Merge pull request #81 from sashamelentyev/feat/forstmt

feat: add check forstmt

Author: sashamelentyev

pkg/analyzer/analyzer.go

@@ -63,6 +63,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
 		(*ast.CompositeLit)(nil),
 		(*ast.IfStmt)(nil),
 		(*ast.SwitchStmt)(nil),
+		(*ast.ForStmt)(nil),
 	}
 
 	insp.Preorder(types, func(node ast.Node) {
@@ -138,6 +139,24 @@ func run(pass *analysis.Pass) (interface{}, error) {
 			} else {
 				switchStmtAsIfElseStmt(pass, n.Body.List)
 			}
+
+		case *ast.ForStmt:
+			cond, ok := n.Cond.(*ast.BinaryExpr)
+			if !ok {
+				return
+			}
+
+			x, ok := cond.X.(*ast.SelectorExpr)
+			if !ok {
+				return
+			}
+
+			y, ok := cond.Y.(*ast.BasicLit)
+			if !ok {
+				return
+			}
+
+			ifElseStmt(pass, x, y)
 		}
 	})
 

pkg/analyzer/internal/gen.go

@@ -50,8 +50,8 @@ func main() {
 		{
 			mapping:      mapping.HTTPStatusCode,
 			packageName:  "http_test",
-			templateName: "test-httpstatuscode.go.tmpl",
-			fileName:     "pkg/analyzer/testdata/src/a/http/statuscode.go",
+			templateName: "test-httpstatus.go.tmpl",
+			fileName:     "pkg/analyzer/testdata/src/a/http/status.go",
 		},
 		{
 			mapping:      mapping.RPCDefaultPath,

pkg/analyzer/internal/template/test-httpmethod.go.tmpl

@@ -53,6 +53,11 @@ func _() error {
     if resp.Request.Method == "{{ $key }}" { // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
         return nil
     }
+{{- end }}
+{{- range $key, $value := .Mapping }}
+    for resp.Request.Method == "{{ $key }}" { // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+        return nil
+    }
 {{- end }}
     return nil
 }
@@ -67,6 +72,11 @@ func _() error {
     if resp.Request.Method == {{ $value }} {
         return nil
     }
+{{- end }}
+{{- range $key, $value := .Mapping }}
+    for resp.Request.Method == {{ $value }} {
+        return nil
+    }
 {{- end }}
     return nil
 }

pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl renamed to pkg/analyzer/internal/template/test-httpstatus.go.tmpl

@@ -69,6 +69,11 @@ func _() error {
     } else if resp.StatusCode == {{ $key }} { // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
         return nil
     }
+{{- end }}
+{{- range $key, $value := .Mapping }}
+    for resp.StatusCode == {{ $key }} { // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+        return nil
+    }
 {{- end }}
     return nil
 }
@@ -85,6 +90,11 @@ func _() error {
     } else if resp.StatusCode == {{ $value }} {
         return nil
     }
+{{- end }}
+{{- range $key, $value := .Mapping }}
+    for resp.StatusCode == {{ $value }} {
+        return nil
+    }
 {{- end }}
     return nil
 }