Skip to content

Commit 8b9d590

Browse files
Remove range uses case in HTTP status (#90)
Remove range uses case in HTTP status
1 parent c561d44 commit 8b9d590

File tree

7 files changed

+1317
-10
lines changed

7 files changed

+1317
-10
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
branches: [ main ]
88

99
env:
10-
GO_VERSION: 1.19.4
10+
GO_VERSION: 1.20.1
1111

1212
jobs:
1313
run:

go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ module github.com/sashamelentyev/usestdlibvars
22

33
go 1.19
44

5-
require golang.org/x/tools v0.5.0
5+
require golang.org/x/tools v0.6.0
66

77
require (
8-
golang.org/x/mod v0.7.0 // indirect
9-
golang.org/x/sys v0.4.0 // indirect
8+
golang.org/x/mod v0.8.0 // indirect
9+
golang.org/x/sys v0.5.0 // indirect
1010
)

go.sum

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
golang.org/x/mod v0.7.0 h1:LapD9S96VoQRhi/GrNTqeBJFrUjs5UHCAtTlgwA5oZA=
2-
golang.org/x/mod v0.7.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
1+
golang.org/x/mod v0.8.0 h1:LUYupSeNrTNCGzR/hVBk2NHZO4hXcVaW1k4Qx7rjPx8=
2+
golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
33
golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o=
4-
golang.org/x/sys v0.4.0 h1:Zr2JFtRQNX3BCZ8YtxRE9hNJYC8J6I1MVbMg6owUp18=
5-
golang.org/x/sys v0.4.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
6-
golang.org/x/tools v0.5.0 h1:+bSpV5HIeWkuvgaMfI3UmKRThoTA5ODJTUd8T17NO+4=
7-
golang.org/x/tools v0.5.0/go.mod h1:N+Kgy78s5I24c24dU8OfWNEotWjutIs8SnJvn5IDq+k=
4+
golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU=
5+
golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
6+
golang.org/x/tools v0.6.0 h1:BOw41kyTf3PuCW1pVQf8+Cyg8pMlkYB1oo9iJ6D/lKM=
7+
golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=

pkg/analyzer/analyzer.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,11 @@ func run(pass *analysis.Pass) (interface{}, error) {
122122
return
123123
}
124124

125+
switch cond.Op {
126+
case token.LSS, token.GTR, token.LEQ, token.GEQ:
127+
return
128+
}
129+
125130
x, ok := cond.X.(*ast.SelectorExpr)
126131
if !ok {
127132
return

pkg/analyzer/internal/gen.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,12 @@ func main() {
101101
templateName: "test-template.go.tmpl",
102102
fileName: "pkg/analyzer/testdata/src/a/constant/kind.go",
103103
},
104+
{
105+
mapping: mapping.HTTPStatusCode,
106+
packageName: "http_test",
107+
templateName: "test-issue89.go.tmpl",
108+
fileName: "pkg/analyzer/testdata/src/a/http/issue89.go",
109+
},
104110
}
105111

106112
for _, operation := range operations {
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
// Code generated by usestdlibvars, DO NOT EDIT.
2+
3+
package {{ .PackageName }}
4+
5+
import "net/http"
6+
7+
func _() error {
8+
resp, err := http.DefaultClient.Do(&http.Request{})
9+
if err != nil {
10+
return err
11+
}
12+
defer func() { _ = resp.Body.Close() }()
13+
{{- range $key, $value := .Mapping }}
14+
if resp.StatusCode < {{ $key }} {
15+
return nil
16+
} else if resp.StatusCode < {{ $key }} {
17+
return nil
18+
}
19+
{{- end }}
20+
{{- range $key, $value := .Mapping }}
21+
if resp.StatusCode > {{ $key }} {
22+
return nil
23+
} else if resp.StatusCode > {{ $key }} {
24+
return nil
25+
}
26+
{{- end }}
27+
{{- range $key, $value := .Mapping }}
28+
if resp.StatusCode <= {{ $key }} {
29+
return nil
30+
} else if resp.StatusCode < {{ $key }} {
31+
return nil
32+
}
33+
{{- end }}
34+
{{- range $key, $value := .Mapping }}
35+
if resp.StatusCode >= {{ $key }} {
36+
return nil
37+
} else if resp.StatusCode > {{ $key }} {
38+
return nil
39+
}
40+
{{- end }}
41+
return nil
42+
}

0 commit comments

Comments
 (0)