Merge pull request #33 from sashamelentyev/fix/issue32

fix: convert HTTP method current value to upper

Author: sashamelentyev

pkg/analyzer/analyzer.go

@@ -158,7 +158,7 @@ func lookupFlag(pass *analysis.Pass, name string) bool {
 }
 
 func checkHTTPMethod(pass *analysis.Pass, basicLit *ast.BasicLit) {
-	currentVal := getBasicLitValue(basicLit)
+	currentVal := strings.ToUpper(getBasicLitValue(basicLit))
 
 	if newVal, ok := mapping.HTTPMethod[currentVal]; ok {
 		report(pass, basicLit.Pos(), currentVal, newVal)

pkg/analyzer/internal/gen.go

@@ -10,6 +10,7 @@ import (
 	"log"
 	"os"
 	"regexp"
+	"strings"
 	"text/template"
 
 	"github.com/sashamelentyev/usestdlibvars/pkg/analyzer/internal/mapping"
@@ -21,7 +22,10 @@ var templateDir embed.FS
 func main() {
 	t := template.Must(
 		template.New("template").
-			Funcs(map[string]any{"quoteMeta": regexp.QuoteMeta}).
+			Funcs(map[string]any{
+				"quoteMeta": regexp.QuoteMeta,
+				"lower":     strings.ToLower,
+			}).
 			ParseFS(templateDir, "template/*.tmpl"),
 	)
 
@@ -73,6 +77,12 @@ func main() {
 			templateName: "test-template.go.tmpl",
 			fileName:     "pkg/analyzer/testdata/src/a/time/layout.go",
 		},
+		{
+			mapping:      mapping.HTTPMethod,
+			packageName:  "http_test",
+			templateName: "test-issue32.go.tmpl",
+			fileName:     "pkg/analyzer/testdata/src/a/http/issue32.go",
+		},
 	}
 
 	for _, operation := range operations {

pkg/analyzer/internal/template/test-issue32.go.tmpl

@@ -0,0 +1,37 @@
+// Code generated by usestdlibvars, DO NOT EDIT.
+
+package {{ .PackageName }}
+
+import "net/http"
+
+var (
+{{- range $key, $value := .Mapping }}
+	_ = "{{ lower $key }}"
+{{- end }}
+)
+
+const (
+{{- range $key, $value := .Mapping }}
+	_ = "{{ lower $key }}"
+{{- end }}
+)
+
+func _() {
+{{- range $key, $value := .Mapping }}
+	_, _ = http.NewRequest("{{ lower $key }}", "", nil) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+{{- end }}
+}
+
+func _() {
+{{- range $key, $value := .Mapping }}
+	_, _ = http.NewRequestWithContext(nil, "{{ lower $key }}", "", nil) // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+{{- end }}
+}
+
+func _() {
+{{- range $key, $value := .Mapping }}
+	_ = &http.Request{
+		Method: "{{ lower $key }}", // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+	}
+{{- end }}
+}