Skip to content

Commit 018e855

Browse files
Merge pull request #84 from sashamelentyev/flag-in-switchstmt
Move check syslog priority flag upper
2 parents 668dba9 + 2da88e8 commit 018e855

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

pkg/analyzer/analyzer.go

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -241,28 +241,22 @@ func funArgs(pass *analysis.Pass, x *ast.Ident, fun *ast.SelectorExpr, args []as
241241
}
242242
}
243243
case "syslog":
244+
if !lookupFlag(pass, SyslogPriorityFlag) {
245+
return
246+
}
247+
244248
switch fun.Sel.Name {
245249
case "New":
246-
if !lookupFlag(pass, SyslogPriorityFlag) {
247-
return
248-
}
249-
250250
if basicLit := getBasicLitFromArgs(args, 2, 0, token.INT); basicLit != nil {
251251
checkSyslogPriority(pass, basicLit)
252252
}
253-
case "Dial":
254-
if !lookupFlag(pass, SyslogPriorityFlag) {
255-
return
256-
}
257253

254+
case "Dial":
258255
if basicLit := getBasicLitFromArgs(args, 4, 2, token.INT); basicLit != nil {
259256
checkSyslogPriority(pass, basicLit)
260257
}
261-
case "NewLogger":
262-
if !lookupFlag(pass, SyslogPriorityFlag) {
263-
return
264-
}
265258

259+
case "NewLogger":
266260
if basicLit := getBasicLitFromArgs(args, 2, 0, token.INT); basicLit != nil {
267261
checkSyslogPriority(pass, basicLit)
268262
}

0 commit comments

Comments
 (0)