Skip to content

Commit 07abed5

Browse files
author
Junya Hayashi
committed
FIX: Fixed some issues around vb_suite
* temporary variable ``bmark`` in groupby was collected as Benchmark * indexing module had same name ('series_getitem_scalar') Benchmarks * VB_DIR pointed wrong directory
1 parent 5fd1fbd commit 07abed5

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

vb_suite/groupby.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,3 +559,6 @@ def inject_bmark_into_globals(bmark):
559559
for func_name in no_arg_func_list:
560560
bmark = make_large_ngroups_bmark(ngroups, func_name)
561561
inject_bmark_into_globals(bmark)
562+
563+
# avoid bmark to be collected as Benchmark object
564+
del bmark

vb_suite/indexing.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,18 @@
1515
dt = ts.index[500]
1616
"""
1717
statement = "ts[dt]"
18-
1918
bm_getitem = Benchmark(statement, setup, ncalls=100000,
20-
name='series_getitem_scalar')
19+
name='time_series_getitem_scalar')
2120

2221
setup = common_setup + """
2322
index = tm.makeStringIndex(1000)
2423
s = Series(np.random.rand(1000), index=index)
2524
idx = index[100]
2625
"""
2726
statement = "s.get_value(idx)"
28-
bm_df_getitem3 = Benchmark(statement, setup,
29-
name='series_get_value',
30-
start_date=datetime(2011, 11, 12))
27+
bm_get_value = Benchmark(statement, setup,
28+
name='series_get_value',
29+
start_date=datetime(2011, 11, 12))
3130

3231

3332
setup = common_setup + """

vb_suite/test_perf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
from pandas import DataFrame, Series
5757

5858
from suite import REPO_PATH
59-
VB_DIR = os.path.dirname(os.path.abspath(__file__))
59+
VB_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
6060
DEFAULT_MIN_DURATION = 0.01
6161
HEAD_COL="head[ms]"
6262
BASE_COL="base[ms]"
@@ -505,7 +505,7 @@ def main():
505505

506506
print("\n")
507507

508-
# move away from the pandas root dit, to avoid possible import
508+
# move away from the pandas root dir, to avoid possible import
509509
# surprises
510510
os.chdir(os.path.dirname(os.path.abspath(__file__)))
511511

0 commit comments

Comments
 (0)