Skip to content

Commit d3d53b4

Browse files
committed
add window to isInteractive
1 parent f0d2ddb commit d3d53b4

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

__mocks__/genInteractives.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const interactiveElementsMap = {
2222
button: [],
2323
canvas: [],
2424
datalist: [],
25+
dialog: [],
2526
embed: [],
2627
input: [],
2728
'input[type="button"]': [{ prop: 'type', value: 'button' }],
@@ -71,7 +72,6 @@ const nonInteractiveElementsMap: {[string]: Array<{[string]: string}>} = {
7172
dd: [],
7273
details: [],
7374
dfn: [],
74-
dialog: [],
7575
dir: [],
7676
dl: [],
7777
dt: [],

src/util/isInteractiveElement.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const nonInteractiveRoles = new Set(roleKeys
2727
// 'toolbar' does not descend from widget, but it does support
2828
// aria-activedescendant, thus in practice we treat it as a widget.
2929
&& name !== 'toolbar'
30-
&& !role.superClass.some((classes) => includes(classes, 'widget'))
30+
&& !role.superClass.some((classes) => includes(classes, 'widget', 'window'))
3131
);
3232
}).concat(
3333
// The `progressbar` is descended from `widget`, but in practice, its

src/util/isInteractiveRole.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import flatMap from 'array.prototype.flatmap';
88
const roles = [...rolesMap.keys()];
99
const interactiveRoles = roles.filter((name) => (
1010
!rolesMap.get(name).abstract
11-
&& rolesMap.get(name).superClass.some((klasses) => includes(klasses, 'widget'))
11+
&& rolesMap.get(name).superClass.some((klasses) => includes(klasses, 'widget', `window`))
1212
));
1313

1414
// 'toolbar' does not descend from widget, but it does support

0 commit comments

Comments
 (0)