integration tests: test SmbShares enabling grouping and clustering

The existing tests only checked that share grouping functioned with
simple single-server deployment based instances. This new test case
checks that the combination of the ctdb enabled clustering mode
and explicit grouping mode works.

Signed-off-by: John Mulligan <[email protected]>

Author: phlogistonjohn

tests/files/cross-pvc2.yaml

@@ -0,0 +1,12 @@
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: cross-pvc2
+spec:
+  accessModes:
+    - ReadWriteMany
+  resources:
+    requests:
+      storage: 100Mi
+  volumeMode: Filesystem

tests/files/cross-share1ctdb.yaml

@@ -0,0 +1,21 @@
+---
+apiVersion: samba-operator.samba.org/v1alpha1
+kind: SmbShare
+metadata:
+  name: cross-share1ctdb
+  annotations:
+    samba-operator.samba.org/node-spread: "false"
+spec:
+  shareName: "Ecks Cee One"
+  readOnly: false
+  browseable: true
+  securityConfig: sharesec1
+  scaling:
+    availabilityMode: clustered
+    minClusterSize: 3
+    groupMode: explicit
+    group: cross-clust
+  storage:
+    pvc:
+      name: cross-pvc2
+      path: one

tests/files/cross-share2ctdb.yaml

@@ -0,0 +1,21 @@
+---
+apiVersion: samba-operator.samba.org/v1alpha1
+kind: SmbShare
+metadata:
+  name: cross-share2ctdb
+  annotations:
+    samba-operator.samba.org/node-spread: "false"
+spec:
+  shareName: "Ecks Cee Two"
+  readOnly: false
+  browseable: true
+  securityConfig: sharesec1
+  scaling:
+    availabilityMode: clustered
+    minClusterSize: 3
+    groupMode: explicit
+    group: cross-clust
+  storage:
+    pvc:
+      name: cross-pvc2
+      path: two

tests/integration/grouped_test.go

@@ -80,7 +80,7 @@ func (s *GroupedSharesSuite) SetupTest() {
 	defer cancel()
 	s.serverGroupName = s.getServerGroupName(ctx)
 	require.NoError(waitForPodExist(ctx, s), "smb server pod does not exist")
-	require.NoError(waitForPodReady(ctx, s), "smb server pod is not ready")
+	require.NoError(waitForAllPodReady(ctx, s), "smb server pod is not ready")
 }
 
 func (s *GroupedSharesSuite) TearDownSuite() {
@@ -666,4 +666,50 @@ func init() {
 		},
 		destNamespace: testNamespace,
 	})
+	if testClusteredShares {
+		groupedSharesTest.AddSuite("clustered", &GroupedSharesSuite{
+			commonSources: []kube.FileSource{
+				{
+					Path:      path.Join(testFilesDir, "userssecret1.yaml"),
+					Namespace: testNamespace,
+				},
+				{
+					Path:      path.Join(testFilesDir, "smbsecurityconfig1.yaml"),
+					Namespace: testNamespace,
+				},
+				{
+					Path:      path.Join(testFilesDir, "cross-pvc2.yaml"),
+					Namespace: testNamespace,
+				},
+			},
+			smbShareSources: []kube.FileSource{
+				{
+					Path:      path.Join(testFilesDir, "cross-share1ctdb.yaml"),
+					Namespace: testNamespace,
+				},
+				{
+					Path:      path.Join(testFilesDir, "cross-share2ctdb.yaml"),
+					Namespace: testNamespace,
+				},
+			},
+			toDelete: []types.NamespacedName{
+				{Namespace: testNamespace, Name: "cross-share2ctdb"},
+			},
+			phaseOneShareNames: []string{
+				"Ecks Cee One",
+				"Ecks Cee Two",
+			},
+			phaseTwoShareNames: []string{
+				"Ecks Cee One",
+			},
+			goneShareName: "Ecks Cee Two", // only specify one share that was removed
+			testAuths: []smbclient.Auth{{
+				Username: "sambauser",
+				Password: "1nsecurely",
+			}},
+			destNamespace: testNamespace,
+			maxPods:       3,
+			minPods:       2,
+		})
+	}
 }