hack: Bump golangci-lint to v1.60.2

- The linter 'exportloopref' is deprecated (since v1.60.2) due to:
  Since Go1.22 (loopvar) this linter is no longer relevant. Replaced
  by copyloopvar.
- The linter named \"megacheck\" is deprecated. It has been split into:
  gosimple, staticcheck, unused.
- The configuration option `linters.govet.check-shadowing` is
  deprecated. Please enable `shadow` instead, if you are not using
  `enable-all`.

Also fixes all occurrence of "Error: printf: non-constant format string
in call to fmt.Errorf (govet)" error.

Signed-off-by: Anoop C S <[email protected]>

Author: anoopcs9

.golangci.yaml

@@ -9,7 +9,6 @@ linters:
     - dupl
     - errcheck
     - exhaustive
-    - exportloopref
     - funlen
     # - gci
     - goconst
@@ -23,7 +22,6 @@ linters:
     # - ineffassign
     # - ifshort
     - lll
-    - megacheck
     - misspell
     # - nlreturn
     # - nolintlint
@@ -42,7 +40,6 @@ linters-settings:
     lines: 188
     statements: 60
   govet:
-    check-shadowing: true
     enable-all: true
     disable:
       - fieldalignment

hack/install-tools.sh

@@ -44,7 +44,7 @@ _install_revive() {
 }
 
 _install_golangci_lint() {
-	_install_tool github.com/golangci/golangci-lint/cmd/golangci-lint@v1.53.3
+	_install_tool github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.2
 }
 
 _install_yq() {

internal/resources/smbshare.go

@@ -851,7 +851,7 @@ func (m *SmbShareManager) setServerGroup(
 				EventWarning,
 				ReasonInvalidConfiguration,
 				msg)
-			return false, fmt.Errorf(msg)
+			return false, fmt.Errorf("%s", msg)
 		}
 	case pln.GroupModeExplicit:
 		if reqGroupName == "" {
@@ -861,7 +861,7 @@ func (m *SmbShareManager) setServerGroup(
 				EventWarning,
 				ReasonInvalidConfiguration,
 				msg)
-			return false, fmt.Errorf(msg)
+			return false, fmt.Errorf("%s", msg)
 		}
 		serverGroup = reqGroupName
 	default:
@@ -871,7 +871,7 @@ func (m *SmbShareManager) setServerGroup(
 			EventWarning,
 			ReasonInvalidConfiguration,
 			msg)
-		return false, fmt.Errorf(msg)
+		return false, fmt.Errorf("%s", msg)
 	}
 
 	s.Status.ServerGroup = serverGroup