resources: verbose logging upon smbshare completion

synarete · mergify[bot] · commit 5903b749242d · 2023-03-23T15:01:25.000Z
A user may define multiple smbshares within different namespace, where
each has its own reconcile cycle. Have more details in completion log
message so that developer may know exactly which smbshare completed.

Signed-off-by: Shachar Sharon &lt;ssharon@redhat.com&gt;
diff --git a/internal/resources/smbshare.go b/internal/resources/smbshare.go
@@ -184,7 +184,11 @@ func (m *SmbShareManager) Update(
 		return result
 	}
 
-	m.logger.Info("Done updating SmbShare resources")
+	m.logger.Info(
+		"Done updating SmbShare resources",
+		"SmbShare.Namespace", instance.Namespace,
+		"SmbShare.Name", instance.Name,
+		"Annotations", instance.Annotations)
 	return Done
 }
 

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,11 @@ func (m *SmbShareManager) Update(`
`184`	`184`	`return result`
`185`	`185`	`}`
`186`	`186`
`187`		`- m.logger.Info("Done updating SmbShare resources")`
	`187`	`+ m.logger.Info(`
	`188`	`+ "Done updating SmbShare resources",`
	`189`	`+ "SmbShare.Namespace", instance.Namespace,`
	`190`	`+ "SmbShare.Name", instance.Name,`
	`191`	`+ "Annotations", instance.Annotations)`
`188`	`192`	`return Done`
`189`	`193`	`}`
`190`	`194`