hack: Fix variable reference before assignment

anoopcs9 · mergify[bot] · commit 7c5bb486bbba · 2024-11-27T08:42:11.000Z
Traceback (most recent call last):
  File "/root/master/./hack/build-image", line 726, in &lt;module&gt;
    main()
  File "/root/master/./hack/build-image", line 716, in main
    _action(cli, img)
  File "/root/master/./hack/build-image", line 513, in retag
    container_tag(cli, cid, *tags)
  File "/root/master/./hack/build-image", line 268, in container_tag
    args += [tag] + list(tags)
UnboundLocalError: local variable 'args' referenced before assignment

Signed-off-by: Anoop C S &lt;anoopcs@samba.org&gt;
diff --git a/hack/build-image b/hack/build-image
@@ -265,7 +265,7 @@ def container_tag(cli, target, tag, *tags):
     ]
     if "docker" not in base_args[0]:
         # podman can do it in one command, docker (on github ci) can not
-        args += [tag] + list(tags)
+        args = base_args + [tag] + list(tags)
         run(cli, args, check=True)
         return
     for new_tag in [tag] + list(tags):

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ def container_tag(cli, target, tag, *tags):`
`265`	`265`	`]`
`266`	`266`	`if "docker" not in base_args[0]:`
`267`	`267`	`# podman can do it in one command, docker (on github ci) can not`
`268`		`- args += [tag] + list(tags)`
	`268`	`+ args = base_args + [tag] + list(tags)`
`269`	`269`	`run(cli, args, check=True)`
`270`	`270`	`return`
`271`	`271`	`for new_tag in [tag] + list(tags):`