fix issue with use of new URL so it supports relative url's

- motivated by: jupyterhub/configurable-http-proxy#572 (comment)

Author: williamstein

README.md

@@ -58,6 +58,8 @@ pnpm tsc
 
 and make changes to code under lib/.
 
+Code Style: use prettier with the defaults.
+
 [![Build package and run tests](https://github.com/sagemathinc/http-proxy-3/actions/workflows/test.yml/badge.svg)](https://github.com/sagemathinc/http-proxy-3/actions/workflows/test.yml)
 
 ## User's Guide

lib/http-proxy/index.ts

@@ -27,9 +27,9 @@ export type ProxyTarget = ProxyTargetUrl | ProxyTargetDetailed;
 export type ProxyTargetUrl = URL | string;
 
 export interface ServerOptions {
-  // NOTE: `options.target and `options.forward` cannot be both missing when the 
+  // NOTE: `options.target and `options.forward` cannot be both missing when the
   // actually proxying is called.  However, they can be missing when creating the
-  // proxy server in the first place!  E.g., you could make a proxy server P with 
+  // proxy server in the first place!  E.g., you could make a proxy server P with
   // no options, then use P.web(req,res, {target:...}).
   // URL string to be parsed with the url module.
   target?: ProxyTarget;
@@ -139,7 +139,7 @@ export class ProxyServer extends EventEmitter {
 
         for (const e of ["target", "forward"]) {
           if (typeof requestOptions[e] === "string") {
-            requestOptions[e] = new URL(requestOptions[e]);
+            requestOptions[e] = new URL(requestOptions[e], "http://dummy.org");
           }
         }
 

lib/http-proxy/passes/web-outgoing.ts

@@ -54,12 +54,12 @@ export function setRedirectHostRewrite(
     proxyRes.headers["location"] &&
     redirectRegex.test(`${proxyRes.statusCode}`)
   ) {
-    const target = new URL(options.target);
+    const target = new URL(options.target, "http://dummy.org");
     const location = proxyRes.headers["location"];
     if (typeof location != "string") {
       return;
     }
-    const u = new URL(location);
+    const u = new URL(location, "http://dummy.org");
 
     // make sure the redirected host matches the target host before rewriting
     if (target.host != u.host) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "http-proxy-3",
-  "version": "1.20.1",
+  "version": "1.20.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/sagemathinc/http-proxy-3.git"

test/README.md

@@ -24,6 +24,7 @@ I run these manually before making a release, but not as part of CI. Use
 ```sh
 pnpm test-all
 ```
+
 to include these tests and also pnpm audit.
 
 ## fetch
@@ -48,3 +49,4 @@ These warnings in the test suite are expected, because we're testing ssl using s
 (node:52812) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
 (Use `node --trace-warnings ...` to show where the warning was created)
 ```
+