Skip to content
This repository was archived by the owner on Dec 1, 2019. It is now read-only.

fix: environment cache invalidation #449

Merged
merged 3 commits into from
Jun 28, 2017
Merged

fix: environment cache invalidation #449

merged 3 commits into from
Jun 28, 2017

Conversation

ArgonAlex
Copy link
Contributor

Previously, the setupCache function always returned undefined, so it seems that cache invalidation based on the environment has never worked.

This fixes that bug, and also add and removes some parameters for the cacheIdentifier.

Removes:

Adds:

  • compilerConfig - the typescript compiler configuration
  • babelPkg - babel config in package.json
  • env - process environment variables that babel can potentially use

We should also look up the directory tree for babelrc.js/babelrc.json files, but I think this is at least good start for now.

@s-panferov
Copy link
Owner

Amazing, thanks! I'll look through it at the weekend.

@s-panferov s-panferov merged commit c073af1 into s-panferov:master Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants