This repository was archived by the owner on Dec 1, 2019. It is now read-only.
fix: environment cache invalidation #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
setupCache
function always returnedundefined
, so it seems that cache invalidation based on the environment has never worked.This fixes that bug, and also add and removes some parameters for the cacheIdentifier.
Removes:
awesome-typescript-loader-query
- because this is already included in the cache key elsewhere (https://github.com/s-panferov/awesome-typescript-loader/blob/master/src/cache.ts#L70)Adds:
compilerConfig
- the typescript compiler configurationbabelPkg
- babel config in package.jsonenv
- process environment variables that babel can potentially useWe should also look up the directory tree for
babelrc.js
/babelrc.json
files, but I think this is at least good start for now.