Skip to content
This repository was archived by the owner on Dec 1, 2019. It is now read-only.

Commit f5105f6

Browse files
committed
fix(*): bind resolver to original context for webpack2
1 parent 9aec18b commit f5105f6

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"ps-node": "0.0.5",
6666
"rimraf": "^2.5.0",
6767
"tslint": "3.5.0-dev.1",
68-
"typescript": "^1.9.0-dev.20160319",
68+
"typescript": "^1.9.0-dev.20160330",
6969
"webpack": "2.1.0-beta.4"
7070
}
7171
}

src/deps.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,13 @@ export type Exclude = string[];
2626
export function createResolver(
2727
externals: IExternals,
2828
exclude: Exclude,
29-
webpackResolver: any
29+
webpackResolver: any,
30+
ctx: any = null
3031
): IResolver {
3132
let finalResolver = webpackResolver;
3233
if (webpackResolver.length === 4) {
33-
// patch resolver for webpack2
34-
finalResolver = (path, request, callback) => webpackResolver({}, path, request, callback);
34+
// carrying resolver for webpack2
35+
finalResolver = webpackResolver.bind(ctx, {});
3536
}
3637
let resolver: IResolver = promisify(finalResolver) as any;
3738

src/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ async function compiler(webpack: IWebPack, text: string): Promise<void> {
4444
let resolver = createResolver(
4545
webpack._compiler.options.externals,
4646
state.options.exclude || [],
47-
webpack.resolve
47+
webpack.resolve,
48+
webpack
4849
);
4950

5051
let depsInjector = {

src/instance.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ function setupWatchRun(compiler, instanceName: string) {
280280
let resolver = createResolver(
281281
compiler.options.externals,
282282
state.options.exclude || [],
283-
watching.compiler.resolvers.normal.resolve
283+
watching.compiler.resolvers.normal.resolve,
284+
watching.compiler.resolvers.normal
284285
);
285286
let mtimes = watching.compiler.watchFileSystem.watcher.mtimes;
286287
let changedFiles = Object.keys(mtimes);

0 commit comments

Comments
 (0)