fix: try to fix some places of potential performance degradation, refs #366

Author: s-panferov

src/checker/runtime.ts

@@ -367,7 +367,7 @@ function createChecker(receive: (cb: (msg: Req) => void) => void, send: (msg: Re
 
         const allDiagnostics = program
             .getOptionsDiagnostics().concat(
-                service.getProgram().getGlobalDiagnostics()
+                program.getGlobalDiagnostics()
             );
 
         const nativeGetter = program.getSourceFiles;
@@ -377,8 +377,8 @@ function createChecker(receive: (cb: (msg: Req) => void) => void, send: (msg: Re
             });
         }
 
-        allDiagnostics.push(...service.getProgram().getSyntacticDiagnostics());
-        allDiagnostics.push(...service.getProgram().getSemanticDiagnostics());
+        allDiagnostics.push(...program.getSyntacticDiagnostics());
+        allDiagnostics.push(...program.getSemanticDiagnostics());
 
         program.getSourceFiles = nativeGetter;
 

src/checker/send.ts

@@ -4,42 +4,48 @@ export interface QueuedSender {
     send: (msg: any) => void;
 }
 
+const isWindows = /^win/.test(process.platform);
+const logOnError = error => { if (error) { console.error(error); } };
+
 // Wrapper around process.send() that will queue any messages if the internal node.js
 // queue is filled with messages and only continue sending messages when the internal
 // queue is free again to consume messages.
 // On Windows we always wait for the send() method to return before sending the next message
 // to workaround https://github.com/nodejs/node/issues/7657 (IPC can freeze process)
 export function createQueuedSender(childProcess: ChildProcess | NodeJS.Process): QueuedSender {
-    let msgQueue = [];
-    let isSending = false;
-
-    const doSendLoop = function(): void {
-        const msg = msgQueue.shift();
-
-        childProcess.send(msg, error => {
-            if (error) {
-                console.error(error);
-            }
+    if (isWindows) {
+        let msgQueue = [];
+        let isSending = false;
 
+        const cb = error => {
+            logOnError(error);
             if (msgQueue.length > 0) {
                 setImmediate(doSendLoop);
             } else {
                 isSending = false;
             }
-        });
-    };
+        };
 
-    const send = function (msg: any): void {
-        msgQueue.push(msg); // add to the queue if the process cannot handle more messages
+        const doSendLoop = function(): void {
+            childProcess.send(msgQueue.shift(), cb);
+        };
 
-        if (isSending) {
-            return;
-        }
+        const send = function (msg: any): void {
+            msgQueue.push(msg); // add to the queue if the process cannot handle more messages
+            if (isSending) {
+                return;
+            }
 
-        isSending = true;
+            isSending = true;
+            doSendLoop();
+        };
 
-        doSendLoop();
-    };
+        return { send };
+    } else {
+        const send = function (msg: any): void {
+            childProcess.send(msg, logOnError);
+        };
 
-    return { send };
+        return { send };
+    }
 }