Skip to content

Commit baae5fc

Browse files
authored
Completely disable Web tests on Windows (#486)
`continue-on-error` does not work as I was expecting. AFAIK GitHub Action does not have a straightforward solution for optionally failing jobs, see: actions/runner#2347 Closes #400
1 parent f345775 commit baae5fc

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

.github/workflows/tests.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,13 +225,12 @@ jobs:
225225
include:
226226
- os: ubuntu-22.04
227227
host: x86_64-unknown-linux-musl
228-
- os: windows-2022
229-
host: x86_64-pc-windows-msvc
230-
# We get spurious failures on Windows, see:
231-
# https://github.com/rust-random/getrandom/issues/400
232-
continue-on-error: true
233228
- os: macos-12
234229
host: x86_64-apple-darwin
230+
# We get spurious failures on Windows, see:
231+
# https://github.com/rust-random/getrandom/issues/400
232+
# - os: windows-2022
233+
# host: x86_64-pc-windows-msvc
235234
runs-on: ${{ matrix.os }}
236235
steps:
237236
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)