Skip to content

Evaluate Interface for Custom Tags #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phip1611 opened this issue Sep 12, 2022 · 3 comments · Fixed by #118
Closed

Evaluate Interface for Custom Tags #116

phip1611 opened this issue Sep 12, 2022 · 3 comments · Fixed by #118

Comments

@phip1611
Copy link
Member

I've seen people using custom Multiboot2 tags to transfer data from a custom bootloader to their kernel. We should evaluate if and how we want or can support this.

@blitz
Copy link

blitz commented Oct 6, 2022

To formulate this as a usecase: As a user of this library I would like to be able to support custom tags. The library should not limit the user to the tags in the current spec and allow the user to define completely custom tags.

@IsaacWoods
Copy link
Member

I think this could be achieved fairly easily by exposing BootInformation::get_tag (which imo should be renamed tag but that's a nit) and reworking TagType to support custom values (e.g. remove the repr(u32), add a Custom(u32) variant, and adding manual From<u32> and Into<u32> impls)?

@phip1611
Copy link
Member Author

Closed with #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants