Remove rls.root option

rls.path is a better option, we don't need two ways and I don't think anyone uses this one any more

Author: nrc

contributing.md

@@ -27,14 +27,8 @@ from https://www.rustup.rs/.
 ### Via Source
 
 Check out the RLS source code, following the [directions](https://github.com/rust-lang-nursery/rls/blob/master/contributing.md). 
-For the plugin to find the RLS, set the `rls.root` setting to the
-root of your rls checkout (e.g., `/Source/rls`):
-
-
-### Via an executable
-
-Similar to above, but use the `rls.path` and point it at the RLS executable
-(e.g., `/rls/target/release/rls`). Note that you must include the name of the
+Point the `rls.path` setting at the RLS executable (e.g.,
+`/rls/target/release/rls`). Note that you must include the name of the
 executable, not just the path.
 
 

src/configuration.ts

@@ -41,12 +41,6 @@ export class RLSConfiguration {
      * specified, RLS will be spawned by executing a file at the given path.
      */
     public readonly rlsPath: string | null;
-    /**
-     * Hidden option that can be specified via `"rls.root"` key (e.g. to `/home/<user>/rls/repo`).
-     * If specified, RLS will be spawned by executing `cargo run --release` under a given working
-     * directory.
-     */
-    public readonly rlsRoot: string | null;
 
     public static loadFromWorkspace(): RLSConfiguration {
         const configuration = workspace.getConfiguration();
@@ -65,7 +59,6 @@ export class RLSConfiguration {
 
         // Hidden options that are not exposed to the user
         this.rlsPath = configuration.get('rls.path', null);
-        this.rlsRoot = configuration.get('rls.root', null);
     }
 
     private static readRevealOutputChannelOn(configuration: WorkspaceConfiguration) {

src/extension.ts

@@ -81,20 +81,12 @@ async function makeRlsEnv(setLibPath = false): Promise<any> {
 async function makeRlsProcess(): Promise<child_process.ChildProcess> {
     // Allow to override how RLS is started up.
     const rls_path = CONFIGURATION.rlsPath;
-    const rls_root = CONFIGURATION.rlsRoot;
 
     let childProcessPromise: Promise<child_process.ChildProcess>;
     if (rls_path) {
         const env = await makeRlsEnv(true);
         console.info('running ' + rls_path);
         childProcessPromise = Promise.resolve(child_process.spawn(rls_path, [], { env }));
-    } else if (rls_root) {
-        const env = await makeRlsEnv();
-        console.info('running `cargo run` in ' + rls_root);
-        childProcessPromise = Promise.resolve(child_process.spawn(
-            CONFIGURATION.rustupPath, ['run', CONFIGURATION.channel, 'cargo', 'run', '--release'],
-            { cwd: rls_root, env })
-        );
     } else {
         const env = await makeRlsEnv();
         console.info('running with rustup');