Skip to content

Miri errors link to wip/stacked-borrows.md, which is no longer accurate #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
saethlin opened this issue Aug 27, 2022 · 2 comments · Fixed by #359
Closed
3 tasks

Miri errors link to wip/stacked-borrows.md, which is no longer accurate #358

saethlin opened this issue Aug 27, 2022 · 2 comments · Fixed by #359

Comments

@saethlin
Copy link
Member

saethlin commented Aug 27, 2022 •
edited
Loading

Things I noticed on a quick skim just now

  • Mentions of Untagged and no explanation of Wildcard
  • Copy+paste of the old code inside Miri (should probably become pseudocode or paste the new code)
  • "We do not recurse into fields of structs or other compound types" but we have -Zmiri-retag-fields
@RalfJung
Copy link
Member

I don't think that page should explain Wildcard. Wildcard is not part of the Stacked Borrows specification. It is part of Miri's approximation for the semantics of from_exposed_addr.

@RalfJung
Copy link
Member

Copy+paste of the old code inside Miri (should probably become pseudocode or paste the new code)

The code still describes behavior correctly, and is simpler than the new code, so I don't see this as a bug, and I see it as a feature.

@RalfJung RalfJung mentioned this issue Aug 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Stacked borrows documentation RalfJung/unsafe-code-guidelines
2 participants
@RalfJung @saethlin