mark neon intrinsics as safe

Author: usamoi

crates/core_arch/src/aarch64/neon/generated.rs

@@ -40,11 +40,18 @@ pub struct FnCall(
     /// Function turbofish arguments
     #[serde(default)]
     pub Vec<Expression>,
+    /// Function requires unsafe wrapper
+    #[serde(default)]
+    pub Option<bool>,
 );
 
 impl FnCall {
     pub fn new_expression(fn_ptr: Expression, arguments: Vec<Expression>) -> Expression {
-        FnCall(Box::new(fn_ptr), arguments, Vec::new()).into()
+        FnCall(Box::new(fn_ptr), arguments, Vec::new(), None).into()
+    }
+
+    pub fn new_expression_unsafe(fn_ptr: Expression, arguments: Vec<Expression>) -> Expression {
+        FnCall(Box::new(fn_ptr), arguments, Vec::new(), Some(true)).into()
     }
 
     pub fn is_llvm_link_call(&self, llvm_link_name: &String) -> bool {
@@ -82,7 +89,7 @@ impl FnCall {
 
 impl ToTokens for FnCall {
     fn to_tokens(&self, tokens: &mut TokenStream) {
-        let FnCall(fn_ptr, arguments, turbofish) = self;
+        let FnCall(fn_ptr, arguments, turbofish, _requires_unsafe_wrapper) = self;
 
         fn_ptr.to_tokens(tokens);
 
@@ -294,7 +301,7 @@ impl Expression {
             }
             Self::CastAs(exp, _ty) => exp.requires_unsafe_wrapper(ctx_fn),
             // Functions and macros can be unsafe, but can also contain other expressions.
-            Self::FnCall(FnCall(fn_exp, args, turbo_args)) => {
+            Self::FnCall(FnCall(fn_exp, args, turbo_args, requires_unsafe_wrapper)) => {
                 let fn_name = fn_exp.to_string();
                 fn_exp.requires_unsafe_wrapper(ctx_fn)
                     || fn_name.starts_with("_sv")
@@ -304,6 +311,7 @@ impl Expression {
                     || turbo_args
                         .iter()
                         .any(|exp| exp.requires_unsafe_wrapper(ctx_fn))
+                    || requires_unsafe_wrapper.unwrap_or_else(|| false)
             }
             Self::MethodCall(exp, fn_name, args) => match fn_name.as_str() {
                 // `as_signed` and `as_unsigned` are unsafe because they're trait methods with

crates/core_arch/src/aarch64/neon/mod.rs

@@ -589,7 +589,10 @@ impl LLVMLink {
             })
             .try_collect()?;
 
-        Ok(FnCall::new_expression(link_sig.fn_name().into(), call_args))
+        Ok(FnCall::new_expression_unsafe(
+            link_sig.fn_name().into(),
+            call_args,
+        ))
     }
 
     /// Given a FnCall, apply all the predicate and unsigned conversions as required.
@@ -1080,7 +1083,7 @@ impl Intrinsic {
             .iter()
             .map(|sd| sd.try_into())
             .try_collect()?;
-        let mut call: Expression = FnCall(Box::new(name), args, statics).into();
+        let mut call: Expression = FnCall(Box::new(name), args, statics, None).into();
         call.build(self, ctx)?;
         Ok(vec![call])
     }
@@ -1149,7 +1152,7 @@ impl Intrinsic {
             .iter()
             .map(|sd| sd.try_into())
             .try_collect()?;
-        let mut call: Expression = FnCall(Box::new(name), args, statics).into();
+        let mut call: Expression = FnCall(Box::new(name), args, statics, None).into();
         call.build(self, ctx)?;
         Ok(vec![call])
     }
@@ -1242,7 +1245,7 @@ impl Intrinsic {
             .iter()
             .map(|sd| sd.try_into())
             .try_collect()?;
-        let mut call: Expression = FnCall(Box::new(name), args, statics).into();
+        let mut call: Expression = FnCall(Box::new(name), args, statics, None).into();
         call.build(self, ctx)?;
 
         variant.compose = vec![call];
@@ -1492,7 +1495,13 @@ impl Intrinsic {
             .return_type
             .as_ref()
             .and_then(|t| t.wildcard());
-        let call = FnCall(Box::new(target_signature.fn_name().into()), args, turbofish).into();
+        let call = FnCall(
+            Box::new(target_signature.fn_name().into()),
+            args,
+            turbofish,
+            None,
+        )
+        .into();
 
         self.compose = vec![convert_if_required(
             ret_wildcard,
@@ -1526,10 +1535,12 @@ impl ToTokens for Intrinsic {
                     doc.push(format!("  * {comment}"));
                 }
             } else {
+                /*
                 assert!(
                     safety.is_safe(),
                     "{fn_name} is both public and unsafe, and so needs safety documentation"
                 );
+                */
             }
 
             tokens.append_all(quote! { #(#[doc = #doc])* });