Skip to content

Commit ced20ea

Browse files
committed
Add some info for reviewers.
1 parent 9c201b6 commit ced20ea

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

src/team/reviewing.md

+11
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ But please keep in mind:
1717
Make sure to involve `@rust-lang/libs-api` on such changes.
1818
- Always be polite when reviewing: you are a representative of the Rust project, so it is expected that you will go above and beyond when it comes to the Code of Conduct.
1919

20+
See https://forge.rust-lang.org/compiler/reviews.html for more information on reviewing.
21+
2022
## High-five rotation
2123

2224
Some of the members of the team are part of the 'high-five rotation';
@@ -34,3 +36,12 @@ If you find yourself unable to do any reviews for an extended period of time,
3436
it might be a good idea to (temporarily) remove yourself from the list.
3537
To add or remove yourself from the list, send a PR to change the
3638
[triagebot configuration file](https://github.com/rust-lang/rust/blob/master/triagebot.toml).
39+
40+
## Rolling up
41+
42+
For library PRs, rolling up (`@bors r+ rollup`) is often fine,
43+
in particular if it's only a new unstable addition or if it only touches docs.
44+
PRs that impact performance should not be rolled up (`@bors rollup=never`),
45+
PRs with subtle platform specific changes might also not be great candiates for rolling up.
46+
See the [rollup guidelines](https://forge.rust-lang.org/compiler/reviews.html#rollups) for more
47+
details on when to rollup.

0 commit comments

Comments
 (0)