You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: src/feature-lifecycle/summary.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -17,7 +17,7 @@ APIs that are well suited to the standard library are things that require langua
17
17
The API Change Proposal process is intended to be a lightweight first step to
18
18
getting new APIs added to the standard library. The goal of this process is to
19
19
make sure proposed API changes have the best chance of success. The ACP process
20
-
accomplishes this by ensuring all changes are reviewed by the library team,
20
+
accomplishes this by ensuring all changes are reviewed by the library API team,
21
21
who will evaluate the proposal and accept it if they are optimistic that the proposal will
22
22
be merged and pass its eventual FCP.
23
23
@@ -28,7 +28,7 @@ You can create an ACP in the `rust-lang/libs-team` repo using [this issue templa
28
28
Once a feature is deemed suitable for inclusion in the standard library, the exact design should be iterated on to find the best way to express it as a Rust API. This iteration should happen in community forums such as [Rust internals](https://internals.rust-lang.org/) where all members of the community can comment and propose improvements.
29
29
30
30
Keep the following points in mind during the discussion:
31
-
- Resist the temptation to make the API overly general since this tends to increase complexity and lowers the chance of it being accepted by the library team. Instead, try to stay focused on the problem that needs solving.
31
+
- Resist the temptation to make the API overly general since this tends to increase complexity and lowers the chance of it being accepted by the library API team. Instead, try to stay focused on the problem that needs solving.
32
32
- An alternative that should *always* be considered is simply adding this feature via a third party crate. This is even possible when adding new methods to standard library types by using extension traits.
33
33
- In the case of "convenience" functions which are simply shorthands for something that is already possible with existing APIs, the cost of extending the standard library surface should be weighed against the ergonomic impact of the new functions.
34
34
@@ -40,7 +40,7 @@ Once the API design space has been explored, an implementation based on the favo
40
40
41
41
The pull request should include a summary of the alternatives that were considered. This is helpful for reviewers since it avoids duplicating this exploration work as part of the review. A PR submitted without this may be closed with a request to explore more alternatives.
42
42
43
-
If an ACP has not been filed for the proposed feature, the PR will need to be reviewed by the library team to determine its suitability for the standard library.
43
+
If an ACP has not been filed for the proposed feature, the PR will need to be reviewed by the library API team to determine its suitability for the standard library.
0 commit comments