Skip to content

Commit b11ec29

Browse files
committed
Address review.
1 parent 8785b70 commit b11ec29

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

Diff for: compiler/rustc_middle/src/dep_graph/dep_node.rs

-7
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,6 @@ pub struct DepKindStruct {
124124
/// with kind `MirValidated`, we know that the GUID/fingerprint of the `DepNode`
125125
/// is actually a `DefPathHash`, and can therefore just look up the corresponding
126126
/// `DefId` in `tcx.def_path_hash_to_def_id`.
127-
///
128-
/// When you implement a new query, it will likely have a corresponding new
129-
/// `DepKind`, and you'll have to support it here in `force_from_dep_node()`. As
130-
/// a rule of thumb, if your query takes a `DefId` or `LocalDefId` as sole parameter,
131-
/// then `force_from_dep_node()` should not fail for it. Otherwise, you can just
132-
/// add it to the "We don't have enough information to reconstruct..." group in
133-
/// the match below.
134127
pub force_from_dep_node: Option<fn(tcx: TyCtxt<'_>, dep_node: DepNode) -> bool>,
135128

136129
/// Invoke a query to put the on-disk cached value in memory.

Diff for: compiler/rustc_query_system/src/query/plumbing.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ where
713713
Q::Key: DepNodeParams<CTX::DepContext>,
714714
CTX: QueryContext,
715715
{
716-
debug_assert!(!Q::ANON);
716+
assert!(!Q::ANON);
717717

718718
// We may be concurrently trying both execute and force a query.
719719
// Ensure that only one of them runs the query.

0 commit comments

Comments
 (0)