Skip to content

Commit 7810e02

Browse files
deps: apply upstream rustc-* changes
1 parent f34d1a4 commit 7810e02

File tree

5 files changed

+38
-14
lines changed

5 files changed

+38
-14
lines changed

Diff for: src/config/file_lines.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ impl FileName {
3838
impl From<rustc_span::FileName> for FileName {
3939
fn from(name: rustc_span::FileName) -> FileName {
4040
match name {
41-
rustc_span::FileName::Real(p) => FileName::Real(p),
41+
rustc_span::FileName::Real(p) => FileName::Real(p.into_local_path()),
4242
rustc_span::FileName::Custom(ref f) if f == "stdin" => FileName::Stdin,
4343
_ => unreachable!(),
4444
}
@@ -48,7 +48,9 @@ impl From<rustc_span::FileName> for FileName {
4848
impl From<&FileName> for rustc_span::FileName {
4949
fn from(filename: &FileName) -> rustc_span::FileName {
5050
match filename {
51-
FileName::Real(path) => rustc_span::FileName::Real(path.to_owned()),
51+
FileName::Real(path) => {
52+
rustc_span::FileName::Real(rustc_span::RealFileName::Named(path.to_owned()))
53+
}
5254
FileName::Stdin => rustc_span::FileName::Custom("stdin".to_owned()),
5355
}
5456
}

Diff for: src/formatting/expr.rs

+5-1
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,11 @@ pub(crate) fn format_expr(
322322
}
323323
// We do not format these expressions yet, but they should still
324324
// satisfy our width restrictions.
325-
ast::ExprKind::LlvmInlineAsm(..) => Some(context.snippet(expr.span).to_owned()),
325+
// Style Guide RFC for InlineAsm variant pending
326+
// https://github.com/rust-dev-tools/fmt-rfcs/issues/152
327+
ast::ExprKind::LlvmInlineAsm(..) | ast::ExprKind::InlineAsm(..) => {
328+
Some(context.snippet(expr.span).to_owned())
329+
}
326330
ast::ExprKind::TryBlock(ref block) => {
327331
if let rw @ Some(_) =
328332
rewrite_single_line_block(context, "try ", block, Some(&expr.attrs), None, shape)

Diff for: src/formatting/macros.rs

+1
Original file line numberDiff line numberDiff line change
@@ -1230,6 +1230,7 @@ pub(crate) fn convert_try_mac(
12301230
kind: ast::ExprKind::Try(kind),
12311231
span: mac.span(), // incorrect span, but shouldn't matter too much
12321232
attrs: ast::AttrVec::new(),
1233+
tokens: Some(ts),
12331234
})
12341235
} else {
12351236
None

Diff for: src/formatting/syntux/session.rs

+27-11
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ impl Emitter for SilentOnIgnoredFilesEmitter {
6565
}
6666
if let Some(primary_span) = &db.span.primary_span() {
6767
let file_name = self.source_map.span_to_filename(*primary_span);
68-
if let rustc_span::FileName::Real(ref path) = file_name {
68+
if let rustc_span::FileName::Real(rustc_span::RealFileName::Named(ref path)) = file_name
69+
{
6970
if self
7071
.ignore_path_set
7172
.is_match(&FileName::Real(path.to_path_buf()))
@@ -158,7 +159,9 @@ impl ParseSess {
158159
pub(crate) fn is_file_parsed(&self, path: &Path) -> bool {
159160
self.parse_sess
160161
.source_map()
161-
.get_source_file(&rustc_span::FileName::Real(path.to_path_buf()))
162+
.get_source_file(&rustc_span::FileName::Real(
163+
rustc_span::RealFileName::Named(path.to_path_buf()),
164+
))
162165
.is_some()
163166
}
164167

@@ -266,7 +269,7 @@ mod tests {
266269
use crate::config::IgnoreList;
267270
use crate::formatting::utils::mk_sp;
268271
use crate::is_nightly_channel;
269-
use rustc_span::{FileName as SourceMapFileName, MultiSpan, DUMMY_SP};
272+
use rustc_span::{FileName as SourceMapFileName, MultiSpan, RealFileName, DUMMY_SP};
270273
use std::path::PathBuf;
271274

272275
struct TestEmitter {
@@ -326,7 +329,10 @@ mod tests {
326329
let source_map = Rc::new(SourceMap::new(FilePathMapping::empty()));
327330
let source =
328331
String::from(r#"extern "system" fn jni_symbol!( funcName ) ( ... ) -> {} "#);
329-
source_map.new_source_file(SourceMapFileName::Real(PathBuf::from("foo.rs")), source);
332+
source_map.new_source_file(
333+
SourceMapFileName::Real(RealFileName::Named(PathBuf::from("foo.rs"))),
334+
source,
335+
);
330336
let mut emitter = build_emitter(
331337
Rc::clone(&num_emitted_errors),
332338
Rc::clone(&can_reset_errors),
@@ -350,7 +356,10 @@ mod tests {
350356
let ignore_list = get_ignore_list(r#"ignore = ["foo.rs"]"#);
351357
let source_map = Rc::new(SourceMap::new(FilePathMapping::empty()));
352358
let source = String::from(r#"pub fn bar() { 1x; }"#);
353-
source_map.new_source_file(SourceMapFileName::Real(PathBuf::from("foo.rs")), source);
359+
source_map.new_source_file(
360+
SourceMapFileName::Real(RealFileName::Named(PathBuf::from("foo.rs"))),
361+
source,
362+
);
354363
let mut emitter = build_emitter(
355364
Rc::clone(&num_emitted_errors),
356365
Rc::clone(&can_reset_errors),
@@ -373,7 +382,10 @@ mod tests {
373382
let can_reset_errors = Rc::new(RefCell::new(false));
374383
let source_map = Rc::new(SourceMap::new(FilePathMapping::empty()));
375384
let source = String::from(r#"pub fn bar() { 1x; }"#);
376-
source_map.new_source_file(SourceMapFileName::Real(PathBuf::from("foo.rs")), source);
385+
source_map.new_source_file(
386+
SourceMapFileName::Real(RealFileName::Named(PathBuf::from("foo.rs"))),
387+
source,
388+
);
377389
let mut emitter = build_emitter(
378390
Rc::clone(&num_emitted_errors),
379391
Rc::clone(&can_reset_errors),
@@ -400,12 +412,16 @@ mod tests {
400412
let foo_source = String::from(r#"pub fn foo() { 1x; }"#);
401413
let fatal_source =
402414
String::from(r#"extern "system" fn jni_symbol!( funcName ) ( ... ) -> {} "#);
403-
source_map
404-
.new_source_file(SourceMapFileName::Real(PathBuf::from("bar.rs")), bar_source);
405-
source_map
406-
.new_source_file(SourceMapFileName::Real(PathBuf::from("foo.rs")), foo_source);
407415
source_map.new_source_file(
408-
SourceMapFileName::Real(PathBuf::from("fatal.rs")),
416+
SourceMapFileName::Real(RealFileName::Named(PathBuf::from("bar.rs"))),
417+
bar_source,
418+
);
419+
source_map.new_source_file(
420+
SourceMapFileName::Real(RealFileName::Named(PathBuf::from("foo.rs"))),
421+
foo_source,
422+
);
423+
source_map.new_source_file(
424+
SourceMapFileName::Real(RealFileName::Named(PathBuf::from("fatal.rs"))),
409425
fatal_source,
410426
);
411427
let mut emitter = build_emitter(

Diff for: src/formatting/utils.rs

+1
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,7 @@ pub(crate) fn is_block_expr(context: &RewriteContext<'_>, expr: &ast::Expr, repr
496496
| ast::ExprKind::Continue(..)
497497
| ast::ExprKind::Err
498498
| ast::ExprKind::Field(..)
499+
| ast::ExprKind::InlineAsm(..)
499500
| ast::ExprKind::LlvmInlineAsm(..)
500501
| ast::ExprKind::Let(..)
501502
| ast::ExprKind::Path(..)

0 commit comments

Comments
 (0)