Skip to content

Support -Ctarget-feature and target spec target_feature list #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjorn3 opened this issue Aug 18, 2022 · 3 comments · Fixed by #299
Closed

Support -Ctarget-feature and target spec target_feature list #206

bjorn3 opened this issue Aug 18, 2022 · 3 comments · Fixed by #299
Labels
enhancement New feature or request hard libgccjit requires a change in libgccjit

Comments

@bjorn3
Copy link
Member

bjorn3 commented Aug 18, 2022

This is necessary for compiling rust-for-linux with cg_gcc.

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 18, 2022

When trying to disable SSE using -Clink-arg="-mno-sse -msoft-float" I get libgccjit.so: error: SSE register return with SSE disabled by the way.

@antoyo antoyo added enhancement New feature or request hard libgccjit requires a change in libgccjit labels Sep 14, 2022
@antoyo
Copy link
Contributor

antoyo commented Sep 16, 2022

Apparently, there's some CPU feature detection in the D frontend in GCC, so that could be useful as an inspiration for libgccjit.

@philberty also mentioned working on a way to share code across GCC frontends which would also be useful. Did you posted a patch for that somewhere?

@philberty
Copy link

@antoyo My initial patches for this were here:

https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598929.html
https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598928.html

These were kind of pushed back against for being too complex. These patches were pretty much a copy paste for was done in the D front-end.

I spent a lot of time talking to Ian from the D front-end about this issue and he has a new simpler approach let me CC you into an email with him It would be ideal if we could do this once for the rust and jit front-end's :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hard libgccjit requires a change in libgccjit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants