Skip to content

Commit 9ed19dc

Browse files
committed
Use associative type defaults in {Layout,FnAbi}OfHelpers.
This avoids some repetitive boilerplate code.
1 parent 6beb6f8 commit 9ed19dc

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/builder.rs

-5
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ use rustc_middle::bug;
2323
use rustc_middle::middle::codegen_fn_attrs::CodegenFnAttrs;
2424
use rustc_middle::ty::layout::{
2525
FnAbiError, FnAbiOfHelpers, FnAbiRequest, HasParamEnv, HasTyCtxt, LayoutError, LayoutOfHelpers,
26-
TyAndLayout,
2726
};
2827
use rustc_middle::ty::{Instance, ParamEnv, Ty, TyCtxt};
2928
use rustc_span::def_id::DefId;
@@ -473,17 +472,13 @@ impl HasDataLayout for Builder<'_, '_, '_> {
473472
}
474473

475474
impl<'tcx> LayoutOfHelpers<'tcx> for Builder<'_, '_, 'tcx> {
476-
type LayoutOfResult = TyAndLayout<'tcx>;
477-
478475
#[inline]
479476
fn handle_layout_err(&self, err: LayoutError<'tcx>, span: Span, ty: Ty<'tcx>) -> ! {
480477
self.cx.handle_layout_err(err, span, ty)
481478
}
482479
}
483480

484481
impl<'tcx> FnAbiOfHelpers<'tcx> for Builder<'_, '_, 'tcx> {
485-
type FnAbiOfResult = &'tcx FnAbi<'tcx, Ty<'tcx>>;
486-
487482
#[inline]
488483
fn handle_fn_abi_err(
489484
&self,

src/context.rs

+1-6
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,12 @@ use rustc_middle::mir::mono::CodegenUnit;
1212
use rustc_middle::span_bug;
1313
use rustc_middle::ty::layout::{
1414
FnAbiError, FnAbiOf, FnAbiOfHelpers, FnAbiRequest, HasParamEnv, HasTyCtxt, LayoutError,
15-
LayoutOfHelpers, TyAndLayout,
15+
LayoutOfHelpers,
1616
};
1717
use rustc_middle::ty::{self, Instance, ParamEnv, PolyExistentialTraitRef, Ty, TyCtxt};
1818
use rustc_session::Session;
1919
use rustc_span::source_map::respan;
2020
use rustc_span::{Span, DUMMY_SP};
21-
use rustc_target::abi::call::FnAbi;
2221
use rustc_target::abi::{HasDataLayout, PointeeInfo, Size, TargetDataLayout, VariantIdx};
2322
use rustc_target::spec::{HasTargetSpec, HasWasmCAbiOpt, Target, TlsModel, WasmCAbi};
2423

@@ -572,8 +571,6 @@ impl<'gcc, 'tcx> HasWasmCAbiOpt for CodegenCx<'gcc, 'tcx> {
572571
}
573572

574573
impl<'gcc, 'tcx> LayoutOfHelpers<'tcx> for CodegenCx<'gcc, 'tcx> {
575-
type LayoutOfResult = TyAndLayout<'tcx>;
576-
577574
#[inline]
578575
fn handle_layout_err(&self, err: LayoutError<'tcx>, span: Span, ty: Ty<'tcx>) -> ! {
579576
if let LayoutError::SizeOverflow(_) | LayoutError::ReferencesError(_) = err {
@@ -585,8 +582,6 @@ impl<'gcc, 'tcx> LayoutOfHelpers<'tcx> for CodegenCx<'gcc, 'tcx> {
585582
}
586583

587584
impl<'gcc, 'tcx> FnAbiOfHelpers<'tcx> for CodegenCx<'gcc, 'tcx> {
588-
type FnAbiOfResult = &'tcx FnAbi<'tcx, Ty<'tcx>>;
589-
590585
#[inline]
591586
fn handle_fn_abi_err(
592587
&self,

0 commit comments

Comments
 (0)