Skip to content

Use multiple codegen units #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjorn3 opened this issue Mar 7, 2020 · 3 comments
Closed

Use multiple codegen units #909

bjorn3 opened this issue Mar 7, 2020 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. compile-time How fast is the code compiled

Comments

@bjorn3
Copy link
Member

bjorn3 commented Mar 7, 2020

This is required for #652 and #760.
@bjorn3 bjorn3 added C-enhancement Category: An issue proposing an enhancement or a PR with one. compile-time How fast is the code compiled labels Mar 7, 2020
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 7, 2020

On macOS my branch currently errors with:

dyld: Symbol not found: __ZN4core3fmt3num14DEC_DIGITS_LUT17hefdc294e6eba323cE
  Referenced from: /Users/bjorn/Documents/rustc_codegen_cranelift/./target/out/alloc_example
  Expected in: flat namespace
 in /Users/bjorn/Documents/rustc_codegen_cranelift/./target/out/alloc_example
./test.sh: line 41: 32618 Abort trap: 6           ./target/out/alloc_example

The mentioned symbol does exist, but it does so twice. Once as definition and once as *UND*.

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 8, 2020 •
edited
Loading

On Linux it gives a similar error, but during linking.

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 9, 2020

I was accidentially making statics private that could have been used in other cgus of the same crate.

@bjorn3 bjorn3 closed this as completed in 11b1c8b Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. compile-time How fast is the code compiled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjorn3