Skip to content

libcore num::test_can_not_overflow test fails on AArch64 #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjorn3 opened this issue Aug 7, 2022 · 2 comments · Fixed by #1283
Closed

libcore num::test_can_not_overflow test fails on AArch64 #1256

bjorn3 opened this issue Aug 7, 2022 · 2 comments · Fixed by #1283
Labels
O-arm Target: ARM processors (arm, thumb and AArch64 targets)

Comments

@bjorn3
Copy link
Member

bjorn3 commented Aug 7, 2022

failures:

---- num::test_can_not_overflow stdout ----
---- num::test_can_not_overflow stderr ----
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `false`,
 right: `true`', num/mod.rs:188:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@bjorn3 bjorn3 added the O-arm Target: ARM processors (arm, thumb and AArch64 targets) label Aug 7, 2022
@afonso360
Copy link
Contributor

Reduced this down to:

test run
target aarch64

function %numcore(i128) -> b1 {
block0(v0: i128):
    v1 = iconst.i128 0
    v2 = icmp eq v0, v1
    return v2
}
; run: %numcore(36893488147419103231) == false

I'll file an issue with cranelift.

@bjorn3
Copy link
Member Author

bjorn3 commented Sep 1, 2022

This is indeed fixed on cranelift main now. Just waiting for a new cranelift release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-arm Target: ARM processors (arm, thumb and AArch64 targets)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants