Implement 128bit checked add and sub

Author: bjorn3

example/mini_core.rs

@@ -44,12 +44,10 @@ unsafe impl Copy for u8 {}
 unsafe impl Copy for u16 {}
 unsafe impl Copy for u32 {}
 unsafe impl Copy for u64 {}
-unsafe impl Copy for u128 {}
 unsafe impl Copy for usize {}
 unsafe impl Copy for i8 {}
 unsafe impl Copy for i16 {}
 unsafe impl Copy for i32 {}
-unsafe impl Copy for i128 {}
 unsafe impl Copy for isize {}
 unsafe impl Copy for char {}
 unsafe impl<'a, T: ?Sized> Copy for &'a T {}
@@ -138,22 +136,6 @@ impl Add for usize {
     }
 }
 
-impl Add for u128 {
-    type Output = Self;
-
-    fn add(self, rhs: Self) -> Self {
-        self + rhs
-    }
-}
-
-impl Add for i128 {
-    type Output = Self;
-
-    fn add(self, rhs: Self) -> Self {
-        self + rhs
-    }
-}
-
 #[lang = "sub"]
 pub trait Sub<RHS = Self> {
     type Output;
@@ -254,15 +236,6 @@ impl PartialEq for i32 {
     }
 }
 
-impl PartialEq for i128 {
-    fn eq(&self, other: &i128) -> bool {
-        (*self) == (*other)
-    }
-    fn ne(&self, other: &i128) -> bool {
-        (*self) != (*other)
-    }
-}
-
 impl PartialEq for isize {
     fn eq(&self, other: &isize) -> bool {
         (*self) == (*other)
@@ -297,14 +270,6 @@ pub trait Neg {
     fn neg(self) -> Self::Output;
 }
 
-impl Neg for i128 {
-    type Output = i128;
-
-    fn neg(self) -> i128 {
-        -self
-    }
-}
-
 impl Neg for isize {
     type Output = isize;
 

example/std_example.rs

@@ -23,6 +23,9 @@ fn main() {
     checked_div_u128(0u128, 2u128);
     assert_eq!(1u128 + 2, 3);
 
+    // overflow panic
+    // 0xFEDCBA987654321123456789ABCDEFu128 + 0xFEDCBA987654321123456789ABCDEFu128;
+
     println!("{}", 0b100010000000000000000000000000000u128 >> 10);
     println!("{}", 0xFEDCBA987654321123456789ABCDEFu128 >> 64);
     println!("{} >> 64 == {}", 0xFEDCBA987654321123456789ABCDEFu128 as i128, 0xFEDCBA987654321123456789ABCDEFu128 as i128 >> 64);

src/codegen_i128.rs

@@ -23,8 +23,20 @@ pub fn maybe_codegen<'a, 'tcx>(
             assert!(!checked);
             return None;
         }
-        BinOp::Add | BinOp::Sub => {
-            return None; // FIXME implement checked versions
+        BinOp::Add | BinOp::Sub if !checked => return None,
+        BinOp::Add => {
+            return Some(if is_signed {
+                fx.easy_call("__rust_i128_addo", &[lhs, rhs], out_ty)
+            } else {
+                fx.easy_call("__rust_u128_addo", &[lhs, rhs], out_ty)
+            })
+        }
+        BinOp::Sub => {
+            return Some(if is_signed {
+                fx.easy_call("__rust_i128_subo", &[lhs, rhs], out_ty)
+            } else {
+                fx.easy_call("__rust_u128_subo", &[lhs, rhs], out_ty)
+            })
         }
         BinOp::Offset => unreachable!("offset should only be used on pointers, not 128bit ints"),
         BinOp::Mul => {