Skip to content

Commit 3998964

Browse files
committed
Only test proc-macro invalid compile flags with panic=unwind
Fuchsia explicitly builds rust and all rust targets with `-C panic=abort` to minimize code generation size. However, when compiling a proc-macro with this setting it can cause a warning to be emitted, which breaks `tests/ui/invalid-compile-flags/crate-type-flag.rs`. This hasn't been a problem in the past for us since we compile our proc macros on host, rather than inside Fuchsia. This attempts to fix the issue by explicitly requiring that we're using the unwinder when compiling this test to avoid the warning being emitted. Fixes #135223
1 parent a2d78f7 commit 3998964

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

scripts/test_rustc_tests.sh

-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ rm tests/ui/mir/mir_raw_fat_ptr.rs # same
123123
rm tests/ui/consts/issue-33537.rs # same
124124
rm tests/ui/consts/const-mut-refs-crate.rs # same
125125
rm tests/ui/abi/large-byval-align.rs # exceeds implementation limit of Cranelift
126-
rm tests/ui/invalid-compile-flags/crate-type-flag.rs # warning about proc-macros and panic=abort
127126

128127
# doesn't work due to the way the rustc test suite is invoked.
129128
# should work when using ./x.py test the way it is intended

0 commit comments

Comments
 (0)