Improve PlaceElem::Subslice handling

Author: bjorn3

src/base.rs

@@ -678,11 +678,10 @@ pub fn trans_place<'tcx>(
                 // slice[from:-to] in Python terms.
 
                 match cplace.layout().ty.kind {
-                    ty::Array(elem_ty, len) => {
+                    ty::Array(elem_ty, _len) => {
+                        assert!(!from_end, "array subslices are never `from_end`");
                         let elem_layout = fx.layout_of(elem_ty);
                         let ptr = cplace.to_ptr(fx);
-                        let len = crate::constant::force_eval_const(fx, len)
-                            .eval_usize(fx.tcx, ParamEnv::reveal_all());
                         cplace = CPlace::for_ptr(
                             ptr.offset_i64(fx, elem_layout.size.bytes() as i64 * from as i64),
                             fx.layout_of(fx.tcx.mk_array(elem_ty, to as u64 - from as u64)),
@@ -691,11 +690,10 @@ pub fn trans_place<'tcx>(
                     ty::Slice(elem_ty) => {
                         assert!(from_end, "slice subslices should be `from_end`");
                         let elem_layout = fx.layout_of(elem_ty);
-                        let (ptr, len) = cplace.to_ptr_maybe_unsized(fx);
-                        let len = len.unwrap();
+                        let (ptr, _len) = cplace.to_ptr_maybe_unsized(fx);
                         cplace = CPlace::for_ptr_with_extra(
                             ptr.offset_i64(fx, elem_layout.size.bytes() as i64 * from as i64),
-                            fx.bcx.ins().iadd_imm(len, -(from as i64 + to as i64)),
+                            fx.bcx.ins().iconst(pointer_ty(fx.tcx), (to as u64 - from as u64) as i64),
                             cplace.layout(),
                         );
                     }