You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
why isn't this classified as a definite improvement in the performance triage script?
Yes, a lot of them have question marks on them (though I'm not sure the performance triage script includes the question marks in its weighting at this point, based on what I saw elsewhere), but even if you remove the question mark cases, you're still left with e.g.
Benchmark & Profile
Scenario
% Change
Significance Factor ?
coercions check
incr-patched: println
-0.64%
4.82x
helloworld debug
incr-unchanged
-0.52%
4.79x
coercions check
incr-unchanged
-0.51%
7.92x
which seems like it should have been enough for being classified as a performance win, not a "probably" ?
The text was updated successfully, but these errors were encountered:
Looking at the performance report linked here:
why isn't this classified as a definite improvement in the performance triage script?
Yes, a lot of them have question marks on them (though I'm not sure the performance triage script includes the question marks in its weighting at this point, based on what I saw elsewhere), but even if you remove the question mark cases, you're still left with e.g.
which seems like it should have been enough for being classified as a performance win, not a "probably" ?
The text was updated successfully, but these errors were encountered: