Skip to content

Commit ed4e323

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 533f2dd commit ed4e323

File tree

1 file changed

+251
-0
lines changed

1 file changed

+251
-0
lines changed

‎triage/2024-07-30.md

Lines changed: 251 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,251 @@
1+
# 2024-07-30 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [9629b90b..7e3a9718](https://perf.rust-lang.org/?start=9629b90b3f7dd8f5626ec9d3b42556f39f09e214&end=7e3a971870f23c94f7aceb53b490fb37333150ff&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 1.3% | [0.2%, 6.1%] | 43 |
13+
| Regressions ❌ <br /> (secondary) | 1.9% | [0.1%, 10.4%] | 46 |
14+
| Improvements ✅ <br /> (primary) | -1.0% | [-3.9%, -0.2%] | 27 |
15+
| Improvements ✅ <br /> (secondary) | -1.6% | [-6.8%, -0.2%] | 43 |
16+
| All ❌✅ (primary) | 0.4% | [-3.9%, 6.1%] | 70 |
17+
18+
19+
5 Regressions, 6 Improvements, 6 Mixed; 8 of them in rollups
20+
65 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Do not use global caches if opaque types can be defined [#126024](https://github.com/rust-lang/rust/pull/126024) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d24930ceb473b7b361d108d573308e3529cb5ef7&end=2ccafed862f6906707a390caf180449dd64cad2e&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 3.4% | [1.6%, 5.5%] | 6 |
29+
| Regressions ❌ <br /> (secondary) | 3.1% | [0.4%, 5.4%] | 11 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 3.4% | [1.6%, 5.5%] | 6 |
33+
34+
35+
Rollup of 5 pull requests [#128169](https://github.com/rust-lang/rust/pull/128169) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e7d66eac5e8e8f60370c98d186aee9fa0ebd7845&end=004e155c46a2083d4f73212cc47a6f7fb98fcbd1&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.9% | [0.2%, 3.0%] | 26 |
40+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 2.2%] | 13 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.9% | [0.2%, 3.0%] | 26 |
44+
45+
46+
Rollup of 7 pull requests [#128186](https://github.com/rust-lang/rust/pull/128186) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=54be9ad5eb47207d155904f6c912a9526133f75f&end=eb10639928a2781cf0a12440007fbcc1e3a6888f&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 11 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 11 |
55+
56+
57+
Rollup of 9 pull requests [#128253](https://github.com/rust-lang/rust/pull/128253) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7c2012d0ec3aae89fefc40e5d6b317a0949cda36&end=8b6b8574f6f2fcc71ec500a52d7bf74fdaff0ed6&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | 0.5% | [0.4%, 0.5%] | 3 |
62+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | 0.5% | [0.4%, 0.5%] | 3 |
66+
67+
68+
Document 0x10.checked_shl(BITS - 1) does not overflow [#128255](https://github.com/rust-lang/rust/pull/128255) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a526d7ce45fd2284e0e7c7556ccba2425b9d25e5&end=ad3c5a330173a4a6446c1ed90c72a3f5f9106888&stat=instructions:u)
69+
70+
| (instructions:u) | mean | range | count |
71+
|:----------------------------------:|:----:|:------------:|:-----:|
72+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.6%] | 4 |
73+
| Regressions ❌ <br /> (secondary) | 2.2% | [2.2%, 2.2%] | 1 |
74+
| Improvements ✅ <br /> (primary) | - | - | 0 |
75+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
76+
| All ❌✅ (primary) | 0.5% | [0.5%, 0.6%] | 4 |
77+
78+
79+
#### Improvements
80+
81+
Remove unnecessary impl sorting in queries and metadata [#120812](https://github.com/rust-lang/rust/pull/120812) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=92c6c03805408a1a261b98013304e9bbf59ee428&end=0f8534e79e4cfbda7421017047d1f5021235b0ac&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -1.2% | [-2.1%, -0.4%] | 2 |
88+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.3%] | 2 |
89+
| All ❌✅ (primary) | -1.2% | [-2.1%, -0.4%] | 2 |
90+
91+
92+
rustdoc: clean up and fix ord violations in item sorting [#128146](https://github.com/rust-lang/rust/pull/128146) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6106b05b27988f4b946d7af219a6db95fb4477a1&end=c1a6199e9d92bb785c17a6d7ffd8b8b552f79c10&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.6%, -0.2%] | 4 |
99+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
100+
| All ❌✅ (primary) | -0.7% | [-1.6%, -0.2%] | 4 |
101+
102+
103+
Rollup of 6 pull requests [#128195](https://github.com/rust-lang/rust/pull/128195) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eb10639928a2781cf0a12440007fbcc1e3a6888f&end=aa877bc71c8c8082122bee23d17c8669f30f275d&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
109+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.4%] | 5 |
110+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
111+
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.4%] | 5 |
112+
113+
114+
Switch from `derivative` to `derive-where` [#127042](https://github.com/rust-lang/rust/pull/127042) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7120fdac7a6e55a5e4b606256042890b36067052&end=2f26b2a99ab976c43d12cf57ef4a3a2c82ede286&stat=instructions:u)
115+
116+
| (instructions:u) | mean | range | count |
117+
|:----------------------------------:|:-----:|:--------------:|:-----:|
118+
| Regressions ❌ <br /> (primary) | - | - | 0 |
119+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
120+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 16 |
121+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.4%] | 8 |
122+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 16 |
123+
124+
125+
Always set `result` during `finish()` in debug builders [#127946](https://github.com/rust-lang/rust/pull/127946) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8b6b8574f6f2fcc71ec500a52d7bf74fdaff0ed6&end=a526d7ce45fd2284e0e7c7556ccba2425b9d25e5&stat=instructions:u)
126+
127+
| (instructions:u) | mean | range | count |
128+
|:----------------------------------:|:-----:|:--------------:|:-----:|
129+
| Regressions ❌ <br /> (primary) | - | - | 0 |
130+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
131+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.5%] | 6 |
132+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
133+
| All ❌✅ (primary) | -0.5% | [-0.6%, -0.5%] | 6 |
134+
135+
136+
Rollup of 6 pull requests [#128313](https://github.com/rust-lang/rust/pull/128313) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=188ddf4d6a694fa263c2ff8be8f8eade659599d6&end=2cbbe8b8bb2be672b14cf741a2f0ec24a49f3f0b&stat=instructions:u)
137+
138+
| (instructions:u) | mean | range | count |
139+
|:----------------------------------:|:-----:|:--------------:|:-----:|
140+
| Regressions ❌ <br /> (primary) | - | - | 0 |
141+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
142+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -1.0%] | 2 |
143+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.9%, -0.2%] | 10 |
144+
| All ❌✅ (primary) | -1.0% | [-1.1%, -1.0%] | 2 |
145+
146+
147+
#### Mixed
148+
149+
Try to fix ICE from re-interning an AllocId with different allocation contents [#127442](https://github.com/rust-lang/rust/pull/127442) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee0fd6caf770e8b3baa403b4da3ef0c7e274dc21&end=ae7b1c191695f351e69ef7ad32c0897048bba73e&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | - | - | 0 |
154+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 2.5%] | 4 |
155+
| Improvements ✅ <br /> (primary) | - | - | 0 |
156+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.4%, -0.3%] | 7 |
157+
| All ❌✅ (primary) | - | - | 0 |
158+
159+
160+
Rollup of 8 pull requests [#128155](https://github.com/rust-lang/rust/pull/128155) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c1a6199e9d92bb785c17a6d7ffd8b8b552f79c10&end=e7d66eac5e8e8f60370c98d186aee9fa0ebd7845&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 0.8%] | 6 |
165+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.7%, 1.0%] | 7 |
166+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.4%] | 4 |
167+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
168+
| All ❌✅ (primary) | 0.1% | [-0.6%, 0.8%] | 10 |
169+
170+
171+
Allow optimizing `u32::from::<char>`. [#124905](https://github.com/rust-lang/rust/pull/124905) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ad3c5a330173a4a6446c1ed90c72a3f5f9106888&end=3942254d00bf95cd5920980f85ebea57a1e6ce2a&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 4 |
176+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
177+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
178+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
179+
| All ❌✅ (primary) | 0.1% | [-0.2%, 0.3%] | 5 |
180+
181+
182+
Rollup of 3 pull requests [#128301](https://github.com/rust-lang/rust/pull/128301) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1b51d80027919563004918eaadfa0d890ac0eb93&end=78c857394ec8c01f06cb1df260c51178180a40e5&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | - | - | 0 |
187+
| Regressions ❌ <br /> (secondary) | 2.1% | [2.1%, 2.1%] | 1 |
188+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 2 |
189+
| Improvements ✅ <br /> (secondary) | -1.6% | [-3.0%, -0.2%] | 2 |
190+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 2 |
191+
192+
193+
Perform instsimplify before inline to eliminate some trivial calls [#128265](https://github.com/rust-lang/rust/pull/128265) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=56c698c71130de6fe55ba703a161405b6145b90e&end=4db3d12e6f395babed53dee1d209a5c8699a5ae6&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | 1.2% | [0.2%, 2.6%] | 4 |
198+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.5%] | 1 |
199+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.8%, -0.2%] | 12 |
200+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.3%] | 2 |
201+
| All ❌✅ (primary) | -0.0% | [-0.8%, 2.6%] | 16 |
202+
203+
204+
Rollup of 6 pull requests [#128360](https://github.com/rust-lang/rust/pull/128360) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=612a33f20b9b2c27380edbc4b26a01433ed114bc&end=368e2fd458a22d0cc133d0c254f2612ee999744f&stat=instructions:u)
205+
206+
| (instructions:u) | mean | range | count |
207+
|:----------------------------------:|:-----:|:--------------:|:-----:|
208+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.7%] | 4 |
209+
| Regressions ❌ <br /> (secondary) | 4.4% | [0.3%, 12.0%] | 10 |
210+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 4 |
211+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
212+
| All ❌✅ (primary) | 0.1% | [-0.3%, 0.7%] | 8 |
213+
214+
215+
#### Untriaged Pull Requests
216+
217+
- [#128360 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/128360)
218+
- [#128301 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/128301)
219+
- [#128265 Perform instsimplify before inline to eliminate some trivial calls ](https://github.com/rust-lang/rust/pull/128265)
220+
- [#128253 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/128253)
221+
- [#128169 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/128169)
222+
- [#128155 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/128155)
223+
- [#128104 Not lint pub structs without pub constructors intentionally](https://github.com/rust-lang/rust/pull/128104)
224+
- [#127998 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/127998)
225+
- [#127865 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/127865)
226+
- [#127528 Replace ASCII control chars with Unicode Control Pictures](https://github.com/rust-lang/rust/pull/127528)
227+
- [#127486 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/127486)
228+
- [#127442 Try to fix ICE from re-interning an AllocId with different allocation contents](https://github.com/rust-lang/rust/pull/127442)
229+
- [#127439 Uplift elaboration into `rustc_type_ir`](https://github.com/rust-lang/rust/pull/127439)
230+
- [#127172 Make `can_eq` process obligations (almost) everywhere](https://github.com/rust-lang/rust/pull/127172)
231+
- [#127096 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/127096)
232+
- [#127076 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/127076)
233+
- [#126852 Also get `add nuw` from `uN::checked_add`](https://github.com/rust-lang/rust/pull/126852)
234+
- [#126591 [perf] More span update benchmarking](https://github.com/rust-lang/rust/pull/126591)
235+
- [#126578 Account for things that optimize out in inlining costs](https://github.com/rust-lang/rust/pull/126578)
236+
- [#126134 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/126134)
237+
- [#126024 Do not use global caches if opaque types can be defined](https://github.com/rust-lang/rust/pull/126024)
238+
- [#125968 Store the types of `ty::Expr` arguments in the `ty::Expr`](https://github.com/rust-lang/rust/pull/125968)
239+
- [#125824 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125824)
240+
- [#125144 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/125144)
241+
- [#125120 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125120)
242+
- [#125069 Extend SCC construction to enable extra functionality ](https://github.com/rust-lang/rust/pull/125069)
243+
- [#124905 Allow optimizing `u32::from::<char>`.](https://github.com/rust-lang/rust/pull/124905)
244+
- [#124700 Remove an unnecessary cast](https://github.com/rust-lang/rust/pull/124700)
245+
- [#124417 Make early lints translatable](https://github.com/rust-lang/rust/pull/124417)
246+
- [#124241 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/124241)
247+
248+
#### Nags requiring follow up
249+
250+
TODO: Nags
251+

0 commit comments

Comments
 (0)