Merge pull request #1947 from s7tya/fix/remove-interpolated-points-and-fix-graph-unit

remove interpolated points of dashboard's runtime bench and fix graph unit

Author: Kobzol

site/frontend/src/pages/dashboard.ts

@@ -80,6 +80,13 @@ function render(
 }
 
 function renderRuntime(element: string, data: [number], versions: [string]) {
+  // Remove null and convert nanoseconds to miliseconds
+  // The null values, which indicate that the runtime data is missing, are only present at the beginning of the array.
+  const formattedData = data
+    .filter((data) => data != null)
+    .map((data) => data / 1_000_000);
+  const nullCount = data.length - formattedData.length;
+
   Highcharts.chart({
     chart: {
       renderTo: element,
@@ -92,19 +99,19 @@ function renderRuntime(element: string, data: [number], versions: [string]) {
       text: `Average time for a runtime benchmark`,
     },
     yAxis: {
-      title: {text: "Seconds"},
+      title: {text: "Miliseconds"},
       min: 0,
     },
     xAxis: {
-      categories: versions,
+      categories: versions.slice(nullCount),
       title: {text: "Version"},
     },
     series: [
       {
         showInLegend: false,
         type: "line",
         animation: false,
-        data,
+        data: formattedData,
       },
     ],
   });

site/src/api.rs

@@ -75,7 +75,7 @@ pub mod dashboard {
         pub debug: Cases,
         pub opt: Cases,
         pub doc: Cases,
-        pub runtime: Vec<f64>,
+        pub runtime: Vec<Option<f64>>,
     }
 }
 

site/src/request_handlers/dashboard.rs

@@ -137,13 +137,26 @@ pub async fn handle_dashboard(ctxt: Arc<SiteCtxt>) -> ServerResult<dashboard::Re
     let responses = ctxt
         .statistic_series(runtime_benchmark_query.clone(), aids.clone())
         .await?;
+
+    // The flag is used to ignore only the initial values where the runtime benchmark was not implemented.
+    let mut ignore_runtime_benchmark = true;
     let points = db::average(
         responses
             .into_iter()
             .map(|sr| sr.interpolate().series)
             .collect::<Vec<_>>(),
     )
-    .map(|((_id, point), _interpolated)| (point.expect("interpolated") * 100.0).round() / 100.0)
+    .map(|((_id, point), interpolated)| {
+        if !interpolated.as_bool() {
+            ignore_runtime_benchmark = false;
+        }
+
+        if ignore_runtime_benchmark && interpolated.as_bool() {
+            None
+        } else {
+            Some((point.expect("interpolated") * 100.0).round() / 100.0)
+        }
+    })
     .collect::<Vec<_>>();
 
     Ok(dashboard::Response {