Skip to content

Commit 9f1e665

Browse files
committed
review feedback: added links to my comments, and removed the nags that already got tags added to them.
1 parent b7c03bc commit 9f1e665

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

triage/2021-07-20.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ Update Rust Float-Parsing Algorithms to use the Eisel-Lemire algorithm. [#86761]
5050
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=64d171b8a419eb6cb872ab579398eff8a741bbc6&end=f502bd3abd12111bbfae0974db018c165a977c0e&stat=instructions:u) (up to 3.2% on `incr-patched: b9b3e592dd cherry picked` builds of `style-servo-debug`)
5151
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=64d171b8a419eb6cb872ab579398eff8a741bbc6&end=f502bd3abd12111bbfae0974db018c165a977c0e&stat=instructions:u) (up to -1.4% on `full` builds of `piston-image-opt`)
5252
- A perf run was done on the orignal PR, but the run there did not predict the regression that was now observed to `style-servo-debug` when this PR landed on nightly.
53-
- Left a comment, but I am guessing that `style-servo-debug` may need a bigger noise threshold (or rather, sensitivity to perturbations) than what we currently use.
53+
- Left a [comment](https://github.com/rust-lang/rust/pull/86761#issuecomment-883645181), but I am guessing that `style-servo-debug` may need a bigger noise threshold (or rather, sensitivity to perturbations) than what we currently use.
5454

5555
Move OnDiskCache to rustc_query_impl. [#86698](https://github.com/rust-lang/rust/issues/86698)
5656
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f&end=18073052d8c3544ccb73effd289ed3acda0d66c0&stat=instructions:u) (up to -1.4% on `incr-unchanged` builds of `ctfe-stress-4-check`)
5757
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f&end=18073052d8c3544ccb73effd289ed3acda0d66c0&stat=instructions:u) (up to 1.1% on `incr-unchanged` builds of `deeply-nested-async-opt`)
5858
- A perf run was done on the original PR that predicted a much better outcome here.
59-
- Left a comment asking PR author if they have any idea about the discrepancy.
59+
- Left a [comment](https://github.com/rust-lang/rust/pull/86698#issuecomment-883647259) asking PR author if they have any idea about the discrepancy.
6060

6161
#### Untriaged Pull Requests
6262

@@ -68,6 +68,3 @@ Move OnDiskCache to rustc_query_impl. [#86698](https://github.com/rust-lang/rust
6868
- [#84560 Inline Iterator as IntoIterator.](https://github.com/rust-lang/rust/pull/84560)
6969

7070
#### Nags requiring follow up
71-
72-
* [PR #87244 followup](https://github.com/rust-lang/rust/pull/87244#issuecomment-883635813)
73-
* [PR #86698 followup](https://github.com/rust-lang/rust/pull/86698#issuecomment-883647259)

0 commit comments

Comments
 (0)