Skip to content

Commit 7f031fb

Browse files
committed
improve accordion component
1 parent ae57713 commit 7f031fb

File tree

4 files changed

+17
-25
lines changed

4 files changed

+17
-25
lines changed

site/frontend/src/components/accordion.vue

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,28 @@
1-
<script lang="ts">
2-
import {defineComponent} from "vue";
3-
import {useExpandedStore} from "./expansion";
1+
<script setup lang="ts">
2+
import {computed} from "vue";
3+
import {useExpandedStore} from "../utils/expansion";
44
5-
export default defineComponent({
6-
props: {
7-
id: {
8-
type: String,
9-
required: true,
10-
},
11-
},
12-
setup() {
13-
const {toggleExpanded, isExpanded} = useExpandedStore();
14-
return {
15-
toggleExpanded,
16-
isExpanded,
17-
};
18-
},
19-
});
5+
const props = defineProps<{
6+
id: string;
7+
}>();
8+
9+
const {toggleExpanded, isExpanded} = useExpandedStore();
10+
11+
const expanded = computed(() => isExpanded(props.id));
2012
</script>
2113

2214
<template>
2315
<tr
24-
@click="toggleExpanded(id)"
25-
:class="{toggle: true, toggled: isExpanded(id)}"
16+
@click="toggleExpanded(props.id)"
17+
:class="{toggle: true, toggled: expanded}"
2618
>
2719
<td class="toggle-arrow">
28-
{{ isExpanded(id) ? "▼" : "▶" }}
20+
{{ expanded ? "▼" : "▶" }}
2921
</td>
3022
<slot name="default" />
3123
</tr>
32-
<tr v-if="isExpanded(id)">
33-
<slot name="collapsed" />
24+
<tr v-if="expanded">
25+
<slot name="expanded" />
3426
</tr>
3527
</template>
3628

site/frontend/src/pages/compare/compile/table/comparisons-table.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ const unit = computed(() => {
136136
</abbr>
137137
</td>
138138
</template>
139-
<template v-slot:collapsed>
139+
<template v-slot:expanded>
140140
<td :colspan="columnCount">
141141
<BenchmarkDetail
142142
:test-case="comparison.testCase"

site/frontend/src/pages/compare/runtime/comparisons-table.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ const unit = computed(() => {
127127
>
128128
</td>
129129
</template>
130-
<template v-slot:collapsed>
130+
<template v-slot:expanded>
131131
<td :colspan="columnCount">
132132
<BenchmarkDetailGraph
133133
:baseArtifact="commitA"

0 commit comments

Comments
 (0)