Skip to content

Commit 2d53054

Browse files
KobzolKobzol
authored
Merge pull request #2029 from Kobzol/triage-2025-01-07
Triage 2025 01 07
2 parents 856dc30 + e5ffd3c commit 2d53054

File tree

1 file changed

+99
-0
lines changed

1 file changed

+99
-0
lines changed

‎triage/2025-01-07.md

Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
# 2025-01-07 Triage Log
2+
3+
A quiet week with not much going on. A small regression was caused by a bugfix related to traits, but
4+
it was somewhat offset by a cargo update that brought a small perf. win.
5+
6+
Triage done by **@kobzol**.
7+
Revision range: [93722f7e..0f1e965f](https://perf.rust-lang.org/?start=93722f7ed56bcf27839a6355074095c4320b7d37&end=0f1e965fec3bc2f97b932e9dd8e85fca6d7faadc&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 1.1%] | 20 |
14+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 2.5%] | 19 |
15+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.6%, -0.2%] | 8 |
16+
| Improvements ✅ <br /> (secondary) | -1.3% | [-1.7%, -0.2%] | 13 |
17+
| All ❌✅ (primary) | 0.1% | [-1.6%, 1.1%] | 28 |
18+
19+
20+
0 Regressions, 2 Improvements, 4 Mixed; 4 of them in rollups
21+
51 artifact comparisons made in total
22+
23+
#### Improvements
24+
25+
Rollup of 4 pull requests [#135059](https://github.com/rust-lang/rust/pull/135059) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ac00fe89a121e9ca5e59c093c7c02aa296e55ece&end=319f5292a19951d13f3c79c04b3cf3d1501d9e79&stat=instructions:u)
26+
27+
| (instructions:u) | mean | range | count |
28+
|:----------------------------------:|:-----:|:--------------:|:-----:|
29+
| Regressions ❌ <br /> (primary) | - | - | 0 |
30+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
31+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
32+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
33+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
34+
35+
36+
Rollup of 7 pull requests [#135086](https://github.com/rust-lang/rust/pull/135086) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3f43b1a636738f41c48df073c5bcb97a97bf8459&end=8d2c06d151972fefa3f0bbf04ace3beede737145&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:-----:|:--------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | - | - | 0 |
41+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
42+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 7 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 7 |
45+
46+
47+
#### Mixed
48+
49+
Update cargo [#135089](https://github.com/rust-lang/rust/pull/135089) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8d2c06d151972fefa3f0bbf04ace3beede737145&end=d13c80a6fdd915ec35d7882122e5f221e8f27a18&stat=instructions:u)
50+
51+
| (instructions:u) | mean | range | count |
52+
|:----------------------------------:|:-----:|:--------------:|:-----:|
53+
| Regressions ❌ <br /> (primary) | - | - | 0 |
54+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.9%, 0.9%] | 1 |
55+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 38 |
56+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.1%] | 35 |
57+
| All ❌✅ (primary) | -0.1% | [-0.2%, -0.1%] | 38 |
58+
59+
- Many small improvements and only a tiny regression.
60+
- Marked as triaged.
61+
62+
Project to `TyKind::Error` when there are unconstrained non-lifetime (ty/const) impl params [#135057](https://github.com/rust-lang/rust/pull/135057) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d13c80a6fdd915ec35d7882122e5f221e8f27a18&end=7349f6b50359fd1f11738765b8deec5ee02d8710&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 76 |
67+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.0%, 0.7%] | 39 |
68+
| Improvements ✅ <br /> (primary) | - | - | 0 |
69+
| Improvements ✅ <br /> (secondary) | -1.0% | [-1.0%, -1.0%] | 1 |
70+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.3%] | 76 |
71+
72+
- Small performance loss, but this was a bugfix, so it was deemed justifiable.
73+
- Marked as triaged.
74+
75+
Rollup of 6 pull requests [#135101](https://github.com/rust-lang/rust/pull/135101) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ead4a8f53624f3b4a9ee833421fbf8a48bc07aca&end=1891c28669863bf7ed3ef8f43f2d3fa546f34861&stat=instructions:u)
76+
77+
| (instructions:u) | mean | range | count |
78+
|:----------------------------------:|:-----:|:--------------:|:-----:|
79+
| Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.8%] | 4 |
80+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.3%, 2.2%] | 4 |
81+
| Improvements ✅ <br /> (primary) | - | - | 0 |
82+
| Improvements ✅ <br /> (secondary) | -1.3% | [-1.8%, -0.2%] | 13 |
83+
| All ❌✅ (primary) | 0.7% | [0.7%, 0.8%] | 4 |
84+
85+
- The `deep-vector` benchmark changes were most likely caused by [#135046](https://github.com/rust-lang/rust/pull/135046).
86+
- Marked as triaged.
87+
88+
Rollup of 3 pull requests [#135140](https://github.com/rust-lang/rust/pull/135140) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=feb32c654619e50eda8408f9241d4cb7b948fea5&end=56f9e6f935f9b0d6e83092a0f86d4dbeb878f17d&stat=instructions:u)
89+
90+
| (instructions:u) | mean | range | count |
91+
|:----------------------------------:|:-----:|:--------------:|:-----:|
92+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.6%] | 2 |
93+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
94+
| Improvements ✅ <br /> (primary) | -1.7% | [-1.7%, -1.7%] | 1 |
95+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.4%] | 2 |
96+
| All ❌✅ (primary) | -0.2% | [-1.7%, 0.6%] | 3 |
97+
98+
- Only tiny changes, and the combined result is a wash.
99+
- Marked as triaged.

0 commit comments

Comments
 (0)