Skip to content

Commit 0fd5c19

Browse files
Merge pull request #1401 from rust-lang/compare-page-url-fix
Do not add undefined parameters to URL in compare page
2 parents 4937a03 + a49d880 commit 0fd5c19

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

site/static/compare/script.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -494,9 +494,15 @@ function makeData(state, app) {
494494

495495
function createSearchParamsForMetric(stat, start, end) {
496496
let params = new URLSearchParams();
497-
params.append("start", start);
498-
params.append("end", end);
499-
params.append("stat", stat);
497+
if (start !== undefined) {
498+
params.append("start", start);
499+
}
500+
if (end !== undefined) {
501+
params.append("end", end);
502+
}
503+
if (stat !== undefined) {
504+
params.append("stat", stat);
505+
}
500506
return params.toString();
501507
}
502508

0 commit comments

Comments
 (0)