From abca6b6ac1c9ea65ffe87868b79af5f32e58ab1e Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Fri, 17 Feb 2023 03:58:34 +0200 Subject: [PATCH 1/3] rustc_codegen_ssa feels permanent enough not to need date-check --- src/backend/backend-agnostic.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/backend/backend-agnostic.md b/src/backend/backend-agnostic.md index ea50cd754..3f25fe037 100644 --- a/src/backend/backend-agnostic.md +++ b/src/backend/backend-agnostic.md @@ -2,11 +2,12 @@ -As of Aug 2022, `rustc_codegen_ssa` provides an -abstract interface for all backends to implement, to allow other codegen -backends (e.g. [Cranelift]). +[`rustc_codegen_ssa`] +provides an abstract interface for all backends to implement, +to allow other codegen backends (e.g. [Cranelift]). [Cranelift]: https://github.com/bytecodealliance/wasmtime/tree/HEAD/cranelift +[`rustc_codegen_ssa`]: https://doc.rust-lang.org/stable/nightly-rustc/rustc_codegen_ssa/index.html # Refactoring of `rustc_codegen_llvm` by Denis Merigoux, October 23rd 2018 From dfb468a52fb606b6647e7240756f2c399654f179 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Fri, 17 Feb 2023 09:24:03 +0200 Subject: [PATCH 2/3] address review comment See - https://github.com/rust-lang/rustc-dev-guide/pull/1606#discussion_r1109298849 - https://github.com/rust-lang/rustc-dev-guide/pull/1606#discussion_r1109298280 --- src/backend/backend-agnostic.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/backend/backend-agnostic.md b/src/backend/backend-agnostic.md index 3f25fe037..ef945c4d2 100644 --- a/src/backend/backend-agnostic.md +++ b/src/backend/backend-agnostic.md @@ -4,9 +4,10 @@ [`rustc_codegen_ssa`] provides an abstract interface for all backends to implement, -to allow other codegen backends (e.g. [Cranelift]). +namely LLVM, [Cranelift], and [GCC]. -[Cranelift]: https://github.com/bytecodealliance/wasmtime/tree/HEAD/cranelift +[Cranelift]: https://github.com/bjorn3/rustc_codegen_cranelift +[GCC]: https://github.com/rust-lang/rustc_codegen_gcc [`rustc_codegen_ssa`]: https://doc.rust-lang.org/stable/nightly-rustc/rustc_codegen_ssa/index.html # Refactoring of `rustc_codegen_llvm` From a650f37f2dc17c4d41e0b853380e67d7a7ddc9f3 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Fri, 17 Feb 2023 09:28:03 +0200 Subject: [PATCH 3/3] accept review suggestion Co-authored-by: Noah Lev --- src/backend/backend-agnostic.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/backend-agnostic.md b/src/backend/backend-agnostic.md index ef945c4d2..e8a65cdc3 100644 --- a/src/backend/backend-agnostic.md +++ b/src/backend/backend-agnostic.md @@ -8,7 +8,7 @@ namely LLVM, [Cranelift], and [GCC]. [Cranelift]: https://github.com/bjorn3/rustc_codegen_cranelift [GCC]: https://github.com/rust-lang/rustc_codegen_gcc -[`rustc_codegen_ssa`]: https://doc.rust-lang.org/stable/nightly-rustc/rustc_codegen_ssa/index.html +[`rustc_codegen_ssa`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/index.html # Refactoring of `rustc_codegen_llvm` by Denis Merigoux, October 23rd 2018