Skip to content

Commit ce1d055

Browse files
authored
Rollup merge of #136530 - Kobzol:x-perf, r=onur-ozkan
Implement `x perf` directly in bootstrap Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Turning.20.60x.20perf.60.20into.20a.20first.20class.20command). Implementing the command directly in bootstrap let's us correctly build the compiler toolchain based on input arguments (such as include rustdoc in the toolchain [only] when needed), and it also makes the CLI interface nicer. r? ``@onur-ozkan``
2 parents 43e4354 + 0238431 commit ce1d055

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

Diff for: src/profiling/with_rustc_perf.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ However, using the suite manually can be a bit cumbersome. To make this easier f
77
the compiler build system (`bootstrap`) also provides built-in integration with the benchmarking suite,
88
which will download and build the suite for you, build a local compiler toolchain and let you profile it using a simplified command-line interface.
99

10-
You can use the `./x perf -- <command> [options]` command to use this integration.
11-
12-
> Note that you need to specify arguments after `--` in the `x perf` command! You will not be able to pass arguments without the double dashes.
10+
You can use the `./x perf <command> [options]` command to use this integration.
1311

1412
You can use normal bootstrap flags for this command, such as `--stage 1` or `--stage 2`, for example to modify the stage of the created sysroot. It might also be useful to configure `config.toml` to better support profiling, e.g. set `rust.debuginfo-level = 1` to add source line information to the built compiler.
1513

0 commit comments

Comments
 (0)