From d505c5abe4d2b03c0f714bc19087cb77f166a19a Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sat, 11 Feb 2023 18:03:06 +0100 Subject: [PATCH] Improve JS function itemTypeFromName code a bit --- src/librustdoc/html/static/js/search.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/librustdoc/html/static/js/search.js b/src/librustdoc/html/static/js/search.js index 251e806c2d90d..ea1875d8e27a9 100644 --- a/src/librustdoc/html/static/js/search.js +++ b/src/librustdoc/html/static/js/search.js @@ -142,13 +142,11 @@ function initSearch(rawSearchIndex) { } function itemTypeFromName(typename) { - for (let i = 0, len = itemTypes.length; i < len; ++i) { - if (itemTypes[i] === typename) { - return i; - } + const index = itemTypes.findIndex(i => i === typename); + if (index < 0) { + throw new Error("Unknown type filter `" + typename + "`"); } - - throw new Error("Unknown type filter `" + typename + "`"); + return index; } /**