Skip to content

Target spec JSON files are not checked for unknown keys #75869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phil-opp opened this issue Aug 24, 2020 · 1 comment
Open

Target spec JSON files are not checked for unknown keys #75869

phil-opp opened this issue Aug 24, 2020 · 1 comment
Labels
A-target-specs Area: Compile-target specifications C-bug Category: This is a bug.

Comments

@phil-opp
Copy link
Contributor

phil-opp commented Aug 24, 2020 •
edited
Loading

Target JSON files are currently not checked for unknown keys, so typos can easily lead to bugs. For example, a "panic_strategy": "abort" key is silently ignored because the correct key name is panic-strategy (- instead of _).

This is not a new problem, but I could not find any open issue for this. Feel free to close this if this is a duplicate.
@phil-opp phil-opp added the C-bug Category: This is a bug. label Aug 24, 2020
@phil-opp phil-opp mentioned this issue Aug 24, 2020
Closed
@jonas-schievink jonas-schievink added the A-target-specs Area: Compile-target specifications label Aug 24, 2020
@xzmeng
Copy link
Contributor

xzmeng commented Aug 25, 2023

After #85775 it emits a warning if there is any unknown key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-target-specs Area: Compile-target specifications C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phil-opp @jonas-schievink @xzmeng