Skip to content

include! should add file dependencies like include_str! #58069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wizeman opened this issue Feb 2, 2019 · 1 comment
Closed

include! should add file dependencies like include_str! #58069

wizeman opened this issue Feb 2, 2019 · 1 comment
Labels
A-incr-comp Area: Incremental compilation A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@wizeman
Copy link
Contributor

wizeman commented Feb 2, 2019

Let's say I use the include! macro and then do cargo build. If I then change the included file and re-run cargo build, cargo should rebuild. However, right now, it doesn't seem to do anything.

In other words, I'm encountering the same problem as in #24348, except with the include! macro instead of the include_bytes! macro.
@Centril Centril added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-incr-comp Area: Incremental compilation labels Feb 2, 2019
@jonas-schievink jonas-schievink added the C-bug Category: This is a bug. label May 16, 2019
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 25, 2019
@ehuss
Copy link
Contributor

ehuss commented Jul 27, 2022

I can't seem to reproduce this issue (even with older releases). Files included via include are registered in the dep-info output. If you're still able to reproduce this, feel free to reopen.

@ehuss ehuss closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ehuss @wizeman @Centril @jonas-schievink