Skip to content

fix performance regressions due to statics no longer being inlined #18311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thestinger opened this issue Oct 25, 2014 · 1 comment
Closed

fix performance regressions due to statics no longer being inlined #18311

thestinger opened this issue Oct 25, 2014 · 1 comment
Assignees
@emberian
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

6c18e50 fixes one particularly bad instance of this, but a quick git grep static reveals more regressions across the standard library in places like core::char.
@thestinger thestinger added the I-slow Issue: Problems and improvements with respect to performance of generated code. label Oct 25, 2014
@thestinger thestinger mentioned this issue Oct 25, 2014
Closed
@emberian emberian self-assigned this Mar 25, 2015
@steveklabnik
Copy link
Member

While in theory some of this might be outstanding, it's been a year, and the compiler is undergoing a lot of work. core::char has no more static in it, and since we're actively working on performance, I think that this will just naturally resolve if it hasn't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emberian emberian

Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @emberian @thestinger