Updating only changed submodules Submodules updated in 0.01 seconds Finished dev [unoptimized + debuginfo] target(s) in 0.11s Checking std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) warning: redundant field names in struct initialization --> library/core/src/num/bignum.rs:122:34 | 96 | / macro_rules! define_bignum { 97 | | ($name:ident: type=$ty:ty, n=$n:expr) => { 98 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer. 99 | | /// ... | 122 | | $name { size: 1, base: base } | | ^^^^^^^^^^ help: replace it with: `base` ... | 461 | | }; 462 | | } | |_- in this expansion of `define_bignum!` ... 467 | define_bignum!(Big32x40: type=Digit32, n=40); | --------------------------------------------- in this macro invocation | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this `if` has identical blocks --> library/unwind/build.rs:12:62 | 12 | } else if target.contains("x86_64-fortanix-unknown-sgx") { | ______________________________________________________________^ 13 | | llvm_libunwind::compile(); 14 | | } else if target.contains("linux") { | |_____^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> library/unwind/build.rs:9:5 | 9 | / { 10 | | // Build the unwinding from libunwind C/C++ source code. 11 | | llvm_libunwind::compile(); 12 | | } else if target.contains("x86_64-fortanix-unknown-sgx") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this `if` has identical blocks --> library/unwind/build.rs:33:42 | 33 | } else if target.contains("illumos") { | __________________________________________^ 34 | | println!("cargo:rustc-link-lib=gcc_s"); 35 | | } else if target.contains("dragonfly") { | |_____^ | note: same as this --> library/unwind/build.rs:31:42 | 31 | } else if target.contains("solaris") { | __________________________________________^ 32 | | println!("cargo:rustc-link-lib=gcc_s"); 33 | | } else if target.contains("illumos") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this `if` has identical blocks --> library/unwind/build.rs:41:42 | 41 | } else if target.contains("fuchsia") { | __________________________________________^ 42 | | println!("cargo:rustc-link-lib=unwind"); 43 | | } else if target.contains("haiku") { | |_____^ | note: same as this --> library/unwind/build.rs:39:50 | 39 | } else if target.contains("uwp-windows-gnu") { | __________________________________________________^ 40 | | println!("cargo:rustc-link-lib=unwind"); 41 | | } else if target.contains("fuchsia") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: 3 warnings emitted warning: redundant field names in struct initialization --> library/core/src/num/bignum.rs:134:35 | 96 | / macro_rules! define_bignum { 97 | | ($name:ident: type=$ty:ty, n=$n:expr) => { 98 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer. 99 | | /// ... | 134 | | $name { size: sz, base: base } | | ^^^^^^^^^^ help: replace it with: `base` ... | 461 | | }; 462 | | } | |_- in this expansion of `define_bignum!` ... 467 | define_bignum!(Big32x40: type=Digit32, n=40); | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: redundant field names in struct initialization --> library/core/src/num/bignum.rs:122:34 | 96 | / macro_rules! define_bignum { 97 | | ($name:ident: type=$ty:ty, n=$n:expr) => { 98 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer. 99 | | /// ... | 122 | | $name { size: 1, base: base } | | ^^^^^^^^^^ help: replace it with: `base` ... | 461 | | }; 462 | | } | |_- in this expansion of `define_bignum!` ... 472 | define_bignum!(Big8x3: type=u8, n=3); | ------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: redundant field names in struct initialization --> library/core/src/num/bignum.rs:134:35 | 96 | / macro_rules! define_bignum { 97 | | ($name:ident: type=$ty:ty, n=$n:expr) => { 98 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer. 99 | | /// ... | 134 | | $name { size: sz, base: base } | | ^^^^^^^^^^ help: replace it with: `base` ... | 461 | | }; 462 | | } | |_- in this expansion of `define_bignum!` ... 472 | define_bignum!(Big8x3: type=u8, n=3); | ------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this `else { if .. }` block can be collapsed --> library/core/src/num/dec2flt/algorithm.rs:167:12 | 167 | } else { | ____________^ 168 | | if e >= 0 { 1 } else { 4 } 169 | | }; | |_____^ help: collapse nested if block: `if e >= 0 { 1 } else { 4 }` | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if warning: 7 bindings with single-character names in scope --> library/core/src/num/dec2flt/algorithm.rs:187:29 | 187 | fn algorithm_r(f: &Big, e: i16, z0: T) -> T { | ^ ^ 188 | let mut z = z0; | ^ ... 191 | let (m, k) = (raw.sig, raw.k); | ^ ^ 192 | let mut x = f.clone(); | ^ 193 | let mut y = Big::from_u64(m); | ^ | = note: `#[warn(clippy::many_single_char_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 7 bindings with single-character names in scope --> library/core/src/num/dec2flt/algorithm.rs:187:29 | 187 | fn algorithm_r(f: &Big, e: i16, z0: T) -> T { | ^ ^ 188 | let mut z = z0; | ^ ... 191 | let (m, k) = (raw.sig, raw.k); | ^ ^ 192 | let mut x = f.clone(); | ^ 193 | let mut y = Big::from_u64(m); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: this `else { if .. }` block can be collapsed --> library/core/src/num/dec2flt/algorithm.rs:263:12 | 263 | } else { | ____________^ 264 | | if k >= 0 { 265 | | // x = f, y = m * 10^abs(e) * 2^k 266 | | // This can't overflow either, see above. ... | 273 | | } 274 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 263 | } else if k >= 0 { 264 | // x = f, y = m * 10^abs(e) * 2^k 265 | // This can't overflow either, see above. 266 | y.mul_pow5(e_abs).mul_pow2(k_abs + e_abs); 267 | } else { 268 | // x = f * 2^abs(k), y = m * 10^abs(e), again reducing by a common power of two. ... warning: 5 bindings with single-character names in scope --> library/core/src/num/dec2flt/algorithm.rs:294:33 | 294 | pub fn algorithm_m(f: &Big, e: i16) -> T { | ^ ^ 295 | let mut u; | ^ 296 | let mut v; | ^ 297 | let e_abs = e.abs() as usize; 298 | let mut k = 0; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 6 bindings with single-character names in scope --> library/core/src/num/dec2flt/algorithm.rs:294:33 | 294 | pub fn algorithm_m(f: &Big, e: i16) -> T { | ^ ^ 295 | let mut u; | ^ 296 | let mut v; | ^ 297 | let e_abs = e.abs() as usize; 298 | let mut k = 0; | ^ ... 312 | let mut x = Big::from_small(0); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 8 bindings with single-character names in scope --> library/core/src/num/dec2flt/algorithm.rs:294:33 | 294 | pub fn algorithm_m(f: &Big, e: i16) -> T { | ^ ^ 295 | let mut u; | ^ 296 | let mut v; | ^ 297 | let e_abs = e.abs() as usize; 298 | let mut k = 0; | ^ ... 312 | let mut x = Big::from_small(0); | ^ ... 341 | let q = num::to_u64(&x); | ^ 342 | let z = rawfp::encode_normal(Unpacked::new(q, k)); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 5 bindings with single-character names in scope --> library/core/src/num/dec2flt/algorithm.rs:385:27 | 385 | fn underflow(x: Big, v: Big, rem: Big) -> T { | ^ ^ ... 406 | let q = num::get_bits(&x, lsb, bits); | ^ 407 | let k = T::MIN_EXP_INT + lsb as i16; | ^ 408 | let z = rawfp::encode_normal(Unpacked::new(q, k)); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 6 bindings with single-character names in scope --> library/core/src/num/diy_float.rs:26:13 | 26 | let a = self.f >> 32; | ^ 27 | let b = self.f & MASK; | ^ 28 | let c = other.f >> 32; | ^ 29 | let d = other.f & MASK; | ^ ... 35 | let f = ac + (ad >> 32) + (bc >> 32) + (tmp >> 32); | ^ 36 | let e = self.e + other.e + 64; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: this `else { if .. }` block can be collapsed --> library/core/src/num/flt2dec/strategy/grisu.rs:151:12 | 151 | } else { | ____________^ 152 | | if x < X6 { 153 | | if x < X5 { (4, X4) } else { (5, X5) } 154 | | } else if x < X8 { ... | 158 | | } 159 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 151 | } else if x < X6 { 152 | if x < X5 { (4, X4) } else { (5, X5) } 153 | } else if x < X8 { 154 | if x < X7 { (6, X6) } else { (7, X7) } 155 | } else { 156 | if x < X9 { (8, X8) } else { (9, X9) } ... warning: this `else { if .. }` block can be collapsed --> library/core/src/num/flt2dec/strategy/grisu.rs:148:16 | 148 | } else { | ________________^ 149 | | if x < X3 { (2, X2) } else { (3, X3) } 150 | | } | |_________^ help: collapse nested if block: `if x < X3 { (2, X2) } else { (3, X3) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if warning: this `else { if .. }` block can be collapsed --> library/core/src/num/flt2dec/strategy/grisu.rs:156:16 | 156 | } else { | ________________^ 157 | | if x < X9 { (8, X8) } else { (9, X9) } 158 | | } | |_________^ help: collapse nested if block: `if x < X9 { (8, X8) } else { (9, X9) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if warning: 6 bindings with single-character names in scope --> library/core/src/num/flt2dec/strategy/grisu.rs:166:5 | 166 | d: &Decoded, | ^ ... 180 | let v = Fp { f: d.mant, e: d.exp }.normalize_to(plus.e); | ^ ... 228 | let e = -plus.e as usize; // shared exponent | ^ ... 240 | let mut i = 0; | ^ ... 267 | let q = remainder / ten_kappa; | ^ 268 | let r = remainder % ten_kappa; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 6 bindings with single-character names in scope --> library/core/src/num/flt2dec/strategy/grisu.rs:166:5 | 166 | d: &Decoded, | ^ ... 180 | let v = Fp { f: d.mant, e: d.exp }.normalize_to(plus.e); | ^ ... 228 | let e = -plus.e as usize; // shared exponent | ^ ... 240 | let mut i = 0; | ^ ... 320 | let q = remainder >> e; | ^ 321 | let r = remainder & ((1 << e) - 1); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 6 bindings with single-character names in scope --> library/core/src/num/flt2dec/strategy/grisu.rs:476:5 | 476 | d: &Decoded, | ^ ... 485 | let v = Fp { f: d.mant, e: d.exp }.normalize(); | ^ ... 490 | let e = -v.e as usize; | ^ ... 511 | let mut i = 0; | ^ ... 551 | let q = remainder / ten_kappa; | ^ 552 | let r = remainder % ten_kappa; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 6 bindings with single-character names in scope --> library/core/src/num/flt2dec/strategy/grisu.rs:476:5 | 476 | d: &Decoded, | ^ ... 485 | let v = Fp { f: d.mant, e: d.exp }.normalize(); | ^ ... 490 | let e = -v.e as usize; | ^ ... 511 | let mut i = 0; | ^ ... 605 | let q = remainder >> e; | ^ 606 | let r = remainder & ((1 << e) - 1); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: this `else { if .. }` block can be collapsed --> library/core/src/num/flt2dec/mod.rs:198:24 | 198 | } else { | ________________________^ 199 | | if v < 10_000 { 4 } else { 5 } 200 | | } | |_________________^ help: collapse nested if block: `if v < 10_000 { 4 } else { 5 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if warning: this `else { if .. }` block can be collapsed --> library/core/src/fmt/builders.rs:201:20 | 201 | } else { | ____________________^ 202 | | if self.has_fields { 203 | | self.fmt.write_str(", ..")?; 204 | | } else { 205 | | self.fmt.write_str(" { ..")?; 206 | | } 207 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 201 | } else if self.has_fields { 202 | self.fmt.write_str(", ..")?; 203 | } else { 204 | self.fmt.write_str(" { ..")?; 205 | } | warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:684:13 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 684 | | ($smap)(($pmap)(self).into_searcher(haystack)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = note: `#[warn(clippy::redundant_closure_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:684:21 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 684 | | ($smap)(($pmap)(self).into_searcher(haystack)) | | ^^^^^^^^^^^^^ ... | 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:689:13 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 689 | | ($pmap)(self).is_contained_in(haystack) | | ^^^^^^^^^^^^^ ... | 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:694:13 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 694 | | ($pmap)(self).is_prefix_of(haystack) | | ^^^^^^^^^^^^^ ... | 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:699:13 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 699 | | ($pmap)(self).strip_prefix_of(haystack) | | ^^^^^^^^^^^^^ ... | 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:707:13 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 707 | | ($pmap)(self).is_suffix_of(haystack) | | ^^^^^^^^^^^^^ ... | 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: try not to call a closure in the expression where it is declared --> library/core/src/str/pattern.rs:715:13 | 678 | / macro_rules! pattern_methods { 679 | | ($t:ty, $pmap:expr, $smap:expr) => { 680 | | type Searcher = $t; 681 | | ... | 715 | | ($pmap)(self).strip_suffix_of(haystack) | | ^^^^^^^^^^^^^ 716 | | } 717 | | }; 718 | | } | |_- in this expansion of `pattern_methods!` ... 845 | pattern_methods!(StrSearcher<'a, 'b>, |&s| s, |s| s); | ----------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call warning: this `else { if .. }` block can be collapsed --> library/core/src/time.rs:524:20 | 524 | } else { | ____________________^ 525 | | if let Some(sub_secs) = secs.checked_sub(1) { 526 | | secs = sub_secs; 527 | | self.nanos + NANOS_PER_SEC - rhs.nanos ... | 530 | | } 531 | | }; | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 524 | } else if let Some(sub_secs) = secs.checked_sub(1) { 525 | secs = sub_secs; 526 | self.nanos + NANOS_PER_SEC - rhs.nanos 527 | } else { 528 | return None; 529 | }; | warning: module has the same name as its containing module --> library/core/src/future/mod.rs:12:1 | 12 | mod future; | ^^^^^^^^^^^ | = note: `#[warn(clippy::module_inception)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/fxsr.rs:9:27 | 9 | fn fxsave(p: *mut u8) -> (); | ^^^^^ help: remove the `-> ()` | = note: `#[warn(clippy::unused_unit)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/fxsr.rs:11:30 | 11 | fn fxrstor(p: *const u8) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:10:44 | 10 | fn xsave(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:12:47 | 12 | fn xrstor(p: *const u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:14:41 | 14 | fn xsetbv(v: u32, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:16:47 | 16 | fn xsaveopt(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:18:45 | 18 | fn xsavec(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:20:45 | 20 | fn xsaves(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:22:48 | 22 | fn xrstors(p: *const u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: using tabs in doc comments is not recommended --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1798:5 | 1798 | /// `mem_addr` does not need to be aligned on any particular boundary. | ^^^^ help: consider using four spaces per tab | = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments warning: 8 bindings with single-character names in scope --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2406:5 | 2406 | a: f32, | ^ 2407 | b: f32, | ^ 2408 | c: f32, | ^ 2409 | d: f32, | ^ 2410 | e: f32, | ^ 2411 | f: f32, | ^ 2412 | g: f32, | ^ 2413 | h: f32, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 8 bindings with single-character names in scope --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2555:5 | 2555 | a: f32, | ^ 2556 | b: f32, | ^ 2557 | c: f32, | ^ 2558 | d: f32, | ^ 2559 | e: f32, | ^ 2560 | f: f32, | ^ 2561 | g: f32, | ^ 2562 | h: f32, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/rtm.rs:23:19 | 23 | fn x86_xend() -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86/rtm.rs:25:29 | 25 | fn x86_xabort(imm8: i8) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/fxsr.rs:9:29 | 9 | fn fxsave64(p: *mut u8) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/fxsr.rs:11:32 | 11 | fn fxrstor64(p: *const u8) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:11:46 | 11 | fn xsave64(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:13:49 | 13 | fn xrstor64(p: *const u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:15:49 | 15 | fn xsaveopt64(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:17:47 | 17 | fn xsavec64(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:19:47 | 19 | fn xsaves64(p: *mut u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: unneeded unit return type --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:21:50 | 21 | fn xrstors64(p: *const u8, hi: u32, lo: u32) -> (); | ^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: float has excessive precision --> library/core/src/num/f32.rs:240:25 | 240 | pub const PI: f32 = 3.14159265358979323846264338327950288_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_7_f32` | = note: `#[warn(clippy::excessive_precision)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:246:26 | 246 | pub const TAU: f32 = 6.28318530717958647692528676655900577_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.283_185_5_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:250:32 | 250 | pub const FRAC_PI_2: f32 = 1.57079632679489661923132169163975144_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.570_796_4_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:254:32 | 254 | pub const FRAC_PI_3: f32 = 1.04719755119659774615421446109316763_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.047_197_6_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:258:32 | 258 | pub const FRAC_PI_4: f32 = 0.785398163397448309615660845819875721_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.785_398_2_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:262:32 | 262 | pub const FRAC_PI_6: f32 = 0.52359877559829887307710723054658381_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.523_598_8_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:266:32 | 266 | pub const FRAC_PI_8: f32 = 0.39269908169872415480783042290993786_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.392_699_1_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:270:32 | 270 | pub const FRAC_1_PI: f32 = 0.318309886183790671537767526745028724_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.318_309_87_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:274:32 | 274 | pub const FRAC_2_PI: f32 = 0.636619772367581343075535053490057448_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.636_619_75_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:278:37 | 278 | pub const FRAC_2_SQRT_PI: f32 = 1.12837916709551257389615890312154517_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.128_379_2_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:282:29 | 282 | pub const SQRT_2: f32 = 1.41421356237309504880168872420969808_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.414_213_5_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:286:36 | 286 | pub const FRAC_1_SQRT_2: f32 = 0.707106781186547524400844362104849039_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.707_106_77_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:290:24 | 290 | pub const E: f32 = 2.71828182845904523536028747135266250_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.718_281_7_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:294:29 | 294 | pub const LOG2_E: f32 = 1.44269504088896340735992468100189214_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.442_695_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:298:30 | 298 | pub const LOG2_10: f32 = 3.32192809488736234787031942948939018_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.321_928_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:302:30 | 302 | pub const LOG10_E: f32 = 0.434294481903251827651128918916605082_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.434_294_5_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:306:30 | 306 | pub const LOG10_2: f32 = 0.301029995663981195213738894724493027_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.301_03_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:310:27 | 310 | pub const LN_2: f32 = 0.693147180559945309417232121458176568_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.693_147_2_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:314:28 | 314 | pub const LN_10: f32 = 2.30258509299404568401799145468436421_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.302_585_1_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:338:30 | 338 | pub const EPSILON: f32 = 1.19209290e-07_f32; | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.192_092_9e-7_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:342:27 | 342 | pub const MIN: f32 = -3.40282347e+38_f32; | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:345:35 | 345 | pub const MIN_POSITIVE: f32 = 1.17549435e-38_f32; | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.175_494_4e-38_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f32.rs:348:26 | 348 | pub const MAX: f32 = 3.40282347e+38_f32; | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: equal expressions as operands to `/` --> library/core/src/num/f32.rs:366:26 | 366 | pub const NAN: f32 = 0.0_f32 / 0.0_f32; | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::eq_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op warning: constant division of `0.0` with `0.0` will always result in NaN --> library/core/src/num/f32.rs:366:26 | 366 | pub const NAN: f32 = 0.0_f32 / 0.0_f32; | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::zero_divided_by_zero)]` on by default = help: Consider using `f32::NAN` if you would like a constant representing NaN = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero warning: equal expressions as operands to `!=` --> library/core/src/num/f32.rs:387:9 | 387 | self != self | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op warning: float has excessive precision --> library/core/src/num/f32.rs:562:33 | 562 | const PIS_IN_180: f32 = 57.2957795130823208767981548141051703_f32; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `57.295_78_f32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:240:25 | 240 | pub const PI: f64 = 3.14159265358979323846264338327950288_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_653_589_793_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:246:26 | 246 | pub const TAU: f64 = 6.28318530717958647692528676655900577_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.283_185_307_179_586_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:250:32 | 250 | pub const FRAC_PI_2: f64 = 1.57079632679489661923132169163975144_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.570_796_326_794_896_6_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:254:32 | 254 | pub const FRAC_PI_3: f64 = 1.04719755119659774615421446109316763_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.047_197_551_196_597_9_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:258:32 | 258 | pub const FRAC_PI_4: f64 = 0.785398163397448309615660845819875721_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.785_398_163_397_448_3_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:262:32 | 262 | pub const FRAC_PI_6: f64 = 0.52359877559829887307710723054658381_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.523_598_775_598_298_9_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:266:32 | 266 | pub const FRAC_PI_8: f64 = 0.39269908169872415480783042290993786_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.392_699_081_698_724_14_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:270:32 | 270 | pub const FRAC_1_PI: f64 = 0.318309886183790671537767526745028724_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.318_309_886_183_790_7_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:274:32 | 274 | pub const FRAC_2_PI: f64 = 0.636619772367581343075535053490057448_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.636_619_772_367_581_4_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:278:37 | 278 | pub const FRAC_2_SQRT_PI: f64 = 1.12837916709551257389615890312154517_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.128_379_167_095_512_6_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:282:29 | 282 | pub const SQRT_2: f64 = 1.41421356237309504880168872420969808_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.414_213_562_373_095_1_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:286:36 | 286 | pub const FRAC_1_SQRT_2: f64 = 0.707106781186547524400844362104849039_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.707_106_781_186_547_6_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:290:24 | 290 | pub const E: f64 = 2.71828182845904523536028747135266250_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.718_281_828_459_045_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:294:30 | 294 | pub const LOG2_10: f64 = 3.32192809488736234787031942948939018_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.321_928_094_887_362_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:298:29 | 298 | pub const LOG2_E: f64 = 1.44269504088896340735992468100189214_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.442_695_040_888_963_4_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:302:30 | 302 | pub const LOG10_2: f64 = 0.301029995663981195213738894724493027_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.301_029_995_663_981_2_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:306:30 | 306 | pub const LOG10_E: f64 = 0.434294481903251827651128918916605082_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.434_294_481_903_251_8_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:310:27 | 310 | pub const LN_2: f64 = 0.693147180559945309417232121458176568_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.693_147_180_559_945_3_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:314:28 | 314 | pub const LN_10: f64 = 2.30258509299404568401799145468436421_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.302_585_092_994_046_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:337:30 | 337 | pub const EPSILON: f64 = 2.2204460492503131e-16_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.220_446_049_250_313e-16_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:341:27 | 341 | pub const MIN: f64 = -1.7976931348623157e+308_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.797_693_134_862_315_7e308_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: float has excessive precision --> library/core/src/num/f64.rs:347:26 | 347 | pub const MAX: f64 = 1.7976931348623157e+308_f64; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.797_693_134_862_315_7e308_f64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision warning: equal expressions as operands to `/` --> library/core/src/num/f64.rs:365:26 | 365 | pub const NAN: f64 = 0.0_f64 / 0.0_f64; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op warning: constant division of `0.0` with `0.0` will always result in NaN --> library/core/src/num/f64.rs:365:26 | 365 | pub const NAN: f64 = 0.0_f64 / 0.0_f64; | ^^^^^^^^^^^^^^^^^ | = help: Consider using `f64::NAN` if you would like a constant representing NaN = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero warning: equal expressions as operands to `!=` --> library/core/src/num/f64.rs:386:9 | 386 | self != self | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op warning: strict comparison of `f32` or `f64` --> library/core/src/num/dec2flt/rawfp.rs:175:23 | 175 | debug_assert!(x as f32 == fp_to_float(Fp { f: x, e: 0 })); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(x as f32 - fp_to_float(Fp { f: x, e: 0 })).abs() < error_margin` | = note: `#[warn(clippy::float_cmp)]` on by default = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp warning: strict comparison of `f32` or `f64` --> library/core/src/num/dec2flt/rawfp.rs:227:23 | 227 | debug_assert!(x as f64 == fp_to_float(Fp { f: x, e: 0 })); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(x as f64 - fp_to_float(Fp { f: x, e: 0 })).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp warning: this `if` has identical blocks --> library/core/src/num/dec2flt/rawfp.rs:272:43 | 272 | } else if rem == half && (q % 2) == 0 { | ___________________________________________^ 273 | | Unpacked::new(q, k) 274 | | } else if q == T::MAX_SIG { | |_____^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> library/core/src/num/dec2flt/rawfp.rs:270:19 | 270 | if rem < half { | ___________________^ 271 | | Unpacked::new(q, k) 272 | | } else if rem == half && (q % 2) == 0 { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false --> library/core/src/num/diy_float.rs:68:23 | 68 | debug_assert!(f >= (1 >> 63)); | ^^^^^^^^^^^^^^ | = note: `#[warn(clippy::absurd_extreme_comparisons)]` on by default = help: because `(1 >> 63)` is the minimum value for this type, this comparison is always true = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons warning: you are trying to use classic C underflow conditions that will fail in Rust --> library/core/src/num/flt2dec/strategy/grisu.rs:702:12 | 702 | if ten_kappa - remainder > remainder && ten_kappa - 2 * remainder >= 2 * ulp { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::overflow_check_conditional)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#overflow_check_conditional warning: the loop variable `j` is only used to index `d`. --> library/core/src/num/flt2dec/mod.rs:153:22 | 153 | for j in i + 1..d.len() { | ^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_range_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 153 | for in d.iter_mut().skip(i + 1) { | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ warning: length comparison to zero --> library/core/src/num/flt2dec/mod.rs:158:17 | 158 | None if d.len() > 0 => { | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!d.is_empty()` | = note: `#[warn(clippy::len_zero)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: the loop variable `j` is only used to index `d`. --> library/core/src/num/flt2dec/mod.rs:161:22 | 161 | for j in 1..d.len() { | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 161 | for in d.iter_mut().skip(1) { | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ warning: item `num::flt2dec::Part<'a>` has a public `len` method but no corresponding `is_empty` method --> library/core/src/num/flt2dec/mod.rs:184:1 | 184 | / impl<'a> Part<'a> { 185 | | /// Returns the exact byte length of given part. 186 | | pub fn len(&self) -> usize { 187 | | match *self { ... | 232 | | } 233 | | } | |_^ | = note: `#[warn(clippy::len_without_is_empty)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: item `num::flt2dec::Formatted<'a>` has a public `len` method but no corresponding `is_empty` method --> library/core/src/num/flt2dec/mod.rs:246:1 | 246 | / impl<'a> Formatted<'a> { 247 | | /// Returns the exact byte length of combined formatted result. 248 | | pub fn len(&self) -> usize { 249 | | let mut len = self.sign.len(); ... | 271 | | } 272 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/wrapping.rs:633:38 | 403 | / macro_rules! wrapping_int_impl { 404 | | ($($t:ty)*) => ($( 405 | | impl Wrapping<$t> { 406 | | doc_comment! { ... | 633 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 755 | | )*) 756 | | } | |_- in this expansion of `wrapping_int_impl!` 757 | 758 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 } | -------------------------------------------------------------------------- in this macro invocation | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/wrapping.rs:662:38 | 403 | / macro_rules! wrapping_int_impl { 404 | | ($($t:ty)*) => ($( 405 | | impl Wrapping<$t> { 406 | | doc_comment! { ... | 662 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 755 | | )*) 756 | | } | |_- in this expansion of `wrapping_int_impl!` 757 | 758 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 } | -------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/wrapping.rs:633:38 | 403 | / macro_rules! wrapping_int_impl { 404 | | ($($t:ty)*) => ($( 405 | | impl Wrapping<$t> { 406 | | doc_comment! { ... | 633 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 755 | | )*) 756 | | } | |_- in this expansion of `wrapping_int_impl!` 757 | 758 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 } | -------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:320:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 320 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:93:5 | 93 | / int_impl! { i8, i8, u8, 8, -128, 127, "", "", 2, "-0x7e", "0xa", "0x12", "0x12", "0x48", 94 | | "[0x12]", "[0x12]", "", "" } | |_________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:354:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 354 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:93:5 | 93 | / int_impl! { i8, i8, u8, 8, -128, 127, "", "", 2, "-0x7e", "0xa", "0x12", "0x12", "0x48", 94 | | "[0x12]", "[0x12]", "", "" } | |_________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:320:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 320 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:99:5 | 99 | / int_impl! { i16, i16, u16, 16, -32768, 32767, "", "", 4, "-0x5ffd", "0x3a", "0x1234", "0x3412", 100 | | "0x2c48", "[0x34, 0x12]", "[0x12, 0x34]", "", "" } | |_______________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:354:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 354 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:99:5 | 99 | / int_impl! { i16, i16, u16, 16, -32768, 32767, "", "", 4, "-0x5ffd", "0x3a", "0x1234", "0x3412", 100 | | "0x2c48", "[0x34, 0x12]", "[0x12, 0x34]", "", "" } | |_______________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:320:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 320 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:105:5 | 105 | / int_impl! { i32, i32, u32, 32, -2147483648, 2147483647, "", "", 8, "0x10000b3", "0xb301", 106 | | "0x12345678", "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]", 107 | | "[0x12, 0x34, 0x56, 0x78]", "", "" } | |_________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:354:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 354 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:105:5 | 105 | / int_impl! { i32, i32, u32, 32, -2147483648, 2147483647, "", "", 8, "0x10000b3", "0xb301", 106 | | "0x12345678", "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]", 107 | | "[0x12, 0x34, 0x56, 0x78]", "", "" } | |_________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:320:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 320 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:112:5 | 112 | / int_impl! { i64, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 12, 113 | | "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412", 114 | | "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 115 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", "", "" } | |_________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:354:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 354 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:112:5 | 112 | / int_impl! { i64, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 12, 113 | | "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412", 114 | | "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 115 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", "", "" } | |_________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:320:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 320 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:120:5 | 120 | / int_impl! { i128, i128, u128, 128, -170141183460469231731687303715884105728, 121 | | 170141183460469231731687303715884105727, "", "", 16, 122 | | "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012", 123 | | "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48", ... | 126 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56, \ 127 | | 0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", "", "" } | |_________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:354:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 354 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:120:5 | 120 | / int_impl! { i128, i128, u128, 128, -170141183460469231731687303715884105728, 121 | | 170141183460469231731687303715884105727, "", "", 16, 122 | | "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012", 123 | | "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48", ... | 126 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56, \ 127 | | 0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", "", "" } | |_________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:320:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 320 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:150:5 | 150 | / int_impl! { isize, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 151 | | 12, "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412", 152 | | "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 153 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", 154 | | usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() } | |________________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/int_macros.rs:354:34 | 1 | / macro_rules! int_impl { 2 | | ($SelfT:ty, $ActualT:ident, $UnsignedT:ty, $BITS:expr, $Min:expr, $Max:expr, $Feature:expr, 3 | | $EndFeature:expr, $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 354 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 2237 | | } 2238 | | } | |_- in this expansion of `int_impl!` | ::: library/core/src/num/mod.rs:150:5 | 150 | / int_impl! { isize, i64, u64, 64, -9223372036854775808, 9223372036854775807, "", "", 151 | | 12, "0xaa00000000006e1", "0x6e10aa", "0x1234567890123456", "0x5634129078563412", 152 | | "0x6a2c48091e6a2c48", "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 153 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", 154 | | usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() } | |________________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:318:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 318 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:159:5 | 159 | / uint_impl! { u8, u8, 8, 255, "", "", 2, "0x82", "0xa", "0x12", "0x12", "0x48", "[0x12]", 160 | | "[0x12]", "", "" } | |_______________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:352:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 352 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:159:5 | 159 | / uint_impl! { u8, u8, 8, 255, "", "", 2, "0x82", "0xa", "0x12", "0x12", "0x48", "[0x12]", 160 | | "[0x12]", "", "" } | |_______________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:318:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 318 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:658:5 | 658 | / uint_impl! { u16, u16, 16, 65535, "", "", 4, "0xa003", "0x3a", "0x1234", "0x3412", "0x2c48", 659 | | "[0x34, 0x12]", "[0x12, 0x34]", "", "" } | |_____________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:352:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 352 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:658:5 | 658 | / uint_impl! { u16, u16, 16, 65535, "", "", 4, "0xa003", "0x3a", "0x1234", "0x3412", "0x2c48", 659 | | "[0x34, 0x12]", "[0x12, 0x34]", "", "" } | |_____________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:318:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 318 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:664:5 | 664 | / uint_impl! { u32, u32, 32, 4294967295, "", "", 8, "0x10000b3", "0xb301", "0x12345678", 665 | | "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]", "[0x12, 0x34, 0x56, 0x78]", "", "" } | |_________________________________________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:352:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 352 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:664:5 | 664 | / uint_impl! { u32, u32, 32, 4294967295, "", "", 8, "0x10000b3", "0xb301", "0x12345678", 665 | | "0x78563412", "0x1e6a2c48", "[0x78, 0x56, 0x34, 0x12]", "[0x12, 0x34, 0x56, 0x78]", "", "" } | |_________________________________________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:318:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 318 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:670:5 | 670 | / uint_impl! { u64, u64, 64, 18446744073709551615, "", "", 12, "0xaa00000000006e1", "0x6e10aa", 671 | | "0x1234567890123456", "0x5634129078563412", "0x6a2c48091e6a2c48", 672 | | "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 673 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", 674 | | "", ""} | |____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:352:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 352 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:670:5 | 670 | / uint_impl! { u64, u64, 64, 18446744073709551615, "", "", 12, "0xaa00000000006e1", "0x6e10aa", 671 | | "0x1234567890123456", "0x5634129078563412", "0x6a2c48091e6a2c48", 672 | | "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 673 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", 674 | | "", ""} | |____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:318:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 318 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:679:5 | 679 | / uint_impl! { u128, u128, 128, 340282366920938463463374607431768211455, "", "", 16, 680 | | "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012", 681 | | "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48", 682 | | "[0x12, 0x90, 0x78, 0x56, 0x34, 0x12, 0x90, 0x78, \ ... | 685 | | 0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", 686 | | "", ""} | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:352:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 352 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:679:5 | 679 | / uint_impl! { u128, u128, 128, 340282366920938463463374607431768211455, "", "", 16, 680 | | "0x13f40000000000000000000000004f76", "0x4f7613f4", "0x12345678901234567890123456789012", 681 | | "0x12907856341290785634129078563412", "0x48091e6a2c48091e6a2c48091e6a2c48", 682 | | "[0x12, 0x90, 0x78, 0x56, 0x34, 0x12, 0x90, 0x78, \ ... | 685 | | 0x78, 0x90, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12]", 686 | | "", ""} | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:318:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 318 | | pub const fn from_be(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:707:5 | 707 | / uint_impl! { usize, u64, 64, 18446744073709551615, "", "", 12, "0xaa00000000006e1", "0x6e10aa", 708 | | "0x1234567890123456", "0x5634129078563412", "0x6a2c48091e6a2c48", 709 | | "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 710 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", 711 | | usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() } | |_______________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/core/src/num/uint_macros.rs:352:34 | 1 | / macro_rules! uint_impl { 2 | | ($SelfT:ty, $ActualT:ty, $BITS:expr, $MaxV:expr, $Feature:expr, $EndFeature:expr, 3 | | $rot:expr, $rot_op:expr, $rot_result:expr, $swap_op:expr, $swapped:expr, 4 | | $reversed:expr, $le_bytes:expr, $be_bytes:expr, ... | 352 | | pub const fn from_le(x: Self) -> Self { | | ^ ... | 1991 | | } 1992 | | } | |_- in this expansion of `uint_impl!` | ::: library/core/src/num/mod.rs:707:5 | 707 | / uint_impl! { usize, u64, 64, 18446744073709551615, "", "", 12, "0xaa00000000006e1", "0x6e10aa", 708 | | "0x1234567890123456", "0x5634129078563412", "0x6a2c48091e6a2c48", 709 | | "[0x56, 0x34, 0x12, 0x90, 0x78, 0x56, 0x34, 0x12]", 710 | | "[0x12, 0x34, 0x56, 0x78, 0x90, 0x12, 0x34, 0x56]", 711 | | usize_isize_to_xe_bytes_doc!(), usize_isize_from_xe_bytes_doc!() } | |_______________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: unsafe function's docs miss `# Safety` section --> library/core/src/mem/mod.rs:620:1 | 620 | / pub unsafe fn zeroed() -> T { 621 | | // SAFETY: the caller must guarantee that an all-zero value is valid for `T`. 622 | | unsafe { 623 | | intrinsics::assert_zero_valid::(); 624 | | MaybeUninit::zeroed().assume_init() 625 | | } 626 | | } | |_^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/mem/mod.rs:656:1 | 656 | / pub unsafe fn uninitialized() -> T { 657 | | // SAFETY: the caller must guarantee that an unitialized value is valid for `T`. 658 | | unsafe { 659 | | intrinsics::assert_uninit_valid::(); 660 | | MaybeUninit::uninit().assume_init() 661 | | } 662 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this call for this type may be undefined behavior --> library/core/src/mem/mod.rs:660:9 | 660 | MaybeUninit::uninit().assume_init() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::uninit_assumed_init)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninit_assumed_init warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` --> library/core/src/mem/mod.rs:750:5 | 750 | replace(dest, T::default()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(dest)` | = note: `#[warn(clippy::mem_replace_with_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default warning: unsafe function's docs miss `# Safety` section --> library/core/src/mem/mod.rs:926:1 | 926 | / pub unsafe fn transmute_copy(src: &T) -> U { 927 | | // If U has a higher alignment requirement, src may not be suitably aligned. 928 | | if align_of::() > align_of::() { 929 | | // SAFETY: `src` is a reference which is guaranteed to be valid for reads. ... | 937 | | } 938 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this public function dereferences a raw pointer but is not marked `unsafe` --> library/core/src/ptr/non_null.rs:165:47 | 165 | Some(unsafe { Self::new_unchecked(ptr) }) | ^^^ | = note: `#[warn(clippy::not_unsafe_ptr_arg_deref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref warning: item `ptr::non_null::NonNull<[T]>` has a public `len` method but no corresponding `is_empty` method --> library/core/src/ptr/non_null.rs:261:1 | 261 | / impl NonNull<[T]> { 262 | | /// Creates a non-null raw slice from a thin pointer and a length. 263 | | /// 264 | | /// The `len` argument is the number of **elements**, not the number of bytes. ... | 490 | | } 491 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: mutable borrow from immutable input(s) --> library/core/src/ptr/non_null.rs:455:49 | 455 | pub unsafe fn as_uninit_slice_mut(&self) -> &mut [MaybeUninit] { | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::mut_from_ref)]` on by default note: immutable borrow here --> library/core/src/ptr/non_null.rs:455:39 | 455 | pub unsafe fn as_uninit_slice_mut(&self) -> &mut [MaybeUninit] { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/non_null.rs:483:5 | 483 | / pub unsafe fn get_unchecked_mut(self, index: I) -> NonNull 484 | | where 485 | | I: SliceIndex<[T]>, 486 | | { ... | 489 | | unsafe { NonNull::new_unchecked(self.as_ptr().get_unchecked_mut(index)) } 490 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/unique.rs:115:5 | 115 | / pub unsafe fn as_ref(&self) -> &T { 116 | | // SAFETY: the caller must guarantee that `self` meets all the 117 | | // requirements for a reference. 118 | | unsafe { &*self.as_ptr() } 119 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/unique.rs:127:5 | 127 | / pub unsafe fn as_mut(&mut self) -> &mut T { 128 | | // SAFETY: the caller must guarantee that `self` meets all the 129 | | // requirements for a mutable reference. 130 | | unsafe { &mut *self.as_ptr() } 131 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: use of `offset` with a `usize` casted to an `isize` --> library/core/src/ptr/const_ptr.rs:499:18 | 499 | unsafe { self.offset(count as isize) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.add(count)` | = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: use of `wrapping_offset` with a `usize` casted to an `isize` --> library/core/src/ptr/const_ptr.rs:620:9 | 620 | self.wrapping_offset(count as isize) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.wrapping_add(count)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/const_ptr.rs:729:5 | 729 | / pub unsafe fn read(self) -> T 730 | | where 731 | | T: Sized, 732 | | { 733 | | // SAFETY: the caller must uphold the safety contract for `read`. 734 | | unsafe { read(self) } 735 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/const_ptr.rs:749:5 | 749 | / pub unsafe fn read_volatile(self) -> T 750 | | where 751 | | T: Sized, 752 | | { 753 | | // SAFETY: the caller must uphold the safety contract for `read_volatile`. 754 | | unsafe { read_volatile(self) } 755 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/const_ptr.rs:767:5 | 767 | / pub unsafe fn read_unaligned(self) -> T 768 | | where 769 | | T: Sized, 770 | | { 771 | | // SAFETY: the caller must uphold the safety contract for `read_unaligned`. 772 | | unsafe { read_unaligned(self) } 773 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/const_ptr.rs:785:5 | 785 | / pub unsafe fn copy_to(self, dest: *mut T, count: usize) 786 | | where 787 | | T: Sized, 788 | | { 789 | | // SAFETY: the caller must uphold the safety contract for `copy`. 790 | | unsafe { copy(self, dest, count) } 791 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/const_ptr.rs:803:5 | 803 | / pub unsafe fn copy_to_nonoverlapping(self, dest: *mut T, count: usize) 804 | | where 805 | | T: Sized, 806 | | { 807 | | // SAFETY: the caller must uphold the safety contract for `copy_nonoverlapping`. 808 | | unsafe { copy_nonoverlapping(self, dest, count) } 809 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: item `*const [T]` has a public `len` method but no corresponding `is_empty` method --> library/core/src/ptr/const_ptr.rs:864:1 | 864 | / impl *const [T] { 865 | | /// Returns the length of a raw slice. 866 | | /// 867 | | /// The returned value is the number of **elements**, not the number of bytes. ... | 987 | | } 988 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/const_ptr.rs:932:5 | 932 | / pub unsafe fn get_unchecked(self, index: I) -> *const I::Output 933 | | where 934 | | I: SliceIndex<[T]>, 935 | | { 936 | | // SAFETY: the caller ensures that `self` is dereferencable and `index` in-bounds. 937 | | unsafe { index.get_unchecked(self) } 938 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:453:5 | 453 | / pub const unsafe fn guaranteed_ne(self, other: *mut T) -> bool 454 | | where 455 | | T: Sized, 456 | | { 457 | | intrinsics::ptr_guaranteed_ne(self as *const _, other as *const _) 458 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: use of `offset` with a `usize` casted to an `isize` --> library/core/src/ptr/mut_ptr.rs:606:18 | 606 | unsafe { self.offset(count as isize) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.add(count)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: use of `wrapping_offset` with a `usize` casted to an `isize` --> library/core/src/ptr/mut_ptr.rs:727:9 | 727 | self.wrapping_offset(count as isize) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.wrapping_add(count)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:836:5 | 836 | / pub unsafe fn read(self) -> T 837 | | where 838 | | T: Sized, 839 | | { 840 | | // SAFETY: the caller must uphold the safety contract for ``. 841 | | unsafe { read(self) } 842 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:856:5 | 856 | / pub unsafe fn read_volatile(self) -> T 857 | | where 858 | | T: Sized, 859 | | { 860 | | // SAFETY: the caller must uphold the safety contract for `read_volatile`. 861 | | unsafe { read_volatile(self) } 862 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:874:5 | 874 | / pub unsafe fn read_unaligned(self) -> T 875 | | where 876 | | T: Sized, 877 | | { 878 | | // SAFETY: the caller must uphold the safety contract for `read_unaligned`. 879 | | unsafe { read_unaligned(self) } 880 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:892:5 | 892 | / pub unsafe fn copy_to(self, dest: *mut T, count: usize) 893 | | where 894 | | T: Sized, 895 | | { 896 | | // SAFETY: the caller must uphold the safety contract for `copy`. 897 | | unsafe { copy(self, dest, count) } 898 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:910:5 | 910 | / pub unsafe fn copy_to_nonoverlapping(self, dest: *mut T, count: usize) 911 | | where 912 | | T: Sized, 913 | | { 914 | | // SAFETY: the caller must uphold the safety contract for `copy_nonoverlapping`. 915 | | unsafe { copy_nonoverlapping(self, dest, count) } 916 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:928:5 | 928 | / pub unsafe fn copy_from(self, src: *const T, count: usize) 929 | | where 930 | | T: Sized, 931 | | { 932 | | // SAFETY: the caller must uphold the safety contract for `copy`. 933 | | unsafe { copy(src, self, count) } 934 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:946:5 | 946 | / pub unsafe fn copy_from_nonoverlapping(self, src: *const T, count: usize) 947 | | where 948 | | T: Sized, 949 | | { 950 | | // SAFETY: the caller must uphold the safety contract for `copy_nonoverlapping`. 951 | | unsafe { copy_nonoverlapping(src, self, count) } 952 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:961:5 | 961 | / pub unsafe fn drop_in_place(self) { 962 | | // SAFETY: the caller must uphold the safety contract for `drop_in_place`. 963 | | unsafe { drop_in_place(self) } 964 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:974:5 | 974 | / pub unsafe fn write(self, val: T) 975 | | where 976 | | T: Sized, 977 | | { 978 | | // SAFETY: the caller must uphold the safety contract for `write`. 979 | | unsafe { write(self, val) } 980 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:990:5 | 990 | / pub unsafe fn write_bytes(self, val: u8, count: usize) 991 | | where 992 | | T: Sized, 993 | | { 994 | | // SAFETY: the caller must uphold the safety contract for `write_bytes`. 995 | | unsafe { write_bytes(self, val, count) } 996 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:1010:5 | 1010 | / pub unsafe fn write_volatile(self, val: T) 1011 | | where 1012 | | T: Sized, 1013 | | { 1014 | | // SAFETY: the caller must uphold the safety contract for `write_volatile`. 1015 | | unsafe { write_volatile(self, val) } 1016 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:1028:5 | 1028 | / pub unsafe fn write_unaligned(self, val: T) 1029 | | where 1030 | | T: Sized, 1031 | | { 1032 | | // SAFETY: the caller must uphold the safety contract for `write_unaligned`. 1033 | | unsafe { write_unaligned(self, val) } 1034 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:1044:5 | 1044 | / pub unsafe fn replace(self, src: T) -> T 1045 | | where 1046 | | T: Sized, 1047 | | { 1048 | | // SAFETY: the caller must uphold the safety contract for `replace`. 1049 | | unsafe { replace(self, src) } 1050 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:1061:5 | 1061 | / pub unsafe fn swap(self, with: *mut T) 1062 | | where 1063 | | T: Sized, 1064 | | { 1065 | | // SAFETY: the caller must uphold the safety contract for `swap`. 1066 | | unsafe { swap(self, with) } 1067 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: item `*mut [T]` has a public `len` method but no corresponding `is_empty` method --> library/core/src/ptr/mut_ptr.rs:1122:1 | 1122 | / impl *mut [T] { 1123 | | /// Returns the length of a raw slice. 1124 | | /// 1125 | | /// The returned value is the number of **elements**, not the number of bytes. ... | 1299 | | } 1300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: unsafe function's docs miss `# Safety` section --> library/core/src/ptr/mut_ptr.rs:1189:5 | 1189 | / pub unsafe fn get_unchecked_mut(self, index: I) -> *mut I::Output 1190 | | where 1191 | | I: SliceIndex<[T]>, 1192 | | { 1193 | | // SAFETY: the caller ensures that `self` is dereferencable and `index` in-bounds. 1194 | | unsafe { index.get_unchecked_mut(self) } 1195 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: needless `fn main` in doctest --> library/core/src/clone.rs:25:4 | 25 | //! #[derive(Clone)] // we add the Clone trait to Morpheus struct | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_doctest_main)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/cmp.rs:1072:9 | 1072 | / fn ne(&self, _other: &()) -> bool { 1073 | | false 1074 | | } | |_________^ | = note: `#[warn(clippy::partialeq_ne_impl)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/cmp.rs:1060:17 | 1053 | / macro_rules! partial_eq_impl { 1054 | | ($($t:ty)*) => ($( 1055 | | #[stable(feature = "rust1", since = "1.0.0")] 1056 | | impl PartialEq for $t { ... | 1060 | | fn ne(&self, other: &$t) -> bool { (*self) != (*other) } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1061 | | } 1062 | | )*) 1063 | | } | |_____- in this expansion of `partial_eq_impl!` ... 1077 | / partial_eq_impl! { 1078 | | bool char usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 f32 f64 1079 | | } | |_____- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/cmp.rs:1228:9 | 1228 | / fn ne(&self, other: &&B) -> bool { 1229 | | PartialEq::ne(*self, *other) 1230 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/cmp.rs:1283:9 | 1283 | / fn ne(&self, other: &&mut B) -> bool { 1284 | | PartialEq::ne(*self, *other) 1285 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/cmp.rs:1336:9 | 1336 | / fn ne(&self, other: &&mut B) -> bool { 1337 | | PartialEq::ne(*self, *other) 1338 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/cmp.rs:1351:9 | 1351 | / fn ne(&self, other: &&B) -> bool { 1352 | | PartialEq::ne(*self, *other) 1353 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: needless `fn main` in doctest --> library/core/src/default.rs:125:4 | 125 | /// #![feature(default_free_fn)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/core/src/ops/drop.rs:29:4 | 29 | /// struct HasDrop; | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/core/src/ops/drop.rs:96:4 | 96 | /// struct Foo; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/core/src/ops/generator.rs:42:4 | 42 | /// #![feature(generators, generator_trait)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:221:5 | 221 | / fn ne(&self, other: &[B; N]) -> bool { 222 | | self[..] != other[..] 223 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:236:5 | 236 | / fn ne(&self, other: &[B]) -> bool { 237 | | self[..] != other[..] 238 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:251:5 | 251 | / fn ne(&self, other: &[A; N]) -> bool { 252 | | self[..] != other[..] 253 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:266:5 | 266 | / fn ne(&self, other: &&'b [B]) -> bool { 267 | | self[..] != other[..] 268 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:281:5 | 281 | / fn ne(&self, other: &[A; N]) -> bool { 282 | | self[..] != other[..] 283 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:296:5 | 296 | / fn ne(&self, other: &&'b mut [B]) -> bool { 297 | | self[..] != other[..] 298 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/array/mod.rs:311:5 | 311 | / fn ne(&self, other: &[A; N]) -> bool { 312 | | self[..] != other[..] 313 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: some ranges overlap --> library/core/src/ascii.rs:99:9 | 99 | b'\x20'..=b'\x7e' => ([c, 0, 0, 0], 1), | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_overlapping_arm)]` on by default note: overlaps with this --> library/core/src/ascii.rs:98:9 | 98 | b'"' => ([b'\\', b'"', 0, 0], 2), | ^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm warning: needless `fn main` in doctest --> library/core/src/cell.rs:70:4 | 70 | //! use std::cell::{RefCell, RefMut}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: method `clone` can be confused for the standard trait method `std::clone::Clone::clone` --> library/core/src/cell.rs:1234:5 | 1234 | / pub fn clone(orig: &Ref<'b, T>) -> Ref<'b, T> { 1235 | | Ref { value: orig.value, borrow: orig.borrow.clone() } 1236 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::clone::Clone` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: transmute from a `u32` to a `char` --> library/core/src/char/convert.rs:93:78 | 93 | if cfg!(debug_assertions) { char::from_u32(i).unwrap() } else { unsafe { transmute(i) } } | ^^^^^^^^^^^^ help: consider using: `std::char::from_u32(i).unwrap()` | = note: `#[warn(clippy::transmute_int_to_char)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_char warning: transmute from a `u32` to a `char` --> library/core/src/char/convert.rs:212:25 | 212 | Ok(unsafe { transmute(i) }) | ^^^^^^^^^^^^ help: consider using: `std::char::from_u32(i).unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_char warning: use of `.to_digit(..).is_some()` --> library/core/src/char/methods.rs:288:9 | 288 | self.to_digit(radix).is_some() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.is_digit(radix)` | = note: `#[warn(clippy::to_digit_is_some)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_digit_is_some warning: unsafe function's docs miss `# Safety` section --> library/core/src/ffi.rs:337:5 | 337 | / pub unsafe fn arg(&mut self) -> T { 338 | | // SAFETY: the caller must uphold the safety contract for `va_arg`. 339 | | unsafe { va_arg(self) } 340 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/ffi.rs:343:5 | 343 | / pub unsafe fn with_copy(&self, f: F) -> R 344 | | where 345 | | F: for<'copy> FnOnce(VaList<'copy, 'f>) -> R, 346 | | { ... | 353 | | ret 354 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. --> library/core/src/iter/adapters/flatten.rs:324:41 | 324 | fn fold(self, init: Acc, ref mut fold: Fold) -> Acc | ^^^^^^^^^^^^ | = note: `#[warn(clippy::toplevel_ref_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. --> library/core/src/iter/adapters/flatten.rs:404:42 | 404 | fn rfold(self, init: Acc, ref mut fold: Fold) -> Acc | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. --> library/core/src/iter/traits/iterator.rs:1754:51 | 1754 | fn partition_in_place<'a, T: 'a, P>(mut self, ref mut predicate: P) -> usize | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg warning: this loop could be written as a `for` loop --> library/core/src/iter/traits/iterator.rs:1887:9 | 1887 | while let Some(x) = self.next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in self` | = note: `#[warn(clippy::while_let_on_iterator)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator warning: this loop could be written as a `for` loop --> library/core/src/iter/traits/iterator.rs:2022:9 | 2022 | while let Some(x) = self.next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator warning: this loop could be written as a `for` loop --> library/core/src/iter/traits/iterator.rs:3236:9 | 3236 | while let Some(curr) = self.next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for curr in self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator warning: use `as_ref()` instead --> library/core/src/option.rs:276:9 | 276 | / match *self { 277 | | Some(ref x) => Some(x), 278 | | None => None, 279 | | } | |_________^ help: try this: `*self.as_ref()` | = note: `#[warn(clippy::match_as_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref warning: use `as_mut()` instead --> library/core/src/option.rs:297:9 | 297 | / match *self { 298 | | Some(ref mut x) => Some(x), 299 | | None => None, 300 | | } | |_________^ help: try this: `*self.as_mut()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name --> library/core/src/option.rs:306:23 | 306 | pub fn as_pin_ref(self: Pin<&Self>) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name --> library/core/src/option.rs:315:23 | 315 | pub fn as_pin_mut(self: Pin<&mut Self>) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: redundant pattern matching, consider using `is_none()` --> library/core/src/option.rs:868:16 | 868 | if let None = *self { | -------^^^^-------- help: try this: `if *self.is_none()` | = note: `#[warn(clippy::redundant_pattern_matching)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching warning: you are using an explicit closure for copying elements --> library/core/src/option.rs:1003:9 | 1003 | self.map(|&t| t) | ^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.copied()` | = note: `#[warn(clippy::map_clone)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone warning: you are using an explicit closure for cloning elements --> library/core/src/option.rs:1041:9 | 1041 | self.map(|t| t.clone()) | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone warning: you are using an explicit closure for cloning elements --> library/core/src/option.rs:1060:9 | 1060 | self.map(|t| t.clone()) | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/pin.rs:420:5 | 420 | / fn ne(&self, other: &Pin) -> bool { 421 | | P::Target::ne(self, other) 422 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: needless `fn main` in doctest --> library/core/src/sync/atomic.rs:72:4 | 72 | //! use std::sync::Arc; | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:288:1 | 288 | pub const ATOMIC_BOOL_INIT: AtomicBool = AtomicBool::new(false); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2089 | / atomic_int! { 2090 | | cfg(target_has_atomic = "8"), 2091 | | cfg(target_has_atomic_equal_alignment = "8"), 2092 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2105 | | i8 AtomicI8 ATOMIC_I8_INIT 2106 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2108 | / atomic_int! { 2109 | | cfg(target_has_atomic = "8"), 2110 | | cfg(target_has_atomic_equal_alignment = "8"), 2111 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2124 | | u8 AtomicU8 ATOMIC_U8_INIT 2125 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2127 | / atomic_int! { 2128 | | cfg(target_has_atomic = "16"), 2129 | | cfg(target_has_atomic_equal_alignment = "16"), 2130 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2143 | | i16 AtomicI16 ATOMIC_I16_INIT 2144 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2146 | / atomic_int! { 2147 | | cfg(target_has_atomic = "16"), 2148 | | cfg(target_has_atomic_equal_alignment = "16"), 2149 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2162 | | u16 AtomicU16 ATOMIC_U16_INIT 2163 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2165 | / atomic_int! { 2166 | | cfg(target_has_atomic = "32"), 2167 | | cfg(target_has_atomic_equal_alignment = "32"), 2168 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2181 | | i32 AtomicI32 ATOMIC_I32_INIT 2182 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2184 | / atomic_int! { 2185 | | cfg(target_has_atomic = "32"), 2186 | | cfg(target_has_atomic_equal_alignment = "32"), 2187 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2200 | | u32 AtomicU32 ATOMIC_U32_INIT 2201 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2203 | / atomic_int! { 2204 | | cfg(target_has_atomic = "64"), 2205 | | cfg(target_has_atomic_equal_alignment = "64"), 2206 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2219 | | i64 AtomicI64 ATOMIC_I64_INIT 2220 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` ... 2222 | / atomic_int! { 2223 | | cfg(target_has_atomic = "64"), 2224 | | cfg(target_has_atomic_equal_alignment = "64"), 2225 | | stable(feature = "integer_atomics_stable", since = "1.34.0"), ... | 2238 | | u64 AtomicU64 ATOMIC_U64_INIT 2239 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` (#2) ... 2279 | / macro_rules! atomic_int_ptr_sized { 2280 | | ( $($target_pointer_width:literal $align:literal)* ) => { $( 2281 | | #[cfg(target_has_atomic_load_store = "ptr")] 2282 | | #[cfg(target_pointer_width = $target_pointer_width)] 2283 | / atomic_int! { 2284 | cfg(target_has_atomic = "ptr"), 2285 | cfg(target_has_atomic_equal_alignment = "ptr"), 2286 | stable(feature = "rust1", since = "1.0.0"), ... 2299 | isize AtomicIsize ATOMIC_ISIZE_INIT 2300 | | } | |_________- in this macro invocation (#2) ... 2321 | | )* }; 2322 | | } | |_- in this expansion of `atomic_int_ptr_sized!` (#1) 2323 | 2324 | / atomic_int_ptr_sized! { 2325 | | "16" 2 2326 | | "32" 4 2327 | | "64" 8 2328 | | } | |_- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: a `const` item should never be interior mutable --> library/core/src/sync/atomic.rs:1337:9 | 1288 | / macro_rules! atomic_int { 1289 | | ($cfg_cas:meta, 1290 | | $cfg_align:meta, 1291 | | $stable:meta, ... | 1337 | | pub const $atomic_init: $atomic_type = $atomic_type::new(0); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 2085 | | } 2086 | | } | |_- in this expansion of `atomic_int!` (#2) ... 2279 | / macro_rules! atomic_int_ptr_sized { 2280 | | ( $($target_pointer_width:literal $align:literal)* ) => { $( 2281 | | #[cfg(target_has_atomic_load_store = "ptr")] 2282 | | #[cfg(target_pointer_width = $target_pointer_width)] ... | 2303 | / atomic_int! { 2304 | cfg(target_has_atomic = "ptr"), 2305 | cfg(target_has_atomic_equal_alignment = "ptr"), 2306 | stable(feature = "rust1", since = "1.0.0"), ... 2319 | usize AtomicUsize ATOMIC_USIZE_INIT 2320 | | } | |_________- in this macro invocation (#2) 2321 | | )* }; 2322 | | } | |_- in this expansion of `atomic_int_ptr_sized!` (#1) 2323 | 2324 | / atomic_int_ptr_sized! { 2325 | | "16" 2 2326 | | "32" 4 2327 | | "64" 8 2328 | | } | |_- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: the operation is ineffective. Consider reducing it to `*curr` --> library/core/src/fmt/num.rs:509:82 | 509 | ptr::copy_nonoverlapping(lut_ptr.offset(d1 as isize), buf_ptr.offset(*curr + 0), 2); | ^^^^^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `*curr` --> library/core/src/fmt/num.rs:529:82 | 529 | ptr::copy_nonoverlapping(lut_ptr.offset(d1 as isize), buf_ptr.offset(*curr + 0), 2); | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `*curr` --> library/core/src/fmt/num.rs:544:82 | 544 | ptr::copy_nonoverlapping(lut_ptr.offset(d1 as isize), buf_ptr.offset(*curr + 0), 2); | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. --> library/core/src/fmt/mod.rs:261:5 | 261 | loop {} | ^^^^^^^ | = note: `#[warn(clippy::empty_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop warning: transmute from a reference to a reference --> library/core/src/fmt/mod.rs:276:68 | 276 | unsafe { ArgumentV1 { formatter: mem::transmute(f), value: mem::transmute(x) } } | ^^^^^^^^^^^^^^^^^ help: try: `&*(x as *const T as *const fmt::Opaque)` | = note: `#[warn(clippy::transmute_ptr_to_ptr)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/slice/cmp.rs:30:5 | 30 | / fn ne(&self, other: &[B]) -> bool { 31 | | SlicePartialEq::not_equal(self, other) 32 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: unsafe function's docs miss `# Safety` section --> library/core/src/slice/index.rs:124:5 | 124 | unsafe fn get_unchecked(self, slice: *const T) -> *const Self::Output; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/slice/index.rs:133:5 | 133 | unsafe fn get_unchecked_mut(self, slice: *mut T) -> *mut Self::Output; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: use of `offset` with a `usize` casted to an `isize` --> library/core/src/slice/sort.rs:392:26 | 392 | l = unsafe { l.offset(block_l as isize) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.add(block_l)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: the operation is ineffective. Consider reducing it to `len / 4` --> library/core/src/slice/sort.rs:614:17 | 614 | let mut a = len / 4 * 1; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: transmute from a `&[u8]` to a `&str` --> library/core/src/str/converts.rs:165:14 | 165 | unsafe { mem::transmute(v) } | ^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8(v).unwrap()` | = note: `#[warn(clippy::transmute_bytes_to_str)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str warning: unsafe function's docs miss `# Safety` section --> library/core/src/str/converts.rs:187:1 | 187 | / pub unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str { 188 | | // SAFETY: the caller must guarantee that the bytes `v` 189 | | // are valid UTF-8, thus the cast to `*mut str` is safe. 190 | | // Also, the pointer dereference is safe because that pointer 191 | | // comes from a reference which is guaranteed to be valid for writes. 192 | | unsafe { &mut *(v as *mut [u8] as *mut str) } 193 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/str/traits.rs:32:5 | 32 | / fn ne(&self, other: &str) -> bool { 33 | | !(*self).eq(other) 34 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` --> library/core/src/str/lossy.rs:15:5 | 15 | / pub fn from_str(s: &str) -> &Utf8Lossy { 16 | | Utf8Lossy::from_bytes(s.as_bytes()) 17 | | } | |_____^ | = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: transmute from a reference to a reference --> library/core/src/str/lossy.rs:21:18 | 21 | unsafe { mem::transmute(bytes) } | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const str::lossy::Utf8Lossy)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: unsafe function's docs miss `# Safety` section --> library/core/src/task/wake.rs:256:5 | 256 | / pub unsafe fn from_raw(waker: RawWaker) -> Waker { 257 | | Waker { waker } 258 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: re-implementing `PartialEq::ne` is unnecessary --> library/core/src/tuple.rs:21:17 | 7 | / macro_rules! tuple_impls { 8 | | ($( 9 | | $Tuple:ident { 10 | | $(($idx:tt) -> $T:ident)+ ... | 21 | /| fn ne(&self, other: &($($T,)+)) -> bool { 22 | || $(self.$idx != other.$idx)||+ 23 | || } | ||_________________^ ... | 70 | | } 71 | | } | |_- in this expansion of `tuple_impls!` ... 110 | / tuple_impls! { 111 | | Tuple1 { 112 | | (0) -> A 113 | | } ... | 212 | | } 213 | | } | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 93 | / simd_ty!( 94 | | u8x8[u8]: u8, 95 | | u8, 96 | | u8, ... | 108 | | x7 109 | | ); | |__- in this macro invocation | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 114 | / simd_ty!( 115 | | i8x8[i8]: i8, 116 | | i8, 117 | | i8, ... | 129 | | x7 130 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 139 | / simd_ty!( 140 | | u8x16[u8]: u8, 141 | | u8, 142 | | u8, ... | 170 | | x15 171 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 172 | / simd_ty!( 173 | | u16x8[u16]: u16, 174 | | u16, 175 | | u16, ... | 187 | | x7 188 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 192 | / simd_ty!( 193 | | i8x16[i8]: i8, 194 | | i8, 195 | | i8, ... | 223 | | x15 224 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 225 | / simd_ty!( 226 | | i16x8[i16]: i16, 227 | | i16, 228 | | i16, ... | 240 | | x7 241 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:52:13 | 38 | / macro_rules! simd_m_ty { 39 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 40 | | #[repr(simd)] 41 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 52 | | pub(crate) const fn new($($elem_name: bool),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 75 | | } 76 | | } | |_- in this expansion of `simd_m_ty!` ... 248 | / simd_m_ty!( 249 | | m8x16[i8]: i8, 250 | | i8, 251 | | i8, ... | 279 | | x15 280 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:52:13 | 38 | / macro_rules! simd_m_ty { 39 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 40 | | #[repr(simd)] 41 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 52 | | pub(crate) const fn new($($elem_name: bool),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 75 | | } 76 | | } | |_- in this expansion of `simd_m_ty!` ... 281 | / simd_m_ty!( 282 | | m16x8[i16]: i16, 283 | | i16, 284 | | i16, ... | 296 | | x7 297 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (32/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 303 | / simd_ty!( 304 | | u8x32[u8]: u8, 305 | | u8, 306 | | u8, ... | 366 | | x31 367 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 368 | / simd_ty!( 369 | | u16x16[u16]: u16, 370 | | u16, 371 | | u16, ... | 399 | | x15 400 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 401 | / simd_ty!( 402 | | u32x8[u32]: u32, 403 | | u32, 404 | | u32, ... | 416 | | x7 417 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (32/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 420 | / simd_ty!( 421 | | i8x32[i8]: i8, 422 | | i8, 423 | | i8, ... | 483 | | x31 484 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 485 | / simd_ty!( 486 | | i16x16[i16]: i16, 487 | | i16, 488 | | i16, ... | 516 | | x15 517 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 518 | / simd_ty!( 519 | | i32x8[i32]: i32, 520 | | i32, 521 | | i32, ... | 533 | | x7 534 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 537 | / simd_ty!( 538 | | f32x8[f32]: f32, 539 | | f32, 540 | | f32, ... | 552 | | x7 553 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 557 | / simd_ty!( 558 | | i32x16[i32]: i32, 559 | | i32, 560 | | i32, ... | 588 | | x15 589 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 591 | / simd_ty!( 592 | | u32x16[u32]: u32, 593 | | u32, 594 | | u32, ... | 622 | | x15 623 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 625 | / simd_ty!( 626 | | f32x16[f32]: f32, 627 | | f32, 628 | | f32, ... | 656 | | x15 657 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 659 | / simd_ty!( 660 | | i64x8[i64]: i64, 661 | | i64, 662 | | i64, ... | 674 | | x7 675 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 677 | / simd_ty!( 678 | | u64x8[u64]: u64, 679 | | u64, 680 | | u64, ... | 692 | | x7 693 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/simd.rs:14:13 | 5 | / macro_rules! simd_ty { 6 | | ($id:ident [$ety:ident]: $($elem_ty:ident),* | $($elem_name:ident),*) => { 7 | | #[repr(simd)] 8 | | #[derive(Copy, Clone, Debug, PartialEq)] ... | 14 | | pub(crate) const fn new($($elem_name: $elem_ty),*) -> Self { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 35 | | } 36 | | } | |_- in this expansion of `simd_ty!` ... 695 | / simd_ty!( 696 | | f64x8[f64]: f64, 697 | | f64, 698 | | f64, ... | 710 | | x7 711 | | ); | |__- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fxsr.rs:30:1 | 30 | / pub unsafe fn _fxsave(mem_addr: *mut u8) { 31 | | fxsave(mem_addr) 32 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fxsr.rs:54:1 | 54 | / pub unsafe fn _fxrstor(mem_addr: *const u8) { 55 | | fxrstor(mem_addr) 56 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bswap.rs:13:1 | 13 | / pub unsafe fn _bswap(x: i32) -> i32 { 14 | | x.swap_bytes() 15 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rdtsc.rs:25:1 | 25 | / pub unsafe fn _rdtsc() -> u64 { 26 | | rdtsc() 27 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rdtsc.rs:48:1 | 48 | / pub unsafe fn __rdtscp(aux: *mut u32) -> u64 { 49 | | rdtscp(aux as *mut _) 50 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/cpuid.rs:53:1 | 53 | / pub unsafe fn __cpuid_count(leaf: u32, sub_leaf: u32) -> CpuidResult { 54 | | let eax; 55 | | let ebx; 56 | | let ecx; ... | 79 | | CpuidResult { eax, ebx, ecx, edx } 80 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/cpuid.rs:86:1 | 86 | / pub unsafe fn __cpuid(leaf: u32) -> CpuidResult { 87 | | __cpuid_count(leaf, 0) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/cpuid.rs:173:1 | 173 | / pub unsafe fn __get_cpuid_max(leaf: u32) -> (u32, u32) { 174 | | let CpuidResult { eax, ebx, .. } = __cpuid(leaf); 175 | | (eax, ebx) 176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:39:1 | 39 | / pub unsafe fn _xsave(mem_addr: *mut u8, save_mask: u64) { 40 | | xsave(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 41 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:55:1 | 55 | / pub unsafe fn _xrstor(mem_addr: *const u8, rs_mask: u64) { 56 | | xrstor(mem_addr, (rs_mask >> 32) as u32, rs_mask as u32); 57 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:75:1 | 75 | / pub unsafe fn _xsetbv(a: u32, val: u64) { 76 | | xsetbv(a, (val >> 32) as u32, val as u32); 77 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:87:1 | 87 | / pub unsafe fn _xgetbv(xcr_no: u32) -> u64 { 88 | | let eax: u32; 89 | | let edx: u32; 90 | | llvm_asm!("xgetbv" : "={eax}"(eax), "={edx}"(edx) : "{ecx}"(xcr_no)); 91 | | ((edx as u64) << 32) | (eax as u64) 92 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:107:1 | 107 | / pub unsafe fn _xsaveopt(mem_addr: *mut u8, save_mask: u64) { 108 | | xsaveopt(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 109 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:123:1 | 123 | / pub unsafe fn _xsavec(mem_addr: *mut u8, save_mask: u64) { 124 | | xsavec(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 125 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:140:1 | 140 | / pub unsafe fn _xsaves(mem_addr: *mut u8, save_mask: u64) { 141 | | xsaves(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 142 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/xsave.rs:159:1 | 159 | / pub unsafe fn _xrstors(mem_addr: *const u8, rs_mask: u64) { 160 | | xrstors(mem_addr, (rs_mask >> 32) as u32, rs_mask as u32); 161 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:19:1 | 19 | / pub unsafe fn _mm_add_ss(a: __m128, b: __m128) -> __m128 { 20 | | addss(a, b) 21 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:30:1 | 30 | / pub unsafe fn _mm_add_ps(a: __m128, b: __m128) -> __m128 { 31 | | simd_add(a, b) 32 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:42:1 | 42 | / pub unsafe fn _mm_sub_ss(a: __m128, b: __m128) -> __m128 { 43 | | subss(a, b) 44 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:53:1 | 53 | / pub unsafe fn _mm_sub_ps(a: __m128, b: __m128) -> __m128 { 54 | | simd_sub(a, b) 55 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:65:1 | 65 | / pub unsafe fn _mm_mul_ss(a: __m128, b: __m128) -> __m128 { 66 | | mulss(a, b) 67 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:76:1 | 76 | / pub unsafe fn _mm_mul_ps(a: __m128, b: __m128) -> __m128 { 77 | | simd_mul(a, b) 78 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:88:1 | 88 | / pub unsafe fn _mm_div_ss(a: __m128, b: __m128) -> __m128 { 89 | | divss(a, b) 90 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:99:1 | 99 | / pub unsafe fn _mm_div_ps(a: __m128, b: __m128) -> __m128 { 100 | | simd_div(a, b) 101 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:111:1 | 111 | / pub unsafe fn _mm_sqrt_ss(a: __m128) -> __m128 { 112 | | sqrtss(a) 113 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:123:1 | 123 | / pub unsafe fn _mm_sqrt_ps(a: __m128) -> __m128 { 124 | | sqrtps(a) 125 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:135:1 | 135 | / pub unsafe fn _mm_rcp_ss(a: __m128) -> __m128 { 136 | | rcpss(a) 137 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:147:1 | 147 | / pub unsafe fn _mm_rcp_ps(a: __m128) -> __m128 { 148 | | rcpps(a) 149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:159:1 | 159 | / pub unsafe fn _mm_rsqrt_ss(a: __m128) -> __m128 { 160 | | rsqrtss(a) 161 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:171:1 | 171 | / pub unsafe fn _mm_rsqrt_ps(a: __m128) -> __m128 { 172 | | rsqrtps(a) 173 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:184:1 | 184 | / pub unsafe fn _mm_min_ss(a: __m128, b: __m128) -> __m128 { 185 | | minss(a, b) 186 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:196:1 | 196 | / pub unsafe fn _mm_min_ps(a: __m128, b: __m128) -> __m128 { 197 | | // See the `test_mm_min_ps` test why this can't be implemented using `simd_fmin`. 198 | | minps(a, b) 199 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:210:1 | 210 | / pub unsafe fn _mm_max_ss(a: __m128, b: __m128) -> __m128 { 211 | | maxss(a, b) 212 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:222:1 | 222 | / pub unsafe fn _mm_max_ps(a: __m128, b: __m128) -> __m128 { 223 | | // See the `test_mm_min_ps` test why this can't be implemented using `simd_fmax`. 224 | | maxps(a, b) 225 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:238:1 | 238 | / pub unsafe fn _mm_and_ps(a: __m128, b: __m128) -> __m128 { 239 | | let a: __m128i = mem::transmute(a); 240 | | let b: __m128i = mem::transmute(b); 241 | | mem::transmute(simd_and(a, b)) 242 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:259:1 | 259 | / pub unsafe fn _mm_andnot_ps(a: __m128, b: __m128) -> __m128 { 260 | | let a: __m128i = mem::transmute(a); 261 | | let b: __m128i = mem::transmute(b); 262 | | let mask: __m128i = mem::transmute(i32x4::splat(-1)); 263 | | mem::transmute(simd_and(simd_xor(mask, a), b)) 264 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:277:1 | 277 | / pub unsafe fn _mm_or_ps(a: __m128, b: __m128) -> __m128 { 278 | | let a: __m128i = mem::transmute(a); 279 | | let b: __m128i = mem::transmute(b); 280 | | mem::transmute(simd_or(a, b)) 281 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:295:1 | 295 | / pub unsafe fn _mm_xor_ps(a: __m128, b: __m128) -> __m128 { 296 | | let a: __m128i = mem::transmute(a); 297 | | let b: __m128i = mem::transmute(b); 298 | | mem::transmute(simd_xor(a, b)) 299 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:310:1 | 310 | / pub unsafe fn _mm_cmpeq_ss(a: __m128, b: __m128) -> __m128 { 311 | | cmpss(a, b, 0) 312 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:324:1 | 324 | / pub unsafe fn _mm_cmplt_ss(a: __m128, b: __m128) -> __m128 { 325 | | cmpss(a, b, 1) 326 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:338:1 | 338 | / pub unsafe fn _mm_cmple_ss(a: __m128, b: __m128) -> __m128 { 339 | | cmpss(a, b, 2) 340 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:352:1 | 352 | / pub unsafe fn _mm_cmpgt_ss(a: __m128, b: __m128) -> __m128 { 353 | | simd_shuffle4(a, cmpss(b, a, 1), [4, 1, 2, 3]) 354 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:366:1 | 366 | / pub unsafe fn _mm_cmpge_ss(a: __m128, b: __m128) -> __m128 { 367 | | simd_shuffle4(a, cmpss(b, a, 2), [4, 1, 2, 3]) 368 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:380:1 | 380 | / pub unsafe fn _mm_cmpneq_ss(a: __m128, b: __m128) -> __m128 { 381 | | cmpss(a, b, 4) 382 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:394:1 | 394 | / pub unsafe fn _mm_cmpnlt_ss(a: __m128, b: __m128) -> __m128 { 395 | | cmpss(a, b, 5) 396 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:408:1 | 408 | / pub unsafe fn _mm_cmpnle_ss(a: __m128, b: __m128) -> __m128 { 409 | | cmpss(a, b, 6) 410 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:422:1 | 422 | / pub unsafe fn _mm_cmpngt_ss(a: __m128, b: __m128) -> __m128 { 423 | | simd_shuffle4(a, cmpss(b, a, 5), [4, 1, 2, 3]) 424 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:436:1 | 436 | / pub unsafe fn _mm_cmpnge_ss(a: __m128, b: __m128) -> __m128 { 437 | | simd_shuffle4(a, cmpss(b, a, 6), [4, 1, 2, 3]) 438 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:450:1 | 450 | / pub unsafe fn _mm_cmpord_ss(a: __m128, b: __m128) -> __m128 { 451 | | cmpss(a, b, 7) 452 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:464:1 | 464 | / pub unsafe fn _mm_cmpunord_ss(a: __m128, b: __m128) -> __m128 { 465 | | cmpss(a, b, 3) 466 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:477:1 | 477 | / pub unsafe fn _mm_cmpeq_ps(a: __m128, b: __m128) -> __m128 { 478 | | cmpps(a, b, 0) 479 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:490:1 | 490 | / pub unsafe fn _mm_cmplt_ps(a: __m128, b: __m128) -> __m128 { 491 | | cmpps(a, b, 1) 492 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:504:1 | 504 | / pub unsafe fn _mm_cmple_ps(a: __m128, b: __m128) -> __m128 { 505 | | cmpps(a, b, 2) 506 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:517:1 | 517 | / pub unsafe fn _mm_cmpgt_ps(a: __m128, b: __m128) -> __m128 { 518 | | cmpps(b, a, 1) 519 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:531:1 | 531 | / pub unsafe fn _mm_cmpge_ps(a: __m128, b: __m128) -> __m128 { 532 | | cmpps(b, a, 2) 533 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:544:1 | 544 | / pub unsafe fn _mm_cmpneq_ps(a: __m128, b: __m128) -> __m128 { 545 | | cmpps(a, b, 4) 546 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:558:1 | 558 | / pub unsafe fn _mm_cmpnlt_ps(a: __m128, b: __m128) -> __m128 { 559 | | cmpps(a, b, 5) 560 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:572:1 | 572 | / pub unsafe fn _mm_cmpnle_ps(a: __m128, b: __m128) -> __m128 { 573 | | cmpps(a, b, 6) 574 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:586:1 | 586 | / pub unsafe fn _mm_cmpngt_ps(a: __m128, b: __m128) -> __m128 { 587 | | cmpps(b, a, 5) 588 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:600:1 | 600 | / pub unsafe fn _mm_cmpnge_ps(a: __m128, b: __m128) -> __m128 { 601 | | cmpps(b, a, 6) 602 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:614:1 | 614 | / pub unsafe fn _mm_cmpord_ps(a: __m128, b: __m128) -> __m128 { 615 | | cmpps(b, a, 7) 616 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:628:1 | 628 | / pub unsafe fn _mm_cmpunord_ps(a: __m128, b: __m128) -> __m128 { 629 | | cmpps(b, a, 3) 630 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:640:1 | 640 | / pub unsafe fn _mm_comieq_ss(a: __m128, b: __m128) -> i32 { 641 | | comieq_ss(a, b) 642 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:652:1 | 652 | / pub unsafe fn _mm_comilt_ss(a: __m128, b: __m128) -> i32 { 653 | | comilt_ss(a, b) 654 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:665:1 | 665 | / pub unsafe fn _mm_comile_ss(a: __m128, b: __m128) -> i32 { 666 | | comile_ss(a, b) 667 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:678:1 | 678 | / pub unsafe fn _mm_comigt_ss(a: __m128, b: __m128) -> i32 { 679 | | comigt_ss(a, b) 680 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:691:1 | 691 | / pub unsafe fn _mm_comige_ss(a: __m128, b: __m128) -> i32 { 692 | | comige_ss(a, b) 693 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:703:1 | 703 | / pub unsafe fn _mm_comineq_ss(a: __m128, b: __m128) -> i32 { 704 | | comineq_ss(a, b) 705 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:716:1 | 716 | / pub unsafe fn _mm_ucomieq_ss(a: __m128, b: __m128) -> i32 { 717 | | ucomieq_ss(a, b) 718 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:730:1 | 730 | / pub unsafe fn _mm_ucomilt_ss(a: __m128, b: __m128) -> i32 { 731 | | ucomilt_ss(a, b) 732 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:744:1 | 744 | / pub unsafe fn _mm_ucomile_ss(a: __m128, b: __m128) -> i32 { 745 | | ucomile_ss(a, b) 746 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:758:1 | 758 | / pub unsafe fn _mm_ucomigt_ss(a: __m128, b: __m128) -> i32 { 759 | | ucomigt_ss(a, b) 760 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:772:1 | 772 | / pub unsafe fn _mm_ucomige_ss(a: __m128, b: __m128) -> i32 { 773 | | ucomige_ss(a, b) 774 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:785:1 | 785 | / pub unsafe fn _mm_ucomineq_ss(a: __m128, b: __m128) -> i32 { 786 | | ucomineq_ss(a, b) 787 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:803:1 | 803 | / pub unsafe fn _mm_cvtss_si32(a: __m128) -> i32 { 804 | | cvtss2si(a) 805 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:814:1 | 814 | / pub unsafe fn _mm_cvt_ss2si(a: __m128) -> i32 { 815 | | _mm_cvtss_si32(a) 816 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:834:1 | 834 | / pub unsafe fn _mm_cvttss_si32(a: __m128) -> i32 { 835 | | cvttss2si(a) 836 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:845:1 | 845 | / pub unsafe fn _mm_cvtt_ss2si(a: __m128) -> i32 { 846 | | _mm_cvttss_si32(a) 847 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:857:1 | 857 | / pub unsafe fn _mm_cvtss_f32(a: __m128) -> f32 { 858 | | simd_extract(a, 0) 859 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:872:1 | 872 | / pub unsafe fn _mm_cvtsi32_ss(a: __m128, b: i32) -> __m128 { 873 | | cvtsi2ss(a, b) 874 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:883:1 | 883 | / pub unsafe fn _mm_cvt_si2ss(a: __m128, b: i32) -> __m128 { 884 | | _mm_cvtsi32_ss(a, b) 885 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:895:1 | 895 | / pub unsafe fn _mm_set_ss(a: f32) -> __m128 { 896 | | __m128(a, 0.0, 0.0, 0.0) 897 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:906:1 | 906 | / pub unsafe fn _mm_set1_ps(a: f32) -> __m128 { 907 | | __m128(a, a, a, a) 908 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:917:1 | 917 | / pub unsafe fn _mm_set_ps1(a: f32) -> __m128 { 918 | | _mm_set1_ps(a) 919 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:944:1 | 944 | / pub unsafe fn _mm_set_ps(a: f32, b: f32, c: f32, d: f32) -> __m128 { 945 | | __m128(d, c, b, a) 946 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:964:1 | 964 | / pub unsafe fn _mm_setr_ps(a: f32, b: f32, c: f32, d: f32) -> __m128 { 965 | | __m128(a, b, c, d) 966 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:975:1 | 975 | / pub unsafe fn _mm_setzero_ps() -> __m128 { 976 | | __m128(0.0, 0.0, 0.0, 0.0) 977 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1006:1 | 1006 | / pub unsafe fn _mm_shuffle_ps(a: __m128, b: __m128, mask: i32) -> __m128 { 1007 | | let mask = (mask & 0xFF) as u8; 1008 | | 1009 | | macro_rules! shuffle_done { ... | 1049 | | } 1050 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1060:1 | 1060 | / pub unsafe fn _mm_unpackhi_ps(a: __m128, b: __m128) -> __m128 { 1061 | | simd_shuffle4(a, b, [2, 6, 3, 7]) 1062 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1072:1 | 1072 | / pub unsafe fn _mm_unpacklo_ps(a: __m128, b: __m128) -> __m128 { 1073 | | simd_shuffle4(a, b, [0, 4, 1, 5]) 1074 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1084:1 | 1084 | / pub unsafe fn _mm_movehl_ps(a: __m128, b: __m128) -> __m128 { 1085 | | // TODO; figure why this is a different instruction on Windows? 1086 | | simd_shuffle4(a, b, [6, 7, 2, 3]) 1087 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1097:1 | 1097 | / pub unsafe fn _mm_movelh_ps(a: __m128, b: __m128) -> __m128 { 1098 | | simd_shuffle4(a, b, [0, 1, 4, 5]) 1099 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1114:1 | 1114 | / pub unsafe fn _mm_movemask_ps(a: __m128) -> i32 { 1115 | | movmskps(a) 1116 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1128:1 | 1128 | / pub unsafe fn _mm_load_ss(p: *const f32) -> __m128 { 1129 | | __m128(*p, 0.0, 0.0, 0.0) 1130 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1143:1 | 1143 | / pub unsafe fn _mm_load1_ps(p: *const f32) -> __m128 { 1144 | | let a = *p; 1145 | | __m128(a, a, a, a) 1146 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1155:1 | 1155 | / pub unsafe fn _mm_load_ps1(p: *const f32) -> __m128 { 1156 | | _mm_load1_ps(p) 1157 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1174:1 | 1174 | / pub unsafe fn _mm_load_ps(p: *const f32) -> __m128 { 1175 | | *(p as *const __m128) 1176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1191:1 | 1191 | / pub unsafe fn _mm_loadu_ps(p: *const f32) -> __m128 { 1192 | | // Note: Using `*p` would require `f32` alignment, but `movups` has no 1193 | | // alignment restrictions. 1194 | | let mut dst = _mm_undefined_ps(); ... | 1200 | | dst 1201 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1228:1 | 1228 | / pub unsafe fn _mm_loadr_ps(p: *const f32) -> __m128 { 1229 | | let a = _mm_load_ps(p); 1230 | | simd_shuffle4(a, a, [3, 2, 1, 0]) 1231 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1242:1 | 1242 | / pub unsafe fn _mm_loadu_si64(mem_addr: *const u8) -> __m128i { 1243 | | transmute(i64x2(0, ptr::read_unaligned(mem_addr as *const i64))) 1244 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1255:1 | 1255 | / pub unsafe fn _mm_store_ss(p: *mut f32, a: __m128) { 1256 | | *p = simd_extract(a, 0); 1257 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1282:1 | 1282 | / pub unsafe fn _mm_store1_ps(p: *mut f32, a: __m128) { 1283 | | let b: __m128 = simd_shuffle4(a, a, [0, 0, 0, 0]); 1284 | | *(p as *mut __m128) = b; 1285 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1294:1 | 1294 | / pub unsafe fn _mm_store_ps1(p: *mut f32, a: __m128) { 1295 | | _mm_store1_ps(p, a); 1296 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1314:1 | 1314 | / pub unsafe fn _mm_store_ps(p: *mut f32, a: __m128) { 1315 | | *(p as *mut __m128) = a; 1316 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1329:1 | 1329 | / pub unsafe fn _mm_storeu_ps(p: *mut f32, a: __m128) { 1330 | | ptr::copy_nonoverlapping( 1331 | | &a as *const __m128 as *const u8, 1332 | | p as *mut u8, 1333 | | mem::size_of::<__m128>(), 1334 | | ); 1335 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1358:1 | 1358 | / pub unsafe fn _mm_storer_ps(p: *mut f32, a: __m128) { 1359 | | let b: __m128 = simd_shuffle4(a, a, [3, 2, 1, 0]); 1360 | | *(p as *mut __m128) = b; 1361 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1376:1 | 1376 | / pub unsafe fn _mm_move_ss(a: __m128, b: __m128) -> __m128 { 1377 | | simd_shuffle4(a, b, [4, 1, 2, 3]) 1378 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1392:1 | 1392 | / pub unsafe fn _mm_sfence() { 1393 | | sfence() 1394 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1405:1 | 1405 | / pub unsafe fn _mm_getcsr() -> u32 { 1406 | | let mut result = 0_i32; 1407 | | stmxcsr((&mut result) as *mut _ as *mut i8); 1408 | | result as u32 1409 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1542:1 | 1542 | / pub unsafe fn _mm_setcsr(val: u32) { 1543 | | ldmxcsr(&val as *const _ as *const i8); 1544 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1624:1 | 1624 | / pub unsafe fn _MM_GET_EXCEPTION_MASK() -> u32 { 1625 | | _mm_getcsr() & _MM_MASK_MASK 1626 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1635:1 | 1635 | / pub unsafe fn _MM_GET_EXCEPTION_STATE() -> u32 { 1636 | | _mm_getcsr() & _MM_EXCEPT_MASK 1637 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1646:1 | 1646 | / pub unsafe fn _MM_GET_FLUSH_ZERO_MODE() -> u32 { 1647 | | _mm_getcsr() & _MM_FLUSH_ZERO_MASK 1648 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1657:1 | 1657 | / pub unsafe fn _MM_GET_ROUNDING_MODE() -> u32 { 1658 | | _mm_getcsr() & _MM_ROUND_MASK 1659 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1668:1 | 1668 | / pub unsafe fn _MM_SET_EXCEPTION_MASK(x: u32) { 1669 | | _mm_setcsr((_mm_getcsr() & !_MM_MASK_MASK) | x) 1670 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1679:1 | 1679 | / pub unsafe fn _MM_SET_EXCEPTION_STATE(x: u32) { 1680 | | _mm_setcsr((_mm_getcsr() & !_MM_EXCEPT_MASK) | x) 1681 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1690:1 | 1690 | / pub unsafe fn _MM_SET_FLUSH_ZERO_MODE(x: u32) { 1691 | | let val = (_mm_getcsr() & !_MM_FLUSH_ZERO_MASK) | x; 1692 | | // println!("setting csr={:x}", val); 1693 | | _mm_setcsr(val) 1694 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1703:1 | 1703 | / pub unsafe fn _MM_SET_ROUNDING_MODE(x: u32) { 1704 | | _mm_setcsr((_mm_getcsr() & !_MM_ROUND_MASK) | x) 1705 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1769:1 | 1769 | / pub unsafe fn _mm_prefetch(p: *const i8, strategy: i32) { 1770 | | // The `strategy` must be a compile-time constant, so we use a short form 1771 | | // of `constify_imm8!` for now. 1772 | | // We use the `llvm.prefetch` instrinsic with `rw` = 0 (read), and ... | 1784 | | pref!(strategy) 1785 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1793:1 | 1793 | / pub unsafe fn _mm_undefined_ps() -> __m128 { 1794 | | _mm_set1_ps(0.0) 1795 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1804:1 | 1804 | / pub unsafe fn _MM_TRANSPOSE4_PS( 1805 | | row0: &mut __m128, 1806 | | row1: &mut __m128, 1807 | | row2: &mut __m128, ... | 1818 | | *row3 = _mm_movehl_ps(tmp3, tmp1); 1819 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse.rs:1908:1 | 1908 | / pub unsafe fn _mm_stream_ps(mem_addr: *mut f32, a: __m128) { 1909 | | intrinsics::nontemporal_store(mem_addr as *mut __m128, a); 1910 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:22:1 | 22 | / pub unsafe fn _mm_pause() { 23 | | // note: `pause` is guaranteed to be interpreted as a `nop` by CPUs without 24 | | // the SSE2 target-feature - therefore it does not require any target features 25 | | pause() 26 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:36:1 | 36 | / pub unsafe fn _mm_clflush(p: *const u8) { 37 | | clflush(p) 38 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:52:1 | 52 | / pub unsafe fn _mm_lfence() { 53 | | lfence() 54 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:68:1 | 68 | / pub unsafe fn _mm_mfence() { 69 | | mfence() 70 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:79:1 | 79 | / pub unsafe fn _mm_add_epi8(a: __m128i, b: __m128i) -> __m128i { 80 | | transmute(simd_add(a.as_i8x16(), b.as_i8x16())) 81 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:90:1 | 90 | / pub unsafe fn _mm_add_epi16(a: __m128i, b: __m128i) -> __m128i { 91 | | transmute(simd_add(a.as_i16x8(), b.as_i16x8())) 92 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:101:1 | 101 | / pub unsafe fn _mm_add_epi32(a: __m128i, b: __m128i) -> __m128i { 102 | | transmute(simd_add(a.as_i32x4(), b.as_i32x4())) 103 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:112:1 | 112 | / pub unsafe fn _mm_add_epi64(a: __m128i, b: __m128i) -> __m128i { 113 | | transmute(simd_add(a.as_i64x2(), b.as_i64x2())) 114 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:123:1 | 123 | / pub unsafe fn _mm_adds_epi8(a: __m128i, b: __m128i) -> __m128i { 124 | | transmute(simd_saturating_add(a.as_i8x16(), b.as_i8x16())) 125 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:134:1 | 134 | / pub unsafe fn _mm_adds_epi16(a: __m128i, b: __m128i) -> __m128i { 135 | | transmute(simd_saturating_add(a.as_i16x8(), b.as_i16x8())) 136 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:145:1 | 145 | / pub unsafe fn _mm_adds_epu8(a: __m128i, b: __m128i) -> __m128i { 146 | | transmute(simd_saturating_add(a.as_u8x16(), b.as_u8x16())) 147 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:156:1 | 156 | / pub unsafe fn _mm_adds_epu16(a: __m128i, b: __m128i) -> __m128i { 157 | | transmute(simd_saturating_add(a.as_u16x8(), b.as_u16x8())) 158 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:167:1 | 167 | / pub unsafe fn _mm_avg_epu8(a: __m128i, b: __m128i) -> __m128i { 168 | | transmute(pavgb(a.as_u8x16(), b.as_u8x16())) 169 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:178:1 | 178 | / pub unsafe fn _mm_avg_epu16(a: __m128i, b: __m128i) -> __m128i { 179 | | transmute(pavgw(a.as_u16x8(), b.as_u16x8())) 180 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:193:1 | 193 | / pub unsafe fn _mm_madd_epi16(a: __m128i, b: __m128i) -> __m128i { 194 | | transmute(pmaddwd(a.as_i16x8(), b.as_i16x8())) 195 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:205:1 | 205 | / pub unsafe fn _mm_max_epi16(a: __m128i, b: __m128i) -> __m128i { 206 | | transmute(pmaxsw(a.as_i16x8(), b.as_i16x8())) 207 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:217:1 | 217 | / pub unsafe fn _mm_max_epu8(a: __m128i, b: __m128i) -> __m128i { 218 | | transmute(pmaxub(a.as_u8x16(), b.as_u8x16())) 219 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:229:1 | 229 | / pub unsafe fn _mm_min_epi16(a: __m128i, b: __m128i) -> __m128i { 230 | | transmute(pminsw(a.as_i16x8(), b.as_i16x8())) 231 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:241:1 | 241 | / pub unsafe fn _mm_min_epu8(a: __m128i, b: __m128i) -> __m128i { 242 | | transmute(pminub(a.as_u8x16(), b.as_u8x16())) 243 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:255:1 | 255 | / pub unsafe fn _mm_mulhi_epi16(a: __m128i, b: __m128i) -> __m128i { 256 | | transmute(pmulhw(a.as_i16x8(), b.as_i16x8())) 257 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:269:1 | 269 | / pub unsafe fn _mm_mulhi_epu16(a: __m128i, b: __m128i) -> __m128i { 270 | | transmute(pmulhuw(a.as_u16x8(), b.as_u16x8())) 271 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:283:1 | 283 | / pub unsafe fn _mm_mullo_epi16(a: __m128i, b: __m128i) -> __m128i { 284 | | transmute(simd_mul(a.as_i16x8(), b.as_i16x8())) 285 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:297:1 | 297 | / pub unsafe fn _mm_mul_epu32(a: __m128i, b: __m128i) -> __m128i { 298 | | transmute(pmuludq(a.as_u32x4(), b.as_u32x4())) 299 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:313:1 | 313 | / pub unsafe fn _mm_sad_epu8(a: __m128i, b: __m128i) -> __m128i { 314 | | transmute(psadbw(a.as_u8x16(), b.as_u8x16())) 315 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:324:1 | 324 | / pub unsafe fn _mm_sub_epi8(a: __m128i, b: __m128i) -> __m128i { 325 | | transmute(simd_sub(a.as_i8x16(), b.as_i8x16())) 326 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:335:1 | 335 | / pub unsafe fn _mm_sub_epi16(a: __m128i, b: __m128i) -> __m128i { 336 | | transmute(simd_sub(a.as_i16x8(), b.as_i16x8())) 337 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:346:1 | 346 | / pub unsafe fn _mm_sub_epi32(a: __m128i, b: __m128i) -> __m128i { 347 | | transmute(simd_sub(a.as_i32x4(), b.as_i32x4())) 348 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:357:1 | 357 | / pub unsafe fn _mm_sub_epi64(a: __m128i, b: __m128i) -> __m128i { 358 | | transmute(simd_sub(a.as_i64x2(), b.as_i64x2())) 359 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:369:1 | 369 | / pub unsafe fn _mm_subs_epi8(a: __m128i, b: __m128i) -> __m128i { 370 | | transmute(simd_saturating_sub(a.as_i8x16(), b.as_i8x16())) 371 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:381:1 | 381 | / pub unsafe fn _mm_subs_epi16(a: __m128i, b: __m128i) -> __m128i { 382 | | transmute(simd_saturating_sub(a.as_i16x8(), b.as_i16x8())) 383 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:393:1 | 393 | / pub unsafe fn _mm_subs_epu8(a: __m128i, b: __m128i) -> __m128i { 394 | | transmute(simd_saturating_sub(a.as_u8x16(), b.as_u8x16())) 395 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:405:1 | 405 | / pub unsafe fn _mm_subs_epu16(a: __m128i, b: __m128i) -> __m128i { 406 | | transmute(simd_saturating_sub(a.as_u16x8(), b.as_u16x8())) 407 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:417:1 | 417 | / pub unsafe fn _mm_slli_si128(a: __m128i, imm8: i32) -> __m128i { 418 | | _mm_slli_si128_impl(a, imm8) 419 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:484:1 | 484 | / pub unsafe fn _mm_bslli_si128(a: __m128i, imm8: i32) -> __m128i { 485 | | _mm_slli_si128_impl(a, imm8) 486 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:496:1 | 496 | / pub unsafe fn _mm_bsrli_si128(a: __m128i, imm8: i32) -> __m128i { 497 | | _mm_srli_si128_impl(a, imm8) 498 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:508:1 | 508 | / pub unsafe fn _mm_slli_epi16(a: __m128i, imm8: i32) -> __m128i { 509 | | let a = a.as_i16x8(); 510 | | macro_rules! call { 511 | | ($imm8:expr) => { ... | 515 | | constify_imm8!(imm8, call) 516 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:526:1 | 526 | / pub unsafe fn _mm_sll_epi16(a: __m128i, count: __m128i) -> __m128i { 527 | | transmute(psllw(a.as_i16x8(), count.as_i16x8())) 528 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:538:1 | 538 | / pub unsafe fn _mm_slli_epi32(a: __m128i, imm8: i32) -> __m128i { 539 | | let a = a.as_i32x4(); 540 | | macro_rules! call { 541 | | ($imm8:expr) => { ... | 545 | | constify_imm8!(imm8, call) 546 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:556:1 | 556 | / pub unsafe fn _mm_sll_epi32(a: __m128i, count: __m128i) -> __m128i { 557 | | transmute(pslld(a.as_i32x4(), count.as_i32x4())) 558 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:568:1 | 568 | / pub unsafe fn _mm_slli_epi64(a: __m128i, imm8: i32) -> __m128i { 569 | | let a = a.as_i64x2(); 570 | | macro_rules! call { 571 | | ($imm8:expr) => { ... | 575 | | constify_imm8!(imm8, call) 576 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:586:1 | 586 | / pub unsafe fn _mm_sll_epi64(a: __m128i, count: __m128i) -> __m128i { 587 | | transmute(psllq(a.as_i64x2(), count.as_i64x2())) 588 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:599:1 | 599 | / pub unsafe fn _mm_srai_epi16(a: __m128i, imm8: i32) -> __m128i { 600 | | let a = a.as_i16x8(); 601 | | macro_rules! call { 602 | | ($imm8:expr) => { ... | 606 | | constify_imm8!(imm8, call) 607 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:617:1 | 617 | / pub unsafe fn _mm_sra_epi16(a: __m128i, count: __m128i) -> __m128i { 618 | | transmute(psraw(a.as_i16x8(), count.as_i16x8())) 619 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:630:1 | 630 | / pub unsafe fn _mm_srai_epi32(a: __m128i, imm8: i32) -> __m128i { 631 | | let a = a.as_i32x4(); 632 | | macro_rules! call { 633 | | ($imm8:expr) => { ... | 637 | | constify_imm8!(imm8, call) 638 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:648:1 | 648 | / pub unsafe fn _mm_sra_epi32(a: __m128i, count: __m128i) -> __m128i { 649 | | transmute(psrad(a.as_i32x4(), count.as_i32x4())) 650 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:660:1 | 660 | / pub unsafe fn _mm_srli_si128(a: __m128i, imm8: i32) -> __m128i { 661 | | _mm_srli_si128_impl(a, imm8) 662 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:728:1 | 728 | / pub unsafe fn _mm_srli_epi16(a: __m128i, imm8: i32) -> __m128i { 729 | | let a = a.as_i16x8(); 730 | | macro_rules! call { 731 | | ($imm8:expr) => { ... | 735 | | constify_imm8!(imm8, call) 736 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:746:1 | 746 | / pub unsafe fn _mm_srl_epi16(a: __m128i, count: __m128i) -> __m128i { 747 | | transmute(psrlw(a.as_i16x8(), count.as_i16x8())) 748 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:759:1 | 759 | / pub unsafe fn _mm_srli_epi32(a: __m128i, imm8: i32) -> __m128i { 760 | | let a = a.as_i32x4(); 761 | | macro_rules! call { 762 | | ($imm8:expr) => { ... | 766 | | constify_imm8!(imm8, call) 767 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:777:1 | 777 | / pub unsafe fn _mm_srl_epi32(a: __m128i, count: __m128i) -> __m128i { 778 | | transmute(psrld(a.as_i32x4(), count.as_i32x4())) 779 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:790:1 | 790 | / pub unsafe fn _mm_srli_epi64(a: __m128i, imm8: i32) -> __m128i { 791 | | transmute(psrliq(a.as_i64x2(), imm8)) 792 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:802:1 | 802 | / pub unsafe fn _mm_srl_epi64(a: __m128i, count: __m128i) -> __m128i { 803 | | transmute(psrlq(a.as_i64x2(), count.as_i64x2())) 804 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:814:1 | 814 | / pub unsafe fn _mm_and_si128(a: __m128i, b: __m128i) -> __m128i { 815 | | simd_and(a, b) 816 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:826:1 | 826 | / pub unsafe fn _mm_andnot_si128(a: __m128i, b: __m128i) -> __m128i { 827 | | simd_and(simd_xor(_mm_set1_epi8(-1), a), b) 828 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:838:1 | 838 | / pub unsafe fn _mm_or_si128(a: __m128i, b: __m128i) -> __m128i { 839 | | simd_or(a, b) 840 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:850:1 | 850 | / pub unsafe fn _mm_xor_si128(a: __m128i, b: __m128i) -> __m128i { 851 | | simd_xor(a, b) 852 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:861:1 | 861 | / pub unsafe fn _mm_cmpeq_epi8(a: __m128i, b: __m128i) -> __m128i { 862 | | transmute::(simd_eq(a.as_i8x16(), b.as_i8x16())) 863 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:872:1 | 872 | / pub unsafe fn _mm_cmpeq_epi16(a: __m128i, b: __m128i) -> __m128i { 873 | | transmute::(simd_eq(a.as_i16x8(), b.as_i16x8())) 874 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:883:1 | 883 | / pub unsafe fn _mm_cmpeq_epi32(a: __m128i, b: __m128i) -> __m128i { 884 | | transmute::(simd_eq(a.as_i32x4(), b.as_i32x4())) 885 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:894:1 | 894 | / pub unsafe fn _mm_cmpgt_epi8(a: __m128i, b: __m128i) -> __m128i { 895 | | transmute::(simd_gt(a.as_i8x16(), b.as_i8x16())) 896 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:905:1 | 905 | / pub unsafe fn _mm_cmpgt_epi16(a: __m128i, b: __m128i) -> __m128i { 906 | | transmute::(simd_gt(a.as_i16x8(), b.as_i16x8())) 907 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:916:1 | 916 | / pub unsafe fn _mm_cmpgt_epi32(a: __m128i, b: __m128i) -> __m128i { 917 | | transmute::(simd_gt(a.as_i32x4(), b.as_i32x4())) 918 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:927:1 | 927 | / pub unsafe fn _mm_cmplt_epi8(a: __m128i, b: __m128i) -> __m128i { 928 | | transmute::(simd_lt(a.as_i8x16(), b.as_i8x16())) 929 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:938:1 | 938 | / pub unsafe fn _mm_cmplt_epi16(a: __m128i, b: __m128i) -> __m128i { 939 | | transmute::(simd_lt(a.as_i16x8(), b.as_i16x8())) 940 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:949:1 | 949 | / pub unsafe fn _mm_cmplt_epi32(a: __m128i, b: __m128i) -> __m128i { 950 | | transmute::(simd_lt(a.as_i32x4(), b.as_i32x4())) 951 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:961:1 | 961 | / pub unsafe fn _mm_cvtepi32_pd(a: __m128i) -> __m128d { 962 | | let a = a.as_i32x4(); 963 | | simd_cast::(simd_shuffle2(a, a, [0, 1])) 964 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:974:1 | 974 | / pub unsafe fn _mm_cvtsi32_sd(a: __m128d, b: i32) -> __m128d { 975 | | simd_insert(a, 0, b as f64) 976 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:986:1 | 986 | / pub unsafe fn _mm_cvtepi32_ps(a: __m128i) -> __m128 { 987 | | cvtdq2ps(a.as_i32x4()) 988 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:998:1 | 998 | / pub unsafe fn _mm_cvtps_epi32(a: __m128) -> __m128i { 999 | | transmute(cvtps2dq(a)) 1000 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1010:1 | 1010 | / pub unsafe fn _mm_cvtsi32_si128(a: i32) -> __m128i { 1011 | | transmute(i32x4::new(a, 0, 0, 0)) 1012 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1021:1 | 1021 | / pub unsafe fn _mm_cvtsi128_si32(a: __m128i) -> i32 { 1022 | | simd_extract(a.as_i32x4(), 0) 1023 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1033:1 | 1033 | / pub unsafe fn _mm_set_epi64x(e1: i64, e0: i64) -> __m128i { 1034 | | transmute(i64x2::new(e0, e1)) 1035 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1044:1 | 1044 | / pub unsafe fn _mm_set_epi32(e3: i32, e2: i32, e1: i32, e0: i32) -> __m128i { 1045 | | transmute(i32x4::new(e0, e1, e2, e3)) 1046 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1055:1 | 1055 | / pub unsafe fn _mm_set_epi16( 1056 | | e7: i16, 1057 | | e6: i16, 1058 | | e5: i16, ... | 1065 | | transmute(i16x8::new(e0, e1, e2, e3, e4, e5, e6, e7)) 1066 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1055:1 | 1055 | / pub unsafe fn _mm_set_epi16( 1056 | | e7: i16, 1057 | | e6: i16, 1058 | | e5: i16, ... | 1063 | | e0: i16, 1064 | | ) -> __m128i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1075:1 | 1075 | / pub unsafe fn _mm_set_epi8( 1076 | | e15: i8, 1077 | | e14: i8, 1078 | | e13: i8, ... | 1096 | | )) 1097 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1075:1 | 1075 | / pub unsafe fn _mm_set_epi8( 1076 | | e15: i8, 1077 | | e14: i8, 1078 | | e13: i8, ... | 1091 | | e0: i8, 1092 | | ) -> __m128i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1106:1 | 1106 | / pub unsafe fn _mm_set1_epi64x(a: i64) -> __m128i { 1107 | | _mm_set_epi64x(a, a) 1108 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1117:1 | 1117 | / pub unsafe fn _mm_set1_epi32(a: i32) -> __m128i { 1118 | | _mm_set_epi32(a, a, a, a) 1119 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1128:1 | 1128 | / pub unsafe fn _mm_set1_epi16(a: i16) -> __m128i { 1129 | | _mm_set_epi16(a, a, a, a, a, a, a, a) 1130 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1139:1 | 1139 | / pub unsafe fn _mm_set1_epi8(a: i8) -> __m128i { 1140 | | _mm_set_epi8(a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a) 1141 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1150:1 | 1150 | / pub unsafe fn _mm_setr_epi32(e3: i32, e2: i32, e1: i32, e0: i32) -> __m128i { 1151 | | _mm_set_epi32(e0, e1, e2, e3) 1152 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1161:1 | 1161 | / pub unsafe fn _mm_setr_epi16( 1162 | | e7: i16, 1163 | | e6: i16, 1164 | | e5: i16, ... | 1171 | | _mm_set_epi16(e0, e1, e2, e3, e4, e5, e6, e7) 1172 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1161:1 | 1161 | / pub unsafe fn _mm_setr_epi16( 1162 | | e7: i16, 1163 | | e6: i16, 1164 | | e5: i16, ... | 1169 | | e0: i16, 1170 | | ) -> __m128i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1181:1 | 1181 | / pub unsafe fn _mm_setr_epi8( 1182 | | e15: i8, 1183 | | e14: i8, 1184 | | e13: i8, ... | 1202 | | ) 1203 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1181:1 | 1181 | / pub unsafe fn _mm_setr_epi8( 1182 | | e15: i8, 1183 | | e14: i8, 1184 | | e13: i8, ... | 1197 | | e0: i8, 1198 | | ) -> __m128i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1212:1 | 1212 | / pub unsafe fn _mm_setzero_si128() -> __m128i { 1213 | | _mm_set1_epi64x(0) 1214 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1232:1 | 1232 | / pub unsafe fn _mm_loadl_epi64(mem_addr: *const __m128i) -> __m128i { 1233 | | _mm_set_epi64x(0, ptr::read_unaligned(mem_addr as *const i64)) 1234 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1245:1 | 1245 | / pub unsafe fn _mm_load_si128(mem_addr: *const __m128i) -> __m128i { 1246 | | *mem_addr 1247 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1258:1 | 1258 | / pub unsafe fn _mm_loadu_si128(mem_addr: *const __m128i) -> __m128i { 1259 | | let mut dst: __m128i = _mm_undefined_si128(); 1260 | | ptr::copy_nonoverlapping( 1261 | | mem_addr as *const u8, ... | 1265 | | dst 1266 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1282:1 | 1282 | / pub unsafe fn _mm_maskmoveu_si128(a: __m128i, mask: __m128i, mem_addr: *mut i8) { 1283 | | maskmovdqu(a.as_i8x16(), mask.as_i8x16(), mem_addr) 1284 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1295:1 | 1295 | / pub unsafe fn _mm_store_si128(mem_addr: *mut __m128i, a: __m128i) { 1296 | | *mem_addr = a; 1297 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1308:1 | 1308 | / pub unsafe fn _mm_storeu_si128(mem_addr: *mut __m128i, a: __m128i) { 1309 | | storeudq(mem_addr as *mut i8, a); 1310 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1330:1 | 1330 | / pub unsafe fn _mm_storel_epi64(mem_addr: *mut __m128i, a: __m128i) { 1331 | | ptr::copy_nonoverlapping(&a as *const _ as *const u8, mem_addr as *mut u8, 8); 1332 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1343:1 | 1343 | / pub unsafe fn _mm_stream_si128(mem_addr: *mut __m128i, a: __m128i) { 1344 | | intrinsics::nontemporal_store(mem_addr, a); 1345 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1356:1 | 1356 | / pub unsafe fn _mm_stream_si32(mem_addr: *mut i32, a: i32) { 1357 | | intrinsics::nontemporal_store(mem_addr, a); 1358 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1369:1 | 1369 | / pub unsafe fn _mm_move_epi64(a: __m128i) -> __m128i { 1370 | | let zero = _mm_setzero_si128(); 1371 | | let r: i64x2 = simd_shuffle2(a.as_i64x2(), zero.as_i64x2(), [0, 2]); 1372 | | transmute(r) 1373 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1383:1 | 1383 | / pub unsafe fn _mm_packs_epi16(a: __m128i, b: __m128i) -> __m128i { 1384 | | transmute(packsswb(a.as_i16x8(), b.as_i16x8())) 1385 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1395:1 | 1395 | / pub unsafe fn _mm_packs_epi32(a: __m128i, b: __m128i) -> __m128i { 1396 | | transmute(packssdw(a.as_i32x4(), b.as_i32x4())) 1397 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1407:1 | 1407 | / pub unsafe fn _mm_packus_epi16(a: __m128i, b: __m128i) -> __m128i { 1408 | | transmute(packuswb(a.as_i16x8(), b.as_i16x8())) 1409 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1419:1 | 1419 | / pub unsafe fn _mm_extract_epi16(a: __m128i, imm8: i32) -> i32 { 1420 | | let a = a.as_u16x8(); 1421 | | macro_rules! call { 1422 | | ($imm3:expr) => { ... | 1426 | | constify_imm3!(imm8, call) 1427 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1437:1 | 1437 | / pub unsafe fn _mm_insert_epi16(a: __m128i, i: i32, imm8: i32) -> __m128i { 1438 | | let a = a.as_i16x8(); 1439 | | macro_rules! call { 1440 | | ($imm3:expr) => { ... | 1444 | | constify_imm3!(imm8, call) 1445 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1454:1 | 1454 | / pub unsafe fn _mm_movemask_epi8(a: __m128i) -> i32 { 1455 | | pmovmskb(a.as_i8x16()) 1456 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1466:1 | 1466 | / pub unsafe fn _mm_shuffle_epi32(a: __m128i, imm8: i32) -> __m128i { 1467 | | // simd_shuffleX requires that its selector parameter be made up of 1468 | | // constant values, but we can't enforce that here. In spirit, we need 1469 | | // to write a `match` on all possible values of a byte, and for each value, ... | 1518 | | transmute(x) 1519 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1533:1 | 1533 | / pub unsafe fn _mm_shufflehi_epi16(a: __m128i, imm8: i32) -> __m128i { 1534 | | // See _mm_shuffle_epi32. 1535 | | let imm8 = (imm8 & 0xFF) as u8; 1536 | | let a = a.as_i16x8(); ... | 1578 | | transmute(x) 1579 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1593:1 | 1593 | / pub unsafe fn _mm_shufflelo_epi16(a: __m128i, imm8: i32) -> __m128i { 1594 | | // See _mm_shuffle_epi32. 1595 | | let imm8 = (imm8 & 0xFF) as u8; 1596 | | let a = a.as_i16x8(); ... | 1639 | | transmute(x) 1640 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1649:1 | 1649 | / pub unsafe fn _mm_unpackhi_epi8(a: __m128i, b: __m128i) -> __m128i { 1650 | | transmute::(simd_shuffle16( 1651 | | a.as_i8x16(), 1652 | | b.as_i8x16(), 1653 | | [8, 24, 9, 25, 10, 26, 11, 27, 12, 28, 13, 29, 14, 30, 15, 31], 1654 | | )) 1655 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1664:1 | 1664 | / pub unsafe fn _mm_unpackhi_epi16(a: __m128i, b: __m128i) -> __m128i { 1665 | | let x = simd_shuffle8(a.as_i16x8(), b.as_i16x8(), [4, 12, 5, 13, 6, 14, 7, 15]); 1666 | | transmute::(x) 1667 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1676:1 | 1676 | / pub unsafe fn _mm_unpackhi_epi32(a: __m128i, b: __m128i) -> __m128i { 1677 | | transmute::(simd_shuffle4(a.as_i32x4(), b.as_i32x4(), [2, 6, 3, 7])) 1678 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1687:1 | 1687 | / pub unsafe fn _mm_unpackhi_epi64(a: __m128i, b: __m128i) -> __m128i { 1688 | | transmute::(simd_shuffle2(a.as_i64x2(), b.as_i64x2(), [1, 3])) 1689 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1698:1 | 1698 | / pub unsafe fn _mm_unpacklo_epi8(a: __m128i, b: __m128i) -> __m128i { 1699 | | transmute::(simd_shuffle16( 1700 | | a.as_i8x16(), 1701 | | b.as_i8x16(), 1702 | | [0, 16, 1, 17, 2, 18, 3, 19, 4, 20, 5, 21, 6, 22, 7, 23], 1703 | | )) 1704 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1713:1 | 1713 | / pub unsafe fn _mm_unpacklo_epi16(a: __m128i, b: __m128i) -> __m128i { 1714 | | let x = simd_shuffle8(a.as_i16x8(), b.as_i16x8(), [0, 8, 1, 9, 2, 10, 3, 11]); 1715 | | transmute::(x) 1716 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1725:1 | 1725 | / pub unsafe fn _mm_unpacklo_epi32(a: __m128i, b: __m128i) -> __m128i { 1726 | | transmute::(simd_shuffle4(a.as_i32x4(), b.as_i32x4(), [0, 4, 1, 5])) 1727 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1736:1 | 1736 | / pub unsafe fn _mm_unpacklo_epi64(a: __m128i, b: __m128i) -> __m128i { 1737 | | transmute::(simd_shuffle2(a.as_i64x2(), b.as_i64x2(), [0, 2])) 1738 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1748:1 | 1748 | / pub unsafe fn _mm_add_sd(a: __m128d, b: __m128d) -> __m128d { 1749 | | simd_insert(a, 0, _mm_cvtsd_f64(a) + _mm_cvtsd_f64(b)) 1750 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1760:1 | 1760 | / pub unsafe fn _mm_add_pd(a: __m128d, b: __m128d) -> __m128d { 1761 | | simd_add(a, b) 1762 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1772:1 | 1772 | / pub unsafe fn _mm_div_sd(a: __m128d, b: __m128d) -> __m128d { 1773 | | simd_insert(a, 0, _mm_cvtsd_f64(a) / _mm_cvtsd_f64(b)) 1774 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1784:1 | 1784 | / pub unsafe fn _mm_div_pd(a: __m128d, b: __m128d) -> __m128d { 1785 | | simd_div(a, b) 1786 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1796:1 | 1796 | / pub unsafe fn _mm_max_sd(a: __m128d, b: __m128d) -> __m128d { 1797 | | maxsd(a, b) 1798 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1808:1 | 1808 | / pub unsafe fn _mm_max_pd(a: __m128d, b: __m128d) -> __m128d { 1809 | | maxpd(a, b) 1810 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1820:1 | 1820 | / pub unsafe fn _mm_min_sd(a: __m128d, b: __m128d) -> __m128d { 1821 | | minsd(a, b) 1822 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1832:1 | 1832 | / pub unsafe fn _mm_min_pd(a: __m128d, b: __m128d) -> __m128d { 1833 | | minpd(a, b) 1834 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1844:1 | 1844 | / pub unsafe fn _mm_mul_sd(a: __m128d, b: __m128d) -> __m128d { 1845 | | simd_insert(a, 0, _mm_cvtsd_f64(a) * _mm_cvtsd_f64(b)) 1846 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1856:1 | 1856 | / pub unsafe fn _mm_mul_pd(a: __m128d, b: __m128d) -> __m128d { 1857 | | simd_mul(a, b) 1858 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1868:1 | 1868 | / pub unsafe fn _mm_sqrt_sd(a: __m128d, b: __m128d) -> __m128d { 1869 | | simd_insert(a, 0, _mm_cvtsd_f64(sqrtsd(b))) 1870 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1879:1 | 1879 | / pub unsafe fn _mm_sqrt_pd(a: __m128d) -> __m128d { 1880 | | simd_fsqrt(a) 1881 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1891:1 | 1891 | / pub unsafe fn _mm_sub_sd(a: __m128d, b: __m128d) -> __m128d { 1892 | | simd_insert(a, 0, _mm_cvtsd_f64(a) - _mm_cvtsd_f64(b)) 1893 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1903:1 | 1903 | / pub unsafe fn _mm_sub_pd(a: __m128d, b: __m128d) -> __m128d { 1904 | | simd_sub(a, b) 1905 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1915:1 | 1915 | / pub unsafe fn _mm_and_pd(a: __m128d, b: __m128d) -> __m128d { 1916 | | let a: __m128i = transmute(a); 1917 | | let b: __m128i = transmute(b); 1918 | | transmute(_mm_and_si128(a, b)) 1919 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1928:1 | 1928 | / pub unsafe fn _mm_andnot_pd(a: __m128d, b: __m128d) -> __m128d { 1929 | | let a: __m128i = transmute(a); 1930 | | let b: __m128i = transmute(b); 1931 | | transmute(_mm_andnot_si128(a, b)) 1932 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1941:1 | 1941 | / pub unsafe fn _mm_or_pd(a: __m128d, b: __m128d) -> __m128d { 1942 | | let a: __m128i = transmute(a); 1943 | | let b: __m128i = transmute(b); 1944 | | transmute(_mm_or_si128(a, b)) 1945 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1954:1 | 1954 | / pub unsafe fn _mm_xor_pd(a: __m128d, b: __m128d) -> __m128d { 1955 | | let a: __m128i = transmute(a); 1956 | | let b: __m128i = transmute(b); 1957 | | transmute(_mm_xor_si128(a, b)) 1958 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1968:1 | 1968 | / pub unsafe fn _mm_cmpeq_sd(a: __m128d, b: __m128d) -> __m128d { 1969 | | cmpsd(a, b, 0) 1970 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1980:1 | 1980 | / pub unsafe fn _mm_cmplt_sd(a: __m128d, b: __m128d) -> __m128d { 1981 | | cmpsd(a, b, 1) 1982 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:1992:1 | 1992 | / pub unsafe fn _mm_cmple_sd(a: __m128d, b: __m128d) -> __m128d { 1993 | | cmpsd(a, b, 2) 1994 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2004:1 | 2004 | / pub unsafe fn _mm_cmpgt_sd(a: __m128d, b: __m128d) -> __m128d { 2005 | | simd_insert(_mm_cmplt_sd(b, a), 1, simd_extract::<_, f64>(a, 1)) 2006 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2016:1 | 2016 | / pub unsafe fn _mm_cmpge_sd(a: __m128d, b: __m128d) -> __m128d { 2017 | | simd_insert(_mm_cmple_sd(b, a), 1, simd_extract::<_, f64>(a, 1)) 2018 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2030:1 | 2030 | / pub unsafe fn _mm_cmpord_sd(a: __m128d, b: __m128d) -> __m128d { 2031 | | cmpsd(a, b, 7) 2032 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2043:1 | 2043 | / pub unsafe fn _mm_cmpunord_sd(a: __m128d, b: __m128d) -> __m128d { 2044 | | cmpsd(a, b, 3) 2045 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2055:1 | 2055 | / pub unsafe fn _mm_cmpneq_sd(a: __m128d, b: __m128d) -> __m128d { 2056 | | cmpsd(a, b, 4) 2057 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2067:1 | 2067 | / pub unsafe fn _mm_cmpnlt_sd(a: __m128d, b: __m128d) -> __m128d { 2068 | | cmpsd(a, b, 5) 2069 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2079:1 | 2079 | / pub unsafe fn _mm_cmpnle_sd(a: __m128d, b: __m128d) -> __m128d { 2080 | | cmpsd(a, b, 6) 2081 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2091:1 | 2091 | / pub unsafe fn _mm_cmpngt_sd(a: __m128d, b: __m128d) -> __m128d { 2092 | | simd_insert(_mm_cmpnlt_sd(b, a), 1, simd_extract::<_, f64>(a, 1)) 2093 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2103:1 | 2103 | / pub unsafe fn _mm_cmpnge_sd(a: __m128d, b: __m128d) -> __m128d { 2104 | | simd_insert(_mm_cmpnle_sd(b, a), 1, simd_extract::<_, f64>(a, 1)) 2105 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2114:1 | 2114 | / pub unsafe fn _mm_cmpeq_pd(a: __m128d, b: __m128d) -> __m128d { 2115 | | cmppd(a, b, 0) 2116 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2125:1 | 2125 | / pub unsafe fn _mm_cmplt_pd(a: __m128d, b: __m128d) -> __m128d { 2126 | | cmppd(a, b, 1) 2127 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2136:1 | 2136 | / pub unsafe fn _mm_cmple_pd(a: __m128d, b: __m128d) -> __m128d { 2137 | | cmppd(a, b, 2) 2138 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2147:1 | 2147 | / pub unsafe fn _mm_cmpgt_pd(a: __m128d, b: __m128d) -> __m128d { 2148 | | _mm_cmplt_pd(b, a) 2149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2158:1 | 2158 | / pub unsafe fn _mm_cmpge_pd(a: __m128d, b: __m128d) -> __m128d { 2159 | | _mm_cmple_pd(b, a) 2160 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2169:1 | 2169 | / pub unsafe fn _mm_cmpord_pd(a: __m128d, b: __m128d) -> __m128d { 2170 | | cmppd(a, b, 7) 2171 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2180:1 | 2180 | / pub unsafe fn _mm_cmpunord_pd(a: __m128d, b: __m128d) -> __m128d { 2181 | | cmppd(a, b, 3) 2182 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2191:1 | 2191 | / pub unsafe fn _mm_cmpneq_pd(a: __m128d, b: __m128d) -> __m128d { 2192 | | cmppd(a, b, 4) 2193 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2202:1 | 2202 | / pub unsafe fn _mm_cmpnlt_pd(a: __m128d, b: __m128d) -> __m128d { 2203 | | cmppd(a, b, 5) 2204 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2213:1 | 2213 | / pub unsafe fn _mm_cmpnle_pd(a: __m128d, b: __m128d) -> __m128d { 2214 | | cmppd(a, b, 6) 2215 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2224:1 | 2224 | / pub unsafe fn _mm_cmpngt_pd(a: __m128d, b: __m128d) -> __m128d { 2225 | | _mm_cmpnlt_pd(b, a) 2226 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2236:1 | 2236 | / pub unsafe fn _mm_cmpnge_pd(a: __m128d, b: __m128d) -> __m128d { 2237 | | _mm_cmpnle_pd(b, a) 2238 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2247:1 | 2247 | / pub unsafe fn _mm_comieq_sd(a: __m128d, b: __m128d) -> i32 { 2248 | | comieqsd(a, b) 2249 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2258:1 | 2258 | / pub unsafe fn _mm_comilt_sd(a: __m128d, b: __m128d) -> i32 { 2259 | | comiltsd(a, b) 2260 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2269:1 | 2269 | / pub unsafe fn _mm_comile_sd(a: __m128d, b: __m128d) -> i32 { 2270 | | comilesd(a, b) 2271 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2280:1 | 2280 | / pub unsafe fn _mm_comigt_sd(a: __m128d, b: __m128d) -> i32 { 2281 | | comigtsd(a, b) 2282 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2291:1 | 2291 | / pub unsafe fn _mm_comige_sd(a: __m128d, b: __m128d) -> i32 { 2292 | | comigesd(a, b) 2293 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2302:1 | 2302 | / pub unsafe fn _mm_comineq_sd(a: __m128d, b: __m128d) -> i32 { 2303 | | comineqsd(a, b) 2304 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2313:1 | 2313 | / pub unsafe fn _mm_ucomieq_sd(a: __m128d, b: __m128d) -> i32 { 2314 | | ucomieqsd(a, b) 2315 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2324:1 | 2324 | / pub unsafe fn _mm_ucomilt_sd(a: __m128d, b: __m128d) -> i32 { 2325 | | ucomiltsd(a, b) 2326 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2335:1 | 2335 | / pub unsafe fn _mm_ucomile_sd(a: __m128d, b: __m128d) -> i32 { 2336 | | ucomilesd(a, b) 2337 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2346:1 | 2346 | / pub unsafe fn _mm_ucomigt_sd(a: __m128d, b: __m128d) -> i32 { 2347 | | ucomigtsd(a, b) 2348 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2357:1 | 2357 | / pub unsafe fn _mm_ucomige_sd(a: __m128d, b: __m128d) -> i32 { 2358 | | ucomigesd(a, b) 2359 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2368:1 | 2368 | / pub unsafe fn _mm_ucomineq_sd(a: __m128d, b: __m128d) -> i32 { 2369 | | ucomineqsd(a, b) 2370 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2380:1 | 2380 | / pub unsafe fn _mm_cvtpd_ps(a: __m128d) -> __m128 { 2381 | | cvtpd2ps(a) 2382 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2393:1 | 2393 | / pub unsafe fn _mm_cvtps_pd(a: __m128) -> __m128d { 2394 | | cvtps2pd(a) 2395 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2405:1 | 2405 | / pub unsafe fn _mm_cvtpd_epi32(a: __m128d) -> __m128i { 2406 | | transmute(cvtpd2dq(a)) 2407 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2417:1 | 2417 | / pub unsafe fn _mm_cvtsd_si32(a: __m128d) -> i32 { 2418 | | cvtsd2si(a) 2419 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2431:1 | 2431 | / pub unsafe fn _mm_cvtsd_ss(a: __m128, b: __m128d) -> __m128 { 2432 | | cvtsd2ss(a, b) 2433 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2441:1 | 2441 | / pub unsafe fn _mm_cvtsd_f64(a: __m128d) -> f64 { 2442 | | simd_extract(a, 0) 2443 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2455:1 | 2455 | / pub unsafe fn _mm_cvtss_sd(a: __m128d, b: __m128) -> __m128d { 2456 | | cvtss2sd(a, b) 2457 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2467:1 | 2467 | / pub unsafe fn _mm_cvttpd_epi32(a: __m128d) -> __m128i { 2468 | | transmute(cvttpd2dq(a)) 2469 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2479:1 | 2479 | / pub unsafe fn _mm_cvttsd_si32(a: __m128d) -> i32 { 2480 | | cvttsd2si(a) 2481 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2491:1 | 2491 | / pub unsafe fn _mm_cvttps_epi32(a: __m128) -> __m128i { 2492 | | transmute(cvttps2dq(a)) 2493 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2502:1 | 2502 | / pub unsafe fn _mm_set_sd(a: f64) -> __m128d { 2503 | | _mm_set_pd(0.0, a) 2504 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2513:1 | 2513 | / pub unsafe fn _mm_set1_pd(a: f64) -> __m128d { 2514 | | _mm_set_pd(a, a) 2515 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2524:1 | 2524 | / pub unsafe fn _mm_set_pd1(a: f64) -> __m128d { 2525 | | _mm_set_pd(a, a) 2526 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2535:1 | 2535 | / pub unsafe fn _mm_set_pd(a: f64, b: f64) -> __m128d { 2536 | | __m128d(b, a) 2537 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2546:1 | 2546 | / pub unsafe fn _mm_setr_pd(a: f64, b: f64) -> __m128d { 2547 | | _mm_set_pd(b, a) 2548 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2558:1 | 2558 | / pub unsafe fn _mm_setzero_pd() -> __m128d { 2559 | | _mm_set_pd(0.0, 0.0) 2560 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2572:1 | 2572 | / pub unsafe fn _mm_movemask_pd(a: __m128d) -> i32 { 2573 | | movmskpd(a) 2574 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2587:1 | 2587 | / pub unsafe fn _mm_load_pd(mem_addr: *const f64) -> __m128d { 2588 | | *(mem_addr as *const __m128d) 2589 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2599:1 | 2599 | / pub unsafe fn _mm_load_sd(mem_addr: *const f64) -> __m128d { 2600 | | _mm_setr_pd(*mem_addr, 0.) 2601 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2612:1 | 2612 | / pub unsafe fn _mm_loadh_pd(a: __m128d, mem_addr: *const f64) -> __m128d { 2613 | | _mm_setr_pd(simd_extract(a, 0), *mem_addr) 2614 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2625:1 | 2625 | / pub unsafe fn _mm_loadl_pd(a: __m128d, mem_addr: *const f64) -> __m128d { 2626 | | _mm_setr_pd(*mem_addr, simd_extract(a, 1)) 2627 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2640:1 | 2640 | / pub unsafe fn _mm_stream_pd(mem_addr: *mut f64, a: __m128d) { 2641 | | intrinsics::nontemporal_store(mem_addr as *mut __m128d, a); 2642 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2652:1 | 2652 | / pub unsafe fn _mm_store_sd(mem_addr: *mut f64, a: __m128d) { 2653 | | *mem_addr = simd_extract(a, 0) 2654 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2666:1 | 2666 | / pub unsafe fn _mm_store_pd(mem_addr: *mut f64, a: __m128d) { 2667 | | *(mem_addr as *mut __m128d) = a; 2668 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2679:1 | 2679 | / pub unsafe fn _mm_storeu_pd(mem_addr: *mut f64, a: __m128d) { 2680 | | storeupd(mem_addr as *mut i8, a); 2681 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2692:1 | 2692 | / pub unsafe fn _mm_store1_pd(mem_addr: *mut f64, a: __m128d) { 2693 | | let b: __m128d = simd_shuffle2(a, a, [0, 0]); 2694 | | *(mem_addr as *mut __m128d) = b; 2695 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2706:1 | 2706 | / pub unsafe fn _mm_store_pd1(mem_addr: *mut f64, a: __m128d) { 2707 | | let b: __m128d = simd_shuffle2(a, a, [0, 0]); 2708 | | *(mem_addr as *mut __m128d) = b; 2709 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2721:1 | 2721 | / pub unsafe fn _mm_storer_pd(mem_addr: *mut f64, a: __m128d) { 2722 | | let b: __m128d = simd_shuffle2(a, a, [1, 0]); 2723 | | *(mem_addr as *mut __m128d) = b; 2724 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2734:1 | 2734 | / pub unsafe fn _mm_storeh_pd(mem_addr: *mut f64, a: __m128d) { 2735 | | *mem_addr = simd_extract(a, 1); 2736 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2746:1 | 2746 | / pub unsafe fn _mm_storel_pd(mem_addr: *mut f64, a: __m128d) { 2747 | | *mem_addr = simd_extract(a, 0); 2748 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2758:1 | 2758 | / pub unsafe fn _mm_load1_pd(mem_addr: *const f64) -> __m128d { 2759 | | let d = *mem_addr; 2760 | | _mm_setr_pd(d, d) 2761 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2771:1 | 2771 | / pub unsafe fn _mm_load_pd1(mem_addr: *const f64) -> __m128d { 2772 | | _mm_load1_pd(mem_addr) 2773 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2784:1 | 2784 | / pub unsafe fn _mm_loadr_pd(mem_addr: *const f64) -> __m128d { 2785 | | let a = _mm_load_pd(mem_addr); 2786 | | simd_shuffle2(a, a, [1, 0]) 2787 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2798:1 | 2798 | / pub unsafe fn _mm_loadu_pd(mem_addr: *const f64) -> __m128d { 2799 | | let mut dst = _mm_undefined_pd(); 2800 | | ptr::copy_nonoverlapping( 2801 | | mem_addr as *const u8, ... | 2805 | | dst 2806 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2819:1 | 2819 | / pub unsafe fn _mm_shuffle_pd(a: __m128d, b: __m128d, imm8: i32) -> __m128d { 2820 | | match imm8 & 0b11 { 2821 | | 0b00 => simd_shuffle2(a, b, [0, 2]), 2822 | | 0b01 => simd_shuffle2(a, b, [1, 2]), ... | 2825 | | } 2826 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2838:1 | 2838 | / pub unsafe fn _mm_move_sd(a: __m128d, b: __m128d) -> __m128d { 2839 | | _mm_setr_pd(simd_extract(b, 0), simd_extract(a, 1)) 2840 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2849:1 | 2849 | / pub unsafe fn _mm_castpd_ps(a: __m128d) -> __m128 { 2850 | | transmute(a) 2851 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2860:1 | 2860 | / pub unsafe fn _mm_castpd_si128(a: __m128d) -> __m128i { 2861 | | transmute(a) 2862 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2871:1 | 2871 | / pub unsafe fn _mm_castps_pd(a: __m128) -> __m128d { 2872 | | transmute(a) 2873 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2882:1 | 2882 | / pub unsafe fn _mm_castps_si128(a: __m128) -> __m128i { 2883 | | transmute(a) 2884 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2893:1 | 2893 | / pub unsafe fn _mm_castsi128_pd(a: __m128i) -> __m128d { 2894 | | transmute(a) 2895 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2904:1 | 2904 | / pub unsafe fn _mm_castsi128_ps(a: __m128i) -> __m128 { 2905 | | transmute(a) 2906 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2914:1 | 2914 | / pub unsafe fn _mm_undefined_pd() -> __m128d { 2915 | | // FIXME: this function should return MaybeUninit<__m128d> 2916 | | mem::MaybeUninit::<__m128d>::uninit().assume_init() 2917 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2925:1 | 2925 | / pub unsafe fn _mm_undefined_si128() -> __m128i { 2926 | | // FIXME: this function should return MaybeUninit<__m128i> 2927 | | mem::MaybeUninit::<__m128i>::uninit().assume_init() 2928 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2942:1 | 2942 | / pub unsafe fn _mm_unpackhi_pd(a: __m128d, b: __m128d) -> __m128d { 2943 | | simd_shuffle2(a, b, [1, 3]) 2944 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse2.rs:2957:1 | 2957 | / pub unsafe fn _mm_unpacklo_pd(a: __m128d, b: __m128d) -> __m128d { 2958 | | simd_shuffle2(a, b, [0, 2]) 2959 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:23:1 | 23 | / pub unsafe fn _mm_addsub_ps(a: __m128, b: __m128) -> __m128 { 24 | | addsubps(a, b) 25 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:35:1 | 35 | / pub unsafe fn _mm_addsub_pd(a: __m128d, b: __m128d) -> __m128d { 36 | | addsubpd(a, b) 37 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:47:1 | 47 | / pub unsafe fn _mm_hadd_pd(a: __m128d, b: __m128d) -> __m128d { 48 | | haddpd(a, b) 49 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:59:1 | 59 | / pub unsafe fn _mm_hadd_ps(a: __m128, b: __m128) -> __m128 { 60 | | haddps(a, b) 61 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:71:1 | 71 | / pub unsafe fn _mm_hsub_pd(a: __m128d, b: __m128d) -> __m128d { 72 | | hsubpd(a, b) 73 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:83:1 | 83 | / pub unsafe fn _mm_hsub_ps(a: __m128, b: __m128) -> __m128 { 84 | | hsubps(a, b) 85 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:96:1 | 96 | / pub unsafe fn _mm_lddqu_si128(mem_addr: *const __m128i) -> __m128i { 97 | | transmute(lddqu(mem_addr as *const _)) 98 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:108:1 | 108 | / pub unsafe fn _mm_movedup_pd(a: __m128d) -> __m128d { 109 | | simd_shuffle2(a, a, [0, 0]) 110 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:120:1 | 120 | / pub unsafe fn _mm_loaddup_pd(mem_addr: *const f64) -> __m128d { 121 | | _mm_load1_pd(mem_addr) 122 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:132:1 | 132 | / pub unsafe fn _mm_movehdup_ps(a: __m128) -> __m128 { 133 | | simd_shuffle4(a, a, [1, 1, 3, 3]) 134 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse3.rs:144:1 | 144 | / pub unsafe fn _mm_moveldup_ps(a: __m128) -> __m128 { 145 | | simd_shuffle4(a, a, [0, 0, 2, 2]) 146 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:19:1 | 19 | / pub unsafe fn _mm_abs_epi8(a: __m128i) -> __m128i { 20 | | transmute(pabsb128(a.as_i8x16())) 21 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:32:1 | 32 | / pub unsafe fn _mm_abs_epi16(a: __m128i) -> __m128i { 33 | | transmute(pabsw128(a.as_i16x8())) 34 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:45:1 | 45 | / pub unsafe fn _mm_abs_epi32(a: __m128i) -> __m128i { 46 | | transmute(pabsd128(a.as_i32x4())) 47 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:79:1 | 79 | / pub unsafe fn _mm_shuffle_epi8(a: __m128i, b: __m128i) -> __m128i { 80 | | transmute(pshufb128(a.as_u8x16(), b.as_u8x16())) 81 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:92:1 | 92 | / pub unsafe fn _mm_alignr_epi8(a: __m128i, b: __m128i, n: i32) -> __m128i { 93 | | let n = n as u32; 94 | | // If palignr is shifting the pair of vectors more than the size of two 95 | | // lanes, emit zero. ... | 154 | | transmute(r) 155 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:165:1 | 165 | / pub unsafe fn _mm_hadd_epi16(a: __m128i, b: __m128i) -> __m128i { 166 | | transmute(phaddw128(a.as_i16x8(), b.as_i16x8())) 167 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:178:1 | 178 | / pub unsafe fn _mm_hadds_epi16(a: __m128i, b: __m128i) -> __m128i { 179 | | transmute(phaddsw128(a.as_i16x8(), b.as_i16x8())) 180 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:190:1 | 190 | / pub unsafe fn _mm_hadd_epi32(a: __m128i, b: __m128i) -> __m128i { 191 | | transmute(phaddd128(a.as_i32x4(), b.as_i32x4())) 192 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:202:1 | 202 | / pub unsafe fn _mm_hsub_epi16(a: __m128i, b: __m128i) -> __m128i { 203 | | transmute(phsubw128(a.as_i16x8(), b.as_i16x8())) 204 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:216:1 | 216 | / pub unsafe fn _mm_hsubs_epi16(a: __m128i, b: __m128i) -> __m128i { 217 | | transmute(phsubsw128(a.as_i16x8(), b.as_i16x8())) 218 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:228:1 | 228 | / pub unsafe fn _mm_hsub_epi32(a: __m128i, b: __m128i) -> __m128i { 229 | | transmute(phsubd128(a.as_i32x4(), b.as_i32x4())) 230 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:243:1 | 243 | / pub unsafe fn _mm_maddubs_epi16(a: __m128i, b: __m128i) -> __m128i { 244 | | transmute(pmaddubsw128(a.as_u8x16(), b.as_i8x16())) 245 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:256:1 | 256 | / pub unsafe fn _mm_mulhrs_epi16(a: __m128i, b: __m128i) -> __m128i { 257 | | transmute(pmulhrsw128(a.as_i16x8(), b.as_i16x8())) 258 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:270:1 | 270 | / pub unsafe fn _mm_sign_epi8(a: __m128i, b: __m128i) -> __m128i { 271 | | transmute(psignb128(a.as_i8x16(), b.as_i8x16())) 272 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:284:1 | 284 | / pub unsafe fn _mm_sign_epi16(a: __m128i, b: __m128i) -> __m128i { 285 | | transmute(psignw128(a.as_i16x8(), b.as_i16x8())) 286 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/ssse3.rs:298:1 | 298 | / pub unsafe fn _mm_sign_epi32(a: __m128i, b: __m128i) -> __m128i { 299 | | transmute(psignd128(a.as_i32x4(), b.as_i32x4())) 300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:64:1 | 64 | / pub unsafe fn _mm_blendv_epi8(a: __m128i, b: __m128i, mask: __m128i) -> __m128i { 65 | | transmute(pblendvb(a.as_i8x16(), b.as_i8x16(), mask.as_i8x16())) 66 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:83:1 | 83 | / pub unsafe fn _mm_blend_epi16(a: __m128i, b: __m128i, imm8: i32) -> __m128i { 84 | | let a = a.as_i16x8(); 85 | | let b = b.as_i16x8(); 86 | | macro_rules! call { ... | 91 | | transmute(constify_imm8!(imm8, call)) 92 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:102:1 | 102 | / pub unsafe fn _mm_blendv_pd(a: __m128d, b: __m128d, mask: __m128d) -> __m128d { 103 | | blendvpd(a, b, mask) 104 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:114:1 | 114 | / pub unsafe fn _mm_blendv_ps(a: __m128, b: __m128, mask: __m128) -> __m128 { 115 | | blendvps(a, b, mask) 116 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:130:1 | 130 | / pub unsafe fn _mm_blend_pd(a: __m128d, b: __m128d, imm2: i32) -> __m128d { 131 | | macro_rules! call { 132 | | ($imm2:expr) => { 133 | | blendpd(a, b, $imm2) ... | 136 | | constify_imm2!(imm2, call) 137 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:148:1 | 148 | / pub unsafe fn _mm_blend_ps(a: __m128, b: __m128, imm4: i32) -> __m128 { 149 | | macro_rules! call { 150 | | ($imm4:expr) => { 151 | | blendps(a, b, $imm4) ... | 154 | | constify_imm4!(imm4, call) 155 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:169:1 | 169 | / pub unsafe fn _mm_extract_ps(a: __m128, imm8: i32) -> i32 { 170 | | macro_rules! call { 171 | | ($imm2:expr) => { 172 | | transmute(simd_extract::<_, f32>(a, $imm2)) ... | 175 | | constify_imm2!(imm8, call) 176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: transmute from a `f32` to a `i32` --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:172:13 | 170 | / macro_rules! call { 171 | | ($imm2:expr) => { 172 | | transmute(simd_extract::<_, f32>(a, $imm2)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `simd_extract::<_, f32>(a, $imm2).to_bits() as i32` 173 | | }; 174 | | } | |_____- in this expansion of `call!` (#2) 175 | constify_imm2!(imm8, call) | -------------------------- in this macro invocation (#1) | ::: library/core/src/../../stdarch/crates/core_arch/src/x86/macros.rs:83:1 | 83 | / macro_rules! constify_imm2 { 84 | | ($imm8:expr, $expand:ident) => { 85 | | #[allow(overflowing_literals)] 86 | | match ($imm8) & 0b11 { 87 | | 0 => $expand!(0), | | ----------- in this macro invocation (#2) ... | 92 | | }; 93 | | } | |_- in this expansion of `constify_imm2!` (#1) | = note: `#[warn(clippy::transmute_float_to_int)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_float_to_int warning: transmute from a `f32` to a `i32` --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:172:13 | 170 | / macro_rules! call { 171 | | ($imm2:expr) => { 172 | | transmute(simd_extract::<_, f32>(a, $imm2)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `simd_extract::<_, f32>(a, $imm2).to_bits() as i32` 173 | | }; 174 | | } | |_____- in this expansion of `call!` (#2) 175 | constify_imm2!(imm8, call) | -------------------------- in this macro invocation (#1) | ::: library/core/src/../../stdarch/crates/core_arch/src/x86/macros.rs:83:1 | 83 | / macro_rules! constify_imm2 { 84 | | ($imm8:expr, $expand:ident) => { 85 | | #[allow(overflowing_literals)] 86 | | match ($imm8) & 0b11 { 87 | | 0 => $expand!(0), 88 | | 1 => $expand!(1), | | ----------- in this macro invocation (#2) ... | 92 | | }; 93 | | } | |_- in this expansion of `constify_imm2!` (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_float_to_int warning: transmute from a `f32` to a `i32` --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:172:13 | 170 | / macro_rules! call { 171 | | ($imm2:expr) => { 172 | | transmute(simd_extract::<_, f32>(a, $imm2)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `simd_extract::<_, f32>(a, $imm2).to_bits() as i32` 173 | | }; 174 | | } | |_____- in this expansion of `call!` (#2) 175 | constify_imm2!(imm8, call) | -------------------------- in this macro invocation (#1) | ::: library/core/src/../../stdarch/crates/core_arch/src/x86/macros.rs:83:1 | 83 | / macro_rules! constify_imm2 { 84 | | ($imm8:expr, $expand:ident) => { 85 | | #[allow(overflowing_literals)] 86 | | match ($imm8) & 0b11 { ... | 89 | | 2 => $expand!(2), | | ----------- in this macro invocation (#2) ... | 92 | | }; 93 | | } | |_- in this expansion of `constify_imm2!` (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_float_to_int warning: transmute from a `f32` to a `i32` --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:172:13 | 170 | / macro_rules! call { 171 | | ($imm2:expr) => { 172 | | transmute(simd_extract::<_, f32>(a, $imm2)) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `simd_extract::<_, f32>(a, $imm2).to_bits() as i32` 173 | | }; 174 | | } | |_____- in this expansion of `call!` (#2) 175 | constify_imm2!(imm8, call) | -------------------------- in this macro invocation (#1) | ::: library/core/src/../../stdarch/crates/core_arch/src/x86/macros.rs:83:1 | 83 | / macro_rules! constify_imm2 { 84 | | ($imm8:expr, $expand:ident) => { 85 | | #[allow(overflowing_literals)] 86 | | match ($imm8) & 0b11 { ... | 90 | | _ => $expand!(3), | | ----------- in this macro invocation (#2) 91 | | } 92 | | }; 93 | | } | |_- in this expansion of `constify_imm2!` (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_float_to_int warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:189:1 | 189 | / pub unsafe fn _mm_extract_epi8(a: __m128i, imm8: i32) -> i32 { 190 | | let a = a.as_u8x16(); 191 | | macro_rules! call { 192 | | ($imm4:expr) => { ... | 196 | | constify_imm4!(imm8, call) 197 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:210:1 | 210 | / pub unsafe fn _mm_extract_epi32(a: __m128i, imm8: i32) -> i32 { 211 | | let a = a.as_i32x4(); 212 | | macro_rules! call { 213 | | ($imm2:expr) => { ... | 217 | | constify_imm2!(imm8, call) 218 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:249:1 | 249 | / pub unsafe fn _mm_insert_ps(a: __m128, b: __m128, imm8: i32) -> __m128 { 250 | | macro_rules! call { 251 | | ($imm8:expr) => { 252 | | insertps(a, b, $imm8) ... | 255 | | constify_imm8!(imm8, call) 256 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:267:1 | 267 | / pub unsafe fn _mm_insert_epi8(a: __m128i, i: i32, imm8: i32) -> __m128i { 268 | | let a = a.as_i8x16(); 269 | | macro_rules! call { 270 | | ($imm4:expr) => { ... | 274 | | constify_imm4!(imm8, call) 275 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:286:1 | 286 | / pub unsafe fn _mm_insert_epi32(a: __m128i, i: i32, imm8: i32) -> __m128i { 287 | | let a = a.as_i32x4(); 288 | | macro_rules! call { 289 | | ($imm2:expr) => { ... | 293 | | constify_imm2!(imm8, call) 294 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:304:1 | 304 | / pub unsafe fn _mm_max_epi8(a: __m128i, b: __m128i) -> __m128i { 305 | | transmute(pmaxsb(a.as_i8x16(), b.as_i8x16())) 306 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:316:1 | 316 | / pub unsafe fn _mm_max_epu16(a: __m128i, b: __m128i) -> __m128i { 317 | | transmute(pmaxuw(a.as_u16x8(), b.as_u16x8())) 318 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:328:1 | 328 | / pub unsafe fn _mm_max_epi32(a: __m128i, b: __m128i) -> __m128i { 329 | | transmute(pmaxsd(a.as_i32x4(), b.as_i32x4())) 330 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:340:1 | 340 | / pub unsafe fn _mm_max_epu32(a: __m128i, b: __m128i) -> __m128i { 341 | | transmute(pmaxud(a.as_u32x4(), b.as_u32x4())) 342 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:352:1 | 352 | / pub unsafe fn _mm_min_epi8(a: __m128i, b: __m128i) -> __m128i { 353 | | transmute(pminsb(a.as_i8x16(), b.as_i8x16())) 354 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:364:1 | 364 | / pub unsafe fn _mm_min_epu16(a: __m128i, b: __m128i) -> __m128i { 365 | | transmute(pminuw(a.as_u16x8(), b.as_u16x8())) 366 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:376:1 | 376 | / pub unsafe fn _mm_min_epi32(a: __m128i, b: __m128i) -> __m128i { 377 | | transmute(pminsd(a.as_i32x4(), b.as_i32x4())) 378 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:388:1 | 388 | / pub unsafe fn _mm_min_epu32(a: __m128i, b: __m128i) -> __m128i { 389 | | transmute(pminud(a.as_u32x4(), b.as_u32x4())) 390 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:400:1 | 400 | / pub unsafe fn _mm_packus_epi32(a: __m128i, b: __m128i) -> __m128i { 401 | | transmute(packusdw(a.as_i32x4(), b.as_i32x4())) 402 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:411:1 | 411 | / pub unsafe fn _mm_cmpeq_epi64(a: __m128i, b: __m128i) -> __m128i { 412 | | transmute(simd_eq::<_, i64x2>(a.as_i64x2(), b.as_i64x2())) 413 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:422:1 | 422 | / pub unsafe fn _mm_cvtepi8_epi16(a: __m128i) -> __m128i { 423 | | let a = a.as_i8x16(); 424 | | let a = simd_shuffle8::<_, i8x8>(a, a, [0, 1, 2, 3, 4, 5, 6, 7]); 425 | | transmute(simd_cast::<_, i16x8>(a)) 426 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:435:1 | 435 | / pub unsafe fn _mm_cvtepi8_epi32(a: __m128i) -> __m128i { 436 | | let a = a.as_i8x16(); 437 | | let a = simd_shuffle4::<_, i8x4>(a, a, [0, 1, 2, 3]); 438 | | transmute(simd_cast::<_, i32x4>(a)) 439 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:449:1 | 449 | / pub unsafe fn _mm_cvtepi8_epi64(a: __m128i) -> __m128i { 450 | | let a = a.as_i8x16(); 451 | | let a = simd_shuffle2::<_, i8x2>(a, a, [0, 1]); 452 | | transmute(simd_cast::<_, i64x2>(a)) 453 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:462:1 | 462 | / pub unsafe fn _mm_cvtepi16_epi32(a: __m128i) -> __m128i { 463 | | let a = a.as_i16x8(); 464 | | let a = simd_shuffle4::<_, i16x4>(a, a, [0, 1, 2, 3]); 465 | | transmute(simd_cast::<_, i32x4>(a)) 466 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:475:1 | 475 | / pub unsafe fn _mm_cvtepi16_epi64(a: __m128i) -> __m128i { 476 | | let a = a.as_i16x8(); 477 | | let a = simd_shuffle2::<_, i16x2>(a, a, [0, 1]); 478 | | transmute(simd_cast::<_, i64x2>(a)) 479 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:488:1 | 488 | / pub unsafe fn _mm_cvtepi32_epi64(a: __m128i) -> __m128i { 489 | | let a = a.as_i32x4(); 490 | | let a = simd_shuffle2::<_, i32x2>(a, a, [0, 1]); 491 | | transmute(simd_cast::<_, i64x2>(a)) 492 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:501:1 | 501 | / pub unsafe fn _mm_cvtepu8_epi16(a: __m128i) -> __m128i { 502 | | let a = a.as_u8x16(); 503 | | let a = simd_shuffle8::<_, u8x8>(a, a, [0, 1, 2, 3, 4, 5, 6, 7]); 504 | | transmute(simd_cast::<_, i16x8>(a)) 505 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:514:1 | 514 | / pub unsafe fn _mm_cvtepu8_epi32(a: __m128i) -> __m128i { 515 | | let a = a.as_u8x16(); 516 | | let a = simd_shuffle4::<_, u8x4>(a, a, [0, 1, 2, 3]); 517 | | transmute(simd_cast::<_, i32x4>(a)) 518 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:527:1 | 527 | / pub unsafe fn _mm_cvtepu8_epi64(a: __m128i) -> __m128i { 528 | | let a = a.as_u8x16(); 529 | | let a = simd_shuffle2::<_, u8x2>(a, a, [0, 1]); 530 | | transmute(simd_cast::<_, i64x2>(a)) 531 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:541:1 | 541 | / pub unsafe fn _mm_cvtepu16_epi32(a: __m128i) -> __m128i { 542 | | let a = a.as_u16x8(); 543 | | let a = simd_shuffle4::<_, u16x4>(a, a, [0, 1, 2, 3]); 544 | | transmute(simd_cast::<_, i32x4>(a)) 545 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:555:1 | 555 | / pub unsafe fn _mm_cvtepu16_epi64(a: __m128i) -> __m128i { 556 | | let a = a.as_u16x8(); 557 | | let a = simd_shuffle2::<_, u16x2>(a, a, [0, 1]); 558 | | transmute(simd_cast::<_, i64x2>(a)) 559 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:569:1 | 569 | / pub unsafe fn _mm_cvtepu32_epi64(a: __m128i) -> __m128i { 570 | | let a = a.as_u32x4(); 571 | | let a = simd_shuffle2::<_, u32x2>(a, a, [0, 1]); 572 | | transmute(simd_cast::<_, i64x2>(a)) 573 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:589:1 | 589 | / pub unsafe fn _mm_dp_pd(a: __m128d, b: __m128d, imm8: i32) -> __m128d { 590 | | macro_rules! call { 591 | | ($imm8:expr) => { 592 | | dppd(a, b, $imm8) ... | 595 | | constify_imm8!(imm8, call) 596 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:612:1 | 612 | / pub unsafe fn _mm_dp_ps(a: __m128, b: __m128, imm8: i32) -> __m128 { 613 | | macro_rules! call { 614 | | ($imm8:expr) => { 615 | | dpps(a, b, $imm8) ... | 618 | | constify_imm8!(imm8, call) 619 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:630:1 | 630 | / pub unsafe fn _mm_floor_pd(a: __m128d) -> __m128d { 631 | | simd_floor(a) 632 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:643:1 | 643 | / pub unsafe fn _mm_floor_ps(a: __m128) -> __m128 { 644 | | simd_floor(a) 645 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:658:1 | 658 | / pub unsafe fn _mm_floor_sd(a: __m128d, b: __m128d) -> __m128d { 659 | | roundsd(a, b, _MM_FROUND_FLOOR) 660 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:673:1 | 673 | / pub unsafe fn _mm_floor_ss(a: __m128, b: __m128) -> __m128 { 674 | | roundss(a, b, _MM_FROUND_FLOOR) 675 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:686:1 | 686 | / pub unsafe fn _mm_ceil_pd(a: __m128d) -> __m128d { 687 | | simd_ceil(a) 688 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:699:1 | 699 | / pub unsafe fn _mm_ceil_ps(a: __m128) -> __m128 { 700 | | simd_ceil(a) 701 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:714:1 | 714 | / pub unsafe fn _mm_ceil_sd(a: __m128d, b: __m128d) -> __m128d { 715 | | roundsd(a, b, _MM_FROUND_CEIL) 716 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:729:1 | 729 | / pub unsafe fn _mm_ceil_ss(a: __m128, b: __m128) -> __m128 { 730 | | roundss(a, b, _MM_FROUND_CEIL) 731 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:769:1 | 769 | / pub unsafe fn _mm_round_pd(a: __m128d, rounding: i32) -> __m128d { 770 | | macro_rules! call { 771 | | ($imm4:expr) => { 772 | | roundpd(a, $imm4) ... | 775 | | constify_imm4!(rounding, call) 776 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:814:1 | 814 | / pub unsafe fn _mm_round_ps(a: __m128, rounding: i32) -> __m128 { 815 | | macro_rules! call { 816 | | ($imm4:expr) => { 817 | | roundps(a, $imm4) ... | 820 | | constify_imm4!(rounding, call) 821 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:861:1 | 861 | / pub unsafe fn _mm_round_sd(a: __m128d, b: __m128d, rounding: i32) -> __m128d { 862 | | macro_rules! call { 863 | | ($imm4:expr) => { 864 | | roundsd(a, b, $imm4) ... | 867 | | constify_imm4!(rounding, call) 868 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:908:1 | 908 | / pub unsafe fn _mm_round_ss(a: __m128, b: __m128, rounding: i32) -> __m128 { 909 | | macro_rules! call { 910 | | ($imm4:expr) => { 911 | | roundss(a, b, $imm4) ... | 914 | | constify_imm4!(rounding, call) 915 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:942:1 | 942 | / pub unsafe fn _mm_minpos_epu16(a: __m128i) -> __m128i { 943 | | transmute(phminposuw(a.as_u16x8())) 944 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:954:1 | 954 | / pub unsafe fn _mm_mul_epi32(a: __m128i, b: __m128i) -> __m128i { 955 | | transmute(pmuldq(a.as_i32x4(), b.as_i32x4())) 956 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:970:1 | 970 | / pub unsafe fn _mm_mullo_epi32(a: __m128i, b: __m128i) -> __m128i { 971 | | transmute(simd_mul(a.as_i32x4(), b.as_i32x4())) 972 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1012:1 | 1012 | / pub unsafe fn _mm_mpsadbw_epu8(a: __m128i, b: __m128i, imm8: i32) -> __m128i { 1013 | | let a = a.as_u8x16(); 1014 | | let b = b.as_u8x16(); 1015 | | macro_rules! call { ... | 1020 | | transmute(constify_imm3!(imm8, call)) 1021 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1042:1 | 1042 | / pub unsafe fn _mm_testz_si128(a: __m128i, mask: __m128i) -> i32 { 1043 | | ptestz(a.as_i64x2(), mask.as_i64x2()) 1044 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1065:1 | 1065 | / pub unsafe fn _mm_testc_si128(a: __m128i, mask: __m128i) -> i32 { 1066 | | ptestc(a.as_i64x2(), mask.as_i64x2()) 1067 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1088:1 | 1088 | / pub unsafe fn _mm_testnzc_si128(a: __m128i, mask: __m128i) -> i32 { 1089 | | ptestnzc(a.as_i64x2(), mask.as_i64x2()) 1090 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1111:1 | 1111 | / pub unsafe fn _mm_test_all_zeros(a: __m128i, mask: __m128i) -> i32 { 1112 | | _mm_testz_si128(a, mask) 1113 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1133:1 | 1133 | / pub unsafe fn _mm_test_all_ones(a: __m128i) -> i32 { 1134 | | _mm_testc_si128(a, _mm_cmpeq_epi32(a, a)) 1135 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse41.rs:1156:1 | 1156 | / pub unsafe fn _mm_test_mix_ones_zeros(a: __m128i, mask: __m128i) -> i32 { 1157 | | _mm_testnzc_si128(a, mask) 1158 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:76:1 | 76 | / pub unsafe fn _mm_cmpistrm(a: __m128i, b: __m128i, imm8: i32) -> __m128i { 77 | | let a = a.as_i8x16(); 78 | | let b = b.as_i8x16(); 79 | | macro_rules! call { ... | 84 | | transmute(constify_imm8!(imm8, call)) 85 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:270:1 | 270 | / pub unsafe fn _mm_cmpistri(a: __m128i, b: __m128i, imm8: i32) -> i32 { 271 | | let a = a.as_i8x16(); 272 | | let b = b.as_i8x16(); 273 | | macro_rules! call { ... | 278 | | constify_imm8!(imm8, call) 279 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:291:1 | 291 | / pub unsafe fn _mm_cmpistrz(a: __m128i, b: __m128i, imm8: i32) -> i32 { 292 | | let a = a.as_i8x16(); 293 | | let b = b.as_i8x16(); 294 | | macro_rules! call { ... | 299 | | constify_imm8!(imm8, call) 300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:312:1 | 312 | / pub unsafe fn _mm_cmpistrc(a: __m128i, b: __m128i, imm8: i32) -> i32 { 313 | | let a = a.as_i8x16(); 314 | | let b = b.as_i8x16(); 315 | | macro_rules! call { ... | 320 | | constify_imm8!(imm8, call) 321 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:333:1 | 333 | / pub unsafe fn _mm_cmpistrs(a: __m128i, b: __m128i, imm8: i32) -> i32 { 334 | | let a = a.as_i8x16(); 335 | | let b = b.as_i8x16(); 336 | | macro_rules! call { ... | 341 | | constify_imm8!(imm8, call) 342 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:353:1 | 353 | / pub unsafe fn _mm_cmpistro(a: __m128i, b: __m128i, imm8: i32) -> i32 { 354 | | let a = a.as_i8x16(); 355 | | let b = b.as_i8x16(); 356 | | macro_rules! call { ... | 361 | | constify_imm8!(imm8, call) 362 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:374:1 | 374 | / pub unsafe fn _mm_cmpistra(a: __m128i, b: __m128i, imm8: i32) -> i32 { 375 | | let a = a.as_i8x16(); 376 | | let b = b.as_i8x16(); 377 | | macro_rules! call { ... | 382 | | constify_imm8!(imm8, call) 383 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:394:1 | 394 | / pub unsafe fn _mm_cmpestrm(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> __m128i { 395 | | let a = a.as_i8x16(); 396 | | let b = b.as_i8x16(); 397 | | macro_rules! call { ... | 402 | | transmute(constify_imm8!(imm8, call)) 403 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:489:1 | 489 | / pub unsafe fn _mm_cmpestri(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> i32 { 490 | | let a = a.as_i8x16(); 491 | | let b = b.as_i8x16(); 492 | | macro_rules! call { ... | 497 | | constify_imm8!(imm8, call) 498 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:510:1 | 510 | / pub unsafe fn _mm_cmpestrz(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> i32 { 511 | | let a = a.as_i8x16(); 512 | | let b = b.as_i8x16(); 513 | | macro_rules! call { ... | 518 | | constify_imm8!(imm8, call) 519 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:531:1 | 531 | / pub unsafe fn _mm_cmpestrc(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> i32 { 532 | | let a = a.as_i8x16(); 533 | | let b = b.as_i8x16(); 534 | | macro_rules! call { ... | 539 | | constify_imm8!(imm8, call) 540 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:552:1 | 552 | / pub unsafe fn _mm_cmpestrs(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> i32 { 553 | | let a = a.as_i8x16(); 554 | | let b = b.as_i8x16(); 555 | | macro_rules! call { ... | 560 | | constify_imm8!(imm8, call) 561 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:573:1 | 573 | / pub unsafe fn _mm_cmpestro(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> i32 { 574 | | let a = a.as_i8x16(); 575 | | let b = b.as_i8x16(); 576 | | macro_rules! call { ... | 581 | | constify_imm8!(imm8, call) 582 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:595:1 | 595 | / pub unsafe fn _mm_cmpestra(a: __m128i, la: i32, b: __m128i, lb: i32, imm8: i32) -> i32 { 596 | | let a = a.as_i8x16(); 597 | | let b = b.as_i8x16(); 598 | | macro_rules! call { ... | 603 | | constify_imm8!(imm8, call) 604 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:614:1 | 614 | / pub unsafe fn _mm_crc32_u8(crc: u32, v: u8) -> u32 { 615 | | crc32_32_8(crc, v) 616 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:626:1 | 626 | / pub unsafe fn _mm_crc32_u16(crc: u32, v: u16) -> u32 { 627 | | crc32_32_16(crc, v) 628 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:638:1 | 638 | / pub unsafe fn _mm_crc32_u32(crc: u32, v: u32) -> u32 { 639 | | crc32_32_32(crc, v) 640 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse42.rs:650:1 | 650 | / pub unsafe fn _mm_cmpgt_epi64(a: __m128i, b: __m128i) -> __m128i { 651 | | transmute(simd_gt::<_, i64x2>(a.as_i64x2(), b.as_i64x2())) 652 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:34:1 | 34 | / pub unsafe fn _mm256_add_pd(a: __m256d, b: __m256d) -> __m256d { 35 | | simd_add(a, b) 36 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:46:1 | 46 | / pub unsafe fn _mm256_add_ps(a: __m256, b: __m256) -> __m256 { 47 | | simd_add(a, b) 48 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:60:1 | 60 | / pub unsafe fn _mm256_and_pd(a: __m256d, b: __m256d) -> __m256d { 61 | | let a: u64x4 = transmute(a); 62 | | let b: u64x4 = transmute(b); 63 | | transmute(simd_and(a, b)) 64 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:74:1 | 74 | / pub unsafe fn _mm256_and_ps(a: __m256, b: __m256) -> __m256 { 75 | | let a: u32x8 = transmute(a); 76 | | let b: u32x8 = transmute(b); 77 | | transmute(simd_and(a, b)) 78 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:90:1 | 90 | / pub unsafe fn _mm256_or_pd(a: __m256d, b: __m256d) -> __m256d { 91 | | let a: u64x4 = transmute(a); 92 | | let b: u64x4 = transmute(b); 93 | | transmute(simd_or(a, b)) 94 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:104:1 | 104 | / pub unsafe fn _mm256_or_ps(a: __m256, b: __m256) -> __m256 { 105 | | let a: u32x8 = transmute(a); 106 | | let b: u32x8 = transmute(b); 107 | | transmute(simd_or(a, b)) 108 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:119:1 | 119 | / pub unsafe fn _mm256_shuffle_pd(a: __m256d, b: __m256d, imm8: i32) -> __m256d { 120 | | let imm8 = (imm8 & 0xFF) as u8; 121 | | macro_rules! shuffle4 { 122 | | ($a:expr, $b:expr, $c:expr, $d:expr) => { ... | 153 | | } 154 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:165:1 | 165 | / pub unsafe fn _mm256_shuffle_ps(a: __m256, b: __m256, imm8: i32) -> __m256 { 166 | | let imm8 = (imm8 & 0xFF) as u8; 167 | | macro_rules! shuffle4 { 168 | | ( ... | 216 | | } 217 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:228:1 | 228 | / pub unsafe fn _mm256_andnot_pd(a: __m256d, b: __m256d) -> __m256d { 229 | | let a: u64x4 = transmute(a); 230 | | let b: u64x4 = transmute(b); 231 | | transmute(simd_and(simd_xor(u64x4::splat(!(0_u64)), a), b)) 232 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:243:1 | 243 | / pub unsafe fn _mm256_andnot_ps(a: __m256, b: __m256) -> __m256 { 244 | | let a: u32x8 = transmute(a); 245 | | let b: u32x8 = transmute(b); 246 | | transmute(simd_and(simd_xor(u32x8::splat(!(0_u32)), a), b)) 247 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:257:1 | 257 | / pub unsafe fn _mm256_max_pd(a: __m256d, b: __m256d) -> __m256d { 258 | | simd_fmax(a, b) 259 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:269:1 | 269 | / pub unsafe fn _mm256_max_ps(a: __m256, b: __m256) -> __m256 { 270 | | simd_fmax(a, b) 271 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:281:1 | 281 | / pub unsafe fn _mm256_min_pd(a: __m256d, b: __m256d) -> __m256d { 282 | | simd_fmin(a, b) 283 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:293:1 | 293 | / pub unsafe fn _mm256_min_ps(a: __m256, b: __m256) -> __m256 { 294 | | simd_fmin(a, b) 295 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:305:1 | 305 | / pub unsafe fn _mm256_mul_pd(a: __m256d, b: __m256d) -> __m256d { 306 | | simd_mul(a, b) 307 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:317:1 | 317 | / pub unsafe fn _mm256_mul_ps(a: __m256, b: __m256) -> __m256 { 318 | | simd_mul(a, b) 319 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:329:1 | 329 | / pub unsafe fn _mm256_addsub_pd(a: __m256d, b: __m256d) -> __m256d { 330 | | addsubpd256(a, b) 331 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:341:1 | 341 | / pub unsafe fn _mm256_addsub_ps(a: __m256, b: __m256) -> __m256 { 342 | | addsubps256(a, b) 343 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:353:1 | 353 | / pub unsafe fn _mm256_sub_pd(a: __m256d, b: __m256d) -> __m256d { 354 | | simd_sub(a, b) 355 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:365:1 | 365 | / pub unsafe fn _mm256_sub_ps(a: __m256, b: __m256) -> __m256 { 366 | | simd_sub(a, b) 367 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:377:1 | 377 | / pub unsafe fn _mm256_div_ps(a: __m256, b: __m256) -> __m256 { 378 | | simd_div(a, b) 379 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:389:1 | 389 | / pub unsafe fn _mm256_div_pd(a: __m256d, b: __m256d) -> __m256d { 390 | | simd_div(a, b) 391 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:411:1 | 411 | / pub unsafe fn _mm256_round_pd(a: __m256d, b: i32) -> __m256d { 412 | | macro_rules! call { 413 | | ($imm8:expr) => { 414 | | roundpd256(a, $imm8) ... | 417 | | constify_imm8!(b, call) 418 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:428:1 | 428 | / pub unsafe fn _mm256_ceil_pd(a: __m256d) -> __m256d { 429 | | simd_ceil(a) 430 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:440:1 | 440 | / pub unsafe fn _mm256_floor_pd(a: __m256d) -> __m256d { 441 | | simd_floor(a) 442 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:462:1 | 462 | / pub unsafe fn _mm256_round_ps(a: __m256, b: i32) -> __m256 { 463 | | macro_rules! call { 464 | | ($imm8:expr) => { 465 | | roundps256(a, $imm8) ... | 468 | | constify_imm8!(b, call) 469 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:479:1 | 479 | / pub unsafe fn _mm256_ceil_ps(a: __m256) -> __m256 { 480 | | simd_ceil(a) 481 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:491:1 | 491 | / pub unsafe fn _mm256_floor_ps(a: __m256) -> __m256 { 492 | | simd_floor(a) 493 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:503:1 | 503 | / pub unsafe fn _mm256_sqrt_ps(a: __m256) -> __m256 { 504 | | sqrtps256(a) 505 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:515:1 | 515 | / pub unsafe fn _mm256_sqrt_pd(a: __m256d) -> __m256d { 516 | | simd_fsqrt(a) 517 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:531:1 | 531 | / pub unsafe fn _mm256_blend_pd(a: __m256d, b: __m256d, imm8: i32) -> __m256d { 532 | | let imm8 = (imm8 & 0xFF) as u8; 533 | | macro_rules! blend4 { 534 | | ($a:expr, $b:expr, $c:expr, $d:expr) => { ... | 565 | | } 566 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:577:1 | 577 | / pub unsafe fn _mm256_blend_ps(a: __m256, b: __m256, imm8: i32) -> __m256 { 578 | | let imm8 = (imm8 & 0xFF) as u8; 579 | | macro_rules! blend4 { 580 | | ( ... | 628 | | } 629 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:639:1 | 639 | / pub unsafe fn _mm256_blendv_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 640 | | vblendvpd(a, b, c) 641 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:651:1 | 651 | / pub unsafe fn _mm256_blendv_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 652 | | vblendvps(a, b, c) 653 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:666:1 | 666 | / pub unsafe fn _mm256_dp_ps(a: __m256, b: __m256, imm8: i32) -> __m256 { 667 | | macro_rules! call { 668 | | ($imm8:expr) => { 669 | | vdpps(a, b, $imm8) ... | 672 | | constify_imm8!(imm8, call) 673 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:685:1 | 685 | / pub unsafe fn _mm256_hadd_pd(a: __m256d, b: __m256d) -> __m256d { 686 | | vhaddpd(a, b) 687 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:700:1 | 700 | / pub unsafe fn _mm256_hadd_ps(a: __m256, b: __m256) -> __m256 { 701 | | vhaddps(a, b) 702 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:714:1 | 714 | / pub unsafe fn _mm256_hsub_pd(a: __m256d, b: __m256d) -> __m256d { 715 | | vhsubpd(a, b) 716 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:729:1 | 729 | / pub unsafe fn _mm256_hsub_ps(a: __m256, b: __m256) -> __m256 { 730 | | vhsubps(a, b) 731 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:742:1 | 742 | / pub unsafe fn _mm256_xor_pd(a: __m256d, b: __m256d) -> __m256d { 743 | | let a: u64x4 = transmute(a); 744 | | let b: u64x4 = transmute(b); 745 | | transmute(simd_xor(a, b)) 746 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:756:1 | 756 | / pub unsafe fn _mm256_xor_ps(a: __m256, b: __m256) -> __m256 { 757 | | let a: u32x8 = transmute(a); 758 | | let b: u32x8 = transmute(b); 759 | | transmute(simd_xor(a, b)) 760 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:869:1 | 869 | / pub unsafe fn _mm_cmp_pd(a: __m128d, b: __m128d, imm8: i32) -> __m128d { 870 | | macro_rules! call { 871 | | ($imm8:expr) => { 872 | | vcmppd(a, b, $imm8) ... | 875 | | constify_imm6!(imm8, call) 876 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:888:1 | 888 | / pub unsafe fn _mm256_cmp_pd(a: __m256d, b: __m256d, imm8: i32) -> __m256d { 889 | | macro_rules! call { 890 | | ($imm8:expr) => { 891 | | vcmppd256(a, b, $imm8) ... | 894 | | constify_imm6!(imm8, call) 895 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:907:1 | 907 | / pub unsafe fn _mm_cmp_ps(a: __m128, b: __m128, imm8: i32) -> __m128 { 908 | | macro_rules! call { 909 | | ($imm8:expr) => { 910 | | vcmpps(a, b, $imm8) ... | 913 | | constify_imm6!(imm8, call) 914 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:926:1 | 926 | / pub unsafe fn _mm256_cmp_ps(a: __m256, b: __m256, imm8: i32) -> __m256 { 927 | | macro_rules! call { 928 | | ($imm8:expr) => { 929 | | vcmpps256(a, b, $imm8) ... | 932 | | constify_imm6!(imm8, call) 933 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:947:1 | 947 | / pub unsafe fn _mm_cmp_sd(a: __m128d, b: __m128d, imm8: i32) -> __m128d { 948 | | macro_rules! call { 949 | | ($imm8:expr) => { 950 | | vcmpsd(a, b, $imm8) ... | 953 | | constify_imm6!(imm8, call) 954 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:968:1 | 968 | / pub unsafe fn _mm_cmp_ss(a: __m128, b: __m128, imm8: i32) -> __m128 { 969 | | macro_rules! call { 970 | | ($imm8:expr) => { 971 | | vcmpss(a, b, $imm8) ... | 974 | | constify_imm6!(imm8, call) 975 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:985:1 | 985 | / pub unsafe fn _mm256_cvtepi32_pd(a: __m128i) -> __m256d { 986 | | simd_cast(a.as_i32x4()) 987 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:997:1 | 997 | / pub unsafe fn _mm256_cvtepi32_ps(a: __m256i) -> __m256 { 998 | | vcvtdq2ps(a.as_i32x8()) 999 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1009:1 | 1009 | / pub unsafe fn _mm256_cvtpd_ps(a: __m256d) -> __m128 { 1010 | | vcvtpd2ps(a) 1011 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1021:1 | 1021 | / pub unsafe fn _mm256_cvtps_epi32(a: __m256) -> __m256i { 1022 | | transmute(vcvtps2dq(a)) 1023 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1033:1 | 1033 | / pub unsafe fn _mm256_cvtps_pd(a: __m128) -> __m256d { 1034 | | simd_cast(a) 1035 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1045:1 | 1045 | / pub unsafe fn _mm256_cvttpd_epi32(a: __m256d) -> __m128i { 1046 | | transmute(vcvttpd2dq(a)) 1047 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1057:1 | 1057 | / pub unsafe fn _mm256_cvtpd_epi32(a: __m256d) -> __m128i { 1058 | | transmute(vcvtpd2dq(a)) 1059 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1069:1 | 1069 | / pub unsafe fn _mm256_cvttps_epi32(a: __m256) -> __m256i { 1070 | | transmute(vcvttps2dq(a)) 1071 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1085:1 | 1085 | / pub unsafe fn _mm256_extractf128_ps(a: __m256, imm8: i32) -> __m128 { 1086 | | match imm8 & 1 { 1087 | | 0 => simd_shuffle4(a, _mm256_undefined_ps(), [0, 1, 2, 3]), 1088 | | _ => simd_shuffle4(a, _mm256_undefined_ps(), [4, 5, 6, 7]), 1089 | | } 1090 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1104:1 | 1104 | / pub unsafe fn _mm256_extractf128_pd(a: __m256d, imm8: i32) -> __m128d { 1105 | | match imm8 & 1 { 1106 | | 0 => simd_shuffle2(a, _mm256_undefined_pd(), [0, 1]), 1107 | | _ => simd_shuffle2(a, _mm256_undefined_pd(), [2, 3]), 1108 | | } 1109 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1122:1 | 1122 | / pub unsafe fn _mm256_extractf128_si256(a: __m256i, imm8: i32) -> __m128i { 1123 | | let b = _mm256_undefined_si256().as_i64x4(); 1124 | | let dst: i64x2 = match imm8 & 1 { 1125 | | 0 => simd_shuffle2(a.as_i64x4(), b, [0, 1]), ... | 1128 | | transmute(dst) 1129 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1138:1 | 1138 | / pub unsafe fn _mm256_zeroall() { 1139 | | vzeroall() 1140 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1150:1 | 1150 | / pub unsafe fn _mm256_zeroupper() { 1151 | | vzeroupper() 1152 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1162:1 | 1162 | / pub unsafe fn _mm256_permutevar_ps(a: __m256, b: __m256i) -> __m256 { 1163 | | vpermilps256(a, b.as_i32x8()) 1164 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1174:1 | 1174 | / pub unsafe fn _mm_permutevar_ps(a: __m128, b: __m128i) -> __m128 { 1175 | | vpermilps(a, b.as_i32x4()) 1176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1187:1 | 1187 | / pub unsafe fn _mm256_permute_ps(a: __m256, imm8: i32) -> __m256 { 1188 | | let imm8 = (imm8 & 0xFF) as u8; 1189 | | macro_rules! shuffle4 { 1190 | | ($a:expr, $b:expr, $c:expr, $d:expr) => { ... | 1233 | | } 1234 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1245:1 | 1245 | / pub unsafe fn _mm_permute_ps(a: __m128, imm8: i32) -> __m128 { 1246 | | let imm8 = (imm8 & 0xFF) as u8; 1247 | | macro_rules! shuffle4 { 1248 | | ($a:expr, $b:expr, $c:expr, $d:expr) => { ... | 1287 | | } 1288 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1298:1 | 1298 | / pub unsafe fn _mm256_permutevar_pd(a: __m256d, b: __m256i) -> __m256d { 1299 | | vpermilpd256(a, b.as_i64x4()) 1300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1310:1 | 1310 | / pub unsafe fn _mm_permutevar_pd(a: __m128d, b: __m128i) -> __m128d { 1311 | | vpermilpd(a, b.as_i64x2()) 1312 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1323:1 | 1323 | / pub unsafe fn _mm256_permute_pd(a: __m256d, imm8: i32) -> __m256d { 1324 | | let imm8 = (imm8 & 0xFF) as u8; 1325 | | macro_rules! shuffle4 { 1326 | | ($a:expr, $b:expr, $c:expr, $d:expr) => { ... | 1357 | | } 1358 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1369:1 | 1369 | / pub unsafe fn _mm_permute_pd(a: __m128d, imm8: i32) -> __m128d { 1370 | | let imm8 = (imm8 & 0xFF) as u8; 1371 | | macro_rules! shuffle2 { 1372 | | ($a:expr, $b:expr) => { ... | 1387 | | } 1388 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1399:1 | 1399 | / pub unsafe fn _mm256_permute2f128_ps(a: __m256, b: __m256, imm8: i32) -> __m256 { 1400 | | macro_rules! call { 1401 | | ($imm8:expr) => { 1402 | | vperm2f128ps256(a, b, $imm8) ... | 1405 | | constify_imm8!(imm8, call) 1406 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1417:1 | 1417 | / pub unsafe fn _mm256_permute2f128_pd(a: __m256d, b: __m256d, imm8: i32) -> __m256d { 1418 | | macro_rules! call { 1419 | | ($imm8:expr) => { 1420 | | vperm2f128pd256(a, b, $imm8) ... | 1423 | | constify_imm8!(imm8, call) 1424 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1435:1 | 1435 | / pub unsafe fn _mm256_permute2f128_si256(a: __m256i, b: __m256i, imm8: i32) -> __m256i { 1436 | | let a = a.as_i32x8(); 1437 | | let b = b.as_i32x8(); 1438 | | macro_rules! call { ... | 1444 | | transmute(r) 1445 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1456:1 | 1456 | / pub unsafe fn _mm256_broadcast_ss(f: &f32) -> __m256 { 1457 | | _mm256_set1_ps(*f) 1458 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1469:1 | 1469 | / pub unsafe fn _mm_broadcast_ss(f: &f32) -> __m128 { 1470 | | _mm_set1_ps(*f) 1471 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1482:1 | 1482 | / pub unsafe fn _mm256_broadcast_sd(f: &f64) -> __m256d { 1483 | | _mm256_set1_pd(*f) 1484 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1494:1 | 1494 | / pub unsafe fn _mm256_broadcast_ps(a: &__m128) -> __m256 { 1495 | | vbroadcastf128ps256(a) 1496 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1506:1 | 1506 | / pub unsafe fn _mm256_broadcast_pd(a: &__m128d) -> __m256d { 1507 | | vbroadcastf128pd256(a) 1508 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1523:1 | 1523 | / pub unsafe fn _mm256_insertf128_ps(a: __m256, b: __m128, imm8: i32) -> __m256 { 1524 | | let b = _mm256_castps128_ps256(b); 1525 | | match imm8 & 1 { 1526 | | 0 => simd_shuffle8(a, b, [8, 9, 10, 11, 4, 5, 6, 7]), 1527 | | _ => simd_shuffle8(a, b, [0, 1, 2, 3, 8, 9, 10, 11]), 1528 | | } 1529 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1544:1 | 1544 | / pub unsafe fn _mm256_insertf128_pd(a: __m256d, b: __m128d, imm8: i32) -> __m256d { 1545 | | match imm8 & 1 { 1546 | | 0 => simd_shuffle4(a, _mm256_castpd128_pd256(b), [4, 5, 2, 3]), 1547 | | _ => simd_shuffle4(a, _mm256_castpd128_pd256(b), [0, 1, 4, 5]), 1548 | | } 1549 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1563:1 | 1563 | / pub unsafe fn _mm256_insertf128_si256(a: __m256i, b: __m128i, imm8: i32) -> __m256i { 1564 | | let b = _mm256_castsi128_si256(b).as_i64x4(); 1565 | | let dst: i64x4 = match imm8 & 1 { 1566 | | 0 => simd_shuffle4(a.as_i64x4(), b, [4, 5, 2, 3]), ... | 1569 | | transmute(dst) 1570 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1581:1 | 1581 | / pub unsafe fn _mm256_insert_epi8(a: __m256i, i: i8, index: i32) -> __m256i { 1582 | | let a = a.as_i8x32(); 1583 | | macro_rules! call { 1584 | | ($index:expr) => { ... | 1588 | | transmute(constify_imm5!(index, call)) 1589 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1600:1 | 1600 | / pub unsafe fn _mm256_insert_epi16(a: __m256i, i: i16, index: i32) -> __m256i { 1601 | | let a = a.as_i16x16(); 1602 | | macro_rules! call { 1603 | | ($index:expr) => { ... | 1607 | | transmute(constify_imm4!((index & 15), call)) 1608 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1619:1 | 1619 | / pub unsafe fn _mm256_insert_epi32(a: __m256i, i: i32, index: i32) -> __m256i { 1620 | | let a = a.as_i32x8(); 1621 | | macro_rules! call { 1622 | | ($index:expr) => { ... | 1626 | | transmute(constify_imm8!((index & 7), call)) 1627 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1640:1 | 1640 | / pub unsafe fn _mm256_load_pd(mem_addr: *const f64) -> __m256d { 1641 | | *(mem_addr as *const __m256d) 1642 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1655:1 | 1655 | / pub unsafe fn _mm256_store_pd(mem_addr: *mut f64, a: __m256d) { 1656 | | *(mem_addr as *mut __m256d) = a; 1657 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1670:1 | 1670 | / pub unsafe fn _mm256_load_ps(mem_addr: *const f32) -> __m256 { 1671 | | *(mem_addr as *const __m256) 1672 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1685:1 | 1685 | / pub unsafe fn _mm256_store_ps(mem_addr: *mut f32, a: __m256) { 1686 | | *(mem_addr as *mut __m256) = a; 1687 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1698:1 | 1698 | / pub unsafe fn _mm256_loadu_pd(mem_addr: *const f64) -> __m256d { 1699 | | let mut dst = _mm256_undefined_pd(); 1700 | | ptr::copy_nonoverlapping( 1701 | | mem_addr as *const u8, ... | 1705 | | dst 1706 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1717:1 | 1717 | / pub unsafe fn _mm256_storeu_pd(mem_addr: *mut f64, a: __m256d) { 1718 | | storeupd256(mem_addr, a); 1719 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1730:1 | 1730 | / pub unsafe fn _mm256_loadu_ps(mem_addr: *const f32) -> __m256 { 1731 | | let mut dst = _mm256_undefined_ps(); 1732 | | ptr::copy_nonoverlapping( 1733 | | mem_addr as *const u8, ... | 1737 | | dst 1738 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1749:1 | 1749 | / pub unsafe fn _mm256_storeu_ps(mem_addr: *mut f32, a: __m256) { 1750 | | storeups256(mem_addr, a); 1751 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1762:1 | 1762 | / pub unsafe fn _mm256_load_si256(mem_addr: *const __m256i) -> __m256i { 1763 | | *mem_addr 1764 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1775:1 | 1775 | / pub unsafe fn _mm256_store_si256(mem_addr: *mut __m256i, a: __m256i) { 1776 | | *mem_addr = a; 1777 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1787:1 | 1787 | / pub unsafe fn _mm256_loadu_si256(mem_addr: *const __m256i) -> __m256i { 1788 | | let mut dst = _mm256_undefined_si256(); 1789 | | ptr::copy_nonoverlapping( 1790 | | mem_addr as *const u8, ... | 1794 | | dst 1795 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1805:1 | 1805 | / pub unsafe fn _mm256_storeu_si256(mem_addr: *mut __m256i, a: __m256i) { 1806 | | storeudq256(mem_addr as *mut i8, a.as_i8x32()); 1807 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1818:1 | 1818 | / pub unsafe fn _mm256_maskload_pd(mem_addr: *const f64, mask: __m256i) -> __m256d { 1819 | | maskloadpd256(mem_addr as *const i8, mask.as_i64x4()) 1820 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1830:1 | 1830 | / pub unsafe fn _mm256_maskstore_pd(mem_addr: *mut f64, mask: __m256i, a: __m256d) { 1831 | | maskstorepd256(mem_addr as *mut i8, mask.as_i64x4(), a); 1832 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1843:1 | 1843 | / pub unsafe fn _mm_maskload_pd(mem_addr: *const f64, mask: __m128i) -> __m128d { 1844 | | maskloadpd(mem_addr as *const i8, mask.as_i64x2()) 1845 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1855:1 | 1855 | / pub unsafe fn _mm_maskstore_pd(mem_addr: *mut f64, mask: __m128i, a: __m128d) { 1856 | | maskstorepd(mem_addr as *mut i8, mask.as_i64x2(), a); 1857 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1868:1 | 1868 | / pub unsafe fn _mm256_maskload_ps(mem_addr: *const f32, mask: __m256i) -> __m256 { 1869 | | maskloadps256(mem_addr as *const i8, mask.as_i32x8()) 1870 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1880:1 | 1880 | / pub unsafe fn _mm256_maskstore_ps(mem_addr: *mut f32, mask: __m256i, a: __m256) { 1881 | | maskstoreps256(mem_addr as *mut i8, mask.as_i32x8(), a); 1882 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1893:1 | 1893 | / pub unsafe fn _mm_maskload_ps(mem_addr: *const f32, mask: __m128i) -> __m128 { 1894 | | maskloadps(mem_addr as *const i8, mask.as_i32x4()) 1895 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1905:1 | 1905 | / pub unsafe fn _mm_maskstore_ps(mem_addr: *mut f32, mask: __m128i, a: __m128) { 1906 | | maskstoreps(mem_addr as *mut i8, mask.as_i32x4(), a); 1907 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1917:1 | 1917 | / pub unsafe fn _mm256_movehdup_ps(a: __m256) -> __m256 { 1918 | | simd_shuffle8(a, a, [1, 1, 3, 3, 5, 5, 7, 7]) 1919 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1929:1 | 1929 | / pub unsafe fn _mm256_moveldup_ps(a: __m256) -> __m256 { 1930 | | simd_shuffle8(a, a, [0, 0, 2, 2, 4, 4, 6, 6]) 1931 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1941:1 | 1941 | / pub unsafe fn _mm256_movedup_pd(a: __m256d) -> __m256d { 1942 | | simd_shuffle4(a, a, [0, 0, 2, 2]) 1943 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1954:1 | 1954 | / pub unsafe fn _mm256_lddqu_si256(mem_addr: *const __m256i) -> __m256i { 1955 | | transmute(vlddqu(mem_addr as *const i8)) 1956 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1967:1 | 1967 | / pub unsafe fn _mm256_stream_si256(mem_addr: *mut __m256i, a: __m256i) { 1968 | | intrinsics::nontemporal_store(mem_addr, a); 1969 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1981:1 | 1981 | / pub unsafe fn _mm256_stream_pd(mem_addr: *mut f64, a: __m256d) { 1982 | | intrinsics::nontemporal_store(mem_addr as *mut __m256d, a); 1983 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:1996:1 | 1996 | / pub unsafe fn _mm256_stream_ps(mem_addr: *mut f32, a: __m256) { 1997 | | intrinsics::nontemporal_store(mem_addr as *mut __m256, a); 1998 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2009:1 | 2009 | / pub unsafe fn _mm256_rcp_ps(a: __m256) -> __m256 { 2010 | | vrcpps(a) 2011 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2022:1 | 2022 | / pub unsafe fn _mm256_rsqrt_ps(a: __m256) -> __m256 { 2023 | | vrsqrtps(a) 2024 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2034:1 | 2034 | / pub unsafe fn _mm256_unpackhi_pd(a: __m256d, b: __m256d) -> __m256d { 2035 | | simd_shuffle4(a, b, [1, 5, 3, 7]) 2036 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2046:1 | 2046 | / pub unsafe fn _mm256_unpackhi_ps(a: __m256, b: __m256) -> __m256 { 2047 | | simd_shuffle8(a, b, [2, 10, 3, 11, 6, 14, 7, 15]) 2048 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2058:1 | 2058 | / pub unsafe fn _mm256_unpacklo_pd(a: __m256d, b: __m256d) -> __m256d { 2059 | | simd_shuffle4(a, b, [0, 4, 2, 6]) 2060 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2070:1 | 2070 | / pub unsafe fn _mm256_unpacklo_ps(a: __m256, b: __m256) -> __m256 { 2071 | | simd_shuffle8(a, b, [0, 8, 1, 9, 4, 12, 5, 13]) 2072 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2084:1 | 2084 | / pub unsafe fn _mm256_testz_si256(a: __m256i, b: __m256i) -> i32 { 2085 | | ptestz256(a.as_i64x4(), b.as_i64x4()) 2086 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2098:1 | 2098 | / pub unsafe fn _mm256_testc_si256(a: __m256i, b: __m256i) -> i32 { 2099 | | ptestc256(a.as_i64x4(), b.as_i64x4()) 2100 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2113:1 | 2113 | / pub unsafe fn _mm256_testnzc_si256(a: __m256i, b: __m256i) -> i32 { 2114 | | ptestnzc256(a.as_i64x4(), b.as_i64x4()) 2115 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2130:1 | 2130 | / pub unsafe fn _mm256_testz_pd(a: __m256d, b: __m256d) -> i32 { 2131 | | vtestzpd256(a, b) 2132 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2147:1 | 2147 | / pub unsafe fn _mm256_testc_pd(a: __m256d, b: __m256d) -> i32 { 2148 | | vtestcpd256(a, b) 2149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2165:1 | 2165 | / pub unsafe fn _mm256_testnzc_pd(a: __m256d, b: __m256d) -> i32 { 2166 | | vtestnzcpd256(a, b) 2167 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2182:1 | 2182 | / pub unsafe fn _mm_testz_pd(a: __m128d, b: __m128d) -> i32 { 2183 | | vtestzpd(a, b) 2184 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2199:1 | 2199 | / pub unsafe fn _mm_testc_pd(a: __m128d, b: __m128d) -> i32 { 2200 | | vtestcpd(a, b) 2201 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2217:1 | 2217 | / pub unsafe fn _mm_testnzc_pd(a: __m128d, b: __m128d) -> i32 { 2218 | | vtestnzcpd(a, b) 2219 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2234:1 | 2234 | / pub unsafe fn _mm256_testz_ps(a: __m256, b: __m256) -> i32 { 2235 | | vtestzps256(a, b) 2236 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2251:1 | 2251 | / pub unsafe fn _mm256_testc_ps(a: __m256, b: __m256) -> i32 { 2252 | | vtestcps256(a, b) 2253 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2269:1 | 2269 | / pub unsafe fn _mm256_testnzc_ps(a: __m256, b: __m256) -> i32 { 2270 | | vtestnzcps256(a, b) 2271 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2286:1 | 2286 | / pub unsafe fn _mm_testz_ps(a: __m128, b: __m128) -> i32 { 2287 | | vtestzps(a, b) 2288 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2303:1 | 2303 | / pub unsafe fn _mm_testc_ps(a: __m128, b: __m128) -> i32 { 2304 | | vtestcps(a, b) 2305 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2321:1 | 2321 | / pub unsafe fn _mm_testnzc_ps(a: __m128, b: __m128) -> i32 { 2322 | | vtestnzcps(a, b) 2323 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2334:1 | 2334 | / pub unsafe fn _mm256_movemask_pd(a: __m256d) -> i32 { 2335 | | movmskpd256(a) 2336 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2347:1 | 2347 | / pub unsafe fn _mm256_movemask_ps(a: __m256) -> i32 { 2348 | | movmskps256(a) 2349 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2358:1 | 2358 | / pub unsafe fn _mm256_setzero_pd() -> __m256d { 2359 | | _mm256_set1_pd(0.0) 2360 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2369:1 | 2369 | / pub unsafe fn _mm256_setzero_ps() -> __m256 { 2370 | | _mm256_set1_ps(0.0) 2371 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2380:1 | 2380 | / pub unsafe fn _mm256_setzero_si256() -> __m256i { 2381 | | _mm256_set1_epi8(0) 2382 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2393:1 | 2393 | / pub unsafe fn _mm256_set_pd(a: f64, b: f64, c: f64, d: f64) -> __m256d { 2394 | | _mm256_setr_pd(d, c, b, a) 2395 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2405:1 | 2405 | / pub unsafe fn _mm256_set_ps( 2406 | | a: f32, 2407 | | b: f32, 2408 | | c: f32, ... | 2415 | | _mm256_setr_ps(h, g, f, e, d, c, b, a) 2416 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2405:1 | 2405 | / pub unsafe fn _mm256_set_ps( 2406 | | a: f32, 2407 | | b: f32, 2408 | | c: f32, ... | 2413 | | h: f32, 2414 | | ) -> __m256 { | |___________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2426:1 | 2426 | / pub unsafe fn _mm256_set_epi8( 2427 | | e00: i8, 2428 | | e01: i8, 2429 | | e02: i8, ... | 2466 | | ) 2467 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (32/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2426:1 | 2426 | / pub unsafe fn _mm256_set_epi8( 2427 | | e00: i8, 2428 | | e01: i8, 2429 | | e02: i8, ... | 2458 | | e31: i8, 2459 | | ) -> __m256i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2476:1 | 2476 | / pub unsafe fn _mm256_set_epi16( 2477 | | e00: i16, 2478 | | e01: i16, 2479 | | e02: i16, ... | 2500 | | ) 2501 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2476:1 | 2476 | / pub unsafe fn _mm256_set_epi16( 2477 | | e00: i16, 2478 | | e01: i16, 2479 | | e02: i16, ... | 2492 | | e15: i16, 2493 | | ) -> __m256i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2510:1 | 2510 | / pub unsafe fn _mm256_set_epi32( 2511 | | e0: i32, 2512 | | e1: i32, 2513 | | e2: i32, ... | 2520 | | _mm256_setr_epi32(e7, e6, e5, e4, e3, e2, e1, e0) 2521 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2510:1 | 2510 | / pub unsafe fn _mm256_set_epi32( 2511 | | e0: i32, 2512 | | e1: i32, 2513 | | e2: i32, ... | 2518 | | e7: i32, 2519 | | ) -> __m256i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2530:1 | 2530 | / pub unsafe fn _mm256_set_epi64x(a: i64, b: i64, c: i64, d: i64) -> __m256i { 2531 | | _mm256_setr_epi64x(d, c, b, a) 2532 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2542:1 | 2542 | / pub unsafe fn _mm256_setr_pd(a: f64, b: f64, c: f64, d: f64) -> __m256d { 2543 | | __m256d(a, b, c, d) 2544 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2554:1 | 2554 | / pub unsafe fn _mm256_setr_ps( 2555 | | a: f32, 2556 | | b: f32, 2557 | | c: f32, ... | 2564 | | __m256(a, b, c, d, e, f, g, h) 2565 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2554:1 | 2554 | / pub unsafe fn _mm256_setr_ps( 2555 | | a: f32, 2556 | | b: f32, 2557 | | c: f32, ... | 2562 | | h: f32, 2563 | | ) -> __m256 { | |___________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2575:1 | 2575 | / pub unsafe fn _mm256_setr_epi8( 2576 | | e00: i8, 2577 | | e01: i8, 2578 | | e02: i8, ... | 2615 | | )) 2616 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (32/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2575:1 | 2575 | / pub unsafe fn _mm256_setr_epi8( 2576 | | e00: i8, 2577 | | e01: i8, 2578 | | e02: i8, ... | 2607 | | e31: i8, 2608 | | ) -> __m256i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2626:1 | 2626 | / pub unsafe fn _mm256_setr_epi16( 2627 | | e00: i16, 2628 | | e01: i16, 2629 | | e02: i16, ... | 2650 | | )) 2651 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2626:1 | 2626 | / pub unsafe fn _mm256_setr_epi16( 2627 | | e00: i16, 2628 | | e01: i16, 2629 | | e02: i16, ... | 2642 | | e15: i16, 2643 | | ) -> __m256i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2661:1 | 2661 | / pub unsafe fn _mm256_setr_epi32( 2662 | | e0: i32, 2663 | | e1: i32, 2664 | | e2: i32, ... | 2671 | | transmute(i32x8::new(e0, e1, e2, e3, e4, e5, e6, e7)) 2672 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2661:1 | 2661 | / pub unsafe fn _mm256_setr_epi32( 2662 | | e0: i32, 2663 | | e1: i32, 2664 | | e2: i32, ... | 2669 | | e7: i32, 2670 | | ) -> __m256i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2682:1 | 2682 | / pub unsafe fn _mm256_setr_epi64x(a: i64, b: i64, c: i64, d: i64) -> __m256i { 2683 | | transmute(i64x4::new(a, b, c, d)) 2684 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2694:1 | 2694 | / pub unsafe fn _mm256_set1_pd(a: f64) -> __m256d { 2695 | | _mm256_setr_pd(a, a, a, a) 2696 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2706:1 | 2706 | / pub unsafe fn _mm256_set1_ps(a: f32) -> __m256 { 2707 | | _mm256_setr_ps(a, a, a, a, a, a, a, a) 2708 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2720:1 | 2720 | / pub unsafe fn _mm256_set1_epi8(a: i8) -> __m256i { 2721 | | #[rustfmt::skip] 2722 | | _mm256_setr_epi8( 2723 | | a, a, a, a, a, a, a, a, ... | 2727 | | ) 2728 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2740:1 | 2740 | / pub unsafe fn _mm256_set1_epi16(a: i16) -> __m256i { 2741 | | _mm256_setr_epi16(a, a, a, a, a, a, a, a, a, a, a, a, a, a, a, a) 2742 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2752:1 | 2752 | / pub unsafe fn _mm256_set1_epi32(a: i32) -> __m256i { 2753 | | _mm256_setr_epi32(a, a, a, a, a, a, a, a) 2754 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2766:1 | 2766 | / pub unsafe fn _mm256_set1_epi64x(a: i64) -> __m256i { 2767 | | _mm256_setr_epi64x(a, a, a, a) 2768 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2778:1 | 2778 | / pub unsafe fn _mm256_castpd_ps(a: __m256d) -> __m256 { 2779 | | transmute(a) 2780 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2790:1 | 2790 | / pub unsafe fn _mm256_castps_pd(a: __m256) -> __m256d { 2791 | | transmute(a) 2792 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2802:1 | 2802 | / pub unsafe fn _mm256_castps_si256(a: __m256) -> __m256i { 2803 | | transmute(a) 2804 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2814:1 | 2814 | / pub unsafe fn _mm256_castsi256_ps(a: __m256i) -> __m256 { 2815 | | transmute(a) 2816 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2826:1 | 2826 | / pub unsafe fn _mm256_castpd_si256(a: __m256d) -> __m256i { 2827 | | transmute(a) 2828 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2838:1 | 2838 | / pub unsafe fn _mm256_castsi256_pd(a: __m256i) -> __m256d { 2839 | | transmute(a) 2840 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2850:1 | 2850 | / pub unsafe fn _mm256_castps256_ps128(a: __m256) -> __m128 { 2851 | | simd_shuffle4(a, a, [0, 1, 2, 3]) 2852 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2862:1 | 2862 | / pub unsafe fn _mm256_castpd256_pd128(a: __m256d) -> __m128d { 2863 | | simd_shuffle2(a, a, [0, 1]) 2864 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2874:1 | 2874 | / pub unsafe fn _mm256_castsi256_si128(a: __m256i) -> __m128i { 2875 | | let a = a.as_i64x4(); 2876 | | let dst: i64x2 = simd_shuffle2(a, a, [0, 1]); 2877 | | transmute(dst) 2878 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2889:1 | 2889 | / pub unsafe fn _mm256_castps128_ps256(a: __m128) -> __m256 { 2890 | | // FIXME simd_shuffle8(a, a, [0, 1, 2, 3, -1, -1, -1, -1]) 2891 | | simd_shuffle8(a, a, [0, 1, 2, 3, 0, 0, 0, 0]) 2892 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2903:1 | 2903 | / pub unsafe fn _mm256_castpd128_pd256(a: __m128d) -> __m256d { 2904 | | // FIXME simd_shuffle4(a, a, [0, 1, -1, -1]) 2905 | | simd_shuffle4(a, a, [0, 1, 0, 0]) 2906 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2917:1 | 2917 | / pub unsafe fn _mm256_castsi128_si256(a: __m128i) -> __m256i { 2918 | | let a = a.as_i64x2(); 2919 | | // FIXME simd_shuffle4(a, a, [0, 1, -1, -1]) 2920 | | let dst: i64x4 = simd_shuffle4(a, a, [0, 1, 0, 0]); 2921 | | transmute(dst) 2922 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2934:1 | 2934 | / pub unsafe fn _mm256_zextps128_ps256(a: __m128) -> __m256 { 2935 | | simd_shuffle8(a, _mm_setzero_ps(), [0, 1, 2, 3, 4, 5, 6, 7]) 2936 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2948:1 | 2948 | / pub unsafe fn _mm256_zextsi128_si256(a: __m128i) -> __m256i { 2949 | | let b = _mm_setzero_si128().as_i64x2(); 2950 | | let dst: i64x4 = simd_shuffle4(a.as_i64x2(), b, [0, 1, 2, 3]); 2951 | | transmute(dst) 2952 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2965:1 | 2965 | / pub unsafe fn _mm256_zextpd128_pd256(a: __m128d) -> __m256d { 2966 | | simd_shuffle4(a, _mm_setzero_pd(), [0, 1, 2, 3]) 2967 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2976:1 | 2976 | / pub unsafe fn _mm256_undefined_ps() -> __m256 { 2977 | | _mm256_set1_ps(0.0) 2978 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2987:1 | 2987 | / pub unsafe fn _mm256_undefined_pd() -> __m256d { 2988 | | _mm256_set1_pd(0.0) 2989 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:2998:1 | 2998 | / pub unsafe fn _mm256_undefined_si256() -> __m256i { 2999 | | // FIXME: this function should return MaybeUninit<__m256i> 3000 | | mem::MaybeUninit::<__m256i>::uninit().assume_init() 3001 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3010:1 | 3010 | / pub unsafe fn _mm256_set_m128(hi: __m128, lo: __m128) -> __m256 { 3011 | | simd_shuffle8(lo, hi, [0, 1, 2, 3, 4, 5, 6, 7]) 3012 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3021:1 | 3021 | / pub unsafe fn _mm256_set_m128d(hi: __m128d, lo: __m128d) -> __m256d { 3022 | | let hi: __m128 = transmute(hi); 3023 | | let lo: __m128 = transmute(lo); 3024 | | transmute(_mm256_set_m128(hi, lo)) 3025 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3034:1 | 3034 | / pub unsafe fn _mm256_set_m128i(hi: __m128i, lo: __m128i) -> __m256i { 3035 | | let hi: __m128 = transmute(hi); 3036 | | let lo: __m128 = transmute(lo); 3037 | | transmute(_mm256_set_m128(hi, lo)) 3038 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3047:1 | 3047 | / pub unsafe fn _mm256_setr_m128(lo: __m128, hi: __m128) -> __m256 { 3048 | | _mm256_set_m128(hi, lo) 3049 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3058:1 | 3058 | / pub unsafe fn _mm256_setr_m128d(lo: __m128d, hi: __m128d) -> __m256d { 3059 | | _mm256_set_m128d(hi, lo) 3060 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3069:1 | 3069 | / pub unsafe fn _mm256_setr_m128i(lo: __m128i, hi: __m128i) -> __m256i { 3070 | | _mm256_set_m128i(hi, lo) 3071 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3083:1 | 3083 | / pub unsafe fn _mm256_loadu2_m128(hiaddr: *const f32, loaddr: *const f32) -> __m256 { 3084 | | let a = _mm256_castps128_ps256(_mm_loadu_ps(loaddr)); 3085 | | _mm256_insertf128_ps(a, _mm_loadu_ps(hiaddr), 1) 3086 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3098:1 | 3098 | / pub unsafe fn _mm256_loadu2_m128d(hiaddr: *const f64, loaddr: *const f64) -> __m256d { 3099 | | let a = _mm256_castpd128_pd256(_mm_loadu_pd(loaddr)); 3100 | | _mm256_insertf128_pd(a, _mm_loadu_pd(hiaddr), 1) 3101 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3112:1 | 3112 | / pub unsafe fn _mm256_loadu2_m128i(hiaddr: *const __m128i, loaddr: *const __m128i) -> __m256i { 3113 | | let a = _mm256_castsi128_si256(_mm_loadu_si128(loaddr)); 3114 | | _mm256_insertf128_si256(a, _mm_loadu_si128(hiaddr), 1) 3115 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3127:1 | 3127 | / pub unsafe fn _mm256_storeu2_m128(hiaddr: *mut f32, loaddr: *mut f32, a: __m256) { 3128 | | let lo = _mm256_castps256_ps128(a); 3129 | | _mm_storeu_ps(loaddr, lo); 3130 | | let hi = _mm256_extractf128_ps(a, 1); 3131 | | _mm_storeu_ps(hiaddr, hi); 3132 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3144:1 | 3144 | / pub unsafe fn _mm256_storeu2_m128d(hiaddr: *mut f64, loaddr: *mut f64, a: __m256d) { 3145 | | let lo = _mm256_castpd256_pd128(a); 3146 | | _mm_storeu_pd(loaddr, lo); 3147 | | let hi = _mm256_extractf128_pd(a, 1); 3148 | | _mm_storeu_pd(hiaddr, hi); 3149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3160:1 | 3160 | / pub unsafe fn _mm256_storeu2_m128i(hiaddr: *mut __m128i, loaddr: *mut __m128i, a: __m256i) { 3161 | | let lo = _mm256_castsi256_si128(a); 3162 | | _mm_storeu_si128(loaddr, lo); 3163 | | let hi = _mm256_extractf128_si256(a, 1); 3164 | | _mm_storeu_si128(hiaddr, hi); 3165 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx.rs:3174:1 | 3174 | / pub unsafe fn _mm256_cvtss_f32(a: __m256) -> f32 { 3175 | | simd_extract(a, 0) 3176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:36:1 | 36 | / pub unsafe fn _mm256_abs_epi32(a: __m256i) -> __m256i { 37 | | transmute(pabsd(a.as_i32x8())) 38 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:47:1 | 47 | / pub unsafe fn _mm256_abs_epi16(a: __m256i) -> __m256i { 48 | | transmute(pabsw(a.as_i16x16())) 49 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:58:1 | 58 | / pub unsafe fn _mm256_abs_epi8(a: __m256i) -> __m256i { 59 | | transmute(pabsb(a.as_i8x32())) 60 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:69:1 | 69 | / pub unsafe fn _mm256_add_epi64(a: __m256i, b: __m256i) -> __m256i { 70 | | transmute(simd_add(a.as_i64x4(), b.as_i64x4())) 71 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:80:1 | 80 | / pub unsafe fn _mm256_add_epi32(a: __m256i, b: __m256i) -> __m256i { 81 | | transmute(simd_add(a.as_i32x8(), b.as_i32x8())) 82 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:91:1 | 91 | / pub unsafe fn _mm256_add_epi16(a: __m256i, b: __m256i) -> __m256i { 92 | | transmute(simd_add(a.as_i16x16(), b.as_i16x16())) 93 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:102:1 | 102 | / pub unsafe fn _mm256_add_epi8(a: __m256i, b: __m256i) -> __m256i { 103 | | transmute(simd_add(a.as_i8x32(), b.as_i8x32())) 104 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:113:1 | 113 | / pub unsafe fn _mm256_adds_epi8(a: __m256i, b: __m256i) -> __m256i { 114 | | transmute(simd_saturating_add(a.as_i8x32(), b.as_i8x32())) 115 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:124:1 | 124 | / pub unsafe fn _mm256_adds_epi16(a: __m256i, b: __m256i) -> __m256i { 125 | | transmute(simd_saturating_add(a.as_i16x16(), b.as_i16x16())) 126 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:135:1 | 135 | / pub unsafe fn _mm256_adds_epu8(a: __m256i, b: __m256i) -> __m256i { 136 | | transmute(simd_saturating_add(a.as_u8x32(), b.as_u8x32())) 137 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:146:1 | 146 | / pub unsafe fn _mm256_adds_epu16(a: __m256i, b: __m256i) -> __m256i { 147 | | transmute(simd_saturating_add(a.as_u16x16(), b.as_u16x16())) 148 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:159:1 | 159 | / pub unsafe fn _mm256_alignr_epi8(a: __m256i, b: __m256i, n: i32) -> __m256i { 160 | | let n = n as u32; 161 | | // If `palignr` is shifting the pair of vectors more than the size of two 162 | | // lanes, emit zero. ... | 308 | | transmute(r) 309 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:319:1 | 319 | / pub unsafe fn _mm256_and_si256(a: __m256i, b: __m256i) -> __m256i { 320 | | transmute(simd_and(a.as_i64x4(), b.as_i64x4())) 321 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:331:1 | 331 | / pub unsafe fn _mm256_andnot_si256(a: __m256i, b: __m256i) -> __m256i { 332 | | let all_ones = _mm256_set1_epi8(-1); 333 | | transmute(simd_and( 334 | | simd_xor(a.as_i64x4(), all_ones.as_i64x4()), 335 | | b.as_i64x4(), 336 | | )) 337 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:346:1 | 346 | / pub unsafe fn _mm256_avg_epu16(a: __m256i, b: __m256i) -> __m256i { 347 | | transmute(pavgw(a.as_u16x16(), b.as_u16x16())) 348 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:357:1 | 357 | / pub unsafe fn _mm256_avg_epu8(a: __m256i, b: __m256i) -> __m256i { 358 | | transmute(pavgb(a.as_u8x32(), b.as_u8x32())) 359 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:369:1 | 369 | / pub unsafe fn _mm_blend_epi32(a: __m128i, b: __m128i, imm8: i32) -> __m128i { 370 | | let imm8 = (imm8 & 0xFF) as u8; 371 | | let a = a.as_i32x4(); 372 | | let b = b.as_i32x4(); ... | 394 | | transmute(r) 395 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:405:1 | 405 | / pub unsafe fn _mm256_blend_epi32(a: __m256i, b: __m256i, imm8: i32) -> __m256i { 406 | | let imm8 = (imm8 & 0xFF) as u8; 407 | | let a = a.as_i32x8(); 408 | | let b = b.as_i32x8(); ... | 459 | | transmute(r) 460 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:470:1 | 470 | / pub unsafe fn _mm256_blend_epi16(a: __m256i, b: __m256i, imm8: i32) -> __m256i { 471 | | let imm8 = (imm8 & 0xFF) as u8; 472 | | let a = a.as_i16x16(); 473 | | let b = b.as_i16x16(); ... | 564 | | transmute(r) 565 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:574:1 | 574 | / pub unsafe fn _mm256_blendv_epi8(a: __m256i, b: __m256i, mask: __m256i) -> __m256i { 575 | | transmute(pblendvb(a.as_i8x32(), b.as_i8x32(), mask.as_i8x32())) 576 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:586:1 | 586 | / pub unsafe fn _mm_broadcastb_epi8(a: __m128i) -> __m128i { 587 | | let zero = _mm_setzero_si128(); 588 | | let ret = simd_shuffle16(a.as_i8x16(), zero.as_i8x16(), [0_u32; 16]); 589 | | transmute::(ret) 590 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:600:1 | 600 | / pub unsafe fn _mm256_broadcastb_epi8(a: __m128i) -> __m256i { 601 | | let zero = _mm_setzero_si128(); 602 | | let ret = simd_shuffle32(a.as_i8x16(), zero.as_i8x16(), [0_u32; 32]); 603 | | transmute::(ret) 604 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:616:1 | 616 | / pub unsafe fn _mm_broadcastd_epi32(a: __m128i) -> __m128i { 617 | | let zero = _mm_setzero_si128(); 618 | | let ret = simd_shuffle4(a.as_i32x4(), zero.as_i32x4(), [0_u32; 4]); 619 | | transmute::(ret) 620 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:632:1 | 632 | / pub unsafe fn _mm256_broadcastd_epi32(a: __m128i) -> __m256i { 633 | | let zero = _mm_setzero_si128(); 634 | | let ret = simd_shuffle8(a.as_i32x4(), zero.as_i32x4(), [0_u32; 8]); 635 | | transmute::(ret) 636 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:647:1 | 647 | / pub unsafe fn _mm_broadcastq_epi64(a: __m128i) -> __m128i { 648 | | let ret = simd_shuffle2(a.as_i64x2(), a.as_i64x2(), [0_u32; 2]); 649 | | transmute::(ret) 650 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:660:1 | 660 | / pub unsafe fn _mm256_broadcastq_epi64(a: __m128i) -> __m256i { 661 | | let ret = simd_shuffle4(a.as_i64x2(), a.as_i64x2(), [0_u32; 4]); 662 | | transmute::(ret) 663 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:673:1 | 673 | / pub unsafe fn _mm_broadcastsd_pd(a: __m128d) -> __m128d { 674 | | simd_shuffle2(a, _mm_setzero_pd(), [0_u32; 2]) 675 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:685:1 | 685 | / pub unsafe fn _mm256_broadcastsd_pd(a: __m128d) -> __m256d { 686 | | simd_shuffle4(a, _mm_setzero_pd(), [0_u32; 4]) 687 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:698:1 | 698 | / pub unsafe fn _mm256_broadcastsi128_si256(a: __m128i) -> __m256i { 699 | | let zero = _mm_setzero_si128(); 700 | | let ret = simd_shuffle4(a.as_i64x2(), zero.as_i64x2(), [0, 1, 0, 1]); 701 | | transmute::(ret) 702 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:712:1 | 712 | / pub unsafe fn _mm_broadcastss_ps(a: __m128) -> __m128 { 713 | | simd_shuffle4(a, _mm_setzero_ps(), [0_u32; 4]) 714 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:724:1 | 724 | / pub unsafe fn _mm256_broadcastss_ps(a: __m128) -> __m256 { 725 | | simd_shuffle8(a, _mm_setzero_ps(), [0_u32; 8]) 726 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:736:1 | 736 | / pub unsafe fn _mm_broadcastw_epi16(a: __m128i) -> __m128i { 737 | | let zero = _mm_setzero_si128(); 738 | | let ret = simd_shuffle8(a.as_i16x8(), zero.as_i16x8(), [0_u32; 8]); 739 | | transmute::(ret) 740 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:750:1 | 750 | / pub unsafe fn _mm256_broadcastw_epi16(a: __m128i) -> __m256i { 751 | | let zero = _mm_setzero_si128(); 752 | | let ret = simd_shuffle16(a.as_i16x8(), zero.as_i16x8(), [0_u32; 16]); 753 | | transmute::(ret) 754 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:763:1 | 763 | / pub unsafe fn _mm256_cmpeq_epi64(a: __m256i, b: __m256i) -> __m256i { 764 | | transmute::(simd_eq(a.as_i64x4(), b.as_i64x4())) 765 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:774:1 | 774 | / pub unsafe fn _mm256_cmpeq_epi32(a: __m256i, b: __m256i) -> __m256i { 775 | | transmute::(simd_eq(a.as_i32x8(), b.as_i32x8())) 776 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:785:1 | 785 | / pub unsafe fn _mm256_cmpeq_epi16(a: __m256i, b: __m256i) -> __m256i { 786 | | transmute::(simd_eq(a.as_i16x16(), b.as_i16x16())) 787 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:796:1 | 796 | / pub unsafe fn _mm256_cmpeq_epi8(a: __m256i, b: __m256i) -> __m256i { 797 | | transmute::(simd_eq(a.as_i8x32(), b.as_i8x32())) 798 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:807:1 | 807 | / pub unsafe fn _mm256_cmpgt_epi64(a: __m256i, b: __m256i) -> __m256i { 808 | | transmute::(simd_gt(a.as_i64x4(), b.as_i64x4())) 809 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:818:1 | 818 | / pub unsafe fn _mm256_cmpgt_epi32(a: __m256i, b: __m256i) -> __m256i { 819 | | transmute::(simd_gt(a.as_i32x8(), b.as_i32x8())) 820 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:829:1 | 829 | / pub unsafe fn _mm256_cmpgt_epi16(a: __m256i, b: __m256i) -> __m256i { 830 | | transmute::(simd_gt(a.as_i16x16(), b.as_i16x16())) 831 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:840:1 | 840 | / pub unsafe fn _mm256_cmpgt_epi8(a: __m256i, b: __m256i) -> __m256i { 841 | | transmute::(simd_gt(a.as_i8x32(), b.as_i8x32())) 842 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:851:1 | 851 | / pub unsafe fn _mm256_cvtepi16_epi32(a: __m128i) -> __m256i { 852 | | transmute::(simd_cast(a.as_i16x8())) 853 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:862:1 | 862 | / pub unsafe fn _mm256_cvtepi16_epi64(a: __m128i) -> __m256i { 863 | | let a = a.as_i16x8(); 864 | | let v64: i16x4 = simd_shuffle4(a, a, [0, 1, 2, 3]); 865 | | transmute::(simd_cast(v64)) 866 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:875:1 | 875 | / pub unsafe fn _mm256_cvtepi32_epi64(a: __m128i) -> __m256i { 876 | | transmute::(simd_cast(a.as_i32x4())) 877 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:886:1 | 886 | / pub unsafe fn _mm256_cvtepi8_epi16(a: __m128i) -> __m256i { 887 | | transmute::(simd_cast(a.as_i8x16())) 888 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:897:1 | 897 | / pub unsafe fn _mm256_cvtepi8_epi32(a: __m128i) -> __m256i { 898 | | let a = a.as_i8x16(); 899 | | let v64: i8x8 = simd_shuffle8(a, a, [0, 1, 2, 3, 4, 5, 6, 7]); 900 | | transmute::(simd_cast(v64)) 901 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:910:1 | 910 | / pub unsafe fn _mm256_cvtepi8_epi64(a: __m128i) -> __m256i { 911 | | let a = a.as_i8x16(); 912 | | let v32: i8x4 = simd_shuffle4(a, a, [0, 1, 2, 3]); 913 | | transmute::(simd_cast(v32)) 914 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:924:1 | 924 | / pub unsafe fn _mm256_cvtepu16_epi32(a: __m128i) -> __m256i { 925 | | transmute::(simd_cast(a.as_u16x8())) 926 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:936:1 | 936 | / pub unsafe fn _mm256_cvtepu16_epi64(a: __m128i) -> __m256i { 937 | | let a = a.as_u16x8(); 938 | | let v64: u16x4 = simd_shuffle4(a, a, [0, 1, 2, 3]); 939 | | transmute::(simd_cast(v64)) 940 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:949:1 | 949 | / pub unsafe fn _mm256_cvtepu32_epi64(a: __m128i) -> __m256i { 950 | | transmute::(simd_cast(a.as_u32x4())) 951 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:960:1 | 960 | / pub unsafe fn _mm256_cvtepu8_epi16(a: __m128i) -> __m256i { 961 | | transmute::(simd_cast(a.as_u8x16())) 962 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:972:1 | 972 | / pub unsafe fn _mm256_cvtepu8_epi32(a: __m128i) -> __m256i { 973 | | let a = a.as_u8x16(); 974 | | let v64: u8x8 = simd_shuffle8(a, a, [0, 1, 2, 3, 4, 5, 6, 7]); 975 | | transmute::(simd_cast(v64)) 976 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:986:1 | 986 | / pub unsafe fn _mm256_cvtepu8_epi64(a: __m128i) -> __m256i { 987 | | let a = a.as_u8x16(); 988 | | let v32: u8x4 = simd_shuffle4(a, a, [0, 1, 2, 3]); 989 | | transmute::(simd_cast(v32)) 990 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1003:1 | 1003 | / pub unsafe fn _mm256_extracti128_si256(a: __m256i, imm8: i32) -> __m128i { 1004 | | let a = a.as_i64x4(); 1005 | | let b = _mm256_undefined_si256().as_i64x4(); 1006 | | let dst: i64x2 = match imm8 & 0b01 { ... | 1010 | | transmute(dst) 1011 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1020:1 | 1020 | / pub unsafe fn _mm256_hadd_epi16(a: __m256i, b: __m256i) -> __m256i { 1021 | | transmute(phaddw(a.as_i16x16(), b.as_i16x16())) 1022 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1031:1 | 1031 | / pub unsafe fn _mm256_hadd_epi32(a: __m256i, b: __m256i) -> __m256i { 1032 | | transmute(phaddd(a.as_i32x8(), b.as_i32x8())) 1033 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1043:1 | 1043 | / pub unsafe fn _mm256_hadds_epi16(a: __m256i, b: __m256i) -> __m256i { 1044 | | transmute(phaddsw(a.as_i16x16(), b.as_i16x16())) 1045 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1054:1 | 1054 | / pub unsafe fn _mm256_hsub_epi16(a: __m256i, b: __m256i) -> __m256i { 1055 | | transmute(phsubw(a.as_i16x16(), b.as_i16x16())) 1056 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1065:1 | 1065 | / pub unsafe fn _mm256_hsub_epi32(a: __m256i, b: __m256i) -> __m256i { 1066 | | transmute(phsubd(a.as_i32x8(), b.as_i32x8())) 1067 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1077:1 | 1077 | / pub unsafe fn _mm256_hsubs_epi16(a: __m256i, b: __m256i) -> __m256i { 1078 | | transmute(phsubsw(a.as_i16x16(), b.as_i16x16())) 1079 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1091:1 | 1091 | / pub unsafe fn _mm_i32gather_epi32(slice: *const i32, offsets: __m128i, scale: i32) -> __m128i { 1092 | | let zero = _mm_setzero_si128().as_i32x4(); 1093 | | let neg_one = _mm_set1_epi32(-1).as_i32x4(); 1094 | | let offsets = offsets.as_i32x4(); ... | 1102 | | transmute(r) 1103 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1116:1 | 1116 | / pub unsafe fn _mm_mask_i32gather_epi32( 1117 | | src: __m128i, 1118 | | slice: *const i32, 1119 | | offsets: __m128i, ... | 1133 | | transmute(r) 1134 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1146:1 | 1146 | / pub unsafe fn _mm256_i32gather_epi32(slice: *const i32, offsets: __m256i, scale: i32) -> __m256i { 1147 | | let zero = _mm256_setzero_si256().as_i32x8(); 1148 | | let neg_one = _mm256_set1_epi32(-1).as_i32x8(); 1149 | | let offsets = offsets.as_i32x8(); ... | 1157 | | transmute(r) 1158 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1171:1 | 1171 | / pub unsafe fn _mm256_mask_i32gather_epi32( 1172 | | src: __m256i, 1173 | | slice: *const i32, 1174 | | offsets: __m256i, ... | 1188 | | transmute(r) 1189 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1201:1 | 1201 | / pub unsafe fn _mm_i32gather_ps(slice: *const f32, offsets: __m128i, scale: i32) -> __m128 { 1202 | | let zero = _mm_setzero_ps(); 1203 | | let neg_one = _mm_set1_ps(-1.0); 1204 | | let offsets = offsets.as_i32x4(); ... | 1211 | | constify_imm8!(scale, call) 1212 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1225:1 | 1225 | / pub unsafe fn _mm_mask_i32gather_ps( 1226 | | src: __m128, 1227 | | slice: *const f32, 1228 | | offsets: __m128i, ... | 1239 | | constify_imm8!(scale, call) 1240 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1252:1 | 1252 | / pub unsafe fn _mm256_i32gather_ps(slice: *const f32, offsets: __m256i, scale: i32) -> __m256 { 1253 | | let zero = _mm256_setzero_ps(); 1254 | | let neg_one = _mm256_set1_ps(-1.0); 1255 | | let offsets = offsets.as_i32x8(); ... | 1262 | | constify_imm8!(scale, call) 1263 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1276:1 | 1276 | / pub unsafe fn _mm256_mask_i32gather_ps( 1277 | | src: __m256, 1278 | | slice: *const f32, 1279 | | offsets: __m256i, ... | 1290 | | constify_imm8!(scale, call) 1291 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1303:1 | 1303 | / pub unsafe fn _mm_i32gather_epi64(slice: *const i64, offsets: __m128i, scale: i32) -> __m128i { 1304 | | let zero = _mm_setzero_si128().as_i64x2(); 1305 | | let neg_one = _mm_set1_epi64x(-1).as_i64x2(); 1306 | | let offsets = offsets.as_i32x4(); ... | 1314 | | transmute(r) 1315 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1328:1 | 1328 | / pub unsafe fn _mm_mask_i32gather_epi64( 1329 | | src: __m128i, 1330 | | slice: *const i64, 1331 | | offsets: __m128i, ... | 1345 | | transmute(r) 1346 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1358:1 | 1358 | / pub unsafe fn _mm256_i32gather_epi64(slice: *const i64, offsets: __m128i, scale: i32) -> __m256i { 1359 | | let zero = _mm256_setzero_si256().as_i64x4(); 1360 | | let neg_one = _mm256_set1_epi64x(-1).as_i64x4(); 1361 | | let offsets = offsets.as_i32x4(); ... | 1369 | | transmute(r) 1370 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1383:1 | 1383 | / pub unsafe fn _mm256_mask_i32gather_epi64( 1384 | | src: __m256i, 1385 | | slice: *const i64, 1386 | | offsets: __m128i, ... | 1400 | | transmute(r) 1401 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1413:1 | 1413 | / pub unsafe fn _mm_i32gather_pd(slice: *const f64, offsets: __m128i, scale: i32) -> __m128d { 1414 | | let zero = _mm_setzero_pd(); 1415 | | let neg_one = _mm_set1_pd(-1.0); 1416 | | let offsets = offsets.as_i32x4(); ... | 1423 | | constify_imm8!(scale, call) 1424 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1437:1 | 1437 | / pub unsafe fn _mm_mask_i32gather_pd( 1438 | | src: __m128d, 1439 | | slice: *const f64, 1440 | | offsets: __m128i, ... | 1451 | | constify_imm8!(scale, call) 1452 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1464:1 | 1464 | / pub unsafe fn _mm256_i32gather_pd(slice: *const f64, offsets: __m128i, scale: i32) -> __m256d { 1465 | | let zero = _mm256_setzero_pd(); 1466 | | let neg_one = _mm256_set1_pd(-1.0); 1467 | | let offsets = offsets.as_i32x4(); ... | 1474 | | constify_imm8!(scale, call) 1475 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1488:1 | 1488 | / pub unsafe fn _mm256_mask_i32gather_pd( 1489 | | src: __m256d, 1490 | | slice: *const f64, 1491 | | offsets: __m128i, ... | 1502 | | constify_imm8!(scale, call) 1503 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1515:1 | 1515 | / pub unsafe fn _mm_i64gather_epi32(slice: *const i32, offsets: __m128i, scale: i32) -> __m128i { 1516 | | let zero = _mm_setzero_si128().as_i32x4(); 1517 | | let neg_one = _mm_set1_epi64x(-1).as_i32x4(); 1518 | | let offsets = offsets.as_i64x2(); ... | 1526 | | transmute(r) 1527 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1540:1 | 1540 | / pub unsafe fn _mm_mask_i64gather_epi32( 1541 | | src: __m128i, 1542 | | slice: *const i32, 1543 | | offsets: __m128i, ... | 1557 | | transmute(r) 1558 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1570:1 | 1570 | / pub unsafe fn _mm256_i64gather_epi32(slice: *const i32, offsets: __m256i, scale: i32) -> __m128i { 1571 | | let zero = _mm_setzero_si128().as_i32x4(); 1572 | | let neg_one = _mm_set1_epi64x(-1).as_i32x4(); 1573 | | let offsets = offsets.as_i64x4(); ... | 1581 | | transmute(r) 1582 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1595:1 | 1595 | / pub unsafe fn _mm256_mask_i64gather_epi32( 1596 | | src: __m128i, 1597 | | slice: *const i32, 1598 | | offsets: __m256i, ... | 1612 | | transmute(r) 1613 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1625:1 | 1625 | / pub unsafe fn _mm_i64gather_ps(slice: *const f32, offsets: __m128i, scale: i32) -> __m128 { 1626 | | let zero = _mm_setzero_ps(); 1627 | | let neg_one = _mm_set1_ps(-1.0); 1628 | | let offsets = offsets.as_i64x2(); ... | 1635 | | constify_imm8!(scale, call) 1636 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1649:1 | 1649 | / pub unsafe fn _mm_mask_i64gather_ps( 1650 | | src: __m128, 1651 | | slice: *const f32, 1652 | | offsets: __m128i, ... | 1663 | | constify_imm8!(scale, call) 1664 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1676:1 | 1676 | / pub unsafe fn _mm256_i64gather_ps(slice: *const f32, offsets: __m256i, scale: i32) -> __m128 { 1677 | | let zero = _mm_setzero_ps(); 1678 | | let neg_one = _mm_set1_ps(-1.0); 1679 | | let offsets = offsets.as_i64x4(); ... | 1686 | | constify_imm8!(scale, call) 1687 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1700:1 | 1700 | / pub unsafe fn _mm256_mask_i64gather_ps( 1701 | | src: __m128, 1702 | | slice: *const f32, 1703 | | offsets: __m256i, ... | 1714 | | constify_imm8!(scale, call) 1715 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1727:1 | 1727 | / pub unsafe fn _mm_i64gather_epi64(slice: *const i64, offsets: __m128i, scale: i32) -> __m128i { 1728 | | let zero = _mm_setzero_si128().as_i64x2(); 1729 | | let neg_one = _mm_set1_epi64x(-1).as_i64x2(); 1730 | | let slice = slice as *const i8; ... | 1738 | | transmute(r) 1739 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1752:1 | 1752 | / pub unsafe fn _mm_mask_i64gather_epi64( 1753 | | src: __m128i, 1754 | | slice: *const i64, 1755 | | offsets: __m128i, ... | 1769 | | transmute(r) 1770 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1782:1 | 1782 | / pub unsafe fn _mm256_i64gather_epi64(slice: *const i64, offsets: __m256i, scale: i32) -> __m256i { 1783 | | let zero = _mm256_setzero_si256().as_i64x4(); 1784 | | let neg_one = _mm256_set1_epi64x(-1).as_i64x4(); 1785 | | let slice = slice as *const i8; ... | 1793 | | transmute(r) 1794 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1807:1 | 1807 | / pub unsafe fn _mm256_mask_i64gather_epi64( 1808 | | src: __m256i, 1809 | | slice: *const i64, 1810 | | offsets: __m256i, ... | 1824 | | transmute(r) 1825 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1837:1 | 1837 | / pub unsafe fn _mm_i64gather_pd(slice: *const f64, offsets: __m128i, scale: i32) -> __m128d { 1838 | | let zero = _mm_setzero_pd(); 1839 | | let neg_one = _mm_set1_pd(-1.0); 1840 | | let slice = slice as *const i8; ... | 1847 | | constify_imm8!(scale, call) 1848 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1861:1 | 1861 | / pub unsafe fn _mm_mask_i64gather_pd( 1862 | | src: __m128d, 1863 | | slice: *const f64, 1864 | | offsets: __m128i, ... | 1875 | | constify_imm8!(scale, call) 1876 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1888:1 | 1888 | / pub unsafe fn _mm256_i64gather_pd(slice: *const f64, offsets: __m256i, scale: i32) -> __m256d { 1889 | | let zero = _mm256_setzero_pd(); 1890 | | let neg_one = _mm256_set1_pd(-1.0); 1891 | | let slice = slice as *const i8; ... | 1898 | | constify_imm8!(scale, call) 1899 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1912:1 | 1912 | / pub unsafe fn _mm256_mask_i64gather_pd( 1913 | | src: __m256d, 1914 | | slice: *const f64, 1915 | | offsets: __m256i, ... | 1926 | | constify_imm8!(scale, call) 1927 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1941:1 | 1941 | / pub unsafe fn _mm256_inserti128_si256(a: __m256i, b: __m128i, imm8: i32) -> __m256i { 1942 | | let a = a.as_i64x4(); 1943 | | let b = _mm256_castsi128_si256(b).as_i64x4(); 1944 | | let dst: i64x4 = match imm8 & 0b01 { ... | 1948 | | transmute(dst) 1949 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1960:1 | 1960 | / pub unsafe fn _mm256_madd_epi16(a: __m256i, b: __m256i) -> __m256i { 1961 | | transmute(pmaddwd(a.as_i16x16(), b.as_i16x16())) 1962 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1974:1 | 1974 | / pub unsafe fn _mm256_maddubs_epi16(a: __m256i, b: __m256i) -> __m256i { 1975 | | transmute(pmaddubsw(a.as_u8x32(), b.as_u8x32())) 1976 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:1987:1 | 1987 | / pub unsafe fn _mm_maskload_epi32(mem_addr: *const i32, mask: __m128i) -> __m128i { 1988 | | transmute(maskloadd(mem_addr as *const i8, mask.as_i32x4())) 1989 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2000:1 | 2000 | / pub unsafe fn _mm256_maskload_epi32(mem_addr: *const i32, mask: __m256i) -> __m256i { 2001 | | transmute(maskloadd256(mem_addr as *const i8, mask.as_i32x8())) 2002 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2013:1 | 2013 | / pub unsafe fn _mm_maskload_epi64(mem_addr: *const i64, mask: __m128i) -> __m128i { 2014 | | transmute(maskloadq(mem_addr as *const i8, mask.as_i64x2())) 2015 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2026:1 | 2026 | / pub unsafe fn _mm256_maskload_epi64(mem_addr: *const i64, mask: __m256i) -> __m256i { 2027 | | transmute(maskloadq256(mem_addr as *const i8, mask.as_i64x4())) 2028 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2039:1 | 2039 | / pub unsafe fn _mm_maskstore_epi32(mem_addr: *mut i32, mask: __m128i, a: __m128i) { 2040 | | maskstored(mem_addr as *mut i8, mask.as_i32x4(), a.as_i32x4()) 2041 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2052:1 | 2052 | / pub unsafe fn _mm256_maskstore_epi32(mem_addr: *mut i32, mask: __m256i, a: __m256i) { 2053 | | maskstored256(mem_addr as *mut i8, mask.as_i32x8(), a.as_i32x8()) 2054 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2065:1 | 2065 | / pub unsafe fn _mm_maskstore_epi64(mem_addr: *mut i64, mask: __m128i, a: __m128i) { 2066 | | maskstoreq(mem_addr as *mut i8, mask.as_i64x2(), a.as_i64x2()) 2067 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2078:1 | 2078 | / pub unsafe fn _mm256_maskstore_epi64(mem_addr: *mut i64, mask: __m256i, a: __m256i) { 2079 | | maskstoreq256(mem_addr as *mut i8, mask.as_i64x4(), a.as_i64x4()) 2080 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2090:1 | 2090 | / pub unsafe fn _mm256_max_epi16(a: __m256i, b: __m256i) -> __m256i { 2091 | | transmute(pmaxsw(a.as_i16x16(), b.as_i16x16())) 2092 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2102:1 | 2102 | / pub unsafe fn _mm256_max_epi32(a: __m256i, b: __m256i) -> __m256i { 2103 | | transmute(pmaxsd(a.as_i32x8(), b.as_i32x8())) 2104 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2114:1 | 2114 | / pub unsafe fn _mm256_max_epi8(a: __m256i, b: __m256i) -> __m256i { 2115 | | transmute(pmaxsb(a.as_i8x32(), b.as_i8x32())) 2116 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2126:1 | 2126 | / pub unsafe fn _mm256_max_epu16(a: __m256i, b: __m256i) -> __m256i { 2127 | | transmute(pmaxuw(a.as_u16x16(), b.as_u16x16())) 2128 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2138:1 | 2138 | / pub unsafe fn _mm256_max_epu32(a: __m256i, b: __m256i) -> __m256i { 2139 | | transmute(pmaxud(a.as_u32x8(), b.as_u32x8())) 2140 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2150:1 | 2150 | / pub unsafe fn _mm256_max_epu8(a: __m256i, b: __m256i) -> __m256i { 2151 | | transmute(pmaxub(a.as_u8x32(), b.as_u8x32())) 2152 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2162:1 | 2162 | / pub unsafe fn _mm256_min_epi16(a: __m256i, b: __m256i) -> __m256i { 2163 | | transmute(pminsw(a.as_i16x16(), b.as_i16x16())) 2164 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2174:1 | 2174 | / pub unsafe fn _mm256_min_epi32(a: __m256i, b: __m256i) -> __m256i { 2175 | | transmute(pminsd(a.as_i32x8(), b.as_i32x8())) 2176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2186:1 | 2186 | / pub unsafe fn _mm256_min_epi8(a: __m256i, b: __m256i) -> __m256i { 2187 | | transmute(pminsb(a.as_i8x32(), b.as_i8x32())) 2188 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2198:1 | 2198 | / pub unsafe fn _mm256_min_epu16(a: __m256i, b: __m256i) -> __m256i { 2199 | | transmute(pminuw(a.as_u16x16(), b.as_u16x16())) 2200 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2210:1 | 2210 | / pub unsafe fn _mm256_min_epu32(a: __m256i, b: __m256i) -> __m256i { 2211 | | transmute(pminud(a.as_u32x8(), b.as_u32x8())) 2212 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2222:1 | 2222 | / pub unsafe fn _mm256_min_epu8(a: __m256i, b: __m256i) -> __m256i { 2223 | | transmute(pminub(a.as_u8x32(), b.as_u8x32())) 2224 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2234:1 | 2234 | / pub unsafe fn _mm256_movemask_epi8(a: __m256i) -> i32 { 2235 | | pmovmskb(a.as_i8x32()) 2236 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2252:1 | 2252 | / pub unsafe fn _mm256_mpsadbw_epu8(a: __m256i, b: __m256i, imm8: i32) -> __m256i { 2253 | | let a = a.as_u8x32(); 2254 | | let b = b.as_u8x32(); 2255 | | macro_rules! call { ... | 2261 | | transmute(r) 2262 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2274:1 | 2274 | / pub unsafe fn _mm256_mul_epi32(a: __m256i, b: __m256i) -> __m256i { 2275 | | transmute(pmuldq(a.as_i32x8(), b.as_i32x8())) 2276 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2288:1 | 2288 | / pub unsafe fn _mm256_mul_epu32(a: __m256i, b: __m256i) -> __m256i { 2289 | | transmute(pmuludq(a.as_u32x8(), b.as_u32x8())) 2290 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2301:1 | 2301 | / pub unsafe fn _mm256_mulhi_epi16(a: __m256i, b: __m256i) -> __m256i { 2302 | | transmute(pmulhw(a.as_i16x16(), b.as_i16x16())) 2303 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2314:1 | 2314 | / pub unsafe fn _mm256_mulhi_epu16(a: __m256i, b: __m256i) -> __m256i { 2315 | | transmute(pmulhuw(a.as_u16x16(), b.as_u16x16())) 2316 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2327:1 | 2327 | / pub unsafe fn _mm256_mullo_epi16(a: __m256i, b: __m256i) -> __m256i { 2328 | | transmute(simd_mul(a.as_i16x16(), b.as_i16x16())) 2329 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2340:1 | 2340 | / pub unsafe fn _mm256_mullo_epi32(a: __m256i, b: __m256i) -> __m256i { 2341 | | transmute(simd_mul(a.as_i32x8(), b.as_i32x8())) 2342 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2354:1 | 2354 | / pub unsafe fn _mm256_mulhrs_epi16(a: __m256i, b: __m256i) -> __m256i { 2355 | | transmute(pmulhrsw(a.as_i16x16(), b.as_i16x16())) 2356 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2366:1 | 2366 | / pub unsafe fn _mm256_or_si256(a: __m256i, b: __m256i) -> __m256i { 2367 | | transmute(simd_or(a.as_i32x8(), b.as_i32x8())) 2368 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2378:1 | 2378 | / pub unsafe fn _mm256_packs_epi16(a: __m256i, b: __m256i) -> __m256i { 2379 | | transmute(packsswb(a.as_i16x16(), b.as_i16x16())) 2380 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2390:1 | 2390 | / pub unsafe fn _mm256_packs_epi32(a: __m256i, b: __m256i) -> __m256i { 2391 | | transmute(packssdw(a.as_i32x8(), b.as_i32x8())) 2392 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2402:1 | 2402 | / pub unsafe fn _mm256_packus_epi16(a: __m256i, b: __m256i) -> __m256i { 2403 | | transmute(packuswb(a.as_i16x16(), b.as_i16x16())) 2404 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2414:1 | 2414 | / pub unsafe fn _mm256_packus_epi32(a: __m256i, b: __m256i) -> __m256i { 2415 | | transmute(packusdw(a.as_i32x8(), b.as_i32x8())) 2416 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2428:1 | 2428 | / pub unsafe fn _mm256_permutevar8x32_epi32(a: __m256i, b: __m256i) -> __m256i { 2429 | | transmute(permd(a.as_u32x8(), b.as_u32x8())) 2430 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2440:1 | 2440 | / pub unsafe fn _mm256_permute4x64_epi64(a: __m256i, imm8: i32) -> __m256i { 2441 | | let imm8 = (imm8 & 0xFF) as u8; 2442 | | let zero = _mm256_setzero_si256().as_i64x4(); 2443 | | let a = a.as_i64x4(); ... | 2485 | | transmute(r) 2486 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2496:1 | 2496 | / pub unsafe fn _mm256_permute2x128_si256(a: __m256i, b: __m256i, imm8: i32) -> __m256i { 2497 | | let a = a.as_i64x4(); 2498 | | let b = b.as_i64x4(); 2499 | | macro_rules! call { ... | 2504 | | transmute(constify_imm8!(imm8, call)) 2505 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2516:1 | 2516 | / pub unsafe fn _mm256_permute4x64_pd(a: __m256d, imm8: i32) -> __m256d { 2517 | | let imm8 = (imm8 & 0xFF) as u8; 2518 | | let undef = _mm256_undefined_pd(); 2519 | | macro_rules! shuffle_done { ... | 2559 | | } 2560 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2570:1 | 2570 | / pub unsafe fn _mm256_permutevar8x32_ps(a: __m256, idx: __m256i) -> __m256 { 2571 | | permps(a, idx.as_i32x8()) 2572 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2584:1 | 2584 | / pub unsafe fn _mm256_sad_epu8(a: __m256i, b: __m256i) -> __m256i { 2585 | | transmute(psadbw(a.as_u8x32(), b.as_u8x32())) 2586 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2623:1 | 2623 | / pub unsafe fn _mm256_shuffle_epi8(a: __m256i, b: __m256i) -> __m256i { 2624 | | transmute(pshufb(a.as_u8x32(), b.as_u8x32())) 2625 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2662:1 | 2662 | / pub unsafe fn _mm256_shuffle_epi32(a: __m256i, imm8: i32) -> __m256i { 2663 | | // simd_shuffleX requires that its selector parameter be made up of 2664 | | // constant values, but we can't enforce that here. In spirit, we need 2665 | | // to write a `match` on all possible values of a byte, and for each value, ... | 2727 | | transmute(r) 2728 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2740:1 | 2740 | / pub unsafe fn _mm256_shufflehi_epi16(a: __m256i, imm8: i32) -> __m256i { 2741 | | let imm8 = (imm8 & 0xFF) as u8; 2742 | | let a = a.as_i16x16(); 2743 | | macro_rules! shuffle_done { ... | 2788 | | transmute(r) 2789 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2801:1 | 2801 | / pub unsafe fn _mm256_shufflelo_epi16(a: __m256i, imm8: i32) -> __m256i { 2802 | | let imm8 = (imm8 & 0xFF) as u8; 2803 | | let a = a.as_i16x16(); 2804 | | macro_rules! shuffle_done { ... | 2849 | | transmute(r) 2850 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2861:1 | 2861 | / pub unsafe fn _mm256_sign_epi16(a: __m256i, b: __m256i) -> __m256i { 2862 | | transmute(psignw(a.as_i16x16(), b.as_i16x16())) 2863 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2874:1 | 2874 | / pub unsafe fn _mm256_sign_epi32(a: __m256i, b: __m256i) -> __m256i { 2875 | | transmute(psignd(a.as_i32x8(), b.as_i32x8())) 2876 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2887:1 | 2887 | / pub unsafe fn _mm256_sign_epi8(a: __m256i, b: __m256i) -> __m256i { 2888 | | transmute(psignb(a.as_i8x32(), b.as_i8x32())) 2889 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2899:1 | 2899 | / pub unsafe fn _mm256_sll_epi16(a: __m256i, count: __m128i) -> __m256i { 2900 | | transmute(psllw(a.as_i16x16(), count.as_i16x8())) 2901 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2911:1 | 2911 | / pub unsafe fn _mm256_sll_epi32(a: __m256i, count: __m128i) -> __m256i { 2912 | | transmute(pslld(a.as_i32x8(), count.as_i32x4())) 2913 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2923:1 | 2923 | / pub unsafe fn _mm256_sll_epi64(a: __m256i, count: __m128i) -> __m256i { 2924 | | transmute(psllq(a.as_i64x4(), count.as_i64x2())) 2925 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2935:1 | 2935 | / pub unsafe fn _mm256_slli_epi16(a: __m256i, imm8: i32) -> __m256i { 2936 | | transmute(pslliw(a.as_i16x16(), imm8)) 2937 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2947:1 | 2947 | / pub unsafe fn _mm256_slli_epi32(a: __m256i, imm8: i32) -> __m256i { 2948 | | transmute(psllid(a.as_i32x8(), imm8)) 2949 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2959:1 | 2959 | / pub unsafe fn _mm256_slli_epi64(a: __m256i, imm8: i32) -> __m256i { 2960 | | transmute(pslliq(a.as_i64x4(), imm8)) 2961 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2971:1 | 2971 | / pub unsafe fn _mm256_slli_si256(a: __m256i, imm8: i32) -> __m256i { 2972 | | let a = a.as_i64x4(); 2973 | | macro_rules! call { 2974 | | ($imm8:expr) => { ... | 2978 | | transmute(constify_imm8!(imm8 * 8, call)) 2979 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:2989:1 | 2989 | / pub unsafe fn _mm256_bslli_epi128(a: __m256i, imm8: i32) -> __m256i { 2990 | | let a = a.as_i64x4(); 2991 | | macro_rules! call { 2992 | | ($imm8:expr) => { ... | 2996 | | transmute(constify_imm8!(imm8 * 8, call)) 2997 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3008:1 | 3008 | / pub unsafe fn _mm_sllv_epi32(a: __m128i, count: __m128i) -> __m128i { 3009 | | transmute(psllvd(a.as_i32x4(), count.as_i32x4())) 3010 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3021:1 | 3021 | / pub unsafe fn _mm256_sllv_epi32(a: __m256i, count: __m256i) -> __m256i { 3022 | | transmute(psllvd256(a.as_i32x8(), count.as_i32x8())) 3023 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3034:1 | 3034 | / pub unsafe fn _mm_sllv_epi64(a: __m128i, count: __m128i) -> __m128i { 3035 | | transmute(psllvq(a.as_i64x2(), count.as_i64x2())) 3036 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3047:1 | 3047 | / pub unsafe fn _mm256_sllv_epi64(a: __m256i, count: __m256i) -> __m256i { 3048 | | transmute(psllvq256(a.as_i64x4(), count.as_i64x4())) 3049 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3059:1 | 3059 | / pub unsafe fn _mm256_sra_epi16(a: __m256i, count: __m128i) -> __m256i { 3060 | | transmute(psraw(a.as_i16x16(), count.as_i16x8())) 3061 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3071:1 | 3071 | / pub unsafe fn _mm256_sra_epi32(a: __m256i, count: __m128i) -> __m256i { 3072 | | transmute(psrad(a.as_i32x8(), count.as_i32x4())) 3073 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3083:1 | 3083 | / pub unsafe fn _mm256_srai_epi16(a: __m256i, imm8: i32) -> __m256i { 3084 | | transmute(psraiw(a.as_i16x16(), imm8)) 3085 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3095:1 | 3095 | / pub unsafe fn _mm256_srai_epi32(a: __m256i, imm8: i32) -> __m256i { 3096 | | transmute(psraid(a.as_i32x8(), imm8)) 3097 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3107:1 | 3107 | / pub unsafe fn _mm_srav_epi32(a: __m128i, count: __m128i) -> __m128i { 3108 | | transmute(psravd(a.as_i32x4(), count.as_i32x4())) 3109 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3119:1 | 3119 | / pub unsafe fn _mm256_srav_epi32(a: __m256i, count: __m256i) -> __m256i { 3120 | | transmute(psravd256(a.as_i32x8(), count.as_i32x8())) 3121 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3131:1 | 3131 | / pub unsafe fn _mm256_srli_si256(a: __m256i, imm8: i32) -> __m256i { 3132 | | let a = a.as_i64x4(); 3133 | | macro_rules! call { 3134 | | ($imm8:expr) => { ... | 3138 | | transmute(constify_imm8!(imm8 * 8, call)) 3139 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3149:1 | 3149 | / pub unsafe fn _mm256_bsrli_epi128(a: __m256i, imm8: i32) -> __m256i { 3150 | | let a = a.as_i64x4(); 3151 | | macro_rules! call { 3152 | | ($imm8:expr) => { ... | 3156 | | transmute(constify_imm8!(imm8 * 8, call)) 3157 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3167:1 | 3167 | / pub unsafe fn _mm256_srl_epi16(a: __m256i, count: __m128i) -> __m256i { 3168 | | transmute(psrlw(a.as_i16x16(), count.as_i16x8())) 3169 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3179:1 | 3179 | / pub unsafe fn _mm256_srl_epi32(a: __m256i, count: __m128i) -> __m256i { 3180 | | transmute(psrld(a.as_i32x8(), count.as_i32x4())) 3181 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3191:1 | 3191 | / pub unsafe fn _mm256_srl_epi64(a: __m256i, count: __m128i) -> __m256i { 3192 | | transmute(psrlq(a.as_i64x4(), count.as_i64x2())) 3193 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3203:1 | 3203 | / pub unsafe fn _mm256_srli_epi16(a: __m256i, imm8: i32) -> __m256i { 3204 | | transmute(psrliw(a.as_i16x16(), imm8)) 3205 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3215:1 | 3215 | / pub unsafe fn _mm256_srli_epi32(a: __m256i, imm8: i32) -> __m256i { 3216 | | transmute(psrlid(a.as_i32x8(), imm8)) 3217 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3227:1 | 3227 | / pub unsafe fn _mm256_srli_epi64(a: __m256i, imm8: i32) -> __m256i { 3228 | | transmute(psrliq(a.as_i64x4(), imm8)) 3229 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3239:1 | 3239 | / pub unsafe fn _mm_srlv_epi32(a: __m128i, count: __m128i) -> __m128i { 3240 | | transmute(psrlvd(a.as_i32x4(), count.as_i32x4())) 3241 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3251:1 | 3251 | / pub unsafe fn _mm256_srlv_epi32(a: __m256i, count: __m256i) -> __m256i { 3252 | | transmute(psrlvd256(a.as_i32x8(), count.as_i32x8())) 3253 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3263:1 | 3263 | / pub unsafe fn _mm_srlv_epi64(a: __m128i, count: __m128i) -> __m128i { 3264 | | transmute(psrlvq(a.as_i64x2(), count.as_i64x2())) 3265 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3275:1 | 3275 | / pub unsafe fn _mm256_srlv_epi64(a: __m256i, count: __m256i) -> __m256i { 3276 | | transmute(psrlvq256(a.as_i64x4(), count.as_i64x4())) 3277 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3288:1 | 3288 | / pub unsafe fn _mm256_sub_epi16(a: __m256i, b: __m256i) -> __m256i { 3289 | | transmute(simd_sub(a.as_i16x16(), b.as_i16x16())) 3290 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3299:1 | 3299 | / pub unsafe fn _mm256_sub_epi32(a: __m256i, b: __m256i) -> __m256i { 3300 | | transmute(simd_sub(a.as_i32x8(), b.as_i32x8())) 3301 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3310:1 | 3310 | / pub unsafe fn _mm256_sub_epi64(a: __m256i, b: __m256i) -> __m256i { 3311 | | transmute(simd_sub(a.as_i64x4(), b.as_i64x4())) 3312 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3321:1 | 3321 | / pub unsafe fn _mm256_sub_epi8(a: __m256i, b: __m256i) -> __m256i { 3322 | | transmute(simd_sub(a.as_i8x32(), b.as_i8x32())) 3323 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3333:1 | 3333 | / pub unsafe fn _mm256_subs_epi16(a: __m256i, b: __m256i) -> __m256i { 3334 | | transmute(simd_saturating_sub(a.as_i16x16(), b.as_i16x16())) 3335 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3345:1 | 3345 | / pub unsafe fn _mm256_subs_epi8(a: __m256i, b: __m256i) -> __m256i { 3346 | | transmute(simd_saturating_sub(a.as_i8x32(), b.as_i8x32())) 3347 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3357:1 | 3357 | / pub unsafe fn _mm256_subs_epu16(a: __m256i, b: __m256i) -> __m256i { 3358 | | transmute(simd_saturating_sub(a.as_u16x16(), b.as_u16x16())) 3359 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3369:1 | 3369 | / pub unsafe fn _mm256_subs_epu8(a: __m256i, b: __m256i) -> __m256i { 3370 | | transmute(simd_saturating_sub(a.as_u8x32(), b.as_u8x32())) 3371 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3416:1 | 3416 | / pub unsafe fn _mm256_unpackhi_epi8(a: __m256i, b: __m256i) -> __m256i { 3417 | | #[rustfmt::skip] 3418 | | let r: i8x32 = simd_shuffle32(a.as_i8x32(), b.as_i8x32(), [ 3419 | | 8, 40, 9, 41, 10, 42, 11, 43, ... | 3424 | | transmute(r) 3425 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3469:1 | 3469 | / pub unsafe fn _mm256_unpacklo_epi8(a: __m256i, b: __m256i) -> __m256i { 3470 | | #[rustfmt::skip] 3471 | | let r: i8x32 = simd_shuffle32(a.as_i8x32(), b.as_i8x32(), [ 3472 | | 0, 32, 1, 33, 2, 34, 3, 35, ... | 3477 | | transmute(r) 3478 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3518:1 | 3518 | / pub unsafe fn _mm256_unpackhi_epi16(a: __m256i, b: __m256i) -> __m256i { 3519 | | let r: i16x16 = simd_shuffle16( 3520 | | a.as_i16x16(), 3521 | | b.as_i16x16(), ... | 3524 | | transmute(r) 3525 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3566:1 | 3566 | / pub unsafe fn _mm256_unpacklo_epi16(a: __m256i, b: __m256i) -> __m256i { 3567 | | let r: i16x16 = simd_shuffle16( 3568 | | a.as_i16x16(), 3569 | | b.as_i16x16(), ... | 3572 | | transmute(r) 3573 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3607:1 | 3607 | / pub unsafe fn _mm256_unpackhi_epi32(a: __m256i, b: __m256i) -> __m256i { 3608 | | let r: i32x8 = simd_shuffle8(a.as_i32x8(), b.as_i32x8(), [2, 10, 3, 11, 6, 14, 7, 15]); 3609 | | transmute(r) 3610 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3644:1 | 3644 | / pub unsafe fn _mm256_unpacklo_epi32(a: __m256i, b: __m256i) -> __m256i { 3645 | | let r: i32x8 = simd_shuffle8(a.as_i32x8(), b.as_i32x8(), [0, 8, 1, 9, 4, 12, 5, 13]); 3646 | | transmute(r) 3647 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3681:1 | 3681 | / pub unsafe fn _mm256_unpackhi_epi64(a: __m256i, b: __m256i) -> __m256i { 3682 | | let r: i64x4 = simd_shuffle4(a.as_i64x4(), b.as_i64x4(), [1, 5, 3, 7]); 3683 | | transmute(r) 3684 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3718:1 | 3718 | / pub unsafe fn _mm256_unpacklo_epi64(a: __m256i, b: __m256i) -> __m256i { 3719 | | let r: i64x4 = simd_shuffle4(a.as_i64x4(), b.as_i64x4(), [0, 4, 2, 6]); 3720 | | transmute(r) 3721 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3731:1 | 3731 | / pub unsafe fn _mm256_xor_si256(a: __m256i, b: __m256i) -> __m256i { 3732 | | transmute(simd_xor(a.as_i64x4(), b.as_i64x4())) 3733 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3746:1 | 3746 | / pub unsafe fn _mm256_extract_epi8(a: __m256i, imm8: i32) -> i32 { 3747 | | let a = a.as_u8x32(); 3748 | | macro_rules! call { 3749 | | ($imm5:expr) => { ... | 3753 | | constify_imm5!(imm8, call) 3754 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3767:1 | 3767 | / pub unsafe fn _mm256_extract_epi16(a: __m256i, imm8: i32) -> i32 { 3768 | | let a = a.as_u16x16(); 3769 | | macro_rules! call { 3770 | | ($imm4:expr) => { ... | 3774 | | constify_imm4!((imm8 & 15), call) 3775 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3785:1 | 3785 | / pub unsafe fn _mm256_extract_epi32(a: __m256i, imm8: i32) -> i32 { 3786 | | let a = a.as_i32x8(); 3787 | | macro_rules! call { 3788 | | ($imm3:expr) => { ... | 3792 | | constify_imm3!((imm8 & 7), call) 3793 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3802:1 | 3802 | / pub unsafe fn _mm256_cvtsd_f64(a: __m256d) -> f64 { 3803 | | simd_extract(a, 0) 3804 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx2.rs:3813:1 | 3813 | / pub unsafe fn _mm256_cvtsi256_si32(a: __m256i) -> i32 { 3814 | | simd_extract(a.as_i32x8(), 0) 3815 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:35:1 | 35 | / pub unsafe fn _mm_fmadd_pd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 36 | | simd_fma(a, b, c) 37 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:47:1 | 47 | / pub unsafe fn _mm256_fmadd_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 48 | | simd_fma(a, b, c) 49 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:59:1 | 59 | / pub unsafe fn _mm_fmadd_ps(a: __m128, b: __m128, c: __m128) -> __m128 { 60 | | simd_fma(a, b, c) 61 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:71:1 | 71 | / pub unsafe fn _mm256_fmadd_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 72 | | simd_fma(a, b, c) 73 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:85:1 | 85 | / pub unsafe fn _mm_fmadd_sd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 86 | | vfmaddsd(a, b, c) 87 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:99:1 | 99 | / pub unsafe fn _mm_fmadd_ss(a: __m128, b: __m128, c: __m128) -> __m128 { 100 | | vfmaddss(a, b, c) 101 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:112:1 | 112 | / pub unsafe fn _mm_fmaddsub_pd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 113 | | vfmaddsubpd(a, b, c) 114 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:125:1 | 125 | / pub unsafe fn _mm256_fmaddsub_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 126 | | vfmaddsubpd256(a, b, c) 127 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:138:1 | 138 | / pub unsafe fn _mm_fmaddsub_ps(a: __m128, b: __m128, c: __m128) -> __m128 { 139 | | vfmaddsubps(a, b, c) 140 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:151:1 | 151 | / pub unsafe fn _mm256_fmaddsub_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 152 | | vfmaddsubps256(a, b, c) 153 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:163:1 | 163 | / pub unsafe fn _mm_fmsub_pd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 164 | | vfmsubpd(a, b, c) 165 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:175:1 | 175 | / pub unsafe fn _mm256_fmsub_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 176 | | vfmsubpd256(a, b, c) 177 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:187:1 | 187 | / pub unsafe fn _mm_fmsub_ps(a: __m128, b: __m128, c: __m128) -> __m128 { 188 | | vfmsubps(a, b, c) 189 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:199:1 | 199 | / pub unsafe fn _mm256_fmsub_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 200 | | vfmsubps256(a, b, c) 201 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:213:1 | 213 | / pub unsafe fn _mm_fmsub_sd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 214 | | vfmsubsd(a, b, c) 215 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:227:1 | 227 | / pub unsafe fn _mm_fmsub_ss(a: __m128, b: __m128, c: __m128) -> __m128 { 228 | | vfmsubss(a, b, c) 229 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:240:1 | 240 | / pub unsafe fn _mm_fmsubadd_pd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 241 | | vfmsubaddpd(a, b, c) 242 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:253:1 | 253 | / pub unsafe fn _mm256_fmsubadd_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 254 | | vfmsubaddpd256(a, b, c) 255 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:266:1 | 266 | / pub unsafe fn _mm_fmsubadd_ps(a: __m128, b: __m128, c: __m128) -> __m128 { 267 | | vfmsubaddps(a, b, c) 268 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:279:1 | 279 | / pub unsafe fn _mm256_fmsubadd_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 280 | | vfmsubaddps256(a, b, c) 281 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:291:1 | 291 | / pub unsafe fn _mm_fnmadd_pd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 292 | | vfnmaddpd(a, b, c) 293 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:303:1 | 303 | / pub unsafe fn _mm256_fnmadd_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 304 | | vfnmaddpd256(a, b, c) 305 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:315:1 | 315 | / pub unsafe fn _mm_fnmadd_ps(a: __m128, b: __m128, c: __m128) -> __m128 { 316 | | vfnmaddps(a, b, c) 317 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:327:1 | 327 | / pub unsafe fn _mm256_fnmadd_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 328 | | vfnmaddps256(a, b, c) 329 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:341:1 | 341 | / pub unsafe fn _mm_fnmadd_sd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 342 | | vfnmaddsd(a, b, c) 343 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:355:1 | 355 | / pub unsafe fn _mm_fnmadd_ss(a: __m128, b: __m128, c: __m128) -> __m128 { 356 | | vfnmaddss(a, b, c) 357 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:368:1 | 368 | / pub unsafe fn _mm_fnmsub_pd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 369 | | vfnmsubpd(a, b, c) 370 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:381:1 | 381 | / pub unsafe fn _mm256_fnmsub_pd(a: __m256d, b: __m256d, c: __m256d) -> __m256d { 382 | | vfnmsubpd256(a, b, c) 383 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:394:1 | 394 | / pub unsafe fn _mm_fnmsub_ps(a: __m128, b: __m128, c: __m128) -> __m128 { 395 | | vfnmsubps(a, b, c) 396 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:407:1 | 407 | / pub unsafe fn _mm256_fnmsub_ps(a: __m256, b: __m256, c: __m256) -> __m256 { 408 | | vfnmsubps256(a, b, c) 409 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:422:1 | 422 | / pub unsafe fn _mm_fnmsub_sd(a: __m128d, b: __m128d, c: __m128d) -> __m128d { 423 | | vfnmsubsd(a, b, c) 424 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/fma.rs:437:1 | 437 | / pub unsafe fn _mm_fnmsub_ss(a: __m128, b: __m128, c: __m128) -> __m128 { 438 | | vfnmsubss(a, b, c) 439 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/abm.rs:32:1 | 32 | / pub unsafe fn _lzcnt_u32(x: u32) -> u32 { 33 | | x.leading_zeros() 34 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/abm.rs:43:1 | 43 | / pub unsafe fn _popcnt32(x: i32) -> i32 { 44 | | x.count_ones() as i32 45 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:23:1 | 23 | / pub unsafe fn _bextr_u32(a: u32, start: u32, len: u32) -> u32 { 24 | | _bextr2_u32(a, (start & 0xff_u32) | ((len & 0xff_u32) << 8_u32)) 25 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:38:1 | 38 | / pub unsafe fn _bextr2_u32(a: u32, control: u32) -> u32 { 39 | | x86_bmi_bextr_32(a, control) 40 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:49:1 | 49 | / pub unsafe fn _andn_u32(a: u32, b: u32) -> u32 { 50 | | !a & b 51 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:60:1 | 60 | / pub unsafe fn _blsi_u32(x: u32) -> u32 { 61 | | x & x.wrapping_neg() 62 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:71:1 | 71 | / pub unsafe fn _blsmsk_u32(x: u32) -> u32 { 72 | | x ^ (x.wrapping_sub(1_u32)) 73 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:84:1 | 84 | / pub unsafe fn _blsr_u32(x: u32) -> u32 { 85 | | x & (x.wrapping_sub(1)) 86 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:97:1 | 97 | / pub unsafe fn _tzcnt_u32(x: u32) -> u32 { 98 | | x.trailing_zeros() 99 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi1.rs:110:1 | 110 | / pub unsafe fn _mm_tzcnt_32(x: u32) -> i32 { 111 | | x.trailing_zeros() as i32 112 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi2.rs:28:1 | 28 | / pub unsafe fn _mulx_u32(a: u32, b: u32, hi: &mut u32) -> u32 { 29 | | let result: u64 = (a as u64) * (b as u64); 30 | | *hi = (result >> 32) as u32; 31 | | result as u32 32 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi2.rs:41:1 | 41 | / pub unsafe fn _bzhi_u32(a: u32, index: u32) -> u32 { 42 | | x86_bmi2_bzhi_32(a, index) 43 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi2.rs:53:1 | 53 | / pub unsafe fn _pdep_u32(a: u32, mask: u32) -> u32 { 54 | | x86_bmi2_pdep_32(a, mask) 55 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bmi2.rs:65:1 | 65 | / pub unsafe fn _pext_u32(a: u32, mask: u32) -> u32 { 66 | | x86_bmi2_pext_32(a, mask) 67 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse4a.rs:41:1 | 41 | / pub unsafe fn _mm_extract_si64(x: __m128i, y: __m128i) -> __m128i { 42 | | transmute(extrq(x.as_i64x2(), y.as_i8x16())) 43 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse4a.rs:58:1 | 58 | / pub unsafe fn _mm_insert_si64(x: __m128i, y: __m128i) -> __m128i { 59 | | transmute(insertq(x.as_i64x2(), y.as_i64x2())) 60 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse4a.rs:69:1 | 69 | / pub unsafe fn _mm_stream_sd(p: *mut f64, a: __m128d) { 70 | | movntsd(p, a); 71 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sse4a.rs:80:1 | 80 | / pub unsafe fn _mm_stream_ss(p: *mut f32, a: __m128) { 81 | | movntss(p, a); 82 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:74:1 | 74 | / pub unsafe fn _blcfill_u32(x: u32) -> u32 { 75 | | x & (x.wrapping_add(1)) 76 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:86:1 | 86 | / pub unsafe fn _blcfill_u64(x: u64) -> u64 { 87 | | x & (x.wrapping_add(1)) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:97:1 | 97 | / pub unsafe fn _blci_u32(x: u32) -> u32 { 98 | | x | !(x.wrapping_add(1)) 99 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:109:1 | 109 | / pub unsafe fn _blci_u64(x: u64) -> u64 { 110 | | x | !(x.wrapping_add(1)) 111 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:120:1 | 120 | / pub unsafe fn _blcic_u32(x: u32) -> u32 { 121 | | !x & (x.wrapping_add(1)) 122 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:132:1 | 132 | / pub unsafe fn _blcic_u64(x: u64) -> u64 { 133 | | !x & (x.wrapping_add(1)) 134 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:144:1 | 144 | / pub unsafe fn _blcmsk_u32(x: u32) -> u32 { 145 | | x ^ (x.wrapping_add(1)) 146 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:157:1 | 157 | / pub unsafe fn _blcmsk_u64(x: u64) -> u64 { 158 | | x ^ (x.wrapping_add(1)) 159 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:168:1 | 168 | / pub unsafe fn _blcs_u32(x: u32) -> u32 { 169 | | x | (x.wrapping_add(1)) 170 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:180:1 | 180 | / pub unsafe fn _blcs_u64(x: u64) -> u64 { 181 | | x | x.wrapping_add(1) 182 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:191:1 | 191 | / pub unsafe fn _blsfill_u32(x: u32) -> u32 { 192 | | x | (x.wrapping_sub(1)) 193 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:203:1 | 203 | / pub unsafe fn _blsfill_u64(x: u64) -> u64 { 204 | | x | (x.wrapping_sub(1)) 205 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:214:1 | 214 | / pub unsafe fn _blsic_u32(x: u32) -> u32 { 215 | | !x | (x.wrapping_sub(1)) 216 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:226:1 | 226 | / pub unsafe fn _blsic_u64(x: u64) -> u64 { 227 | | !x | (x.wrapping_sub(1)) 228 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:238:1 | 238 | / pub unsafe fn _t1mskc_u32(x: u32) -> u32 { 239 | | !x | (x.wrapping_add(1)) 240 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:251:1 | 251 | / pub unsafe fn _t1mskc_u64(x: u64) -> u64 { 252 | | !x | (x.wrapping_add(1)) 253 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:263:1 | 263 | / pub unsafe fn _tzmsk_u32(x: u32) -> u32 { 264 | | !x & (x.wrapping_sub(1)) 265 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/tbm.rs:276:1 | 276 | / pub unsafe fn _tzmsk_u64(x: u64) -> u64 { 277 | | !x & (x.wrapping_sub(1)) 278 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/pclmulqdq.rs:35:1 | 35 | / pub unsafe fn _mm_clmulepi64_si128(a: __m128i, b: __m128i, imm8: i32) -> __m128i { 36 | | macro_rules! call { 37 | | ($imm8:expr) => { 38 | | pclmulqdq(a, b, $imm8) ... | 41 | | constify_imm8!(imm8, call) 42 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/aes.rs:38:1 | 38 | / pub unsafe fn _mm_aesdec_si128(a: __m128i, round_key: __m128i) -> __m128i { 39 | | aesdec(a, round_key) 40 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/aes.rs:49:1 | 49 | / pub unsafe fn _mm_aesdeclast_si128(a: __m128i, round_key: __m128i) -> __m128i { 50 | | aesdeclast(a, round_key) 51 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/aes.rs:60:1 | 60 | / pub unsafe fn _mm_aesenc_si128(a: __m128i, round_key: __m128i) -> __m128i { 61 | | aesenc(a, round_key) 62 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/aes.rs:71:1 | 71 | / pub unsafe fn _mm_aesenclast_si128(a: __m128i, round_key: __m128i) -> __m128i { 72 | | aesenclast(a, round_key) 73 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/aes.rs:82:1 | 82 | / pub unsafe fn _mm_aesimc_si128(a: __m128i) -> __m128i { 83 | | aesimc(a) 84 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/aes.rs:98:1 | 98 | / pub unsafe fn _mm_aeskeygenassist_si128(a: __m128i, imm8: i32) -> __m128i { 99 | | macro_rules! call { 100 | | ($imm8:expr) => { 101 | | aeskeygenassist(a, $imm8) ... | 104 | | constify_imm8!(imm8, call) 105 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rdrand.rs:29:1 | 29 | / pub unsafe fn _rdrand16_step(val: &mut u16) -> i32 { 30 | | let (v, flag) = x86_rdrand16_step(); 31 | | *val = v; 32 | | flag 33 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rdrand.rs:43:1 | 43 | / pub unsafe fn _rdrand32_step(val: &mut u32) -> i32 { 44 | | let (v, flag) = x86_rdrand32_step(); 45 | | *val = v; 46 | | flag 47 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rdrand.rs:57:1 | 57 | / pub unsafe fn _rdseed16_step(val: &mut u16) -> i32 { 58 | | let (v, flag) = x86_rdseed16_step(); 59 | | *val = v; 60 | | flag 61 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rdrand.rs:71:1 | 71 | / pub unsafe fn _rdseed32_step(val: &mut u32) -> i32 { 72 | | let (v, flag) = x86_rdseed32_step(); 73 | | *val = v; 74 | | flag 75 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:36:1 | 36 | / pub unsafe fn _mm_sha1msg1_epu32(a: __m128i, b: __m128i) -> __m128i { 37 | | transmute(sha1msg1(a.as_i32x4(), b.as_i32x4())) 38 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:49:1 | 49 | / pub unsafe fn _mm_sha1msg2_epu32(a: __m128i, b: __m128i) -> __m128i { 50 | | transmute(sha1msg2(a.as_i32x4(), b.as_i32x4())) 51 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:62:1 | 62 | / pub unsafe fn _mm_sha1nexte_epu32(a: __m128i, b: __m128i) -> __m128i { 63 | | transmute(sha1nexte(a.as_i32x4(), b.as_i32x4())) 64 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:78:1 | 78 | / pub unsafe fn _mm_sha1rnds4_epu32(a: __m128i, b: __m128i, func: i32) -> __m128i { 79 | | let a = a.as_i32x4(); 80 | | let b = b.as_i32x4(); 81 | | macro_rules! call { ... | 87 | | transmute(ret) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:99:1 | 99 | / pub unsafe fn _mm_sha256msg1_epu32(a: __m128i, b: __m128i) -> __m128i { 100 | | transmute(sha256msg1(a.as_i32x4(), b.as_i32x4())) 101 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:112:1 | 112 | / pub unsafe fn _mm_sha256msg2_epu32(a: __m128i, b: __m128i) -> __m128i { 113 | | transmute(sha256msg2(a.as_i32x4(), b.as_i32x4())) 114 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/sha.rs:127:1 | 127 | / pub unsafe fn _mm_sha256rnds2_epu32(a: __m128i, b: __m128i, k: __m128i) -> __m128i { 128 | | transmute(sha256rnds2(a.as_i32x4(), b.as_i32x4(), k.as_i32x4())) 129 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/adx.rs:20:1 | 20 | / pub unsafe fn _addcarry_u32(c_in: u8, a: u32, b: u32, out: &mut u32) -> u8 { 21 | | let (a, b) = llvm_addcarry_u32(c_in, a, b); 22 | | *out = b; 23 | | a 24 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/adx.rs:33:1 | 33 | / pub unsafe fn _addcarryx_u32(c_in: u8, a: u32, b: u32, out: &mut u32) -> u8 { 34 | | llvm_addcarryx_u32(c_in, a, b, out as *mut _ as *mut u8) 35 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/adx.rs:43:1 | 43 | / pub unsafe fn _subborrow_u32(c_in: u8, a: u32, b: u32, out: &mut u32) -> u8 { 44 | | let (a, b) = llvm_subborrow_u32(c_in, a, b); 45 | | *out = b; 46 | | a 47 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/mod.rs:616:1 | 616 | / pub unsafe fn ud2() -> ! { 617 | | intrinsics::abort() 618 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:16:1 | 16 | / pub unsafe fn _mm512_abs_epi32(a: __m512i) -> __m512i { 17 | | let a = a.as_i32x16(); 18 | | // all-0 is a properly initialized i32x16 19 | | let zero: i32x16 = mem::zeroed(); ... | 22 | | transmute(simd_select(cmp, a, sub)) 23 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:33:1 | 33 | / pub unsafe fn _mm512_mask_abs_epi32(src: __m512i, k: __mmask16, a: __m512i) -> __m512i { 34 | | let abs = _mm512_abs_epi32(a).as_i32x16(); 35 | | transmute(simd_select_bitmask(k, abs, src.as_i32x16())) 36 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:46:1 | 46 | / pub unsafe fn _mm512_maskz_abs_epi32(k: __mmask16, a: __m512i) -> __m512i { 47 | | let abs = _mm512_abs_epi32(a).as_i32x16(); 48 | | let zero = _mm512_setzero_si512().as_i32x16(); 49 | | transmute(simd_select_bitmask(k, abs, zero)) 50 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:58:1 | 58 | / pub unsafe fn _mm512_abs_epi64(a: __m512i) -> __m512i { 59 | | let a = a.as_i64x8(); 60 | | // all-0 is a properly initialized i64x8 61 | | let zero: i64x8 = mem::zeroed(); ... | 64 | | transmute(simd_select(cmp, a, sub)) 65 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:73:1 | 73 | / pub unsafe fn _mm512_mask_abs_epi64(src: __m512i, k: __mmask8, a: __m512i) -> __m512i { 74 | | let abs = _mm512_abs_epi64(a).as_i64x8(); 75 | | transmute(simd_select_bitmask(k, abs, src.as_i64x8())) 76 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:84:1 | 84 | / pub unsafe fn _mm512_maskz_abs_epi64(k: __mmask8, a: __m512i) -> __m512i { 85 | | let abs = _mm512_abs_epi64(a).as_i64x8(); 86 | | let zero = _mm512_setzero_si512().as_i64x8(); 87 | | transmute(simd_select_bitmask(k, abs, zero)) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:96:1 | 96 | / pub unsafe fn _mm512_abs_ps(v2: __m512) -> __m512 { 97 | | let a = _mm512_set1_epi32(0x7FFFFFFF); // from LLVM code 98 | | let b = transmute::(v2.as_f32x16()); 99 | | let abs = _mm512_and_epi32(a, b); 100 | | transmute(abs) 101 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:109:1 | 109 | / pub unsafe fn _mm512_mask_abs_ps(src: __m512, k: __mmask16, v2: __m512) -> __m512 { 110 | | let abs = _mm512_abs_ps(v2).as_f32x16(); 111 | | transmute(simd_select_bitmask(k, abs, src.as_f32x16())) 112 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:120:1 | 120 | / pub unsafe fn _mm512_abs_pd(v2: __m512d) -> __m512d { 121 | | let a = _mm512_set1_epi64(0x7FFFFFFFFFFFFFFF); // from LLVM code 122 | | let b = transmute::(v2.as_f64x8()); 123 | | let abs = _mm512_and_epi64(a, b); 124 | | transmute(abs) 125 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:133:1 | 133 | / pub unsafe fn _mm512_mask_abs_pd(src: __m512d, k: __mmask8, v2: __m512d) -> __m512d { 134 | | let abs = _mm512_abs_pd(v2).as_f64x8(); 135 | | transmute(simd_select_bitmask(k, abs, src.as_f64x8())) 136 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:144:1 | 144 | / pub unsafe fn _mm512_add_epi32(a: __m512i, b: __m512i) -> __m512i { 145 | | transmute(simd_add(a.as_i32x16(), b.as_i32x16())) 146 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:154:1 | 154 | / pub unsafe fn _mm512_mask_add_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 155 | | let add = _mm512_add_epi32(a, b).as_i32x16(); 156 | | transmute(simd_select_bitmask(k, add, src.as_i32x16())) 157 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:165:1 | 165 | / pub unsafe fn _mm512_maskz_add_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 166 | | let add = _mm512_add_epi32(a, b).as_i32x16(); 167 | | let zero = _mm512_setzero_si512().as_i32x16(); 168 | | transmute(simd_select_bitmask(k, add, zero)) 169 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:177:1 | 177 | / pub unsafe fn _mm512_add_epi64(a: __m512i, b: __m512i) -> __m512i { 178 | | transmute(simd_add(a.as_i64x8(), b.as_i64x8())) 179 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:187:1 | 187 | / pub unsafe fn _mm512_mask_add_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 188 | | let add = _mm512_add_epi64(a, b).as_i64x8(); 189 | | transmute(simd_select_bitmask(k, add, src.as_i64x8())) 190 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:198:1 | 198 | / pub unsafe fn _mm512_maskz_add_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 199 | | let add = _mm512_add_epi64(a, b).as_i64x8(); 200 | | let zero = _mm512_setzero_si512().as_i64x8(); 201 | | transmute(simd_select_bitmask(k, add, zero)) 202 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:210:1 | 210 | / pub unsafe fn _mm512_add_ps(a: __m512, b: __m512) -> __m512 { 211 | | transmute(simd_add(a.as_f32x16(), b.as_f32x16())) 212 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:220:1 | 220 | / pub unsafe fn _mm512_mask_add_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 221 | | let add = _mm512_add_ps(a, b).as_f32x16(); 222 | | transmute(simd_select_bitmask(k, add, src.as_f32x16())) 223 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:231:1 | 231 | / pub unsafe fn _mm512_maskz_add_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 232 | | let add = _mm512_add_ps(a, b).as_f32x16(); 233 | | let zero = _mm512_setzero_ps().as_f32x16(); 234 | | transmute(simd_select_bitmask(k, add, zero)) 235 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:243:1 | 243 | / pub unsafe fn _mm512_add_pd(a: __m512d, b: __m512d) -> __m512d { 244 | | transmute(simd_add(a.as_f64x8(), b.as_f64x8())) 245 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:253:1 | 253 | / pub unsafe fn _mm512_mask_add_pd(src: __m512d, k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 254 | | let add = _mm512_add_pd(a, b).as_f64x8(); 255 | | transmute(simd_select_bitmask(k, add, src.as_f64x8())) 256 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:264:1 | 264 | / pub unsafe fn _mm512_maskz_add_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 265 | | let add = _mm512_add_pd(a, b).as_f64x8(); 266 | | let zero = _mm512_setzero_pd().as_f64x8(); 267 | | transmute(simd_select_bitmask(k, add, zero)) 268 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:276:1 | 276 | / pub unsafe fn _mm512_sub_epi32(a: __m512i, b: __m512i) -> __m512i { 277 | | transmute(simd_sub(a.as_i32x16(), b.as_i32x16())) 278 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:286:1 | 286 | / pub unsafe fn _mm512_mask_sub_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 287 | | let sub = _mm512_sub_epi32(a, b).as_i32x16(); 288 | | transmute(simd_select_bitmask(k, sub, src.as_i32x16())) 289 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:297:1 | 297 | / pub unsafe fn _mm512_maskz_sub_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 298 | | let sub = _mm512_sub_epi32(a, b).as_i32x16(); 299 | | let zero = _mm512_setzero_si512().as_i32x16(); 300 | | transmute(simd_select_bitmask(k, sub, zero)) 301 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:309:1 | 309 | / pub unsafe fn _mm512_sub_epi64(a: __m512i, b: __m512i) -> __m512i { 310 | | transmute(simd_sub(a.as_i64x8(), b.as_i64x8())) 311 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:319:1 | 319 | / pub unsafe fn _mm512_mask_sub_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 320 | | let sub = _mm512_sub_epi64(a, b).as_i64x8(); 321 | | transmute(simd_select_bitmask(k, sub, src.as_i64x8())) 322 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:330:1 | 330 | / pub unsafe fn _mm512_maskz_sub_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 331 | | let add = _mm512_sub_epi64(a, b).as_i64x8(); 332 | | let zero = _mm512_setzero_si512().as_i64x8(); 333 | | transmute(simd_select_bitmask(k, add, zero)) 334 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:342:1 | 342 | / pub unsafe fn _mm512_sub_ps(a: __m512, b: __m512) -> __m512 { 343 | | transmute(simd_sub(a.as_f32x16(), b.as_f32x16())) 344 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:352:1 | 352 | / pub unsafe fn _mm512_mask_sub_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 353 | | let sub = _mm512_sub_ps(a, b).as_f32x16(); 354 | | transmute(simd_select_bitmask(k, sub, src.as_f32x16())) 355 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:363:1 | 363 | / pub unsafe fn _mm512_maskz_sub_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 364 | | let sub = _mm512_sub_ps(a, b).as_f32x16(); 365 | | let zero = _mm512_setzero_ps().as_f32x16(); 366 | | transmute(simd_select_bitmask(k, sub, zero)) 367 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:375:1 | 375 | / pub unsafe fn _mm512_sub_pd(a: __m512d, b: __m512d) -> __m512d { 376 | | transmute(simd_sub(a.as_f64x8(), b.as_f64x8())) 377 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:385:1 | 385 | / pub unsafe fn _mm512_mask_sub_pd(src: __m512d, k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 386 | | let sub = _mm512_sub_pd(a, b).as_f64x8(); 387 | | transmute(simd_select_bitmask(k, sub, src.as_f64x8())) 388 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:396:1 | 396 | / pub unsafe fn _mm512_maskz_sub_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 397 | | let sub = _mm512_sub_pd(a, b).as_f64x8(); 398 | | let zero = _mm512_setzero_pd().as_f64x8(); 399 | | transmute(simd_select_bitmask(k, sub, zero)) 400 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:408:1 | 408 | / pub unsafe fn _mm512_mul_epi32(a: __m512i, b: __m512i) -> __m512i { 409 | | transmute(vpmuldq(a.as_i32x16(), b.as_i32x16())) 410 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:418:1 | 418 | / pub unsafe fn _mm512_mask_mul_epi32(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 419 | | let mul = _mm512_mul_epi32(a, b).as_i64x8(); 420 | | transmute(simd_select_bitmask(k, mul, src.as_i64x8())) 421 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:429:1 | 429 | / pub unsafe fn _mm512_maskz_mul_epi32(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 430 | | let mul = _mm512_mul_epi32(a, b).as_i64x8(); 431 | | let zero = _mm512_setzero_si512().as_i64x8(); 432 | | transmute(simd_select_bitmask(k, mul, zero)) 433 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:441:1 | 441 | / pub unsafe fn _mm512_mullo_epi32(a: __m512i, b: __m512i) -> __m512i { 442 | | transmute(simd_mul(a.as_i32x16(), b.as_i32x16())) 443 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:451:1 | 451 | / pub unsafe fn _mm512_mask_mullo_epi32( 452 | | src: __m512i, 453 | | k: __mmask16, 454 | | a: __m512i, ... | 458 | | transmute(simd_select_bitmask(k, mul, src.as_i32x16())) 459 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:467:1 | 467 | / pub unsafe fn _mm512_maskz_mullo_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 468 | | let mul = _mm512_mullo_epi32(a, b).as_i32x16(); 469 | | let zero = _mm512_setzero_si512().as_i32x16(); 470 | | transmute(simd_select_bitmask(k, mul, zero)) 471 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:480:1 | 480 | / pub unsafe fn _mm512_mullox_epi64(a: __m512i, b: __m512i) -> __m512i { 481 | | transmute(simd_mul(a.as_i64x8(), b.as_i64x8())) 482 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:491:1 | 491 | / pub unsafe fn _mm512_mask_mullox_epi64( 492 | | src: __m512i, 493 | | k: __mmask8, 494 | | a: __m512i, ... | 498 | | transmute(simd_select_bitmask(k, mul, src.as_i64x8())) 499 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:507:1 | 507 | / pub unsafe fn _mm512_mul_epu32(a: __m512i, b: __m512i) -> __m512i { 508 | | transmute(vpmuludq(a.as_u32x16(), b.as_u32x16())) 509 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:517:1 | 517 | / pub unsafe fn _mm512_mask_mul_epu32(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 518 | | let mul = _mm512_mul_epu32(a, b).as_u64x8(); 519 | | transmute(simd_select_bitmask(k, mul, src.as_u64x8())) 520 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:528:1 | 528 | / pub unsafe fn _mm512_maskz_mul_epu32(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 529 | | let mul = _mm512_mul_epu32(a, b).as_u64x8(); 530 | | let zero = _mm512_setzero_si512().as_u64x8(); 531 | | transmute(simd_select_bitmask(k, mul, zero)) 532 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:540:1 | 540 | / pub unsafe fn _mm512_mul_ps(a: __m512, b: __m512) -> __m512 { 541 | | transmute(simd_mul(a.as_f32x16(), b.as_f32x16())) 542 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:550:1 | 550 | / pub unsafe fn _mm512_mask_mul_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 551 | | let mul = _mm512_mul_ps(a, b).as_f32x16(); 552 | | transmute(simd_select_bitmask(k, mul, src.as_f32x16())) 553 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:561:1 | 561 | / pub unsafe fn _mm512_maskz_mul_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 562 | | let mul = _mm512_mul_ps(a, b).as_f32x16(); 563 | | let zero = _mm512_setzero_ps().as_f32x16(); 564 | | transmute(simd_select_bitmask(k, mul, zero)) 565 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:573:1 | 573 | / pub unsafe fn _mm512_mul_pd(a: __m512d, b: __m512d) -> __m512d { 574 | | transmute(simd_mul(a.as_f64x8(), b.as_f64x8())) 575 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:583:1 | 583 | / pub unsafe fn _mm512_mask_mul_pd(src: __m512d, k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 584 | | let mul = _mm512_mul_pd(a, b).as_f64x8(); 585 | | transmute(simd_select_bitmask(k, mul, src.as_f64x8())) 586 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:594:1 | 594 | / pub unsafe fn _mm512_maskz_mul_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 595 | | let mul = _mm512_mul_pd(a, b).as_f64x8(); 596 | | let zero = _mm512_setzero_pd().as_f64x8(); 597 | | transmute(simd_select_bitmask(k, mul, zero)) 598 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:606:1 | 606 | / pub unsafe fn _mm512_div_ps(a: __m512, b: __m512) -> __m512 { 607 | | transmute(simd_div(a.as_f32x16(), b.as_f32x16())) 608 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:616:1 | 616 | / pub unsafe fn _mm512_mask_div_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 617 | | let div = _mm512_div_ps(a, b).as_f32x16(); 618 | | transmute(simd_select_bitmask(k, div, src.as_f32x16())) 619 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:627:1 | 627 | / pub unsafe fn _mm512_maskz_div_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 628 | | let div = _mm512_div_ps(a, b).as_f32x16(); 629 | | let zero = _mm512_setzero_ps().as_f32x16(); 630 | | transmute(simd_select_bitmask(k, div, zero)) 631 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:639:1 | 639 | / pub unsafe fn _mm512_div_pd(a: __m512d, b: __m512d) -> __m512d { 640 | | transmute(simd_div(a.as_f64x8(), b.as_f64x8())) 641 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:649:1 | 649 | / pub unsafe fn _mm512_mask_div_pd(src: __m512d, k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 650 | | let div = _mm512_div_pd(a, b).as_f64x8(); 651 | | transmute(simd_select_bitmask(k, div, src.as_f64x8())) 652 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:660:1 | 660 | / pub unsafe fn _mm512_maskz_div_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 661 | | let div = _mm512_div_pd(a, b).as_f64x8(); 662 | | let zero = _mm512_setzero_pd().as_f64x8(); 663 | | transmute(simd_select_bitmask(k, div, zero)) 664 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:672:1 | 672 | / pub unsafe fn _mm512_max_epi32(a: __m512i, b: __m512i) -> __m512i { 673 | | transmute(vpmaxsd(a.as_i32x16(), b.as_i32x16())) 674 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:682:1 | 682 | / pub unsafe fn _mm512_mask_max_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 683 | | let max = _mm512_max_epi32(a, b).as_i32x16(); 684 | | transmute(simd_select_bitmask(k, max, src.as_i32x16())) 685 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:693:1 | 693 | / pub unsafe fn _mm512_maskz_max_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 694 | | let max = _mm512_max_epi32(a, b).as_i32x16(); 695 | | let zero = _mm512_setzero_si512().as_i32x16(); 696 | | transmute(simd_select_bitmask(k, max, zero)) 697 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:705:1 | 705 | / pub unsafe fn _mm512_max_epi64(a: __m512i, b: __m512i) -> __m512i { 706 | | transmute(vpmaxsq(a.as_i64x8(), b.as_i64x8())) 707 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:715:1 | 715 | / pub unsafe fn _mm512_mask_max_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 716 | | let max = _mm512_max_epi64(a, b).as_i64x8(); 717 | | transmute(simd_select_bitmask(k, max, src.as_i64x8())) 718 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:726:1 | 726 | / pub unsafe fn _mm512_maskz_max_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 727 | | let max = _mm512_max_epi64(a, b).as_i64x8(); 728 | | let zero = _mm512_setzero_si512().as_i64x8(); 729 | | transmute(simd_select_bitmask(k, max, zero)) 730 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:738:1 | 738 | / pub unsafe fn _mm512_max_ps(a: __m512, b: __m512) -> __m512 { 739 | | transmute(vmaxps( 740 | | a.as_f32x16(), 741 | | b.as_f32x16(), 742 | | _MM_FROUND_CUR_DIRECTION, 743 | | )) 744 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:752:1 | 752 | / pub unsafe fn _mm512_mask_max_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 753 | | let max = _mm512_max_ps(a, b).as_f32x16(); 754 | | transmute(simd_select_bitmask(k, max, src.as_f32x16())) 755 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:763:1 | 763 | / pub unsafe fn _mm512_maskz_max_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 764 | | let max = _mm512_max_ps(a, b).as_f32x16(); 765 | | let zero = _mm512_setzero_ps().as_f32x16(); 766 | | transmute(simd_select_bitmask(k, max, zero)) 767 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:775:1 | 775 | / pub unsafe fn _mm512_max_pd(a: __m512d, b: __m512d) -> __m512d { 776 | | transmute(vmaxpd(a.as_f64x8(), b.as_f64x8(), _MM_FROUND_CUR_DIRECTION)) 777 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:785:1 | 785 | / pub unsafe fn _mm512_mask_max_pd(src: __m512d, k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 786 | | let max = _mm512_max_pd(a, b).as_f64x8(); 787 | | transmute(simd_select_bitmask(k, max, src.as_f64x8())) 788 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:796:1 | 796 | / pub unsafe fn _mm512_maskz_max_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 797 | | let max = _mm512_max_pd(a, b).as_f64x8(); 798 | | let zero = _mm512_setzero_pd().as_f64x8(); 799 | | transmute(simd_select_bitmask(k, max, zero)) 800 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:808:1 | 808 | / pub unsafe fn _mm512_max_epu32(a: __m512i, b: __m512i) -> __m512i { 809 | | transmute(vpmaxud(a.as_u32x16(), b.as_u32x16())) 810 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:818:1 | 818 | / pub unsafe fn _mm512_mask_max_epu32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 819 | | let max = _mm512_max_epu32(a, b).as_u32x16(); 820 | | transmute(simd_select_bitmask(k, max, src.as_u32x16())) 821 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:829:1 | 829 | / pub unsafe fn _mm512_maskz_max_epu32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 830 | | let max = _mm512_max_epu32(a, b).as_u32x16(); 831 | | let zero = _mm512_setzero_si512().as_u32x16(); 832 | | transmute(simd_select_bitmask(k, max, zero)) 833 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:841:1 | 841 | / pub unsafe fn _mm512_max_epu64(a: __m512i, b: __m512i) -> __m512i { 842 | | transmute(vpmaxuq(a.as_u64x8(), b.as_u64x8())) 843 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:851:1 | 851 | / pub unsafe fn _mm512_mask_max_epu64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 852 | | let max = _mm512_max_epu64(a, b).as_u64x8(); 853 | | transmute(simd_select_bitmask(k, max, src.as_u64x8())) 854 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:862:1 | 862 | / pub unsafe fn _mm512_maskz_max_epu64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 863 | | let max = _mm512_max_epu64(a, b).as_u64x8(); 864 | | let zero = _mm512_setzero_si512().as_u64x8(); 865 | | transmute(simd_select_bitmask(k, max, zero)) 866 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:874:1 | 874 | / pub unsafe fn _mm512_min_epi32(a: __m512i, b: __m512i) -> __m512i { 875 | | transmute(vpminsd(a.as_i32x16(), b.as_i32x16())) 876 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:884:1 | 884 | / pub unsafe fn _mm512_mask_min_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 885 | | let max = _mm512_min_epi32(a, b).as_i32x16(); 886 | | transmute(simd_select_bitmask(k, max, src.as_i32x16())) 887 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:895:1 | 895 | / pub unsafe fn _mm512_maskz_min_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 896 | | let max = _mm512_min_epi32(a, b).as_i32x16(); 897 | | let zero = _mm512_setzero_si512().as_i32x16(); 898 | | transmute(simd_select_bitmask(k, max, zero)) 899 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:907:1 | 907 | / pub unsafe fn _mm512_min_epi64(a: __m512i, b: __m512i) -> __m512i { 908 | | transmute(vpminsq(a.as_i64x8(), b.as_i64x8())) 909 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:917:1 | 917 | / pub unsafe fn _mm512_mask_min_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 918 | | let max = _mm512_min_epi64(a, b).as_i64x8(); 919 | | transmute(simd_select_bitmask(k, max, src.as_i64x8())) 920 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:928:1 | 928 | / pub unsafe fn _mm512_maskz_min_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 929 | | let max = _mm512_min_epi64(a, b).as_i64x8(); 930 | | let zero = _mm512_setzero_si512().as_i64x8(); 931 | | transmute(simd_select_bitmask(k, max, zero)) 932 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:940:1 | 940 | / pub unsafe fn _mm512_min_ps(a: __m512, b: __m512) -> __m512 { 941 | | transmute(vminps( 942 | | a.as_f32x16(), 943 | | b.as_f32x16(), 944 | | _MM_FROUND_CUR_DIRECTION, 945 | | )) 946 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:954:1 | 954 | / pub unsafe fn _mm512_mask_min_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 955 | | let max = _mm512_min_ps(a, b).as_f32x16(); 956 | | transmute(simd_select_bitmask(k, max, src.as_f32x16())) 957 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:965:1 | 965 | / pub unsafe fn _mm512_maskz_min_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 966 | | let max = _mm512_min_ps(a, b).as_f32x16(); 967 | | let zero = _mm512_setzero_ps().as_f32x16(); 968 | | transmute(simd_select_bitmask(k, max, zero)) 969 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:977:1 | 977 | / pub unsafe fn _mm512_min_pd(a: __m512d, b: __m512d) -> __m512d { 978 | | transmute(vminpd(a.as_f64x8(), b.as_f64x8(), _MM_FROUND_CUR_DIRECTION)) 979 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:987:1 | 987 | / pub unsafe fn _mm512_mask_min_pd(src: __m512d, k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 988 | | let max = _mm512_min_pd(a, b).as_f64x8(); 989 | | transmute(simd_select_bitmask(k, max, src.as_f64x8())) 990 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:998:1 | 998 | / pub unsafe fn _mm512_maskz_min_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 999 | | let max = _mm512_min_pd(a, b).as_f64x8(); 1000 | | let zero = _mm512_setzero_pd().as_f64x8(); 1001 | | transmute(simd_select_bitmask(k, max, zero)) 1002 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1010:1 | 1010 | / pub unsafe fn _mm512_min_epu32(a: __m512i, b: __m512i) -> __m512i { 1011 | | transmute(vpminud(a.as_u32x16(), b.as_u32x16())) 1012 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1020:1 | 1020 | / pub unsafe fn _mm512_mask_min_epu32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 1021 | | let max = _mm512_min_epu32(a, b).as_u32x16(); 1022 | | transmute(simd_select_bitmask(k, max, src.as_u32x16())) 1023 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1031:1 | 1031 | / pub unsafe fn _mm512_maskz_min_epu32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 1032 | | let max = _mm512_min_epu32(a, b).as_u32x16(); 1033 | | let zero = _mm512_setzero_si512().as_u32x16(); 1034 | | transmute(simd_select_bitmask(k, max, zero)) 1035 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1043:1 | 1043 | / pub unsafe fn _mm512_min_epu64(a: __m512i, b: __m512i) -> __m512i { 1044 | | transmute(vpminuq(a.as_u64x8(), b.as_u64x8())) 1045 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1053:1 | 1053 | / pub unsafe fn _mm512_mask_min_epu64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 1054 | | let max = _mm512_min_epu64(a, b).as_u64x8(); 1055 | | transmute(simd_select_bitmask(k, max, src.as_u64x8())) 1056 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1064:1 | 1064 | / pub unsafe fn _mm512_maskz_min_epu64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 1065 | | let max = _mm512_min_epu64(a, b).as_u64x8(); 1066 | | let zero = _mm512_setzero_si512().as_u64x8(); 1067 | | transmute(simd_select_bitmask(k, max, zero)) 1068 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1076:1 | 1076 | / pub unsafe fn _mm512_sqrt_ps(a: __m512) -> __m512 { 1077 | | transmute(vsqrtps(a.as_f32x16(), _MM_FROUND_CUR_DIRECTION)) 1078 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1086:1 | 1086 | / pub unsafe fn _mm512_mask_sqrt_ps(src: __m512, k: __mmask16, a: __m512) -> __m512 { 1087 | | let sqrt = _mm512_sqrt_ps(a).as_f32x16(); 1088 | | transmute(simd_select_bitmask(k, sqrt, src.as_f32x16())) 1089 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1097:1 | 1097 | / pub unsafe fn _mm512_maskz_sqrt_ps(k: __mmask16, a: __m512) -> __m512 { 1098 | | let sqrt = _mm512_sqrt_ps(a).as_f32x16(); 1099 | | let zero = _mm512_setzero_ps().as_f32x16(); 1100 | | transmute(simd_select_bitmask(k, sqrt, zero)) 1101 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1109:1 | 1109 | / pub unsafe fn _mm512_sqrt_pd(a: __m512d) -> __m512d { 1110 | | transmute(vsqrtpd(a.as_f64x8(), _MM_FROUND_CUR_DIRECTION)) 1111 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1119:1 | 1119 | / pub unsafe fn _mm512_mask_sqrt_pd(src: __m512d, k: __mmask8, a: __m512d) -> __m512d { 1120 | | let sqrt = _mm512_sqrt_pd(a).as_f64x8(); 1121 | | transmute(simd_select_bitmask(k, sqrt, src.as_f64x8())) 1122 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1130:1 | 1130 | / pub unsafe fn _mm512_maskz_sqrt_pd(k: __mmask8, a: __m512d) -> __m512d { 1131 | | let sqrt = _mm512_sqrt_pd(a).as_f64x8(); 1132 | | let zero = _mm512_setzero_pd().as_f64x8(); 1133 | | transmute(simd_select_bitmask(k, sqrt, zero)) 1134 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1142:1 | 1142 | / pub unsafe fn _mm512_fmadd_ps(a: __m512, b: __m512, c: __m512) -> __m512 { 1143 | | transmute(vfmadd132ps( 1144 | | a.as_f32x16(), 1145 | | b.as_f32x16(), ... | 1148 | | )) 1149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1157:1 | 1157 | / pub unsafe fn _mm512_mask_fmadd_ps(a: __m512, k: __mmask16, b: __m512, c: __m512) -> __m512 { 1158 | | let fmadd = _mm512_fmadd_ps(a, b, c).as_f32x16(); 1159 | | transmute(simd_select_bitmask(k, fmadd, a.as_f32x16())) 1160 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1168:1 | 1168 | / pub unsafe fn _mm512_maskz_fmadd_ps(k: __mmask16, a: __m512, b: __m512, c: __m512) -> __m512 { 1169 | | let fmadd = _mm512_fmadd_ps(a, b, c).as_f32x16(); 1170 | | let zero = _mm512_setzero_ps().as_f32x16(); 1171 | | transmute(simd_select_bitmask(k, fmadd, zero)) 1172 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1180:1 | 1180 | / pub unsafe fn _mm512_mask3_fmadd_ps(a: __m512, b: __m512, c: __m512, k: __mmask16) -> __m512 { 1181 | | let fmadd = _mm512_fmadd_ps(a, b, c).as_f32x16(); 1182 | | transmute(simd_select_bitmask(k, fmadd, c.as_f32x16())) 1183 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1191:1 | 1191 | / pub unsafe fn _mm512_fmadd_pd(a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1192 | | transmute(vfmadd132pd( 1193 | | a.as_f64x8(), 1194 | | b.as_f64x8(), ... | 1197 | | )) 1198 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1206:1 | 1206 | / pub unsafe fn _mm512_mask_fmadd_pd(a: __m512d, k: __mmask8, b: __m512d, c: __m512d) -> __m512d { 1207 | | let fmadd = _mm512_fmadd_pd(a, b, c).as_f64x8(); 1208 | | transmute(simd_select_bitmask(k, fmadd, a.as_f64x8())) 1209 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1217:1 | 1217 | / pub unsafe fn _mm512_maskz_fmadd_pd(k: __mmask8, a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1218 | | let fmadd = _mm512_fmadd_pd(a, b, c).as_f64x8(); 1219 | | let zero = _mm512_setzero_pd().as_f64x8(); 1220 | | transmute(simd_select_bitmask(k, fmadd, zero)) 1221 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1229:1 | 1229 | / pub unsafe fn _mm512_mask3_fmadd_pd(a: __m512d, b: __m512d, c: __m512d, k: __mmask8) -> __m512d { 1230 | | let fmadd = _mm512_fmadd_pd(a, b, c).as_f64x8(); 1231 | | transmute(simd_select_bitmask(k, fmadd, c.as_f64x8())) 1232 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1240:1 | 1240 | / pub unsafe fn _mm512_fmsub_ps(a: __m512, b: __m512, c: __m512) -> __m512 { 1241 | | let zero: f32x16 = mem::zeroed(); 1242 | | let sub = simd_sub(zero, c.as_f32x16()); 1243 | | transmute(vfmadd132ps( ... | 1248 | | )) 1249 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1257:1 | 1257 | / pub unsafe fn _mm512_mask_fmsub_ps(a: __m512, k: __mmask16, b: __m512, c: __m512) -> __m512 { 1258 | | let fmsub = _mm512_fmsub_ps(a, b, c).as_f32x16(); 1259 | | transmute(simd_select_bitmask(k, fmsub, a.as_f32x16())) 1260 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1268:1 | 1268 | / pub unsafe fn _mm512_maskz_fmsub_ps(k: __mmask16, a: __m512, b: __m512, c: __m512) -> __m512 { 1269 | | let fmsub = _mm512_fmsub_ps(a, b, c).as_f32x16(); 1270 | | let zero = _mm512_setzero_ps().as_f32x16(); 1271 | | transmute(simd_select_bitmask(k, fmsub, zero)) 1272 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1280:1 | 1280 | / pub unsafe fn _mm512_mask3_fmsub_ps(a: __m512, b: __m512, c: __m512, k: __mmask16) -> __m512 { 1281 | | let fmsub = _mm512_fmsub_ps(a, b, c).as_f32x16(); 1282 | | transmute(simd_select_bitmask(k, fmsub, c.as_f32x16())) 1283 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1291:1 | 1291 | / pub unsafe fn _mm512_fmsub_pd(a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1292 | | let zero: f64x8 = mem::zeroed(); 1293 | | let sub = simd_sub(zero, c.as_f64x8()); 1294 | | transmute(vfmadd132pd( ... | 1299 | | )) 1300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1308:1 | 1308 | / pub unsafe fn _mm512_mask_fmsub_pd(a: __m512d, k: __mmask8, b: __m512d, c: __m512d) -> __m512d { 1309 | | let fmsub = _mm512_fmsub_pd(a, b, c).as_f64x8(); 1310 | | transmute(simd_select_bitmask(k, fmsub, a.as_f64x8())) 1311 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1319:1 | 1319 | / pub unsafe fn _mm512_maskz_fmsub_pd(k: __mmask8, a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1320 | | let fmsub = _mm512_fmsub_pd(a, b, c).as_f64x8(); 1321 | | let zero = _mm512_setzero_pd().as_f64x8(); 1322 | | transmute(simd_select_bitmask(k, fmsub, zero)) 1323 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1331:1 | 1331 | / pub unsafe fn _mm512_mask3_fmsub_pd(a: __m512d, b: __m512d, c: __m512d, k: __mmask8) -> __m512d { 1332 | | let fmsub = _mm512_fmsub_pd(a, b, c).as_f64x8(); 1333 | | transmute(simd_select_bitmask(k, fmsub, c.as_f64x8())) 1334 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1342:1 | 1342 | / pub unsafe fn _mm512_fmaddsub_ps(a: __m512, b: __m512, c: __m512) -> __m512 { 1343 | | transmute(vfmaddsub213ps( 1344 | | a.as_f32x16(), 1345 | | b.as_f32x16(), ... | 1348 | | )) 1349 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1357:1 | 1357 | / pub unsafe fn _mm512_mask_fmaddsub_ps(a: __m512, k: __mmask16, b: __m512, c: __m512) -> __m512 { 1358 | | let fmaddsub = _mm512_fmaddsub_ps(a, b, c).as_f32x16(); 1359 | | transmute(simd_select_bitmask(k, fmaddsub, a.as_f32x16())) 1360 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1368:1 | 1368 | / pub unsafe fn _mm512_maskz_fmaddsub_ps(k: __mmask16, a: __m512, b: __m512, c: __m512) -> __m512 { 1369 | | let fmaddsub = _mm512_fmaddsub_ps(a, b, c).as_f32x16(); 1370 | | let zero = _mm512_setzero_ps().as_f32x16(); 1371 | | transmute(simd_select_bitmask(k, fmaddsub, zero)) 1372 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1380:1 | 1380 | / pub unsafe fn _mm512_mask3_fmaddsub_ps(a: __m512, b: __m512, c: __m512, k: __mmask16) -> __m512 { 1381 | | let fmaddsub = _mm512_fmaddsub_ps(a, b, c).as_f32x16(); 1382 | | transmute(simd_select_bitmask(k, fmaddsub, c.as_f32x16())) 1383 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1391:1 | 1391 | / pub unsafe fn _mm512_fmaddsub_pd(a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1392 | | transmute(vfmaddsub213pd( 1393 | | a.as_f64x8(), 1394 | | b.as_f64x8(), ... | 1397 | | )) 1398 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1406:1 | 1406 | / pub unsafe fn _mm512_mask_fmaddsub_pd(a: __m512d, k: __mmask8, b: __m512d, c: __m512d) -> __m512d { 1407 | | let fmaddsub = _mm512_fmaddsub_pd(a, b, c).as_f64x8(); 1408 | | transmute(simd_select_bitmask(k, fmaddsub, a.as_f64x8())) 1409 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1417:1 | 1417 | / pub unsafe fn _mm512_maskz_fmaddsub_pd(k: __mmask8, a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1418 | | let fmaddsub = _mm512_fmaddsub_pd(a, b, c).as_f64x8(); 1419 | | let zero = _mm512_setzero_pd().as_f64x8(); 1420 | | transmute(simd_select_bitmask(k, fmaddsub, zero)) 1421 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1429:1 | 1429 | / pub unsafe fn _mm512_mask3_fmaddsub_pd(a: __m512d, b: __m512d, c: __m512d, k: __mmask8) -> __m512d { 1430 | | let fmaddsub = _mm512_fmaddsub_pd(a, b, c).as_f64x8(); 1431 | | transmute(simd_select_bitmask(k, fmaddsub, c.as_f64x8())) 1432 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1440:1 | 1440 | / pub unsafe fn _mm512_fmsubadd_ps(a: __m512, b: __m512, c: __m512) -> __m512 { 1441 | | let zero: f32x16 = mem::zeroed(); 1442 | | let sub = simd_sub(zero, c.as_f32x16()); 1443 | | transmute(vfmaddsub213ps( ... | 1448 | | )) 1449 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1457:1 | 1457 | / pub unsafe fn _mm512_mask_fmsubadd_ps(a: __m512, k: __mmask16, b: __m512, c: __m512) -> __m512 { 1458 | | let fmsubadd = _mm512_fmsubadd_ps(a, b, c).as_f32x16(); 1459 | | transmute(simd_select_bitmask(k, fmsubadd, a.as_f32x16())) 1460 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1468:1 | 1468 | / pub unsafe fn _mm512_maskz_fmsubadd_ps(k: __mmask16, a: __m512, b: __m512, c: __m512) -> __m512 { 1469 | | let fmsubadd = _mm512_fmsubadd_ps(a, b, c).as_f32x16(); 1470 | | let zero = _mm512_setzero_ps().as_f32x16(); 1471 | | transmute(simd_select_bitmask(k, fmsubadd, zero)) 1472 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1480:1 | 1480 | / pub unsafe fn _mm512_mask3_fmsubadd_ps(a: __m512, b: __m512, c: __m512, k: __mmask16) -> __m512 { 1481 | | let fmsubadd = _mm512_fmsubadd_ps(a, b, c).as_f32x16(); 1482 | | transmute(simd_select_bitmask(k, fmsubadd, c.as_f32x16())) 1483 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1491:1 | 1491 | / pub unsafe fn _mm512_fmsubadd_pd(a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1492 | | let zero: f64x8 = mem::zeroed(); 1493 | | let sub = simd_sub(zero, c.as_f64x8()); 1494 | | transmute(vfmaddsub213pd( ... | 1499 | | )) 1500 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1508:1 | 1508 | / pub unsafe fn _mm512_mask_fmsubadd_pd(a: __m512d, k: __mmask8, b: __m512d, c: __m512d) -> __m512d { 1509 | | let fmsubadd = _mm512_fmsubadd_pd(a, b, c).as_f64x8(); 1510 | | transmute(simd_select_bitmask(k, fmsubadd, a.as_f64x8())) 1511 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1519:1 | 1519 | / pub unsafe fn _mm512_maskz_fmsubadd_pd(k: __mmask8, a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1520 | | let fmsubadd = _mm512_fmsubadd_pd(a, b, c).as_f64x8(); 1521 | | let zero = _mm512_setzero_pd().as_f64x8(); 1522 | | transmute(simd_select_bitmask(k, fmsubadd, zero)) 1523 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1531:1 | 1531 | / pub unsafe fn _mm512_mask3_fmsubadd_pd(a: __m512d, b: __m512d, c: __m512d, k: __mmask8) -> __m512d { 1532 | | let fmsubadd = _mm512_fmsubadd_pd(a, b, c).as_f64x8(); 1533 | | transmute(simd_select_bitmask(k, fmsubadd, c.as_f64x8())) 1534 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1542:1 | 1542 | / pub unsafe fn _mm512_fnmadd_ps(a: __m512, b: __m512, c: __m512) -> __m512 { 1543 | | let zero: f32x16 = mem::zeroed(); 1544 | | let sub = simd_sub(zero, a.as_f32x16()); 1545 | | transmute(vfmadd132ps( ... | 1550 | | )) 1551 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1559:1 | 1559 | / pub unsafe fn _mm512_mask_fnmadd_ps(a: __m512, k: __mmask16, b: __m512, c: __m512) -> __m512 { 1560 | | let fnmadd = _mm512_fnmadd_ps(a, b, c).as_f32x16(); 1561 | | transmute(simd_select_bitmask(k, fnmadd, a.as_f32x16())) 1562 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1570:1 | 1570 | / pub unsafe fn _mm512_maskz_fnmadd_ps(k: __mmask16, a: __m512, b: __m512, c: __m512) -> __m512 { 1571 | | let fnmadd = _mm512_fnmadd_ps(a, b, c).as_f32x16(); 1572 | | let zero = _mm512_setzero_ps().as_f32x16(); 1573 | | transmute(simd_select_bitmask(k, fnmadd, zero)) 1574 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1582:1 | 1582 | / pub unsafe fn _mm512_mask3_fnmadd_ps(a: __m512, b: __m512, c: __m512, k: __mmask16) -> __m512 { 1583 | | let fnmadd = _mm512_fnmadd_ps(a, b, c).as_f32x16(); 1584 | | transmute(simd_select_bitmask(k, fnmadd, c.as_f32x16())) 1585 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1593:1 | 1593 | / pub unsafe fn _mm512_fnmadd_pd(a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1594 | | let zero: f64x8 = mem::zeroed(); 1595 | | let sub = simd_sub(zero, a.as_f64x8()); 1596 | | transmute(vfmadd132pd( ... | 1601 | | )) 1602 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1610:1 | 1610 | / pub unsafe fn _mm512_mask_fnmadd_pd(a: __m512d, k: __mmask8, b: __m512d, c: __m512d) -> __m512d { 1611 | | let fnmadd = _mm512_fnmadd_pd(a, b, c).as_f64x8(); 1612 | | transmute(simd_select_bitmask(k, fnmadd, a.as_f64x8())) 1613 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1621:1 | 1621 | / pub unsafe fn _mm512_maskz_fnmadd_pd(k: __mmask8, a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1622 | | let fnmadd = _mm512_fnmadd_pd(a, b, c).as_f64x8(); 1623 | | let zero = _mm512_setzero_pd().as_f64x8(); 1624 | | transmute(simd_select_bitmask(k, fnmadd, zero)) 1625 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1633:1 | 1633 | / pub unsafe fn _mm512_mask3_fnmadd_pd(a: __m512d, b: __m512d, c: __m512d, k: __mmask8) -> __m512d { 1634 | | let fnmadd = _mm512_fnmadd_pd(a, b, c).as_f64x8(); 1635 | | transmute(simd_select_bitmask(k, fnmadd, c.as_f64x8())) 1636 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1644:1 | 1644 | / pub unsafe fn _mm512_fnmsub_ps(a: __m512, b: __m512, c: __m512) -> __m512 { 1645 | | let zero: f32x16 = mem::zeroed(); 1646 | | let suba = simd_sub(zero, a.as_f32x16()); 1647 | | let subc = simd_sub(zero, c.as_f32x16()); ... | 1653 | | )) 1654 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1662:1 | 1662 | / pub unsafe fn _mm512_mask_fnmsub_ps(a: __m512, k: __mmask16, b: __m512, c: __m512) -> __m512 { 1663 | | let fnmsub = _mm512_fnmsub_ps(a, b, c).as_f32x16(); 1664 | | transmute(simd_select_bitmask(k, fnmsub, a.as_f32x16())) 1665 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1673:1 | 1673 | / pub unsafe fn _mm512_maskz_fnmsub_ps(k: __mmask16, a: __m512, b: __m512, c: __m512) -> __m512 { 1674 | | let fnmsub = _mm512_fnmsub_ps(a, b, c).as_f32x16(); 1675 | | let zero = _mm512_setzero_ps().as_f32x16(); 1676 | | transmute(simd_select_bitmask(k, fnmsub, zero)) 1677 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1685:1 | 1685 | / pub unsafe fn _mm512_mask3_fnmsub_ps(a: __m512, b: __m512, c: __m512, k: __mmask16) -> __m512 { 1686 | | let fnmsub = _mm512_fnmsub_ps(a, b, c).as_f32x16(); 1687 | | transmute(simd_select_bitmask(k, fnmsub, c.as_f32x16())) 1688 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1696:1 | 1696 | / pub unsafe fn _mm512_fnmsub_pd(a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1697 | | let zero: f64x8 = mem::zeroed(); 1698 | | let suba = simd_sub(zero, a.as_f64x8()); 1699 | | let subc = simd_sub(zero, c.as_f64x8()); ... | 1705 | | )) 1706 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1714:1 | 1714 | / pub unsafe fn _mm512_mask_fnmsub_pd(a: __m512d, k: __mmask8, b: __m512d, c: __m512d) -> __m512d { 1715 | | let fnmsub = _mm512_fnmsub_pd(a, b, c).as_f64x8(); 1716 | | transmute(simd_select_bitmask(k, fnmsub, a.as_f64x8())) 1717 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1725:1 | 1725 | / pub unsafe fn _mm512_maskz_fnmsub_pd(k: __mmask8, a: __m512d, b: __m512d, c: __m512d) -> __m512d { 1726 | | let fnmsub = _mm512_fnmsub_pd(a, b, c).as_f64x8(); 1727 | | let zero = _mm512_setzero_pd().as_f64x8(); 1728 | | transmute(simd_select_bitmask(k, fnmsub, zero)) 1729 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1737:1 | 1737 | / pub unsafe fn _mm512_mask3_fnmsub_pd(a: __m512d, b: __m512d, c: __m512d, k: __mmask8) -> __m512d { 1738 | | let fnmsub = _mm512_fnmsub_pd(a, b, c).as_f64x8(); 1739 | | transmute(simd_select_bitmask(k, fnmsub, c.as_f64x8())) 1740 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1748:1 | 1748 | / pub unsafe fn _mm512_rcp14_ps(a: __m512) -> __m512 { 1749 | | transmute(vrcp14ps( 1750 | | a.as_f32x16(), 1751 | | _mm512_setzero_ps().as_f32x16(), 1752 | | 0b11111111_11111111, 1753 | | )) 1754 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1762:1 | 1762 | / pub unsafe fn _mm512_mask_rcp14_ps(src: __m512, k: __mmask16, a: __m512) -> __m512 { 1763 | | transmute(vrcp14ps(a.as_f32x16(), src.as_f32x16(), k)) 1764 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1772:1 | 1772 | / pub unsafe fn _mm512_maskz_rcp14_ps(k: __mmask16, a: __m512) -> __m512 { 1773 | | transmute(vrcp14ps(a.as_f32x16(), _mm512_setzero_ps().as_f32x16(), k)) 1774 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1782:1 | 1782 | / pub unsafe fn _mm512_rcp14_pd(a: __m512d) -> __m512d { 1783 | | transmute(vrcp14pd( 1784 | | a.as_f64x8(), 1785 | | _mm512_setzero_pd().as_f64x8(), 1786 | | 0b11111111, 1787 | | )) 1788 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1796:1 | 1796 | / pub unsafe fn _mm512_mask_rcp14_pd(src: __m512d, k: __mmask8, a: __m512d) -> __m512d { 1797 | | transmute(vrcp14pd(a.as_f64x8(), src.as_f64x8(), k)) 1798 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1806:1 | 1806 | / pub unsafe fn _mm512_maskz_rcp14_pd(k: __mmask8, a: __m512d) -> __m512d { 1807 | | transmute(vrcp14pd(a.as_f64x8(), _mm512_setzero_pd().as_f64x8(), k)) 1808 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1816:1 | 1816 | / pub unsafe fn _mm512_rsqrt14_ps(a: __m512) -> __m512 { 1817 | | transmute(vrsqrt14ps( 1818 | | a.as_f32x16(), 1819 | | _mm512_setzero_ps().as_f32x16(), 1820 | | 0b11111111_11111111, 1821 | | )) 1822 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1830:1 | 1830 | / pub unsafe fn _mm512_mask_rsqrt14_ps(src: __m512, k: __mmask16, a: __m512) -> __m512 { 1831 | | transmute(vrsqrt14ps(a.as_f32x16(), src.as_f32x16(), k)) 1832 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1840:1 | 1840 | / pub unsafe fn _mm512_maskz_rsqrt14_ps(k: __mmask16, a: __m512) -> __m512 { 1841 | | transmute(vrsqrt14ps( 1842 | | a.as_f32x16(), 1843 | | _mm512_setzero_ps().as_f32x16(), 1844 | | k, 1845 | | )) 1846 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1854:1 | 1854 | / pub unsafe fn _mm512_rsqrt14_pd(a: __m512d) -> __m512d { 1855 | | transmute(vrsqrt14pd( 1856 | | a.as_f64x8(), 1857 | | _mm512_setzero_pd().as_f64x8(), 1858 | | 0b11111111, 1859 | | )) 1860 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1868:1 | 1868 | / pub unsafe fn _mm512_mask_rsqrt14_pd(src: __m512d, k: __mmask8, a: __m512d) -> __m512d { 1869 | | transmute(vrsqrt14pd(a.as_f64x8(), src.as_f64x8(), k)) 1870 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1878:1 | 1878 | / pub unsafe fn _mm512_maskz_rsqrt14_pd(k: __mmask8, a: __m512d) -> __m512d { 1879 | | transmute(vrsqrt14pd(a.as_f64x8(), _mm512_setzero_pd().as_f64x8(), k)) 1880 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1888:1 | 1888 | / pub unsafe fn _mm512_getexp_ps(a: __m512) -> __m512 { 1889 | | transmute(vgetexpps( 1890 | | a.as_f32x16(), 1891 | | _mm512_setzero_ps().as_f32x16(), ... | 1894 | | )) 1895 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1903:1 | 1903 | / pub unsafe fn _mm512_mask_getexp_ps(src: __m512, k: __mmask16, a: __m512) -> __m512 { 1904 | | transmute(vgetexpps( 1905 | | a.as_f32x16(), 1906 | | src.as_f32x16(), ... | 1909 | | )) 1910 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1918:1 | 1918 | / pub unsafe fn _mm512_maskz_getexp_ps(k: __mmask16, a: __m512) -> __m512 { 1919 | | transmute(vgetexpps( 1920 | | a.as_f32x16(), 1921 | | _mm512_setzero_ps().as_f32x16(), ... | 1924 | | )) 1925 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1933:1 | 1933 | / pub unsafe fn _mm512_getexp_pd(a: __m512d) -> __m512d { 1934 | | transmute(vgetexppd( 1935 | | a.as_f64x8(), 1936 | | _mm512_setzero_pd().as_f64x8(), ... | 1939 | | )) 1940 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1948:1 | 1948 | / pub unsafe fn _mm512_mask_getexp_pd(src: __m512d, k: __mmask8, a: __m512d) -> __m512d { 1949 | | transmute(vgetexppd( 1950 | | a.as_f64x8(), 1951 | | src.as_f64x8(), ... | 1954 | | )) 1955 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1963:1 | 1963 | / pub unsafe fn _mm512_maskz_getexp_pd(k: __mmask8, a: __m512d) -> __m512d { 1964 | | transmute(vgetexppd( 1965 | | a.as_f64x8(), 1966 | | _mm512_setzero_pd().as_f64x8(), ... | 1969 | | )) 1970 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1988:1 | 1988 | / pub unsafe fn _mm512_getmant_ps( 1989 | | a: __m512, 1990 | | norm: _MM_MANTISSA_NORM_ENUM, 1991 | | sign: _MM_MANTISSA_SIGN_ENUM, ... | 2005 | | transmute(r) 2006 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2024:1 | 2024 | / pub unsafe fn _mm512_mask_getmant_ps( 2025 | | src: __m512, 2026 | | k: __mmask16, 2027 | | a: __m512, ... | 2043 | | transmute(r) 2044 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2062:1 | 2062 | / pub unsafe fn _mm512_maskz_getmant_ps( 2063 | | k: __mmask16, 2064 | | a: __m512, 2065 | | norm: _MM_MANTISSA_NORM_ENUM, ... | 2080 | | transmute(r) 2081 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2099:1 | 2099 | / pub unsafe fn _mm512_getmant_pd( 2100 | | a: __m512d, 2101 | | norm: _MM_MANTISSA_NORM_ENUM, 2102 | | sign: _MM_MANTISSA_SIGN_ENUM, ... | 2116 | | transmute(r) 2117 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2135:1 | 2135 | / pub unsafe fn _mm512_mask_getmant_pd( 2136 | | src: __m512d, 2137 | | k: __mmask8, 2138 | | a: __m512d, ... | 2154 | | transmute(r) 2155 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2173:1 | 2173 | / pub unsafe fn _mm512_maskz_getmant_pd( 2174 | | k: __mmask8, 2175 | | a: __m512d, 2176 | | norm: _MM_MANTISSA_NORM_ENUM, ... | 2191 | | transmute(r) 2192 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2208:1 | 2208 | / pub unsafe fn _mm512_add_round_ps(a: __m512, b: __m512, rounding: i32) -> __m512 { 2209 | | macro_rules! call { 2210 | | ($imm4:expr) => { 2211 | | vaddps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 2215 | | transmute(r) 2216 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2232:1 | 2232 | / pub unsafe fn _mm512_mask_add_round_ps( 2233 | | src: __m512, 2234 | | k: __mmask16, 2235 | | a: __m512, ... | 2245 | | transmute(simd_select_bitmask(k, addround, src.as_f32x16())) 2246 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2262:1 | 2262 | / pub unsafe fn _mm512_maskz_add_round_ps( 2263 | | k: __mmask16, 2264 | | a: __m512, 2265 | | b: __m512, ... | 2275 | | transmute(simd_select_bitmask(k, addround, zero)) 2276 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2292:1 | 2292 | / pub unsafe fn _mm512_add_round_pd(a: __m512d, b: __m512d, rounding: i32) -> __m512d { 2293 | | macro_rules! call { 2294 | | ($imm4:expr) => { 2295 | | vaddpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 2299 | | transmute(r) 2300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2316:1 | 2316 | / pub unsafe fn _mm512_mask_add_round_pd( 2317 | | src: __m512d, 2318 | | k: __mmask8, 2319 | | a: __m512d, ... | 2329 | | transmute(simd_select_bitmask(k, addround, src.as_f64x8())) 2330 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2346:1 | 2346 | / pub unsafe fn _mm512_maskz_add_round_pd( 2347 | | k: __mmask8, 2348 | | a: __m512d, 2349 | | b: __m512d, ... | 2359 | | transmute(simd_select_bitmask(k, addround, zero)) 2360 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2376:1 | 2376 | / pub unsafe fn _mm512_sub_round_ps(a: __m512, b: __m512, rounding: i32) -> __m512 { 2377 | | macro_rules! call { 2378 | | ($imm4:expr) => { 2379 | | vsubps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 2383 | | transmute(r) 2384 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2400:1 | 2400 | / pub unsafe fn _mm512_mask_sub_round_ps( 2401 | | src: __m512, 2402 | | k: __mmask16, 2403 | | a: __m512, ... | 2413 | | transmute(simd_select_bitmask(k, subround, src.as_f32x16())) 2414 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2430:1 | 2430 | / pub unsafe fn _mm512_maskz_sub_round_ps( 2431 | | k: __mmask16, 2432 | | a: __m512, 2433 | | b: __m512, ... | 2443 | | transmute(simd_select_bitmask(k, subround, zero)) 2444 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2460:1 | 2460 | / pub unsafe fn _mm512_sub_round_pd(a: __m512d, b: __m512d, rounding: i32) -> __m512d { 2461 | | macro_rules! call { 2462 | | ($imm4:expr) => { 2463 | | vsubpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 2467 | | transmute(r) 2468 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2484:1 | 2484 | / pub unsafe fn _mm512_mask_sub_round_pd( 2485 | | src: __m512d, 2486 | | k: __mmask8, 2487 | | a: __m512d, ... | 2497 | | transmute(simd_select_bitmask(k, subround, src.as_f64x8())) 2498 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2514:1 | 2514 | / pub unsafe fn _mm512_maskz_sub_round_pd( 2515 | | k: __mmask8, 2516 | | a: __m512d, 2517 | | b: __m512d, ... | 2527 | | transmute(simd_select_bitmask(k, subround, zero)) 2528 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2544:1 | 2544 | / pub unsafe fn _mm512_mul_round_ps(a: __m512, b: __m512, rounding: i32) -> __m512 { 2545 | | macro_rules! call { 2546 | | ($imm4:expr) => { 2547 | | vmulps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 2551 | | transmute(r) 2552 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2568:1 | 2568 | / pub unsafe fn _mm512_mask_mul_round_ps( 2569 | | src: __m512, 2570 | | k: __mmask16, 2571 | | a: __m512, ... | 2581 | | transmute(simd_select_bitmask(k, mulround, src.as_f32x16())) 2582 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2598:1 | 2598 | / pub unsafe fn _mm512_maskz_mul_round_ps( 2599 | | k: __mmask16, 2600 | | a: __m512, 2601 | | b: __m512, ... | 2611 | | transmute(simd_select_bitmask(k, mulround, zero)) 2612 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2628:1 | 2628 | / pub unsafe fn _mm512_mul_round_pd(a: __m512d, b: __m512d, rounding: i32) -> __m512d { 2629 | | macro_rules! call { 2630 | | ($imm4:expr) => { 2631 | | vmulpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 2635 | | transmute(r) 2636 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2652:1 | 2652 | / pub unsafe fn _mm512_mask_mul_round_pd( 2653 | | src: __m512d, 2654 | | k: __mmask8, 2655 | | a: __m512d, ... | 2665 | | transmute(simd_select_bitmask(k, mulround, src.as_f64x8())) 2666 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2682:1 | 2682 | / pub unsafe fn _mm512_maskz_mul_round_pd( 2683 | | k: __mmask8, 2684 | | a: __m512d, 2685 | | b: __m512d, ... | 2695 | | transmute(simd_select_bitmask(k, mulround, zero)) 2696 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2712:1 | 2712 | / pub unsafe fn _mm512_div_round_ps(a: __m512, b: __m512, rounding: i32) -> __m512 { 2713 | | macro_rules! call { 2714 | | ($imm4:expr) => { 2715 | | vdivps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 2719 | | transmute(r) 2720 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2736:1 | 2736 | / pub unsafe fn _mm512_mask_div_round_ps( 2737 | | src: __m512, 2738 | | k: __mmask16, 2739 | | a: __m512, ... | 2749 | | transmute(simd_select_bitmask(k, divround, src.as_f32x16())) 2750 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2766:1 | 2766 | / pub unsafe fn _mm512_maskz_div_round_ps( 2767 | | k: __mmask16, 2768 | | a: __m512, 2769 | | b: __m512, ... | 2779 | | transmute(simd_select_bitmask(k, divround, zero)) 2780 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2796:1 | 2796 | / pub unsafe fn _mm512_div_round_pd(a: __m512d, b: __m512d, rounding: i32) -> __m512d { 2797 | | macro_rules! call { 2798 | | ($imm4:expr) => { 2799 | | vdivpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 2803 | | transmute(r) 2804 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2820:1 | 2820 | / pub unsafe fn _mm512_mask_div_round_pd( 2821 | | src: __m512d, 2822 | | k: __mmask8, 2823 | | a: __m512d, ... | 2833 | | transmute(simd_select_bitmask(k, divround, src.as_f64x8())) 2834 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2850:1 | 2850 | / pub unsafe fn _mm512_maskz_div_round_pd( 2851 | | k: __mmask8, 2852 | | a: __m512d, 2853 | | b: __m512d, ... | 2863 | | transmute(simd_select_bitmask(k, divround, zero)) 2864 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2880:1 | 2880 | / pub unsafe fn _mm512_sqrt_round_ps(a: __m512, rounding: i32) -> __m512 { 2881 | | macro_rules! call { 2882 | | ($imm4:expr) => { 2883 | | vsqrtps(a.as_f32x16(), $imm4) ... | 2887 | | transmute(r) 2888 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2904:1 | 2904 | / pub unsafe fn _mm512_mask_sqrt_round_ps( 2905 | | src: __m512, 2906 | | k: __mmask16, 2907 | | a: __m512, ... | 2916 | | transmute(simd_select_bitmask(k, sqrtround, src.as_f32x16())) 2917 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2933:1 | 2933 | / pub unsafe fn _mm512_maskz_sqrt_round_ps(k: __mmask16, a: __m512, rounding: i32) -> __m512 { 2934 | | macro_rules! call { 2935 | | ($imm4:expr) => { 2936 | | vsqrtps(a.as_f32x16(), $imm4) ... | 2941 | | transmute(simd_select_bitmask(k, sqrtround, zero)) 2942 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2958:1 | 2958 | / pub unsafe fn _mm512_sqrt_round_pd(a: __m512d, rounding: i32) -> __m512d { 2959 | | macro_rules! call { 2960 | | ($imm4:expr) => { 2961 | | vsqrtpd(a.as_f64x8(), $imm4) ... | 2965 | | transmute(r) 2966 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2982:1 | 2982 | / pub unsafe fn _mm512_mask_sqrt_round_pd( 2983 | | src: __m512d, 2984 | | k: __mmask8, 2985 | | a: __m512d, ... | 2994 | | transmute(simd_select_bitmask(k, sqrtround, src.as_f64x8())) 2995 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3011:1 | 3011 | / pub unsafe fn _mm512_maskz_sqrt_round_pd(k: __mmask8, a: __m512d, rounding: i32) -> __m512d { 3012 | | macro_rules! call { 3013 | | ($imm4:expr) => { 3014 | | vsqrtpd(a.as_f64x8(), $imm4) ... | 3019 | | transmute(simd_select_bitmask(k, sqrtround, zero)) 3020 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3036:1 | 3036 | / pub unsafe fn _mm512_fmadd_round_ps(a: __m512, b: __m512, c: __m512, rounding: i32) -> __m512 { 3037 | | macro_rules! call { 3038 | | ($imm4:expr) => { 3039 | | vfmadd132ps(a.as_f32x16(), b.as_f32x16(), c.as_f32x16(), $imm4) ... | 3043 | | transmute(r) 3044 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3060:1 | 3060 | / pub unsafe fn _mm512_mask_fmadd_round_ps( 3061 | | a: __m512, 3062 | | k: __mmask16, 3063 | | b: __m512, ... | 3073 | | transmute(simd_select_bitmask(k, fmadd, a.as_f32x16())) 3074 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3090:1 | 3090 | / pub unsafe fn _mm512_maskz_fmadd_round_ps( 3091 | | k: __mmask16, 3092 | | a: __m512, 3093 | | b: __m512, ... | 3104 | | transmute(simd_select_bitmask(k, fmadd, zero)) 3105 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3121:1 | 3121 | / pub unsafe fn _mm512_mask3_fmadd_round_ps( 3122 | | a: __m512, 3123 | | b: __m512, 3124 | | c: __m512, ... | 3134 | | transmute(simd_select_bitmask(k, fmadd, c.as_f32x16())) 3135 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3151:1 | 3151 | / pub unsafe fn _mm512_fmadd_round_pd(a: __m512d, b: __m512d, c: __m512d, rounding: i32) -> __m512d { 3152 | | macro_rules! call { 3153 | | ($imm4:expr) => { 3154 | | vfmadd132pd(a.as_f64x8(), b.as_f64x8(), c.as_f64x8(), $imm4) ... | 3158 | | transmute(r) 3159 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3175:1 | 3175 | / pub unsafe fn _mm512_mask_fmadd_round_pd( 3176 | | a: __m512d, 3177 | | k: __mmask8, 3178 | | b: __m512d, ... | 3188 | | transmute(simd_select_bitmask(k, fmadd, a.as_f64x8())) 3189 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3205:1 | 3205 | / pub unsafe fn _mm512_maskz_fmadd_round_pd( 3206 | | k: __mmask8, 3207 | | a: __m512d, 3208 | | b: __m512d, ... | 3219 | | transmute(simd_select_bitmask(k, fmadd, zero)) 3220 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3236:1 | 3236 | / pub unsafe fn _mm512_mask3_fmadd_round_pd( 3237 | | a: __m512d, 3238 | | b: __m512d, 3239 | | c: __m512d, ... | 3249 | | transmute(simd_select_bitmask(k, fmadd, c.as_f64x8())) 3250 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3266:1 | 3266 | / pub unsafe fn _mm512_fmsub_round_ps(a: __m512, b: __m512, c: __m512, rounding: i32) -> __m512 { 3267 | | let zero: f32x16 = mem::zeroed(); 3268 | | let sub = simd_sub(zero, c.as_f32x16()); 3269 | | macro_rules! call { ... | 3275 | | transmute(r) 3276 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3292:1 | 3292 | / pub unsafe fn _mm512_mask_fmsub_round_ps( 3293 | | a: __m512, 3294 | | k: __mmask16, 3295 | | b: __m512, ... | 3307 | | transmute(simd_select_bitmask(k, fmsub, a.as_f32x16())) 3308 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3324:1 | 3324 | / pub unsafe fn _mm512_maskz_fmsub_round_ps( 3325 | | k: __mmask16, 3326 | | a: __m512, 3327 | | b: __m512, ... | 3339 | | transmute(simd_select_bitmask(k, fmsub, zero)) 3340 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3356:1 | 3356 | / pub unsafe fn _mm512_mask3_fmsub_round_ps( 3357 | | a: __m512, 3358 | | b: __m512, 3359 | | c: __m512, ... | 3371 | | transmute(simd_select_bitmask(k, fmsub, c.as_f32x16())) 3372 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3388:1 | 3388 | / pub unsafe fn _mm512_fmsub_round_pd(a: __m512d, b: __m512d, c: __m512d, rounding: i32) -> __m512d { 3389 | | let zero: f64x8 = mem::zeroed(); 3390 | | let sub = simd_sub(zero, c.as_f64x8()); 3391 | | macro_rules! call { ... | 3397 | | transmute(r) 3398 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3414:1 | 3414 | / pub unsafe fn _mm512_mask_fmsub_round_pd( 3415 | | a: __m512d, 3416 | | k: __mmask8, 3417 | | b: __m512d, ... | 3429 | | transmute(simd_select_bitmask(k, fmsub, a.as_f64x8())) 3430 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3446:1 | 3446 | / pub unsafe fn _mm512_maskz_fmsub_round_pd( 3447 | | k: __mmask8, 3448 | | a: __m512d, 3449 | | b: __m512d, ... | 3461 | | transmute(simd_select_bitmask(k, fmsub, zero)) 3462 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3478:1 | 3478 | / pub unsafe fn _mm512_mask3_fmsub_round_pd( 3479 | | a: __m512d, 3480 | | b: __m512d, 3481 | | c: __m512d, ... | 3493 | | transmute(simd_select_bitmask(k, fmsub, c.as_f64x8())) 3494 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3510:1 | 3510 | / pub unsafe fn _mm512_fmaddsub_round_ps(a: __m512, b: __m512, c: __m512, rounding: i32) -> __m512 { 3511 | | macro_rules! call { 3512 | | ($imm4:expr) => { 3513 | | vfmaddsub213ps(a.as_f32x16(), b.as_f32x16(), c.as_f32x16(), $imm4) ... | 3517 | | transmute(r) 3518 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3534:1 | 3534 | / pub unsafe fn _mm512_mask_fmaddsub_round_ps( 3535 | | a: __m512, 3536 | | k: __mmask16, 3537 | | b: __m512, ... | 3547 | | transmute(simd_select_bitmask(k, fmaddsub, a.as_f32x16())) 3548 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3564:1 | 3564 | / pub unsafe fn _mm512_maskz_fmaddsub_round_ps( 3565 | | k: __mmask16, 3566 | | a: __m512, 3567 | | b: __m512, ... | 3578 | | transmute(simd_select_bitmask(k, fmaddsub, zero)) 3579 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3595:1 | 3595 | / pub unsafe fn _mm512_mask3_fmaddsub_round_ps( 3596 | | a: __m512, 3597 | | b: __m512, 3598 | | c: __m512, ... | 3608 | | transmute(simd_select_bitmask(k, fmaddsub, c.as_f32x16())) 3609 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3625:1 | 3625 | / pub unsafe fn _mm512_fmaddsub_round_pd( 3626 | | a: __m512d, 3627 | | b: __m512d, 3628 | | c: __m512d, ... | 3637 | | transmute(r) 3638 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3654:1 | 3654 | / pub unsafe fn _mm512_mask_fmaddsub_round_pd( 3655 | | a: __m512d, 3656 | | k: __mmask8, 3657 | | b: __m512d, ... | 3667 | | transmute(simd_select_bitmask(k, fmaddsub, a.as_f64x8())) 3668 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3684:1 | 3684 | / pub unsafe fn _mm512_maskz_fmaddsub_round_pd( 3685 | | k: __mmask8, 3686 | | a: __m512d, 3687 | | b: __m512d, ... | 3698 | | transmute(simd_select_bitmask(k, fmaddsub, zero)) 3699 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3715:1 | 3715 | / pub unsafe fn _mm512_mask3_fmaddsub_round_pd( 3716 | | a: __m512d, 3717 | | b: __m512d, 3718 | | c: __m512d, ... | 3728 | | transmute(simd_select_bitmask(k, fmaddsub, c.as_f64x8())) 3729 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3745:1 | 3745 | / pub unsafe fn _mm512_fmsubadd_round_ps(a: __m512, b: __m512, c: __m512, rounding: i32) -> __m512 { 3746 | | let zero: f32x16 = mem::zeroed(); 3747 | | let sub = simd_sub(zero, c.as_f32x16()); 3748 | | macro_rules! call { ... | 3754 | | transmute(r) 3755 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3771:1 | 3771 | / pub unsafe fn _mm512_mask_fmsubadd_round_ps( 3772 | | a: __m512, 3773 | | k: __mmask16, 3774 | | b: __m512, ... | 3786 | | transmute(simd_select_bitmask(k, fmsubadd, a.as_f32x16())) 3787 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3803:1 | 3803 | / pub unsafe fn _mm512_maskz_fmsubadd_round_ps( 3804 | | k: __mmask16, 3805 | | a: __m512, 3806 | | b: __m512, ... | 3818 | | transmute(simd_select_bitmask(k, fmsubadd, zero)) 3819 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3835:1 | 3835 | / pub unsafe fn _mm512_mask3_fmsubadd_round_ps( 3836 | | a: __m512, 3837 | | b: __m512, 3838 | | c: __m512, ... | 3850 | | transmute(simd_select_bitmask(k, fmsubadd, c.as_f32x16())) 3851 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3867:1 | 3867 | / pub unsafe fn _mm512_fmsubadd_round_pd( 3868 | | a: __m512d, 3869 | | b: __m512d, 3870 | | c: __m512d, ... | 3881 | | transmute(r) 3882 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3898:1 | 3898 | / pub unsafe fn _mm512_mask_fmsubadd_round_pd( 3899 | | a: __m512d, 3900 | | k: __mmask8, 3901 | | b: __m512d, ... | 3913 | | transmute(simd_select_bitmask(k, fmsubadd, a.as_f64x8())) 3914 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3930:1 | 3930 | / pub unsafe fn _mm512_maskz_fmsubadd_round_pd( 3931 | | k: __mmask8, 3932 | | a: __m512d, 3933 | | b: __m512d, ... | 3945 | | transmute(simd_select_bitmask(k, fmsubadd, zero)) 3946 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3962:1 | 3962 | / pub unsafe fn _mm512_mask3_fmsubadd_round_pd( 3963 | | a: __m512d, 3964 | | b: __m512d, 3965 | | c: __m512d, ... | 3977 | | transmute(simd_select_bitmask(k, fmsubadd, c.as_f64x8())) 3978 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3994:1 | 3994 | / pub unsafe fn _mm512_fnmadd_round_ps(a: __m512, b: __m512, c: __m512, rounding: i32) -> __m512 { 3995 | | let zero: f32x16 = mem::zeroed(); 3996 | | let sub = simd_sub(zero, a.as_f32x16()); 3997 | | macro_rules! call { ... | 4003 | | transmute(r) 4004 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4020:1 | 4020 | / pub unsafe fn _mm512_mask_fnmadd_round_ps( 4021 | | a: __m512, 4022 | | k: __mmask16, 4023 | | b: __m512, ... | 4035 | | transmute(simd_select_bitmask(k, fnmadd, a.as_f32x16())) 4036 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4052:1 | 4052 | / pub unsafe fn _mm512_maskz_fnmadd_round_ps( 4053 | | k: __mmask16, 4054 | | a: __m512, 4055 | | b: __m512, ... | 4067 | | transmute(simd_select_bitmask(k, fnmadd, zero)) 4068 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4084:1 | 4084 | / pub unsafe fn _mm512_mask3_fnmadd_round_ps( 4085 | | a: __m512, 4086 | | b: __m512, 4087 | | c: __m512, ... | 4099 | | transmute(simd_select_bitmask(k, fnmadd, c.as_f32x16())) 4100 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4116:1 | 4116 | / pub unsafe fn _mm512_fnmadd_round_pd(a: __m512d, b: __m512d, c: __m512d, rounding: i32) -> __m512d { 4117 | | let zero: f64x8 = mem::zeroed(); 4118 | | let sub = simd_sub(zero, a.as_f64x8()); 4119 | | macro_rules! call { ... | 4125 | | transmute(r) 4126 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4142:1 | 4142 | / pub unsafe fn _mm512_mask_fnmadd_round_pd( 4143 | | a: __m512d, 4144 | | k: __mmask8, 4145 | | b: __m512d, ... | 4157 | | transmute(simd_select_bitmask(k, fnmadd, a.as_f64x8())) 4158 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4174:1 | 4174 | / pub unsafe fn _mm512_maskz_fnmadd_round_pd( 4175 | | k: __mmask8, 4176 | | a: __m512d, 4177 | | b: __m512d, ... | 4189 | | transmute(simd_select_bitmask(k, fnmadd, zero)) 4190 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4206:1 | 4206 | / pub unsafe fn _mm512_mask3_fnmadd_round_pd( 4207 | | a: __m512d, 4208 | | b: __m512d, 4209 | | c: __m512d, ... | 4221 | | transmute(simd_select_bitmask(k, fnmadd, c.as_f64x8())) 4222 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4238:1 | 4238 | / pub unsafe fn _mm512_fnmsub_round_ps(a: __m512, b: __m512, c: __m512, rounding: i32) -> __m512 { 4239 | | let zero: f32x16 = mem::zeroed(); 4240 | | let suba = simd_sub(zero, a.as_f32x16()); 4241 | | let subc = simd_sub(zero, c.as_f32x16()); ... | 4248 | | transmute(r) 4249 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4265:1 | 4265 | / pub unsafe fn _mm512_mask_fnmsub_round_ps( 4266 | | a: __m512, 4267 | | k: __mmask16, 4268 | | b: __m512, ... | 4281 | | transmute(simd_select_bitmask(k, fnmsub, a.as_f32x16())) 4282 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4298:1 | 4298 | / pub unsafe fn _mm512_maskz_fnmsub_round_ps( 4299 | | k: __mmask16, 4300 | | a: __m512, 4301 | | b: __m512, ... | 4314 | | transmute(simd_select_bitmask(k, fnmsub, zero)) 4315 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4331:1 | 4331 | / pub unsafe fn _mm512_mask3_fnmsub_round_ps( 4332 | | a: __m512, 4333 | | b: __m512, 4334 | | c: __m512, ... | 4347 | | transmute(simd_select_bitmask(k, fnmsub, c.as_f32x16())) 4348 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4364:1 | 4364 | / pub unsafe fn _mm512_fnmsub_round_pd(a: __m512d, b: __m512d, c: __m512d, rounding: i32) -> __m512d { 4365 | | let zero: f64x8 = mem::zeroed(); 4366 | | let suba = simd_sub(zero, a.as_f64x8()); 4367 | | let subc = simd_sub(zero, c.as_f64x8()); ... | 4374 | | transmute(r) 4375 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4391:1 | 4391 | / pub unsafe fn _mm512_mask_fnmsub_round_pd( 4392 | | a: __m512d, 4393 | | k: __mmask8, 4394 | | b: __m512d, ... | 4407 | | transmute(simd_select_bitmask(k, fnmsub, a.as_f64x8())) 4408 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4424:1 | 4424 | / pub unsafe fn _mm512_maskz_fnmsub_round_pd( 4425 | | k: __mmask8, 4426 | | a: __m512d, 4427 | | b: __m512d, ... | 4440 | | transmute(simd_select_bitmask(k, fnmsub, zero)) 4441 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4457:1 | 4457 | / pub unsafe fn _mm512_mask3_fnmsub_round_pd( 4458 | | a: __m512d, 4459 | | b: __m512d, 4460 | | c: __m512d, ... | 4473 | | transmute(simd_select_bitmask(k, fnmsub, c.as_f64x8())) 4474 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4484:1 | 4484 | / pub unsafe fn _mm512_max_round_ps(a: __m512, b: __m512, sae: i32) -> __m512 { 4485 | | macro_rules! call { 4486 | | ($imm4:expr) => { 4487 | | vmaxps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 4491 | | transmute(r) 4492 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4502:1 | 4502 | / pub unsafe fn _mm512_mask_max_round_ps( 4503 | | src: __m512, 4504 | | k: __mmask16, 4505 | | a: __m512, ... | 4515 | | transmute(simd_select_bitmask(k, max, src.as_f32x16())) 4516 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4526:1 | 4526 | / pub unsafe fn _mm512_maskz_max_round_ps(k: __mmask16, a: __m512, b: __m512, sae: i32) -> __m512 { 4527 | | macro_rules! call { 4528 | | ($imm4:expr) => { 4529 | | vmaxps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 4534 | | transmute(simd_select_bitmask(k, max, zero)) 4535 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4545:1 | 4545 | / pub unsafe fn _mm512_max_round_pd(a: __m512d, b: __m512d, sae: i32) -> __m512d { 4546 | | macro_rules! call { 4547 | | ($imm4:expr) => { 4548 | | vmaxpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 4552 | | transmute(r) 4553 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4563:1 | 4563 | / pub unsafe fn _mm512_mask_max_round_pd( 4564 | | src: __m512d, 4565 | | k: __mmask8, 4566 | | a: __m512d, ... | 4576 | | transmute(simd_select_bitmask(k, max, src.as_f64x8())) 4577 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4587:1 | 4587 | / pub unsafe fn _mm512_maskz_max_round_pd(k: __mmask8, a: __m512d, b: __m512d, sae: i32) -> __m512d { 4588 | | macro_rules! call { 4589 | | ($imm4:expr) => { 4590 | | vmaxpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 4595 | | transmute(simd_select_bitmask(k, max, zero)) 4596 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4606:1 | 4606 | / pub unsafe fn _mm512_min_round_ps(a: __m512, b: __m512, sae: i32) -> __m512 { 4607 | | macro_rules! call { 4608 | | ($imm4:expr) => { 4609 | | vminps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 4613 | | transmute(r) 4614 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4624:1 | 4624 | / pub unsafe fn _mm512_mask_min_round_ps( 4625 | | src: __m512, 4626 | | k: __mmask16, 4627 | | a: __m512, ... | 4637 | | transmute(simd_select_bitmask(k, max, src.as_f32x16())) 4638 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4648:1 | 4648 | / pub unsafe fn _mm512_maskz_min_round_ps(k: __mmask16, a: __m512, b: __m512, sae: i32) -> __m512 { 4649 | | macro_rules! call { 4650 | | ($imm4:expr) => { 4651 | | vminps(a.as_f32x16(), b.as_f32x16(), $imm4) ... | 4656 | | transmute(simd_select_bitmask(k, max, zero)) 4657 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4667:1 | 4667 | / pub unsafe fn _mm512_min_round_pd(a: __m512d, b: __m512d, sae: i32) -> __m512d { 4668 | | macro_rules! call { 4669 | | ($imm4:expr) => { 4670 | | vminpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 4674 | | transmute(r) 4675 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4685:1 | 4685 | / pub unsafe fn _mm512_mask_min_round_pd( 4686 | | src: __m512d, 4687 | | k: __mmask8, 4688 | | a: __m512d, ... | 4698 | | transmute(simd_select_bitmask(k, max, src.as_f64x8())) 4699 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4709:1 | 4709 | / pub unsafe fn _mm512_maskz_min_round_pd(k: __mmask8, a: __m512d, b: __m512d, sae: i32) -> __m512d { 4710 | | macro_rules! call { 4711 | | ($imm4:expr) => { 4712 | | vminpd(a.as_f64x8(), b.as_f64x8(), $imm4) ... | 4717 | | transmute(simd_select_bitmask(k, max, zero)) 4718 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4728:1 | 4728 | / pub unsafe fn _mm512_getexp_round_ps(a: __m512, sae: i32) -> __m512 { 4729 | | macro_rules! call { 4730 | | ($imm4:expr) => { 4731 | | vgetexpps( ... | 4740 | | transmute(r) 4741 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4751:1 | 4751 | / pub unsafe fn _mm512_mask_getexp_round_ps( 4752 | | src: __m512, 4753 | | k: __mmask16, 4754 | | a: __m512, ... | 4763 | | transmute(r) 4764 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4774:1 | 4774 | / pub unsafe fn _mm512_maskz_getexp_round_ps(k: __mmask16, a: __m512, sae: i32) -> __m512 { 4775 | | macro_rules! call { 4776 | | ($imm4:expr) => { 4777 | | vgetexpps(a.as_f32x16(), _mm512_setzero_ps().as_f32x16(), k, $imm4) ... | 4781 | | transmute(r) 4782 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4792:1 | 4792 | / pub unsafe fn _mm512_getexp_round_pd(a: __m512d, sae: i32) -> __m512d { 4793 | | macro_rules! call { 4794 | | ($imm4:expr) => { 4795 | | vgetexppd( ... | 4804 | | transmute(r) 4805 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4815:1 | 4815 | / pub unsafe fn _mm512_mask_getexp_round_pd( 4816 | | src: __m512d, 4817 | | k: __mmask8, 4818 | | a: __m512d, ... | 4827 | | transmute(r) 4828 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4838:1 | 4838 | / pub unsafe fn _mm512_maskz_getexp_round_pd(k: __mmask8, a: __m512d, sae: i32) -> __m512d { 4839 | | macro_rules! call { 4840 | | ($imm4:expr) => { 4841 | | vgetexppd(a.as_f64x8(), _mm512_setzero_pd().as_f64x8(), k, $imm4) ... | 4845 | | transmute(r) 4846 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4865:1 | 4865 | / pub unsafe fn _mm512_getmant_round_ps( 4866 | | a: __m512, 4867 | | norm: _MM_MANTISSA_NORM_ENUM, 4868 | | sign: _MM_MANTISSA_SIGN_ENUM, ... | 4883 | | transmute(r) 4884 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4903:1 | 4903 | / pub unsafe fn _mm512_mask_getmant_round_ps( 4904 | | src: __m512, 4905 | | k: __mmask16, 4906 | | a: __m512, ... | 4923 | | transmute(r) 4924 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4943:1 | 4943 | / pub unsafe fn _mm512_maskz_getmant_round_ps( 4944 | | k: __mmask16, 4945 | | a: __m512, 4946 | | norm: _MM_MANTISSA_NORM_ENUM, ... | 4962 | | transmute(r) 4963 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:4982:1 | 4982 | / pub unsafe fn _mm512_getmant_round_pd( 4983 | | a: __m512d, 4984 | | norm: _MM_MANTISSA_NORM_ENUM, 4985 | | sign: _MM_MANTISSA_SIGN_ENUM, ... | 5000 | | transmute(r) 5001 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5020:1 | 5020 | / pub unsafe fn _mm512_mask_getmant_round_pd( 5021 | | src: __m512d, 5022 | | k: __mmask8, 5023 | | a: __m512d, ... | 5040 | | transmute(r) 5041 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5060:1 | 5060 | / pub unsafe fn _mm512_maskz_getmant_round_pd( 5061 | | k: __mmask8, 5062 | | a: __m512d, 5063 | | norm: _MM_MANTISSA_NORM_ENUM, ... | 5079 | | transmute(r) 5080 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5088:1 | 5088 | / pub unsafe fn _mm512_cvtps_epi32(a: __m512) -> __m512i { 5089 | | transmute(vcvtps2dq( 5090 | | a.as_f32x16(), 5091 | | _mm512_setzero_si512().as_i32x16(), ... | 5094 | | )) 5095 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5103:1 | 5103 | / pub unsafe fn _mm512_mask_cvtps_epi32(src: __m512i, k: __mmask16, a: __m512) -> __m512i { 5104 | | transmute(vcvtps2dq( 5105 | | a.as_f32x16(), 5106 | | src.as_i32x16(), ... | 5109 | | )) 5110 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5118:1 | 5118 | / pub unsafe fn _mm512_maskz_cvtps_epi32(k: __mmask16, a: __m512) -> __m512i { 5119 | | transmute(vcvtps2dq( 5120 | | a.as_f32x16(), 5121 | | _mm512_setzero_si512().as_i32x16(), ... | 5124 | | )) 5125 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5133:1 | 5133 | / pub unsafe fn _mm512_cvtps_epu32(a: __m512) -> __m512i { 5134 | | transmute(vcvtps2udq( 5135 | | a.as_f32x16(), 5136 | | _mm512_setzero_si512().as_u32x16(), ... | 5139 | | )) 5140 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5148:1 | 5148 | / pub unsafe fn _mm512_mask_cvtps_epu32(src: __m512i, k: __mmask16, a: __m512) -> __m512i { 5149 | | transmute(vcvtps2udq( 5150 | | a.as_f32x16(), 5151 | | src.as_u32x16(), ... | 5154 | | )) 5155 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5163:1 | 5163 | / pub unsafe fn _mm512_maskz_cvtps_epu32(k: __mmask16, a: __m512) -> __m512i { 5164 | | transmute(vcvtps2udq( 5165 | | a.as_f32x16(), 5166 | | _mm512_setzero_si512().as_u32x16(), ... | 5169 | | )) 5170 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5178:1 | 5178 | / pub unsafe fn _mm512_cvtps_pd(a: __m256) -> __m512d { 5179 | | transmute(vcvtps2pd( 5180 | | a.as_f32x8(), 5181 | | _mm512_setzero_pd().as_f64x8(), ... | 5184 | | )) 5185 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5193:1 | 5193 | / pub unsafe fn _mm512_mask_cvtps_pd(src: __m512d, k: __mmask8, a: __m256) -> __m512d { 5194 | | transmute(vcvtps2pd( 5195 | | a.as_f32x8(), 5196 | | src.as_f64x8(), ... | 5199 | | )) 5200 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5208:1 | 5208 | / pub unsafe fn _mm512_maskz_cvtps_pd(k: __mmask8, a: __m256) -> __m512d { 5209 | | transmute(vcvtps2pd( 5210 | | a.as_f32x8(), 5211 | | _mm512_setzero_pd().as_f64x8(), ... | 5214 | | )) 5215 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5231:1 | 5231 | / pub unsafe fn _mm512_cvt_roundps_epi32(a: __m512, rounding: i32) -> __m512i { 5232 | | macro_rules! call { 5233 | | ($imm4:expr) => { 5234 | | vcvtps2dq( ... | 5243 | | transmute(r) 5244 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5260:1 | 5260 | / pub unsafe fn _mm512_mask_cvt_roundps_epi32( 5261 | | src: __m512i, 5262 | | k: __mmask16, 5263 | | a: __m512, ... | 5272 | | transmute(r) 5273 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5289:1 | 5289 | / pub unsafe fn _mm512_maskz_cvt_roundps_epi32(k: __mmask16, a: __m512, rounding: i32) -> __m512i { 5290 | | macro_rules! call { 5291 | | ($imm4:expr) => { 5292 | | vcvtps2dq(a.as_f32x16(), _mm512_setzero_si512().as_i32x16(), k, $imm4) ... | 5296 | | transmute(r) 5297 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5313:1 | 5313 | / pub unsafe fn _mm512_cvt_roundps_epu32(a: __m512, rounding: i32) -> __m512i { 5314 | | macro_rules! call { 5315 | | ($imm4:expr) => { 5316 | | vcvtps2udq( ... | 5325 | | transmute(r) 5326 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5342:1 | 5342 | / pub unsafe fn _mm512_mask_cvt_roundps_epu32( 5343 | | src: __m512i, 5344 | | k: __mmask16, 5345 | | a: __m512, ... | 5354 | | transmute(r) 5355 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5371:1 | 5371 | / pub unsafe fn _mm512_maskz_cvt_roundps_epu32(k: __mmask16, a: __m512, rounding: i32) -> __m512i { 5372 | | macro_rules! call { 5373 | | ($imm4:expr) => { 5374 | | vcvtps2udq(a.as_f32x16(), _mm512_setzero_si512().as_u32x16(), k, $imm4) ... | 5378 | | transmute(r) 5379 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5389:1 | 5389 | / pub unsafe fn _mm512_cvt_roundps_pd(a: __m256, sae: i32) -> __m512d { 5390 | | macro_rules! call { 5391 | | ($imm4:expr) => { 5392 | | vcvtps2pd( ... | 5401 | | transmute(r) 5402 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5412:1 | 5412 | / pub unsafe fn _mm512_mask_cvt_roundps_pd( 5413 | | src: __m512d, 5414 | | k: __mmask8, 5415 | | a: __m256, ... | 5424 | | transmute(r) 5425 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5435:1 | 5435 | / pub unsafe fn _mm512_maskz_cvt_roundps_pd(k: __mmask8, a: __m256, sae: i32) -> __m512d { 5436 | | macro_rules! call { 5437 | | ($imm4:expr) => { 5438 | | vcvtps2pd(a.as_f32x8(), _mm512_setzero_pd().as_f64x8(), k, $imm4) ... | 5442 | | transmute(r) 5443 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5453:1 | 5453 | / pub unsafe fn _mm512_cvtt_roundps_epi32(a: __m512, sae: i32) -> __m512i { 5454 | | macro_rules! call { 5455 | | ($imm4:expr) => { 5456 | | vcvttps2dq( ... | 5465 | | transmute(r) 5466 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5476:1 | 5476 | / pub unsafe fn _mm512_mask_cvtt_roundps_epi32( 5477 | | src: __m512i, 5478 | | k: __mmask16, 5479 | | a: __m512, ... | 5488 | | transmute(r) 5489 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5499:1 | 5499 | / pub unsafe fn _mm512_maskz_cvtt_roundps_epi32(k: __mmask16, a: __m512, sae: i32) -> __m512i { 5500 | | macro_rules! call { 5501 | | ($imm4:expr) => { 5502 | | vcvttps2dq(a.as_f32x16(), _mm512_setzero_si512().as_i32x16(), k, $imm4) ... | 5506 | | transmute(r) 5507 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5517:1 | 5517 | / pub unsafe fn _mm512_cvtt_roundps_epu32(a: __m512, sae: i32) -> __m512i { 5518 | | macro_rules! call { 5519 | | ($imm4:expr) => { 5520 | | vcvttps2udq( ... | 5529 | | transmute(r) 5530 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5540:1 | 5540 | / pub unsafe fn _mm512_mask_cvtt_roundps_epu32( 5541 | | src: __m512i, 5542 | | k: __mmask16, 5543 | | a: __m512, ... | 5552 | | transmute(r) 5553 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5563:1 | 5563 | / pub unsafe fn _mm512_maskz_cvtt_roundps_epu32(k: __mmask16, a: __m512, sae: i32) -> __m512i { 5564 | | macro_rules! call { 5565 | | ($imm4:expr) => { 5566 | | vcvttps2udq(a.as_f32x16(), _mm512_setzero_si512().as_i32x16(), k, $imm4) ... | 5570 | | transmute(r) 5571 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5581:1 | 5581 | / pub unsafe fn _mm512_cvtt_roundpd_epi32(a: __m512d, sae: i32) -> __m256i { 5582 | | macro_rules! call { 5583 | | ($imm4:expr) => { 5584 | | vcvttpd2dq( ... | 5593 | | transmute(r) 5594 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5604:1 | 5604 | / pub unsafe fn _mm512_mask_cvtt_roundpd_epi32( 5605 | | src: __m256i, 5606 | | k: __mmask8, 5607 | | a: __m512d, ... | 5616 | | transmute(r) 5617 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5627:1 | 5627 | / pub unsafe fn _mm512_maskz_cvtt_roundpd_epi32(k: __mmask8, a: __m512d, sae: i32) -> __m256i { 5628 | | macro_rules! call { 5629 | | ($imm4:expr) => { 5630 | | vcvttpd2dq(a.as_f64x8(), _mm256_setzero_si256().as_i32x8(), k, $imm4) ... | 5634 | | transmute(r) 5635 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5645:1 | 5645 | / pub unsafe fn _mm512_cvtt_roundpd_epu32(a: __m512d, sae: i32) -> __m256i { 5646 | | macro_rules! call { 5647 | | ($imm4:expr) => { 5648 | | vcvttpd2udq( ... | 5657 | | transmute(r) 5658 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5668:1 | 5668 | / pub unsafe fn _mm512_mask_cvtt_roundpd_epu32( 5669 | | src: __m256i, 5670 | | k: __mmask8, 5671 | | a: __m512d, ... | 5680 | | transmute(r) 5681 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5689:1 | 5689 | / pub unsafe fn _mm512_cvttps_epi32(a: __m512) -> __m512i { 5690 | | transmute(vcvttps2dq( 5691 | | a.as_f32x16(), 5692 | | _mm512_setzero_si512().as_i32x16(), ... | 5695 | | )) 5696 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5704:1 | 5704 | / pub unsafe fn _mm512_mask_cvttps_epi32(src: __m512i, k: __mmask16, a: __m512) -> __m512i { 5705 | | transmute(vcvttps2dq( 5706 | | a.as_f32x16(), 5707 | | src.as_i32x16(), ... | 5710 | | )) 5711 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5719:1 | 5719 | / pub unsafe fn _mm512_maskz_cvttps_epi32(k: __mmask16, a: __m512) -> __m512i { 5720 | | transmute(vcvttps2dq( 5721 | | a.as_f32x16(), 5722 | | _mm512_setzero_si512().as_i32x16(), ... | 5725 | | )) 5726 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5734:1 | 5734 | / pub unsafe fn _mm512_cvttps_epu32(a: __m512) -> __m512i { 5735 | | transmute(vcvttps2udq( 5736 | | a.as_f32x16(), 5737 | | _mm512_setzero_si512().as_i32x16(), ... | 5740 | | )) 5741 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5749:1 | 5749 | / pub unsafe fn _mm512_mask_cvttps_epu32(src: __m512i, k: __mmask16, a: __m512) -> __m512i { 5750 | | transmute(vcvttps2udq( 5751 | | a.as_f32x16(), 5752 | | src.as_i32x16(), ... | 5755 | | )) 5756 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5764:1 | 5764 | / pub unsafe fn _mm512_maskz_cvttps_epu32(k: __mmask16, a: __m512) -> __m512i { 5765 | | transmute(vcvttps2udq( 5766 | | a.as_f32x16(), 5767 | | _mm512_setzero_si512().as_i32x16(), ... | 5770 | | )) 5771 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5781:1 | 5781 | / pub unsafe fn _mm512_maskz_cvtt_roundpd_epu32(k: __mmask8, a: __m512d, sae: i32) -> __m256i { 5782 | | macro_rules! call { 5783 | | ($imm4:expr) => { 5784 | | vcvttpd2udq(a.as_f64x8(), _mm256_setzero_si256().as_i32x8(), k, $imm4) ... | 5788 | | transmute(r) 5789 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5797:1 | 5797 | / pub unsafe fn _mm512_cvttpd_epi32(a: __m512d) -> __m256i { 5798 | | transmute(vcvttpd2dq( 5799 | | a.as_f64x8(), 5800 | | _mm256_setzero_si256().as_i32x8(), ... | 5803 | | )) 5804 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5812:1 | 5812 | / pub unsafe fn _mm512_mask_cvttpd_epi32(src: __m256i, k: __mmask8, a: __m512d) -> __m256i { 5813 | | transmute(vcvttpd2dq( 5814 | | a.as_f64x8(), 5815 | | src.as_i32x8(), ... | 5818 | | )) 5819 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5827:1 | 5827 | / pub unsafe fn _mm512_maskz_cvttpd_epi32(k: __mmask8, a: __m512d) -> __m256i { 5828 | | transmute(vcvttpd2dq( 5829 | | a.as_f64x8(), 5830 | | _mm256_setzero_si256().as_i32x8(), ... | 5833 | | )) 5834 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5842:1 | 5842 | / pub unsafe fn _mm512_cvttpd_epu32(a: __m512d) -> __m256i { 5843 | | transmute(vcvttpd2udq( 5844 | | a.as_f64x8(), 5845 | | _mm256_setzero_si256().as_i32x8(), ... | 5848 | | )) 5849 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5857:1 | 5857 | / pub unsafe fn _mm512_mask_cvttpd_epu32(src: __m256i, k: __mmask8, a: __m512d) -> __m256i { 5858 | | transmute(vcvttpd2udq( 5859 | | a.as_f64x8(), 5860 | | src.as_i32x8(), ... | 5863 | | )) 5864 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5872:1 | 5872 | / pub unsafe fn _mm512_maskz_cvttpd_epu32(k: __mmask8, a: __m512d) -> __m256i { 5873 | | transmute(vcvttpd2udq( 5874 | | a.as_f64x8(), 5875 | | _mm256_setzero_si256().as_i32x8(), ... | 5878 | | )) 5879 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5887:1 | 5887 | / pub unsafe fn _mm512_setzero_pd() -> __m512d { 5888 | | // All-0 is a properly initialized __m512d 5889 | | mem::zeroed() 5890 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5898:1 | 5898 | / pub unsafe fn _mm512_setzero_ps() -> __m512 { 5899 | | // All-0 is a properly initialized __m512 5900 | | mem::zeroed() 5901 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5909:1 | 5909 | / pub unsafe fn _mm512_setzero_si512() -> __m512i { 5910 | | // All-0 is a properly initialized __m512i 5911 | | mem::zeroed() 5912 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5918:1 | 5918 | / pub unsafe fn _mm512_setr_epi32( 5919 | | e15: i32, 5920 | | e14: i32, 5921 | | e13: i32, ... | 5939 | | transmute(r) 5940 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5918:1 | 5918 | / pub unsafe fn _mm512_setr_epi32( 5919 | | e15: i32, 5920 | | e14: i32, 5921 | | e13: i32, ... | 5934 | | e0: i32, 5935 | | ) -> __m512i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5949:1 | 5949 | / pub unsafe fn _mm512_i32gather_pd(offsets: __m256i, slice: *const u8, scale: i32) -> __m512d { 5950 | | let zero = _mm512_setzero_pd().as_f64x8(); 5951 | | let neg_one = -1; 5952 | | let slice = slice as *const i8; ... | 5960 | | transmute(r) 5961 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5970:1 | 5970 | / pub unsafe fn _mm512_mask_i32gather_pd( 5971 | | src: __m512d, 5972 | | mask: __mmask8, 5973 | | offsets: __m256i, ... | 5986 | | transmute(r) 5987 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:5996:1 | 5996 | / pub unsafe fn _mm512_i64gather_pd(offsets: __m512i, slice: *const u8, scale: i32) -> __m512d { 5997 | | let zero = _mm512_setzero_pd().as_f64x8(); 5998 | | let neg_one = -1; 5999 | | let slice = slice as *const i8; ... | 6007 | | transmute(r) 6008 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6017:1 | 6017 | / pub unsafe fn _mm512_mask_i64gather_pd( 6018 | | src: __m512d, 6019 | | mask: __mmask8, 6020 | | offsets: __m512i, ... | 6033 | | transmute(r) 6034 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6043:1 | 6043 | / pub unsafe fn _mm512_i64gather_ps(offsets: __m512i, slice: *const u8, scale: i32) -> __m256 { 6044 | | let zero = _mm256_setzero_ps().as_f32x8(); 6045 | | let neg_one = -1; 6046 | | let slice = slice as *const i8; ... | 6054 | | transmute(r) 6055 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6064:1 | 6064 | / pub unsafe fn _mm512_mask_i64gather_ps( 6065 | | src: __m256, 6066 | | mask: __mmask8, 6067 | | offsets: __m512i, ... | 6080 | | transmute(r) 6081 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6090:1 | 6090 | / pub unsafe fn _mm512_i32gather_ps(offsets: __m512i, slice: *const u8, scale: i32) -> __m512 { 6091 | | let zero = _mm512_setzero_ps().as_f32x16(); 6092 | | let neg_one = -1; 6093 | | let slice = slice as *const i8; ... | 6101 | | transmute(r) 6102 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6111:1 | 6111 | / pub unsafe fn _mm512_mask_i32gather_ps( 6112 | | src: __m512, 6113 | | mask: __mmask16, 6114 | | offsets: __m512i, ... | 6127 | | transmute(r) 6128 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6137:1 | 6137 | / pub unsafe fn _mm512_i32gather_epi32(offsets: __m512i, slice: *const u8, scale: i32) -> __m512i { 6138 | | let zero = _mm512_setzero_si512().as_i32x16(); 6139 | | let neg_one = -1; 6140 | | let slice = slice as *const i8; ... | 6148 | | transmute(r) 6149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6158:1 | 6158 | / pub unsafe fn _mm512_mask_i32gather_epi32( 6159 | | src: __m512i, 6160 | | mask: __mmask16, 6161 | | offsets: __m512i, ... | 6175 | | transmute(r) 6176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6185:1 | 6185 | / pub unsafe fn _mm512_i32gather_epi64(offsets: __m256i, slice: *const u8, scale: i32) -> __m512i { 6186 | | let zero = _mm512_setzero_si512().as_i64x8(); 6187 | | let neg_one = -1; 6188 | | let slice = slice as *const i8; ... | 6196 | | transmute(r) 6197 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6206:1 | 6206 | / pub unsafe fn _mm512_mask_i32gather_epi64( 6207 | | src: __m512i, 6208 | | mask: __mmask8, 6209 | | offsets: __m256i, ... | 6223 | | transmute(r) 6224 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6233:1 | 6233 | / pub unsafe fn _mm512_i64gather_epi64(offsets: __m512i, slice: *const u8, scale: i32) -> __m512i { 6234 | | let zero = _mm512_setzero_si512().as_i64x8(); 6235 | | let neg_one = -1; 6236 | | let slice = slice as *const i8; ... | 6244 | | transmute(r) 6245 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6254:1 | 6254 | / pub unsafe fn _mm512_mask_i64gather_epi64( 6255 | | src: __m512i, 6256 | | mask: __mmask8, 6257 | | offsets: __m512i, ... | 6271 | | transmute(r) 6272 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6281:1 | 6281 | / pub unsafe fn _mm512_i64gather_epi32(offsets: __m512i, slice: *const u8, scale: i32) -> __m256i { 6282 | | let zeros = _mm256_setzero_si256().as_i32x8(); 6283 | | let neg_one = -1; 6284 | | let slice = slice as *const i8; ... | 6292 | | transmute(r) 6293 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6302:1 | 6302 | / pub unsafe fn _mm512_mask_i64gather_epi32( 6303 | | src: __m256i, 6304 | | mask: __mmask8, 6305 | | offsets: __m512i, ... | 6319 | | transmute(r) 6320 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6329:1 | 6329 | / pub unsafe fn _mm512_i32scatter_pd(slice: *mut u8, offsets: __m256i, src: __m512d, scale: i32) { 6330 | | let src = src.as_f64x8(); 6331 | | let neg_one = -1; 6332 | | let slice = slice as *mut i8; ... | 6339 | | constify_imm8_gather!(scale, call); 6340 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6349:1 | 6349 | / pub unsafe fn _mm512_mask_i32scatter_pd( 6350 | | slice: *mut u8, 6351 | | mask: __mmask8, 6352 | | offsets: __m256i, ... | 6364 | | constify_imm8_gather!(scale, call); 6365 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6374:1 | 6374 | / pub unsafe fn _mm512_i64scatter_pd(slice: *mut u8, offsets: __m512i, src: __m512d, scale: i32) { 6375 | | let src = src.as_f64x8(); 6376 | | let neg_one = -1; 6377 | | let slice = slice as *mut i8; ... | 6384 | | constify_imm8_gather!(scale, call); 6385 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6394:1 | 6394 | / pub unsafe fn _mm512_mask_i64scatter_pd( 6395 | | slice: *mut u8, 6396 | | mask: __mmask8, 6397 | | offsets: __m512i, ... | 6409 | | constify_imm8_gather!(scale, call); 6410 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6419:1 | 6419 | / pub unsafe fn _mm512_i32scatter_ps(slice: *mut u8, offsets: __m512i, src: __m512, scale: i32) { 6420 | | let src = src.as_f32x16(); 6421 | | let neg_one = -1; 6422 | | let slice = slice as *mut i8; ... | 6429 | | constify_imm8_gather!(scale, call); 6430 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6439:1 | 6439 | / pub unsafe fn _mm512_mask_i32scatter_ps( 6440 | | slice: *mut u8, 6441 | | mask: __mmask16, 6442 | | offsets: __m512i, ... | 6454 | | constify_imm8_gather!(scale, call); 6455 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6464:1 | 6464 | / pub unsafe fn _mm512_i64scatter_ps(slice: *mut u8, offsets: __m512i, src: __m256, scale: i32) { 6465 | | let src = src.as_f32x8(); 6466 | | let neg_one = -1; 6467 | | let slice = slice as *mut i8; ... | 6474 | | constify_imm8_gather!(scale, call); 6475 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6484:1 | 6484 | / pub unsafe fn _mm512_mask_i64scatter_ps( 6485 | | slice: *mut u8, 6486 | | mask: __mmask8, 6487 | | offsets: __m512i, ... | 6499 | | constify_imm8_gather!(scale, call); 6500 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6509:1 | 6509 | / pub unsafe fn _mm512_i32scatter_epi64(slice: *mut u8, offsets: __m256i, src: __m512i, scale: i32) { 6510 | | let src = src.as_i64x8(); 6511 | | let neg_one = -1; 6512 | | let slice = slice as *mut i8; ... | 6519 | | constify_imm8_gather!(scale, call); 6520 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6529:1 | 6529 | / pub unsafe fn _mm512_mask_i32scatter_epi64( 6530 | | slice: *mut u8, 6531 | | mask: __mmask8, 6532 | | offsets: __m256i, ... | 6545 | | constify_imm8_gather!(scale, call); 6546 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6555:1 | 6555 | / pub unsafe fn _mm512_i64scatter_epi64(slice: *mut u8, offsets: __m512i, src: __m512i, scale: i32) { 6556 | | let src = src.as_i64x8(); 6557 | | let neg_one = -1; 6558 | | let slice = slice as *mut i8; ... | 6565 | | constify_imm8_gather!(scale, call); 6566 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6575:1 | 6575 | / pub unsafe fn _mm512_mask_i64scatter_epi64( 6576 | | slice: *mut u8, 6577 | | mask: __mmask8, 6578 | | offsets: __m512i, ... | 6591 | | constify_imm8_gather!(scale, call); 6592 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6601:1 | 6601 | / pub unsafe fn _mm512_i32scatter_epi32(slice: *mut u8, offsets: __m512i, src: __m512i, scale: i32) { 6602 | | let src = src.as_i32x16(); 6603 | | let neg_one = -1; 6604 | | let slice = slice as *mut i8; ... | 6611 | | constify_imm8_gather!(scale, call); 6612 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6621:1 | 6621 | / pub unsafe fn _mm512_mask_i32scatter_epi32( 6622 | | slice: *mut u8, 6623 | | mask: __mmask16, 6624 | | offsets: __m512i, ... | 6637 | | constify_imm8_gather!(scale, call); 6638 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6647:1 | 6647 | / pub unsafe fn _mm512_i64scatter_epi32(slice: *mut u8, offsets: __m512i, src: __m256i, scale: i32) { 6648 | | let src = src.as_i32x8(); 6649 | | let neg_one = -1; 6650 | | let slice = slice as *mut i8; ... | 6657 | | constify_imm8_gather!(scale, call); 6658 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6667:1 | 6667 | / pub unsafe fn _mm512_mask_i64scatter_epi32( 6668 | | slice: *mut u8, 6669 | | mask: __mmask8, 6670 | | offsets: __m512i, ... | 6683 | | constify_imm8_gather!(scale, call); 6684 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6693:1 | 6693 | / pub unsafe fn _mm512_rol_epi32(a: __m512i, imm8: i32) -> __m512i { 6694 | | macro_rules! call { 6695 | | ($imm8:expr) => { 6696 | | vprold(a.as_i32x16(), $imm8) ... | 6700 | | transmute(r) 6701 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6710:1 | 6710 | / pub unsafe fn _mm512_mask_rol_epi32(src: __m512i, k: __mmask16, a: __m512i, imm8: i32) -> __m512i { 6711 | | macro_rules! call { 6712 | | ($imm8:expr) => { 6713 | | vprold(a.as_i32x16(), $imm8) ... | 6717 | | transmute(simd_select_bitmask(k, rol, src.as_i32x16())) 6718 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6727:1 | 6727 | / pub unsafe fn _mm512_maskz_rol_epi32(k: __mmask16, a: __m512i, imm8: i32) -> __m512i { 6728 | | macro_rules! call { 6729 | | ($imm8:expr) => { 6730 | | vprold(a.as_i32x16(), $imm8) ... | 6735 | | transmute(simd_select_bitmask(k, rol, zero)) 6736 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6745:1 | 6745 | / pub unsafe fn _mm512_ror_epi32(a: __m512i, imm8: i32) -> __m512i { 6746 | | macro_rules! call { 6747 | | ($imm8:expr) => { 6748 | | vprord(a.as_i32x16(), $imm8) ... | 6752 | | transmute(r) 6753 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6762:1 | 6762 | / pub unsafe fn _mm512_mask_ror_epi32(src: __m512i, k: __mmask16, a: __m512i, imm8: i32) -> __m512i { 6763 | | macro_rules! call { 6764 | | ($imm8:expr) => { 6765 | | vprord(a.as_i32x16(), $imm8) ... | 6769 | | transmute(simd_select_bitmask(k, ror, src.as_i32x16())) 6770 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6779:1 | 6779 | / pub unsafe fn _mm512_maskz_ror_epi32(k: __mmask16, a: __m512i, imm8: i32) -> __m512i { 6780 | | macro_rules! call { 6781 | | ($imm8:expr) => { 6782 | | vprord(a.as_i32x16(), $imm8) ... | 6787 | | transmute(simd_select_bitmask(k, ror, zero)) 6788 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6797:1 | 6797 | / pub unsafe fn _mm512_rol_epi64(a: __m512i, imm8: i32) -> __m512i { 6798 | | macro_rules! call { 6799 | | ($imm8:expr) => { 6800 | | vprolq(a.as_i64x8(), $imm8) ... | 6804 | | transmute(r) 6805 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6814:1 | 6814 | / pub unsafe fn _mm512_mask_rol_epi64(src: __m512i, k: __mmask8, a: __m512i, imm8: i32) -> __m512i { 6815 | | macro_rules! call { 6816 | | ($imm8:expr) => { 6817 | | vprolq(a.as_i64x8(), $imm8) ... | 6821 | | transmute(simd_select_bitmask(k, rol, src.as_i64x8())) 6822 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6831:1 | 6831 | / pub unsafe fn _mm512_maskz_rol_epi64(k: __mmask8, a: __m512i, imm8: i32) -> __m512i { 6832 | | macro_rules! call { 6833 | | ($imm8:expr) => { 6834 | | vprolq(a.as_i64x8(), $imm8) ... | 6839 | | transmute(simd_select_bitmask(k, rol, zero)) 6840 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6849:1 | 6849 | / pub unsafe fn _mm512_ror_epi64(a: __m512i, imm8: i32) -> __m512i { 6850 | | macro_rules! call { 6851 | | ($imm8:expr) => { 6852 | | vprorq(a.as_i64x8(), $imm8) ... | 6856 | | transmute(r) 6857 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6866:1 | 6866 | / pub unsafe fn _mm512_mask_ror_epi64(src: __m512i, k: __mmask8, a: __m512i, imm8: i32) -> __m512i { 6867 | | macro_rules! call { 6868 | | ($imm8:expr) => { 6869 | | vprorq(a.as_i64x8(), $imm8) ... | 6873 | | transmute(simd_select_bitmask(k, ror, src.as_i64x8())) 6874 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6883:1 | 6883 | / pub unsafe fn _mm512_maskz_ror_epi64(k: __mmask8, a: __m512i, imm8: i32) -> __m512i { 6884 | | macro_rules! call { 6885 | | ($imm8:expr) => { 6886 | | vprorq(a.as_i64x8(), $imm8) ... | 6891 | | transmute(simd_select_bitmask(k, ror, zero)) 6892 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6901:1 | 6901 | / pub unsafe fn _mm512_slli_epi32(a: __m512i, imm8: u32) -> __m512i { 6902 | | macro_rules! call { 6903 | | ($imm8:expr) => { 6904 | | vpsllid(a.as_i32x16(), $imm8) ... | 6908 | | transmute(r) 6909 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6918:1 | 6918 | / pub unsafe fn _mm512_mask_slli_epi32(src: __m512i, k: __mmask16, a: __m512i, imm8: u32) -> __m512i { 6919 | | macro_rules! call { 6920 | | ($imm8:expr) => { 6921 | | vpsllid(a.as_i32x16(), $imm8) ... | 6925 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 6926 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6935:1 | 6935 | / pub unsafe fn _mm512_maskz_slli_epi32(k: __mmask16, a: __m512i, imm8: u32) -> __m512i { 6936 | | macro_rules! call { 6937 | | ($imm8:expr) => { 6938 | | vpsllid(a.as_i32x16(), $imm8) ... | 6943 | | transmute(simd_select_bitmask(k, shf, zero)) 6944 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6953:1 | 6953 | / pub unsafe fn _mm512_srli_epi32(a: __m512i, imm8: u32) -> __m512i { 6954 | | macro_rules! call { 6955 | | ($imm8:expr) => { 6956 | | vpsrlid(a.as_i32x16(), $imm8) ... | 6960 | | transmute(r) 6961 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6970:1 | 6970 | / pub unsafe fn _mm512_mask_srli_epi32(src: __m512i, k: __mmask16, a: __m512i, imm8: u32) -> __m512i { 6971 | | macro_rules! call { 6972 | | ($imm8:expr) => { 6973 | | vpsrlid(a.as_i32x16(), $imm8) ... | 6977 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 6978 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:6987:1 | 6987 | / pub unsafe fn _mm512_maskz_srli_epi32(k: __mmask16, a: __m512i, imm8: u32) -> __m512i { 6988 | | macro_rules! call { 6989 | | ($imm8:expr) => { 6990 | | vpsrlid(a.as_i32x16(), $imm8) ... | 6995 | | transmute(simd_select_bitmask(k, shf, zero)) 6996 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7005:1 | 7005 | / pub unsafe fn _mm512_slli_epi64(a: __m512i, imm8: u32) -> __m512i { 7006 | | macro_rules! call { 7007 | | ($imm8:expr) => { 7008 | | vpslliq(a.as_i64x8(), $imm8) ... | 7012 | | transmute(r) 7013 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7022:1 | 7022 | / pub unsafe fn _mm512_mask_slli_epi64(src: __m512i, k: __mmask8, a: __m512i, imm8: u32) -> __m512i { 7023 | | macro_rules! call { 7024 | | ($imm8:expr) => { 7025 | | vpslliq(a.as_i64x8(), $imm8) ... | 7029 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7030 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7039:1 | 7039 | / pub unsafe fn _mm512_maskz_slli_epi64(k: __mmask8, a: __m512i, imm8: u32) -> __m512i { 7040 | | macro_rules! call { 7041 | | ($imm8:expr) => { 7042 | | vpslliq(a.as_i64x8(), $imm8) ... | 7047 | | transmute(simd_select_bitmask(k, shf, zero)) 7048 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7057:1 | 7057 | / pub unsafe fn _mm512_srli_epi64(a: __m512i, imm8: u32) -> __m512i { 7058 | | macro_rules! call { 7059 | | ($imm8:expr) => { 7060 | | vpsrliq(a.as_i64x8(), $imm8) ... | 7064 | | transmute(r) 7065 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7074:1 | 7074 | / pub unsafe fn _mm512_mask_srli_epi64(src: __m512i, k: __mmask8, a: __m512i, imm8: u32) -> __m512i { 7075 | | macro_rules! call { 7076 | | ($imm8:expr) => { 7077 | | vpsrliq(a.as_i64x8(), $imm8) ... | 7081 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7082 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7091:1 | 7091 | / pub unsafe fn _mm512_maskz_srli_epi64(k: __mmask8, a: __m512i, imm8: u32) -> __m512i { 7092 | | macro_rules! call { 7093 | | ($imm8:expr) => { 7094 | | vpsrliq(a.as_i64x8(), $imm8) ... | 7099 | | transmute(simd_select_bitmask(k, shf, zero)) 7100 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7108:1 | 7108 | / pub unsafe fn _mm512_sll_epi32(a: __m512i, count: __m128i) -> __m512i { 7109 | | transmute(vpslld(a.as_i32x16(), count.as_i32x4())) 7110 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7118:1 | 7118 | / pub unsafe fn _mm512_mask_sll_epi32( 7119 | | src: __m512i, 7120 | | k: __mmask16, 7121 | | a: __m512i, ... | 7125 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7126 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7134:1 | 7134 | / pub unsafe fn _mm512_maskz_sll_epi32(k: __mmask16, a: __m512i, count: __m128i) -> __m512i { 7135 | | let shf = _mm512_sll_epi32(a, count).as_i32x16(); 7136 | | let zero = _mm512_setzero_si512().as_i32x16(); 7137 | | transmute(simd_select_bitmask(k, shf, zero)) 7138 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7146:1 | 7146 | / pub unsafe fn _mm512_srl_epi32(a: __m512i, count: __m128i) -> __m512i { 7147 | | transmute(vpsrld(a.as_i32x16(), count.as_i32x4())) 7148 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7156:1 | 7156 | / pub unsafe fn _mm512_mask_srl_epi32( 7157 | | src: __m512i, 7158 | | k: __mmask16, 7159 | | a: __m512i, ... | 7163 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7164 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7172:1 | 7172 | / pub unsafe fn _mm512_maskz_srl_epi32(k: __mmask16, a: __m512i, count: __m128i) -> __m512i { 7173 | | let shf = _mm512_srl_epi32(a, count).as_i32x16(); 7174 | | let zero = _mm512_setzero_si512().as_i32x16(); 7175 | | transmute(simd_select_bitmask(k, shf, zero)) 7176 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7184:1 | 7184 | / pub unsafe fn _mm512_sll_epi64(a: __m512i, count: __m128i) -> __m512i { 7185 | | transmute(vpsllq(a.as_i64x8(), count.as_i64x2())) 7186 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7194:1 | 7194 | / pub unsafe fn _mm512_mask_sll_epi64( 7195 | | src: __m512i, 7196 | | k: __mmask8, 7197 | | a: __m512i, ... | 7201 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7202 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7210:1 | 7210 | / pub unsafe fn _mm512_maskz_sll_epi64(k: __mmask8, a: __m512i, count: __m128i) -> __m512i { 7211 | | let shf = _mm512_sll_epi64(a, count).as_i64x8(); 7212 | | let zero = _mm512_setzero_si512().as_i64x8(); 7213 | | transmute(simd_select_bitmask(k, shf, zero)) 7214 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7222:1 | 7222 | / pub unsafe fn _mm512_srl_epi64(a: __m512i, count: __m128i) -> __m512i { 7223 | | transmute(vpsrlq(a.as_i64x8(), count.as_i64x2())) 7224 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7232:1 | 7232 | / pub unsafe fn _mm512_mask_srl_epi64( 7233 | | src: __m512i, 7234 | | k: __mmask8, 7235 | | a: __m512i, ... | 7239 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7240 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7248:1 | 7248 | / pub unsafe fn _mm512_maskz_srl_epi64(k: __mmask8, a: __m512i, count: __m128i) -> __m512i { 7249 | | let shf = _mm512_srl_epi64(a, count).as_i64x8(); 7250 | | let zero = _mm512_setzero_si512().as_i64x8(); 7251 | | transmute(simd_select_bitmask(k, shf, zero)) 7252 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7260:1 | 7260 | / pub unsafe fn _mm512_sra_epi32(a: __m512i, count: __m128i) -> __m512i { 7261 | | transmute(vpsrad(a.as_i32x16(), count.as_i32x4())) 7262 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7270:1 | 7270 | / pub unsafe fn _mm512_mask_sra_epi32( 7271 | | src: __m512i, 7272 | | k: __mmask16, 7273 | | a: __m512i, ... | 7277 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7278 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7286:1 | 7286 | / pub unsafe fn _mm512_maskz_sra_epi32(k: __mmask16, a: __m512i, count: __m128i) -> __m512i { 7287 | | let shf = _mm512_sra_epi32(a, count).as_i32x16(); 7288 | | let zero = _mm512_setzero_si512().as_i32x16(); 7289 | | transmute(simd_select_bitmask(k, shf, zero)) 7290 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7298:1 | 7298 | / pub unsafe fn _mm512_sra_epi64(a: __m512i, count: __m128i) -> __m512i { 7299 | | transmute(vpsraq(a.as_i64x8(), count.as_i64x2())) 7300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7308:1 | 7308 | / pub unsafe fn _mm512_mask_sra_epi64( 7309 | | src: __m512i, 7310 | | k: __mmask8, 7311 | | a: __m512i, ... | 7315 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7316 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7324:1 | 7324 | / pub unsafe fn _mm512_maskz_sra_epi64(k: __mmask8, a: __m512i, count: __m128i) -> __m512i { 7325 | | let shf = _mm512_sra_epi64(a, count).as_i64x8(); 7326 | | let zero = _mm512_setzero_si512().as_i64x8(); 7327 | | transmute(simd_select_bitmask(k, shf, zero)) 7328 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7337:1 | 7337 | / pub unsafe fn _mm512_srai_epi32(a: __m512i, imm8: u32) -> __m512i { 7338 | | macro_rules! call { 7339 | | ($imm8:expr) => { 7340 | | vpsraid(a.as_i32x16(), $imm8) ... | 7344 | | transmute(r) 7345 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7354:1 | 7354 | / pub unsafe fn _mm512_mask_srai_epi32(src: __m512i, k: __mmask16, a: __m512i, imm8: u32) -> __m512i { 7355 | | macro_rules! call { 7356 | | ($imm8:expr) => { 7357 | | vpsraid(a.as_i32x16(), $imm8) ... | 7361 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7362 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7371:1 | 7371 | / pub unsafe fn _mm512_maskz_srai_epi32(k: __mmask16, a: __m512i, imm8: u32) -> __m512i { 7372 | | macro_rules! call { 7373 | | ($imm8:expr) => { 7374 | | vpsraid(a.as_i32x16(), $imm8) ... | 7379 | | transmute(simd_select_bitmask(k, shf, zero)) 7380 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7389:1 | 7389 | / pub unsafe fn _mm512_srai_epi64(a: __m512i, imm8: u32) -> __m512i { 7390 | | macro_rules! call { 7391 | | ($imm8:expr) => { 7392 | | vpsraiq(a.as_i64x8(), $imm8) ... | 7396 | | transmute(r) 7397 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7406:1 | 7406 | / pub unsafe fn _mm512_mask_srai_epi64(src: __m512i, k: __mmask8, a: __m512i, imm8: u32) -> __m512i { 7407 | | macro_rules! call { 7408 | | ($imm8:expr) => { 7409 | | vpsraiq(a.as_i64x8(), $imm8) ... | 7413 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7414 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7423:1 | 7423 | / pub unsafe fn _mm512_maskz_srai_epi64(k: __mmask8, a: __m512i, imm8: u32) -> __m512i { 7424 | | macro_rules! call { 7425 | | ($imm8:expr) => { 7426 | | vpsraiq(a.as_i64x8(), $imm8) ... | 7431 | | transmute(simd_select_bitmask(k, shf, zero)) 7432 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7440:1 | 7440 | / pub unsafe fn _mm512_srav_epi32(a: __m512i, count: __m512i) -> __m512i { 7441 | | transmute(vpsravd(a.as_i32x16(), count.as_i32x16())) 7442 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7450:1 | 7450 | / pub unsafe fn _mm512_mask_srav_epi32( 7451 | | src: __m512i, 7452 | | k: __mmask16, 7453 | | a: __m512i, ... | 7457 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7458 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7466:1 | 7466 | / pub unsafe fn _mm512_maskz_srav_epi32(k: __mmask16, a: __m512i, count: __m512i) -> __m512i { 7467 | | let shf = _mm512_srav_epi32(a, count).as_i32x16(); 7468 | | let zero = _mm512_setzero_si512().as_i32x16(); 7469 | | transmute(simd_select_bitmask(k, shf, zero)) 7470 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7478:1 | 7478 | / pub unsafe fn _mm512_srav_epi64(a: __m512i, count: __m512i) -> __m512i { 7479 | | transmute(vpsravq(a.as_i64x8(), count.as_i64x8())) 7480 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7488:1 | 7488 | / pub unsafe fn _mm512_mask_srav_epi64( 7489 | | src: __m512i, 7490 | | k: __mmask8, 7491 | | a: __m512i, ... | 7495 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7496 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7504:1 | 7504 | / pub unsafe fn _mm512_maskz_srav_epi64(k: __mmask8, a: __m512i, count: __m512i) -> __m512i { 7505 | | let shf = _mm512_srav_epi64(a, count).as_i64x8(); 7506 | | let zero = _mm512_setzero_si512().as_i64x8(); 7507 | | transmute(simd_select_bitmask(k, shf, zero)) 7508 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7516:1 | 7516 | / pub unsafe fn _mm512_rolv_epi32(a: __m512i, b: __m512i) -> __m512i { 7517 | | transmute(vprolvd(a.as_i32x16(), b.as_i32x16())) 7518 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7526:1 | 7526 | / pub unsafe fn _mm512_mask_rolv_epi32( 7527 | | src: __m512i, 7528 | | k: __mmask16, 7529 | | a: __m512i, ... | 7533 | | transmute(simd_select_bitmask(k, rol, src.as_i32x16())) 7534 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7542:1 | 7542 | / pub unsafe fn _mm512_maskz_rolv_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 7543 | | let rol = _mm512_rolv_epi32(a, b).as_i32x16(); 7544 | | let zero = _mm512_setzero_si512().as_i32x16(); 7545 | | transmute(simd_select_bitmask(k, rol, zero)) 7546 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7554:1 | 7554 | / pub unsafe fn _mm512_rorv_epi32(a: __m512i, b: __m512i) -> __m512i { 7555 | | transmute(vprorvd(a.as_i32x16(), b.as_i32x16())) 7556 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7564:1 | 7564 | / pub unsafe fn _mm512_mask_rorv_epi32( 7565 | | src: __m512i, 7566 | | k: __mmask16, 7567 | | a: __m512i, ... | 7571 | | transmute(simd_select_bitmask(k, ror, src.as_i32x16())) 7572 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7580:1 | 7580 | / pub unsafe fn _mm512_maskz_rorv_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 7581 | | let ror = _mm512_rorv_epi32(a, b).as_i32x16(); 7582 | | let zero = _mm512_setzero_si512().as_i32x16(); 7583 | | transmute(simd_select_bitmask(k, ror, zero)) 7584 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7592:1 | 7592 | / pub unsafe fn _mm512_rolv_epi64(a: __m512i, b: __m512i) -> __m512i { 7593 | | transmute(vprolvq(a.as_i64x8(), b.as_i64x8())) 7594 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7602:1 | 7602 | / pub unsafe fn _mm512_mask_rolv_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 7603 | | let rol = _mm512_rolv_epi64(a, b).as_i64x8(); 7604 | | transmute(simd_select_bitmask(k, rol, src.as_i64x8())) 7605 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7613:1 | 7613 | / pub unsafe fn _mm512_maskz_rolv_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 7614 | | let rol = _mm512_rolv_epi64(a, b).as_i64x8(); 7615 | | let zero = _mm512_setzero_si512().as_i64x8(); 7616 | | transmute(simd_select_bitmask(k, rol, zero)) 7617 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7625:1 | 7625 | / pub unsafe fn _mm512_rorv_epi64(a: __m512i, b: __m512i) -> __m512i { 7626 | | transmute(vprorvq(a.as_i64x8(), b.as_i64x8())) 7627 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7635:1 | 7635 | / pub unsafe fn _mm512_mask_rorv_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 7636 | | let ror = _mm512_rorv_epi64(a, b).as_i64x8(); 7637 | | transmute(simd_select_bitmask(k, ror, src.as_i64x8())) 7638 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7646:1 | 7646 | / pub unsafe fn _mm512_maskz_rorv_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 7647 | | let ror = _mm512_rorv_epi64(a, b).as_i64x8(); 7648 | | let zero = _mm512_setzero_si512().as_i64x8(); 7649 | | transmute(simd_select_bitmask(k, ror, zero)) 7650 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7658:1 | 7658 | / pub unsafe fn _mm512_sllv_epi32(a: __m512i, count: __m512i) -> __m512i { 7659 | | transmute(vpsllvd(a.as_i32x16(), count.as_i32x16())) 7660 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7668:1 | 7668 | / pub unsafe fn _mm512_mask_sllv_epi32( 7669 | | src: __m512i, 7670 | | k: __mmask16, 7671 | | a: __m512i, ... | 7675 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7676 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7684:1 | 7684 | / pub unsafe fn _mm512_maskz_sllv_epi32(k: __mmask16, a: __m512i, count: __m512i) -> __m512i { 7685 | | let shf = _mm512_sllv_epi32(a, count).as_i32x16(); 7686 | | let zero = _mm512_setzero_si512().as_i32x16(); 7687 | | transmute(simd_select_bitmask(k, shf, zero)) 7688 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7696:1 | 7696 | / pub unsafe fn _mm512_srlv_epi32(a: __m512i, count: __m512i) -> __m512i { 7697 | | transmute(vpsrlvd(a.as_i32x16(), count.as_i32x16())) 7698 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7706:1 | 7706 | / pub unsafe fn _mm512_mask_srlv_epi32( 7707 | | src: __m512i, 7708 | | k: __mmask16, 7709 | | a: __m512i, ... | 7713 | | transmute(simd_select_bitmask(k, shf, src.as_i32x16())) 7714 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7722:1 | 7722 | / pub unsafe fn _mm512_maskz_srlv_epi32(k: __mmask16, a: __m512i, count: __m512i) -> __m512i { 7723 | | let shf = _mm512_srlv_epi32(a, count).as_i32x16(); 7724 | | let zero = _mm512_setzero_si512().as_i32x16(); 7725 | | transmute(simd_select_bitmask(k, shf, zero)) 7726 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7734:1 | 7734 | / pub unsafe fn _mm512_sllv_epi64(a: __m512i, count: __m512i) -> __m512i { 7735 | | transmute(vpsllvq(a.as_i64x8(), count.as_i64x8())) 7736 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7744:1 | 7744 | / pub unsafe fn _mm512_mask_sllv_epi64( 7745 | | src: __m512i, 7746 | | k: __mmask8, 7747 | | a: __m512i, ... | 7751 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7752 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7760:1 | 7760 | / pub unsafe fn _mm512_maskz_sllv_epi64(k: __mmask8, a: __m512i, count: __m512i) -> __m512i { 7761 | | let shf = _mm512_sllv_epi64(a, count).as_i64x8(); 7762 | | let zero = _mm512_setzero_si512().as_i64x8(); 7763 | | transmute(simd_select_bitmask(k, shf, zero)) 7764 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7772:1 | 7772 | / pub unsafe fn _mm512_srlv_epi64(a: __m512i, count: __m512i) -> __m512i { 7773 | | transmute(vpsrlvq(a.as_i64x8(), count.as_i64x8())) 7774 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7782:1 | 7782 | / pub unsafe fn _mm512_mask_srlv_epi64( 7783 | | src: __m512i, 7784 | | k: __mmask8, 7785 | | a: __m512i, ... | 7789 | | transmute(simd_select_bitmask(k, shf, src.as_i64x8())) 7790 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7798:1 | 7798 | / pub unsafe fn _mm512_maskz_srlv_epi64(k: __mmask8, a: __m512i, count: __m512i) -> __m512i { 7799 | | let shf = _mm512_srlv_epi64(a, count).as_i64x8(); 7800 | | let zero = _mm512_setzero_si512().as_i64x8(); 7801 | | transmute(simd_select_bitmask(k, shf, zero)) 7802 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7811:1 | 7811 | / pub unsafe fn _mm512_permute_ps(a: __m512, imm8: i32) -> __m512 { 7812 | | macro_rules! call { 7813 | | ($imm8:expr) => { 7814 | | vpermilps(a.as_f32x16(), _mm512_set1_epi32($imm8).as_i32x16()) ... | 7818 | | transmute(r) 7819 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7828:1 | 7828 | / pub unsafe fn _mm512_mask_permute_ps(src: __m512, k: __mmask16, a: __m512, imm8: i32) -> __m512 { 7829 | | macro_rules! call { 7830 | | ($imm8:expr) => { 7831 | | vpermilps(a.as_f32x16(), _mm512_set1_epi32($imm8).as_i32x16()) ... | 7835 | | transmute(simd_select_bitmask(k, permute, src.as_f32x16())) 7836 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7845:1 | 7845 | / pub unsafe fn _mm512_maskz_permute_ps(k: __mmask16, a: __m512, imm8: i32) -> __m512 { 7846 | | macro_rules! call { 7847 | | ($imm8:expr) => { 7848 | | vpermilps(a.as_f32x16(), _mm512_set1_epi32($imm8).as_i32x16()) ... | 7853 | | transmute(simd_select_bitmask(k, permute, zero)) 7854 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7863:1 | 7863 | / pub unsafe fn _mm512_permute_pd(a: __m512d, imm8: i32) -> __m512d { 7864 | | macro_rules! call { 7865 | | ($imm8:expr) => { 7866 | | vpermilpd(a.as_f64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7870 | | transmute(r) 7871 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7880:1 | 7880 | / pub unsafe fn _mm512_mask_permute_pd(src: __m512d, k: __mmask8, a: __m512d, imm8: i32) -> __m512d { 7881 | | macro_rules! call { 7882 | | ($imm8:expr) => { 7883 | | vpermilpd(a.as_f64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7887 | | transmute(simd_select_bitmask(k, permute, src.as_f64x8())) 7888 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7897:1 | 7897 | / pub unsafe fn _mm512_maskz_permute_pd(k: __mmask8, a: __m512d, imm8: i32) -> __m512d { 7898 | | macro_rules! call { 7899 | | ($imm8:expr) => { 7900 | | vpermilpd(a.as_f64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7905 | | transmute(simd_select_bitmask(k, permute, zero)) 7906 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7916:1 | 7916 | / pub unsafe fn _mm512_permutex_epi64(a: __m512i, imm8: i32) -> __m512i { 7917 | | macro_rules! call { 7918 | | ($imm8:expr) => { 7919 | | vpermq(a.as_i64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7923 | | transmute(r) 7924 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7933:1 | 7933 | / pub unsafe fn _mm512_mask_permutex_epi64( 7934 | | src: __m512i, 7935 | | k: __mmask8, 7936 | | a: __m512i, ... | 7945 | | transmute(simd_select_bitmask(k, permute, src.as_i64x8())) 7946 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7955:1 | 7955 | / pub unsafe fn _mm512_maskz_permutex_epi64(k: __mmask8, a: __m512i, imm8: i32) -> __m512i { 7956 | | macro_rules! call { 7957 | | ($imm8:expr) => { 7958 | | vpermq(a.as_i64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7963 | | transmute(simd_select_bitmask(k, permute, zero)) 7964 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7973:1 | 7973 | / pub unsafe fn _mm512_permutex_pd(a: __m512d, imm8: i32) -> __m512d { 7974 | | macro_rules! call { 7975 | | ($imm8:expr) => { 7976 | | vpermpd(a.as_f64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7980 | | transmute(r) 7981 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:7990:1 | 7990 | / pub unsafe fn _mm512_mask_permutex_pd(src: __m512d, k: __mmask8, a: __m512d, imm8: i32) -> __m512d { 7991 | | macro_rules! call { 7992 | | ($imm8:expr) => { 7993 | | vpermpd(a.as_f64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 7997 | | transmute(simd_select_bitmask(k, permute, src.as_f64x8())) 7998 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8007:1 | 8007 | / pub unsafe fn _mm512_maskz_permutex_pd(k: __mmask8, a: __m512d, imm8: i32) -> __m512d { 8008 | | macro_rules! call { 8009 | | ($imm8:expr) => { 8010 | | vpermpd(a.as_f64x8(), _mm512_set1_epi64($imm8).as_i64x8()) ... | 8015 | | transmute(simd_select_bitmask(k, permute, zero)) 8016 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8024:1 | 8024 | / pub unsafe fn _mm512_permutevar_epi32(idx: __m512i, a: __m512i) -> __m512i { 8025 | | transmute(vpermd(a.as_i32x16(), idx.as_i32x16())) 8026 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8034:1 | 8034 | / pub unsafe fn _mm512_mask_permutevar_epi32( 8035 | | src: __m512i, 8036 | | k: __mmask16, 8037 | | idx: __m512i, ... | 8041 | | transmute(simd_select_bitmask(k, permute, src.as_i32x16())) 8042 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8050:1 | 8050 | / pub unsafe fn _mm512_permutevar_ps(a: __m512, b: __m512i) -> __m512 { 8051 | | transmute(vpermilps(a.as_f32x16(), b.as_i32x16())) 8052 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8060:1 | 8060 | / pub unsafe fn _mm512_mask_permutevar_ps( 8061 | | src: __m512, 8062 | | k: __mmask16, 8063 | | a: __m512, ... | 8067 | | transmute(simd_select_bitmask(k, permute, src.as_f32x16())) 8068 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8076:1 | 8076 | / pub unsafe fn _mm512_maskz_permutevar_ps(k: __mmask16, a: __m512, b: __m512i) -> __m512 { 8077 | | let permute = _mm512_permutevar_ps(a, b).as_f32x16(); 8078 | | let zero = _mm512_setzero_ps().as_f32x16(); 8079 | | transmute(simd_select_bitmask(k, permute, zero)) 8080 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8088:1 | 8088 | / pub unsafe fn _mm512_permutevar_pd(a: __m512d, b: __m512i) -> __m512d { 8089 | | transmute(vpermilpd(a.as_f64x8(), b.as_i64x8())) 8090 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8098:1 | 8098 | / pub unsafe fn _mm512_mask_permutevar_pd( 8099 | | src: __m512d, 8100 | | k: __mmask8, 8101 | | a: __m512d, ... | 8105 | | transmute(simd_select_bitmask(k, permute, src.as_f64x8())) 8106 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8114:1 | 8114 | / pub unsafe fn _mm512_maskz_permutevar_pd(k: __mmask8, a: __m512d, b: __m512i) -> __m512d { 8115 | | let permute = _mm512_permutevar_pd(a, b).as_f64x8(); 8116 | | let zero = _mm512_setzero_pd().as_f64x8(); 8117 | | transmute(simd_select_bitmask(k, permute, zero)) 8118 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8126:1 | 8126 | / pub unsafe fn _mm512_permutexvar_epi32(idx: __m512i, a: __m512i) -> __m512i { 8127 | | transmute(vpermd(a.as_i32x16(), idx.as_i32x16())) 8128 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8136:1 | 8136 | / pub unsafe fn _mm512_mask_permutexvar_epi32( 8137 | | src: __m512i, 8138 | | k: __mmask16, 8139 | | idx: __m512i, ... | 8143 | | transmute(simd_select_bitmask(k, permute, src.as_i32x16())) 8144 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8152:1 | 8152 | / pub unsafe fn _mm512_maskz_permutexvar_epi32(k: __mmask16, idx: __m512i, a: __m512i) -> __m512i { 8153 | | let permute = _mm512_permutexvar_epi32(idx, a).as_i32x16(); 8154 | | let zero = _mm512_setzero_si512().as_i32x16(); 8155 | | transmute(simd_select_bitmask(k, permute, zero)) 8156 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8164:1 | 8164 | / pub unsafe fn _mm512_permutexvar_epi64(idx: __m512i, a: __m512i) -> __m512i { 8165 | | transmute(vpermq(a.as_i64x8(), idx.as_i64x8())) 8166 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8174:1 | 8174 | / pub unsafe fn _mm512_mask_permutexvar_epi64( 8175 | | src: __m512i, 8176 | | k: __mmask8, 8177 | | idx: __m512i, ... | 8181 | | transmute(simd_select_bitmask(k, permute, src.as_i64x8())) 8182 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8190:1 | 8190 | / pub unsafe fn _mm512_maskz_permutexvar_epi64(k: __mmask8, idx: __m512i, a: __m512i) -> __m512i { 8191 | | let permute = _mm512_permutexvar_epi64(idx, a).as_i64x8(); 8192 | | let zero = _mm512_setzero_si512().as_i64x8(); 8193 | | transmute(simd_select_bitmask(k, permute, zero)) 8194 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8202:1 | 8202 | / pub unsafe fn _mm512_permutexvar_ps(idx: __m512i, a: __m512) -> __m512 { 8203 | | transmute(vpermps(a.as_f32x16(), idx.as_i32x16())) 8204 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8212:1 | 8212 | / pub unsafe fn _mm512_mask_permutexvar_ps( 8213 | | src: __m512, 8214 | | k: __mmask16, 8215 | | idx: __m512i, ... | 8219 | | transmute(simd_select_bitmask(k, permute, src.as_f32x16())) 8220 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8228:1 | 8228 | / pub unsafe fn _mm512_maskz_permutexvar_ps(k: __mmask16, idx: __m512i, a: __m512) -> __m512 { 8229 | | let permute = _mm512_permutexvar_ps(idx, a).as_f32x16(); 8230 | | let zero = _mm512_setzero_ps().as_f32x16(); 8231 | | transmute(simd_select_bitmask(k, permute, zero)) 8232 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8240:1 | 8240 | / pub unsafe fn _mm512_permutexvar_pd(idx: __m512i, a: __m512d) -> __m512d { 8241 | | transmute(vpermpd(a.as_f64x8(), idx.as_i64x8())) 8242 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8250:1 | 8250 | / pub unsafe fn _mm512_mask_permutexvar_pd( 8251 | | src: __m512d, 8252 | | k: __mmask8, 8253 | | idx: __m512i, ... | 8257 | | transmute(simd_select_bitmask(k, permute, src.as_f64x8())) 8258 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8266:1 | 8266 | / pub unsafe fn _mm512_maskz_permutexvar_pd(k: __mmask8, idx: __m512i, a: __m512d) -> __m512d { 8267 | | let permute = _mm512_permutexvar_pd(idx, a).as_f64x8(); 8268 | | let zero = _mm512_setzero_pd().as_f64x8(); 8269 | | transmute(simd_select_bitmask(k, permute, zero)) 8270 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8278:1 | 8278 | / pub unsafe fn _mm512_permutex2var_epi32(a: __m512i, idx: __m512i, b: __m512i) -> __m512i { 8279 | | transmute(vpermi2d(a.as_i32x16(), idx.as_i32x16(), b.as_i32x16())) 8280 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8288:1 | 8288 | / pub unsafe fn _mm512_mask_permutex2var_epi32( 8289 | | a: __m512i, 8290 | | k: __mmask16, 8291 | | idx: __m512i, ... | 8295 | | transmute(simd_select_bitmask(k, permute, a.as_i32x16())) 8296 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8304:1 | 8304 | / pub unsafe fn _mm512_maskz_permutex2var_epi32( 8305 | | k: __mmask16, 8306 | | a: __m512i, 8307 | | idx: __m512i, ... | 8312 | | transmute(simd_select_bitmask(k, permute, zero)) 8313 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8321:1 | 8321 | / pub unsafe fn _mm512_mask2_permutex2var_epi32( 8322 | | a: __m512i, 8323 | | idx: __m512i, 8324 | | k: __mmask16, ... | 8328 | | transmute(simd_select_bitmask(k, permute, idx.as_i32x16())) 8329 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8337:1 | 8337 | / pub unsafe fn _mm512_permutex2var_epi64(a: __m512i, idx: __m512i, b: __m512i) -> __m512i { 8338 | | transmute(vpermi2q(a.as_i64x8(), idx.as_i64x8(), b.as_i64x8())) 8339 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8347:1 | 8347 | / pub unsafe fn _mm512_mask_permutex2var_epi64( 8348 | | a: __m512i, 8349 | | k: __mmask8, 8350 | | idx: __m512i, ... | 8354 | | transmute(simd_select_bitmask(k, permute, a.as_i64x8())) 8355 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8363:1 | 8363 | / pub unsafe fn _mm512_maskz_permutex2var_epi64( 8364 | | k: __mmask8, 8365 | | a: __m512i, 8366 | | idx: __m512i, ... | 8371 | | transmute(simd_select_bitmask(k, permute, zero)) 8372 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8380:1 | 8380 | / pub unsafe fn _mm512_mask2_permutex2var_epi64( 8381 | | a: __m512i, 8382 | | idx: __m512i, 8383 | | k: __mmask8, ... | 8387 | | transmute(simd_select_bitmask(k, permute, idx.as_i64x8())) 8388 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8396:1 | 8396 | / pub unsafe fn _mm512_permutex2var_ps(a: __m512, idx: __m512i, b: __m512) -> __m512 { 8397 | | transmute(vpermi2ps(a.as_f32x16(), idx.as_i32x16(), b.as_f32x16())) 8398 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8406:1 | 8406 | / pub unsafe fn _mm512_mask_permutex2var_ps( 8407 | | a: __m512, 8408 | | k: __mmask16, 8409 | | idx: __m512i, ... | 8413 | | transmute(simd_select_bitmask(k, permute, a.as_f32x16())) 8414 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8422:1 | 8422 | / pub unsafe fn _mm512_maskz_permutex2var_ps( 8423 | | k: __mmask16, 8424 | | a: __m512, 8425 | | idx: __m512i, ... | 8430 | | transmute(simd_select_bitmask(k, permute, zero)) 8431 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8439:1 | 8439 | / pub unsafe fn _mm512_mask2_permutex2var_ps( 8440 | | a: __m512, 8441 | | idx: __m512i, 8442 | | k: __mmask16, ... | 8447 | | transmute(simd_select_bitmask(k, permute, zero)) 8448 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8456:1 | 8456 | / pub unsafe fn _mm512_permutex2var_pd(a: __m512d, idx: __m512i, b: __m512d) -> __m512d { 8457 | | transmute(vpermi2pd(a.as_f64x8(), idx.as_i64x8(), b.as_f64x8())) 8458 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8466:1 | 8466 | / pub unsafe fn _mm512_mask_permutex2var_pd( 8467 | | a: __m512d, 8468 | | k: __mmask8, 8469 | | idx: __m512i, ... | 8473 | | transmute(simd_select_bitmask(k, permute, a.as_f64x8())) 8474 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8482:1 | 8482 | / pub unsafe fn _mm512_maskz_permutex2var_pd( 8483 | | k: __mmask8, 8484 | | a: __m512d, 8485 | | idx: __m512i, ... | 8490 | | transmute(simd_select_bitmask(k, permute, zero)) 8491 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8499:1 | 8499 | / pub unsafe fn _mm512_mask2_permutex2var_pd( 8500 | | a: __m512d, 8501 | | idx: __m512i, 8502 | | k: __mmask8, ... | 8507 | | transmute(simd_select_bitmask(k, permute, zero)) 8508 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8517:1 | 8517 | / pub unsafe fn _mm512_shuffle_epi32(a: __m512i, imm8: _MM_PERM_ENUM) -> __m512i { 8518 | | let imm8 = (imm8 & 0xFF) as u8; 8519 | | 8520 | | let a = a.as_i32x16(); ... | 8585 | | transmute(r) 8586 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8595:1 | 8595 | / pub unsafe fn _mm512_mask_shuffle_epi32( 8596 | | src: __m512i, 8597 | | k: __mmask16, 8598 | | a: __m512i, ... | 8668 | | transmute(simd_select_bitmask(k, shuffle, src.as_i32x16())) 8669 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8678:1 | 8678 | / pub unsafe fn _mm512_maskz_shuffle_epi32(k: __mmask16, a: __m512i, imm8: _MM_PERM_ENUM) -> __m512i { 8679 | | let imm8 = (imm8 & 0xFF) as u8; 8680 | | 8681 | | let a = a.as_i32x16(); ... | 8747 | | transmute(simd_select_bitmask(k, shuffle, zero)) 8748 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8757:1 | 8757 | / pub unsafe fn _mm512_shuffle_ps(a: __m512, b: __m512, imm8: i32) -> __m512 { 8758 | | assert!(imm8 >= 0 && imm8 <= 255); 8759 | | let imm8 = (imm8 & 0xFF) as u8; 8760 | | macro_rules! shuffle4 { ... | 8823 | | } 8824 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8833:1 | 8833 | / pub unsafe fn _mm512_mask_shuffle_ps( 8834 | | src: __m512, 8835 | | k: __mmask16, 8836 | | a: __m512, ... | 8907 | | transmute(simd_select_bitmask(k, shuffle, src.as_f32x16())) 8908 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8917:1 | 8917 | / pub unsafe fn _mm512_maskz_shuffle_ps(k: __mmask16, a: __m512, b: __m512, imm8: i32) -> __m512 { 8918 | | assert!(imm8 >= 0 && imm8 <= 255); 8919 | | let imm8 = (imm8 & 0xFF) as u8; 8920 | | macro_rules! shuffle4 { ... | 8986 | | transmute(simd_select_bitmask(k, shuffle, zero)) 8987 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:8996:1 | 8996 | / pub unsafe fn _mm512_shuffle_pd(a: __m512d, b: __m512d, imm8: i32) -> __m512d { 8997 | | assert!(imm8 >= 0 && imm8 <= 255); 8998 | | let imm8 = (imm8 & 0xFF) as u8; 8999 | | macro_rules! shuffle8 { ... | 9063 | | } 9064 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9073:1 | 9073 | / pub unsafe fn _mm512_mask_shuffle_pd( 9074 | | src: __m512d, 9075 | | k: __mmask8, 9076 | | a: __m512d, ... | 9148 | | transmute(simd_select_bitmask(k, shuffle, src.as_f64x8())) 9149 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9158:1 | 9158 | / pub unsafe fn _mm512_maskz_shuffle_pd(k: __mmask8, a: __m512d, b: __m512d, imm8: i32) -> __m512d { 9159 | | assert!(imm8 >= 0 && imm8 <= 255); 9160 | | let imm8 = (imm8 & 0xFF) as u8; 9161 | | macro_rules! shuffle8 { ... | 9228 | | transmute(simd_select_bitmask(k, shuffle, zero)) 9229 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9238:1 | 9238 | / pub unsafe fn _mm512_shuffle_i32x4(a: __m512i, b: __m512i, imm8: i32) -> __m512i { 9239 | | assert!(imm8 >= 0 && imm8 <= 255); 9240 | | let imm8 = (imm8 & 0xFF) as u8; 9241 | | let a = a.as_i32x16(); ... | 9308 | | transmute(r) 9309 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9318:1 | 9318 | / pub unsafe fn _mm512_mask_shuffle_i32x4( 9319 | | src: __m512i, 9320 | | k: __mmask16, 9321 | | a: __m512i, ... | 9394 | | transmute(simd_select_bitmask(k, shuffle, src.as_i32x16())) 9395 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9404:1 | 9404 | / pub unsafe fn _mm512_maskz_shuffle_i32x4( 9405 | | k: __mmask16, 9406 | | a: __m512i, 9407 | | b: __m512i, ... | 9480 | | transmute(simd_select_bitmask(k, shuffle, zero)) 9481 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9490:1 | 9490 | / pub unsafe fn _mm512_shuffle_i64x2(a: __m512i, b: __m512i, imm8: i32) -> __m512i { 9491 | | assert!(imm8 >= 0 && imm8 <= 255); 9492 | | let imm8 = (imm8 & 0xFF) as u8; 9493 | | macro_rules! shuffle4 { ... | 9542 | | } 9543 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9552:1 | 9552 | / pub unsafe fn _mm512_mask_shuffle_i64x2( 9553 | | src: __m512i, 9554 | | k: __mmask8, 9555 | | a: __m512i, ... | 9612 | | transmute(simd_select_bitmask(k, shuffle, src.as_i64x8())) 9613 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9622:1 | 9622 | / pub unsafe fn _mm512_maskz_shuffle_i64x2( 9623 | | k: __mmask8, 9624 | | a: __m512i, 9625 | | b: __m512i, ... | 9682 | | transmute(simd_select_bitmask(k, shuffle, zero)) 9683 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9692:1 | 9692 | / pub unsafe fn _mm512_shuffle_f32x4(a: __m512, b: __m512, imm8: i32) -> __m512 { 9693 | | assert!(imm8 >= 0 && imm8 <= 255); 9694 | | let imm8 = (imm8 & 0xFF) as u8; 9695 | | macro_rules! shuffle4 { ... | 9758 | | } 9759 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9768:1 | 9768 | / pub unsafe fn _mm512_mask_shuffle_f32x4( 9769 | | src: __m512, 9770 | | k: __mmask16, 9771 | | a: __m512, ... | 9842 | | transmute(simd_select_bitmask(k, shuffle, src.as_f32x16())) 9843 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9852:1 | 9852 | / pub unsafe fn _mm512_maskz_shuffle_f32x4(k: __mmask16, a: __m512, b: __m512, imm8: i32) -> __m512 { 9853 | | assert!(imm8 >= 0 && imm8 <= 255); 9854 | | let imm8 = (imm8 & 0xFF) as u8; 9855 | | macro_rules! shuffle4 { ... | 9921 | | transmute(simd_select_bitmask(k, shuffle, zero)) 9922 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9931:1 | 9931 | / pub unsafe fn _mm512_shuffle_f64x2(a: __m512d, b: __m512d, imm8: i32) -> __m512d { 9932 | | assert!(imm8 >= 0 && imm8 <= 255); 9933 | | let imm8 = (imm8 & 0xFF) as u8; 9934 | | macro_rules! shuffle4 { ... | 9983 | | } 9984 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:9993:1 | 9993 | / pub unsafe fn _mm512_mask_shuffle_f64x2( 9994 | | src: __m512d, 9995 | | k: __mmask8, 9996 | | a: __m512d, ... | 10053 | | transmute(simd_select_bitmask(k, shuffle, src.as_f64x8())) 10054 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10063:1 | 10063 | / pub unsafe fn _mm512_maskz_shuffle_f64x2( 10064 | | k: __mmask8, 10065 | | a: __m512d, 10066 | | b: __m512d, ... | 10123 | | transmute(simd_select_bitmask(k, shuffle, zero)) 10124 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10136:1 | 10136 | / pub unsafe fn _mm512_extractf32x4_ps(a: __m512, imm8: i32) -> __m128 { 10137 | | assert!(imm8 >= 0 && imm8 <= 3); 10138 | | match imm8 & 0x3 { 10139 | | 0 => simd_shuffle4(a, _mm512_undefined_ps(), [0, 1, 2, 3]), ... | 10143 | | } 10144 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10152:1 | 10152 | / pub unsafe fn _mm512_moveldup_ps(a: __m512) -> __m512 { 10153 | | let r: f32x16 = simd_shuffle16(a, a, [0, 0, 2, 2, 4, 4, 6, 6, 8, 8, 10, 10, 12, 12, 14, 14]); 10154 | | transmute(r) 10155 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10163:1 | 10163 | / pub unsafe fn _mm512_mask_moveldup_ps(src: __m512, k: __mmask16, a: __m512) -> __m512 { 10164 | | let mov: f32x16 = simd_shuffle16(a, a, [0, 0, 2, 2, 4, 4, 6, 6, 8, 8, 10, 10, 12, 12, 14, 14]); 10165 | | transmute(simd_select_bitmask(k, mov, src.as_f32x16())) 10166 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10174:1 | 10174 | / pub unsafe fn _mm512_maskz_moveldup_ps(k: __mmask16, a: __m512) -> __m512 { 10175 | | let mov: f32x16 = simd_shuffle16(a, a, [0, 0, 2, 2, 4, 4, 6, 6, 8, 8, 10, 10, 12, 12, 14, 14]); 10176 | | let zero = _mm512_setzero_ps().as_f32x16(); 10177 | | transmute(simd_select_bitmask(k, mov, zero)) 10178 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10186:1 | 10186 | / pub unsafe fn _mm512_movehdup_ps(a: __m512) -> __m512 { 10187 | | let r: f32x16 = simd_shuffle16(a, a, [1, 1, 3, 3, 5, 5, 7, 7, 9, 9, 11, 11, 13, 13, 15, 15]); 10188 | | transmute(r) 10189 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10197:1 | 10197 | / pub unsafe fn _mm512_mask_movehdup_ps(src: __m512, k: __mmask16, a: __m512) -> __m512 { 10198 | | let mov: f32x16 = simd_shuffle16(a, a, [1, 1, 3, 3, 5, 5, 7, 7, 9, 9, 11, 11, 13, 13, 15, 15]); 10199 | | transmute(simd_select_bitmask(k, mov, src.as_f32x16())) 10200 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10208:1 | 10208 | / pub unsafe fn _mm512_maskz_movehdup_ps(k: __mmask16, a: __m512) -> __m512 { 10209 | | let mov: f32x16 = simd_shuffle16(a, a, [1, 1, 3, 3, 5, 5, 7, 7, 9, 9, 11, 11, 13, 13, 15, 15]); 10210 | | let zero = _mm512_setzero_ps().as_f32x16(); 10211 | | transmute(simd_select_bitmask(k, mov, zero)) 10212 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10220:1 | 10220 | / pub unsafe fn _mm512_movedup_pd(a: __m512d) -> __m512d { 10221 | | let r: f64x8 = simd_shuffle8(a, a, [0, 0, 2, 2, 4, 4, 6, 6]); 10222 | | transmute(r) 10223 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10231:1 | 10231 | / pub unsafe fn _mm512_mask_movedup_pd(src: __m512d, k: __mmask8, a: __m512d) -> __m512d { 10232 | | let mov: f64x8 = simd_shuffle8(a, a, [0, 0, 2, 2, 4, 4, 6, 6]); 10233 | | transmute(simd_select_bitmask(k, mov, src.as_f64x8())) 10234 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10242:1 | 10242 | / pub unsafe fn _mm512_maskz_movedup_pd(k: __mmask8, a: __m512d) -> __m512d { 10243 | | let mov: f64x8 = simd_shuffle8(a, a, [0, 0, 2, 2, 4, 4, 6, 6]); 10244 | | let zero = _mm512_setzero_pd().as_f64x8(); 10245 | | transmute(simd_select_bitmask(k, mov, zero)) 10246 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10255:1 | 10255 | / pub unsafe fn _mm512_inserti32x4(a: __m512i, b: __m128i, imm8: i32) -> __m512i { 10256 | | assert!(imm8 >= 0 && imm8 <= 3); 10257 | | let a = a.as_i32x16(); 10258 | | let b = _mm512_castsi128_si512(b).as_i32x16(); ... | 10277 | | transmute(ret) 10278 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10287:1 | 10287 | / pub unsafe fn _mm512_mask_inserti32x4( 10288 | | src: __m512i, 10289 | | k: __mmask16, 10290 | | a: __m512i, ... | 10315 | | transmute(simd_select_bitmask(k, insert, src.as_i32x16())) 10316 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10325:1 | 10325 | / pub unsafe fn _mm512_maskz_inserti32x4(k: __mmask16, a: __m512i, b: __m128i, imm8: i32) -> __m512i { 10326 | | assert!(imm8 >= 0 && imm8 <= 3); 10327 | | let a = a.as_i32x16(); 10328 | | let b = _mm512_castsi128_si512(b).as_i32x16(); ... | 10348 | | transmute(simd_select_bitmask(k, insert, zero)) 10349 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10358:1 | 10358 | / pub unsafe fn _mm512_inserti64x4(a: __m512i, b: __m256i, imm8: i32) -> __m512i { 10359 | | assert!(imm8 >= 0 && imm8 <= 1); 10360 | | let b = _mm512_castsi256_si512(b); 10361 | | match imm8 & 0b1 { ... | 10364 | | } 10365 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10374:1 | 10374 | / pub unsafe fn _mm512_mask_inserti64x4( 10375 | | src: __m512i, 10376 | | k: __mmask8, 10377 | | a: __m512i, ... | 10387 | | transmute(simd_select_bitmask(k, insert, src.as_i64x8())) 10388 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10397:1 | 10397 | / pub unsafe fn _mm512_maskz_inserti64x4(k: __mmask8, a: __m512i, b: __m256i, imm8: i32) -> __m512i { 10398 | | assert!(imm8 >= 0 && imm8 <= 1); 10399 | | let b = _mm512_castsi256_si512(b); 10400 | | let insert = match imm8 & 0b1 { ... | 10405 | | transmute(simd_select_bitmask(k, insert, zero)) 10406 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10415:1 | 10415 | / pub unsafe fn _mm512_insertf32x4(a: __m512, b: __m128, imm8: i32) -> __m512 { 10416 | | assert!(imm8 >= 0 && imm8 <= 3); 10417 | | let b = _mm512_castps128_ps512(b); 10418 | | match imm8 & 0b11 { ... | 10435 | | } 10436 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10445:1 | 10445 | / pub unsafe fn _mm512_mask_insertf32x4( 10446 | | src: __m512, 10447 | | k: __mmask16, 10448 | | a: __m512, ... | 10472 | | transmute(simd_select_bitmask(k, insert, src.as_f32x16())) 10473 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10482:1 | 10482 | / pub unsafe fn _mm512_maskz_insertf32x4(k: __mmask16, a: __m512, b: __m128, imm8: i32) -> __m512 { 10483 | | assert!(imm8 >= 0 && imm8 <= 3); 10484 | | let b = _mm512_castps128_ps512(b); 10485 | | let insert = match imm8 & 0b11 { ... | 10504 | | transmute(simd_select_bitmask(k, insert, zero)) 10505 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10514:1 | 10514 | / pub unsafe fn _mm512_insertf64x4(a: __m512d, b: __m256d, imm8: i32) -> __m512d { 10515 | | assert!(imm8 >= 0 && imm8 <= 1); 10516 | | let b = _mm512_castpd256_pd512(b); 10517 | | match imm8 & 0b1 { ... | 10520 | | } 10521 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10530:1 | 10530 | / pub unsafe fn _mm512_mask_insertf64x4( 10531 | | src: __m512d, 10532 | | k: __mmask8, 10533 | | a: __m512d, ... | 10543 | | transmute(simd_select_bitmask(k, insert, src.as_f64x8())) 10544 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10553:1 | 10553 | / pub unsafe fn _mm512_maskz_insertf64x4(k: __mmask8, a: __m512d, b: __m256d, imm8: i32) -> __m512d { 10554 | | assert!(imm8 >= 0 && imm8 <= 1); 10555 | | let b = _mm512_castpd256_pd512(b); 10556 | | let insert = match imm8 & 0b1 { ... | 10561 | | transmute(simd_select_bitmask(k, insert, zero)) 10562 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10570:1 | 10570 | / pub unsafe fn _mm512_unpackhi_epi32(a: __m512i, b: __m512i) -> __m512i { 10571 | | let a = a.as_i32x16(); 10572 | | let b = b.as_i32x16(); 10573 | | let r: i32x16 = simd_shuffle16( ... | 10595 | | transmute(r) 10596 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10604:1 | 10604 | / pub unsafe fn _mm512_mask_unpackhi_epi32( 10605 | | src: __m512i, 10606 | | k: __mmask16, 10607 | | a: __m512i, ... | 10611 | | transmute(simd_select_bitmask(k, unpackhi, src.as_i32x16())) 10612 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10620:1 | 10620 | / pub unsafe fn _mm512_maskz_unpackhi_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 10621 | | let unpackhi = _mm512_unpackhi_epi32(a, b).as_i32x16(); 10622 | | let zero = _mm512_setzero_si512().as_i32x16(); 10623 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10624 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10633:1 | 10633 | / pub unsafe fn _mm512_unpackhi_epi64(a: __m512i, b: __m512i) -> __m512i { 10634 | | simd_shuffle8(a, b, [1, 9, 1 + 2, 9 + 2, 1 + 4, 9 + 4, 1 + 6, 9 + 6]) 10635 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10643:1 | 10643 | / pub unsafe fn _mm512_mask_unpackhi_epi64( 10644 | | src: __m512i, 10645 | | k: __mmask8, 10646 | | a: __m512i, ... | 10650 | | transmute(simd_select_bitmask(k, unpackhi, src.as_i64x8())) 10651 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10659:1 | 10659 | / pub unsafe fn _mm512_maskz_unpackhi_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 10660 | | let unpackhi = _mm512_unpackhi_epi64(a, b).as_i64x8(); 10661 | | let zero = _mm512_setzero_si512().as_i64x8(); 10662 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10663 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10671:1 | 10671 | / pub unsafe fn _mm512_unpackhi_ps(a: __m512, b: __m512) -> __m512 { 10672 | | simd_shuffle16( 10673 | | a, 10674 | | b, ... | 10693 | | ) 10694 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10702:1 | 10702 | / pub unsafe fn _mm512_mask_unpackhi_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 10703 | | let unpackhi = _mm512_unpackhi_ps(a, b).as_f32x16(); 10704 | | transmute(simd_select_bitmask(k, unpackhi, src.as_f32x16())) 10705 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10713:1 | 10713 | / pub unsafe fn _mm512_maskz_unpackhi_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 10714 | | let unpackhi = _mm512_unpackhi_ps(a, b).as_f32x16(); 10715 | | let zero = _mm512_setzero_ps().as_f32x16(); 10716 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10717 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10725:1 | 10725 | / pub unsafe fn _mm512_unpackhi_pd(a: __m512d, b: __m512d) -> __m512d { 10726 | | simd_shuffle8(a, b, [1, 9, 1 + 2, 9 + 2, 1 + 4, 9 + 4, 1 + 6, 9 + 6]) 10727 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10735:1 | 10735 | / pub unsafe fn _mm512_mask_unpackhi_pd( 10736 | | src: __m512d, 10737 | | k: __mmask8, 10738 | | a: __m512d, ... | 10742 | | transmute(simd_select_bitmask(k, unpackhi, src.as_f64x8())) 10743 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10751:1 | 10751 | / pub unsafe fn _mm512_maskz_unpackhi_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 10752 | | let unpackhi = _mm512_unpackhi_pd(a, b).as_f64x8(); 10753 | | let zero = _mm512_setzero_pd().as_f64x8(); 10754 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10755 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10763:1 | 10763 | / pub unsafe fn _mm512_unpacklo_epi32(a: __m512i, b: __m512i) -> __m512i { 10764 | | let a = a.as_i32x16(); 10765 | | let b = b.as_i32x16(); 10766 | | let r: i32x16 = simd_shuffle16( ... | 10788 | | transmute(r) 10789 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: the operation is ineffective. Consider reducing it to `4` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10774:13 | 10774 | 0 + 4, | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `8` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10778:13 | 10778 | 0 + 8, | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `12` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10782:13 | 10782 | 0 + 12, | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10797:1 | 10797 | / pub unsafe fn _mm512_mask_unpacklo_epi32( 10798 | | src: __m512i, 10799 | | k: __mmask16, 10800 | | a: __m512i, ... | 10804 | | transmute(simd_select_bitmask(k, unpackhi, src.as_i32x16())) 10805 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10813:1 | 10813 | / pub unsafe fn _mm512_maskz_unpacklo_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 10814 | | let unpackhi = _mm512_unpacklo_epi32(a, b).as_i32x16(); 10815 | | let zero = _mm512_setzero_si512().as_i32x16(); 10816 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10817 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10825:1 | 10825 | / pub unsafe fn _mm512_unpacklo_epi64(a: __m512i, b: __m512i) -> __m512i { 10826 | | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) 10827 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: the operation is ineffective. Consider reducing it to `2` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10826:32 | 10826 | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `4` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10826:46 | 10826 | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `6` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10826:60 | 10826 | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10835:1 | 10835 | / pub unsafe fn _mm512_mask_unpacklo_epi64( 10836 | | src: __m512i, 10837 | | k: __mmask8, 10838 | | a: __m512i, ... | 10842 | | transmute(simd_select_bitmask(k, unpackhi, src.as_i64x8())) 10843 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10851:1 | 10851 | / pub unsafe fn _mm512_maskz_unpacklo_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 10852 | | let unpackhi = _mm512_unpacklo_epi64(a, b).as_i64x8(); 10853 | | let zero = _mm512_setzero_si512().as_i64x8(); 10854 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10855 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10863:1 | 10863 | / pub unsafe fn _mm512_unpacklo_ps(a: __m512, b: __m512) -> __m512 { 10864 | | simd_shuffle16( 10865 | | a, 10866 | | b, ... | 10885 | | ) 10886 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: the operation is ineffective. Consider reducing it to `4` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10872:13 | 10872 | 0 + 4, | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `8` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10876:13 | 10876 | 0 + 8, | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `12` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10880:13 | 10880 | 0 + 12, | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10894:1 | 10894 | / pub unsafe fn _mm512_mask_unpacklo_ps(src: __m512, k: __mmask16, a: __m512, b: __m512) -> __m512 { 10895 | | let unpackhi = _mm512_unpacklo_ps(a, b).as_f32x16(); 10896 | | transmute(simd_select_bitmask(k, unpackhi, src.as_f32x16())) 10897 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10905:1 | 10905 | / pub unsafe fn _mm512_maskz_unpacklo_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 10906 | | let unpackhi = _mm512_unpacklo_ps(a, b).as_f32x16(); 10907 | | let zero = _mm512_setzero_ps().as_f32x16(); 10908 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10909 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10917:1 | 10917 | / pub unsafe fn _mm512_unpacklo_pd(a: __m512d, b: __m512d) -> __m512d { 10918 | | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) 10919 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: the operation is ineffective. Consider reducing it to `2` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10918:32 | 10918 | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `4` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10918:46 | 10918 | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `6` --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10918:60 | 10918 | simd_shuffle8(a, b, [0, 8, 0 + 2, 8 + 2, 0 + 4, 8 + 4, 0 + 6, 8 + 6]) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10927:1 | 10927 | / pub unsafe fn _mm512_mask_unpacklo_pd( 10928 | | src: __m512d, 10929 | | k: __mmask8, 10930 | | a: __m512d, ... | 10934 | | transmute(simd_select_bitmask(k, unpackhi, src.as_f64x8())) 10935 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10943:1 | 10943 | / pub unsafe fn _mm512_maskz_unpacklo_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 10944 | | let unpackhi = _mm512_unpacklo_pd(a, b).as_f64x8(); 10945 | | let zero = _mm512_setzero_pd().as_f64x8(); 10946 | | transmute(simd_select_bitmask(k, unpackhi, zero)) 10947 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10954:1 | 10954 | / pub unsafe fn _mm512_castps128_ps512(a: __m128) -> __m512 { 10955 | | simd_shuffle16( 10956 | | a, 10957 | | _mm_set1_ps(-1.), 10958 | | [0, 1, 2, 3, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4], 10959 | | ) 10960 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10967:1 | 10967 | / pub unsafe fn _mm512_castps256_ps512(a: __m256) -> __m512 { 10968 | | simd_shuffle16( 10969 | | a, 10970 | | _mm256_set1_ps(-1.), 10971 | | [0, 1, 2, 3, 4, 5, 6, 7, 8, 8, 8, 8, 8, 8, 8, 8], 10972 | | ) 10973 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10980:1 | 10980 | / pub unsafe fn _mm512_castps512_ps128(a: __m512) -> __m128 { 10981 | | simd_shuffle4(a, a, [0, 1, 2, 3]) 10982 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10989:1 | 10989 | / pub unsafe fn _mm512_castps512_ps256(a: __m512) -> __m256 { 10990 | | simd_shuffle8(a, a, [0, 1, 2, 3, 4, 5, 6, 7]) 10991 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:10998:1 | 10998 | / pub unsafe fn _mm512_castps_pd(a: __m512) -> __m512d { 10999 | | transmute(a.as_m512()) 11000 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11007:1 | 11007 | / pub unsafe fn _mm512_castps_si512(a: __m512) -> __m512i { 11008 | | transmute(a.as_m512()) 11009 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11016:1 | 11016 | / pub unsafe fn _mm512_castpd128_pd512(a: __m128d) -> __m512d { 11017 | | simd_shuffle8(a, _mm_set1_pd(-1.), [0, 1, 2, 2, 2, 2, 2, 2]) 11018 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11025:1 | 11025 | / pub unsafe fn _mm512_castpd256_pd512(a: __m256d) -> __m512d { 11026 | | simd_shuffle8(a, _mm256_set1_pd(-1.), [0, 1, 2, 3, 4, 4, 4, 4]) 11027 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11034:1 | 11034 | / pub unsafe fn _mm512_castpd512_pd128(a: __m512d) -> __m128d { 11035 | | simd_shuffle2(a, a, [0, 1]) 11036 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11043:1 | 11043 | / pub unsafe fn _mm512_castpd512_pd256(a: __m512d) -> __m256d { 11044 | | simd_shuffle4(a, a, [0, 1, 2, 3]) 11045 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11052:1 | 11052 | / pub unsafe fn _mm512_castpd_ps(a: __m512d) -> __m512 { 11053 | | transmute(a.as_m512d()) 11054 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11061:1 | 11061 | / pub unsafe fn _mm512_castpd_si512(a: __m512d) -> __m512i { 11062 | | transmute(a.as_m512d()) 11063 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11070:1 | 11070 | / pub unsafe fn _mm512_castsi128_si512(a: __m128i) -> __m512i { 11071 | | simd_shuffle8(a, _mm_set1_epi64x(-1), [0, 1, 2, 2, 2, 2, 2, 2]) 11072 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11079:1 | 11079 | / pub unsafe fn _mm512_castsi256_si512(a: __m256i) -> __m512i { 11080 | | simd_shuffle8(a, _mm256_set1_epi64x(-1), [0, 1, 2, 3, 4, 4, 4, 4]) 11081 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11088:1 | 11088 | / pub unsafe fn _mm512_castsi512_si128(a: __m512i) -> __m128i { 11089 | | simd_shuffle2(a, a, [0, 1]) 11090 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11097:1 | 11097 | / pub unsafe fn _mm512_castsi512_si256(a: __m512i) -> __m256i { 11098 | | simd_shuffle4(a, a, [0, 1, 2, 3]) 11099 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11106:1 | 11106 | / pub unsafe fn _mm512_castsi512_ps(a: __m512i) -> __m512 { 11107 | | transmute(a) 11108 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11115:1 | 11115 | / pub unsafe fn _mm512_castsi512_pd(a: __m512i) -> __m512d { 11116 | | transmute(a) 11117 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11125:1 | 11125 | / pub unsafe fn _mm512_broadcastd_epi32(a: __m128i) -> __m512i { 11126 | | let a = _mm512_castsi128_si512(a).as_i32x16(); 11127 | | let ret: i32x16 = simd_shuffle16(a, a, [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]); 11128 | | transmute(ret) 11129 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11137:1 | 11137 | / pub unsafe fn _mm512_mask_broadcastd_epi32(src: __m512i, k: __mmask16, a: __m128i) -> __m512i { 11138 | | let broadcast = _mm512_broadcastd_epi32(a).as_i32x16(); 11139 | | transmute(simd_select_bitmask(k, broadcast, src.as_i32x16())) 11140 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11148:1 | 11148 | / pub unsafe fn _mm512_maskz_broadcastd_epi32(k: __mmask16, a: __m128i) -> __m512i { 11149 | | let broadcast = _mm512_broadcastd_epi32(a).as_i32x16(); 11150 | | let zero = _mm512_setzero_si512().as_i32x16(); 11151 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11152 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11160:1 | 11160 | / pub unsafe fn _mm512_broadcastq_epi64(a: __m128i) -> __m512i { 11161 | | simd_shuffle8(a, a, [0, 0, 0, 0, 0, 0, 0, 0]) 11162 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11170:1 | 11170 | / pub unsafe fn _mm512_mask_broadcastq_epi64(src: __m512i, k: __mmask8, a: __m128i) -> __m512i { 11171 | | let broadcast = _mm512_broadcastq_epi64(a).as_i64x8(); 11172 | | transmute(simd_select_bitmask(k, broadcast, src.as_i64x8())) 11173 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11181:1 | 11181 | / pub unsafe fn _mm512_maskz_broadcastq_epi64(k: __mmask8, a: __m128i) -> __m512i { 11182 | | let broadcast = _mm512_broadcastq_epi64(a).as_i64x8(); 11183 | | let zero = _mm512_setzero_si512().as_i64x8(); 11184 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11185 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11193:1 | 11193 | / pub unsafe fn _mm512_broadcastss_ps(a: __m128) -> __m512 { 11194 | | simd_shuffle16(a, a, [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]) 11195 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11203:1 | 11203 | / pub unsafe fn _mm512_mask_broadcastss_ps(src: __m512, k: __mmask16, a: __m128) -> __m512 { 11204 | | let broadcast = _mm512_broadcastss_ps(a).as_f32x16(); 11205 | | transmute(simd_select_bitmask(k, broadcast, src.as_f32x16())) 11206 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11214:1 | 11214 | / pub unsafe fn _mm512_maskz_broadcastss_ps(k: __mmask16, a: __m128) -> __m512 { 11215 | | let broadcast = _mm512_broadcastss_ps(a).as_f32x16(); 11216 | | let zero = _mm512_setzero_ps().as_f32x16(); 11217 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11218 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11226:1 | 11226 | / pub unsafe fn _mm512_broadcastsd_pd(a: __m128d) -> __m512d { 11227 | | simd_shuffle8(a, a, [1, 1, 1, 1, 1, 1, 1, 1]) 11228 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11236:1 | 11236 | / pub unsafe fn _mm512_mask_broadcastsd_pd(src: __m512d, k: __mmask8, a: __m128d) -> __m512d { 11237 | | let broadcast = _mm512_broadcastsd_pd(a).as_f64x8(); 11238 | | transmute(simd_select_bitmask(k, broadcast, src.as_f64x8())) 11239 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11247:1 | 11247 | / pub unsafe fn _mm512_maskz_broadcastsd_pd(k: __mmask8, a: __m128d) -> __m512d { 11248 | | let broadcast = _mm512_broadcastsd_pd(a).as_f64x8(); 11249 | | let zero = _mm512_setzero_pd().as_f64x8(); 11250 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11251 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11258:1 | 11258 | / pub unsafe fn _mm512_broadcast_i32x4(a: __m128i) -> __m512i { 11259 | | let a = _mm512_castsi128_si512(a).as_i32x16(); 11260 | | let ret: i32x16 = simd_shuffle16(a, a, [0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3]); 11261 | | transmute(ret) 11262 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11269:1 | 11269 | / pub unsafe fn _mm512_mask_broadcast_i32x4(src: __m512i, k: __mmask16, a: __m128i) -> __m512i { 11270 | | let broadcast = _mm512_broadcast_i32x4(a).as_i32x16(); 11271 | | transmute(simd_select_bitmask(k, broadcast, src.as_i32x16())) 11272 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11279:1 | 11279 | / pub unsafe fn _mm512_maskz_broadcast_i32x4(k: __mmask16, a: __m128i) -> __m512i { 11280 | | let broadcast = _mm512_broadcast_i32x4(a).as_i32x16(); 11281 | | let zero = _mm512_setzero_si512().as_i32x16(); 11282 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11283 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11290:1 | 11290 | / pub unsafe fn _mm512_broadcast_i64x4(a: __m256i) -> __m512i { 11291 | | simd_shuffle8(a, a, [0, 1, 2, 3, 0, 1, 2, 3]) 11292 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11299:1 | 11299 | / pub unsafe fn _mm512_mask_broadcast_i64x4(src: __m512i, k: __mmask8, a: __m256i) -> __m512i { 11300 | | let broadcast = _mm512_broadcast_i64x4(a).as_i64x8(); 11301 | | transmute(simd_select_bitmask(k, broadcast, src.as_i64x8())) 11302 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11309:1 | 11309 | / pub unsafe fn _mm512_maskz_broadcast_i64x4(k: __mmask8, a: __m256i) -> __m512i { 11310 | | let broadcast = _mm512_broadcast_i64x4(a).as_i64x8(); 11311 | | let zero = _mm512_setzero_si512().as_i64x8(); 11312 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11313 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11320:1 | 11320 | / pub unsafe fn _mm512_broadcast_f32x4(a: __m128) -> __m512 { 11321 | | simd_shuffle16(a, a, [0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3]) 11322 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11329:1 | 11329 | / pub unsafe fn _mm512_mask_broadcast_f32x4(src: __m512, k: __mmask16, a: __m128) -> __m512 { 11330 | | let broadcast = _mm512_broadcast_f32x4(a).as_f32x16(); 11331 | | transmute(simd_select_bitmask(k, broadcast, src.as_f32x16())) 11332 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11339:1 | 11339 | / pub unsafe fn _mm512_maskz_broadcast_f32x4(k: __mmask16, a: __m128) -> __m512 { 11340 | | let broadcast = _mm512_broadcast_f32x4(a).as_f32x16(); 11341 | | let zero = _mm512_setzero_ps().as_f32x16(); 11342 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11343 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11350:1 | 11350 | / pub unsafe fn _mm512_broadcast_f64x4(a: __m256d) -> __m512d { 11351 | | simd_shuffle8(a, a, [0, 1, 2, 3, 0, 1, 2, 3]) 11352 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11359:1 | 11359 | / pub unsafe fn _mm512_mask_broadcast_f64x4(src: __m512d, k: __mmask8, a: __m256d) -> __m512d { 11360 | | let broadcast = _mm512_broadcast_f64x4(a).as_f64x8(); 11361 | | transmute(simd_select_bitmask(k, broadcast, src.as_f64x8())) 11362 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11369:1 | 11369 | / pub unsafe fn _mm512_maskz_broadcast_f64x4(k: __mmask8, a: __m256d) -> __m512d { 11370 | | let broadcast = _mm512_broadcast_f64x4(a).as_f64x8(); 11371 | | let zero = _mm512_setzero_pd().as_f64x8(); 11372 | | transmute(simd_select_bitmask(k, broadcast, zero)) 11373 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11381:1 | 11381 | / pub unsafe fn _mm512_mask_blend_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11382 | | transmute(simd_select_bitmask(k, b.as_i32x16(), a.as_i32x16())) 11383 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11391:1 | 11391 | / pub unsafe fn _mm512_mask_blend_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11392 | | transmute(simd_select_bitmask(k, b.as_i64x8(), a.as_i64x8())) 11393 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11401:1 | 11401 | / pub unsafe fn _mm512_mask_blend_ps(k: __mmask16, a: __m512, b: __m512) -> __m512 { 11402 | | transmute(simd_select_bitmask(k, b.as_f32x16(), a.as_f32x16())) 11403 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11411:1 | 11411 | / pub unsafe fn _mm512_mask_blend_pd(k: __mmask8, a: __m512d, b: __m512d) -> __m512d { 11412 | | transmute(simd_select_bitmask(k, b.as_f64x8(), a.as_f64x8())) 11413 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11421:1 | 11421 | / pub unsafe fn _mm512_and_epi32(a: __m512i, b: __m512i) -> __m512i { 11422 | | transmute(simd_and(a.as_i32x16(), b.as_i32x16())) 11423 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11431:1 | 11431 | / pub unsafe fn _mm512_mask_and_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11432 | | let and = _mm512_and_epi32(a, b).as_i32x16(); 11433 | | transmute(simd_select_bitmask(k, and, src.as_i32x16())) 11434 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11442:1 | 11442 | / pub unsafe fn _mm512_maskz_and_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11443 | | let and = _mm512_and_epi32(a, b).as_i32x16(); 11444 | | let zero = _mm512_setzero_si512().as_i32x16(); 11445 | | transmute(simd_select_bitmask(k, and, zero)) 11446 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11454:1 | 11454 | / pub unsafe fn _mm512_and_epi64(a: __m512i, b: __m512i) -> __m512i { 11455 | | transmute(simd_and(a.as_i64x8(), b.as_i64x8())) 11456 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11464:1 | 11464 | / pub unsafe fn _mm512_mask_and_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11465 | | let and = _mm512_and_epi64(a, b).as_i64x8(); 11466 | | transmute(simd_select_bitmask(k, and, src.as_i64x8())) 11467 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11475:1 | 11475 | / pub unsafe fn _mm512_maskz_and_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11476 | | let and = _mm512_and_epi64(a, b).as_i64x8(); 11477 | | let zero = _mm512_setzero_si512().as_i64x8(); 11478 | | transmute(simd_select_bitmask(k, and, zero)) 11479 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11487:1 | 11487 | / pub unsafe fn _mm512_and_si512(a: __m512i, b: __m512i) -> __m512i { 11488 | | transmute(simd_and(a.as_i32x16(), b.as_i32x16())) 11489 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11497:1 | 11497 | / pub unsafe fn _mm512_or_epi32(a: __m512i, b: __m512i) -> __m512i { 11498 | | transmute(simd_or(a.as_i32x16(), b.as_i32x16())) 11499 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11507:1 | 11507 | / pub unsafe fn _mm512_mask_or_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11508 | | let or = _mm512_or_epi32(a, b).as_i32x16(); 11509 | | transmute(simd_select_bitmask(k, or, src.as_i32x16())) 11510 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11518:1 | 11518 | / pub unsafe fn _mm512_maskz_or_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11519 | | let or = _mm512_or_epi32(a, b).as_i32x16(); 11520 | | let zero = _mm512_setzero_si512().as_i32x16(); 11521 | | transmute(simd_select_bitmask(k, or, zero)) 11522 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11530:1 | 11530 | / pub unsafe fn _mm512_or_epi64(a: __m512i, b: __m512i) -> __m512i { 11531 | | transmute(simd_or(a.as_i64x8(), b.as_i64x8())) 11532 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11540:1 | 11540 | / pub unsafe fn _mm512_mask_or_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11541 | | let or = _mm512_or_epi64(a, b).as_i64x8(); 11542 | | transmute(simd_select_bitmask(k, or, src.as_i64x8())) 11543 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11551:1 | 11551 | / pub unsafe fn _mm512_maskz_or_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11552 | | let or = _mm512_or_epi64(a, b).as_i64x8(); 11553 | | let zero = _mm512_setzero_si512().as_i64x8(); 11554 | | transmute(simd_select_bitmask(k, or, zero)) 11555 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11563:1 | 11563 | / pub unsafe fn _mm512_or_si512(a: __m512i, b: __m512i) -> __m512i { 11564 | | transmute(simd_or(a.as_i32x16(), b.as_i32x16())) 11565 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11573:1 | 11573 | / pub unsafe fn _mm512_xor_epi32(a: __m512i, b: __m512i) -> __m512i { 11574 | | transmute(simd_xor(a.as_i32x16(), b.as_i32x16())) 11575 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11583:1 | 11583 | / pub unsafe fn _mm512_mask_xor_epi32(src: __m512i, k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11584 | | let xor = _mm512_xor_epi32(a, b).as_i32x16(); 11585 | | transmute(simd_select_bitmask(k, xor, src.as_i32x16())) 11586 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11594:1 | 11594 | / pub unsafe fn _mm512_maskz_xor_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11595 | | let xor = _mm512_xor_epi32(a, b).as_i32x16(); 11596 | | let zero = _mm512_setzero_si512().as_i32x16(); 11597 | | transmute(simd_select_bitmask(k, xor, zero)) 11598 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11606:1 | 11606 | / pub unsafe fn _mm512_xor_epi64(a: __m512i, b: __m512i) -> __m512i { 11607 | | transmute(simd_xor(a.as_i64x8(), b.as_i64x8())) 11608 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11616:1 | 11616 | / pub unsafe fn _mm512_mask_xor_epi64(src: __m512i, k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11617 | | let xor = _mm512_xor_epi64(a, b).as_i64x8(); 11618 | | transmute(simd_select_bitmask(k, xor, src.as_i64x8())) 11619 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11627:1 | 11627 | / pub unsafe fn _mm512_maskz_xor_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11628 | | let xor = _mm512_xor_epi64(a, b).as_i64x8(); 11629 | | let zero = _mm512_setzero_si512().as_i64x8(); 11630 | | transmute(simd_select_bitmask(k, xor, zero)) 11631 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11639:1 | 11639 | / pub unsafe fn _mm512_xor_si512(a: __m512i, b: __m512i) -> __m512i { 11640 | | transmute(simd_xor(a.as_i32x16(), b.as_i32x16())) 11641 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11649:1 | 11649 | / pub unsafe fn _mm512_andnot_epi32(a: __m512i, b: __m512i) -> __m512i { 11650 | | _mm512_and_epi32(_mm512_xor_epi32(a, _mm512_set1_epi32(u32::MAX as i32)), b) 11651 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11659:1 | 11659 | / pub unsafe fn _mm512_mask_andnot_epi32( 11660 | | src: __m512i, 11661 | | k: __mmask16, 11662 | | a: __m512i, ... | 11666 | | transmute(simd_select_bitmask(k, andnot, src.as_i32x16())) 11667 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11675:1 | 11675 | / pub unsafe fn _mm512_maskz_andnot_epi32(k: __mmask16, a: __m512i, b: __m512i) -> __m512i { 11676 | | let andnot = _mm512_andnot_epi32(a, b).as_i32x16(); 11677 | | let zero = _mm512_setzero_si512().as_i32x16(); 11678 | | transmute(simd_select_bitmask(k, andnot, zero)) 11679 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11687:1 | 11687 | / pub unsafe fn _mm512_andnot_epi64(a: __m512i, b: __m512i) -> __m512i { 11688 | | _mm512_and_epi64(_mm512_xor_epi64(a, _mm512_set1_epi64(u64::MAX as i64)), b) 11689 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11697:1 | 11697 | / pub unsafe fn _mm512_mask_andnot_epi64( 11698 | | src: __m512i, 11699 | | k: __mmask8, 11700 | | a: __m512i, ... | 11704 | | transmute(simd_select_bitmask(k, andnot, src.as_i64x8())) 11705 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11713:1 | 11713 | / pub unsafe fn _mm512_maskz_andnot_epi64(k: __mmask8, a: __m512i, b: __m512i) -> __m512i { 11714 | | let andnot = _mm512_andnot_epi64(a, b).as_i64x8(); 11715 | | let zero = _mm512_setzero_si512().as_i64x8(); 11716 | | transmute(simd_select_bitmask(k, andnot, zero)) 11717 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11725:1 | 11725 | / pub unsafe fn _mm512_andnot_si512(a: __m512i, b: __m512i) -> __m512i { 11726 | | _mm512_and_epi64(_mm512_xor_epi64(a, _mm512_set1_epi64(u64::MAX as i64)), b) 11727 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11735:1 | 11735 | / pub unsafe fn _kand_mask16(a: __mmask16, b: __mmask16) -> __mmask16 { 11736 | | transmute(a & b) 11737 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11745:1 | 11745 | / pub unsafe fn _mm512_kand(a: __mmask16, b: __mmask16) -> __mmask16 { 11746 | | transmute(a & b) 11747 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11755:1 | 11755 | / pub unsafe fn _kor_mask16(a: __mmask16, b: __mmask16) -> __mmask16 { 11756 | | transmute(a | b) 11757 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11765:1 | 11765 | / pub unsafe fn _mm512_kor(a: __mmask16, b: __mmask16) -> __mmask16 { 11766 | | transmute(a | b) 11767 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11775:1 | 11775 | / pub unsafe fn _kxor_mask16(a: __mmask16, b: __mmask16) -> __mmask16 { 11776 | | transmute(a ^ b) 11777 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11785:1 | 11785 | / pub unsafe fn _mm512_kxor(a: __mmask16, b: __mmask16) -> __mmask16 { 11786 | | transmute(a ^ b) 11787 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11794:1 | 11794 | / pub unsafe fn _knot_mask16(a: __mmask16) -> __mmask16 { 11795 | | transmute(a ^ 0b11111111_11111111) 11796 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11803:1 | 11803 | / pub unsafe fn _mm512_knot(a: __mmask16) -> __mmask16 { 11804 | | transmute(a ^ 0b11111111_11111111) 11805 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11813:1 | 11813 | / pub unsafe fn _kandn_mask16(a: __mmask16, b: __mmask16) -> __mmask16 { 11814 | | _mm512_kand(_mm512_knot(a), b) 11815 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11823:1 | 11823 | / pub unsafe fn _mm512_kandn(a: __mmask16, b: __mmask16) -> __mmask16 { 11824 | | _mm512_kand(_mm512_knot(a), b) 11825 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11833:1 | 11833 | / pub unsafe fn _kxnor_mask16(a: __mmask16, b: __mmask16) -> __mmask16 { 11834 | | _mm512_knot(_mm512_kxor(a, b)) 11835 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11843:1 | 11843 | / pub unsafe fn _mm512_kxnor(a: __mmask16, b: __mmask16) -> __mmask16 { 11844 | | _mm512_knot(_mm512_kxor(a, b)) 11845 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11853:1 | 11853 | / pub unsafe fn _mm512_kmov(a: __mmask16) -> __mmask16 { 11854 | | let r: u16 = a; 11855 | | transmute(r) 11856 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11863:1 | 11863 | / pub unsafe fn _mm512_set_ps( 11864 | | e0: f32, 11865 | | e1: f32, 11866 | | e2: f32, ... | 11883 | | ) 11884 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11863:1 | 11863 | / pub unsafe fn _mm512_set_ps( 11864 | | e0: f32, 11865 | | e1: f32, 11866 | | e2: f32, ... | 11879 | | e15: f32, 11880 | | ) -> __m512 { | |___________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11892:1 | 11892 | / pub unsafe fn _mm512_setr_ps( 11893 | | e0: f32, 11894 | | e1: f32, 11895 | | e2: f32, ... | 11913 | | transmute(r) 11914 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11892:1 | 11892 | / pub unsafe fn _mm512_setr_ps( 11893 | | e0: f32, 11894 | | e1: f32, 11895 | | e2: f32, ... | 11908 | | e15: f32, 11909 | | ) -> __m512 { | |___________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11919:1 | 11919 | / pub unsafe fn _mm512_set1_pd(a: f64) -> __m512d { 11920 | | transmute(f64x8::splat(a)) 11921 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11926:1 | 11926 | / pub unsafe fn _mm512_set1_ps(a: f32) -> __m512 { 11927 | | transmute(f32x16::splat(a)) 11928 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11933:1 | 11933 | / pub unsafe fn _mm512_set_epi32( 11934 | | e15: i32, 11935 | | e14: i32, 11936 | | e13: i32, ... | 11953 | | ) 11954 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (16/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11933:1 | 11933 | / pub unsafe fn _mm512_set_epi32( 11934 | | e15: i32, 11935 | | e14: i32, 11936 | | e13: i32, ... | 11949 | | e0: i32, 11950 | | ) -> __m512i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11959:1 | 11959 | / pub unsafe fn _mm512_set1_epi32(a: i32) -> __m512i { 11960 | | transmute(i32x16::splat(a)) 11961 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11966:1 | 11966 | / pub unsafe fn _mm512_set1_epi64(a: i64) -> __m512i { 11967 | | transmute(i64x8::splat(a)) 11968 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11976:1 | 11976 | / pub unsafe fn _mm512_cmplt_ps_mask(a: __m512, b: __m512) -> __mmask16 { 11977 | | _mm512_cmp_ps_mask(a, b, _CMP_LT_OS) 11978 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11987:1 | 11987 | / pub unsafe fn _mm512_mask_cmplt_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 11988 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_LT_OS) 11989 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:11997:1 | 11997 | / pub unsafe fn _mm512_cmpnlt_ps_mask(a: __m512, b: __m512) -> __mmask16 { 11998 | | _mm512_cmp_ps_mask(a, b, _CMP_NLT_US) 11999 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12008:1 | 12008 | / pub unsafe fn _mm512_mask_cmpnlt_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12009 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_NLT_US) 12010 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12018:1 | 12018 | / pub unsafe fn _mm512_cmple_ps_mask(a: __m512, b: __m512) -> __mmask16 { 12019 | | _mm512_cmp_ps_mask(a, b, _CMP_LE_OS) 12020 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12029:1 | 12029 | / pub unsafe fn _mm512_mask_cmple_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12030 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_LE_OS) 12031 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12039:1 | 12039 | / pub unsafe fn _mm512_cmpnle_ps_mask(a: __m512, b: __m512) -> __mmask16 { 12040 | | _mm512_cmp_ps_mask(a, b, _CMP_NLE_US) 12041 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12050:1 | 12050 | / pub unsafe fn _mm512_mask_cmpnle_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12051 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_NLE_US) 12052 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12060:1 | 12060 | / pub unsafe fn _mm512_cmpeq_ps_mask(a: __m512, b: __m512) -> __mmask16 { 12061 | | _mm512_cmp_ps_mask(a, b, _CMP_EQ_OQ) 12062 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12071:1 | 12071 | / pub unsafe fn _mm512_mask_cmpeq_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12072 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_EQ_OQ) 12073 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12081:1 | 12081 | / pub unsafe fn _mm512_cmpneq_ps_mask(a: __m512, b: __m512) -> __mmask16 { 12082 | | _mm512_cmp_ps_mask(a, b, _CMP_NEQ_UQ) 12083 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12092:1 | 12092 | / pub unsafe fn _mm512_mask_cmpneq_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12093 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_NEQ_UQ) 12094 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12103:1 | 12103 | / pub unsafe fn _mm512_cmp_ps_mask(a: __m512, b: __m512, op: i32) -> __mmask16 { 12104 | | let neg_one = -1; 12105 | | macro_rules! call { 12106 | | ($imm5:expr) => { ... | 12117 | | transmute(r) 12118 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12128:1 | 12128 | / pub unsafe fn _mm512_mask_cmp_ps_mask(m: __mmask16, a: __m512, b: __m512, op: i32) -> __mmask16 { 12129 | | macro_rules! call { 12130 | | ($imm5:expr) => { 12131 | | vcmpps( ... | 12141 | | transmute(r) 12142 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12151:1 | 12151 | / pub unsafe fn _mm512_cmp_round_ps_mask(a: __m512, b: __m512, op: i32, sae: i32) -> __mmask16 { 12152 | | let neg_one = -1; 12153 | | macro_rules! call { 12154 | | ($imm5:expr, $imm4:expr) => { ... | 12159 | | transmute(r) 12160 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12170:1 | 12170 | / pub unsafe fn _mm512_mask_cmp_round_ps_mask( 12171 | | m: __mmask16, 12172 | | a: __m512, 12173 | | b: __m512, ... | 12183 | | transmute(r) 12184 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12192:1 | 12192 | / pub unsafe fn _mm512_cmpord_ps_mask(a: __m512, b: __m512) -> __mmask16 { 12193 | | _mm512_cmp_ps_mask(a, b, _CMP_ORD_Q) 12194 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12202:1 | 12202 | / pub unsafe fn _mm512_mask_cmpord_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12203 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_ORD_Q) 12204 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12212:1 | 12212 | / pub unsafe fn _mm512_cmpunord_ps_mask(a: __m512, b: __m512) -> __mmask16 { 12213 | | _mm512_cmp_ps_mask(a, b, _CMP_UNORD_Q) 12214 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12222:1 | 12222 | / pub unsafe fn _mm512_mask_cmpunord_ps_mask(m: __mmask16, a: __m512, b: __m512) -> __mmask16 { 12223 | | _mm512_mask_cmp_ps_mask(m, a, b, _CMP_UNORD_Q) 12224 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12232:1 | 12232 | / pub unsafe fn _mm512_cmplt_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12233 | | _mm512_cmp_pd_mask(a, b, _CMP_LT_OS) 12234 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12243:1 | 12243 | / pub unsafe fn _mm512_mask_cmplt_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12244 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_LT_OS) 12245 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12253:1 | 12253 | / pub unsafe fn _mm512_cmpnlt_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12254 | | _mm512_cmp_pd_mask(a, b, _CMP_NLT_US) 12255 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12264:1 | 12264 | / pub unsafe fn _mm512_mask_cmpnlt_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12265 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_NLT_US) 12266 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12274:1 | 12274 | / pub unsafe fn _mm512_cmple_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12275 | | _mm512_cmp_pd_mask(a, b, _CMP_LE_OS) 12276 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12285:1 | 12285 | / pub unsafe fn _mm512_mask_cmple_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12286 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_LE_OS) 12287 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12295:1 | 12295 | / pub unsafe fn _mm512_cmpnle_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12296 | | _mm512_cmp_pd_mask(a, b, _CMP_NLE_US) 12297 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12306:1 | 12306 | / pub unsafe fn _mm512_mask_cmpnle_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12307 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_NLE_US) 12308 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12316:1 | 12316 | / pub unsafe fn _mm512_cmpeq_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12317 | | _mm512_cmp_pd_mask(a, b, _CMP_EQ_OQ) 12318 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12327:1 | 12327 | / pub unsafe fn _mm512_mask_cmpeq_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12328 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_EQ_OQ) 12329 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12337:1 | 12337 | / pub unsafe fn _mm512_cmpneq_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12338 | | _mm512_cmp_pd_mask(a, b, _CMP_NEQ_UQ) 12339 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12348:1 | 12348 | / pub unsafe fn _mm512_mask_cmpneq_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12349 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_NEQ_UQ) 12350 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12359:1 | 12359 | / pub unsafe fn _mm512_cmp_pd_mask(a: __m512d, b: __m512d, op: i32) -> __mmask8 { 12360 | | let neg_one = -1; 12361 | | macro_rules! call { 12362 | | ($imm5:expr) => { ... | 12373 | | transmute(r) 12374 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12384:1 | 12384 | / pub unsafe fn _mm512_mask_cmp_pd_mask(m: __mmask8, a: __m512d, b: __m512d, op: i32) -> __mmask8 { 12385 | | macro_rules! call { 12386 | | ($imm5:expr) => { 12387 | | vcmppd( ... | 12397 | | transmute(r) 12398 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12407:1 | 12407 | / pub unsafe fn _mm512_cmp_round_pd_mask(a: __m512d, b: __m512d, op: i32, sae: i32) -> __mmask8 { 12408 | | let neg_one = -1; 12409 | | macro_rules! call { 12410 | | ($imm5:expr, $imm4:expr) => { ... | 12415 | | transmute(r) 12416 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12426:1 | 12426 | / pub unsafe fn _mm512_mask_cmp_round_pd_mask( 12427 | | m: __mmask8, 12428 | | a: __m512d, 12429 | | b: __m512d, ... | 12439 | | transmute(r) 12440 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12448:1 | 12448 | / pub unsafe fn _mm512_cmpord_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12449 | | _mm512_cmp_pd_mask(a, b, _CMP_ORD_Q) 12450 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12458:1 | 12458 | / pub unsafe fn _mm512_mask_cmpord_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12459 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_ORD_Q) 12460 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12468:1 | 12468 | / pub unsafe fn _mm512_cmpunord_pd_mask(a: __m512d, b: __m512d) -> __mmask8 { 12469 | | _mm512_cmp_pd_mask(a, b, _CMP_UNORD_Q) 12470 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12478:1 | 12478 | / pub unsafe fn _mm512_mask_cmpunord_pd_mask(m: __mmask8, a: __m512d, b: __m512d) -> __mmask8 { 12479 | | _mm512_mask_cmp_pd_mask(m, a, b, _CMP_UNORD_Q) 12480 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12489:1 | 12489 | / pub unsafe fn _mm_cmp_ss_mask(a: __m128, b: __m128, op: i32) -> __mmask8 { 12490 | | let neg_one = -1; 12491 | | macro_rules! call { 12492 | | ($imm5:expr) => { ... | 12497 | | transmute(r) 12498 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12507:1 | 12507 | / pub unsafe fn _mm_mask_cmp_ss_mask(m: __mmask8, a: __m128, b: __m128, op: i32) -> __mmask8 { 12508 | | macro_rules! call { 12509 | | ($imm5:expr) => { 12510 | | vcmpss(a, b, $imm5, m as i8, _MM_FROUND_CUR_DIRECTION) ... | 12514 | | transmute(r) 12515 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12524:1 | 12524 | / pub unsafe fn _mm_cmp_round_ss_mask(a: __m128, b: __m128, op: i32, sae: i32) -> __mmask8 { 12525 | | let neg_one = -1; 12526 | | macro_rules! call { 12527 | | ($imm5:expr, $imm4:expr) => { ... | 12532 | | transmute(r) 12533 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12542:1 | 12542 | / pub unsafe fn _mm_mask_cmp_round_ss_mask( 12543 | | m: __mmask8, 12544 | | a: __m128, 12545 | | b: __m128, ... | 12555 | | transmute(r) 12556 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12565:1 | 12565 | / pub unsafe fn _mm_cmp_sd_mask(a: __m128d, b: __m128d, op: i32) -> __mmask8 { 12566 | | let neg_one = -1; 12567 | | macro_rules! call { 12568 | | ($imm5:expr) => { ... | 12573 | | transmute(r) 12574 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12583:1 | 12583 | / pub unsafe fn _mm_mask_cmp_sd_mask(m: __mmask8, a: __m128d, b: __m128d, op: i32) -> __mmask8 { 12584 | | macro_rules! call { 12585 | | ($imm5:expr) => { 12586 | | vcmpsd(a, b, $imm5, m as i8, _MM_FROUND_CUR_DIRECTION) ... | 12590 | | transmute(r) 12591 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12600:1 | 12600 | / pub unsafe fn _mm_cmp_round_sd_mask(a: __m128d, b: __m128d, op: i32, sae: i32) -> __mmask8 { 12601 | | let neg_one = -1; 12602 | | macro_rules! call { 12603 | | ($imm5:expr, $imm4:expr) => { ... | 12608 | | transmute(r) 12609 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12618:1 | 12618 | / pub unsafe fn _mm_mask_cmp_round_sd_mask( 12619 | | m: __mmask8, 12620 | | a: __m128d, 12621 | | b: __m128d, ... | 12631 | | transmute(r) 12632 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12640:1 | 12640 | / pub unsafe fn _mm512_cmplt_epu32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12641 | | simd_bitmask::(simd_lt(a.as_u32x16(), b.as_u32x16())) 12642 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12651:1 | 12651 | / pub unsafe fn _mm512_mask_cmplt_epu32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12652 | | _mm512_cmplt_epu32_mask(a, b) & m 12653 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12661:1 | 12661 | / pub unsafe fn _mm512_cmpgt_epu32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12662 | | simd_bitmask::(simd_gt(a.as_u32x16(), b.as_u32x16())) 12663 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12672:1 | 12672 | / pub unsafe fn _mm512_mask_cmpgt_epu32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12673 | | _mm512_cmpgt_epu32_mask(a, b) & m 12674 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12682:1 | 12682 | / pub unsafe fn _mm512_cmple_epu32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12683 | | simd_bitmask::(simd_le(a.as_u32x16(), b.as_u32x16())) 12684 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12693:1 | 12693 | / pub unsafe fn _mm512_mask_cmple_epu32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12694 | | _mm512_cmple_epu32_mask(a, b) & m 12695 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12703:1 | 12703 | / pub unsafe fn _mm512_cmpge_epu32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12704 | | simd_bitmask::(simd_ge(a.as_u32x16(), b.as_u32x16())) 12705 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12714:1 | 12714 | / pub unsafe fn _mm512_mask_cmpge_epu32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12715 | | _mm512_cmpge_epu32_mask(a, b) & m 12716 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12724:1 | 12724 | / pub unsafe fn _mm512_cmpeq_epu32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12725 | | simd_bitmask::(simd_eq(a.as_u32x16(), b.as_u32x16())) 12726 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12735:1 | 12735 | / pub unsafe fn _mm512_mask_cmpeq_epu32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12736 | | _mm512_cmpeq_epu32_mask(a, b) & m 12737 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12745:1 | 12745 | / pub unsafe fn _mm512_cmpneq_epu32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12746 | | simd_bitmask::(simd_ne(a.as_u32x16(), b.as_u32x16())) 12747 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12756:1 | 12756 | / pub unsafe fn _mm512_mask_cmpneq_epu32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12757 | | _mm512_cmpneq_epu32_mask(a, b) & m 12758 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12767:1 | 12767 | / pub unsafe fn _mm512_cmp_epu32_mask(a: __m512i, b: __m512i, op: _MM_CMPINT_ENUM) -> __mmask16 { 12768 | | let neg_one = -1; 12769 | | macro_rules! call { 12770 | | ($imm3:expr) => { ... | 12775 | | transmute(r) 12776 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12786:1 | 12786 | / pub unsafe fn _mm512_mask_cmp_epu32_mask( 12787 | | m: __mmask16, 12788 | | a: __m512i, 12789 | | b: __m512i, ... | 12798 | | transmute(r) 12799 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12807:1 | 12807 | / pub unsafe fn _mm512_cmplt_epi32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12808 | | simd_bitmask::(simd_lt(a.as_i32x16(), b.as_i32x16())) 12809 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12818:1 | 12818 | / pub unsafe fn _mm512_mask_cmplt_epi32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12819 | | _mm512_cmplt_epi32_mask(a, b) & m 12820 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12828:1 | 12828 | / pub unsafe fn _mm512_cmpgt_epi32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12829 | | simd_bitmask::(simd_gt(a.as_i32x16(), b.as_i32x16())) 12830 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12839:1 | 12839 | / pub unsafe fn _mm512_mask_cmpgt_epi32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12840 | | _mm512_cmpgt_epi32_mask(a, b) & m 12841 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12849:1 | 12849 | / pub unsafe fn _mm512_cmple_epi32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12850 | | simd_bitmask::(simd_le(a.as_i32x16(), b.as_i32x16())) 12851 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12860:1 | 12860 | / pub unsafe fn _mm512_mask_cmple_epi32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12861 | | _mm512_cmple_epi32_mask(a, b) & m 12862 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12870:1 | 12870 | / pub unsafe fn _mm512_cmpge_epi32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12871 | | simd_bitmask::(simd_ge(a.as_i32x16(), b.as_i32x16())) 12872 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12881:1 | 12881 | / pub unsafe fn _mm512_mask_cmpge_epi32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12882 | | _mm512_cmpge_epi32_mask(a, b) & m 12883 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12891:1 | 12891 | / pub unsafe fn _mm512_cmpeq_epi32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12892 | | simd_bitmask::(simd_eq(a.as_i32x16(), b.as_i32x16())) 12893 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12902:1 | 12902 | / pub unsafe fn _mm512_mask_cmpeq_epi32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12903 | | _mm512_cmpeq_epi32_mask(a, b) & m 12904 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12912:1 | 12912 | / pub unsafe fn _mm512_cmpneq_epi32_mask(a: __m512i, b: __m512i) -> __mmask16 { 12913 | | simd_bitmask::(simd_ne(a.as_i32x16(), b.as_i32x16())) 12914 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12923:1 | 12923 | / pub unsafe fn _mm512_mask_cmpneq_epi32_mask(m: __mmask16, a: __m512i, b: __m512i) -> __mmask16 { 12924 | | _mm512_cmpneq_epi32_mask(a, b) & m 12925 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12934:1 | 12934 | / pub unsafe fn _mm512_cmp_epi32_mask(a: __m512i, b: __m512i, op: _MM_CMPINT_ENUM) -> __mmask16 { 12935 | | let neg_one = -1; 12936 | | macro_rules! call { 12937 | | ($imm3:expr) => { ... | 12942 | | transmute(r) 12943 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12953:1 | 12953 | / pub unsafe fn _mm512_mask_cmp_epi32_mask( 12954 | | m: __mmask16, 12955 | | a: __m512i, 12956 | | b: __m512i, ... | 12965 | | transmute(r) 12966 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12974:1 | 12974 | / pub unsafe fn _mm512_cmplt_epu64_mask(a: __m512i, b: __m512i) -> __mmask8 { 12975 | | simd_bitmask::<__m512i, _>(simd_lt(a.as_u64x8(), b.as_u64x8())) 12976 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12985:1 | 12985 | / pub unsafe fn _mm512_mask_cmplt_epu64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 12986 | | _mm512_cmplt_epu64_mask(a, b) & m 12987 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:12995:1 | 12995 | / pub unsafe fn _mm512_cmpgt_epu64_mask(a: __m512i, b: __m512i) -> __mmask8 { 12996 | | simd_bitmask::<__m512i, _>(simd_gt(a.as_u64x8(), b.as_u64x8())) 12997 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13006:1 | 13006 | / pub unsafe fn _mm512_mask_cmpgt_epu64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13007 | | _mm512_cmpgt_epu64_mask(a, b) & m 13008 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13016:1 | 13016 | / pub unsafe fn _mm512_cmple_epu64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13017 | | simd_bitmask::<__m512i, _>(simd_le(a.as_u64x8(), b.as_u64x8())) 13018 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13027:1 | 13027 | / pub unsafe fn _mm512_mask_cmple_epu64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13028 | | _mm512_cmple_epu64_mask(a, b) & m 13029 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13037:1 | 13037 | / pub unsafe fn _mm512_cmpge_epu64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13038 | | simd_bitmask::<__m512i, _>(simd_ge(a.as_u64x8(), b.as_u64x8())) 13039 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13048:1 | 13048 | / pub unsafe fn _mm512_mask_cmpge_epu64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13049 | | _mm512_cmpge_epu64_mask(b, a) & m 13050 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13058:1 | 13058 | / pub unsafe fn _mm512_cmpeq_epu64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13059 | | simd_bitmask::<__m512i, _>(simd_eq(a.as_u64x8(), b.as_u64x8())) 13060 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13069:1 | 13069 | / pub unsafe fn _mm512_mask_cmpeq_epu64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13070 | | _mm512_cmpeq_epu64_mask(a, b) & m 13071 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13079:1 | 13079 | / pub unsafe fn _mm512_cmpneq_epu64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13080 | | simd_bitmask::<__m512i, _>(simd_ne(a.as_u64x8(), b.as_u64x8())) 13081 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13090:1 | 13090 | / pub unsafe fn _mm512_mask_cmpneq_epu64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13091 | | _mm512_cmpneq_epu64_mask(a, b) & m 13092 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13101:1 | 13101 | / pub unsafe fn _mm512_cmp_epu64_mask(a: __m512i, b: __m512i, op: _MM_CMPINT_ENUM) -> __mmask8 { 13102 | | let neg_one = -1; 13103 | | macro_rules! call { 13104 | | ($imm3:expr) => { ... | 13109 | | transmute(r) 13110 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13120:1 | 13120 | / pub unsafe fn _mm512_mask_cmp_epu64_mask( 13121 | | m: __mmask8, 13122 | | a: __m512i, 13123 | | b: __m512i, ... | 13132 | | transmute(r) 13133 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13141:1 | 13141 | / pub unsafe fn _mm512_cmplt_epi64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13142 | | simd_bitmask::<__m512i, _>(simd_lt(a.as_i64x8(), b.as_i64x8())) 13143 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13152:1 | 13152 | / pub unsafe fn _mm512_mask_cmplt_epi64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13153 | | _mm512_cmplt_epi64_mask(a, b) & m 13154 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13162:1 | 13162 | / pub unsafe fn _mm512_cmpgt_epi64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13163 | | simd_bitmask::<__m512i, _>(simd_gt(a.as_i64x8(), b.as_i64x8())) 13164 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13173:1 | 13173 | / pub unsafe fn _mm512_mask_cmpgt_epi64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13174 | | _mm512_cmpgt_epi64_mask(a, b) & m 13175 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13183:1 | 13183 | / pub unsafe fn _mm512_cmple_epi64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13184 | | simd_bitmask::<__m512i, _>(simd_le(a.as_i64x8(), b.as_i64x8())) 13185 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13194:1 | 13194 | / pub unsafe fn _mm512_mask_cmple_epi64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13195 | | _mm512_cmple_epi64_mask(a, b) & m 13196 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13204:1 | 13204 | / pub unsafe fn _mm512_cmpge_epi64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13205 | | simd_bitmask::<__m512i, _>(simd_ge(a.as_i64x8(), b.as_i64x8())) 13206 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13215:1 | 13215 | / pub unsafe fn _mm512_mask_cmpge_epi64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13216 | | _mm512_cmpge_epi64_mask(b, a) & m 13217 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13225:1 | 13225 | / pub unsafe fn _mm512_cmpeq_epi64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13226 | | simd_bitmask::<__m512i, _>(simd_eq(a.as_i64x8(), b.as_i64x8())) 13227 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13236:1 | 13236 | / pub unsafe fn _mm512_mask_cmpeq_epi64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13237 | | _mm512_cmpeq_epi64_mask(a, b) & m 13238 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13246:1 | 13246 | / pub unsafe fn _mm512_cmpneq_epi64_mask(a: __m512i, b: __m512i) -> __mmask8 { 13247 | | simd_bitmask::<__m512i, _>(simd_ne(a.as_i64x8(), b.as_i64x8())) 13248 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13257:1 | 13257 | / pub unsafe fn _mm512_mask_cmpneq_epi64_mask(m: __mmask8, a: __m512i, b: __m512i) -> __mmask8 { 13258 | | _mm512_cmpneq_epi64_mask(a, b) & m 13259 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13268:1 | 13268 | / pub unsafe fn _mm512_cmp_epi64_mask(a: __m512i, b: __m512i, op: _MM_CMPINT_ENUM) -> __mmask8 { 13269 | | let neg_one = -1; 13270 | | macro_rules! call { 13271 | | ($imm3:expr) => { ... | 13276 | | transmute(r) 13277 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13287:1 | 13287 | / pub unsafe fn _mm512_mask_cmp_epi64_mask( 13288 | | m: __mmask8, 13289 | | a: __m512i, 13290 | | b: __m512i, ... | 13299 | | transmute(r) 13300 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13308:1 | 13308 | / pub unsafe fn _mm512_undefined_pd() -> __m512d { 13309 | | _mm512_set1_pd(0.0) 13310 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13318:1 | 13318 | / pub unsafe fn _mm512_undefined_ps() -> __m512 { 13319 | | _mm512_set1_ps(0.0) 13320 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13330:1 | 13330 | / pub unsafe fn _mm512_loadu_pd(mem_addr: *const f64) -> __m512d { 13331 | | ptr::read_unaligned(mem_addr as *const __m512d) 13332 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13342:1 | 13342 | / pub unsafe fn _mm512_storeu_pd(mem_addr: *mut f64, a: __m512d) { 13343 | | ptr::write_unaligned(mem_addr as *mut __m512d, a); 13344 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13354:1 | 13354 | / pub unsafe fn _mm512_loadu_ps(mem_addr: *const f32) -> __m512 { 13355 | | ptr::read_unaligned(mem_addr as *const __m512) 13356 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13367:1 | 13367 | / pub unsafe fn _mm512_storeu_ps(mem_addr: *mut f32, a: __m512) { 13368 | | ptr::write_unaligned(mem_addr as *mut __m512, a); 13369 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13377:1 | 13377 | / pub unsafe fn _mm512_setr_pd( 13378 | | e0: f64, 13379 | | e1: f64, 13380 | | e2: f64, ... | 13388 | | transmute(r) 13389 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13377:1 | 13377 | / pub unsafe fn _mm512_setr_pd( 13378 | | e0: f64, 13379 | | e1: f64, 13380 | | e2: f64, ... | 13385 | | e7: f64, 13386 | | ) -> __m512d { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13396:1 | 13396 | / pub unsafe fn _mm512_set_pd( 13397 | | e0: f64, 13398 | | e1: f64, 13399 | | e2: f64, ... | 13406 | | _mm512_setr_pd(e7, e6, e5, e4, e3, e2, e1, e0) 13407 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:13396:1 | 13396 | / pub unsafe fn _mm512_set_pd( 13397 | | e0: f64, 13398 | | e1: f64, 13399 | | e2: f64, ... | 13404 | | e7: f64, 13405 | | ) -> __m512d { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512ifma.rs:16:1 | 16 | / pub unsafe fn _mm512_madd52hi_epu64(a: __m512i, b: __m512i, c: __m512i) -> __m512i { 17 | | vpmadd52huq_512(a, b, c) 18 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512ifma.rs:30:1 | 30 | / pub unsafe fn _mm512_madd52lo_epu64(a: __m512i, b: __m512i, c: __m512i) -> __m512i { 31 | | vpmadd52luq_512(a, b, c) 32 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512ifma.rs:44:1 | 44 | / pub unsafe fn _mm256_madd52hi_epu64(a: __m256i, b: __m256i, c: __m256i) -> __m256i { 45 | | vpmadd52huq_256(a, b, c) 46 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512ifma.rs:58:1 | 58 | / pub unsafe fn _mm256_madd52lo_epu64(a: __m256i, b: __m256i, c: __m256i) -> __m256i { 59 | | vpmadd52luq_256(a, b, c) 60 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512ifma.rs:72:1 | 72 | / pub unsafe fn _mm_madd52hi_epu64(a: __m128i, b: __m128i, c: __m128i) -> __m128i { 73 | | vpmadd52huq_128(a, b, c) 74 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512ifma.rs:86:1 | 86 | / pub unsafe fn _mm_madd52lo_epu64(a: __m128i, b: __m128i, c: __m128i) -> __m128i { 87 | | vpmadd52luq_128(a, b, c) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bt.rs:8:1 | 8 | / pub unsafe fn _bittest(p: *const i32, b: i32) -> u8 { 9 | | let r: u8; 10 | | llvm_asm!("btl $2, $1\n\tsetc ${0:b}" 11 | | : "=r"(r) ... | 14 | | r 15 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bt.rs:21:1 | 21 | / pub unsafe fn _bittestandset(p: *mut i32, b: i32) -> u8 { 22 | | let r: u8; 23 | | llvm_asm!("btsl $2, $1\n\tsetc ${0:b}" 24 | | : "=r"(r), "+*m"(p) ... | 27 | | r 28 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bt.rs:34:1 | 34 | / pub unsafe fn _bittestandreset(p: *mut i32, b: i32) -> u8 { 35 | | let r: u8; 36 | | llvm_asm!("btrl $2, $1\n\tsetc ${0:b}" 37 | | : "=r"(r), "+*m"(p) ... | 40 | | r 41 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/bt.rs:47:1 | 47 | / pub unsafe fn _bittestandcomplement(p: *mut i32, b: i32) -> u8 { 48 | | let r: u8; 49 | | llvm_asm!("btcl $2, $1\n\tsetc ${0:b}" 50 | | : "=r"(r), "+*m"(p) ... | 53 | | r 54 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rtm.rs:60:1 | 60 | / pub unsafe fn _xbegin() -> u32 { 61 | | x86_xbegin() as _ 62 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rtm.rs:70:1 | 70 | / pub unsafe fn _xend() { 71 | | x86_xend() 72 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rtm.rs:81:1 | 81 | / pub unsafe fn _xabort(imm8: u32) { 82 | | macro_rules! call { 83 | | ($imm8:expr) => { 84 | | x86_xabort($imm8) ... | 87 | | constify_imm8!(imm8, call) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/rtm.rs:97:1 | 97 | / pub unsafe fn _xtest() -> u8 { 98 | | x86_xtest() as _ 99 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/f16c.rs:32:1 | 32 | / pub unsafe fn _mm_cvtph_ps(a: __m128i) -> __m128 { 33 | | transmute(llvm_vcvtph2ps_128(transmute(a))) 34 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/f16c.rs:41:1 | 41 | / pub unsafe fn _mm256_cvtph_ps(a: __m128i) -> __m256 { 42 | | transmute(llvm_vcvtph2ps_256(transmute(a))) 43 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/f16c.rs:76:1 | 76 | / pub unsafe fn _mm_cvtps_ph(a: __m128, imm_rounding: i32) -> __m128i { 77 | | let a = transmute(a); 78 | | macro_rules! call { 79 | | ($rounding:expr) => { ... | 83 | | transmute(dispatch_rounding!(imm_rounding, call)) 84 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86/f16c.rs:100:1 | 100 | / pub unsafe fn _mm256_cvtps_ph(a: __m256, imm_rounding: i32) -> __m128i { 101 | | let a = transmute(a); 102 | | macro_rules! call { 103 | | ($rounding:expr) => { ... | 107 | | transmute(dispatch_rounding!(imm_rounding, call)) 108 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/fxsr.rs:30:1 | 30 | / pub unsafe fn _fxsave64(mem_addr: *mut u8) { 31 | | fxsave64(mem_addr) 32 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/fxsr.rs:54:1 | 54 | / pub unsafe fn _fxrstor64(mem_addr: *const u8) { 55 | | fxrstor64(mem_addr) 56 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse.rs:33:1 | 33 | / pub unsafe fn _mm_cvtss_si64(a: __m128) -> i64 { 34 | | cvtss2si64(a) 35 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse.rs:52:1 | 52 | / pub unsafe fn _mm_cvttss_si64(a: __m128) -> i64 { 53 | | cvttss2si64(a) 54 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse.rs:67:1 | 67 | / pub unsafe fn _mm_cvtsi64_ss(a: __m128, b: i64) -> __m128 { 68 | | cvtsi642ss(a, b) 69 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:27:1 | 27 | / pub unsafe fn _mm_cvtsd_si64(a: __m128d) -> i64 { 28 | | cvtsd2si64(a) 29 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:38:1 | 38 | / pub unsafe fn _mm_cvtsd_si64x(a: __m128d) -> i64 { 39 | | _mm_cvtsd_si64(a) 40 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:50:1 | 50 | / pub unsafe fn _mm_cvttsd_si64(a: __m128d) -> i64 { 51 | | cvttsd2si64(a) 52 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:61:1 | 61 | / pub unsafe fn _mm_cvttsd_si64x(a: __m128d) -> i64 { 62 | | _mm_cvttsd_si64(a) 63 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:74:1 | 74 | / pub unsafe fn _mm_stream_si64(mem_addr: *mut i64, a: i64) { 75 | | intrinsics::nontemporal_store(mem_addr, a); 76 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:86:1 | 86 | / pub unsafe fn _mm_cvtsi64_si128(a: i64) -> __m128i { 87 | | _mm_set_epi64x(0, a) 88 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:98:1 | 98 | / pub unsafe fn _mm_cvtsi64x_si128(a: i64) -> __m128i { 99 | | _mm_cvtsi64_si128(a) 100 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:109:1 | 109 | / pub unsafe fn _mm_cvtsi128_si64(a: __m128i) -> i64 { 110 | | simd_extract(a.as_i64x2(), 0) 111 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:120:1 | 120 | / pub unsafe fn _mm_cvtsi128_si64x(a: __m128i) -> i64 { 121 | | _mm_cvtsi128_si64(a) 122 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:132:1 | 132 | / pub unsafe fn _mm_cvtsi64_sd(a: __m128d, b: i64) -> __m128d { 133 | | simd_insert(a, 0, b as f64) 134 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse2.rs:144:1 | 144 | / pub unsafe fn _mm_cvtsi64x_sd(a: __m128d, b: i64) -> __m128d { 145 | | _mm_cvtsi64_sd(a, b) 146 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse41.rs:19:1 | 19 | / pub unsafe fn _mm_extract_epi64(a: __m128i, imm8: i32) -> i64 { 20 | | let a = a.as_i64x2(); 21 | | match imm8 & 1 { 22 | | 0 => simd_extract(a, 0), 23 | | _ => simd_extract(a, 1), 24 | | } 25 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse41.rs:36:1 | 36 | / pub unsafe fn _mm_insert_epi64(a: __m128i, i: i64, imm8: i32) -> __m128i { 37 | | let a = a.as_i64x2(); 38 | | match imm8 & 1 { 39 | | 0 => transmute(simd_insert(a, 0, i)), 40 | | _ => transmute(simd_insert(a, 1, i)), 41 | | } 42 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/sse42.rs:20:1 | 20 | / pub unsafe fn _mm_crc32_u64(crc: u64, v: u64) -> u64 { 21 | | crc32_64_64(crc, v) 22 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:38:1 | 38 | / pub unsafe fn _xsave64(mem_addr: *mut u8, save_mask: u64) { 39 | | xsave64(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 40 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:54:1 | 54 | / pub unsafe fn _xrstor64(mem_addr: *const u8, rs_mask: u64) { 55 | | xrstor64(mem_addr, (rs_mask >> 32) as u32, rs_mask as u32); 56 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:71:1 | 71 | / pub unsafe fn _xsaveopt64(mem_addr: *mut u8, save_mask: u64) { 72 | | xsaveopt64(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 73 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:87:1 | 87 | / pub unsafe fn _xsavec64(mem_addr: *mut u8, save_mask: u64) { 88 | | xsavec64(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 89 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:104:1 | 104 | / pub unsafe fn _xsaves64(mem_addr: *mut u8, save_mask: u64) { 105 | | xsaves64(mem_addr, (save_mask >> 32) as u32, save_mask as u32); 106 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/xsave.rs:123:1 | 123 | / pub unsafe fn _xrstors64(mem_addr: *const u8, rs_mask: u64) { 124 | | xrstors64(mem_addr, (rs_mask >> 32) as u32, rs_mask as u32); 125 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/abm.rs:32:1 | 32 | / pub unsafe fn _lzcnt_u64(x: u64) -> u64 { 33 | | x.leading_zeros() as u64 34 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/abm.rs:43:1 | 43 | / pub unsafe fn _popcnt64(x: i64) -> i32 { 44 | | x.count_ones() as i32 45 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/avx.rs:30:1 | 30 | / pub unsafe fn _mm256_insert_epi64(a: __m256i, i: i64, index: i32) -> __m256i { 31 | | let a = a.as_i64x4(); 32 | | match index & 3 { 33 | | 0 => transmute(simd_insert(a, 0, i)), ... | 37 | | } 38 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:24:1 | 24 | / pub unsafe fn _bextr_u64(a: u64, start: u32, len: u32) -> u64 { 25 | | _bextr2_u64(a, ((start & 0xff) | ((len & 0xff) << 8)) as u64) 26 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:40:1 | 40 | / pub unsafe fn _bextr2_u64(a: u64, control: u64) -> u64 { 41 | | x86_bmi_bextr_64(a, control) 42 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:51:1 | 51 | / pub unsafe fn _andn_u64(a: u64, b: u64) -> u64 { 52 | | !a & b 53 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:63:1 | 63 | / pub unsafe fn _blsi_u64(x: u64) -> u64 { 64 | | x & x.wrapping_neg() 65 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:75:1 | 75 | / pub unsafe fn _blsmsk_u64(x: u64) -> u64 { 76 | | x ^ (x.wrapping_sub(1_u64)) 77 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:89:1 | 89 | / pub unsafe fn _blsr_u64(x: u64) -> u64 { 90 | | x & (x.wrapping_sub(1)) 91 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:102:1 | 102 | / pub unsafe fn _tzcnt_u64(x: u64) -> u64 { 103 | | x.trailing_zeros() as u64 104 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi.rs:115:1 | 115 | / pub unsafe fn _mm_tzcnt_64(x: u64) -> i64 { 116 | | x.trailing_zeros() as i64 117 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi2.rs:27:1 | 27 | / pub unsafe fn _mulx_u64(a: u64, b: u64, hi: &mut u64) -> u64 { 28 | | let result: u128 = (a as u128) * (b as u128); 29 | | *hi = (result >> 64) as u64; 30 | | result as u64 31 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi2.rs:41:1 | 41 | / pub unsafe fn _bzhi_u64(a: u64, index: u32) -> u64 { 42 | | x86_bmi2_bzhi_64(a, index as u64) 43 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi2.rs:54:1 | 54 | / pub unsafe fn _pdep_u64(a: u64, mask: u64) -> u64 { 55 | | x86_bmi2_pdep_64(a, mask) 56 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bmi2.rs:67:1 | 67 | / pub unsafe fn _pext_u64(a: u64, mask: u64) -> u64 { 68 | | x86_bmi2_pext_64(a, mask) 69 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/avx2.rs:31:1 | 31 | / pub unsafe fn _mm256_extract_epi64(a: __m256i, imm8: i32) -> i64 { 32 | | let a = a.as_i64x4(); 33 | | match imm8 & 3 { 34 | | 0 => simd_extract(a, 0), ... | 38 | | } 39 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/avx512f.rs:11:1 | 11 | / pub unsafe fn _mm512_set_epi64( 12 | | e0: i64, 13 | | e1: i64, 14 | | e2: i64, ... | 21 | | _mm512_setr_epi64(e7, e6, e5, e4, e3, e2, e1, e0) 22 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/avx512f.rs:11:1 | 11 | / pub unsafe fn _mm512_set_epi64( 12 | | e0: i64, 13 | | e1: i64, 14 | | e2: i64, ... | 19 | | e7: i64, 20 | | ) -> __m512i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/avx512f.rs:30:1 | 30 | / pub unsafe fn _mm512_setr_epi64( 31 | | e0: i64, 32 | | e1: i64, 33 | | e2: i64, ... | 41 | | transmute(r) 42 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/avx512f.rs:30:1 | 30 | / pub unsafe fn _mm512_setr_epi64( 31 | | e0: i64, 32 | | e1: i64, 33 | | e2: i64, ... | 38 | | e7: i64, 39 | | ) -> __m512i { | |____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bswap.rs:14:1 | 14 | / pub unsafe fn _bswap64(x: i64) -> i64 { 15 | | x.swap_bytes() 16 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/rdrand.rs:26:1 | 26 | / pub unsafe fn _rdrand64_step(val: &mut u64) -> i32 { 27 | | let (v, flag) = x86_rdrand64_step(); 28 | | *val = v; 29 | | flag 30 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/rdrand.rs:40:1 | 40 | / pub unsafe fn _rdseed64_step(val: &mut u64) -> i32 { 41 | | let (v, flag) = x86_rdseed64_step(); 42 | | *val = v; 43 | | flag 44 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/cmpxchg16b.rs:45:1 | 45 | / pub unsafe fn cmpxchg16b( 46 | | dst: *mut u128, 47 | | old: u128, 48 | | new: u128, ... | 72 | | val 73 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/adx.rs:20:1 | 20 | / pub unsafe fn _addcarry_u64(c_in: u8, a: u64, b: u64, out: &mut u64) -> u8 { 21 | | let (a, b) = llvm_addcarry_u64(c_in, a, b); 22 | | *out = b; 23 | | a 24 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/adx.rs:33:1 | 33 | / pub unsafe fn _addcarryx_u64(c_in: u8, a: u64, b: u64, out: &mut u64) -> u8 { 34 | | llvm_addcarryx_u64(c_in, a, b, out as *mut _ as *mut u8) 35 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/adx.rs:43:1 | 43 | / pub unsafe fn _subborrow_u64(c_in: u8, a: u64, b: u64, out: &mut u64) -> u8 { 44 | | let (a, b) = llvm_subborrow_u64(c_in, a, b); 45 | | *out = b; 46 | | a 47 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bt.rs:8:1 | 8 | / pub unsafe fn _bittest64(p: *const i64, b: i64) -> u8 { 9 | | let r: u8; 10 | | llvm_asm!("btq $2, $1\n\tsetc ${0:b}" 11 | | : "=r"(r) ... | 14 | | r 15 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bt.rs:21:1 | 21 | / pub unsafe fn _bittestandset64(p: *mut i64, b: i64) -> u8 { 22 | | let r: u8; 23 | | llvm_asm!("btsq $2, $1\n\tsetc ${0:b}" 24 | | : "=r"(r), "+*m"(p) ... | 27 | | r 28 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bt.rs:34:1 | 34 | / pub unsafe fn _bittestandreset64(p: *mut i64, b: i64) -> u8 { 35 | | let r: u8; 36 | | llvm_asm!("btrq $2, $1\n\tsetc ${0:b}" 37 | | : "=r"(r), "+*m"(p) ... | 40 | | r 41 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/core/src/../../stdarch/crates/core_arch/src/x86_64/bt.rs:47:1 | 47 | / pub unsafe fn _bittestandcomplement64(p: *mut i64, b: i64) -> u8 { 48 | | let r: u8; 49 | | llvm_asm!("btcq $2, $1\n\tsetc ${0:b}" 50 | | : "=r"(r), "+*m"(p) ... | 53 | | r 54 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: 2033 warnings emitted warning: redundant field names in struct initialization --> library/alloc/src/collections/btree/map.rs:315:16 | 315 | Iter { range: range, length: self.length } | ^^^^^^^^^^^^ help: replace it with: `range` | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/boxed.rs:892:5 | 892 | / fn ne(&self, other: &Self) -> bool { 893 | | PartialEq::ne(&**self, &**other) 894 | | } | |_____^ | = note: `#[warn(clippy::partialeq_ne_impl)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. --> library/alloc/src/collections/binary_heap.rs:1422:31 | 1422 | fn spec_extend(&mut self, ref mut other: BinaryHeap) { | ^^^^^^^^^^^^^ | = note: `#[warn(clippy::toplevel_ref_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:16:6 | 16 | ) -> ( | ______^ 17 | | Handle, marker::Edge>, 18 | | Handle, marker::Edge>, 19 | | ) | |_^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:101:6 | 101 | ) -> ( | ______^ 102 | | Handle, marker::Edge>, 103 | | Handle, marker::Edge>, 104 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: unsafe function's docs miss `# Safety` section --> library/panic_abort/src/lib.rs:25:1 | 25 | / pub unsafe extern "C" fn __rust_panic_cleanup(_: *mut u8) -> *mut (dyn Any + Send + 'static) { 26 | | unreachable!() 27 | | } | |_^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:128:10 | 128 | ) -> ( | __________^ 129 | | Handle, K, V, marker::Leaf>, marker::Edge>, 130 | | Handle, K, V, marker::Leaf>, marker::Edge>, 131 | | ) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: unsafe function's docs miss `# Safety` section --> library/panic_abort/src/lib.rs:31:1 | 31 | / pub unsafe extern "C" fn __rust_start_panic(_payload: usize) -> u32 { 32 | | abort(); 33 | | 34 | | cfg_if::cfg_if! { ... | 80 | | } 81 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: 2 warnings emitted warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:143:10 | 143 | ) -> ( | __________^ 144 | | Handle, K, V, marker::Leaf>, marker::Edge>, 145 | | Handle, K, V, marker::Leaf>, marker::Edge>, 146 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:158:10 | 158 | ) -> ( | __________^ 159 | | Handle, K, V, marker::Leaf>, marker::Edge>, 160 | | Handle, K, V, marker::Leaf>, marker::Edge>, 161 | | ) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:178:10 | 178 | ) -> ( | __________^ 179 | | Handle, K, V, marker::Leaf>, marker::Edge>, 180 | | Handle, K, V, marker::Leaf>, marker::Edge>, 181 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:195:10 | 195 | ) -> ( | __________^ 196 | | Handle, marker::Edge>, 197 | | Handle, marker::Edge>, 198 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:212:10 | 212 | ) -> Result< | __________^ 213 | | Handle, marker::KV>, 214 | | NodeRef, 215 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:233:10 | 233 | ) -> Result< | __________^ 234 | | Handle, marker::KV>, 235 | | NodeRef, 236 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/navigate.rs:256:10 | 256 | ) -> Result< | __________^ 257 | | Handle, marker::KV>, 258 | | NodeRef, 259 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: the function `ptr::read` doesn't need a mutable reference --> library/alloc/src/collections/btree/node.rs:197:52 | 197 | new_node.edges[0].write(unsafe { ptr::read(&mut self.node) }); | ^^^^^^^^^^^^^^ | = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:380:10 | 380 | ) -> Result, marker::Edge>, Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:742:10 | 742 | ) -> ForceResult< | __________^ 743 | | NodeRef, 744 | | NodeRef, 745 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:879:29 | 879 | pub fn left_kv(self) -> Result, marker::KV>, Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:887:30 | 887 | pub fn right_kv(self) -> Result, marker::KV>, Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:1160:31 | 1160 | pub fn split(mut self) -> (NodeRef, K, V, marker::Leaf>, K, V, Root) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:1175:10 | 1175 | ) -> ((K, V), Handle, K, V, marker::Leaf>, marker::Edge>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:1205:31 | 1205 | pub fn split(mut self) -> (NodeRef, K, V, marker::Internal>, K, V, Root) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/node.rs:1518:10 | 1518 | ) -> ForceResult< | __________^ 1519 | | Handle, HandleType>, 1520 | | Handle, HandleType>, 1521 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/btree/remove.rs:13:10 | 13 | ) -> ((K, V), Handle, K, V, marker::Leaf>, marker::Edge>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: local variable doesn't need to be boxed here --> library/alloc/src/collections/linked_list.rs:124:21 | 124 | fn into_element(self: Box) -> T { | ^^^^ | = note: `#[warn(clippy::boxed_local)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: very complex type used. Consider factoring parts into `type` definitions --> library/alloc/src/collections/linked_list.rs:277:38 | 277 | fn detach_all_nodes(mut self) -> Option<(NonNull>, NonNull>, usize)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: manual implementation of an assign operation --> library/alloc/src/collections/linked_list.rs:320:13 | 320 | self.len = self.len - at; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len -= at` | = note: `#[warn(clippy::assign_op_pattern)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual saturating arithmetic --> library/alloc/src/collections/linked_list.rs:543:25 | 543 | Cursor { index: self.len.checked_sub(1).unwrap_or(0), current: self.tail, list: self } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using `saturating_sub`: `self.len.saturating_sub(1)` | = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic warning: manual saturating arithmetic --> library/alloc/src/collections/linked_list.rs:552:28 | 552 | CursorMut { index: self.len.checked_sub(1).unwrap_or(0), current: self.tail, list: self } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using `saturating_sub`: `self.len.saturating_sub(1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic warning: manual saturating arithmetic --> library/alloc/src/collections/linked_list.rs:1263:30 | 1263 | self.index = self.list.len().checked_sub(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using `saturating_sub`: `self.list.len().saturating_sub(1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic warning: manual saturating arithmetic --> library/alloc/src/collections/linked_list.rs:1360:30 | 1360 | self.index = self.list.len().checked_sub(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using `saturating_sub`: `self.list.len().saturating_sub(1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. --> library/alloc/src/collections/linked_list.rs:1747:31 | 1747 | fn spec_extend(&mut self, ref mut other: LinkedList) { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/collections/linked_list.rs:1770:5 | 1770 | / fn ne(&self, other: &Self) -> bool { 1771 | | self.len() != other.len() || self.iter().ne(other) 1772 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: `if` chain can be rewritten with `match` --> library/alloc/src/collections/vec_deque.rs:3008:9 | 3008 | / if sa.len() == oa.len() { 3009 | | sa == oa && sb == ob 3010 | | } else if sa.len() < oa.len() { 3011 | | // Always divisible in three sections, for example: ... | 3034 | | sa_front == oa && sa_mid == ob_mid && sb == ob_back 3035 | | } | |_________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: needless `fn main` in doctest --> library/alloc/src/fmt.rs:361:4 | 361 | //! use std::fmt; | ^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_doctest_main)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/alloc/src/rc.rs:92:4 | 92 | //! use std::rc::Rc; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/alloc/src/rc.rs:160:4 | 160 | //! use std::rc::Rc; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: unsafe function's docs miss `# Safety` section --> library/alloc/src/rc.rs:736:5 | 736 | / pub unsafe fn from_raw(ptr: *const T) -> Self { 737 | | let offset = unsafe { data_offset(ptr) }; 738 | | 739 | | // Reverse the offset to find the original RcBox. ... | 743 | | unsafe { Self::from_ptr(rc_ptr) } 744 | | } | |_____^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/rc.rs:1364:5 | 1364 | / fn ne(&self, other: &Rc) -> bool { 1365 | | RcEqIdent::ne(self, other) 1366 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: called `skip_while(p).next()` on an `Iterator` --> library/alloc/src/str.rs:392:19 | 392 | match iter.skip_while(|&c| Case_Ignorable(c)).next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::skip_while_next)]` on by default = help: this is more succinctly expressed by calling `.find(!p)` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#skip_while_next warning: unsafe function's docs miss `# Safety` section --> library/alloc/src/str.rs:574:1 | 574 | / pub unsafe fn from_boxed_utf8_unchecked(v: Box<[u8]>) -> Box { 575 | | unsafe { Box::from_raw(Box::into_raw(v) as *mut str) } 576 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> library/alloc/src/string.rs:781:19 | 781 | pub fn as_str(&self) -> &str { | ^^^^^ help: change this to: `&str` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> library/alloc/src/string.rs:837:21 | 837 | pub fn capacity(&self) -> usize { | ^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> library/alloc/src/string.rs:1101:21 | 1101 | pub fn as_bytes(&self) -> &[u8] { | ^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> library/alloc/src/string.rs:1393:16 | 1393 | pub fn len(&self) -> usize { | ^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> library/alloc/src/string.rs:1412:21 | 1412 | pub fn is_empty(&self) -> bool { | ^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1894:5 | 1894 | / fn ne(&self, other: &String) -> bool { 1895 | | PartialEq::ne(&self[..], &other[..]) 1896 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1909:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1909 | /| fn ne(&self, other: &$rhs) -> bool { 1910 | || PartialEq::ne(&self[..], &other[..]) 1911 | || } | ||_____________^ ... | 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` 1928 | 1929 | impl_eq! { String, str } | ------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1922:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1922 | /| fn ne(&self, other: &$lhs) -> bool { 1923 | || PartialEq::ne(&self[..], &other[..]) 1924 | || } | ||_____________^ 1925 | | } 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` 1928 | 1929 | impl_eq! { String, str } | ------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1909:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1909 | /| fn ne(&self, other: &$rhs) -> bool { 1910 | || PartialEq::ne(&self[..], &other[..]) 1911 | || } | ||_____________^ ... | 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1930 | impl_eq! { String, &'a str } | ---------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1922:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1922 | /| fn ne(&self, other: &$lhs) -> bool { 1923 | || PartialEq::ne(&self[..], &other[..]) 1924 | || } | ||_____________^ 1925 | | } 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1930 | impl_eq! { String, &'a str } | ---------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1909:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1909 | /| fn ne(&self, other: &$rhs) -> bool { 1910 | || PartialEq::ne(&self[..], &other[..]) 1911 | || } | ||_____________^ ... | 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1931 | impl_eq! { Cow<'a, str>, str } | ------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1922:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1922 | /| fn ne(&self, other: &$lhs) -> bool { 1923 | || PartialEq::ne(&self[..], &other[..]) 1924 | || } | ||_____________^ 1925 | | } 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1931 | impl_eq! { Cow<'a, str>, str } | ------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1909:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1909 | /| fn ne(&self, other: &$rhs) -> bool { 1910 | || PartialEq::ne(&self[..], &other[..]) 1911 | || } | ||_____________^ ... | 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1932 | impl_eq! { Cow<'a, str>, &'b str } | ---------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1922:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1922 | /| fn ne(&self, other: &$lhs) -> bool { 1923 | || PartialEq::ne(&self[..], &other[..]) 1924 | || } | ||_____________^ 1925 | | } 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1932 | impl_eq! { Cow<'a, str>, &'b str } | ---------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1909:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1909 | /| fn ne(&self, other: &$rhs) -> bool { 1910 | || PartialEq::ne(&self[..], &other[..]) 1911 | || } | ||_____________^ ... | 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1933 | impl_eq! { Cow<'a, str>, String } | --------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/string.rs:1922:13 | 1899 | / macro_rules! impl_eq { 1900 | | ($lhs:ty, $rhs: ty) => { 1901 | | #[stable(feature = "rust1", since = "1.0.0")] 1902 | | #[allow(unused_lifetimes)] ... | 1922 | /| fn ne(&self, other: &$lhs) -> bool { 1923 | || PartialEq::ne(&self[..], &other[..]) 1924 | || } | ||_____________^ 1925 | | } 1926 | | }; 1927 | | } | |_- in this expansion of `impl_eq!` ... 1933 | impl_eq! { Cow<'a, str>, String } | --------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: unsafe function's docs miss `# Safety` section --> library/alloc/src/sync.rs:751:5 | 751 | / pub unsafe fn from_raw(ptr: *const T) -> Self { 752 | | unsafe { 753 | | let offset = data_offset(ptr); 754 | | ... | 760 | | } 761 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/sync.rs:2012:5 | 2012 | / fn ne(&self, other: &Arc) -> bool { 2013 | | ArcEqIdent::ne(self, other) 2014 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> library/alloc/src/vec.rs:482:21 | 482 | pub fn capacity(&self) -> usize { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> library/alloc/src/vec.rs:772:21 | 772 | pub fn as_slice(&self) -> &[T] { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> library/alloc/src/vec.rs:820:19 | 820 | pub fn as_ptr(&self) -> *const T { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> library/alloc/src/vec.rs:1365:16 | 1365 | pub fn len(&self) -> usize { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> library/alloc/src/vec.rs:1381:21 | 1381 | pub fn is_empty(&self) -> bool { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: equality checks against false can be replaced by a negation --> library/alloc/src/vec.rs:1839:25 | 1839 | impl_is_zero!(bool, |x| x == false); | ^^^^^^^^^^ help: try simplifying it as shown: `!x` | = note: `#[warn(clippy::bool_comparison)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison warning: returning the result of a `let` binding from a block --> library/alloc/src/vec.rs:2275:9 | 2270 | / let vec = unsafe { 2271 | | let len = dst.offset_from(dst_buf) as usize; 2272 | | Vec::from_raw_parts(dst_buf, len, cap) 2273 | | }; | |__________- unnecessary `let` binding 2274 | 2275 | vec | ^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 2270 | 2271 | 2272 | unsafe { 2273 | let len = dst.offset_from(dst_buf) as usize; 2274 | Vec::from_raw_parts(dst_buf, len, cap) 2275 | } | warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` 2545 | 2546 | __impl_slice_eq1! { [] Vec, Vec, #[stable(feature = "rust1", since = "1.0.0")] } | -------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2547 | __impl_slice_eq1! { [] Vec, &[B], #[stable(feature = "rust1", since = "1.0.0")] } | ------------------------------------------------------------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2548 | __impl_slice_eq1! { [] Vec, &mut [B], #[stable(feature = "rust1", since = "1.0.0")] } | ---------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2549 | __impl_slice_eq1! { [] &[A], Vec, #[stable(feature = "partialeq_vec_for_ref_slice", since = "1.46.0")] } | ----------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2550 | __impl_slice_eq1! { [] &mut [A], Vec, #[stable(feature = "partialeq_vec_for_ref_slice", since = "1.46.0")] } | --------------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2551 | __impl_slice_eq1! { [] Vec, [B], #[stable(feature = "partialeq_vec_for_slice", since = "1.48.0")] } | ------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2552 | __impl_slice_eq1! { [] [A], Vec, #[stable(feature = "partialeq_vec_for_slice", since = "1.48.0")] } | ------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2553 | __impl_slice_eq1! { [] Cow<'_, [A]>, Vec where A: Clone, #[stable(feature = "rust1", since = "1.0.0")] } | ----------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2554 | __impl_slice_eq1! { [] Cow<'_, [A]>, &[B] where A: Clone, #[stable(feature = "rust1", since = "1.0.0")] } | --------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2555 | __impl_slice_eq1! { [] Cow<'_, [A]>, &mut [B] where A: Clone, #[stable(feature = "rust1", since = "1.0.0")] } | ------------------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2556 | __impl_slice_eq1! { [const N: usize] Vec, [B; N], #[stable(feature = "rust1", since = "1.0.0")] } | ---------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: re-implementing `PartialEq::ne` is unnecessary --> library/alloc/src/vec.rs:2541:13 | 2530 | / macro_rules! __impl_slice_eq1 { 2531 | | ([$($vars:tt)*] $lhs:ty, $rhs:ty $(where $ty:ty: $bound:ident)?, #[$stability:meta]) => { 2532 | | #[$stability] 2533 | | impl PartialEq<$rhs> for $lhs ... | 2541 | | fn ne(&self, other: &$rhs) -> bool { self[..] != other[..] } | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2542 | | } 2543 | | } 2544 | | } | |_- in this expansion of `__impl_slice_eq1!` ... 2557 | __impl_slice_eq1! { [const N: usize] Vec, &[B; N], #[stable(feature = "rust1", since = "1.0.0")] } | ----------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl warning: 77 warnings emitted warning: digits grouped inconsistently by underscores --> library/panic_unwind/src/gcc.rs:90:5 | 90 | 0x4d4f5a_00_52555354 | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0x4d4f_5a00_5255_5354` | = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping warning: unsafe function's docs miss `# Safety` section --> library/panic_unwind/src/lib.rs:100:1 | 100 | / pub unsafe extern "C" fn __rust_panic_cleanup(payload: *mut u8) -> *mut (dyn Any + Send + 'static) { 101 | | Box::into_raw(imp::cleanup(payload)) 102 | | } | |_^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/panic_unwind/src/lib.rs:108:1 | 108 | / pub unsafe extern "C" fn __rust_start_panic(payload: usize) -> u32 { 109 | | let payload = payload as *mut &mut dyn BoxMeUp; 110 | | let payload = (*payload).take_box(); 111 | | 112 | | imp::panic(Box::from_raw(payload)) 113 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: 3 warnings emitted warning: using `write!()` with a format string that ends in a single newline --> library/std/src/../../backtrace/src/print.rs:283:9 | 283 | write!(self.fmt.fmt, "\n")?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_with_newline)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 283 | writeln!(self.fmt.fmt, )?; | ^^^^^^^ -- warning: this `else { if .. }` block can be collapsed --> library/std/src/io/buffered/bufreader.rs:243:16 | 243 | } else { | ________________^ 244 | | if let Some(new_pos) = pos.checked_add(offset as u64) { 245 | | if new_pos <= self.cap as u64 { 246 | | self.pos = new_pos as usize; ... | 249 | | } 250 | | } | |_________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 243 | } else if let Some(new_pos) = pos.checked_add(offset as u64) { 244 | if new_pos <= self.cap as u64 { 245 | self.pos = new_pos as usize; 246 | return Ok(()); 247 | } 248 | } | warning: 8 bindings with single-character names in scope --> library/std/src/net/ip.rs:1048:22 | 1048 | pub const fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { | ^ ^ ^ ^ ^ ^ ^ ^ | = note: `#[warn(clippy::many_single_char_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 8 bindings with single-character names in scope --> library/std/src/net/ip.rs:1048:22 | 1048 | pub const fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { | ^ ^ ^ ^ ^ ^ ^ ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 8 bindings with single-character names in scope --> library/std/src/net/ip.rs:1109:14 | 1109 | let [a, b, c, d, e, f, g, h] = unsafe { transmute::<_, [u16; 8]>(self.inner.s6_addr) }; | ^ ^ ^ ^ ^ ^ ^ ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 8 bindings with single-character names in scope --> library/std/src/net/ip.rs:1837:14 | 1837 | let [a, b, c, d, e, f, g, h] = segments; | ^ ^ ^ ^ ^ ^ ^ ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: this `if` statement can be collapsed --> library/std/src/sys_common/backtrace.rs:96:9 | 96 | / if !hit { 97 | | if start { 98 | | res = bt_fmt.frame().print_raw(frame.ip(), None, None, None); 99 | | } 100 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 96 | if !hit && start { 97 | res = bt_fmt.frame().print_raw(frame.ip(), None, None, None); 98 | } | warning: this `if` has identical blocks --> library/std/src/f64.rs:935:30 | 935 | } else if self > 0.0 { | ______________________________^ 936 | | self // log(Inf) = Inf 937 | | } else { | |_________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> library/std/src/f64.rs:933:33 | 933 | } else if self.is_nan() { | _________________________________^ 934 | | self // log(NaN) = NaN 935 | | } else if self > 0.0 { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this `if` has identical blocks --> library/std/src/f64.rs:935:30 | 935 | } else if self > 0.0 { | ______________________________^ 936 | | self // log(Inf) = Inf 937 | | } else { | |_________^ | note: same as this --> library/std/src/f64.rs:933:33 | 933 | } else if self.is_nan() { | _________________________________^ 934 | | self // log(NaN) = NaN 935 | | } else if self > 0.0 { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: unsafe function's docs miss `# Safety` section --> library/std/src/thread/local.rs:445:9 | 445 | / pub unsafe fn get T>(&self, init: F) -> Option<&'static T> { 446 | | // SAFETY: See the definitions of `LazyKeyInner::get` and 447 | | // `try_initialize` for more informations. 448 | | // ... | 458 | | } 459 | | } | |_________^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/std/src/thread/local.rs:560:9 | 560 | / pub unsafe fn get(&'static self, init: fn() -> T) -> Option<&'static T> { 561 | | // SAFETY: See the documentation for this method. 562 | | let ptr = unsafe { self.os.get() as *mut Value }; 563 | | if ptr as usize > 1 { ... | 572 | | unsafe { self.try_initialize(init) } 573 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: you should consider adding a `Default` implementation for `thread::Builder` --> library/std/src/thread/mod.rs:283:5 | 283 | / pub fn new() -> Builder { 284 | | Builder { name: None, stack_size: None } 285 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 263 | impl Default for thread::Builder { 264 | fn default() -> Self { 265 | Self::new() 266 | } 267 | } | warning: you seem to be trying to use `match` to destructure a single infallible pattern. Consider using `let` --> library/std/src/backtrace.rs:416:13 | 416 | / let frame = match &frame.frame { 417 | | RawFrame::Actual(frame) => frame, 418 | | #[cfg(test)] 419 | | RawFrame::Fake => unimplemented!(), 420 | | }; | |______________^ help: try this: `let RawFrame::Actual(frame) = &frame.frame;` | = note: `#[warn(clippy::infallible_destructuring_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/std/src/collections/hash/map.rs:1447:32 | 1447 | pub fn from_key(self, k: &Q) -> RawEntryMut<'a, K, V, S> | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/std/src/collections/hash/map.rs:1458:47 | 1458 | pub fn from_key_hashed_nocheck(self, hash: u64, k: &Q) -> RawEntryMut<'a, K, V, S> | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/std/src/collections/hash/map.rs:1469:25 | 1469 | pub fn from_hash(self, hash: u64, is_match: F) -> RawEntryMut<'a, K, V, S> | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/std/src/collections/hash/map.rs:1484:32 | 1484 | pub fn from_key(self, k: &Q) -> Option<(&'a K, &'a V)> | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/std/src/collections/hash/map.rs:1495:47 | 1495 | pub fn from_key_hashed_nocheck(self, hash: u64, k: &Q) -> Option<(&'a K, &'a V)> | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> library/std/src/collections/hash/map.rs:1506:25 | 1506 | pub fn from_hash(self, hash: u64, is_match: F) -> Option<(&'a K, &'a V)> | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: needless `fn main` in doctest --> library/std/src/env.rs:618:4 | 618 | /// fn main() { | ^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_doctest_main)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: you are deriving `Hash` but have implemented `PartialEq` explicitly --> library/std/src/ffi/c_str.rs:189:10 | 189 | #[derive(Hash)] | ^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/hash/mod.rs:200:5 | 200 | / pub macro Hash($item:item) { 201 | | /* compiler built-in */ 202 | | } | |_____- in this expansion of `#[derive(Hash)]` | = note: `#[warn(clippy::derive_hash_xor_eq)]` on by default note: `PartialEq` implemented here --> library/std/src/ffi/c_str.rs:1443:1 | 1443 | / impl PartialEq for CStr { 1444 | | fn eq(&self, other: &CStr) -> bool { 1445 | | self.to_bytes().eq(other.to_bytes()) 1446 | | } 1447 | | } | |_^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: unsafe function's docs miss `# Safety` section --> library/std/src/ffi/c_str.rs:429:5 | 429 | / pub unsafe fn from_vec_unchecked(mut v: Vec) -> CString { 430 | | v.reserve_exact(1); 431 | | v.push(0); 432 | | CString { inner: v.into_boxed_slice() } 433 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/std/src/ffi/c_str.rs:1161:5 | 1161 | / pub unsafe fn from_ptr<'a>(ptr: *const c_char) -> &'a CStr { 1162 | | // SAFETY: The caller has provided a pointer that points to a valid C 1163 | | // string with a NUL terminator of size less than `isize::MAX`, whose 1164 | | // content remain valid and doesn't change for the lifetime of the ... | 1176 | | } 1177 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/std/src/ffi/c_str.rs:1244:5 | 1244 | / pub const unsafe fn from_bytes_with_nul_unchecked(bytes: &[u8]) -> &CStr { 1245 | | // SAFETY: Casting to CStr is safe because its internal representation 1246 | | // is a [u8] too (safe only inside std). 1247 | | // Dereferencing the obtained pointer is safe because it comes from a ... | 1250 | | unsafe { &*(bytes as *const [u8] as *const CStr) } 1251 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: needlessly taken reference of both operands --> library/std/src/ffi/os_str.rs:412:9 | 412 | &**self == &**other | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::op_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 412 | **self == **other | ^^^^^^ ^^^^^^^ warning: needlessly taken reference of both operands --> library/std/src/ffi/os_str.rs:455:9 | 455 | &**self < &**other | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 455 | **self < **other | ^^^^^^ ^^^^^^^ warning: needlessly taken reference of both operands --> library/std/src/ffi/os_str.rs:459:9 | 459 | &**self <= &**other | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 459 | **self <= **other | ^^^^^^ ^^^^^^^ warning: needlessly taken reference of both operands --> library/std/src/ffi/os_str.rs:463:9 | 463 | &**self > &**other | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 463 | **self > **other | ^^^^^^ ^^^^^^^ warning: needlessly taken reference of both operands --> library/std/src/ffi/os_str.rs:467:9 | 467 | &**self >= &**other | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 467 | **self >= **other | ^^^^^^ ^^^^^^^ warning: you should consider adding a `Default` implementation for `fs::OpenOptions` --> library/std/src/fs.rs:716:5 | 716 | / pub fn new() -> Self { 717 | | OpenOptions(fs_imp::OpenOptions::new()) 718 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 702 | impl Default for fs::OpenOptions { 703 | fn default() -> Self { 704 | Self::new() 705 | } 706 | } | warning: item `fs::Metadata` has a public `len` method but no corresponding `is_empty` method --> library/std/src/fs.rs:939:1 | 939 | / impl Metadata { 940 | | /// Returns the file type for this metadata. 941 | | /// 942 | | /// # Examples ... | 1143 | | } 1144 | | } | |_^ | = note: `#[warn(clippy::len_without_is_empty)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: you should consider adding a `Default` implementation for `fs::DirBuilder` --> library/std/src/fs.rs:2117:5 | 2117 | / pub fn new() -> DirBuilder { 2118 | | DirBuilder { inner: fs_imp::DirBuilder::new(), recursive: false } 2119 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 2105 | impl Default for fs::DirBuilder { 2106 | fn default() -> Self { 2107 | Self::new() 2108 | } 2109 | } | warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> library/std/src/io/stdio.rs:924:13 | 924 | let s = LOCAL_STDERR.with(move |slot| mem::replace(&mut *slot.borrow_mut(), sink)).and_then( | _____________^ 925 | | |mut s| { 926 | | let _ = s.flush(); 927 | | Some(s) 928 | | }, 929 | | ); | |_____^ | = note: `#[warn(clippy::bind_instead_of_map)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map help: try this | 924 | let s = LOCAL_STDERR.with(move |slot| mem::replace(&mut *slot.borrow_mut(), sink)).map( 925 | |mut s| { 926 | let _ = s.flush(); 927 | s | warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> library/std/src/io/stdio.rs:955:13 | 955 | let s = LOCAL_STDOUT.with(move |slot| mem::replace(&mut *slot.borrow_mut(), sink)).and_then( | _____________^ 956 | | |mut s| { 957 | | let _ = s.flush(); 958 | | Some(s) 959 | | }, 960 | | ); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map help: try this | 955 | let s = LOCAL_STDOUT.with(move |slot| mem::replace(&mut *slot.borrow_mut(), sink)).map( 956 | |mut s| { 957 | let _ = s.flush(); 958 | s | warning: very complex type used. Consider factoring parts into `type` definitions --> library/std/src/io/stdio.rs:965:29 | 965 | pub(crate) fn clone_io() -> (Option>, Option>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: struct update has no effect, all the fields in the struct have already been specified --> library/std/src/net/addr.rs:367:19 | 367 | ..unsafe { mem::zeroed() } | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_update)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update warning: this function has too many arguments (8/7) --> library/std/src/net/ip.rs:1048:5 | 1048 | pub const fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: the operation is ineffective. Consider reducing it to `i` --> library/std/src/net/parser.rs:160:32 | 160 | groups[i + 0] = u16::from_be_bytes([one, two]); | ^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: needless `fn main` in doctest --> library/std/src/process.rs:1748:4 | 1748 | /// use std::process; | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/std/src/process.rs:1763:4 | 1763 | /// use std::process; | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: this loop could be written as a `while let` loop --> library/std/src/sync/mpsc/shared.rs:393:13 | 393 | / loop { 394 | | match self.queue.pop() { 395 | | mpsc::Data(..) => { 396 | | steals += 1; ... | 399 | | } 400 | | } | |_____________^ help: try: `while let mpsc::Data(..) = self.queue.pop() { .. }` | = note: `#[warn(clippy::while_let_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop warning: mutable borrow from immutable input(s) --> library/std/src/sync/mpsc/mod.rs:625:35 | 625 | unsafe fn inner_mut(&self) -> &mut Flavor { | ^^^^^^^^^^^^^^ | = note: `#[warn(clippy::mut_from_ref)]` on by default note: immutable borrow here --> library/std/src/sync/mpsc/mod.rs:625:25 | 625 | unsafe fn inner_mut(&self) -> &mut Flavor { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: a `const` item should never be interior mutable --> library/std/src/sync/once.rs:150:1 | 150 | pub const ONCE_INIT: Once = Once::new(); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: needless `fn main` in doctest --> library/std/src/time.rs:53:4 | 53 | /// use std::time::{Duration, Instant}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: needless `fn main` in doctest --> library/std/src/time.rs:138:4 | 138 | /// use std::time::{Duration, SystemTime}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: use of `unwrap_or` followed by a function call --> library/std/src/time.rs:325:46 | 325 | self.checked_duration_since(earlier).unwrap_or(Duration::new(0, 0)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(0, 0))` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: the method `assume_init_read` doesn't need a mutable reference --> library/std/src/lazy.rs:350:27 | 350 | unsafe { Some((&mut *self.value.get()).assume_init_read()) } | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed warning: transmute from a reference to a reference --> library/std/src/sys_common/os_str_bytes.rs:112:18 | 112 | unsafe { mem::transmute(&*self.inner) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&*self.inner as *const [u8] as *const sys_common::os_str_bytes::Slice)` | = note: `#[warn(clippy::transmute_ptr_to_ptr)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: transmute from a reference to a reference --> library/std/src/sys_common/os_str_bytes.rs:120:18 | 120 | unsafe { mem::transmute(&mut *self.inner) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut *self.inner as *mut [u8] as *mut sys_common::os_str_bytes::Slice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/os_str_bytes.rs:143:21 | 143 | pub fn into_arc(&self) -> Arc { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/os_str_bytes.rs:148:20 | 148 | pub fn into_rc(&self) -> Rc { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: transmute from a reference to a reference --> library/std/src/sys_common/os_str_bytes.rs:156:18 | 156 | unsafe { mem::transmute(s) } | ^^^^^^^^^^^^^^^^^ help: try: `&*(s as *const [u8] as *const sys_common::os_str_bytes::Slice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/os_str_bytes.rs:181:21 | 181 | pub fn into_box(&self) -> Box { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/os_str_bytes.rs:192:21 | 192 | pub fn into_arc(&self) -> Arc { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/os_str_bytes.rs:198:20 | 198 | pub fn into_rc(&self) -> Rc { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: transmute from a reference to a reference --> library/std/src/sys_common/os_str_bytes.rs:280:18 | 280 | unsafe { mem::transmute(slice) } | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u8] as *const ffi::os_str::OsStr)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: useless conversion to the same type: `ffi::os_str::OsString` --> library/std/src/sys_common/process.rs:29:31 | 29 | result.insert(k.into(), v); | ^^^^^^^^ help: consider removing `.into()`: `k` | = note: `#[warn(clippy::useless_conversion)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: you don't need to add `&` to all patterns --> library/std/src/sys_common/process.rs:33:13 | 33 | / if let &Some(ref v) = maybe_v { 34 | | result.insert(k.clone(), v.clone()); 35 | | } else { 36 | | result.remove(k); 37 | | } | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 33 | if let Some(ref v) = *maybe_v { | ^^^^^^^^^^^ ^^^^^^^^ warning: useless conversion to the same type: `ffi::os_str::OsString` --> library/std/src/sys_common/process.rs:69:26 | 69 | self.vars.insert(key.to_owned().into(), Some(value.to_owned())); | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.to_owned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: useless conversion to the same type: `ffi::os_str::OsString` --> library/std/src/sys_common/process.rs:77:30 | 77 | self.vars.insert(key.to_owned().into(), None); | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `key.to_owned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: a `const` item should never be interior mutable --> library/std/src/sys_common/thread_local_key.rs:117:1 | 117 | pub const INIT: StaticKey = StaticKey::new(None); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const warning: this `if` has identical blocks --> library/std/src/sys_common/thread_parker/futex.rs:74:16 | 74 | } else { | ________________^ 75 | | // Timeout or spurious wake up. 76 | | // We return either way, because we can't easily tell if it was the 77 | | // timeout or not. 78 | | } | |_________^ | note: same as this --> library/std/src/sys_common/thread_parker/futex.rs:72:56 | 72 | if self.state.swap(EMPTY, Acquire) == NOTIFIED { | ________________________________________________________^ 73 | | // Woke up because of unpark(). 74 | | } else { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: transmute from a reference to a reference --> library/std/src/sys_common/wtf8.rs:483:9 | 483 | mem::transmute(value) | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(value as *const [u8] as *const sys_common::wtf8::Wtf8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: transmute from a reference to a reference --> library/std/src/sys_common/wtf8.rs:492:9 | 492 | mem::transmute(value) | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(value as *mut [u8] as *mut sys_common::wtf8::Wtf8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/wtf8.rs:635:21 | 635 | pub fn into_box(&self) -> Box { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/wtf8.rs:647:21 | 647 | pub fn into_arc(&self) -> Arc { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> library/std/src/sys_common/wtf8.rs:653:20 | 653 | pub fn into_rc(&self) -> Rc { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you are implementing `Hash` explicitly but have derived `PartialEq` --> library/std/src/sys_common/wtf8.rs:863:1 | 863 | / impl Hash for CodePoint { 864 | | #[inline] 865 | | fn hash(&self, state: &mut H) { 866 | | self.value.hash(state) 867 | | } 868 | | } | |_^ | note: `PartialEq` implemented here --> library/std/src/sys_common/wtf8.rs:43:14 | 43 | #[derive(Eq, PartialEq, Ord, PartialOrd, Clone, Copy)] | ^^^^^^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/cmp.rs:218:1 | 218 | / pub macro PartialEq($item:item) { 219 | | /* compiler built-in */ 220 | | } | |_- in this expansion of `#[derive(PartialEq)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: you are implementing `Hash` explicitly but have derived `PartialEq` --> library/std/src/sys_common/wtf8.rs:870:1 | 870 | / impl Hash for Wtf8Buf { 871 | | #[inline] 872 | | fn hash(&self, state: &mut H) { 873 | | state.write(&self.bytes); 874 | | 0xfeu8.hash(state) 875 | | } 876 | | } | |_^ | note: `PartialEq` implemented here --> library/std/src/sys_common/wtf8.rs:116:14 | 116 | #[derive(Eq, PartialEq, Ord, PartialOrd, Clone)] | ^^^^^^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/cmp.rs:218:1 | 218 | / pub macro PartialEq($item:item) { 219 | | /* compiler built-in */ 220 | | } | |_- in this expansion of `#[derive(PartialEq)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: you are implementing `Hash` explicitly but have derived `PartialEq` --> library/std/src/sys_common/wtf8.rs:878:1 | 878 | / impl Hash for Wtf8 { 879 | | #[inline] 880 | | fn hash(&self, state: &mut H) { 881 | | state.write(&self.bytes); 882 | | 0xfeu8.hash(state) 883 | | } 884 | | } | |_^ | note: `PartialEq` implemented here --> library/std/src/sys_common/wtf8.rs:408:19 | 408 | #[derive(Eq, Ord, PartialEq, PartialOrd)] | ^^^^^^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/cmp.rs:218:1 | 218 | / pub macro PartialEq($item:item) { 219 | | /* compiler built-in */ 220 | | } | |_- in this expansion of `#[derive(PartialEq)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: transmute from a pointer type (`*mut libc::sockaddr`) to a reference type (`&libc::sockaddr_storage`) --> library/std/src/sys_common/net.rs:148:40 | 148 | match sockaddr_to_addr(mem::transmute(cur.ai_addr), cur.ai_addrlen as usize) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(cur.ai_addr as *const libc::sockaddr_storage)` | = note: `#[warn(clippy::transmute_ptr_to_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref warning: unsafe function's docs miss `# Safety` section --> library/std/src/sys/unix/ext/io.rs:77:5 | 77 | unsafe fn from_raw_fd(fd: RawFd) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: if let .. else expression looks like `matches!` macro --> library/std/src/sys/unix/ext/net.rs:205:9 | 205 | if let AddressKind::Unnamed = self.address() { true } else { false } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches!(self.address(), AddressKind::Unnamed)` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: transmute from a reference to a reference --> library/std/src/sys/unix/ext/net.rs:245:29 | 245 | let path = unsafe { mem::transmute::<&[libc::c_char], &[u8]>(&self.addr.sun_path) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.addr.sun_path as *const [i8; 108] as *const [u8])` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: `if` chain can be rewritten with `match` --> library/std/src/sys/unix/ext/net.rs:1386:13 | 1386 | / if count > 0 { 1387 | | 1 1388 | | } else if count == 0 { 1389 | | 0 1390 | | } else { 1391 | | -1 1392 | | } | |_____________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: unsafe function's docs miss `# Safety` section --> library/std/src/sys/unix/ext/process.rs:64:5 | 64 | / unsafe fn pre_exec(&mut self, f: F) -> &mut process::Command 65 | | where 66 | | F: FnMut() -> io::Result<()> + Send + Sync + 'static; | |_____________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> library/std/src/sys/unix/fs.rs:1234:17 | 1234 | / match copy_err.raw_os_error() { 1235 | | Some(libc::ENOSYS | libc::EPERM | libc::EOPNOTSUPP) => { 1236 | | HAS_COPY_FILE_RANGE.store(false, Ordering::Relaxed); 1237 | | } 1238 | | _ => {} 1239 | | } | |_________________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1234 | if let Some(libc::ENOSYS | libc::EPERM | libc::EOPNOTSUPP) = copy_err.raw_os_error() { 1235 | HAS_COPY_FILE_RANGE.store(false, Ordering::Relaxed); 1236 | } | warning: very complex type used. Consider factoring parts into `type` definitions --> library/std/src/sys/unix/os.rs:172:11 | 172 | iter: iter::Map bool>, fn(&'a [u8]) -> PathBuf>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this `if` has identical blocks --> library/std/src/sys/unix/thread.rs:443:75 | 443 | } else if cfg!(all(target_os = "linux", target_env = "musl")) { | ___________________________________________________________________________^ 444 | | Some(stackaddr - guardsize..stackaddr) 445 | | } else if cfg!(all(target_os = "linux", target_env = "gnu")) { | |_____________^ | note: same as this --> library/std/src/sys/unix/thread.rs:441:50 | 441 | } else if cfg!(target_os = "netbsd") { | __________________________________________________^ 442 | | Some(stackaddr - guardsize..stackaddr) 443 | | } else if cfg!(all(target_os = "linux", target_env = "musl")) { | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: unsafe function's docs miss `# Safety` section --> library/std/src/alloc.rs:351:5 | 351 | / pub unsafe extern "C" fn __rdl_alloc(size: usize, align: usize) -> *mut u8 { 352 | | // SAFETY: see the guarantees expected by `Layout::from_size_align` and 353 | | // `GlobalAlloc::alloc`. 354 | | unsafe { ... | 357 | | } 358 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/std/src/alloc.rs:361:5 | 361 | / pub unsafe extern "C" fn __rdl_dealloc(ptr: *mut u8, size: usize, align: usize) { 362 | | // SAFETY: see the guarantees expected by `Layout::from_size_align` and 363 | | // `GlobalAlloc::dealloc`. 364 | | unsafe { System.dealloc(ptr, Layout::from_size_align_unchecked(size, align)) } 365 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/std/src/alloc.rs:368:5 | 368 | / pub unsafe extern "C" fn __rdl_realloc( 369 | | ptr: *mut u8, 370 | | old_size: usize, 371 | | align: usize, ... | 379 | | } 380 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> library/std/src/alloc.rs:383:5 | 383 | / pub unsafe extern "C" fn __rdl_alloc_zeroed(size: usize, align: usize) -> *mut u8 { 384 | | // SAFETY: see the guarantees expected by `Layout::from_size_align` and 385 | | // `GlobalAlloc::alloc_zeroed`. 386 | | unsafe { ... | 389 | | } 390 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: calls to `std::mem::drop` with a value that implements `Copy`. Dropping a copy leaves the original intact. --> library/std/src/panicking.rs:461:17 | 461 | drop(s.write_fmt(*inner)); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::drop_copy)]` on by default note: argument has type core::result::Result<(), core::fmt::Error> --> library/std/src/panicking.rs:461:22 | 461 | drop(s.write_fmt(*inner)); | ^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy warning: sub-expression diverges --> library/std/src/panicking.rs:521:12 | 521 | return crate::sys_common::backtrace::__rust_end_short_backtrace(move || { | ____________^ 522 | | rust_panic_with_hook(&mut PanicPayload::new(msg), None, loc) 523 | | }); | |______^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: mutable borrow from immutable input(s) --> library/std/src/../../backtrace/src/symbolize/gimli/stash.rs:22:44 | 22 | pub fn allocate(&self, size: usize) -> &mut [u8] { | ^^^^^^^^^ | note: immutable borrow here --> library/std/src/../../backtrace/src/symbolize/gimli/stash.rs:22:21 | 22 | pub fn allocate(&self, size: usize) -> &mut [u8] { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: 86 warnings emitted warning: you should consider adding a `Default` implementation for `terminfo::parm::Variables` --> library/term/src/terminfo/parm.rs:53:5 | 53 | / pub fn new() -> Variables { 54 | | Variables { 55 | | sta_va: [ 56 | | Number(0), ... | 111 | | } 112 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 51 | impl Default for terminfo::parm::Variables { 52 | fn default() -> Self { 53 | Self::new() 54 | } 55 | } | warning: 1 warning emitted warning: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> library/proc_macro/src/lib.rs:153:22 | 153 | f.write_str(&self.to_string()) | ^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::to_string_in_display)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_display warning: method `eq` can be confused for the standard trait method `std::cmp::PartialEq::eq` --> library/proc_macro/src/lib.rs:380:5 | 380 | / pub fn eq(&self, other: &Span) -> bool { 381 | | self.0 == other.0 382 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::cmp::PartialEq` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> library/proc_macro/src/lib.rs:609:22 | 609 | f.write_str(&self.to_string()) | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_display warning: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> library/proc_macro/src/lib.rs:734:22 | 734 | f.write_str(&self.to_string()) | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_display warning: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> library/proc_macro/src/lib.rs:830:22 | 830 | f.write_str(&self.to_string()) | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_display warning: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> library/proc_macro/src/lib.rs:912:22 | 912 | f.write_str(&self.to_string()) | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_display warning: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> library/proc_macro/src/lib.rs:1159:22 | 1159 | f.write_str(&self.to_string()) | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_display warning: 7 warnings emitted warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> library/test/src/formatters/pretty.rs:127:17 | 127 | inputs: &Vec<(TestDesc, Vec)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(TestDesc, Vec)]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: you should consider adding a `Default` implementation for `helpers::metrics::MetricMap` --> library/test/src/helpers/metrics.rs:20:5 | 20 | / pub fn new() -> MetricMap { 21 | | MetricMap(BTreeMap::new()) 22 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 19 | impl Default for helpers::metrics::MetricMap { 20 | fn default() -> Self { 21 | Self::new() 22 | } 23 | } | warning: you should consider adding a `Default` implementation for `options::Options` --> library/test/src/options.rs:74:5 | 74 | / pub fn new() -> Options { 75 | | Options { display_output: false, panic_abort: false } 76 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 73 | impl Default for options::Options { 74 | fn default() -> Self { 75 | Self::new() 76 | } 77 | } | warning: strict comparison of `f32` or `f64` --> library/test/src/stats.rs:270:8 | 270 | if pct == hundred { | ^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(pct - hundred).abs() < error_margin` | = note: `#[warn(clippy::float_cmp)]` on by default = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp warning: you don't need to add `&` to all patterns --> library/test/src/types.rs:55:9 | 55 | / match self { 56 | | &AlignedTestName(_, p) => p, 57 | | _ => PadNone, 58 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 55 | match *self { 56 | AlignedTestName(_, p) => p, | warning: 5 warnings emitted Finished release [optimized] target(s) in 0.21s Checking compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:120:39 | 120 | pub fn alloc(&self, object: T) -> &mut T { | ^^^^^^ | = note: `#[warn(clippy::mut_from_ref)]` on by default note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:120:18 | 120 | pub fn alloc(&self, object: T) -> &mut T { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:179:47 | 179 | pub fn alloc_slice(&self, slice: &[T]) -> &mut [T] | ^^^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:179:24 | 179 | pub fn alloc_slice(&self, slice: &[T]) -> &mut [T] | ^^^^^ ^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:192:74 | 192 | pub fn alloc_from_iter>(&self, iter: I) -> &mut [T] { | ^^^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:192:55 | 192 | pub fn alloc_from_iter>(&self, iter: I) -> &mut [T] { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:398:42 | 398 | pub fn alloc(&self, object: T) -> &mut T { | ^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:398:21 | 398 | pub fn alloc(&self, object: T) -> &mut T { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:418:50 | 418 | pub fn alloc_slice(&self, slice: &[T]) -> &mut [T] | ^^^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:418:27 | 418 | pub fn alloc_slice(&self, slice: &[T]) -> &mut [T] | ^^^^^ ^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:440:10 | 440 | ) -> &mut [T] { | ^^^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:436:9 | 436 | &self, | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:457:77 | 457 | pub fn alloc_from_iter>(&self, iter: I) -> &mut [T] { | ^^^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:457:58 | 457 | pub fn alloc_from_iter>(&self, iter: I) -> &mut [T] { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:530:49 | 530 | pub unsafe fn alloc(&self, object: T) -> &mut T { | ^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:530:28 | 530 | pub unsafe fn alloc(&self, object: T) -> &mut T { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_arena/src/lib.rs:530:5 | 530 | / pub unsafe fn alloc(&self, object: T) -> &mut T { 531 | | let mem = self.arena.alloc_raw(Layout::new::()) as *mut T; 532 | | // Write into uninitialized memory. 533 | | ptr::write(mem, object); ... | 540 | | result 541 | | } | |_____^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: mutable borrow from immutable input(s) --> compiler/rustc_arena/src/lib.rs:544:84 | 544 | pub unsafe fn alloc_from_iter>(&self, iter: I) -> &mut [T] { | ^^^^^^^^ | note: immutable borrow here --> compiler/rustc_arena/src/lib.rs:544:65 | 544 | pub unsafe fn alloc_from_iter>(&self, iter: I) -> &mut [T] { | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_arena/src/lib.rs:544:5 | 544 | / pub unsafe fn alloc_from_iter>(&self, iter: I) -> &mut [T] { 545 | | let mut vec: SmallVec<[_; 8]> = iter.into_iter().collect(); 546 | | if vec.is_empty() { 547 | | return &mut []; ... | 569 | | slice::from_raw_parts_mut(start_ptr, len) 570 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: 11 warnings emitted warning: use of `unwrap_or` followed by a function call --> compiler/rustc_lexer/src/unescape.rs:305:14 | 305 | .unwrap_or(str.len()); | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| str.len())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: 1 warning emitted warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:205:13 | 205 | &lib[2..] | ^^^^^^^^^ | = note: `#[warn(clippy::manual_strip)]` on by default note: the prefix was tested here --> compiler/rustc_llvm/build.rs:204:20 | 204 | let name = if lib.starts_with("-l") { | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 204 | let name = if let Some() = lib.strip_prefix("-l") { 205 | | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:207:13 | 207 | &lib[1..] | ^^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:206:16 | 206 | } else if lib.starts_with('-') { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 206 | } else if let Some() = lib.strip_prefix('-') { 207 | | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:245:63 | 245 | println!("cargo:rustc-link-search=native={}", lib[9..].replace(&host, &target)); | ^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:244:13 | 244 | if lib.starts_with("-LIBPATH:") { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 244 | if let Some() = lib.strip_prefix("-LIBPATH:") { 245 | println!("cargo:rustc-link-search=native={}", .replace(&host, &target)); | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:247:63 | 247 | println!("cargo:rustc-link-search=native={}", lib[2..].replace(&host, &target)); | ^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:246:20 | 246 | } else if lib.starts_with("-L") { | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 246 | } else if let Some() = lib.strip_prefix("-L") { 247 | println!("cargo:rustc-link-search=native={}", .replace(&host, &target)); | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:250:59 | 250 | println!("cargo:rustc-link-search=native={}", &lib[9..]); | ^^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:249:16 | 249 | } else if lib.starts_with("-LIBPATH:") { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 249 | } else if let Some() = lib.strip_prefix("-LIBPATH:") { 250 | println!("cargo:rustc-link-search=native={}", ); | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:252:49 | 252 | println!("cargo:rustc-link-lib={}", &lib[2..]); | ^^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:251:16 | 251 | } else if lib.starts_with("-l") { | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 251 | } else if let Some() = lib.strip_prefix("-l") { 252 | println!("cargo:rustc-link-lib={}", ); | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:254:59 | 254 | println!("cargo:rustc-link-search=native={}", &lib[2..]); | ^^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:253:16 | 253 | } else if lib.starts_with("-L") { | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 253 | } else if let Some() = lib.strip_prefix("-L") { 254 | println!("cargo:rustc-link-search=native={}", ); | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:266:53 | 266 | println!("cargo:rustc-link-lib={}", &lib[2..]); | ^^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:265:13 | 265 | if lib.starts_with("-l") { | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 265 | if let Some() = lib.strip_prefix("-l") { 266 | println!("cargo:rustc-link-lib={}", ); | warning: stripping a prefix manually --> compiler/rustc_llvm/build.rs:268:63 | 268 | println!("cargo:rustc-link-search=native={}", &lib[2..]); | ^^^^^^^^^ | note: the prefix was tested here --> compiler/rustc_llvm/build.rs:267:20 | 267 | } else if lib.starts_with("-L") { | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 267 | } else if let Some() = lib.strip_prefix("-L") { 268 | println!("cargo:rustc-link-search=native={}", ); | warning: this `if` has identical blocks --> compiler/rustc_llvm/build.rs:280:41 | 280 | } else if target.contains("darwin") { | _________________________________________^ 281 | | "c++" 282 | | } else if target.contains("netbsd") && llvm_static_stdcpp.is_some() { | |_____^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_llvm/build.rs:278:42 | 278 | } else if target.contains("freebsd") { | __________________________________________^ 279 | | "c++" 280 | | } else if target.contains("darwin") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this `if` has identical blocks --> compiler/rustc_llvm/build.rs:280:41 | 280 | } else if target.contains("darwin") { | _________________________________________^ 281 | | "c++" 282 | | } else if target.contains("netbsd") && llvm_static_stdcpp.is_some() { | |_____^ | note: same as this --> compiler/rustc_llvm/build.rs:278:42 | 278 | } else if target.contains("freebsd") { | __________________________________________^ 279 | | "c++" 280 | | } else if target.contains("darwin") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: 11 warnings emitted warning: 5 bindings with single-character names in scope --> compiler/rustc_apfloat/src/ppc.rs:295:22 | 295 | let (a, b, c, d) = (self.0, self.1, rhs.0, rhs.1); | ^ ^ ^ ^ 296 | // t = a * c 297 | let mut t = a; | ^ | = note: `#[warn(clippy::many_single_char_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 5 bindings with single-character names in scope --> compiler/rustc_apfloat/src/ppc.rs:295:22 | 295 | let (a, b, c, d) = (self.0, self.1, rhs.0, rhs.1); | ^ ^ ^ ^ 296 | // t = a * c 297 | let mut t = a; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 6 bindings with single-character names in scope --> compiler/rustc_apfloat/src/ppc.rs:295:22 | 295 | let (a, b, c, d) = (self.0, self.1, rhs.0, rhs.1); | ^ ^ ^ ^ 296 | // t = a * c 297 | let mut t = a; | ^ ... 307 | let mut v = a; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 7 bindings with single-character names in scope --> compiler/rustc_apfloat/src/ppc.rs:295:22 | 295 | let (a, b, c, d) = (self.0, self.1, rhs.0, rhs.1); | ^ ^ ^ ^ 296 | // t = a * c 297 | let mut t = a; | ^ ... 307 | let mut v = a; | ^ ... 310 | let mut w = b; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 8 bindings with single-character names in scope --> compiler/rustc_apfloat/src/ppc.rs:295:22 | 295 | let (a, b, c, d) = (self.0, self.1, rhs.0, rhs.1); | ^ ^ ^ ^ 296 | // t = a * c 297 | let mut t = a; | ^ ... 307 | let mut v = a; | ^ ... 310 | let mut w = b; | ^ ... 316 | let mut u = t; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: all variants have the same prefix: `Parse` --> compiler/rustc_serialize/src/json.rs:1385:1 | 1385 | / enum ParserState { 1386 | | // Parse a value in an array, true means first element. 1387 | | ParseArray(bool), 1388 | | // Parse ',' or ']' after an element in an array. ... | 1399 | | ParseFinished, 1400 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the prefixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` ... 296 | v = unpack!(status=, v / rhs); | ------------------------- in this macro invocation | = note: `#[warn(clippy::self_assignment)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: the loop variable `i` is used to index `v` --> compiler/rustc_serialize/src/serialize.rs:571:22 | 571 | for i in 0..len { | ^^^^^^ | = note: `#[warn(clippy::needless_range_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 571 | for (i, ) in v.iter_mut().enumerate().take(len) { | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` ... 304 | let x = unpack!(status=, v.to_i128_r(128, Round::NearestTiesToEven, &mut false)); | ------------------------------------------------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` ... 310 | let mut v = unpack!(status=, Self::from_i128(x)); | ------------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 666 | / macro_rules! tuple { 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 696 | | ) 697 | | } | |_- in this expansion of `tuple!` 698 | 699 | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | ------------------------------------------------------------ in this macro invocation | = note: `#[warn(clippy::eval_order_dependence)]` on by default note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 666 | / macro_rules! tuple { 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 696 | | ) 697 | | } | |_- in this expansion of `tuple!` 698 | 699 | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | ------------------------------------------------------------ in this macro invocation = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` ... 314 | v = unpack!(status=, v * rhs); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` ... 318 | v = unpack!(status=, self - v); | -------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` ... 390 | let r = unpack!(status=, (-self).to_u128_r(width, -round, is_exact)); | ------------------------------------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 666 | / macro_rules! tuple { 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 696 | | ) 697 | | } | |_- in this expansion of `tuple!` 698 | 699 | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | ------------------------------------------------------------ in this macro invocation | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 666 | / macro_rules! tuple { 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 696 | | ) 697 | | } | |_- in this expansion of `tuple!` 698 | 699 | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | ------------------------------------------------------------ in this macro invocation = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: `if` chain can be rewritten with `match` --> compiler/rustc_apfloat/src/ieee.rs:392:9 | 392 | / if exp == 0 { 393 | | // Nothing to do. 394 | | } else if exp > 0 { 395 | | // Just shift left. ... | 438 | | } 439 | | } | |_________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:763:24 | 763 | self = unpack!(status=, self.normalize(round, loss)); | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 666 | / macro_rules! tuple { 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 696 | | ) 697 | | } | |_- in this expansion of `tuple!` 698 | 699 | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | ------------------------------------------------------------ in this macro invocation | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 666 | / macro_rules! tuple { 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 696 | | ) 697 | | } | |_- in this expansion of `tuple!` 698 | 699 | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | ------------------------------------------------------------ in this macro invocation = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:821:24 | 821 | self = unpack!(status=, self.normalize(round, loss)); | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:835:20 | 835 | self = unpack!(status=, self.mul_r(multiplicand, round)); | ------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:845:24 | 845 | self = unpack!(status=, self.add_r(addend, round)); | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:919:16 | 919 | self = unpack!(status=, self.normalize(round, loss)); | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:980:24 | 980 | self = unpack!(status=, self.normalize(round, loss)); | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:1016:28 | 1016 | self = unpack!(status=, self - v); | -------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:1040:27 | 1040 | let magic_const = unpack!(status=, Self::from_u128(1 << (S::PRECISION - 1))); | ---------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:1048:13 | 1048 | r = unpack!(status=, r.add_r(magic_const, round)); | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:1368:22 | 1368 | reciprocal = unpack!(status=, reciprocal / self); | ----------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:1503:17 | 1503 | r = unpack!(status=, r.normalize(round, loss)); | ------------------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ieee.rs:2110:27 | 2110 | let mut exp = unpack!(status=, | ___________________________- 2111 | | calc_normal_from_limbs(&mut sig_calc, &dec_sig)); | |________________________________________________________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: `if` chain can be rewritten with `match` --> compiler/rustc_apfloat/src/ieee.rs:2528:13 | 2528 | / if bits == 0 { 2529 | | reverse = cmp(a_sig, b_sig) == Ordering::Less; 2530 | | loss = Loss::ExactlyZero; 2531 | | } else if bits > 0 { ... | 2538 | | reverse = true; 2539 | | } | |_____________^ | = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:66:45 | 66 | let extended: FallbackExtended = unpack!(status=, x.convert(&mut loses_info)); | -------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:69:17 | 69 | let a = unpack!(status=, extended.convert(&mut loses_info)); | --------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:77:42 | 77 | let u: FallbackExtended = unpack!(status=, a.convert(&mut loses_info)); | -------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:79:21 | 79 | let v = unpack!(status=, extended - u); | ------------------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:81:21 | 81 | let v = unpack!(status=, v.convert(&mut loses_info)); | -------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:98:17 | 98 | let a = unpack!(status=, a.convert(&mut loses_info)); | -------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:103:21 | 103 | let b = unpack!(status=, b.convert(&mut loses_info)); | -------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: self-assignment of `status` to `$status` --> compiler/rustc_apfloat/src/lib.rs:95:17 | 83 | / macro_rules! unpack { 84 | | ($status:ident|=, $e:expr) => { 85 | | match $e { 86 | | $crate::StatusAnd { status, value } => { ... | 95 | | $status = status; | | ^^^^^^^^^^^^^^^^ ... | 99 | | }; 100 | | } | |_- in this expansion of `unpack!` | ::: compiler/rustc_apfloat/src/ppc.rs:160:15 | 160 | r.1 = unpack!(status=, r.1.next_down()); | --------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment warning: 33 warnings emitted warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: item `RustString` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_llvm/src/lib.rs:16:1 | 16 | / impl RustString { 17 | | pub fn len(&self) -> usize { 18 | | self.bytes.borrow().len() 19 | | } 20 | | } | |_^ | = note: `#[warn(clippy::len_without_is_empty)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_llvm/src/lib.rs:24:1 | 24 | / pub unsafe extern "C" fn LLVMRustStringWriteImpl( 25 | | sr: &RustString, 26 | | ptr: *const c_char, 27 | | size: size_t, ... | 31 | | sr.bytes.borrow_mut().extend_from_slice(slice); 32 | | } | |_^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: 2 warnings emitted warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: large size difference between variants --> compiler/rustc_macros/src/query.rs:36:5 | 36 | Storage(Type), | ^^^^^^^^^^^^^ this variant is 304 bytes | = note: `#[warn(clippy::large_enum_variant)]` on by default note: and the second-largest variant is 72 bytes: --> compiler/rustc_macros/src/query.rs:33:5 | 33 | Desc(Option, Punctuated), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant help: consider boxing the large fields to reduce the total size of the enum | 36 | Storage(Box), | ^^^^^^^^^ warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_macros/src/session_diagnostic.rs:94:25 | 94 | fn to_compile_error(self) -> proc_macro2::TokenStream { | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> compiler/rustc_macros/src/session_diagnostic.rs:319:5 | 319 | / fn set_kind_once( 320 | | &mut self, 321 | | kind: DiagnosticId, 322 | | span: proc_macro2::Span, 323 | | ) -> Result<(), SessionDiagnosticDeriveError> { | |_________________________________________________^ | = note: `#[warn(clippy::double_must_use)]` on by default = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> compiler/rustc_macros/src/session_diagnostic.rs:577:35 | 577 | fn build_format(&self, input: &String, span: proc_macro2::Span) -> proc_macro2::TokenStream { | ^^^^^^^ help: change this to: `&str` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: returning the result of a `let` binding from a block --> compiler/rustc_macros/src/symbols.rs:193:5 | 162 | / let tt = TokenStream::from(quote! { 163 | | macro_rules! keywords { 164 | | () => { 165 | | #keyword_stream ... | 186 | | } 187 | | }); | |_______- unnecessary `let` binding ... 193 | tt | ^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 162 | 163 | 164 | // To see the generated code generated, uncomment this line, recompile, and 165 | // run the resulting output through `rustfmt`. 166 | //eprintln!("{}", tt); 167 | ... warning: 5 warnings emitted warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: large size difference between variants --> compiler/rustc_macros/src/query.rs:36:5 | 36 | Storage(Type), | ^^^^^^^^^^^^^ this variant is 304 bytes | = note: `#[warn(clippy::large_enum_variant)]` on by default note: and the second-largest variant is 72 bytes: --> compiler/rustc_macros/src/query.rs:33:5 | 33 | Desc(Option, Punctuated), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant help: consider boxing the large fields to reduce the total size of the enum | 36 | Storage(Box), | ^^^^^^^^^ warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_macros/src/session_diagnostic.rs:94:25 | 94 | fn to_compile_error(self) -> proc_macro2::TokenStream { | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> compiler/rustc_macros/src/session_diagnostic.rs:319:5 | 319 | / fn set_kind_once( 320 | | &mut self, 321 | | kind: DiagnosticId, 322 | | span: proc_macro2::Span, 323 | | ) -> Result<(), SessionDiagnosticDeriveError> { | |_________________________________________________^ | = note: `#[warn(clippy::double_must_use)]` on by default = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> compiler/rustc_macros/src/session_diagnostic.rs:577:35 | 577 | fn build_format(&self, input: &String, span: proc_macro2::Span) -> proc_macro2::TokenStream { | ^^^^^^^ help: change this to: `&str` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: returning the result of a `let` binding from a block --> compiler/rustc_macros/src/symbols.rs:193:5 | 162 | / let tt = TokenStream::from(quote! { 163 | | macro_rules! keywords { 164 | | () => { 165 | | #keyword_stream ... | 186 | | } 187 | | }); | |_______- unnecessary `let` binding ... 193 | tt | ^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 162 | 163 | 164 | // To see the generated code generated, uncomment this line, recompile, and 165 | // run the resulting output through `rustfmt`. 166 | //eprintln!("{}", tt); 167 | ... warning: 5 warnings emitted warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: unsequenced read of a variable --> compiler/rustc_serialize/src/serialize.rs:675:59 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) | note: whether read occurs before this write depends on evaluation order --> compiler/rustc_serialize/src/serialize.rs:675:53 | 649 | / macro_rules! peel { 650 | | ($name:ident, $($other:ident,)*) => (tuple! { $($other,)* }) | | ---------------------- in this macro invocation (#3) 651 | | } | |_- in this expansion of `peel!` (#2) ... 666 | macro_rules! tuple { | _- | |_| | | 667 | | () => (); 668 | | ( $($name:ident,)+ ) => ( 669 | | impl),+> Decodable for ($($name,)+) { ... | 675 | | let ret = ($(d.read_tuple_arg({ i+=1; i-1 }, |d| -> Result<$name, D::Error> { | | ^^^^ ... | 695 | | peel! { $($name,)+ } | | -------------------- in this macro invocation (#2) 696 | | ) 697 | | } | | - | |_| | |_in this expansion of `tuple!` (#1) | in this expansion of `tuple!` (#3) 698 | 699 | | tuple! { T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, } | | ------------------------------------------------------------ in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence warning: sub-expression diverges --> compiler/rustc_serialize/src/opaque.rs:138:33 | 138 | self.emit_usize(v.len())?; | ^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: 26 warnings emitted warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_index/src/bit_set.rs:622:21 | 622 | pub fn to_dense(self) -> BitSet { | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: the loop variable `index` is only used to index `words`. --> compiler/rustc_index/src/bit_set.rs:864:22 | 864 | for index in start..end { | ^^^^^^^^^^ | = note: `#[warn(clippy::needless_range_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 864 | for in words.iter_mut().take(end).skip(start) { | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter` --> compiler/rustc_index/src/vec.rs:588:5 | 588 | / pub fn into_iter(self) -> vec::IntoIter { 589 | | self.raw.into_iter() 590 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: 3 warnings emitted warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/sip128.rs:402:13 | 402 | let _0 = state.v0 ^ state.v1 ^ state.v2 ^ state.v3; | ^^ | = note: `#[warn(clippy::just_underscores_and_digits)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/sip128.rs:406:13 | 406 | let _1 = state.v0 ^ state.v1 ^ state.v2 ^ state.v3; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:45:14 | 45 | let (_0, _1) = hasher.finalize(); | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:45:18 | 45 | let (_0, _1) = hasher.finalize(); | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:245:18 | 245 | let (ref _0,) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:252:18 | 252 | let (ref _0, ref _1) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:252:26 | 252 | let (ref _0, ref _1) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:265:18 | 265 | let (ref _0, ref _1, ref _2) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:265:26 | 265 | let (ref _0, ref _1, ref _2) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:265:34 | 265 | let (ref _0, ref _1, ref _2) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:280:18 | 280 | let (ref _0, ref _1, ref _2, ref _3) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:280:26 | 280 | let (ref _0, ref _1, ref _2, ref _3) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:280:34 | 280 | let (ref _0, ref _1, ref _2, ref _3) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/stable_hasher.rs:280:42 | 280 | let (ref _0, ref _1, ref _2, ref _3) = *self; | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/fingerprint.rs:110:14 | 110 | let (_0, _1) = hasher.finalize(); | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: consider choosing a more descriptive name --> compiler/rustc_data_structures/src/fingerprint.rs:110:18 | 110 | let (_0, _1) = hasher.finalize(); | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_data_structures/src/box_region.rs:34:16 | 34 | generator: Pin, Return = R>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/box_region.rs:52:5 | 52 | / pub unsafe fn access(&mut self, closure: *mut dyn FnMut()) { 53 | | // Call the generator, which in turn will call the closure 54 | | if let GeneratorState::Complete(_) = 55 | | Pin::new(&mut self.generator).resume(Action::Access(AccessAction(closure))) ... | 58 | | } 59 | | } | |_____^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/box_region.rs:72:5 | 72 | / pub unsafe fn new() -> Self { 73 | | Marker(PhantomData) 74 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: you should consider adding a `Default` implementation for `graph::implementation::Graph` --> compiler/rustc_data_structures/src/graph/implementation/mod.rs:88:5 | 88 | / pub fn new() -> Graph { 89 | | Graph { nodes: SnapshotVec::new(), edges: SnapshotVec::new() } 90 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 87 | impl Default for graph::implementation::Graph { 88 | fn default() -> Self { 89 | Self::new() 90 | } 91 | } | warning: item `obligation_forest::ObligationForest` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_data_structures/src/obligation_forest/mod.rs:313:1 | 313 | / impl ObligationForest { 314 | | pub fn new() -> ObligationForest { 315 | | ObligationForest { 316 | | nodes: vec![], ... | 705 | | } 706 | | } | |_^ | = note: `#[warn(clippy::len_without_is_empty)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: you should consider adding a `Default` implementation for `obligation_forest::ObligationForest` --> compiler/rustc_data_structures/src/obligation_forest/mod.rs:314:5 | 314 | / pub fn new() -> ObligationForest { 315 | | ObligationForest { 316 | | nodes: vec![], 317 | | done_cache: Default::default(), ... | 322 | | } 323 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 313 | impl Default for obligation_forest::ObligationForest { 314 | fn default() -> Self { 315 | Self::new() 316 | } 317 | } | warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_data_structures/src/obligation_forest/mod.rs:384:32 | 384 | pub fn to_errors(&mut self, error: E) -> Vec> { | ^^^^^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: `assert!(false)` should probably be replaced --> compiler/rustc_data_structures/src/obligation_forest/mod.rs:393:27 | 393 | self.compress(|_| assert!(false)); | ^^^^^^^^^^^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/macros/mod.rs:1218:5 | 1218 | / macro_rules! assert { 1219 | | ($cond:expr $(,)?) => {{ /* compiler built-in */ }}; 1220 | | ($cond:expr, $($arg:tt)+) => {{ /* compiler built-in */ }}; 1221 | | } | |_____- in this expansion of `assert!` | = note: `#[warn(clippy::assertions_on_constants)]` on by default = help: use `panic!()` or `unreachable!()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants warning: the loop variable `index` is used to index `node_rewrites` --> compiler/rustc_data_structures/src/obligation_forest/mod.rs:625:22 | 625 | for index in 0..orig_nodes_len { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_range_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 625 | for (index, ) in node_rewrites.iter_mut().enumerate().take(orig_nodes_len) { | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/owning_ref/mod.rs:350:5 | 350 | / pub unsafe fn new_assert_stable_address(o: O) -> Self 351 | | where 352 | | O: Deref, 353 | | { 354 | | OwningRef { reference: &*o, owner: o } 355 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/owning_ref/mod.rs:420:5 | 420 | / pub unsafe fn map_owner(self, f: F) -> OwningRef 421 | | where 422 | | O: StableAddress, 423 | | P: StableAddress, ... | 426 | | OwningRef { reference: self.reference, owner: f(self.owner) } 427 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/owning_ref/mod.rs:540:5 | 540 | / pub unsafe fn new_assert_stable_address(mut o: O) -> Self 541 | | where 542 | | O: DerefMut, 543 | | { 544 | | OwningRefMut { reference: &mut *o, owner: o } 545 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/owning_ref/mod.rs:668:5 | 668 | / pub unsafe fn map_owner(self, f: F) -> OwningRefMut 669 | | where 670 | | O: StableAddress, 671 | | P: StableAddress, ... | 674 | | OwningRefMut { reference: self.reference, owner: f(self.owner) } 675 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/owning_ref/mod.rs:809:5 | 809 | unsafe fn to_handle(x: *const Self) -> Self::Handle; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_data_structures/src/owning_ref/mod.rs:819:5 | 819 | unsafe fn to_handle_mut(x: *const Self) -> Self::HandleMut; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: type `svh::Svh` implements inherent method `to_string(&self) -> String` which shadows the implementation of `Display` --> compiler/rustc_data_structures/src/svh.rs:31:5 | 31 | / pub fn to_string(&self) -> String { 32 | | format!("{:016x}", self.hash) 33 | | } | |_____^ | = note: `#[warn(clippy::inherent_to_string_shadow_display)]` on by default = help: remove the inherent method from type `svh::Svh` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string_shadow_display warning: you are implementing `Hash` explicitly but have derived `PartialEq` --> compiler/rustc_data_structures/src/svh.rs:36:1 | 36 | / impl Hash for Svh { 37 | | fn hash(&self, state: &mut H) 38 | | where 39 | | H: Hasher, ... | 42 | | } 43 | | } | |_^ | = note: `#[warn(clippy::derive_hash_xor_eq)]` on by default note: `PartialEq` implemented here --> compiler/rustc_data_structures/src/svh.rs:14:23 | 14 | #[derive(Copy, Clone, PartialEq, Eq, Debug)] | ^^^^^^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/cmp.rs:218:1 | 218 | / pub macro PartialEq($item:item) { 219 | | /* compiler built-in */ 220 | | } | |_- in this expansion of `#[derive(PartialEq)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: you should consider adding a `Default` implementation for `sorted_map::index_map::SortedIndexMultiMap` --> compiler/rustc_data_structures/src/sorted_map/index_map.rs:39:5 | 39 | / pub fn new() -> Self { 40 | | SortedIndexMultiMap { items: IndexVec::new(), idx_sorted_by_item_key: Vec::new() } 41 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 38 | impl Default for sorted_map::index_map::SortedIndexMultiMap { 39 | fn default() -> Self { 40 | Self::new() 41 | } 42 | } | warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter` --> compiler/rustc_data_structures/src/sorted_map/index_map.rs:52:5 | 52 | / pub fn into_iter(self) -> impl DoubleEndedIterator { 53 | | self.items.into_iter() 54 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: you should consider adding a `Default` implementation for `stable_hasher::StableHasher` --> compiler/rustc_data_structures/src/stable_hasher.rs:34:5 | 34 | / pub fn new() -> Self { 35 | | StableHasher { state: SipHasher128::new_with_keys(0, 0) } 36 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 32 | impl Default for stable_hasher::StableHasher { 33 | fn default() -> Self { 34 | Self::new() 35 | } 36 | } | warning: transmute from a `f32` to a `u32` --> compiler/rustc_data_structures/src/stable_hasher.rs:225:33 | 225 | let val: u32 = unsafe { ::std::mem::transmute(*self) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `(*self).to_bits()` | = note: `#[warn(clippy::transmute_float_to_int)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_float_to_int warning: transmute from a `f64` to a `u64` --> compiler/rustc_data_structures/src/stable_hasher.rs:232:33 | 232 | let val: u64 = unsafe { ::std::mem::transmute(*self) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `(*self).to_bits()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_float_to_int warning: you are implementing `Hash` explicitly but have derived `PartialEq` --> compiler/rustc_data_structures/src/fingerprint.rs:80:1 | 80 | / impl Hash for Fingerprint { 81 | | #[inline] 82 | | fn hash(&self, state: &mut H) { 83 | | state.write_fingerprint(self); 84 | | } 85 | | } | |_^ | note: `PartialEq` implemented here --> compiler/rustc_data_structures/src/fingerprint.rs:9:14 | 9 | #[derive(Eq, PartialEq, Ord, PartialOrd, Debug, Clone, Copy)] | ^^^^^^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/cmp.rs:218:1 | 218 | / pub macro PartialEq($item:item) { 219 | | /* compiler built-in */ 220 | | } | |_- in this expansion of `#[derive(PartialEq)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: any number modulo 1 will be 0 --> compiler/rustc_data_structures/src/sharded.rs:77:9 | 77 | bits % SHARDS | ^^^^^^^^^^^^^ | = note: `#[warn(clippy::modulo_one)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#modulo_one warning: item `sharded::Sharded>>` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_data_structures/src/sharded.rs:101:1 | 101 | / impl ShardedHashMap { 102 | | pub fn len(&self) -> usize { 103 | | self.lock_shards().iter().map(|shard| shard.len()).sum() 104 | | } 105 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: the operation is ineffective. Consider reducing it to `1024` --> compiler/rustc_data_structures/src/stack.rs:8:36 | 8 | const STACK_PER_RECURSION: usize = 1 * 1024 * 1024; // 1MB | ^^^^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: you seem to be trying to use `Box>`. Consider using just `Vec` --> compiler/rustc_data_structures/src/thin_vec.rs:7:30 | 7 | pub struct ThinVec(Option>>); | ^^^^^^^^^^^ | = note: `#[warn(clippy::box_vec)]` on by default = help: `Vec` is already on the heap, `Box>` makes an extra allocation. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec warning: item `tiny_list::TinyList` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_data_structures/src/tiny_list.rs:22:1 | 22 | / impl TinyList { 23 | | #[inline] 24 | | pub fn new() -> TinyList { 25 | | TinyList { head: None } ... | 68 | | } 69 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: you should consider adding a `Default` implementation for `tiny_list::TinyList` --> compiler/rustc_data_structures/src/tiny_list.rs:24:5 | 24 | / pub fn new() -> TinyList { 25 | | TinyList { head: None } 26 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 22 | impl Default for tiny_list::TinyList { 23 | fn default() -> Self { 24 | Self::new() 25 | } 26 | } | warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_data_structures/src/sso/map.rs:413:21 | 413 | type IntoIter = EitherIter< | _____________________^ 414 | | as IntoIterator>::IntoIter, 415 | | as IntoIterator>::IntoIter, 416 | | >; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_data_structures/src/sso/map.rs:429:1 | 429 | fn adapt_array_ref_it(pair: &'a (K, V)) -> (&'a K, &'a V) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_data_structures/src/sso/map.rs:436:1 | 436 | fn adapt_array_mut_it(pair: &'a mut (K, V)) -> (&'a K, &'a mut V) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_data_structures/src/sso/map.rs:442:21 | 442 | type IntoIter = EitherIter< | _____________________^ 443 | | std::iter::Map< 444 | | <&'a ArrayVec<[(K, V); 8]> as IntoIterator>::IntoIter, 445 | | fn(&'a (K, V)) -> (&'a K, &'a V), 446 | | >, 447 | | <&'a FxHashMap as IntoIterator>::IntoIter, 448 | | >; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_data_structures/src/sso/map.rs:460:21 | 460 | type IntoIter = EitherIter< | _____________________^ 461 | | std::iter::Map< 462 | | <&'a mut ArrayVec<[(K, V); 8]> as IntoIterator>::IntoIter, 463 | | fn(&'a mut (K, V)) -> (&'a K, &'a mut V), 464 | | >, 465 | | <&'a mut FxHashMap as IntoIterator>::IntoIter, 466 | | >; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_data_structures/src/sso/set.rs:78:5 | 78 | pub fn iter(&'a self) -> impl Iterator { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_data_structures/src/sso/set.rs:208:21 | 208 | type IntoIter = std::iter::Map< as IntoIterator>::IntoIter, fn((T, ())) -> T>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_data_structures/src/sso/set.rs:218:21 | 218 | type IntoIter = std::iter::Map< | _____________________^ 219 | | <&'a SsoHashMap as IntoIterator>::IntoIter, 220 | | fn((&'a T, &'a ())) -> &'a T, 221 | | >; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: 53 warnings emitted warning: this `else { if .. }` block can be collapsed --> compiler/rustc_span/src/symbol.rs:1355:16 | 1355 | } else { | ________________^ 1356 | | if self.symbol == kw::DollarCrate { 1357 | | if let Some(span) = self.convert_dollar_crate { 1358 | | let converted = span.ctxt().dollar_crate_name(); ... | 1364 | | } 1365 | | } | |_________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1355 | } else if self.symbol == kw::DollarCrate { 1356 | if let Some(span) = self.convert_dollar_crate { 1357 | let converted = span.ctxt().dollar_crate_name(); 1358 | if !converted.is_path_segment_keyword() { 1359 | f.write_str("::")?; 1360 | } ... warning: this function has too many arguments (13/7) --> compiler/rustc_span/src/source_map.rs:343:5 | 343 | / pub fn new_imported_source_file( 344 | | &self, 345 | | filename: FileName, 346 | | name_was_remapped: bool, ... | 356 | | original_end_pos: BytePos, 357 | | ) -> Lrc { | |________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_span/src/source_map.rs:624:13 | 624 | / src.get(start_index..end_index) 625 | | .map(|s| s.to_string()) 626 | | .ok_or_else(|| SpanSnippetError::IllFormedSpan(sp)) | |___________________________________________________________________^ | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `ok_or` instead | 624 | src.get(start_index..end_index) 625 | .map(|s| s.to_string()).ok_or(SpanSnippetError::IllFormedSpan(sp)) | warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_span/src/source_map.rs:643:13 | 643 | / src.get(..start_index) 644 | | .map(|s| s.to_string()) 645 | | .ok_or_else(|| SpanSnippetError::IllFormedSpan(sp)) | |___________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `ok_or` instead | 643 | src.get(..start_index) 644 | .map(|s| s.to_string()).ok_or(SpanSnippetError::IllFormedSpan(sp)) | warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` --> compiler/rustc_span/src/symbol.rs:1245:5 | 1245 | / pub fn from_str(string: &str) -> Ident { 1246 | | Ident::with_dummy_span(Symbol::intern(string)) 1247 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: use of `offset` with a `usize` casted to an `isize` --> compiler/rustc_span/src/analyze_source_file.rs:100:45 | 100 | let chunk = _mm_loadu_si128(ptr.offset(chunk_index as isize)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(chunk_index)` | = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> compiler/rustc_span/src/lib.rs:372:27 | 372 | pub fn from_expansion(self) -> bool { | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name --> compiler/rustc_span/src/lib.rs:605:23 | 605 | pub fn from_inner(self, inner: InnerSpan) -> Span { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you should consider adding a `Default` implementation for `MultiSpan` --> compiler/rustc_span/src/lib.rs:803:5 | 803 | / pub fn new() -> MultiSpan { 804 | | MultiSpan { primary_spans: vec![], span_labels: vec![] } 805 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 801 | impl Default for MultiSpan { 802 | fn default() -> Self { 803 | Self::new() 804 | } 805 | } | warning: usage of `Rc` when T is a buffer type --> compiler/rustc_span/src/lib.rs:1007:13 | 1007 | Present(Lrc), | ^^^^^^^^^^^ help: try: `Rc` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: match expression looks like `matches!` macro --> compiler/rustc_span/src/lib.rs:1017:9 | 1017 | / match self { 1018 | | ExternalSource::Foreign { kind: ExternalSourceKind::Present(_), .. } => false, 1019 | | _ => true, 1020 | | } | |_________^ help: try this: `!matches!(self, ExternalSource::Foreign { kind: ExternalSourceKind::Present(_), .. })` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: usage of `Rc` when T is a buffer type --> compiler/rustc_span/src/lib.rs:1023:41 | 1023 | pub fn get_source(&self) -> Option<&Lrc> { | ^^^^^^^^^^^ help: try: `Rc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: usage of `Rc` when T is a buffer type --> compiler/rustc_span/src/lib.rs:1117:21 | 1117 | pub src: Option>, | ^^^^^^^^^^^ help: try: `Rc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: 13 warnings emitted warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/util/classify.rs:15:5 | 15 | / match e.kind { 16 | | ast::ExprKind::If(..) 17 | | | ast::ExprKind::Match(..) 18 | | | ast::ExprKind::Block(..) ... | 23 | | _ => true, 24 | | } | |_____^ | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 15 | !matches!(e.kind, ast::ExprKind::If(..) 16 | | ast::ExprKind::Match(..) 17 | | ast::ExprKind::Block(..) 18 | | ast::ExprKind::While(..) 19 | | ast::ExprKind::Loop(..) 20 | | ast::ExprKind::ForLoop(..) ... warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/util/comments.rs:181:45 | 181 | let code_to_the_right = match text[pos + token.len..].chars().next() { | _____________________________________________^ 182 | | Some('\r' | '\n') => false, 183 | | _ => true, 184 | | }; | |_____________________^ help: try this: `!matches!(text[pos + token.len..].chars().next(), Some('\r' | '\n'))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this `if` has identical blocks --> compiler/rustc_parse_format/src/lib.rs:354:48 | 354 | } else if pos == *skip && raw == 0 { | ________________________________________________^ 355 | | pos += 1; 356 | | } else { | |_____________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_parse_format/src/lib.rs:352:28 | 352 | if pos > *skip { | ____________________________^ 353 | | pos += 1; 354 | | } else if pos == *skip && raw == 0 { | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/util/parser.rs:215:9 | 215 | / match self { 216 | | BitXor | // `{ 42 } ^ 3` 217 | | Assign | // `{ 42 } = { 42 }` 218 | | Divide | // `{ 42 } / 42` ... | 229 | | _ => false, 230 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 215 | matches!(self, BitXor | // `{ 42 } ^ 3` 216 | Assign | // `{ 42 } = { 42 }` 217 | Divide | // `{ 42 } / 42` 218 | Modulus | // `{ 42 } % 2` 219 | ShiftRight | // `{ 42 } >> 2` 220 | LessEqual | // `{ 42 } <= 3` ... warning: use of `unwrap_or` followed by a function call --> compiler/rustc_parse_format/src/lib.rs:694:23 | 694 | let end = end.unwrap_or(self.input.len()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.input.len())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: 2 warnings emitted warning: you should consider adding a `Default` implementation for `abi::call::ArgAttributes` --> compiler/rustc_target/src/abi/call/mod.rs:80:5 | 80 | / pub fn new() -> Self { 81 | | ArgAttributes { 82 | | regular: ArgAttribute::default(), 83 | | pointee_size: Size::ZERO, 84 | | pointee_align: None, 85 | | } 86 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 79 | impl Default for abi::call::ArgAttributes { 80 | fn default() -> Self { 81 | Self::new() 82 | } 83 | } | warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:171:9 | 171 | / match *self { 172 | | AngleBracketed(..) => true, 173 | | _ => false, 174 | | } | |_________^ help: try this: `matches!(*self, AngleBracketed(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: some ranges overlap --> compiler/rustc_target/src/abi/mod.rs:504:13 | 504 | -0x0000_0000_0000_0080..=0x0000_0000_0000_007f => I8, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_overlapping_arm)]` on by default note: overlaps with this --> compiler/rustc_target/src/abi/mod.rs:505:13 | 505 | -0x0000_0000_0000_8000..=0x0000_0000_0000_7fff => I16, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm warning: you are deriving `Hash` but have implemented `PartialEq` explicitly --> compiler/rustc_ast/src/ast.rs:317:10 | 317 | #[derive(Hash, Clone, Copy)] | ^^^^ in this macro invocation | ::: /home/nick/development/rust/rust/library/core/src/hash/mod.rs:200:5 | 200 | / pub macro Hash($item:item) { 201 | | /* compiler built-in */ 202 | | } | |_____- in this expansion of `#[derive(Hash)]` | = note: `#[warn(clippy::derive_hash_xor_eq)]` on by default note: `PartialEq` implemented here --> compiler/rustc_ast/src/ast.rs:347:1 | 347 | / impl PartialEq for ParamKindOrd { 348 | | fn eq(&self, other: &Self) -> bool { 349 | | self.cmp(other) == Ordering::Equal 350 | | } 351 | | } | |_^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq warning: some ranges overlap --> compiler/rustc_target/src/abi/mod.rs:515:13 | 515 | 0..=0x0000_0000_0000_00ff => I8, | ^^^^^^^^^^^^^^^^^^^^^^^^^ | note: overlaps with this --> compiler/rustc_target/src/abi/mod.rs:516:13 | 516 | 0..=0x0000_0000_0000_ffff => I16, | ^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm warning: the operation is ineffective. Consider reducing it to `n` --> compiler/rustc_target/src/asm/mod.rs:493:31 | 493 | Self::VecI8(n) => n * 1, | ^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: you don't need to add `&` to all patterns --> compiler/rustc_ast/src/ast.rs:437:9 | 437 | / match self { 438 | | &WherePredicate::BoundPredicate(ref p) => p.span, 439 | | &WherePredicate::RegionPredicate(ref p) => p.span, 440 | | &WherePredicate::EqPredicate(ref p) => p.span, 441 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 437 | match *self { 438 | WherePredicate::BoundPredicate(ref p) => p.span, 439 | WherePredicate::RegionPredicate(ref p) => p.span, 440 | WherePredicate::EqPredicate(ref p) => p.span, | warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:633:9 | 633 | / match self.kind { 634 | | PatKind::Rest => true, 635 | | _ => false, 636 | | } | |_________^ help: try this: `matches!(self.kind, PatKind::Rest)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:856:9 | 856 | / match *self { 857 | | BinOpKind::And | BinOpKind::Or => true, 858 | | _ => false, 859 | | } | |_________^ help: try this: `matches!(*self, BinOpKind::And | BinOpKind::Or)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` --> compiler/rustc_target/src/spec/mod.rs:136:13 | 129 | / macro_rules! flavor_mappings { 130 | | ($((($($flavor:tt)*), $string:expr),)*) => ( 131 | | impl LinkerFlavor { 132 | | pub const fn one_of() -> &'static str { ... | 136 | /| pub fn from_str(s: &str) -> Option { 137 | || Some(match s { 138 | || $($string => $($flavor)*,)* 139 | || _ => return None, 140 | || }) 141 | || } | ||_____________^ ... | 149 | | ) 150 | | } | |_- in this expansion of `flavor_mappings!` 151 | 152 | / flavor_mappings! { 153 | | ((LinkerFlavor::Em), "em"), 154 | | ((LinkerFlavor::Gcc), "gcc"), 155 | | ((LinkerFlavor::Ld), "ld"), ... | 161 | | ((LinkerFlavor::Lld(LldFlavor::Link)), "lld-link"), 162 | | } | |__- in this macro invocation | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: 5 warnings emitted warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:931:9 | 931 | / match self.kind { 932 | | StmtKind::Item(_) => true, 933 | | _ => false, 934 | | } | |_________^ help: try this: `matches!(self.kind, StmtKind::Item(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:938:9 | 938 | / match self.kind { 939 | | StmtKind::Expr(_) => true, 940 | | _ => false, 941 | | } | |_________^ help: try this: `matches!(self.kind, StmtKind::Expr(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: if let .. else expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:1075:21 | 1075 | / if let ExprKind::Ret(_) = expr.kind { 1076 | | // Last statement is explicit return. 1077 | | true 1078 | | } else { 1079 | | false 1080 | | } | |_____________________^ help: try this: `matches!(expr.kind, ExprKind::Ret(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:1620:9 | 1620 | / match *self { 1621 | | LitKind::Str(..) => true, 1622 | | _ => false, 1623 | | } | |_________^ help: try this: `matches!(*self, LitKind::Str(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:1628:9 | 1628 | / match self { 1629 | | LitKind::ByteStr(_) => true, 1630 | | _ => false, 1631 | | } | |_________^ help: try this: `matches!(self, LitKind::ByteStr(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:1636:9 | 1636 | / match *self { 1637 | | LitKind::Int(..) | LitKind::Float(..) => true, 1638 | | _ => false, 1639 | | } | |_________^ help: try this: `matches!(*self, LitKind::Int(..) | LitKind::Float(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_ast/src/ast.rs:2005:22 | 2005 | pub fn to_string(s: &[Self]) -> String { | ^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/ast.rs:2204:48 | 2204 | self.inputs.last().map_or(false, |arg| match arg.ty.kind { | ________________________________________________^ 2205 | | TyKind::CVarArgs => true, 2206 | | _ => false, 2207 | | }) | |_________^ help: try this: `matches!(arg.ty.kind, TyKind::CVarArgs)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: you should consider adding a `Default` implementation for `attr::MarkedAttrs` --> compiler/rustc_ast/src/attr/mod.rs:25:5 | 25 | / pub fn new() -> Self { 26 | | MarkedAttrs(GrowableBitSet::new_empty()) 27 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 22 | impl Default for attr::MarkedAttrs { 23 | fn default() -> Self { 24 | Self::new() 25 | } 26 | } | warning: use of `unwrap_or` followed by a function call --> compiler/rustc_ast/src/attr/mod.rs:69:22 | 69 | self.ident().unwrap_or(Ident::invalid()).name | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Ident::invalid)` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> compiler/rustc_ast/src/attr/mod.rs:142:22 | 142 | self.ident().unwrap_or(Ident::invalid()).name | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Ident::invalid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> compiler/rustc_ast/src/attr/mod.rs:186:22 | 186 | self.ident().unwrap_or(Ident::invalid()).name | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Ident::invalid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/attr/mod.rs:217:9 | 217 | / match self.kind { 218 | | MetaItemKind::Word => true, 219 | | _ => false, 220 | | } | |_________^ help: try this: `matches!(self.kind, MetaItemKind::Word)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: use of `unwrap_or` followed by a function call --> compiler/rustc_ast/src/attr/mod.rs:428:62 | 428 | MetaItemKind::List(..) => list_closing_paren_pos.unwrap_or(path.span.hi()), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path.span.hi())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` --> compiler/rustc_ast/src/ptr.rs:196:18 | 196 | self.ptr.into_iter() | ^^^^^^^^^ help: call directly: `iter` | = note: `#[warn(clippy::into_iter_on_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:133:9 | 133 | / match self { 134 | | Integer | Float | Err => true, 135 | | _ => false, 136 | | } | |_________^ help: try this: `matches!(self, Integer | Float | Err)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:308:9 | 308 | / match self { 309 | | Gt | Ge | BinOp(Shr) | BinOpEq(Shr) => true, 310 | | _ => false, 311 | | } | |_________^ help: try this: `matches!(self, Gt | Ge | BinOp(Shr) | BinOpEq(Shr))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:349:9 | 349 | / match self.kind { 350 | | OpenDelim(..) | CloseDelim(..) | Literal(..) | DocComment(..) | Ident(..) 351 | | | Lifetime(..) | Interpolated(..) | Eof => false, 352 | | _ => true, 353 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 349 | !matches!(self.kind, OpenDelim(..) | CloseDelim(..) | Literal(..) | DocComment(..) | Ident(..) 350 | | Lifetime(..) | Interpolated(..) | Eof) | warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:357:9 | 357 | / match self.kind { 358 | | BinOp(Plus) | BinOpEq(Plus) => true, 359 | | _ => false, 360 | | } | |_________^ help: try this: `matches!(self.kind, BinOp(Plus) | BinOpEq(Plus))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:382:37 | 382 | Interpolated(ref nt) => match **nt { | _____________________________________^ 383 | | NtLiteral(..) | 384 | | NtExpr(..) | 385 | | NtBlock(..) | 386 | | NtPath(..) => true, 387 | | _ => false, 388 | | }, | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 382 | Interpolated(ref nt) => matches!(**nt, NtLiteral(..) | 383 | NtExpr(..) | 384 | NtBlock(..) | 385 | NtPath(..)), | warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:408:37 | 408 | Interpolated(ref nt) => match **nt { | _____________________________________^ 409 | | NtTy(..) | NtPath(..) => true, 410 | | _ => false, 411 | | }, | |_____________^ help: try this: `matches!(**nt, NtTy(..) | NtPath(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:420:37 | 420 | Interpolated(ref nt) => match **nt { | _____________________________________^ 421 | | NtExpr(..) | NtBlock(..) | NtLiteral(..) => true, 422 | | _ => false, 423 | | }, | |_____________^ help: try this: `matches!(**nt, NtExpr(..) | NtBlock(..) | NtLiteral(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_ast/src/token.rs:439:9 | 439 | / match self.kind { 440 | | Literal(..) => true, 441 | | _ => false, 442 | | } | |_________^ help: try this: `matches!(self.kind, Literal(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: usage of `Rc>` --> compiler/rustc_ast/src/tokenstream.rs:137:28 | 137 | pub struct LazyTokenStream(Lrc>); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc` | = note: `#[warn(clippy::redundant_allocation)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: usage of `Rc` when T is a buffer type --> compiler/rustc_ast/src/tokenstream.rs:180:35 | 180 | pub struct TokenStream(pub(crate) Lrc>); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[TreeAndSpacing]>` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: you should consider adding a `Default` implementation for `tokenstream::TokenStreamBuilder` --> compiler/rustc_ast/src/tokenstream.rs:361:5 | 361 | / pub fn new() -> TokenStreamBuilder { 362 | | TokenStreamBuilder(SmallVec::new()) 363 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 360 | impl Default for tokenstream::TokenStreamBuilder { 361 | fn default() -> Self { 362 | Self::new() 363 | } 364 | } | warning: 34 warnings emitted warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` --> compiler/rustc_lint_defs/src/lib.rs:66:5 | 66 | / pub fn from_str(x: &str) -> Option { 67 | | match x { 68 | | "allow" => Some(Level::Allow), 69 | | "warn" => Some(Level::Warn), ... | 73 | | } 74 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: implementation of inherent method `to_string(&self) -> String` for type `LintId` --> compiler/rustc_lint_defs/src/lib.rs:220:5 | 220 | / pub fn to_string(&self) -> String { 221 | | self.lint.name_lower() 222 | | } | |_____^ | = note: `#[warn(clippy::inherent_to_string)]` on by default = help: implement trait `Display` for type `LintId` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string warning: this function has too many arguments (8/7) --> compiler/rustc_ast_pretty/src/pprust/state.rs:104:1 | 104 | / pub fn print_crate<'a>( 105 | | sm: &'a SourceMap, 106 | | krate: &ast::Crate, 107 | | filename: FileName, ... | 112 | | has_injected_crate: bool, 113 | | ) -> String { | |___________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: 2 warnings emitted warning: this function has too many arguments (8/7) --> compiler/rustc_ast_pretty/src/pprust/state.rs:537:5 | 537 | / fn print_mac_common( 538 | | &mut self, 539 | | header: Option>, 540 | | has_bang: bool, ... | 545 | | span: Span, 546 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: method `into_iter` can be confused for the standard trait method `std::iter::IntoIterator::into_iter` --> compiler/rustc_hir/src/def.rs:307:5 | 307 | / pub fn into_iter(self) -> IntoIter { 308 | | IntoIter::new([self.value_ns, self.type_ns, self.macro_ns]) 309 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::iter::IntoIterator` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait warning: use of `unwrap_or` followed by a function call --> compiler/rustc_hir/src/definitions.rs:412:56 | 412 | self.expansions_that_defined.get(&id).copied().unwrap_or(ExpnId::root()) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(ExpnId::root)` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: you should consider adding a `Default` implementation for `pprust::state::State<'a>` --> compiler/rustc_ast_pretty/src/pprust/state.rs:868:5 | 868 | / pub fn new() -> State<'a> { 869 | | State { 870 | | s: pp::mk_printer(), 871 | | comments: None, ... | 875 | | } 876 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 867 | impl Default for pprust::state::State<'a> { 868 | fn default() -> Self { 869 | Self::new() 870 | } 871 | } | warning: you should consider adding a `Default` implementation for `diagnostic::DiagnosticStyledString` --> compiler/rustc_errors/src/diagnostic.rs:46:5 | 46 | / pub fn new() -> DiagnosticStyledString { 47 | | DiagnosticStyledString(vec![]) 48 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 45 | impl Default for diagnostic::DiagnosticStyledString { 46 | fn default() -> Self { 47 | Self::new() 48 | } 49 | } | warning: the variable `i` is used as a loop counter. --> compiler/rustc_ast_pretty/src/pprust/state.rs:900:9 | 900 | for elt in elts { | ^^^^^^^^^^^^^^^ help: consider using: `for (i, elt) in elts.into_iter().enumerate()` | = note: `#[warn(clippy::explicit_counter_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop warning: this function has too many arguments (8/7) --> compiler/rustc_errors/src/emitter.rs:628:5 | 628 | / fn draw_line( 629 | | &self, 630 | | buffer: &mut StyledBuffer, 631 | | source_string: &str, ... | 636 | | margin: Margin, 637 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> compiler/rustc_hir/src/hir.rs:372:9 | 372 | / match self { 373 | | &GenericBound::Trait(ref t, ..) => t.span, 374 | | &GenericBound::LangItemTrait(_, span, ..) => span, 375 | | &GenericBound::Outlives(ref l) => l.span, 376 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 372 | match *self { 373 | GenericBound::Trait(ref t, ..) => t.span, 374 | GenericBound::LangItemTrait(_, span, ..) => span, 375 | GenericBound::Outlives(ref l) => l.span, | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_ast_pretty/src/pprust/state.rs:1103:17 | 1103 | bounds: &ast::GenericBounds, | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_ast_pretty/src/pprust/state.rs:2519:5 | 2519 | / fn print_fn_full( 2520 | | &mut self, 2521 | | sig: &ast::FnSig, 2522 | | name: Ident, ... | 2527 | | attrs: &[ast::Attribute], 2528 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: `if` chain can be rewritten with `match` --> compiler/rustc_errors/src/emitter.rs:1472:25 | 1472 | / if line_idx_delta > 2 { 1473 | | let last_buffer_line_num = buffer.num_lines(); 1474 | | buffer.puts(last_buffer_line_num, 0, "...", Style::LineNumber); 1475 | | ... | 1512 | | } 1513 | | } | |_________________________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: you don't need to add `&` to all patterns --> compiler/rustc_hir/src/hir.rs:530:9 | 530 | / match self { 531 | | &WherePredicate::BoundPredicate(ref p) => p.span, 532 | | &WherePredicate::RegionPredicate(ref p) => p.span, 533 | | &WherePredicate::EqPredicate(ref p) => p.span, 534 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 530 | match *self { 531 | WherePredicate::BoundPredicate(ref p) => p.span, 532 | WherePredicate::RegionPredicate(ref p) => p.span, 533 | WherePredicate::EqPredicate(ref p) => p.span, | warning: 3 warnings emitted warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_ast_pretty/src/pprust/state.rs:2622:17 | 2622 | bounds: &ast::GenericBounds, | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: 7 warnings emitted warning: you don't need to add `&` to all patterns --> compiler/rustc_hir/src/intravisit.rs:871:5 | 871 | / match predicate { 872 | | &WherePredicate::BoundPredicate(WhereBoundPredicate { 873 | | ref bounded_ty, 874 | | bounds, ... | 892 | | } 893 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 871 | match *predicate { 872 | WherePredicate::BoundPredicate(WhereBoundPredicate { 873 | ref bounded_ty, 874 | bounds, 875 | bound_generic_params, 876 | .. ... warning: you should consider adding a `Default` implementation for `cgu_reuse_tracker::CguReuseTracker` --> compiler/rustc_session/src/cgu_reuse_tracker.rs:42:5 | 42 | / pub fn new() -> CguReuseTracker { 43 | | let data = 44 | | TrackerData { actual_reuse: Default::default(), expected_reuse: Default::default() }; 45 | | 46 | | CguReuseTracker { data: Some(Arc::new(Mutex::new(data))) } 47 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 41 | impl Default for cgu_reuse_tracker::CguReuseTracker { 42 | fn default() -> Self { 43 | Self::new() 44 | } 45 | } | warning: this function has too many arguments (8/7) --> compiler/rustc_session/src/code_stats.rs:54:5 | 54 | / pub fn record_type_size( 55 | | &self, 56 | | kind: DataTypeKind, 57 | | type_desc: S, ... | 62 | | mut variants: Vec, 63 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: returning the result of a `let` binding from a block --> compiler/rustc_query_system/src/dep_graph/dep_node.rs:83:9 | 74 | let dep_node = DepNode { kind, hash }; | -------------------------------------- unnecessary `let` binding ... 83 | dep_node | ^^^^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 74 | 75 | 76 | #[cfg(debug_assertions)] 77 | { 78 | if !kind.can_reconstruct_query_key() && tcx.debug_dep_node() { 79 | tcx.dep_graph().register_dep_node_debug_str(dep_node, || arg.to_debug_str(tcx)); ... warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name --> compiler/rustc_query_system/src/dep_graph/graph.rs:59:21 | 59 | pub fn is_green(self) -> bool { | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: item `config::OutputTypes` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_session/src/config.rs:352:1 | 352 | / impl OutputTypes { 353 | | pub fn new(entries: &[(OutputType, Option)]) -> OutputTypes { 354 | | OutputTypes(BTreeMap::from_iter(entries.iter().map(|&(k, ref v)| (k, v.clone())))) 355 | | } ... | 388 | | } 389 | | } | |_^ | = note: `#[warn(clippy::len_without_is_empty)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_session/src/filesearch.rs:79:23 | 79 | search_paths: &'a Vec, | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[SearchPath]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_query_system/src/dep_graph/graph.rs:228:40 | 228 | finish_task_and_alloc_depnode: fn( | ________________________________________^ 229 | | &CurrentDepGraph, 230 | | DepNode, 231 | | Fingerprint, 232 | | Option>, 233 | | ) -> DepNodeIndex, | |_________________________^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> compiler/rustc_session/src/session.rs:252:5 | 252 | fn into_diagnostic(self, sess: &'a Session) -> DiagnosticBuilder<'a>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::double_must_use)]` on by default = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use warning: this function has too many arguments (9/7) --> compiler/rustc_query_system/src/dep_graph/graph.rs:220:5 | 220 | / fn with_task_impl, A, R>( 221 | | &self, 222 | | key: DepNode, 223 | | cx: Ctxt, ... | 234 | | hash_result: impl FnOnce(&mut Ctxt::StableHashingContext, &R) -> Option, 235 | | ) -> (R, DepNodeIndex) { | |__________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: 4 warnings emitted warning: this `if` has identical blocks --> compiler/rustc_session/src/session.rs:825:56 | 825 | } else if self.target.options.requires_uwtable { | ________________________________________________________^ 826 | | true 827 | | } else { | |_________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_session/src/session.rs:823:59 | 823 | if self.panic_strategy() == PanicStrategy::Unwind { | ___________________________________________________________^ 824 | | true 825 | | } else if self.target.options.requires_uwtable { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: you should consider adding a `Default` implementation for `lang_items::LanguageItems` --> compiler/rustc_hir/src/lang_items.rs:84:13 | 39 | / macro_rules! language_item_table { 40 | | ( 41 | | $( $variant:ident $($group:expr)?, $name:expr, $method:ident, $target:expr; )* 42 | | ) => { ... | 84 | /| pub fn new() -> Self { 85 | || fn init_none(_: LangItem) -> Option { None } 86 | || 87 | || Self { ... || 91 | || } 92 | || } | ||_____________^ ... | 128 | | } 129 | | } | |_- in this expansion of `language_item_table!` ... 159 | / language_item_table! { 160 | | // Variant name, Name, Method name, Target; 161 | | Bool, sym::bool, bool_impl, Target::Impl; 162 | | Char, sym::char, char_impl, Target::Impl; ... | 332 | | RangeTo, sym::RangeTo, range_to_struct, Target::Struct; 333 | | } | |__- in this macro invocation | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 82 | impl Default for lang_items::LanguageItems { 83 | fn default() -> Self { 84 | Self::new() 85 | } 86 | } 87 | ... warning: use of `unwrap_or` followed by a function call --> compiler/rustc_session/src/session.rs:1308:30 | 1308 | let loader = file_loader.unwrap_or(Box::new(RealFileLoader)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Box::new(RealFileLoader))` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: 7 warnings emitted warning: all variants have the same postfix: `Parsed` --> compiler/rustc_parse/src/parser/expr.rs:62:1 | 62 | / pub(super) enum LhsExpr { 63 | | NotYetParsed, 64 | | AttributesParsed(AttrVec), 65 | | AlreadyParsed(P), 66 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> compiler/rustc_hir/src/lang_items.rs:114:32 | 39 | / macro_rules! language_item_table { 40 | | ( 41 | | $( $variant:ident $($group:expr)?, $name:expr, $method:ident, $target:expr; )* 42 | | ) => { ... | 114 | | pub fn $method(&self) -> Option { | | ^^^^^ ... | 128 | | } 129 | | } | |_- in this expansion of `language_item_table!` ... 159 | / language_item_table! { 160 | | // Variant name, Name, Method name, Target; 161 | | Bool, sym::bool, bool_impl, Target::Impl; 162 | | Char, sym::char, char_impl, Target::Impl; ... | 332 | | RangeTo, sym::RangeTo, range_to_struct, Target::Struct; 333 | | } | |_- in this macro invocation | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: this `if` has identical blocks --> compiler/rustc_attr/src/builtin.rs:251:94 | 251 | } else if meta_name == sym::rustc_const_unstable && const_stab.is_some() { | ______________________________________________________________________________________________^ 252 | | handle_errors( 253 | | &sess.parse_sess, 254 | | attr.span, ... | 257 | | break; 258 | | } | |_____________________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_attr/src/builtin.rs:244:69 | 244 | if meta_name == sym::unstable && stab.is_some() { | _____________________________________________________________________^ 245 | | handle_errors( 246 | | &sess.parse_sess, 247 | | attr.span, ... | 250 | | break; 251 | | } else if meta_name == sym::rustc_const_unstable && const_stab.is_some() { | |_____________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this `else { if .. }` block can be collapsed --> compiler/rustc_parse/src/parser/item.rs:1556:16 | 1556 | } else { | ________________^ 1557 | | if let Err(mut err) = 1558 | | self.expected_one_of_not_found(&[], &[token::Semi, token::OpenDelim(token::Brace)]) 1559 | | { ... | 1571 | | } 1572 | | }; | |_________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1556 | } else if let Err(mut err) = 1557 | self.expected_one_of_not_found(&[], &[token::Semi, token::OpenDelim(token::Brace)]) 1558 | { 1559 | if self.token.kind == token::CloseDelim(token::Brace) { 1560 | // The enclosing `mod`, `trait` or `impl` is being closed, so keep the `fn` in 1561 | // the AST for typechecking. ... warning: this `if` has identical blocks --> compiler/rustc_attr/src/builtin.rs:385:92 | 385 | } else if meta_name == sym::rustc_const_stable && const_stab.is_some() { | ____________________________________________________________________________________________^ 386 | | handle_errors( 387 | | &sess.parse_sess, 388 | | attr.span, ... | 391 | | break; 392 | | } | |_____________________^ | note: same as this --> compiler/rustc_attr/src/builtin.rs:378:67 | 378 | if meta_name == sym::stable && stab.is_some() { | ___________________________________________________________________^ 379 | | handle_errors( 380 | | &sess.parse_sess, 381 | | attr.span, ... | 384 | | break; 385 | | } else if meta_name == sym::rustc_const_stable && const_stab.is_some() { | |_____________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: 2 warnings emitted warning: this `if` statement can be collapsed --> compiler/rustc_parse/src/parser/path.rs:402:17 | 402 | / if !self.token.kind.should_end_const_arg() { 403 | | if self.handle_ambiguous_unbraced_const_arg(&mut args)? { 404 | | // We've managed to (partially) recover, so continue trying to parse 405 | | // arguments. 406 | | continue; 407 | | } 408 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 402 | if !self.token.kind.should_end_const_arg() && self.handle_ambiguous_unbraced_const_arg(&mut args)? { 403 | // We've managed to (partially) recover, so continue trying to parse 404 | // arguments. 405 | continue; 406 | } | warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> compiler/rustc_hir/src/lang_items.rs:114:32 | 39 | / macro_rules! language_item_table { 40 | | ( 41 | | $( $variant:ident $($group:expr)?, $name:expr, $method:ident, $target:expr; )* 42 | | ) => { ... | 114 | | pub fn $method(&self) -> Option { | | ^^^^^ ... | 128 | | } 129 | | } | |_- in this expansion of `language_item_table!` ... 159 | / language_item_table! { 160 | | // Variant name, Name, Method name, Target; 161 | | Bool, sym::bool, bool_impl, Target::Impl; 162 | | Char, sym::char, char_impl, Target::Impl; ... | 332 | | RangeTo, sym::RangeTo, range_to_struct, Target::Struct; 333 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: 8 warnings emitted warning: this `if` has identical blocks --> compiler/rustc_parse/src/parser/diagnostics.rs:304:93 | 304 | } else if !sm.is_multiline(self.token.span.shrink_to_hi().until(sp.shrink_to_lo())) { | _____________________________________________________________________________________________^ 305 | | // When the spans are in the same line, it means that the only content between 306 | | // them is whitespace, point at the found token in that case: 307 | | // ... | 317 | | err.span_label(self.token.span, label_exp); 318 | | } else { | |_________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_parse/src/parser/diagnostics.rs:300:45 | 300 | if self.prev_token.span == DUMMY_SP { | _____________________________________________^ 301 | | // Account for macro context where the previous span might not be 302 | | // available to avoid incorrect output (#54841). 303 | | err.span_label(self.token.span, label_exp); 304 | | } else if !sm.is_multiline(self.token.span.shrink_to_hi().until(sp.shrink_to_lo())) { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_parse/src/parser/diagnostics.rs:564:42 | 564 | if self.look_ahead(position, |t| { | __________________________________________^ 565 | | trace!("check_trailing_angle_brackets: t={:?}", t); 566 | | end.contains(&&t.kind) 567 | | }) { | |_________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: this `if` statement can be collapsed --> compiler/rustc_middle/src/hir/map/collector.rs:244:9 | 244 | / if cfg!(debug_assertions) { 245 | | if hir_id.owner != self.current_dep_node_owner { 246 | | let node_str = match self.definitions.opt_hir_id_to_local_def_id(hir_id) { 247 | | Some(def_id) => self.definitions.def_path(def_id).to_string_no_crate_verbose(), ... | 264 | | } 265 | | } | |_________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 244 | if cfg!(debug_assertions) && hir_id.owner != self.current_dep_node_owner { 245 | let node_str = match self.definitions.opt_hir_id_to_local_def_id(hir_id) { 246 | Some(def_id) => self.definitions.def_path(def_id).to_string_no_crate_verbose(), 247 | None => format!("{:?}", node), 248 | }; 249 | ... warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_parse/src/parser/diagnostics.rs:1159:42 | 1159 | } else if self.look_ahead(1, |t| { | __________________________________________^ 1160 | | t == &token::CloseDelim(token::Brace) || t.can_begin_expr() && t.kind != token::Colon 1161 | | }) && [token::Comma, token::Colon].contains(&self.token.kind) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: the variable `i` is used as a loop counter. --> compiler/rustc_hir_pretty/src/lib.rs:328:9 | 328 | for elt in elts { | ^^^^^^^^^^^^^^^ help: consider using: `for (i, elt) in elts.into_iter().enumerate()` | = note: `#[warn(clippy::explicit_counter_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop warning: redundant field names in struct initialization --> compiler/rustc_middle/src/hir/place.rs:81:13 | 81 | hir_id: hir_id, | ^^^^^^^^^^^^^^ help: replace it with: `hir_id` | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (8/7) --> compiler/rustc_ast_lowering/src/path.rs:212:5 | 212 | / crate fn lower_path_segment( 213 | | &mut self, 214 | | path_span: Span, 215 | | segment: &PathSegment, ... | 220 | | explicit_owner: Option, 221 | | ) -> hir::PathSegment<'hir> { | |_______________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_parse/src/parser/diagnostics.rs:1175:42 | 1175 | } else if self.look_ahead(0, |t| { | __________________________________________^ 1176 | | t == &token::CloseDelim(token::Brace) 1177 | | || ( 1178 | | t.can_begin_expr() && t != &token::Semi && t != &token::Pound 1179 | | // Avoid triggering with too many trailing `#` in raw string. 1180 | | ) 1181 | | }) { | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: redundant field names in struct initialization --> compiler/rustc_middle/src/hir/place.rs:82:28 | 82 | place: Place { base_ty: base_ty, base: base, projections: projections }, | ^^^^^^^^^^^^^^^^ help: replace it with: `base_ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this boolean expression contains a logic bug --> compiler/rustc_hir_pretty/src/lib.rs:1796:16 | 1796 | if infer_args && false { | ^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` | = note: `#[warn(clippy::logic_bug)]` on by default help: this expression can be optimized out by applying boolean operations to the outer expression --> compiler/rustc_hir_pretty/src/lib.rs:1796:16 | 1796 | if infer_args && false { | ^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug warning: unneeded `return` statement --> compiler/rustc_parse/src/parser/diagnostics.rs:1808:9 | 1808 | return Ok(false); // Don't continue. | ^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(false)` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: redundant field names in struct initialization --> compiler/rustc_middle/src/hir/place.rs:82:46 | 82 | place: Place { base_ty: base_ty, base: base, projections: projections }, | ^^^^^^^^^^ help: replace it with: `base` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (8/7) --> compiler/rustc_hir_pretty/src/lib.rs:2035:5 | 2035 | / pub fn print_fn( 2036 | | &mut self, 2037 | | decl: &hir::FnDecl<'_>, 2038 | | header: hir::FnHeader, ... | 2043 | | body_id: Option, 2044 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: redundant field names in struct initialization --> compiler/rustc_middle/src/hir/place.rs:82:58 | 82 | place: Place { base_ty: base_ty, base: base, projections: projections }, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projections` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: match expression looks like `matches!` macro --> compiler/rustc_parse/src/parser/path.rs:495:59 | 495 | ast::ExprKind::Unary(ast::UnOp::Neg, expr) => match &expr.kind { | ___________________________________________________________^ 496 | | ast::ExprKind::Lit(_) => true, 497 | | _ => false, 498 | | }, | |_____________^ help: try this: `matches!(&expr.kind, ast::ExprKind::Lit(_))` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this `if` statement can be collapsed --> compiler/rustc_middle/src/middle/stability.rs:361:17 | 361 | / if feature == sym::rustc_private && issue == NonZeroU32::new(27812) { 362 | | if self.sess.opts.debugging_opts.force_unstable_if_unmarked { 363 | | return EvalResult::Allow; 364 | | } 365 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 361 | if feature == sym::rustc_private && issue == NonZeroU32::new(27812) && self.sess.opts.debugging_opts.force_unstable_if_unmarked { 362 | return EvalResult::Allow; 363 | } | warning: implementation of inherent method `to_string(&self) -> String` for type `parser::TokenType` --> compiler/rustc_parse/src/parser/mod.rs:258:5 | 258 | / fn to_string(&self) -> String { 259 | | match *self { 260 | | TokenType::Token(ref t) => format!("`{}`", pprust::token_kind_to_string(t)), 261 | | TokenType::Keyword(kw) => format!("`{}`", kw), ... | 268 | | } 269 | | } | |_____^ | = note: `#[warn(clippy::inherent_to_string)]` on by default = help: implement trait `Display` for type `parser::TokenType` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string warning: 10 warnings emitted warning: you don't need to add `&` to all patterns --> compiler/rustc_hir_pretty/src/lib.rs:2224:13 | 2224 | / match predicate { 2225 | | &hir::WherePredicate::BoundPredicate(hir::WhereBoundPredicate { 2226 | | ref bound_generic_params, 2227 | | ref bounded_ty, ... | 2265 | | } 2266 | | } | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 2224 | match *predicate { 2225 | hir::WherePredicate::BoundPredicate(hir::WhereBoundPredicate { 2226 | ref bound_generic_params, 2227 | ref bounded_ty, 2228 | bounds, 2229 | .. ... warning: 4 warnings emitted warning: this `else { if .. }` block can be collapsed --> compiler/rustc_middle/src/mir/interpret/allocation.rs:374:16 | 374 | } else { | ________________^ 375 | | if let Some(&(tag, alloc_id)) = self.relocations.get(&ptr.offset) { 376 | | let ptr = Pointer::new_with_tag(alloc_id, Size::from_bytes(bits), tag); 377 | | return Ok(ScalarMaybeUninit::Scalar(ptr.into())); 378 | | } 379 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 374 | } else if let Some(&(tag, alloc_id)) = self.relocations.get(&ptr.offset) { 375 | let ptr = Pointer::new_with_tag(alloc_id, Size::from_bytes(bits), tag); 376 | return Ok(ScalarMaybeUninit::Scalar(ptr.into())); 377 | } | warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 55 | gate_feature_post!(&self, intrinsics, span, "intrinsics are subject to change"); | -------------------------------------------------------------------------------- in this macro invocation (#1) | = note: `#[warn(clippy::deref_addrof)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 58 | / gate_feature_post!( 59 | | &self, 60 | | platform_intrinsics, 61 | | span, 62 | | "platform intrinsics are experimental and possibly buggy" 63 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:610:65 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 610 | | fn allocate_on<'a>(self, arena: &'a Arena<'tcx>) -> &'a mut Self; | | ^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) | = note: `#[warn(clippy::mut_from_ref)]` on by default note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:610:45 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 610 | | fn allocate_on<'a>(self, arena: &'a Arena<'tcx>) -> &'a mut Self; | | ^^^^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 66 | / gate_feature_post!( 67 | | &self, 68 | | abi_vectorcall, 69 | | span, 70 | | "vectorcall is experimental and subject to change" 71 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 74 | / gate_feature_post!( 75 | | &self, 76 | | abi_thiscall, 77 | | span, 78 | | "thiscall is experimental and subject to change" 79 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: redundant field names in struct initialization --> compiler/rustc_middle/src/mir/visit.rs:309:47 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 309 | | let location = Location { block: block, statement_index: index }; | | ^^^^^^^^^^^^ help: replace it with: `block` ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1074 | make_mir_visitor!(Visitor,); | ---------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:614:18 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 614 | | ) -> &'a mut [Self]; | | ^^^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:612:24 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 612 | | arena: &'a Arena<'tcx>, | | ^^^^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 82 | / gate_feature_post!( 83 | | &self, 84 | | unboxed_closures, 85 | | span, 86 | | "rust-call ABI is subject to change" 87 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 90 | / gate_feature_post!( 91 | | &self, 92 | | abi_ptx, 93 | | span, 94 | | "PTX ABIs are experimental and subject to change" 95 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 98 | / gate_feature_post!( 99 | | &self, 100 | | abi_unadjusted, 101 | | span, 102 | | "unadjusted ABI is an implementation detail and perma-unstable" 103 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:666:79 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 666 | | pub fn alloc, U>(&self, value: T) -> &mut T { | | ^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:666:59 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 666 | | pub fn alloc, U>(&self, value: T) -> &mut T { | | ^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 106 | / gate_feature_post!( 107 | | &self, 108 | | abi_msp430_interrupt, 109 | | span, 110 | | "msp430-interrupt ABI is experimental and subject to change" 111 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: redundant field names in struct initialization --> compiler/rustc_middle/src/mir/visit.rs:315:47 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 315 | | let location = Location { block: block, statement_index: index }; | | ^^^^^^^^^^^^ help: replace it with: `block` ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1074 | make_mir_visitor!(Visitor,); | ---------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 114 | / gate_feature_post!( 115 | | &self, 116 | | abi_x86_interrupt, 117 | | span, 118 | | "x86-interrupt ABI is experimental and subject to change" 119 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 122 | / gate_feature_post!( 123 | | &self, 124 | | abi_amdgpu_kernel, 125 | | span, 126 | | "amdgpu-kernel ABI is experimental and subject to change" 127 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:671:79 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 671 | | pub fn alloc_slice(&self, value: &[T]) -> &mut [T] { | | ^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:671:56 | 600 | macro_rules! declare_arena { | ___- | |___| | | 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 671 | | pub fn alloc_slice(&self, value: &[T]) -> &mut [T] { | | ^^^^^ ^^^^ ... | 685 | | } 686 | | } | | - | |___| | |___in this expansion of `rustc_arena::declare_arena!` (#2) | in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- | | | in this macro invocation (#1) | in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | macro_rules! arena_types { | _- | |_| | | 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | _|_________- | |_|_________| | | | 14 | | | // HIR types 15 | | | [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | | | [] arm: rustc_hir::Arm<$tcx>, ... | | 49 | | | [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | | | ], $tcx); | | | - | |_|_________________| | |_|_________________in this macro invocation (#2) | | in this macro invocation (#2) 51 | | | ) 52 | | | } | | | - | | |_| | | |_in this expansion of `rustc_hir::arena_types!` (#1) | | in this expansion of `rustc_hir::arena_types!` (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 130 | / gate_feature_post!( 131 | | &self, 132 | | abi_avr_interrupt, 133 | | span, 134 | | "avr-interrupt and avr-non-blocking-interrupt ABIs are experimental and subject to change" 135 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 138 | / gate_feature_post!( 139 | | &self, 140 | | abi_efiapi, 141 | | span, 142 | | "efiapi ABI is experimental and subject to change" 143 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: redundant field names in struct initialization --> compiler/rustc_middle/src/mir/visit.rs:309:47 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 309 | | let location = Location { block: block, statement_index: index }; | | ^^^^^^^^^^^^ help: replace it with: `block` ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1075 | make_mir_visitor!(MutVisitor, mut); | ----------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 201 | / gate_feature_post!( 202 | | &self, 203 | | generic_associated_types, 204 | | span, 205 | | "generic associated types are unstable" 206 | | ); | |______________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:681:18 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 681 | | ) -> &'a mut [T] { | | ^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:679:17 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 679 | | &'a self, | | ^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_ast_lowering/src/lib.rs:84:1 | 84 | rustc_hir::arena_types!(rustc_arena::declare_arena, [], 'tcx); | -------------------------------------------------------------- in this macro invocation (#1) | ::: /home/nick/development/rust/rust/compiler/rustc_hir/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || // HIR types 15 | || [few] hir_krate: rustc_hir::Crate<$tcx>, 16 | || [] arm: rustc_hir::Arm<$tcx>, ... || 49 | || [] where_predicate: rustc_hir::WherePredicate<$tcx>, 50 | || ], $tcx); | ||_________________- in this macro invocation (#2) 51 | | ) 52 | | } | |_- in this expansion of `rustc_hir::arena_types!` (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_ast_lowering/src/lib.rs:855:63 | 855 | if self.lifetimes_to_define.iter().any(|(_, lt_name)| { | _______________________________________________________________^ 856 | | lt_name.normalize_to_macros_2_0() == hir_name.normalize_to_macros_2_0() 857 | | }) { | |_________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: 7 warnings emitted warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 209 | / gate_feature_post!( 210 | | &self, 211 | | generic_associated_types, 212 | | span, 213 | | "where clauses on associated types are unstable" 214 | | ); | |______________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self.vis` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 226 | / gate_feature_post!( 227 | | &self.vis, 228 | | type_alias_impl_trait, 229 | | ty.span, 230 | | "`impl Trait` in type aliases is unstable" 231 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 271 | / gate_feature_post!( 272 | | &self, 273 | | non_ascii_idents, 274 | | self.sess.parse_sess.source_map().guess_head_span(sp), 275 | | "non-ascii idents are not fully supported" 276 | | ); | |______________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: redundant field names in struct initialization --> compiler/rustc_middle/src/mir/visit.rs:315:47 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 315 | | let location = Location { block: block, statement_index: index }; | | ^^^^^^^^^^^^ help: replace it with: `block` ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1075 | make_mir_visitor!(MutVisitor, mut); | ----------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this `else { if .. }` block can be collapsed --> compiler/rustc_middle/src/ty/fold.rs:527:16 | 527 | } else { | ________________^ 528 | | if !ct.has_vars_bound_at_or_above(self.current_index) { 529 | | // Nothing more to substitute. 530 | | ct ... | 533 | | } 534 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 527 | } else if !ct.has_vars_bound_at_or_above(self.current_index) { 528 | // Nothing more to substitute. 529 | ct 530 | } else { 531 | ct.super_fold_with(self) 532 | } | warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 290 | / gate_feature_post!( 291 | | &self, 292 | | plugin_registrar, 293 | | i.span, 294 | | "compiler plugins are experimental and possibly buggy" 295 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: redundant field names in struct initialization --> compiler/rustc_middle/src/ty/layout.rs:1561:17 | 1561 | tag: tag, | ^^^^^^^^ help: replace it with: `tag` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this `else { if .. }` block can be collapsed --> compiler/rustc_middle/src/ty/layout.rs:2431:12 | 2431 | } else { | ____________^ 2432 | | if call_conv == Conv::Rust { 2433 | | // Any Rust method (or `extern "Rust" fn` or `extern 2434 | | // "rust-call" fn`) is explicitly allowed to unwind ... | 2455 | | } 2456 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 2431 | } else if call_conv == Conv::Rust { 2432 | // Any Rust method (or `extern "Rust" fn` or `extern 2433 | // "rust-call" fn`) is explicitly allowed to unwind 2434 | // (unless it has no-unwind attribute, handled above). 2435 | true 2436 | } else { ... warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 298 | / gate_feature_post!( 299 | | &self, 300 | | start, 301 | | i.span, ... | 304 | | over time" 305 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: this `if` statement can be collapsed --> compiler/rustc_middle/src/ty/layout.rs:2632:13 | 2632 | / if scalar.valid_range.start() < scalar.valid_range.end() { 2633 | | if *scalar.valid_range.start() > 0 { 2634 | | attrs.set(ArgAttribute::NonNull); 2635 | | } 2636 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 2632 | if scalar.valid_range.start() < scalar.valid_range.end() && *scalar.valid_range.start() > 0 { 2633 | attrs.set(ArgAttribute::NonNull); 2634 | } | warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 308 | / gate_feature_post!( 309 | | &self, 310 | | main, 311 | | i.span, ... | 314 | | a top-level `fn main()` is required" 315 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 323 | / gate_feature_post!( 324 | | &self, 325 | | repr_simd, 326 | | attr.span, 327 | | "SIMD types are experimental and possibly buggy" 328 | | ); | |______________________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 338 | (_, Some(disr_expr)) => gate_feature_post!( | _________________________________________________- 339 | | &self, 340 | | arbitrary_enum_discriminant, 341 | | disr_expr.value.span, 342 | | "discriminants on non-unit variants are experimental" 343 | | ), | |_________________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:610:65 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 610 | | fn allocate_on<'a>(self, arena: &'a Arena<'tcx>) -> &'a mut Self; | | ^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) | = note: `#[warn(clippy::mut_from_ref)]` on by default note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:610:45 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 610 | | fn allocate_on<'a>(self, arena: &'a Arena<'tcx>) -> &'a mut Self; | | ^^^^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 356 | / gate_feature_post!( 357 | | &self, 358 | | negative_impls, 359 | | span.to(of_trait.as_ref().map(|t| t.path.span).unwrap_or(span)), 360 | | "negative trait bounds are not yet fully implemented; \ 361 | | use marker types for now" 362 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 366 | gate_feature_post!(&self, specialization, i.span, "specialization is unstable"); | -------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 371 | / gate_feature_post!( 372 | | &self, 373 | | optin_builtin_traits, 374 | | i.span, 375 | | "auto traits are experimental and possibly buggy" 376 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:614:18 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 614 | | ) -> &'a mut [Self]; | | ^^^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:612:24 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 612 | | arena: &'a Arena<'tcx>, | | ^^^^^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 380 | gate_feature_post!(&self, trait_alias, i.span, "trait aliases are experimental"); | --------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 385 | gate_feature_post!(&self, decl_macro, i.span, msg); | --------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 405 | / gate_feature_post!( 406 | | &self, 407 | | link_llvm_intrinsics, 408 | | i.span, 409 | | "linking to LLVM intrinsics is experimental" 410 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:666:79 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 666 | | pub fn alloc, U>(&self, value: T) -> &mut T { | | ^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:666:59 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 666 | | pub fn alloc, U>(&self, value: T) -> &mut T { | | ^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 414 | gate_feature_post!(&self, extern_types, i.span, "extern types are experimental"); | --------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 428 | gate_feature_post!(&self, never_type, ty.span, "the `!` type is experimental"); | ------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 448 | / gate_feature_post!( 449 | | &self, 450 | | box_syntax, 451 | | e.span, 452 | | "box expression syntax is experimental; you can call `Box::new` instead" 453 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 459 | / gate_feature_post!( 460 | | &self, 461 | | type_ascription, 462 | | e.span, 463 | | "type ascription is experimental" 464 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:671:79 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 671 | | pub fn alloc_slice(&self, value: &[T]) -> &mut [T] { | | ^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:671:56 | 600 | macro_rules! declare_arena { | ___- | |___| | | 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 671 | | pub fn alloc_slice(&self, value: &[T]) -> &mut [T] { | | ^^^^^ ^^^^ ... | 685 | | } 686 | | } | | - | |___| | |___in this expansion of `rustc_arena::declare_arena!` (#2) | in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | macro_rules! arena_types { | _- | |_| | | 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | _|_________- | |_|_________| | | | 14 | | | [] layouts: rustc_target::abi::Layout, 15 | | | // AdtDef are interned and compared by address 16 | | | [] adt_def: rustc_middle::ty::AdtDef, ... | | 105 | | | [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | | | ], $tcx); | | | - | |_|_________________| | |_|_________________in this macro invocation (#2) | | in this macro invocation (#2) 107 | | | ) 108 | | | } | | | - | | |_| | | |_in this expansion of `arena_types!` (#1) | | in this expansion of `arena_types!` (#1) 109 | | 110 | | | arena_types!(rustc_arena::declare_arena, [], 'tcx); | | | --------------------------------------------------- | | | | | | | in this macro invocation (#1) | | | in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 468 | gate_feature_post!(&self, try_blocks, e.span, "`try` expression is experimental"); | ---------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 472 | / gate_feature_post!( 473 | | &self, 474 | | label_break_value, 475 | | label.ident.span, 476 | | "labels on blocks are unstable" 477 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 488 | / gate_feature_post!( 489 | | &self, 490 | | box_patterns, 491 | | pattern.span, 492 | | "box pattern syntax is experimental" 493 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: mutable borrow from immutable input(s) --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:681:18 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 681 | | ) -> &'a mut [T] { | | ^^^^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) | note: immutable borrow here --> /home/nick/development/rust/rust/compiler/rustc_arena/src/lib.rs:679:17 | 600 | / macro_rules! declare_arena { 601 | | ([], [$($a:tt $name:ident: $ty:ty,)*], $tcx:lifetime) => { 602 | | #[derive(Default)] 603 | | pub struct Arena<$tcx> { ... | 679 | | &'a self, | | ^^^^^^^^ ... | 685 | | } 686 | | } | |__- in this expansion of `rustc_arena::declare_arena!` (#2) | ::: compiler/rustc_middle/src/arena.rs:11:1 | 11 | / macro_rules! arena_types { 12 | | ($macro:path, $args:tt, $tcx:lifetime) => ( 13 | | $macro!($args, [ | |_________- 14 | || [] layouts: rustc_target::abi::Layout, 15 | || // AdtDef are interned and compared by address 16 | || [] adt_def: rustc_middle::ty::AdtDef, ... || 105 | || [decode] used_trait_imports: rustc_data_structures::fx::FxHashSet, 106 | || ], $tcx); | ||_________________- in this macro invocation (#2) 107 | | ) 108 | | } | |_- in this expansion of `arena_types!` (#1) 109 | 110 | arena_types!(rustc_arena::declare_arena, [], 'tcx); | --------------------------------------------------- in this macro invocation (#1) = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 496 | / gate_feature_post!( 497 | | &self, 498 | | exclusive_range_pattern, 499 | | pattern.span, 500 | | "exclusive range pattern syntax is experimental" 501 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/hir/map/blocks.rs:45:9 | 45 | / match self.kind { 46 | | hir::ItemKind::Fn(..) => true, 47 | | _ => false, 48 | | } | |_________^ help: try this: `matches!(self.kind, hir::ItemKind::Fn(..))` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/hir/map/blocks.rs:54:9 | 54 | / match self.kind { 55 | | hir::ImplItemKind::Fn(..) => true, 56 | | _ => false, 57 | | } | |_________^ help: try this: `matches!(self.kind, hir::ImplItemKind::Fn(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/hir/map/blocks.rs:63:9 | 63 | / match self.kind { 64 | | hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)) => true, 65 | | _ => false, 66 | | } | |_________^ help: try this: `matches!(self.kind, hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 516 | / gate_feature_post!( 517 | | &self, 518 | | const_extern_fn, 519 | | span, 520 | | "`const extern fn` definitions are unstable" 521 | | ); | |__________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/hir/map/blocks.rs:72:9 | 72 | / match self.kind { 73 | | hir::ExprKind::Closure(..) => true, 74 | | _ => false, 75 | | } | |_________^ help: try this: `matches!(self.kind, hir::ExprKind::Closure(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/hir/map/mod.rs:40:1 | 40 | fn fn_decl<'hir>(node: Node<'hir>) -> Option<&'hir FnDecl<'hir>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/hir/map/mod.rs:50:1 | 50 | fn fn_sig<'hir>(node: Node<'hir>) -> Option<&'hir FnSig<'hir>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 526 | gate_feature_post!(&self, c_variadic, span, "C-variadic functions are unstable"); | --------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/hir/map/mod.rs:59:1 | 59 | pub fn associated_body<'hir>(node: Node<'hir>) -> Option { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/hir/map/mod.rs:82:1 | 82 | fn is_body_owner<'hir>(node: Node<'hir>, hir_id: HirId) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/hir/map/mod.rs:974:1 | 974 | pub(super) fn index_hir<'tcx>(tcx: TyCtxt<'tcx>, cnum: CrateNum) -> &'tcx IndexedHir<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` ... 534 | / gate_feature_fn!( 535 | | &self, 536 | | |x: &Features| x.const_generics || x.min_const_generics, 537 | | param.ident.span, 538 | | sym::min_const_generics, 539 | | "const generics are unstable" 540 | | ); | |______________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: item `infer::canonical::CanonicalVarValues<'tcx>` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_middle/src/infer/canonical.rs:301:1 | 301 | / impl<'tcx> CanonicalVarValues<'tcx> { 302 | | pub fn len(&self) -> usize { 303 | | self.var_values.len() 304 | | } ... | 336 | | } 337 | | } | |_^ | = note: `#[warn(clippy::len_without_is_empty)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: usage of `Rc` when T is a buffer type --> compiler/rustc_middle/src/infer/mod.rs:31:25 | 31 | pub choice_regions: Lrc>>, | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[Region<'tcx>]>` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: you should consider adding a `Default` implementation for `lint::LintLevelSets` --> compiler/rustc_middle/src/lint.rs:69:5 | 69 | / pub fn new() -> Self { 70 | | LintLevelSets { list: Vec::new(), lint_cap: Level::Forbid } 71 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 68 | impl Default for lint::LintLevelSets { 69 | fn default() -> Self { 70 | Self::new() 71 | } 72 | } | warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 547 | / gate_feature_post!( 548 | | &self, 549 | | associated_type_bounds, 550 | | constraint.span, 551 | | "associated type bounds are unstable" 552 | | ) | |_____________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: you should consider adding a `Default` implementation for `middle::codegen_fn_attrs::CodegenFnAttrs` --> compiler/rustc_middle/src/middle/codegen_fn_attrs.rs:93:5 | 93 | / pub fn new() -> CodegenFnAttrs { 94 | | CodegenFnAttrs { 95 | | flags: CodegenFnAttrFlags::empty(), 96 | | inline: InlineAttr::None, ... | 106 | | } 107 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 92 | impl Default for middle::codegen_fn_attrs::CodegenFnAttrs { 93 | fn default() -> Self { 94 | Self::new() 95 | } 96 | } | warning: you should consider adding a `Default` implementation for `middle::cstore::EncodedMetadata` --> compiler/rustc_middle/src/middle/cstore.rs:155:5 | 155 | / pub fn new() -> EncodedMetadata { 156 | | EncodedMetadata { raw_data: Vec::new() } 157 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 154 | impl Default for middle::cstore::EncodedMetadata { 155 | fn default() -> Self { 156 | Self::new() 157 | } 158 | } | warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 561 | gate_feature_post!(&self, const_fn, i.span, "const fn is unstable"); | -------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/mir/coverage.rs:121:9 | 121 | / match self { 122 | | Self::Counter { .. } => true, 123 | | _ => false, 124 | | } | |_________^ help: try this: `matches!(self, Self::Counter { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/mir/coverage.rs:128:9 | 128 | / match self { 129 | | Self::Expression { .. } => true, 130 | | _ => false, 131 | | } | |_________^ help: try this: `matches!(self, Self::Expression { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: item `mir::interpret::allocation::Allocation` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_middle/src/mir/interpret/allocation.rs:151:1 | 151 | / impl Allocation { 152 | | pub fn len(&self) -> usize { 153 | | self.size.bytes_usize() 154 | | } ... | 172 | | } 173 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 567 | / gate_feature_post!( 568 | | &self, 569 | | associated_type_defaults, 570 | | i.span, 571 | | "associated type defaults are unstable" 572 | | ); | |______________________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_ub!(UnterminatedCString(ptr.erase_tag())).into())` 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/allocation.rs:298:21 | 298 | None => throw_ub!(UnterminatedCString(ptr.erase_tag())), | ----------------------------------------------- in this macro invocation | = note: `#[warn(clippy::try_err)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` ... 584 | / gate_feature_fn!( 585 | | &self, 586 | | |x: &Features| x.specialization || (is_fn && x.min_specialization), 587 | | i.span, 588 | | sym::specialization, 589 | | "specialization is unstable" 590 | | ); | |______________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:59:23 | 58 | / macro_rules! throw_unsup { 59 | | ($($tt:tt)*) => { Err::(err_unsup!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_unsup!(ReadPointerAsBytes).into())` 60 | | } | |_- in this expansion of `throw_unsup!` | ::: compiler/rustc_middle/src/mir/interpret/allocation.rs:477:13 | 477 | throw_unsup!(ReadPointerAsBytes) | -------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: immediately dereferencing a reference --> compiler/rustc_ast_passes/src/feature_gate.rs:19:15 | 16 | / macro_rules! gate_feature_fn { 17 | | ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{ 18 | | let (visitor, has_feature, span, name, explain) = 19 | | (&*$visitor, $has_feature, $span, $name, $explain); | | ^^^^^^^^^ help: try this: `self` ... | 26 | | }}; 27 | | } | |_- in this expansion of `gate_feature_fn!` (#2) 28 | 29 | / macro_rules! gate_feature_post { 30 | | ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => { 31 | | gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain) | | ------------------------------------------------------------------------------------- in this macro invocation (#2) 32 | | }; 33 | | } | |_- in this expansion of `gate_feature_post!` (#1) ... 597 | / gate_feature_post!( 598 | | &self, 599 | | crate_visibility_modifier, 600 | | vis.span, 601 | | "`crate` visibility modifier is experimental" 602 | | ); | |______________- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/allocation.rs:553:13 | 553 | / throw_ub!(InvalidUninitBytes(Some(Box::new(UninitBytesAccess { 554 | | access_ptr: ptr.erase_tag(), 555 | | access_size: size, 556 | | uninit_ptr: Pointer::new(ptr.alloc_id, idx_range.start), 557 | | uninit_size: idx_range.end - idx_range.start, // `Size` subtraction 558 | | })))) | |_________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 74 | ($($tt:tt)*) => { return Err(throw_ub!(InvalidUninitBytes(Some(Box::new(UninitBytesAccess { 75 | access_ptr: ptr.erase_tag(), 76 | access_size: size, 77 | uninit_ptr: Pointer::new(ptr.alloc_id, idx_range.start), 78 | uninit_size: idx_range.end - idx_range.start, // `Size` subtraction 79 | })))).into()) }; | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_ast_passes/src/ast_validation.rs:257:46 | 257 | fn no_questions_in_bounds(&self, bounds: &GenericBounds, where_: &str, is_trait: bool) { | ^^^^^^^^^^^^^^ | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: you should consider adding a `Default` implementation for `mir::interpret::allocation::Relocations` --> compiler/rustc_middle/src/mir/interpret/allocation.rs:667:5 | 667 | / pub fn new() -> Self { 668 | | Relocations(SortedMap::new()) 669 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 666 | impl Default for mir::interpret::allocation::Relocations { 667 | fn default() -> Self { 668 | Self::new() 669 | } 670 | } | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_ast_passes/src/ast_validation.rs:621:41 | 621 | fn deny_super_traits(&self, bounds: &GenericBounds, ident_span: Span) { | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_ub!(PointerArithOverflow).into())` 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/pointer.rs:74:19 | 74 | if over { throw_ub!(PointerArithOverflow) } else { Ok(res) } | ------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: you don't need to add `&` to all patterns --> compiler/rustc_ast_passes/src/ast_validation.rs:1230:9 | 1230 | / if let &WherePredicate::BoundPredicate(ref bound_predicate) = p { 1231 | | // A type binding, eg `for<'c> Foo: Send+Clone+'c` 1232 | | self.check_late_bound_lifetime_defs(&bound_predicate.bound_generic_params); 1233 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1230 | if let WherePredicate::BoundPredicate(ref bound_predicate) = *p { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_ub!(PointerArithOverflow).into())` 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/pointer.rs:80:19 | 80 | if over { throw_ub!(PointerArithOverflow) } else { Ok(res) } | ------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:330:9 | 330 | self, | ^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:347:16 | 347 | fn to_bits(self, target_size: Size) -> InterpResult<'tcx, u128> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_ast_passes/src/ast_validation.rs:1369:13 | 1369 | / match &path.segments[..] { 1370 | | [PathSegment { ident, args: None, .. }] => { 1371 | | for param in &generics.params { 1372 | | if param.ident == *ident { ... | 1426 | | _ => {} 1427 | | } | |_____________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1369 | if let [PathSegment { ident, args: None, .. }] = &path.segments[..] { 1370 | for param in &generics.params { 1371 | if param.ident == *ident { 1372 | let param = ident; 1373 | match &full_path.segments[qself.position..] { 1374 | [PathSegment { ident, .. }] => { ... warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:59:23 | 58 | / macro_rules! throw_unsup { 59 | | ($($tt:tt)*) => { Err::(err_unsup!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_unsup!(ReadPointerAsBytes).into())` 60 | | } | |_- in this expansion of `throw_unsup!` | ::: compiler/rustc_middle/src/mir/interpret/value.rs:357:31 | 357 | Scalar::Ptr(_) => throw_unsup!(ReadPointerAsBytes), | -------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:384:20 | 384 | pub fn is_bits(self) -> bool { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:390:19 | 390 | pub fn is_ptr(self) -> bool { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_ast_passes/src/ast_validation.rs:1374:29 | 1374 | / ... match &full_path.segments[qself.position..] { 1375 | | ... [PathSegment { ident, .. }] => { 1376 | | ... // Make a new `Path` from `foo::Bar` to `Foo`. 1377 | | ... let mut assoc_path = full_path.clone(); ... | 1421 | | ... _ => {} 1422 | | ... }; | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1374 | if let [PathSegment { ident, .. }] = &full_path.segments[qself.position..] { 1375 | // Make a new `Path` from `foo::Bar` to `Foo`. 1376 | let mut assoc_path = full_path.clone(); 1377 | // Remove `Bar` from `Foo::Bar`. 1378 | assoc_path.segments.pop(); 1379 | let len = assoc_path.segments.len() - 1; ... warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:394:20 | 394 | pub fn to_bool(self) -> InterpResult<'tcx, bool> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you should consider adding a `Default` implementation for `node_count::NodeCounter` --> compiler/rustc_ast_passes/src/node_count.rs:13:5 | 13 | / pub fn new() -> NodeCounter { 14 | | NodeCounter { count: 0 } 15 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 12 | impl Default for node_count::NodeCounter { 13 | fn default() -> Self { 14 | Self::new() 15 | } 16 | } | warning: 49 warnings emitted warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_ub!(InvalidBool(val)).into())` 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/value.rs:399:18 | 399 | _ => throw_ub!(InvalidBool(val)), | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:403:20 | 403 | pub fn to_char(self) -> InterpResult<'tcx, char> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_ub!(InvalidChar(val)).into())` 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/value.rs:407:21 | 407 | None => throw_ub!(InvalidChar(val)), | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:412:35 | 412 | fn to_unsigned_with_bit_width(self, bits: u64) -> InterpResult<'static, u128> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:418:18 | 418 | pub fn to_u8(self) -> InterpResult<'static, u8> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:423:19 | 423 | pub fn to_u16(self) -> InterpResult<'static, u16> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:428:19 | 428 | pub fn to_u32(self) -> InterpResult<'static, u32> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:433:19 | 433 | pub fn to_u64(self) -> InterpResult<'static, u64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_expand/src/proc_macro_server.rs:444:10 | 444 | ) -> Option> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:438:20 | 438 | pub fn to_u128(self) -> InterpResult<'static, u128> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:379:18 | 379 | fn make_expr(self: Box) -> Option> { | ^^^^ | = note: `#[warn(clippy::boxed_local)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:442:29 | 442 | pub fn to_machine_usize(self, cx: &impl HasDataLayout) -> InterpResult<'static, u64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:383:19 | 383 | fn make_items(self: Box) -> Option; 1]>> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:448:33 | 448 | fn to_signed_with_bit_width(self, bits: u64) -> InterpResult<'static, i128> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:388:24 | 388 | fn make_impl_items(self: Box) -> Option; 1]>> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:455:18 | 455 | pub fn to_i8(self) -> InterpResult<'static, i8> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:393:25 | 393 | fn make_trait_items(self: Box) -> Option; 1]>> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:460:19 | 460 | pub fn to_i16(self) -> InterpResult<'static, i16> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:398:27 | 398 | fn make_foreign_items(self: Box) -> Option; 1]>> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:465:19 | 465 | pub fn to_i32(self) -> InterpResult<'static, i32> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:403:17 | 403 | fn make_pat(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:470:19 | 470 | pub fn to_i64(self) -> InterpResult<'static, i64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:415:16 | 415 | fn make_ty(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:475:20 | 475 | pub fn to_i128(self) -> InterpResult<'static, i128> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:419:18 | 419 | fn make_arms(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:479:29 | 479 | pub fn to_machine_isize(self, cx: &impl HasDataLayout) -> InterpResult<'static, i64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:423:20 | 423 | fn make_fields(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:487:19 | 487 | pub fn to_f32(self) -> InterpResult<'static, Single> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:427:28 | 427 | fn make_field_patterns(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:493:19 | 493 | pub fn to_f64(self) -> InterpResult<'static, Double> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:431:28 | 431 | fn make_generic_params(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:435:20 | 435 | fn make_params(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_middle/src/mir/interpret/mod.rs:74:23 | 73 | / macro_rules! throw_ub { 74 | | ($($tt:tt)*) => { Err::(err_ub!($($tt)*))? }; | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `return Err(throw_ub!(InvalidUninitBytes(None)).into())` 75 | | } | |_- in this expansion of `throw_ub!` | ::: compiler/rustc_middle/src/mir/interpret/value.rs:565:42 | 565 | ScalarMaybeUninit::Uninit => throw_ub!(InvalidUninitBytes(None)), | ----------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:439:27 | 439 | fn make_struct_fields(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: local variable doesn't need to be boxed here --> compiler/rustc_expand/src/base.rs:443:22 | 443 | fn make_variants(self: Box) -> Option> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:570:20 | 570 | pub fn to_bool(self) -> InterpResult<'tcx, bool> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:575:20 | 575 | pub fn to_char(self) -> InterpResult<'tcx, char> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:580:19 | 580 | pub fn to_f32(self) -> InterpResult<'tcx, Single> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:585:19 | 585 | pub fn to_f64(self) -> InterpResult<'tcx, Double> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: large size difference between variants --> compiler/rustc_expand/src/expand.rs:278:5 | 278 | / Attr { 279 | | attr: ast::Attribute, 280 | | item: Annotatable, 281 | | // Required for resolving derive helper attributes. ... | 284 | | after_derive: bool, 285 | | }, | |_____^ this variant is 281 bytes | = note: `#[warn(clippy::large_enum_variant)]` on by default note: and the second-largest variant is 72 bytes: --> compiler/rustc_expand/src/expand.rs:274:5 | 274 | / Bang { 275 | | mac: ast::MacCall, 276 | | span: Span, 277 | | }, | |_____^ help: consider boxing the large fields to reduce the total size of the enum --> compiler/rustc_expand/src/expand.rs:278:5 | 278 | / Attr { 279 | | attr: ast::Attribute, 280 | | item: Annotatable, 281 | | // Required for resolving derive helper attributes. ... | 284 | | after_derive: bool, 285 | | }, | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:590:18 | 590 | pub fn to_u8(self) -> InterpResult<'tcx, u8> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:595:19 | 595 | pub fn to_u16(self) -> InterpResult<'tcx, u16> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: `if` chain can be rewritten with `match` --> compiler/rustc_expand/src/mbe/macro_parser.rs:652:13 | 652 | / if eof_items.len() == 1 { 653 | | let matches = 654 | | eof_items[0].matches.iter_mut().map(|dv| Lrc::make_mut(dv).pop().unwrap()); 655 | | return nameize(parser.sess, ms, matches); ... | 672 | | ); 673 | | } | |_____________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:600:19 | 600 | pub fn to_u32(self) -> InterpResult<'tcx, u32> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:605:19 | 605 | pub fn to_u64(self) -> InterpResult<'tcx, u64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: this function has too many arguments (8/7) --> compiler/rustc_expand/src/mbe/macro_rules.rs:211:1 | 211 | / fn generic_extension<'cx>( 212 | | cx: &'cx mut ExtCtxt<'_>, 213 | | sp: Span, 214 | | def_span: Span, ... | 219 | | rhses: &[mbe::TokenTree], 220 | | ) -> Box { | |_____________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:610:29 | 610 | pub fn to_machine_usize(self, cx: &impl HasDataLayout) -> InterpResult<'tcx, u64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:615:18 | 615 | pub fn to_i8(self) -> InterpResult<'tcx, i8> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:620:19 | 620 | pub fn to_i16(self) -> InterpResult<'tcx, i16> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: avoid using `collect()` when not needed --> compiler/rustc_expand/src/mbe/macro_rules.rs:278:17 | 278 | / let rhs_spans = rhs.iter().map(|t| t.span()).collect::>(); 279 | | // rhs has holes ( `$id` and `$(...)` that need filled) 280 | | let mut tts = match transcribe(cx, &named_matches, rhs, transparency) { 281 | | Ok(tts) => tts, ... | 289 | | // proper positions in error reporting, while maintaining the macro_backtrace. 290 | | if rhs_spans.len() == tts.len() { | |___________________^ | = note: `#[warn(clippy::needless_collect)]` on by default help: Take the original Iterator's count instead of collecting it and finding the length | 278 | 279 | // rhs has holes ( `$id` and `$(...)` that need filled) 280 | let mut tts = match transcribe(cx, &named_matches, rhs, transparency) { 281 | Ok(tts) => tts, 282 | Err(mut err) => { 283 | err.emit(); ... warning: 19 warnings emitted warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:625:19 | 625 | pub fn to_i32(self) -> InterpResult<'tcx, i32> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:630:19 | 630 | pub fn to_i64(self) -> InterpResult<'tcx, i64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_middle/src/mir/interpret/value.rs:635:29 | 635 | pub fn to_machine_isize(self, cx: &impl HasDataLayout) -> InterpResult<'tcx, i64> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: length comparison to zero --> compiler/rustc_middle/src/mir/interpret/mod.rs:570:19 | 570 | debug_assert!(target.len() == 0); // We should have filled the target buffer. | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` | = note: `#[warn(clippy::len_zero)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: read amount is not handled. Use `Read::read_exact` instead --> compiler/rustc_middle/src/mir/interpret/mod.rs:581:13 | 581 | source.read(&mut buf)?; | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::unused_io_amount)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount warning: read amount is not handled. Use `Read::read_exact` instead --> compiler/rustc_middle/src/mir/interpret/mod.rs:585:13 | 585 | source.read(&mut buf[16 - source.len()..])?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount warning: this `else { if .. }` block can be collapsed --> compiler/rustc_builtin_macros/src/asm.rs:208:16 | 208 | } else { | ________________^ 209 | | if !args.named_args.is_empty() || !args.reg_args.is_empty() { 210 | | let mut err = ecx.struct_span_err( 211 | | span, ... | 223 | | } 224 | | } | |_________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 208 | } else if !args.named_args.is_empty() || !args.reg_args.is_empty() { 209 | let mut err = ecx.struct_span_err( 210 | span, 211 | "positional arguments cannot follow named arguments \ 212 | or explicit register arguments", 213 | ); ... warning: length comparison to zero --> compiler/rustc_middle/src/mir/interpret/mod.rs:589:19 | 589 | debug_assert!(source.len() == 0); // We should have consumed the source buffer. | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `source.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: variant name starts with the enum's name --> compiler/rustc_builtin_macros/src/llvm_asm.rs:22:5 | 22 | StateNone, | ^^^^^^^^^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_middle/src/mir/query.rs:171:37 | 171 | struct MapPrinter<'a, K, V>(Cell + 'a>>>); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: match expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/deriving/clone.rs:41:51 | 41 | && !params.iter().any(|param| match param.kind { | ___________________________________________________^ 42 | | ast::GenericParamKind::Type { .. } => true, 43 | | _ => false, 44 | | }) | |_____________________^ help: try this: `matches!(param.kind, ast::GenericParamKind::Type { .. })` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this loop could be written as a `while let` loop --> compiler/rustc_middle/src/mir/traversal.rs:176:9 | 176 | / loop { 177 | | let bb = if let Some(&mut (_, ref mut iter)) = self.visit_stack.last_mut() { 178 | | if let Some(&bb) = iter.next() { 179 | | bb ... | 191 | | } 192 | | } | |_________^ help: try: `while let Some(&mut (_, ref mut iter)) = self.visit_stack.last_mut() { .. }` | = note: `#[warn(clippy::while_let_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_builtin_macros/src/deriving/hash.rs:51:22 | 51 | let state_expr = match &substr.nonself_args { | ______________________^ 52 | | &[o_f] => o_f, 53 | | _ => cx.span_bug(trait_span, "incorrect number of arguments in `derive(Hash)`"), 54 | | }; | |_____^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 51 | let state_expr = match substr.nonself_args { 52 | [o_f] => o_f, | warning: `Vec` is already on the heap, the boxing is unnecessary. --> compiler/rustc_builtin_macros/src/deriving/generic/ty.rs:30:13 | 30 | params: Vec>, | ^^^^^^^^^^^^ help: try: `Vec` | = note: `#[warn(clippy::vec_box)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box warning: `Vec` is already on the heap, the boxing is unnecessary. --> compiler/rustc_builtin_macros/src/deriving/generic/ty.rs:51:17 | 51 | params: Vec>, | ^^^^^^^^^^^^ help: try: `Vec` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:391:9 | 391 | / match *item { 392 | | Annotatable::Item(ref item) => { 393 | | let is_packed = item.attrs.iter().any(|attr| { 394 | | for r in attr::find_repr_attrs(&cx.sess, attr) { ... | 483 | | } 484 | | } | |_________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 391 | if let Annotatable::Item(ref item) = *item { 392 | let is_packed = item.attrs.iter().any(|attr| { 393 | for r in attr::find_repr_attrs(&cx.sess, attr) { 394 | if let attr::ReprPacked(_) = r { 395 | return true; 396 | } ... warning: match expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:405:61 | 405 | !generics.params.iter().any(|param| match param.kind { | _____________________________________________________________^ 406 | | ast::GenericParamKind::Type { .. } => true, 407 | | _ => false, 408 | | }) | |_________________________^ help: try this: `matches!(param.kind, ast::GenericParamKind::Type { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this `.filter_map` can be written more simply using `.filter` --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:609:33 | 609 | let mut ty_params = params | _________________________________^ 610 | | .iter() 611 | | .filter_map(|param| match param.kind { 612 | | ast::GenericParamKind::Type { .. } => Some(param), 613 | | _ => None, 614 | | }) | |__________________^ | = note: `#[warn(clippy::unnecessary_filter_map)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:854:10 | 854 | ) -> (Option, Vec>, Vec>, Vec<(Ident, P)>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: if let .. else expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:882:35 | 882 | Ptr(ref ty, _) if (if let Self_ = **ty { true } else { false }) && nonstatic => { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches!(**ty, Self_)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (8/7) --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:894:5 | 894 | / fn create_method( 895 | | &self, 896 | | cx: &mut ExtCtxt<'_>, 897 | | trait_: &TraitDef<'_>, ... | 902 | | body: P, 903 | | ) -> P { | |__________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:986:5 | 986 | / fn expand_struct_method_body<'b>( 987 | | &self, 988 | | cx: &mut ExtCtxt<'_>, 989 | | trait_: &TraitDef<'b>, ... | 994 | | use_temporaries: bool, 995 | | ) -> P { | |________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:1570:10 | 1570 | ) -> (P, Vec<(Span, Option, P, &'a [ast::Attribute])>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_builtin_macros/src/deriving/generic/mod.rs:1621:10 | 1621 | ) -> (P, Vec<(Span, Option, P, &'a [ast::Attribute])>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_builtin_macros/src/format.rs:128:6 | 128 | ) -> Result<(P, Vec>, FxHashMap), DiagnosticBuilder<'a>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: match expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/format.rs:1047:37 | 1047 | parse::NextArgument(arg) => match arg.position { | _____________________________________^ 1048 | | parse::Position::ArgumentIs(_) => true, 1049 | | _ => false, 1050 | | }, | |_________^ help: try this: `matches!(arg.position, parse::Position::ArgumentIs(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. --> compiler/rustc_middle/src/mir/visit.rs:858:17 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 858 | | drop(user_ty); // no visit method for this | | ^^^^^^^^^^^^^ ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1074 | make_mir_visitor!(Visitor,); | ---------------------------- in this macro invocation | = note: `#[warn(clippy::drop_ref)]` on by default note: argument has type `&std::option::Option` --> compiler/rustc_middle/src/mir/visit.rs:858:22 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 858 | | drop(user_ty); // no visit method for this | | ^^^^^^^ ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1074 | make_mir_visitor!(Visitor,); | ---------------------------- in this macro invocation = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref warning: calls to `std::mem::drop` with a value that implements `Copy`. Dropping a copy leaves the original intact. --> compiler/rustc_builtin_macros/src/format_foreign.rs:538:13 | 538 | drop(c); | ^^^^^^^ | = note: `#[warn(clippy::drop_copy)]` on by default note: argument has type char --> compiler/rustc_builtin_macros/src/format_foreign.rs:538:18 | 538 | drop(c); | ^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy warning: calls to `std::mem::drop` with a value that implements `Copy`. Dropping a copy leaves the original intact. --> compiler/rustc_builtin_macros/src/format_foreign.rs:545:9 | 545 | drop(c); | ^^^^^^^ | note: argument has type char --> compiler/rustc_builtin_macros/src/format_foreign.rs:545:14 | 545 | drop(c); | ^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy warning: calls to `std::mem::drop` with a value that implements `Copy`. Dropping a copy leaves the original intact. --> compiler/rustc_builtin_macros/src/format_foreign.rs:546:9 | 546 | drop(next); | ^^^^^^^^^^ | note: argument has type format_foreign::strcursor::StrCursor --> compiler/rustc_builtin_macros/src/format_foreign.rs:546:14 | 546 | drop(next); | ^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy warning: match expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/format_foreign.rs:583:9 | 583 | / match c { 584 | | '0' | '-' | '+' | ' ' | '#' | '\'' => true, 585 | | _ => false, 586 | | } | |_________^ help: try this: `matches!(c, '0' | '-' | '+' | ' ' | '#' | '\'')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: returning the result of a `let` binding from a block --> compiler/rustc_builtin_macros/src/global_allocator.rs:120:17 | 119 | let layout = self.cx.expr_call(self.span, layout_new, vec![size, align]); | ------------------------------------------------------------------------- unnecessary `let` binding 120 | layout | ^^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 119 | 120 | self.cx.expr_call(self.span, layout_new, vec![size, align]) | warning: use of `unwrap_or` followed by a function call --> compiler/rustc_builtin_macros/src/llvm_asm.rs:94:10 | 94 | .unwrap_or(tts.len()); | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| tts.len())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: match expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/llvm_asm.rs:90:24 | 90 | .position(|tt| match tt { | ________________________^ 91 | | tokenstream::TokenTree::Token(Token { kind: token::Colon | token::ModSep, .. }) => true, 92 | | _ => false, 93 | | }) | |_________^ help: try this: `matches!(tt, tokenstream::TokenTree::Token(Token { kind: token::Colon | token::ModSep, .. }))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (8/7) --> compiler/rustc_builtin_macros/src/proc_macro_harness.rs:53:1 | 53 | / pub fn inject( 54 | | sess: &Session, 55 | | resolver: &mut dyn ResolverExpand, 56 | | mut krate: ast::Crate, ... | 61 | | handler: &rustc_errors::Handler, 62 | | ) -> ast::Crate { | |_______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: match expression looks like `matches!` macro --> compiler/rustc_builtin_macros/src/proc_macro_harness.rs:259:21 | 259 | let is_fn = match item.kind { | _____________________^ 260 | | ast::ItemKind::Fn(..) => true, 261 | | _ => false, 262 | | }; | |_________^ help: try this: `matches!(item.kind, ast::ItemKind::Fn(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: needless `fn main` in doctest --> compiler/rustc_builtin_macros/src/test_harness.rs:255:4 | 255 | /// #[main] | ^^^^^^^^ | = note: `#[warn(clippy::needless_doctest_main)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: use of `unwrap_or` followed by a function call --> compiler/rustc_builtin_macros/src/test_harness.rs:293:10 | 293 | .unwrap_or(ecx.path(sp, vec![test_id, Ident::from_str_and_span(runner_name, sp)])); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ecx.path(sp, vec![test_id, Ident::from_str_and_span(runner_name, sp)]))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: 28 warnings emitted warning: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. --> compiler/rustc_middle/src/mir/visit.rs:858:17 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 858 | | drop(user_ty); // no visit method for this | | ^^^^^^^^^^^^^ ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1075 | make_mir_visitor!(MutVisitor, mut); | ----------------------------------- in this macro invocation | note: argument has type `&mut std::option::Option` --> compiler/rustc_middle/src/mir/visit.rs:858:22 | 68 | / macro_rules! make_mir_visitor { 69 | | ($visitor_trait_name:ident, $($mutability:ident)?) => { 70 | | pub trait $visitor_trait_name<'tcx> { 71 | | // Override these, and call `self.super_xxx` to revert back to the ... | 858 | | drop(user_ty); // no visit method for this | | ^^^^^^^ ... | 925 | | } 926 | | } | |_- in this expansion of `make_mir_visitor!` ... 1075 | make_mir_visitor!(MutVisitor, mut); | ----------------------------------- in this macro invocation = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref warning: this function has too many arguments (9/7) --> compiler/rustc_middle/src/mir/mod.rs:233:5 | 233 | / pub fn new( 234 | | source: MirSource<'tcx>, 235 | | basic_blocks: IndexVec>, 236 | | source_scopes: IndexVec>, ... | 242 | | generator_kind: Option, 243 | | ) -> Self { | |_____________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: usage of `Rc` when T is a buffer type --> compiler/rustc_middle/src/traits/query.rs:209:16 | 209 | pub steps: Lrc>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[CandidateStep<'tcx>]>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: you should consider adding a `Default` implementation for `traits::specialization_graph::Graph` --> compiler/rustc_middle/src/traits/specialization_graph.rs:40:5 | 40 | / pub fn new() -> Graph { 41 | | Graph { parent: Default::default(), children: Default::default(), has_errored: false } 42 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 39 | impl Default for traits::specialization_graph::Graph { 40 | fn default() -> Self { 41 | Self::new() 42 | } 43 | } | warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/traits/specialization_graph.rs:221:1 | 221 | / pub fn ancestors( 222 | | tcx: TyCtxt<'tcx>, 223 | | trait_def_id: DefId, 224 | | start_from_impl: DefId, 225 | | ) -> Result, ErrorReported> { | |___________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/ty/error.rs:650:30 | 650 | let callable_scope = match body_owner { | ______________________________^ 651 | | Some( 652 | | hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn(..), .. }) 653 | | | hir::Node::TraitItem(hir::TraitItem { kind: hir::TraitItemKind::Fn(..), .. }) ... | 656 | | _ => false, 657 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 650 | let callable_scope = matches!(body_owner, Some( 651 | hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn(..), .. }) 652 | | hir::Node::TraitItem(hir::TraitItem { kind: hir::TraitItemKind::Fn(..), .. }) 653 | | hir::Node::ImplItem(hir::ImplItem { kind: hir::ImplItemKind::Fn(..), .. }), 654 | )); | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_middle/src/ty/error.rs:814:21 | 814 | / match item.kind { 815 | | hir::AssocItemKind::Type => { 816 | | // FIXME: account for returning some type in a trait fn impl that has 817 | | // an assoc type as a return type (#72076). ... | 830 | | _ => {} 831 | | } | |_____________________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 814 | if let hir::AssocItemKind::Type = item.kind { 815 | // FIXME: account for returning some type in a trait fn impl that has 816 | // an assoc type as a return type (#72076). 817 | if let hir::Defaultness::Default { has_value: true } = item.defaultness 818 | { 819 | if self.type_of(self.hir().local_def_id(item.id.hir_id)) == found { ... warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/flags.rs:38:9 | 38 | self.flags = self.flags | flags; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.flags |= flags` | = note: `#[warn(clippy::assign_op_pattern)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: returning the result of a `let` binding from a block --> compiler/rustc_middle/src/ty/layout.rs:2257:37 | 2255 | / ... let field_info = 2256 | | ... field.pointee_info_at(cx, offset - field_start); | |__________________________________________________________________________- unnecessary `let` binding 2257 | ... field_info | ^^^^^^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 2255 | 2256 | field.pointee_info_at(cx, offset - field_start) | warning: this if-then-else expression returns a bool literal --> compiler/rustc_middle/src/ty/layout.rs:2432:9 | 2432 | / if call_conv == Conv::Rust { 2433 | | // Any Rust method (or `extern "Rust" fn` or `extern 2434 | | // "rust-call" fn`) is explicitly allowed to unwind 2435 | | // (unless it has no-unwind attribute, handled above). ... | 2454 | | false 2455 | | } | |_________^ help: you can reduce it to: `call_conv == Conv::Rust` | = note: `#[warn(clippy::needless_bool)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool warning: usage of `Box<&T>` --> compiler/rustc_middle/src/ty/print/pretty.rs:1237:31 | 1237 | pub name_resolver: Option Option>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn Fn(ty::sty::TyVid) -> Option` | = note: `#[warn(clippy::redundant_allocation)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_middle/src/ty/print/pretty.rs:1715:10 | 1715 | ) -> Result<(Self, (T, BTreeMap>)), fmt::Error> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: unneeded `return` statement --> compiler/rustc_middle/src/ty/print/mod.rs:292:13 | 292 | return None; | ^^^^^^^^^^^^ help: remove `return`: `None` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_middle/src/ty/query/plumbing.rs:43:10 | 43 | ) -> Option, QueryJobInfo>> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: mutable key type --> compiler/rustc_middle/src/ty/query/on_disk_cache.rs:188:17 | 188 | / let mut file_to_file_index = 189 | | FxHashMap::with_capacity_and_hasher(files.len(), Default::default()); | |_________________________________________________________________________________________^ | = note: `#[warn(clippy::mutable_key_type)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type warning: sub-expression diverges --> compiler/rustc_middle/src/ty/query/on_disk_cache.rs:965:50 | 965 | ((self.0 >> (i * 8)) as u8).encode(e)?; | ^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you should consider adding a `Default` implementation for `ty::query::profiling_support::QueryKeyStringCache` --> compiler/rustc_middle/src/ty/query/profiling_support.rs:17:5 | 17 | / pub fn new() -> QueryKeyStringCache { 18 | | QueryKeyStringCache { def_id_cache: Default::default() } 19 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 16 | impl Default for ty::query::profiling_support::QueryKeyStringCache { 17 | fn default() -> Self { 18 | Self::new() 19 | } 20 | } | warning: this function has too many arguments (12/7) --> compiler/rustc_middle/src/ty/context.rs:1071:5 | 1071 | / pub fn create_global_ctxt( 1072 | | s: &'tcx Session, 1073 | | lint_store: Lrc, 1074 | | local_providers: ty::query::Providers, ... | 1083 | | output_filenames: &OutputFilenames, 1084 | | ) -> GlobalCtxt<'tcx> { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_middle/src/ty/context.rs:1482:9 | 1482 | / match self.hir().get(hir_id) { 1483 | | Node::Item(item) => { 1484 | | match item.kind { 1485 | | ItemKind::Fn(..) => { /* `type_of_def_id()` will work */ } ... | 1491 | | _ => { /* `type_of_def_id()` will work or panic */ } 1492 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1482 | if let Node::Item(item) = self.hir().get(hir_id) { 1483 | match item.kind { 1484 | ItemKind::Fn(..) => { /* `type_of_def_id()` will work */ } 1485 | _ => { 1486 | return None; 1487 | } ... warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_middle/src/ty/context.rs:1983:5 | 1983 | fn borrow<'a>(&'a self) -> &'a [T] { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: length comparison to zero --> compiler/rustc_middle/src/ty/diagnostics.rs:218:16 | 218 | && generics.where_clause.predicates.len() == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `generics.where_clause.predicates.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_middle/src/ty/diagnostics.rs:248:13 | 248 | / match ¶m_spans[..] { 249 | | &[¶m_span] => suggest_restrict(param_span.shrink_to_hi()), 250 | | _ => { 251 | | err.span_suggestion_verbose( ... | 257 | | } 258 | | } | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 248 | match param_spans[..] { 249 | [¶m_span] => suggest_restrict(param_span.shrink_to_hi()), | warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/ty/sty.rs:208:9 | 208 | / match self { 209 | | Bool | Char | Int(_) | Uint(_) | Float(_) => true, 210 | | _ => false, 211 | | } | |_________^ help: try this: `matches!(self, Bool | Char | Int(_) | Uint(_) | Float(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/ty/sty.rs:1696:9 | 1696 | / match *self { 1697 | | ty::ReLateBound(..) => true, 1698 | | _ => false, 1699 | | } | |_________^ help: try this: `matches!(*self, ty::ReLateBound(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_middle/src/ty/sty.rs:1703:9 | 1703 | / match *self { 1704 | | ty::RePlaceholder(..) => true, 1705 | | _ => false, 1706 | | } | |_________^ help: try this: `matches!(*self, ty::RePlaceholder(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1750:17 | 1750 | flags = flags | TypeFlags::HAS_FREE_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1751:17 | 1751 | flags = flags | TypeFlags::HAS_FREE_LOCAL_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_LOCAL_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1752:17 | 1752 | flags = flags | TypeFlags::HAS_RE_INFER; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_RE_INFER` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1755:17 | 1755 | flags = flags | TypeFlags::HAS_FREE_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1756:17 | 1756 | flags = flags | TypeFlags::HAS_FREE_LOCAL_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_LOCAL_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1757:17 | 1757 | flags = flags | TypeFlags::HAS_RE_PLACEHOLDER; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_RE_PLACEHOLDER` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1760:17 | 1760 | flags = flags | TypeFlags::HAS_FREE_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1761:17 | 1761 | flags = flags | TypeFlags::HAS_FREE_LOCAL_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_LOCAL_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1762:17 | 1762 | flags = flags | TypeFlags::HAS_RE_PARAM; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_RE_PARAM` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1765:17 | 1765 | flags = flags | TypeFlags::HAS_FREE_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1766:17 | 1766 | flags = flags | TypeFlags::HAS_FREE_LOCAL_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_LOCAL_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1769:17 | 1769 | flags = flags | TypeFlags::HAS_FREE_REGIONS; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_FREE_REGIONS` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1772:17 | 1772 | flags = flags | TypeFlags::HAS_RE_LATE_BOUND; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_RE_LATE_BOUND` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/sty.rs:1775:17 | 1775 | flags = flags | TypeFlags::HAS_RE_ERASED; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= TypeFlags::HAS_RE_ERASED` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: item `ty::AssociatedItems<'tcx>` has a public `len` method but no corresponding `is_empty` method --> compiler/rustc_middle/src/ty/mod.rs:254:1 | 254 | / impl<'tcx> AssociatedItems<'tcx> { 255 | | /// Constructs an `AssociatedItems` map from a series of `ty::AssocItem`s in definition order. 256 | | pub fn new(items_in_def_order: impl IntoIterator) -> Self { 257 | | let items = items_in_def_order.into_iter().map(|item| (item.ident.name, item)).collect(); ... | 320 | | } 321 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty warning: you don't need to add `&` to all patterns --> compiler/rustc_middle/src/ty/mod.rs:1042:9 | 1042 | / match self.kind() { 1043 | | &PredicateKind::ForAll(binder) => binder.skip_binder(), 1044 | | &PredicateKind::Atom(atom) => { 1045 | | debug_assert!(!atom.has_escaping_bound_vars()); 1046 | | atom 1047 | | } 1048 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1042 | match *self.kind() { 1043 | PredicateKind::ForAll(binder) => binder.skip_binder(), 1044 | PredicateKind::Atom(atom) => { | warning: you don't need to add `&` to all patterns --> compiler/rustc_middle/src/ty/mod.rs:1058:9 | 1058 | / match self.kind() { 1059 | | &PredicateKind::ForAll(binder) => binder.skip_binder(), 1060 | | &PredicateKind::Atom(atom) => atom, 1061 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1058 | match *self.kind() { 1059 | PredicateKind::ForAll(binder) => binder.skip_binder(), 1060 | PredicateKind::Atom(atom) => atom, | warning: you don't need to add `&` to all patterns --> compiler/rustc_middle/src/ty/mod.rs:1067:9 | 1067 | / match self.kind() { 1068 | | &PredicateKind::ForAll(binder) => binder, 1069 | | &PredicateKind::Atom(atom) => { 1070 | | debug_assert!(!atom.has_escaping_bound_vars()); 1071 | | Binder::dummy(atom) 1072 | | } 1073 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1067 | match *self.kind() { 1068 | PredicateKind::ForAll(binder) => binder, 1069 | PredicateKind::Atom(atom) => { | warning: you don't need to add `&` to all patterns --> compiler/rustc_middle/src/ty/mod.rs:1079:9 | 1079 | / match self.kind() { 1080 | | &PredicateKind::ForAll(binder) => binder, 1081 | | &PredicateKind::Atom(atom) => Binder::wrap_nonbinding(tcx, atom), 1082 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1079 | match *self.kind() { 1080 | PredicateKind::ForAll(binder) => binder, 1081 | PredicateKind::Atom(atom) => Binder::wrap_nonbinding(tcx, atom), | warning: needless `fn main` in doctest --> compiler/rustc_middle/src/ty/mod.rs:1623:4 | 1623 | /// #![feature(const_generics)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_doctest_main)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main warning: this function has too many arguments (10/7) --> compiler/rustc_middle/src/ty/mod.rs:2011:5 | 2011 | / pub fn new( 2012 | | ident: Ident, 2013 | | variant_did: Option, 2014 | | ctor_def_id: Option, ... | 2021 | | is_field_list_non_exhaustive: bool, 2022 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: manual implementation of an assign operation --> compiler/rustc_middle/src/ty/mod.rs:2318:13 | 2318 | flags = flags | AdtFlags::IS_VARIANT_LIST_NON_EXHAUSTIVE; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= AdtFlags::IS_VARIANT_LIST_NON_EXHAUSTIVE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: manual implementation of an assign operation --> compiler/rustc_middle/src/util/common.rs:37:5 | 37 | *accu = *accu + duration; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*accu += duration` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern warning: 138 warnings emitted warning: `t` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult --> compiler/rustc_infer/src/infer/combine.rs:839:23 | 839 | fn tys(&mut self, t: Ty<'tcx>, _t: Ty<'tcx>) -> RelateResult<'tcx, Ty<'tcx>> { | ^ | = note: `#[warn(clippy::duplicate_underscore_argument)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument warning: `r` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult --> compiler/rustc_infer/src/infer/combine.rs:879:9 | 879 | r: ty::Region<'tcx>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:171:34 | 171 | self = print_prefix(self)?; | ^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_incremental/src/assert_dep_graph.rs:240:13 | 240 | write!(file, "{:?} -> {:?}\n", source, target).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_with_newline)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 240 | writeln!(file, "{:?} -> {:?}", source, target).unwrap(); | ^^^^^^^ -- warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:213:63 | 213 | self = print_value(self, value.as_ref().skip_binder())?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: `c` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult --> compiler/rustc_infer/src/infer/combine.rs:914:9 | 914 | c: &'tcx ty::Const<'tcx>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:243:59 | 243 | self = self.default_print_def_path(def_id, substs)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_incremental/src/assert_dep_graph.rs:190:58 | 190 | fn check_paths<'tcx>(tcx: TyCtxt<'tcx>, if_this_changed: &Sources, then_this_would_need: &Targets) { | ^^^^^^^^ | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: all variants have the same prefix: `Add` --> compiler/rustc_infer/src/infer/region_constraints/mod.rs:277:1 | 277 | / pub(crate) enum UndoLog<'tcx> { 278 | | /// We added `RegionVid`. 279 | | AddVar(RegionVid), 280 | | ... | 291 | | AddCombination(CombineMapType, TwoRegions<'tcx>), 292 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the prefixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:299:14 | 299 | )?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_incremental/src/assert_dep_graph.rs:190:90 | 190 | fn check_paths<'tcx>(tcx: TyCtxt<'tcx>, if_this_changed: &Sources, then_this_would_need: &Targets) { | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_metadata/src/rmeta/decoder.rs:612:9 | 612 | write!(out, "=External Dependencies=\n")?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_with_newline)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 612 | writeln!(out, "=External Dependencies=")?; | ^^^^^^^ -- warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:302:59 | 302 | self = self.print_def_path(parent_def_id, &[])?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_metadata/src/rmeta/decoder.rs:615:13 | 615 | write!(out, "{} {}{}\n", i + 1, dep.name, dep.extra_filename)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 615 | writeln!(out, "{} {}{}", i + 1, dep.name, dep.extra_filename)?; | ^^^^^^^ -- warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:305:35 | 305 | self = self_ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_incremental/src/assert_dep_graph.rs:313:5 | 313 | / if let &Some(ref sources) = sources { 314 | | if let &Some(ref targets) = targets { 315 | | walk_between(query, sources, targets) 316 | | } else { ... | 322 | | query.nodes().into_iter().collect() 323 | | } | |_____^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 313 | if let Some(ref sources) = *sources { | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:308:75 | 308 | self = self.print_def_path(trait_ref.def_id, trait_ref.substs)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_metadata/src/rmeta/decoder.rs:617:9 | 617 | write!(out, "\n")?; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 617 | writeln!(out, )?; | ^^^^^^^ -- warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:392:41 | 392 | self = r.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_incremental/src/assert_dep_graph.rs:314:9 | 314 | / if let &Some(ref targets) = targets { 315 | | walk_between(query, sources, targets) 316 | | } else { 317 | | walk_nodes(query, sources, OUTGOING) 318 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 314 | if let Some(ref targets) = *targets { | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_metadata/src/locator.rs:851:21 | 851 | Err(msg) => write!(out, "{}\n", msg), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 851 | Err(msg) => writeln!(out, "{}", msg), | ^^^^^^^ -- warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:394:38 | 394 | self = ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:402:41 | 402 | self = mt.ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_incremental/src/assert_dep_graph.rs:319:12 | 319 | } else if let &Some(ref targets) = targets { | ____________^ 320 | | walk_nodes(query, targets, INCOMING) 321 | | } else { 322 | | query.nodes().into_iter().collect() 323 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 319 | } else if let Some(ref targets) = *targets { | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_infer/src/infer/canonical/query_response.rs:435:21 | 435 | / if let &ty::RegionKind::ReLateBound(debruijn, br) = result_value { 436 | | // ... in which case we would set `canonical_vars[0]` to `Some('static)`. 437 | | 438 | | // We only allow a `ty::INNERMOST` index in substitutions. 439 | | assert_eq!(debruijn, ty::INNERMOST); 440 | | opt_values[br.assert_bound_var()] = Some(*original_value); 441 | | } | |_____________________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 435 | if let ty::RegionKind::ReLateBound(debruijn, br) = *result_value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:407:38 | 407 | self = ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_metadata/src/native_libs.rs:195:13 | 195 | / if let &Some(ref new_name) = new_name { 196 | | let any_duplicate = self 197 | | .libs 198 | | .iter() ... | 219 | | } 220 | | } | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 195 | if let Some(ref new_name) = *new_name { | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ warning: the operation is ineffective. Consider reducing it to `HEADER_FORMAT_VERSION` --> compiler/rustc_incremental/src/persist/file_format.rs:34:27 | 34 | .emit_raw_bytes(&[(HEADER_FORMAT_VERSION >> 0) as u8, (HEADER_FORMAT_VERSION >> 8) as u8]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: 7 warnings emitted warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:408:45 | 408 | self = self.print_const(len)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_metadata/src/native_libs.rs:242:29 | 242 | / ... if let &Some(ref new_name) = new_name { 243 | | ... lib.name = Some(Symbol::intern(new_name)); 244 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 242 | if let Some(ref new_name) = *new_name { | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ warning: unneeded `return` statement --> compiler/rustc_infer/src/infer/combine.rs:660:9 | 660 | return result; | ^^^^^^^^^^^^^^ help: remove `return`: `result` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: returning the result of a `let` binding from a block --> compiler/rustc_metadata/src/rmeta/decoder/cstore_impl.rs:238:9 | 232 | let syms = cdata.exported_symbols(tcx); | --------------------------------------- unnecessary `let` binding ... 238 | syms | ^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 232 | 233 | 234 | // FIXME rust-lang/rust#64319, rust-lang/rust#64872: We want 235 | // to block export of generics from dylibs, but we must fix 236 | // rust-lang/rust#65890 before we can do that robustly. 237 | ... warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:412:38 | 412 | self = ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: this function has too many arguments (8/7) --> compiler/rustc_save_analysis/src/dump_visitor.rs:259:5 | 259 | / fn process_method( 260 | | &mut self, 261 | | sig: &'tcx hir::FnSig<'tcx>, 262 | | body: Option, ... | 267 | | span: Span, 268 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:418:42 | 418 | self = ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_metadata/src/rmeta/decoder.rs:75:9 | 75 | FxHashMap<(u32, DefIndex), Lazy<[(DefIndex, Option)]>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has too many arguments (8/7) --> compiler/rustc_save_analysis/src/dump_visitor.rs:414:5 | 414 | / fn process_assoc_const( 415 | | &mut self, 416 | | hir_id: hir::HirId, 417 | | ident: Ident, ... | 422 | | attrs: &'tcx [ast::Attribute], 423 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:430:59 | 430 | self = self.print_def_path(def_id, substs)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: use of `or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:167:31 | 167 | sess: self.sess().or(tcx.map(|tcx| tcx.sess)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| tcx.map(|tcx| tcx.sess))` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:433:56 | 433 | self = self.print_def_path(def_id, &[])?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: the operation is ineffective. Consider reducing it to `offset` --> compiler/rustc_metadata/src/rmeta/decoder.rs:604:28 | 604 | let pos = (((slice[offset + 0] as u32) << 24) | ^^^^^^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:463:19 | 463 | })?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_save_analysis/src/dump_visitor.rs:585:21 | 585 | / if let &hir::VariantData::Tuple(ref fields, _) = v { 586 | | value.push('('); 587 | | value.push_str( 588 | | &fields ... | 594 | | value.push(')'); 595 | | } | |_____________________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 585 | if let hir::VariantData::Tuple(ref fields, _) = *v { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ warning: the operation is ineffective. Consider reducing it to `(slice[offset + 3] as u32)` --> compiler/rustc_metadata/src/rmeta/decoder.rs:607:15 | 607 | | ((slice[offset + 3] as u32) << 0)) as usize; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:456:42 | 456 | cx = ty.print(cx)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_infer/src/infer/combine.rs:843:9 | 843 | / match t.kind() { 844 | | &ty::Infer(ty::TyVar(vid)) => { 845 | | let vid = self.infcx.inner.borrow_mut().type_variables().root_var(vid); 846 | | let probe = self.infcx.inner.borrow_mut().type_variables().probe(vid); ... | 873 | | _ => relate::super_relate_tys(self, t, t), 874 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 843 | match *t.kind() { 844 | ty::Infer(ty::TyVar(vid)) => { | warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:859:18 | 859 | .unwrap_or(Lazy::empty()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:470:19 | 470 | })?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_save_analysis/src/dump_visitor.rs:656:13 | 656 | / if let &Some(ref trait_ref) = trait_ref { 657 | | v.process_path(trait_ref.hir_ref_id, &hir::QPath::Resolved(None, &trait_ref.path)); 658 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 656 | if let Some(ref trait_ref) = *trait_ref { | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:891:18 | 891 | .unwrap_or(Lazy::empty()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:471:37 | 471 | self = r.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you don't need to add `&` to all patterns --> compiler/rustc_save_analysis/src/dump_visitor.rs:1083:17 | 1083 | / if let &Some(ref default_ty) = default_ty { 1084 | | self.visit_ty(default_ty) 1085 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1083 | if let Some(ref default_ty) = *default_ty { | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:497:83 | 497 | self = self.print_def_path(trait_ref.def_id, trait_ref.substs)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:1078:64 | 1078 | let children = self.root.tables.children.get(self, id).unwrap_or(Lazy::empty()); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: 5 warnings emitted warning: unneeded `return` statement --> compiler/rustc_infer/src/infer/combine.rs:904:13 | 904 | return Ok(r); | ^^^^^^^^^^^^^ help: remove `return`: `Ok(r)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:1101:30 | 1101 | ... .unwrap_or(Lazy::empty()); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:1287:50 | 1287 | self.root.tables.variances.get(self, id).unwrap_or(Lazy::empty()).decode(self).collect() | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:503:53 | 503 | self = projection.ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:1326:14 | 1326 | .unwrap_or(Lazy::empty()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs:53:42 | 53 | if ty.walk().any(|inner| { | __________________________________________^ 54 | | inner == self.target 55 | | || match (inner.unpack(), self.target.unpack()) { 56 | | (GenericArgKind::Type(inner_ty), GenericArgKind::Type(target_ty)) => { ... | 71 | | } 72 | | }) { | |_________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:506:60 | 506 | self = self.print_def_path(def_id, &[])?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:1336:14 | 1336 | .unwrap_or(Lazy::empty()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:543:37 | 543 | self = ct.ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/rmeta/decoder.rs:1352:18 | 1352 | .unwrap_or(Lazy::empty()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Lazy::empty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs:116:88 | 116 | == self.infcx.in_progress_typeck_results.and_then(|typeck_results| { | ________________________________________________________________________________________^ 117 | | typeck_results 118 | | .borrow() 119 | | .node_type_opt(exprs.first().unwrap().hir_id) 120 | | .map(Into::into) 121 | | }) | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:580:35 | 580 | self = self_ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:649:34 | 649 | self = print_prefix(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: this function has too many arguments (9/7) --> compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs:139:1 | 139 | / fn closure_return_type_suggestion( 140 | | span: Span, 141 | | err: &mut DiagnosticBuilder<'_>, 142 | | output: &FnRetTy<'_>, ... | 148 | | parent_descr: Option<&str>, 149 | | ) { | |__^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (10/7) --> compiler/rustc_metadata/src/rmeta/decoder.rs:1801:5 | 1801 | / crate fn new( 1802 | | sess: &Session, 1803 | | blob: MetadataBlob, 1804 | | root: CrateRoot<'static>, ... | 1811 | | host_hash: Option, 1812 | | ) -> CrateMetadata { | |______________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:653:42 | 653 | self = lt.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:132:32 | 132 | e.emit_usize(self.meta)?; | ^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: this function has too many arguments (8/7) --> compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs:193:5 | 193 | / fn try_report_placeholders_trait( 194 | | &self, 195 | | vid: Option>, 196 | | cause: &ObligationCause<'tcx>, ... | 201 | | actual_substs: SubstsRef<'tcx>, 202 | | ) -> DiagnosticBuilder<'me> { | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:656:42 | 656 | self = ty.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:146:32 | 146 | e.emit_usize(self.meta)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_symbol_mangling/src/v0.rs:660:41 | 660 | self = c.print(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:252:22 | 252 | tag.encode(s)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: 29 warnings emitted warning: this function has too many arguments (13/7) --> compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs:325:5 | 325 | / fn explain_actual_impl_that_was_found( 326 | | &self, 327 | | err: &mut DiagnosticBuilder<'_>, 328 | | sub_placeholder: Option>, ... | 338 | | leading_ellipsis: bool, 339 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:253:21 | 253 | lo.encode(s)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:258:22 | 258 | len.encode(s)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:292:44 | 292 | SyntaxContext::root().encode(s)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_infer/src/infer/error_reporting/nice_region_error/trait_impl_difference.rs:67:9 | 67 | / match assoc_item.kind { 68 | | ty::AssocKind::Fn => { 69 | | let hir = self.tcx().hir(); 70 | | if let Some(hir_id) = ... | 78 | | _ => {} 79 | | } | |_________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 67 | if let ty::AssocKind::Fn = assoc_item.kind { 68 | let hir = self.tcx().hir(); 69 | if let Some(hir_id) = 70 | assoc_item.def_id.as_local().map(|id| hir.local_def_id_to_hir_id(id)) 71 | { 72 | if let Some(decl) = hir.fn_decl_by_hir_id(hir_id) { ... warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:294:32 | 294 | span.ctxt.encode(s)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_metadata/src/rmeta/encoder.rs:301:27 | 301 | cnum.encode(s)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: match expression looks like `matches!` macro --> compiler/rustc_infer/src/infer/error_reporting/nice_region_error/trait_impl_difference.rs:135:36 | 135 | .map(|res| match res { | ____________________________________^ 136 | | Res::SelfTy(_, _) | Res::Def(hir::def::DefKind::TyParam, _) => true, 137 | | _ => false, 138 | | }) | |_________________________^ help: try this: `matches!(res, Res::SelfTy(_, _) | Res::Def(hir::def::DefKind::TyParam, _))` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this call to `map()` won't have an effect on the call to `count()` --> compiler/rustc_metadata/src/rmeta/encoder.rs:378:9 | 378 | self.into_iter().map(|value| value.encode_contents_for_lazy(ecx)).count() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::suspicious_map)]` on by default = help: make sure you did not confuse `map` with `filter` or `for_each` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_map warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:311:48 | 311 | pub fn report_region_errors(&self, errors: &Vec>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RegionResolutionError<'tcx>]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: the operation is ineffective. Consider reducing it to `header` --> compiler/rustc_metadata/src/rmeta/encoder.rs:2078:12 | 2078 | result[header + 0] = (pos >> 24) as u8; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `pos` --> compiler/rustc_metadata/src/rmeta/encoder.rs:2081:26 | 2081 | result[header + 3] = (pos >> 0) as u8; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:418:17 | 418 | errors: &Vec>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 418 | errors: &[RegionResolutionError<'tcx>], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change `errors.clone()` to | 443 | errors.to_owned() | warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_metadata/src/rmeta/table.rs:126:14 | 126 | _marker: PhantomData<(fn(&I), T)>, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_metadata/src/rmeta/table.rs:142:14 | 142 | _marker: PhantomData<(fn(&I), T)>, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you are using an explicit closure for copying elements --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:632:29 | 632 | ... prior_arms.iter().chain(std::iter::once(&arm_span)).map(|s| *s), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `prior_arms.iter().chain(std::iter::once(&arm_span)).copied()` | = note: `#[warn(clippy::map_clone)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone warning: you are using an explicit closure for copying elements --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:727:29 | 727 | ... prior_arms.iter().chain(std::iter::once(&arm_span)).map(|s| *s), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `prior_arms.iter().chain(std::iter::once(&arm_span)).copied()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_metadata/src/creader.rs:254:38 | 254 | if files.any(|l| { | ______________________________________^ 255 | | let l = fs::canonicalize(l).unwrap_or(l.clone().into()); 256 | | source.dylib.as_ref().map(|p| &p.0) == Some(&l) 257 | | || source.rlib.as_ref().map(|p| &p.0) == Some(&l) 258 | | }) { | |_____________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: use of `unwrap_or` followed by a function call --> compiler/rustc_metadata/src/creader.rs:255:53 | 255 | let l = fs::canonicalize(l).unwrap_or(l.clone().into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| l.clone().into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: you don't need to add `&` to all patterns --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:908:13 | 908 | / if let &ty::Adt(def, _) = ta.kind() { 909 | | let path_ = self.tcx.def_path_str(def.did); 910 | | if path_ == other_path { 911 | | self.highlight_outer(&mut t1_out, &mut t2_out, path, sub, i, &other_ty); 912 | | return Some(()); 913 | | } 914 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 908 | if let ty::Adt(def, _) = *ta.kind() { | ^^^^^^^^^^^^^^^ ^^^^^^^^^^ warning: use of `or` followed by a function call --> compiler/rustc_metadata/src/creader.rs:275:18 | 275 | .or(source.rmeta.as_ref()) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| source.rmeta.as_ref())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `or` followed by a function call --> compiler/rustc_metadata/src/creader.rs:274:18 | 274 | .or(source.rlib.as_ref()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| source.rlib.as_ref())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:1600:58 | 1600 | || (exp_found.map_or(false, |ef| { | __________________________________________________________^ 1601 | | // This happens when the type error is a subset of the expectation, 1602 | | // like when you have two references but one is `usize` and the other 1603 | | // is `f32`. In those cases we still want to show the `note`. If the ... | 1611 | | } 1612 | | })) | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_metadata/src/dynamic_lib.rs:33:5 | 33 | / pub unsafe fn symbol(&self, symbol: &str) -> Result<*mut T, String> { 34 | | // This function should have a lifetime constraint of 'a on 35 | | // T but that feature is still unimplemented 36 | | ... | 45 | | } 46 | | } | |_____^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: use of `unwrap_or` followed by a function call --> compiler/rustc_infer/src/infer/error_reporting/mod.rs:2044:14 | 2044 | .unwrap_or("'lt".to_string()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "'lt".to_string())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: match expression looks like `matches!` macro --> compiler/rustc_infer/src/infer/free_regions.rs:96:9 | 96 | / match *r { 97 | | ty::ReEarlyBound(_) | ty::ReFree(_) => true, 98 | | _ => false, 99 | | } | |_________^ help: try this: `matches!(*r, ty::ReEarlyBound(_) | ty::ReFree(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (10/7) --> compiler/rustc_metadata/src/locator.rs:295:5 | 295 | / crate fn new( 296 | | sess: &'a Session, 297 | | metadata_loader: &'a dyn MetadataLoader, 298 | | crate_name: Symbol, ... | 305 | | is_proc_macro: Option, 306 | | ) -> CrateLocator<'a> { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: match expression looks like `matches!` macro --> compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs:396:17 | 396 | / match *b_data { 397 | | VarValue::Value(ReStatic) | VarValue::ErrorValue => false, 398 | | _ => true, 399 | | } | |_________________^ help: try this: `!matches!(*b_data, VarValue::Value(ReStatic) | VarValue::ErrorValue)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: large size difference between variants --> compiler/rustc_metadata/src/locator.rs:889:5 | 889 | LocatorCombined(CombinedLocatorError), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this variant is 312 bytes | = note: `#[warn(clippy::large_enum_variant)]` on by default note: and the second-largest variant is 36 bytes: --> compiler/rustc_metadata/src/locator.rs:884:5 | 884 | MultipleMatchingCrates(Symbol, FxHashMap), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant help: consider boxing the large fields to reduce the total size of the enum | 889 | LocatorCombined(Box), | ^^^^^^^^^^^^^^^^^^^^^^^^^ warning: 40 warnings emitted warning: if let .. else expression looks like `matches!` macro --> compiler/rustc_infer/src/infer/lexical_region_resolve/mod.rs:975:17 | 975 | / if let ty::ReEmpty(_) = min { 976 | | true 977 | | } else { 978 | | false 979 | | } | |_________________^ help: try this: `matches!(min, ty::ReEmpty(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. --> compiler/rustc_infer/src/infer/nll_relate/mod.rs:885:29 | 885 | ... drop(variables); | ^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::drop_ref)]` on by default note: argument has type `&mut infer::type_variable::TypeVariableTable` --> compiler/rustc_infer/src/infer/nll_relate/mod.rs:885:34 | 885 | ... drop(variables); | ^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_infer/src/infer/outlives/obligations.rs:194:29 | 194 | region_bound_pairs: &RegionBoundPairs<'tcx>, | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this `if` statement can be collapsed --> compiler/rustc_codegen_ssa/src/back/link.rs:445:5 | 445 | / if !all_native_libs.is_empty() { 446 | | if sess.opts.prints.contains(&PrintRequest::NativeStaticLibs) { 447 | | print_native_static_libs(sess, &all_native_libs); 448 | | } 449 | | } | |_____^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 445 | if !all_native_libs.is_empty() && sess.opts.prints.contains(&PrintRequest::NativeStaticLibs) { 446 | print_native_static_libs(sess, &all_native_libs); 447 | } | warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:100:5 | 100 | NormalRibKind, | ^^^^^^^^^^^^^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_infer/src/infer/outlives/obligations.rs:254:29 | 254 | region_bound_pairs: &'cx RegionBoundPairs<'tcx>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:106:5 | 106 | AssocItemRibKind, | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_infer/src/infer/outlives/verify.rs:25:29 | 25 | region_bound_pairs: &'cx RegionBoundPairs<'tcx>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:109:5 | 109 | ClosureOrAsyncRibKind, | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: this `else { if .. }` block can be collapsed --> compiler/rustc_codegen_ssa/src/back/link.rs:1341:12 | 1341 | } else { | ____________^ 1342 | | if let Some(args) = sess.target.options.late_link_args_static.get(&flavor) { 1343 | | cmd.args(args); 1344 | | } 1345 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1341 | } else if let Some(args) = sess.target.options.late_link_args_static.get(&flavor) { 1342 | cmd.args(args); 1343 | } | warning: use of `or_insert` followed by a function call --> compiler/rustc_infer/src/infer/region_constraints/leak_check.rs:444:25 | 444 | *nodes.entry(r).or_insert(LeakCheckNode::new(l)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| LeakCheckNode::new(l))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:113:5 | 113 | FnItemRibKind, | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: this will panic at run-time if the environment variable doesn't exist at compile-time --> compiler/rustc_codegen_ssa/src/back/link.rs:1477:34 | 1477 | let install_prefix = option_env!("CFG_PREFIX").expect("CFG_PREFIX"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::option_env_unwrap)]` on by default = help: consider using the `env!` macro instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_env_unwrap warning: usage of `Rc` when T is a buffer type --> compiler/rustc_infer/src/infer/region_constraints/mod.rs:545:26 | 545 | choice_regions: &Lrc>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[ty::Region<'tcx>]>` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:116:5 | 116 | ItemRibKind(HasGenericParams), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:122:5 | 122 | ConstantItemRibKind(bool), | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:125:5 | 125 | ModuleRibKind(Module<'a>), | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: this `if` has identical blocks --> compiler/rustc_infer/src/infer/region_constraints/mod.rs:802:58 | 802 | } else if self.cannot_hold() && vb.cannot_hold() { | __________________________________________________________^ 803 | | self 804 | | } else { | |_________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_infer/src/infer/region_constraints/mod.rs:800:47 | 800 | if self.must_hold() && vb.must_hold() { | _______________________________________________^ 801 | | self 802 | | } else if self.cannot_hold() && vb.cannot_hold() { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:133:5 | 133 | ForwardTyParamBanRibKind, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: this `if` statement can be collapsed --> compiler/rustc_codegen_ssa/src/mir/block.rs:161:9 | 161 | / if bx.tcx().sess.opts.debugging_opts.insert_sideeffect { 162 | | if targets.iter().any(|&target| { 163 | | target <= self.bb 164 | | && target.start_location().is_predecessor_of(self.bb.start_location(), mir) ... | 167 | | } 168 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 161 | if bx.tcx().sess.opts.debugging_opts.insert_sideeffect && targets.iter().any(|&target| { 162 | target <= self.bb 163 | && target.start_location().is_predecessor_of(self.bb.start_location(), mir) 164 | }) { 165 | bx.sideeffect(false); 166 | } | warning: variant name ends with the enum's name --> compiler/rustc_resolve/src/late.rs:137:5 | 137 | ConstParamTyRibKind, | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: you should consider adding a `Default` implementation for `infer::type_variable::TypeVariableStorage<'tcx>` --> compiler/rustc_infer/src/infer/type_variable.rs:156:5 | 156 | / pub fn new() -> TypeVariableStorage<'tcx> { 157 | | TypeVariableStorage { 158 | | values: sv::SnapshotVecStorage::new(), 159 | | eq_relations: ut::UnificationTableStorage::new(), 160 | | sub_relations: ut::UnificationTableStorage::new(), 161 | | } 162 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 155 | impl Default for infer::type_variable::TypeVariableStorage<'tcx> { 156 | fn default() -> Self { 157 | Self::new() 158 | } 159 | } | warning: this function has too many arguments (9/7) --> compiler/rustc_resolve/src/build_reduced_graph.rs:353:5 | 353 | / fn add_import( 354 | | &mut self, 355 | | module_path: Vec, 356 | | kind: ImportKind<'a>, ... | 362 | | vis: ty::Visibility, 363 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: usage of `Rc` when T is a buffer type --> compiler/rustc_infer/src/infer/mod.rs:919:22 | 919 | in_regions: &Lrc>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[ty::Region<'tcx>]>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: 34 warnings emitted warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_codegen_ssa/src/back/link.rs:1293:5 | 1293 | / match (crate_type, &sess.target.options.link_script) { 1294 | | (CrateType::Cdylib | CrateType::Executable, Some(script)) => { 1295 | | if !sess.target.options.linker_is_gnu { 1296 | | sess.fatal("can only use link script when linking with GNU-like linker"); ... | 1309 | | _ => {} 1310 | | } | |_____^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1293 | if let (CrateType::Cdylib | CrateType::Executable, Some(script)) = (crate_type, &sess.target.options.link_script) { 1294 | if !sess.target.options.linker_is_gnu { 1295 | sess.fatal("can only use link script when linking with GNU-like linker"); 1296 | } 1297 | 1298 | let file_name = ["rustc", &sess.target.llvm_target, "linkfile.ld"].join("-"); ... warning: this function has too many arguments (8/7) --> compiler/rustc_resolve/src/build_reduced_graph.rs:404:5 | 404 | / fn build_reduced_graph_for_use_tree( 405 | | &mut self, 406 | | // This particular use tree 407 | | use_tree: &ast::UseTree, ... | 414 | | root_span: Span, 415 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> compiler/rustc_resolve/src/diagnostics.rs:97:9 | 97 | &self, | ^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: this function has too many arguments (8/7) --> compiler/rustc_codegen_ssa/src/back/link.rs:1503:1 | 1503 | / fn linker_with_args<'a, B: ArchiveBuilder<'a>>( 1504 | | path: &Path, 1505 | | flavor: LinkerFlavor, 1506 | | sess: &'a Session, ... | 1511 | | target_cpu: &str, 1512 | | ) -> Command { | |____________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_ssa/src/back/link.rs:1984:20 | 1984 | parent.unwrap_or(Path::new("")), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: this function has too many arguments (8/7) --> compiler/rustc_resolve/src/imports.rs:184:5 | 184 | / crate fn resolve_ident_in_module_unadjusted_ext( 185 | | &mut self, 186 | | module: ModuleOrUniformRoot<'a>, 187 | | ident: Ident, ... | 192 | | path_span: Span, 193 | | ) -> Result<&'a NameBinding<'a>, (Determinacy, Weak)> { | |_________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_codegen_ssa/src/back/lto.rs:65:5 | 65 | / pub unsafe fn optimize( 66 | | &mut self, 67 | | cgcx: &CodegenContext, 68 | | ) -> Result, FatalError> { ... | 79 | | } 80 | | } | |_____^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_codegen_ssa/src/back/rpath.rs:27:16 | 27 | let libs = config.used_crates.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::clone_double_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 27 | let libs = &(*config.used_crates).clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 27 | let libs = <&[(rustc_hir::def_id::CrateNum, rustc_middle::middle::cstore::LibSource)]>::clone(config.used_crates); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_resolve/src/imports.rs:1017:17 | 1017 | / match binding { 1018 | | Ok(binding) => { 1019 | | // Consistency checks, analogous to `finalize_macro_resolutions`. 1020 | | let initial_res = source_bindings[ns].get().map(|initial_binding| { ... | 1059 | | } 1060 | | } | |_________________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1017 | if let Ok(binding) = binding { 1018 | // Consistency checks, analogous to `finalize_macro_resolutions`. 1019 | let initial_res = source_bindings[ns].get().map(|initial_binding| { 1020 | all_ns_err = false; 1021 | if let Some(target_binding) = target_bindings[ns].get() { 1022 | if target.name == kw::Underscore ... warning: this `if` statement can be collapsed --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:758:29 | 758 | / ... if p.ty().skip_binder().has_infer_types() { 759 | | ... if !self.evaluate_nested_obligations( 760 | | ... ty, 761 | | ... v.into_iter(), ... | 769 | | ... } 770 | | ... } | |_______________________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 758 | if p.ty().skip_binder().has_infer_types() && !self.evaluate_nested_obligations( 759 | ty, 760 | v.into_iter(), 761 | computed_preds, 762 | fresh_preds, 763 | predicates, ... warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_ssa/src/back/symbol_export.rs:160:1 | 160 | / fn exported_symbols_provider_local( 161 | | tcx: TyCtxt<'tcx>, 162 | | cnum: CrateNum, 163 | | ) -> &'tcx [(ExportedSymbol<'tcx>, SymbolExportLevel)] { | |______________________________________________________^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: mutable key type --> compiler/rustc_codegen_ssa/src/back/symbol_export.rs:320:13 | 320 | let substs_map = instances.entry(def_id).or_default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::mutable_key_type)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_resolve/src/late/diagnostics.rs:196:9 | 196 | / match (source, self.diagnostic_metadata.in_if_condition) { 197 | | (PathSource::Expr(_), Some(Expr { span, kind: ExprKind::Assign(..), .. })) => { 198 | | err.span_suggestion_verbose( 199 | | span.shrink_to_lo(), ... | 206 | | _ => {} 207 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 196 | if let (PathSource::Expr(_), Some(Expr { span, kind: ExprKind::Assign(..), .. })) = (source, self.diagnostic_metadata.in_if_condition) { 197 | err.span_suggestion_verbose( 198 | span.shrink_to_lo(), 199 | "you might have meant to use pattern matching", 200 | "let ".to_string(), 201 | Applicability::MaybeIncorrect, ... warning: this `if` statement can be collapsed --> compiler/rustc_trait_selection/src/traits/coherence.rs:184:5 | 184 | / if !skip_leak_check.is_yes() { 185 | | if infcx.leak_check(true, snapshot).is_err() { 186 | | debug!("overlap: leak check failed"); 187 | | return None; 188 | | } 189 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 184 | if !skip_leak_check.is_yes() && infcx.leak_check(true, snapshot).is_err() { 185 | debug!("overlap: leak check failed"); 186 | return None; 187 | } | warning: this function has too many arguments (12/7) --> compiler/rustc_codegen_ssa/src/back/write.rs:927:1 | 927 | / fn start_executing_work( 928 | | backend: B, 929 | | tcx: TyCtxt<'_>, 930 | | crate_info: &CrateInfo, ... | 939 | | tx_to_llvm_workers: Sender>, 940 | | ) -> thread::JoinHandle> { | |____________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_resolve/src/late/diagnostics.rs:916:31 | 916 | .map(|sp| { | _______________________________^ 917 | | self.r 918 | | .session 919 | | .parse_sess ... | 922 | | .contains(&sp) 923 | | }) | |_____________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you are needlessly cloning iterator elements --> compiler/rustc_codegen_ssa/src/back/write.rs:1014:64 | 1014 | incr_comp_session_dir: sess.incr_comp_session_dir_opt().map(|r| r.clone()), | ^^^^^^^^^^^^^^^^^^^ help: remove the `map` call | = note: `#[warn(clippy::map_clone)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone warning: this `else { if .. }` block can be collapsed --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:2024:24 | 2024 | } else { | ________________________^ 2025 | | if let ObligationCauseCode::BuiltinDerivedObligation(ref data) = 2026 | | *data.parent_code 2027 | | { ... | 2035 | | } 2036 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 2024 | } else if let ObligationCauseCode::BuiltinDerivedObligation(ref data) = 2025 | *data.parent_code 2026 | { 2027 | let parent_trait_ref = 2028 | self.resolve_vars_if_possible(&data.parent_trait_ref); 2029 | let ty = parent_trait_ref.skip_binder().self_ty(); ... warning: length comparison to zero --> compiler/rustc_resolve/src/late/diagnostics.rs:973:48 | 973 | field_spans.filter(|spans| spans.len() > 0 && fields.len() == spans.len()) | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!spans.is_empty()` | = note: `#[warn(clippy::len_zero)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: `if` chain can be rewritten with `match` --> compiler/rustc_codegen_ssa/src/base.rs:309:9 | 309 | / if lhs_sz < rhs_sz { 310 | | bx.trunc(rhs, lhs_llty) 311 | | } else if lhs_sz > rhs_sz { 312 | | // FIXME (#1877: If in the future shifting by negative ... | 316 | | rhs 317 | | } | |_________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: length comparison to zero --> compiler/rustc_resolve/src/late/diagnostics.rs:984:24 | 984 | if non_visible_spans.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!non_visible_spans.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: this `if` statement can be collapsed --> compiler/rustc_trait_selection/src/traits/query/type_op/prove_predicate.rs:20:17 | 20 | / if trait_ref.def_id() == sized_def_id { 21 | | if trait_ref.self_ty().is_trivially_sized(tcx) { 22 | | return Some(()); 23 | | } 24 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 20 | if trait_ref.def_id() == sized_def_id && trait_ref.self_ty().is_trivially_sized(tcx) { 21 | return Some(()); 22 | } | warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_ssa/src/base.rs:477:1 | 477 | / pub fn codegen_crate( 478 | | backend: B, 479 | | tcx: TyCtxt<'tcx>, 480 | | metadata: EncodedMetadata, 481 | | need_metadata_module: bool, 482 | | ) -> OngoingCodegen { | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_ssa/src/coverageinfo/map.rs:134:5 | 134 | fn counter_regions<'a>(&'a self) -> impl Iterator { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: you don't need to add `&` to all patterns --> compiler/rustc_resolve/src/late/lifetimes.rs:880:13 | 880 | / match predicate { 881 | | &hir::WherePredicate::BoundPredicate(hir::WhereBoundPredicate { 882 | | ref bounded_ty, 883 | | bounds, ... | 933 | | } 934 | | } | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 880 | match *predicate { 881 | hir::WherePredicate::BoundPredicate(hir::WhereBoundPredicate { 882 | ref bounded_ty, 883 | bounds, 884 | ref bound_generic_params, 885 | .. ... warning: this `if` statement can be collapsed --> compiler/rustc_trait_selection/src/traits/select/mod.rs:909:9 | 909 | / if self.can_use_global_caches(param_env) { 910 | | if !trait_ref.needs_infer() { 911 | | debug!(?trait_ref, ?result, "insert_evaluation_cache global"); 912 | | // This may overwrite the cache with the same value ... | 918 | | } 919 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 909 | if self.can_use_global_caches(param_env) && !trait_ref.needs_infer() { 910 | debug!(?trait_ref, ?result, "insert_evaluation_cache global"); 911 | // This may overwrite the cache with the same value 912 | // FIXME: Due to #50507 this overwrites the different values 913 | // This should be changed to use HashMapExt::insert_same 914 | // when that is fixed ... warning: redundant closure found --> compiler/rustc_codegen_ssa/src/coverageinfo/map.rs:193:52 | 193 | ... new_indexes[index].map(|new_index| Counter::expression(new_index)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Counter::expression` | = note: `#[warn(clippy::redundant_closure)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_ssa/src/coverageinfo/map.rs:253:5 | 253 | fn unreachable_regions<'a>(&'a self) -> impl Iterator { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_codegen_ssa/src/mir/mod.rs:279:6 | 279 | ) -> ( | ______^ 280 | | IndexVec>, 281 | | IndexVec>, 282 | | ) { | |_^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this `if` statement can be collapsed --> compiler/rustc_trait_selection/src/traits/select/mod.rs:1117:20 | 1117 | } else if !trait_ref.needs_infer() { | ____________________^ 1118 | | if !candidate.needs_infer() { 1119 | | debug!(?trait_ref, ?candidate, "insert_candidate_cache global"); 1120 | | // This may overwrite the cache with the same value. ... | 1123 | | } 1124 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1117 | } else if !trait_ref.needs_infer() && !candidate.needs_infer() { 1118 | debug!(?trait_ref, ?candidate, "insert_candidate_cache global"); 1119 | // This may overwrite the cache with the same value. 1120 | tcx.selection_cache.insert(param_env.and(trait_ref), dep_node, candidate); 1121 | return; 1122 | } | warning: returning the result of a `let` binding from a block --> compiler/rustc_resolve/src/late/lifetimes.rs:912:25 | 905 | / let result = self.with(scope, |old_scope, this| { 906 | | this.check_lifetime_params(old_scope, &bound_generic_params); 907 | | this.visit_ty(&bounded_ty); 908 | | this.trait_ref_hack = true; 909 | | walk_list!(this, visit_param_bound, bounds); 910 | | this.trait_ref_hack = false; 911 | | }); | |___________________________- unnecessary `let` binding 912 | result | ^^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 905 | 906 | self.with(scope, |old_scope, this| { 907 | this.check_lifetime_params(old_scope, &bound_generic_params); 908 | this.visit_ty(&bounded_ty); 909 | this.trait_ref_hack = true; 910 | walk_list!(this, visit_param_bound, bounds); ... warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:38:9 | 38 | / match *self { 39 | | AutoTraitResult::PositiveImpl(_) | AutoTraitResult::NegativeImpl => true, 40 | | _ => false, 41 | | } | |_________^ help: try this: `matches!(*self, AutoTraitResult::PositiveImpl(_) | AutoTraitResult::NegativeImpl)` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_resolve/src/late/lifetimes.rs:1561:90 | 1561 | ... if self.tcx.hir().attrs(parent_hir_id).iter().any(|attr| { | ________________________________________________________________________________^ 1562 | | ... self.tcx.sess.check_name(attr, sym::automatically_derived) 1563 | | ... }) { | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: this `if` has identical blocks --> compiler/rustc_codegen_ssa/src/mir/analyze.rs:33:56 | 33 | } else if fx.cx.is_backend_scalar_pair(layout) { | ________________________________________________________^ 34 | | // We allow pairs and uses of any of their 2 fields. 35 | | } else { | |_________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_codegen_ssa/src/mir/analyze.rs:30:47 | 30 | if fx.cx.is_backend_immediate(layout) { | _______________________________________________^ 31 | | // These sorts of types are immediates that we can store 32 | | // in an Value without an alloca. 33 | | } else if fx.cx.is_backend_scalar_pair(layout) { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_resolve/src/late.rs:1163:22 | 1163 | trait_items: &'ast Vec>, | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[P]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:262:5 | 262 | / fn evaluate_predicates( 263 | | &self, 264 | | infcx: &InferCtxt<'_, 'tcx>, 265 | | trait_did: DefId, ... | 270 | | only_projections: bool, 271 | | ) -> Option<(ty::ParamEnv<'tcx>, ty::ParamEnv<'tcx>)> { | |_________________________________________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> compiler/rustc_resolve/src/late.rs:1976:5 | 1976 | / fn resolve_qpath_anywhere( 1977 | | &mut self, 1978 | | id: NodeId, 1979 | | qself: Option<&QSelf>, ... | 1984 | | crate_lint: CrateLint, 1985 | | ) -> Result, Spanned>> { | |_________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> compiler/rustc_codegen_ssa/src/mir/analyze.rs:107:9 | 107 | / if let &[ref proj_base @ .., elem] = place_ref.projection { 108 | | let mut base_context = if context.is_mutating_use() { 109 | | PlaceContext::MutatingUse(MutatingUseContext::Projection) 110 | | } else { ... | 207 | | self.visit_projection(place_ref.local, place_ref.projection, context, location); 208 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 107 | if let [ref proj_base @ .., elem] = *place_ref.projection { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_resolve/src/lib.rs:479:13 | 479 | traits: RefCell)]>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:314:13 | 314 | / match &result { 315 | | &Ok(Some(ref impl_source)) => { 316 | | // If we see an explicit negative impl (e.g., `impl !Send for MyStruct`), 317 | | // we immediately bail out, since it's impossible for us to continue. ... | 368 | | _ => panic!("Unexpected error for '{:?}': {:?}", ty, result), 369 | | }; | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 314 | match result { 315 | Ok(Some(ref impl_source)) => { 316 | // If we see an explicit negative impl (e.g., `impl !Send for MyStruct`), 317 | // we immediately bail out, since it's impossible for us to continue. 318 | 319 | if let ImplSource::UserDefined(ImplSourceUserDefinedData { ... warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_resolve/src/lib.rs:966:9 | 966 | Vec<(Vec, Span, MacroKind, ParentScope<'a>, Option)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: match expression looks like `matches!` macro --> compiler/rustc_codegen_ssa/src/mir/analyze.rs:115:30 | 115 | let is_consume = match context { | ______________________________^ 116 | | PlaceContext::NonMutatingUse( 117 | | NonMutatingUseContext::Copy | NonMutatingUseContext::Move, 118 | | ) => true, 119 | | _ => false, 120 | | }; | |_____________^ | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 115 | let is_consume = matches!(context, PlaceContext::NonMutatingUse( 116 | NonMutatingUseContext::Copy | NonMutatingUseContext::Move, 117 | )); | warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_resolve/src/lib.rs:1710:25 | 1710 | / self.output_macro_rules_scopes.get(&invoc_id).cloned().unwrap_or_else( 1711 | | || self.invocation_parent_scopes[&invoc_id].macro_rules, 1712 | | ), | |_________________________^ help: Use `unwrap_or` instead: `self.output_macro_rules_scopes.get(&invoc_id).cloned().unwrap_or(self.invocation_parent_scopes[&invoc_id].macro_rules)` | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations warning: this function has too many arguments (8/7) --> compiler/rustc_codegen_ssa/src/mir/block.rs:106:5 | 106 | / fn do_call>( 107 | | &self, 108 | | fx: &mut FunctionCx<'a, 'tcx, Bx>, 109 | | bx: &mut Bx, ... | 114 | | cleanup: Option, 115 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:514:13 | 514 | / match constraint { 515 | | &Constraint::VarSubVar(r1, r2) => { 516 | | { 517 | | let deps1 = vid_map.entry(RegionTarget::RegionVid(r1)).or_default(); ... | 544 | | } 545 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 514 | match *constraint { 515 | Constraint::VarSubVar(r1, r2) => { 516 | { 517 | let deps1 = vid_map.entry(RegionTarget::RegionVid(r1)).or_default(); 518 | deps1.larger.insert(RegionTarget::RegionVid(r2)); 519 | } ... warning: this function has too many arguments (8/7) --> compiler/rustc_resolve/src/lib.rs:2142:5 | 2142 | / fn resolve_path_with_ribs( 2143 | | &mut self, 2144 | | path: &[Segment], 2145 | | opt_ns: Option, // `None` indicates a module path in import ... | 2150 | | ribs: Option<&PerNS>>>, 2151 | | ) -> PathResult<'a> { | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:607:9 | 607 | / match *p.ty().skip_binder().kind() { 608 | | ty::Projection(proj) if proj == p.skip_binder().projection_ty => true, 609 | | _ => false, 610 | | } | |_________^ help: try this: `matches!(*p.ty().skip_binder().kind(), ty::Projection(proj) if proj == p.skip_binder().projection_ty)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_codegen_ssa/src/mir/block.rs:162:45 | 162 | if targets.iter().any(|&target| { | _____________________________________________^ 163 | | target <= self.bb 164 | | && target.start_location().is_predecessor_of(self.bb.start_location(), mir) 165 | | }) { | |_____________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you checked before that `unwrap()` cannot fail, instead of checking and unwrapping, it's better to use `if let` or `match` --> compiler/rustc_resolve/src/lib.rs:2288:26 | 2266 | } else if ribs.is_none() || opt_ns.is_none() || opt_ns == Some(MacroNS) { | -------------- the check is happening here ... 2288 | &ribs.unwrap()[ns], | ^^^^^^^^^^^^^ | = note: `#[warn(clippy::unnecessary_unwrap)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap warning: this function has too many arguments (8/7) --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:613:5 | 613 | / fn evaluate_nested_obligations( 614 | | &self, 615 | | ty: Ty<'_>, 616 | | nested: impl Iterator>>, ... | 621 | | only_projections: bool, 622 | | ) -> bool { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (9/7) --> compiler/rustc_codegen_ssa/src/mir/block.rs:355:5 | 355 | / fn codegen_assert_terminator( 356 | | &mut self, 357 | | helper: TerminatorCodegenHelper<'tcx>, 358 | | mut bx: Bx, ... | 364 | | cleanup: Option, 365 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you checked before that `unwrap()` cannot fail, instead of checking and unwrapping, it's better to use `if let` or `match` --> compiler/rustc_resolve/src/lib.rs:2288:26 | 2266 | } else if ribs.is_none() || opt_ns.is_none() || opt_ns == Some(MacroNS) { | -------------- the check is happening here ... 2288 | &ribs.unwrap()[ns], | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap warning: 29 warnings emitted warning: this function has too many arguments (8/7) --> compiler/rustc_codegen_ssa/src/mir/block.rs:439:5 | 439 | / fn codegen_panic_intrinsic( 440 | | &mut self, 441 | | helper: &TerminatorCodegenHelper<'tcx>, 442 | | bx: &mut Bx, ... | 447 | | cleanup: Option, 448 | | ) -> bool { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/auto_trait.rs:874:9 | 874 | / (match r { 875 | | &ty::ReVar(vid) => self.vid_to_region.get(&vid).cloned(), 876 | | _ => None, 877 | | }) | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 874 | (match *r { 875 | ty::ReVar(vid) => self.vid_to_region.get(&vid).cloned(), | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_codegen_ssa/src/mir/block.rs:528:15 | 528 | args: &Vec>, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[mir::Operand<'tcx>]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/coherence.rs:195:32 | 195 | let involves_placeholder = match selcx.infcx().region_constraints_added_in_snapshot(snapshot) { | ________________________________^ 196 | | Some(true) => true, 197 | | _ => false, 198 | | }; | |_____^ help: try this: `matches!(selcx.infcx().region_constraints_added_in_snapshot(snapshot), Some(true))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (9/7) --> compiler/rustc_codegen_ssa/src/mir/block.rs:522:5 | 522 | / fn codegen_call_terminator( 523 | | &mut self, 524 | | helper: TerminatorCodegenHelper<'tcx>, 525 | | mut bx: Bx, ... | 531 | | fn_span: Span, 532 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you checked before that `unwrap()` cannot fail, instead of checking and unwrapping, it's better to use `if let` or `match` --> compiler/rustc_codegen_ssa/src/mir/block.rs:648:29 | 647 | if intrinsic.is_some() && intrinsic != Some(sym::drop_in_place) { | ------------------- the check is happening here 648 | let intrinsic = intrinsic.unwrap(); | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::unnecessary_unwrap)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_trait_selection/src/traits/const_evaluatable.rs:40:9 | 40 | / match AbstractConst::new(tcx, def, substs)? { 41 | | // We are looking at a generic abstract constant. 42 | | Some(ct) => { 43 | | for pred in param_env.caller_bounds() { ... | 124 | | } 125 | | } | |_________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 40 | if let Some(ct) = AbstractConst::new(tcx, def, substs)? { 41 | for pred in param_env.caller_bounds() { 42 | match pred.skip_binders() { 43 | ty::PredicateAtom::ConstEvaluatable(b_def, b_substs) => { 44 | debug!( 45 | "is_const_evaluatable: caller_bound={:?}, {:?}", ... warning: this function has too many arguments (9/7) --> compiler/rustc_codegen_ssa/src/mir/block.rs:831:5 | 831 | / fn codegen_asm_terminator( 832 | | &mut self, 833 | | helper: TerminatorCodegenHelper<'tcx>, 834 | | mut bx: Bx, ... | 840 | | destination: Option, 841 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: the loop variable `i` is used to index `args` --> compiler/rustc_codegen_ssa/src/mir/block.rs:1171:22 | 1171 | for i in 0..tuple.layout.fields.count() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_range_loop)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 1171 | for (i, ) in args.iter().enumerate().take(tuple.layout.fields.count()) { | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_trait_selection/src/traits/const_evaluatable.rs:44:21 | 44 | / match pred.skip_binders() { 45 | | ty::PredicateAtom::ConstEvaluatable(b_def, b_substs) => { 46 | | debug!( 47 | | "is_const_evaluatable: caller_bound={:?}, {:?}", ... | 60 | | _ => {} // don't care 61 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 44 | if let ty::PredicateAtom::ConstEvaluatable(b_def, b_substs) = pred.skip_binders() { 45 | debug!( 46 | "is_const_evaluatable: caller_bound={:?}, {:?}", 47 | b_def, b_substs 48 | ); 49 | if b_def == def && b_substs == substs { ... warning: the loop variable `i` is used to index `args` --> compiler/rustc_codegen_ssa/src/mir/block.rs:1180:22 | 1180 | for i in 0..tuple.layout.fields.count() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 1180 | for (i, ) in args.iter().enumerate().take(tuple.layout.fields.count()) { | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/const_evaluatable.rs:340:16 | 340 | } else if let &[mir::ProjectionElem::Field(ZERO_FIELD, _)] = p.projection.as_ref() { | ________________^ 341 | | // Only allow field accesses if the given local 342 | | // contains the result of a checked operation. 343 | | if self.checked_op_locals.contains(p.local) { ... | 349 | | self.error(Some(span), "unsupported projection")?; 350 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 340 | } else if let [mir::ProjectionElem::Field(ZERO_FIELD, _)] = *p.projection.as_ref() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ warning: this `if` has identical blocks --> compiler/rustc_codegen_ssa/src/mir/debuginfo.rs:147:49 | 147 | } else if whole_local_var.is_some() { | _________________________________________________^ 148 | | // No need to make up anything, there is a `mir::VarDebugInfo` 149 | | // covering the whole local. 150 | | // FIXME(eddyb) take `whole_local_var.source_info.scope` into ... | 153 | | None 154 | | } else { | |_____________^ | note: same as this --> compiler/rustc_codegen_ssa/src/mir/debuginfo.rs:142:45 | 142 | if arg_index == 0 && has_proj() { | _____________________________________________^ 143 | | // Hide closure environments from debuginfo. 144 | | // FIXME(eddyb) shouldn't `ArgumentVariable` indices 145 | | // be offset to account for the hidden environment? 146 | | None 147 | | } else if whole_local_var.is_some() { | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_ssa/src/mir/intrinsic.rs:584:33 | 584 | Some((t.bit_width().unwrap_or(u64::from(tcx.sess.target.pointer_width)), true)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| u64::from(tcx.sess.target.pointer_width))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/const_evaluatable.rs:487:24 | 487 | } else if let &[mir::ProjectionElem::Field(ONE_FIELD, _)] = p.projection.as_ref() { | ________________________^ 488 | | // Only allow asserts checking the result of a checked operation. 489 | | if self.checked_op_locals.contains(p.local) { 490 | | return Ok(Some(target)); 491 | | } 492 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 487 | } else if let [mir::ProjectionElem::Field(ONE_FIELD, _)] = *p.projection.as_ref() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_ssa/src/mir/intrinsic.rs:587:33 | 587 | Some((t.bit_width().unwrap_or(u64::from(tcx.sess.target.pointer_width)), false)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| u64::from(tcx.sess.target.pointer_width))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: unnecessary closure used to substitute value for `Result::Err` --> compiler/rustc_trait_selection/src/traits/const_evaluatable.rs:555:5 | 555 | / (|| { 556 | | if let Some(a) = AbstractConst::new(tcx, a, a_substs)? { 557 | | if let Some(b) = AbstractConst::new(tcx, b, b_substs)? { 558 | | return Ok(try_unify(tcx, a, b)); ... | 563 | | })() 564 | | .unwrap_or_else(|ErrorReported| true) | |_________________________________________^ | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `unwrap_or` instead | 555 | (|| { 556 | if let Some(a) = AbstractConst::new(tcx, a, a_substs)? { 557 | if let Some(b) = AbstractConst::new(tcx, b, b_substs)? { 558 | return Ok(try_unify(tcx, a, b)); 559 | } 560 | } ... warning: `if` chain can be rewritten with `match` --> compiler/rustc_codegen_ssa/src/mir/rvalue.rs:362:33 | 362 | / ... if dstsz > srcsz { 363 | | ... bx.fpext(llval, ll_t_out) 364 | | ... } else if srcsz > dstsz { 365 | | ... bx.fptrunc(llval, ll_t_out) 366 | | ... } else { 367 | | ... llval 368 | | ... } | |_______________________^ | = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_trait_selection/src/traits/error_reporting/on_unimplemented.rs:94:19 | 94 | }) => self.describe_generator(*body_id).or_else(|| Some("a trait method")), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Use `or` instead: `self.describe_generator(*body_id).or(Some("a trait method"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations warning: this function has too many arguments (8/7) --> compiler/rustc_codegen_ssa/src/mir/rvalue.rs:670:5 | 670 | / pub fn codegen_fat_ptr_binop( 671 | | &mut self, 672 | | bx: &mut Bx, 673 | | op: mir::BinOp, ... | 678 | | _input_ty: Ty<'tcx>, 679 | | ) -> Bx::Value { | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_codegen_ssa/src/traits/builder.rs:295:5 | 295 | unsafe fn delete_basic_block(&mut self, bb: Self::BasicBlock); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:145:30 | 145 | interior_extra_info: Option<(Option, Span, Option, Option)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_codegen_ssa/src/traits/misc.rs:11:10 | 11 | ) -> &RefCell, Option>), Self::Value>>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has too many arguments (11/7) --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:141:5 | 141 | / fn note_obligation_cause_for_async_await( 142 | | &self, 143 | | err: &mut DiagnosticBuilder<'_>, 144 | | interior_or_upvar_span: GeneratorInteriorOrUpvar, ... | 152 | | next_code: Option<&ObligationCauseCode<'tcx>>, 153 | | ); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_codegen_ssa/src/traits/write.rs:38:5 | 38 | / unsafe fn optimize( 39 | | cgcx: &CodegenContext, 40 | | diag_handler: &Handler, 41 | | module: &ModuleCodegen, 42 | | config: &ModuleConfig, 43 | | ) -> Result<(), FatalError>; | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this function has too many arguments (8/7) --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:190:1 | 190 | / fn suggest_restriction( 191 | | tcx: TyCtxt<'tcx>, 192 | | generics: &hir::Generics<'tcx>, 193 | | msg: &str, ... | 198 | | super_traits: Option<(&Ident, &hir::GenericBounds<'_>)>, 199 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_codegen_ssa/src/traits/write.rs:44:5 | 44 | / unsafe fn optimize_thin( 45 | | cgcx: &CodegenContext, 46 | | thin: &mut ThinModule, 47 | | ) -> Result, FatalError>; | |_________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_codegen_ssa/src/traits/write.rs:48:5 | 48 | / unsafe fn codegen( 49 | | cgcx: &CodegenContext, 50 | | diag_handler: &Handler, 51 | | module: ModuleCodegen, 52 | | config: &ModuleConfig, 53 | | ) -> Result; | |____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:258:29 | 258 | .filter(|p| match p.kind { | _____________________________^ 259 | | hir::GenericParamKind::Type { 260 | | synthetic: Some(hir::SyntheticTyParamKind::ImplTrait), 261 | | .. 262 | | } => false, 263 | | _ => true, 264 | | }) | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 258 | .filter(|p| !matches!(p.kind, hir::GenericParamKind::Type { 259 | synthetic: Some(hir::SyntheticTyParamKind::ImplTrait), 260 | .. 261 | })) | warning: usage of `Rc` when T is a buffer type --> compiler/rustc_codegen_ssa/src/lib.rs:118:47 | 118 | pub native_libraries: FxHashMap>>, | ^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[NativeLib]>` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: usage of `Rc` when T is a buffer type --> compiler/rustc_codegen_ssa/src/lib.rs:120:25 | 120 | pub used_libraries: Lrc>, | ^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[NativeLib]>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: usage of `Rc` when T is a buffer type --> compiler/rustc_codegen_ssa/src/lib.rs:121:20 | 121 | pub link_args: Lrc>, | ^^^^^^^^^^^^^^^^ help: try: `Rc<[String]>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:1449:9 | 1449 | / typeck_results 1450 | | .generator_interior_types 1451 | | .iter() 1452 | | .find(|ty::GeneratorInteriorTypeCause { ty, .. }| ty_matches(ty)) ... | 1472 | | interior_extra_info = Some((*scope_span, *yield_span, *expr, from_awaited_ty)); 1473 | | }); | |______________^ | = note: `#[warn(clippy::option_map_unit_fn)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn help: try this | 1449 | if let Some(cause) = typeck_results 1450 | .generator_interior_types 1451 | .iter() 1452 | .find(|ty::GeneratorInteriorTypeCause { ty, .. }| ty_matches(ty)) { ... } | warning: 45 warnings emitted warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs:1505:30 | 1505 | interior_extra_info: Option<(Option, Span, Option, Option)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:830:38 | 830 | .map(|arg| match arg.clone().kind { | ^^^^^^^^^^^ | = note: `#[warn(clippy::clone_double_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 830 | .map(|arg| match &(*arg).clone().kind { | ^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 830 | .map(|arg| match <&rustc_hir::Ty>::clone(arg).kind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:863:28 | 863 | let distinct = match &other[..] { | ____________________________^ 864 | | &[ArgKind::Tuple(..)] => true, 865 | | _ => false, 866 | | }; | |_____________^ help: try this: `matches!(&other[..], &[ArgKind::Tuple(..)])` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this will panic at run-time if the environment variable doesn't exist at compile-time --> compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs:991:37 | 991 | format!("rustc version {}", option_env!("CFG_VERSION").expect("CFG_VERSION"),); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::option_env_unwrap)]` on by default = help: consider using the `env!` macro instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_env_unwrap warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:863:28 | 863 | let distinct = match &other[..] { | ____________________________^ 864 | | &[ArgKind::Tuple(..)] => true, 865 | | _ => false, 866 | | }; | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 863 | let distinct = match other[..] { 864 | [ArgKind::Tuple(..)] => true, | warning: all variants have the same postfix: `Tag` --> compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs:1767:1 | 1767 | / enum EnumTagInfo<'ll> { 1768 | | RegularTag { tag_field: Field, tag_type_metadata: &'ll DIType }, 1769 | | OptimizedTag, 1770 | | NoTag, 1771 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_codegen_llvm/src/back/lto.rs:44:6 | 44 | ) -> Result<(Vec, Vec<(SerializedModule, CString)>), FatalError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:925:13 | 925 | / if let &[ArgKind::Tuple(_, ref fields)] = &found_args[..] { 926 | | if fields.len() == expected_args.len() { 927 | | let sugg = fields 928 | | .iter() ... | 938 | | } 939 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 925 | if let [ArgKind::Tuple(_, ref fields)] = found_args[..] { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ warning: this function has too many arguments (9/7) --> compiler/rustc_codegen_llvm/src/asm.rs:338:1 | 338 | / fn inline_asm_call( 339 | | bx: &mut Builder<'a, 'll, 'tcx>, 340 | | asm: &str, 341 | | cons: &str, ... | 347 | | line_spans: &[Span], 348 | | ) -> Option<&'ll Value> { | |_______________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:940:13 | 940 | / if let &[ArgKind::Tuple(_, ref fields)] = &expected_args[..] { 941 | | if fields.len() == found_args.len() && is_closure { 942 | | let sugg = format!( 943 | | "|({}){}|", ... | 975 | | } 976 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 940 | if let [ArgKind::Tuple(_, ref fields)] = expected_args[..] { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/attributes.rs:63:1 | 63 | pub fn emit_uwtable(val: &'ll Value, emit: bool) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/attributes.rs:69:1 | 69 | fn naked(val: &'ll Value, is_naked: bool) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/base.rs:92:1 | 92 | pub fn iter_globals(llmod: &'ll llvm::Module) -> ValueIter<'ll> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:1203:49 | 1203 | let is_normalized_ty_expected = match &obligation.cause.code { | _________________________________________________^ 1204 | | ObligationCauseCode::ItemObligation(_) 1205 | | | ObligationCauseCode::BindingObligation(_, _) 1206 | | | ObligationCauseCode::ObjectCastObligation(_) => false, 1207 | | _ => true, 1208 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 1203 | let is_normalized_ty_expected = !matches!(&obligation.cause.code, ObligationCauseCode::ItemObligation(_) 1204 | | ObligationCauseCode::BindingObligation(_, _) 1205 | | ObligationCauseCode::ObjectCastObligation(_)); | warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/base.rs:96:1 | 96 | / pub fn compile_codegen_unit( 97 | | tcx: TyCtxt<'tcx>, 98 | | cgu_name: Symbol, 99 | | ) -> (ModuleCodegen, u64) { | |_____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:1365:9 | 1365 | / match code { 1366 | | &ObligationCauseCode::BuiltinDerivedObligation(ref data) => { 1367 | | let parent_trait_ref = self.resolve_vars_if_possible(&data.parent_trait_ref); 1368 | | match self.get_parent_trait_ref(&data.parent_code) { ... | 1378 | | _ => None, 1379 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1365 | match *code { 1366 | ObligationCauseCode::BuiltinDerivedObligation(ref data) => { | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs:1418:9 | 1418 | / match var.place.projection[..] { 1419 | | [ 1420 | | // Deref of the `Pin<&mut Self>` state argument. 1421 | | mir::ProjectionElem::Field(..), ... | 1435 | | _ => {} 1436 | | } | |_________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1418 | if let [ 1419 | // Deref of the `Pin<&mut Self>` state argument. 1420 | mir::ProjectionElem::Field(..), 1421 | mir::ProjectionElem::Deref, 1422 | 1423 | // Field of a variant of the state. ... warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:1735:52 | 1735 | || param.bounds.iter().any(|bound| { | ____________________________________________________^ 1736 | | bound.trait_ref().and_then(|trait_ref| trait_ref.trait_def_id()) 1737 | | == self.tcx.lang_items().sized_trait() 1738 | | }) | |_________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs:1827:9 | 1827 | / match self { 1828 | | VariantInfo::Generator { def_id, variant_index, .. } => { 1829 | | let span = 1830 | | cx.tcx.generator_layout(*def_id).variant_source_info[*variant_index].span; ... | 1839 | | _ => {} 1840 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1827 | if let VariantInfo::Generator { def_id, variant_index, .. } = self { 1828 | let span = 1829 | cx.tcx.generator_layout(*def_id).variant_source_info[*variant_index].span; 1830 | if !span.is_dummy() { 1831 | let loc = cx.lookup_debug_loc(span.lo()); 1832 | return Some(SourceInfo { ... warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:1742:13 | 1742 | / match node { 1743 | | hir::Node::Item( 1744 | | item 1745 | | @ ... | 1789 | | _ => {} 1790 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 1742 | if let hir::Node::Item( 1743 | item 1744 | @ 1745 | hir::Item { 1746 | kind: 1747 | hir::ItemKind::Enum(..) ... warning: this function has too many arguments (8/7) --> compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs:2256:1 | 2256 | / fn composite_type_metadata( 2257 | | cx: &CodegenCx<'ll, 'tcx>, 2258 | | composite_type: Ty<'tcx>, 2259 | | composite_type_name: &str, ... | 2267 | | _definition_span: Span, 2268 | | ) -> &'ll DICompositeType { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs:1865:1 | 1865 | / pub fn recursive_type_with_infinite_size_error( 1866 | | tcx: TyCtxt<'tcx>, 1867 | | type_def_id: DefId, 1868 | | spans: Vec, 1869 | | ) { | |__^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_codegen_llvm/src/debuginfo/mod.rs:63:20 | 63 | created_files: RefCell, Option), &'a DIFile>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you should consider adding a `Default` implementation for `traits::fulfill::FulfillmentContext<'tcx>` --> compiler/rustc_trait_selection/src/traits/fulfill.rs:94:5 | 94 | / pub fn new() -> FulfillmentContext<'tcx> { 95 | | FulfillmentContext { 96 | | predicates: ObligationForest::new(), 97 | | register_region_obligations: true, 98 | | usable_in_snapshot: false, 99 | | } 100 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 92 | impl Default for traits::fulfill::FulfillmentContext<'tcx> { 93 | fn default() -> Self { 94 | Self::new() 95 | } 96 | } | warning: stripping a prefix manually --> compiler/rustc_codegen_llvm/src/intrinsic.rs:859:22 | 859 | let n: u64 = name_str["simd_shuffle".len()..].parse().unwrap_or_else(|_| { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::manual_strip)]` on by default note: the prefix was tested here --> compiler/rustc_codegen_llvm/src/intrinsic.rs:858:5 | 858 | if name_str.starts_with("simd_shuffle") { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 858 | if let Some() = name_str.strip_prefix("simd_shuffle") { 859 | let n: u64 = .parse().unwrap_or_else(|_| { | warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_trait_selection/src/traits/object_safety.rs:54:1 | 54 | / fn object_safety_violations( 55 | | tcx: TyCtxt<'tcx>, 56 | | trait_def_id: DefId, 57 | | ) -> &'tcx [ObjectSafetyViolation] { | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_llvm/src/intrinsic.rs:983:53 | 983 | (args[0].immediate(), i.bit_width().unwrap_or(bx.data_layout().pointer_size.bits())) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| bx.data_layout().pointer_size.bits())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_llvm/src/intrinsic.rs:986:53 | 986 | (args[0].immediate(), i.bit_width().unwrap_or(bx.data_layout().pointer_size.bits())) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| bx.data_layout().pointer_size.bits())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_trait_selection/src/traits/on_unimplemented.rs:214:30 | 214 | &mut |c| { | ______________________________^ 215 | | c.ident().map_or(false, |ident| { 216 | | options.contains(&(ident.name, c.value_str().map(|s| s.to_string()))) 217 | | }) 218 | | }, | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_llvm/src/intrinsic.rs:1726:33 | 1726 | Some((t.bit_width().unwrap_or(u64::from(cx.tcx.sess.target.pointer_width)), true)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| u64::from(cx.tcx.sess.target.pointer_width))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: this if-then-else expression returns a bool literal --> compiler/rustc_trait_selection/src/traits/query/dropck_outlives.rs:117:13 | 117 | / if Some(def.did) == tcx.lang_items().manually_drop() { 118 | | // `ManuallyDrop` never has a dtor. 119 | | true 120 | | } else { ... | 125 | | false 126 | | } | |_____________^ help: you can reduce it to: `Some(def.did) == tcx.lang_items().manually_drop()` | = note: `#[warn(clippy::needless_bool)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool warning: use of `unwrap_or` followed by a function call --> compiler/rustc_codegen_llvm/src/intrinsic.rs:1729:33 | 1729 | Some((t.bit_width().unwrap_or(u64::from(cx.tcx.sess.target.pointer_width)), false)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| u64::from(cx.tcx.sess.target.pointer_width))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: unsafe function's docs miss `# Safety` section --> compiler/rustc_codegen_llvm/src/llvm/diagnostic.rs:128:5 | 128 | / pub unsafe fn unpack(di: &'ll DiagnosticInfo) -> Self { 129 | | use super::DiagnosticKind as Dk; 130 | | let kind = super::LLVMRustGetDiagInfoKind(di); 131 | | ... | 166 | | } 167 | | } | |_____^ | = note: `#[warn(clippy::missing_safety_doc)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc warning: this `if` has identical blocks --> compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs:625:81 | 625 | } else if self.tcx().is_object_safe(principal.def_id()) { | _________________________________________________________________________________^ 626 | | principal.with_self_ty(self.tcx(), self_ty) 627 | | } else { | |_________________________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs:623:80 | 623 | if !self.infcx.tcx.features().object_safe_for_dispatch { | ________________________________________________________________________________^ 624 | | principal.with_self_ty(self.tcx(), self_ty) 625 | | } else if self.tcx().is_object_safe(principal.def_id()) { | |_________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/llvm/mod.rs:85:1 | 85 | pub fn SetInstructionCallConv(instr: &'a Value, cc: CallConv) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/llvm/mod.rs:90:1 | 90 | pub fn SetFunctionCallConv(fn_: &'a Value, cc: CallConv) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this `if` has identical blocks --> compiler/rustc_trait_selection/src/traits/select/confirmation.rs:219:67 | 219 | } else if Some(trait_def) == lang_items.clone_trait() { | ___________________________________________________________________^ 220 | | self.copy_clone_conditions(obligation) 221 | | } else { | |_____________^ | note: same as this --> compiler/rustc_trait_selection/src/traits/select/confirmation.rs:217:66 | 217 | } else if Some(trait_def) == lang_items.copy_trait() { | __________________________________________________________________^ 218 | | self.copy_clone_conditions(obligation) 219 | | } else if Some(trait_def) == lang_items.clone_trait() { | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/llvm/mod.rs:109:1 | 109 | pub fn UnsetComdat(val: &'a Value) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/llvm/mod.rs:115:1 | 115 | pub fn SetUnnamedAddress(global: &'a Value, unnamed: UnnamedAddr) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: using `clone` on a `Copy` type --> compiler/rustc_trait_selection/src/traits/select/confirmation.rs:450:21 | 450 | obligation.param_env.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `obligation.param_env` | = note: `#[warn(clippy::clone_on_copy)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: using `clone` on a `Copy` type --> compiler/rustc_trait_selection/src/traits/select/confirmation.rs:488:21 | 488 | obligation.param_env.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `obligation.param_env` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_codegen_llvm/src/llvm/mod.rs:121:1 | 121 | pub fn set_thread_local_mode(global: &'a Value, mode: ThreadLocalMode) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: methods called `new` usually return `Self` --> compiler/rustc_codegen_llvm/src/lib.rs:198:5 | 198 | / pub fn new() -> Box { 199 | | Box::new(LlvmCodegenBackend(())) 200 | | } | |_____^ | = note: `#[warn(clippy::new_ret_no_self)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self warning: 24 warnings emitted warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/select/mod.rs:70:9 | 70 | / match self { 71 | | &IntercrateAmbiguityCause::DownstreamCrate { ref trait_desc, ref self_desc } => { 72 | | let self_desc = if let &Some(ref ty) = self_desc { 73 | | format!(" for type `{}`", ty) ... | 91 | | &IntercrateAmbiguityCause::ReservationImpl { ref message } => message.clone(), 92 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 70 | match *self { 71 | IntercrateAmbiguityCause::DownstreamCrate { ref trait_desc, ref self_desc } => { 72 | let self_desc = if let &Some(ref ty) = self_desc { 73 | format!(" for type `{}`", ty) 74 | } else { 75 | String::new() ... warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/select/mod.rs:72:33 | 72 | let self_desc = if let &Some(ref ty) = self_desc { | _________________________________^ 73 | | format!(" for type `{}`", ty) 74 | | } else { 75 | | String::new() 76 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 72 | let self_desc = if let Some(ref ty) = *self_desc { | ^^^^^^^^^^^^ ^^^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_trait_selection/src/traits/select/mod.rs:80:33 | 80 | let self_desc = if let &Some(ref ty) = self_desc { | _________________________________^ 81 | | format!(" for type `{}`", ty) 82 | | } else { 83 | | String::new() 84 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 80 | let self_desc = if let Some(ref ty) = *self_desc { | ^^^^^^^^^^^^ ^^^^^^^^^^ warning: use of `unwrap_or` followed by a call to `new` --> compiler/rustc_trait_selection/src/traits/select/mod.rs:282:9 | 282 | self.intercrate_ambiguity_causes.take().unwrap_or(vec![]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.intercrate_ambiguity_causes.take().unwrap_or_default()` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_trait_selection/src/traits/select/mod.rs:806:48 | 806 | && stack.iter().skip(1).any(|prev| { | ________________________________________________^ 807 | | stack.obligation.param_env == prev.obligation.param_env 808 | | && self.match_fresh_trait_refs( 809 | | stack.fresh_trait_ref, ... | 812 | | ) 813 | | }) | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_trait_selection/src/traits/select/mod.rs:1176:45 | 1176 | if self.infcx.probe(|_| { | _____________________________________________^ 1177 | | match self.match_normalize_trait_ref( 1178 | | obligation, 1179 | | bound, ... | 1189 | | } 1190 | | }) { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: unneeded `return` statement --> compiler/rustc_trait_selection/src/traits/select/mod.rs:1424:21 | 1424 | / return match tcx.impls_are_allowed_to_overlap(other_def, victim_def) { 1425 | | Some(ty::ImplOverlapKind::Permitted { marker: true }) => { 1426 | | // Subtle: If the predicate we are evaluating has inference 1427 | | // variables, do *not* allow discarding candidates due to ... | 1468 | | None => false, 1469 | | }; | |______________________^ | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 1424 | match tcx.impls_are_allowed_to_overlap(other_def, victim_def) { 1425 | Some(ty::ImplOverlapKind::Permitted { marker: true }) => { 1426 | // Subtle: If the predicate we are evaluating has inference 1427 | // variables, do *not* allow discarding candidates due to 1428 | // marker trait impls. 1429 | // ... warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_trait_selection/src/traits/util.rs:116:58 | 116 | if item.path.iter().rev().skip(1).any(|&(tr, _)| { | __________________________________________________________^ 117 | | anonymize_predicate(tcx, tr.without_const().to_predicate(tcx)) == anon_pred 118 | | }) { | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: match expression looks like `matches!` macro --> compiler/rustc_trait_selection/src/traits/mod.rs:326:35 | 326 | .drain_filter(|predicate| match predicate.skip_binders() { | ___________________________________^ 327 | | ty::PredicateAtom::TypeOutlives(..) => true, 328 | | _ => false, 329 | | }) | |_________^ help: try this: `matches!(predicate.skip_binders(), ty::PredicateAtom::TypeOutlives(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: 53 warnings emitted warning: all variants have the same prefix: `Ffi` --> compiler/rustc_lint/src/types.rs:629:1 | 629 | / enum FfiResult<'tcx> { 630 | | FfiSafe, 631 | | FfiPhantom(Ty<'tcx>), 632 | | FfiUnsafe { ty: Ty<'tcx>, reason: String, help: Option }, 633 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the prefixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: returning the result of a `let` binding from a block --> compiler/rustc_traits/src/chalk/db.rs:321:9 | 320 | let impls = matched_impls.map(chalk_ir::ImplId).collect(); | ---------------------------------------------------------- unnecessary `let` binding 321 | impls | ^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 320 | 321 | matched_impls.map(chalk_ir::ImplId).collect() | warning: module has the same name as its containing module --> compiler/rustc_typeck/src/check/mod.rs:69:1 | 69 | mod check; | ^^^^^^^^^^ | = note: `#[warn(clippy::module_inception)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_traits/src/chalk/db.rs:603:1 | 603 | fn bound_vars_for_item(tcx: TyCtxt<'tcx>, def_id: DefId) -> SubstsRef<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_mir/src/dataflow/framework/fmt.rs:30:13 | 30 | write!(f, "\n")?; | ^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_with_newline)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 30 | writeln!(f, )?; | ^^^^^^^ -- warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/check/check.rs:1015:13 | 1015 | / if !is_implemented && tcx.impl_defaultness(impl_id).is_final() { 1016 | | if !trait_item.defaultness.has_value() { 1017 | | missing_items.push(*trait_item); 1018 | | } 1019 | | } | |_____________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1015 | if !is_implemented && tcx.impl_defaultness(impl_id).is_final() && !trait_item.defaultness.has_value() { 1016 | missing_items.push(*trait_item); 1017 | } | warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_traits/src/chalk/mod.rs:114:24 | 114 | variables: obligation.variables.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::clone_double_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 114 | variables: &(*obligation.variables).clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 114 | variables: <&rustc_middle::ty::List>::clone(obligation.variables), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: literal with an empty format string --> compiler/rustc_mir/src/util/generic_graphviz.rs:131:21 | 131 | attrs = r#"align="center""#, | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_literal)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: literal with an empty format string --> compiler/rustc_mir/src/util/generic_graphviz.rs:132:23 | 132 | colspan = 1, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_traits/src/chalk/mod.rs:139:40 | 139 | ... variables: obligation.variables.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 139 | variables: &(*obligation.variables).clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 139 | variables: <&rustc_middle::ty::List>::clone(obligation.variables), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: this `else { if .. }` block can be collapsed --> compiler/rustc_typeck/src/check/check.rs:1111:16 | 1111 | } else { | ________________^ 1112 | | if let Some(def_spans) = check_packed_inner(tcx, def.did, &mut vec![]) { 1113 | | let mut err = struct_span_err!( 1114 | | tcx.sess, ... | 1149 | | } 1150 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1111 | } else if let Some(def_spans) = check_packed_inner(tcx, def.did, &mut vec![]) { 1112 | let mut err = struct_span_err!( 1113 | tcx.sess, 1114 | sp, 1115 | E0588, 1116 | "packed type cannot transitively contain a `#[repr(align)]` type" ... warning: literal with an empty format string --> compiler/rustc_mir/src/util/graphviz.rs:125:17 | 125 | attrs = r#"align="center""#, | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/check/check.rs:1266:5 | 1266 | / if repr_type_ty == tcx.types.i128 || repr_type_ty == tcx.types.u128 { 1267 | | if !tcx.features().repr128 { 1268 | | feature_err( 1269 | | &tcx.sess.parse_sess, ... | 1275 | | } 1276 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1266 | if (repr_type_ty == tcx.types.i128 || repr_type_ty == tcx.types.u128) && !tcx.features().repr128 { 1267 | feature_err( 1268 | &tcx.sess.parse_sess, 1269 | sym::repr128, 1270 | sp, 1271 | "repr with 128-bit type is unstable", ... warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:109:40 | 107 | / macro_rules! pre_expansion_lint_passes { 108 | | ($macro:path, $args:tt) => { 109 | | $macro!($args, [KeywordIdents: KeywordIdents,]); | |_________-------------------------------^---------------- | || | | || in this macro invocation (#2) 110 | || }; 111 | || } | || - | ||_| | | in this expansion of `pre_expansion_lint_passes!` (#1) 112 | | ... | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |__- in this expansion of `declare_combined_early_pass!` (#2) 141 | 142 | | pre_expansion_lint_passes!(declare_combined_early_pass, [BuiltinCombinedPreExpansionLintPass]); | | ----------------------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |______________________________^ help: replace it with: `KeywordIdents` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | __________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |____________- in this macro invocation (#4) 214 | | ) 215 | | } | |__- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |__- in this expansion of `declare_combined_early_lint_pass!` (#4) | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: you don't need to add `&` to all patterns --> compiler/rustc_traits/src/implied_outlives_bounds.rs:97:13 | 97 | / match obligation.predicate.kind() { 98 | | &ty::PredicateKind::ForAll(..) => vec![], 99 | | &ty::PredicateKind::Atom(atom) => match atom { 100 | | ty::PredicateAtom::Trait(..) ... | 123 | | }, 124 | | } | |_____________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 97 | match *obligation.predicate.kind() { 98 | ty::PredicateKind::ForAll(..) => vec![], 99 | ty::PredicateKind::Atom(atom) => match atom { | warning: 5 warnings emitted warning: all variants have the same postfix: `Node` --> compiler/rustc_passes/src/liveness.rs:121:1 | 121 | / enum LiveNodeKind { 122 | | UpvarNode(Span), 123 | | ExprNode(Span), 124 | | VarDefNode(Span), 125 | | ClosureNode, 126 | | ExitNode, 127 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/check/expr.rs:1595:13 | 1595 | / if !def.is_enum() { 1596 | | if def.non_enum_variant().fields.iter().any(|field| field.ident == field_ident) { 1597 | | add_label = false; 1598 | | err.span_label( ... | 1608 | | } 1609 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1595 | if !def.is_enum() && def.non_enum_variant().fields.iter().any(|field| field.ident == field_ident) { 1596 | add_label = false; 1597 | err.span_label( 1598 | field_ident.span, 1599 | "field not available in `impl Future`, but it is available in its `Output`", 1600 | ); ... warning: this `else { if .. }` block can be collapsed --> compiler/rustc_mir/src/borrow_check/diagnostics/conflict_errors.rs:171:24 | 171 | } else { | ________________________^ 172 | | if let UseSpans::FnSelfUse { var_span, fn_call_span, fn_span, kind } = 173 | | move_spans 174 | | { ... | 251 | | } 252 | | } | |_________________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 171 | } else if let UseSpans::FnSelfUse { var_span, fn_call_span, fn_span, kind } = 172 | move_spans 173 | { 174 | let place_name = self 175 | .describe_place(moved_place.as_ref()) 176 | .map(|n| format!("`{}`", n)) ... warning: this `else { if .. }` block can be collapsed --> compiler/rustc_passes/src/liveness.rs:1563:20 | 1563 | } else { | ____________________^ 1564 | | if let Some(name) = self.should_warn(var) { 1565 | | self.ir.tcx.struct_span_lint_hir( 1566 | | lint::builtin::UNUSED_VARIABLES, ... | 1575 | | } 1576 | | } | |_____________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1563 | } else if let Some(name) = self.should_warn(var) { 1564 | self.ir.tcx.struct_span_lint_hir( 1565 | lint::builtin::UNUSED_VARIABLES, 1566 | var_hir_id, 1567 | vec![upvar.span], 1568 | |lint| { ... warning: this `else { if .. }` block can be collapsed --> compiler/rustc_typeck/src/check/fn_ctxt/suggestions.rs:227:36 | 227 | ... } else { | ______________________________^ 228 | | ... if expr.precedence().order() < ExprPrecedence::MethodCall.order() { 229 | | ... format!("({}){}", receiver, method_call) 230 | | ... } else { 231 | | ... format!("{}{}", receiver, method_call) 232 | | ... } 233 | | ... }; | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 227 | } else if expr.precedence().order() < ExprPrecedence::MethodCall.order() { 228 | format!("({}){}", receiver, method_call) 229 | } else { 230 | format!("{}{}", receiver, method_call) 231 | }; | warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/borrow_check/diagnostics/conflict_errors.rs:1608:9 | 1608 | / if span != assigned_span { 1609 | | if !from_arg { 1610 | | err.span_label(assigned_span, format!("first assignment to {}", place_description)); 1611 | | } 1612 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1608 | if span != assigned_span && !from_arg { 1609 | err.span_label(assigned_span, format!("first assignment to {}", place_description)); 1610 | } | warning: this `else { if .. }` block can be collapsed --> compiler/rustc_typeck/src/check/gather_locals.rs:115:20 | 115 | } else { | ____________________^ 116 | | if !self.fcx.tcx.features().unsized_locals { 117 | | self.fcx.require_type_is_sized(var_ty, p.span, traits::VariableType(p.hir_id)); 118 | | } 119 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 115 | } else if !self.fcx.tcx.features().unsized_locals { 116 | self.fcx.require_type_is_sized(var_ty, p.span, traits::VariableType(p.hir_id)); 117 | } | warning: this `if` statement can be collapsed --> compiler/rustc_passes/src/loops.rs:207:9 | 207 | / if !span.is_desugaring(DesugaringKind::QuestionMark) && self.cx == LabeledBlock { 208 | | if label.label.is_none() { 209 | | struct_span_err!( 210 | | self.sess, ... | 226 | | } 227 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 207 | if !span.is_desugaring(DesugaringKind::QuestionMark) && self.cx == LabeledBlock && label.label.is_none() { 208 | struct_span_err!( 209 | self.sess, 210 | span, 211 | E0695, 212 | "unlabeled `{}` inside of a labeled block", ... warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:118:31 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, | ||_______________________________^ 119 | ||| UnusedBraces: UnusedBraces, 120 | ||| UnusedImportBraces: UnusedImportBraces, 121 | ||| UnsafeCode: UnsafeCode, ... ||| 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `UnusedParens` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: all variants have the same postfix: `Candidate` --> compiler/rustc_typeck/src/check/method/probe.rs:137:1 | 137 | / enum CandidateKind<'tcx> { 138 | | InherentImplCandidate( 139 | | SubstsRef<'tcx>, 140 | | // Normalize obligations ... | 148 | | ), 149 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_passes/src/check_attr.rs:697:46 | 697 | && item.map_or(false, |item| { | ______________________________________________^ 698 | | if let ItemLike::Item(item) = item { 699 | | return is_c_like_enum(item); 700 | | } 701 | | return false; 702 | | })) | |_________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: this `else { if .. }` block can be collapsed --> compiler/rustc_mir/src/borrow_check/diagnostics/mod.rs:228:32 | 228 | } else { | ________________________________^ 229 | | if autoderef { 230 | | // FIXME turn this recursion into iteration 231 | | self.append_place_to_string( ... | 245 | | } 246 | | } | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 228 | } else if autoderef { 229 | // FIXME turn this recursion into iteration 230 | self.append_place_to_string( 231 | PlaceRef { local, projection: proj_base }, 232 | buf, 233 | autoderef, ... warning: unneeded `return` statement --> compiler/rustc_passes/src/check_attr.rs:701:21 | 701 | return false; | ^^^^^^^^^^^^^ help: remove `return`: `false` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/check/method/suggest.rs:1399:21 | 1399 | / if self.span.map_or(true, |span| item.span < span) { 1400 | | if !item.span.from_expansion() { 1401 | | // Don't insert between attributes and an item. 1402 | | if item.attrs.is_empty() { ... | 1412 | | } 1413 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1399 | if self.span.map_or(true, |span| item.span < span) && !item.span.from_expansion() { 1400 | // Don't insert between attributes and an item. 1401 | if item.attrs.is_empty() { 1402 | self.span = Some(item.span.shrink_to_lo()); 1403 | } else { 1404 | // Find the first attribute on the item. ... warning: you don't need to add `&` to all patterns --> compiler/rustc_passes/src/check_const.rs:137:9 | 137 | / match missing_gates.as_slice() { 138 | | &[] => struct_span_err!(tcx.sess, span, E0744, "{}", msg).emit(), 139 | | 140 | | &[missing_primary, ref missing_secondary @ ..] => { ... | 159 | | } 160 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 137 | match *missing_gates.as_slice() { 138 | [] => struct_span_err!(tcx.sess, span, E0744, "{}", msg).emit(), 139 | 140 | [missing_primary, ref missing_secondary @ ..] => { | warning: all variants have the same postfix: `Use` --> compiler/rustc_mir/src/borrow_check/diagnostics/mod.rs:541:1 | 541 | / pub(super) enum UseSpans<'tcx> { 542 | | /// The access is caused by capturing a variable for a closure. 543 | | ClosureUse { 544 | | /// This is true if the captured variable was from a generator. ... | 566 | | OtherUse(Span), 567 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: this `else { if .. }` block can be collapsed --> compiler/rustc_typeck/src/check/wfcheck.rs:1085:12 | 1085 | } else { | ____________^ 1086 | | if !receiver_is_valid(fcx, span, receiver_ty, self_ty, false) { 1087 | | if receiver_is_valid(fcx, span, receiver_ty, self_ty, true) { 1088 | | // Report error; would have worked with `arbitrary_self_types`. ... | 1105 | | } 1106 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1085 | } else if !receiver_is_valid(fcx, span, receiver_ty, self_ty, false) { 1086 | if receiver_is_valid(fcx, span, receiver_ty, self_ty, true) { 1087 | // Report error; would have worked with `arbitrary_self_types`. 1088 | feature_err( 1089 | &fcx.tcx.sess.parse_sess, 1090 | sym::arbitrary_self_types, ... warning: match expression looks like `matches!` macro --> compiler/rustc_passes/src/dead.rs:26:5 | 26 | / match tcx.hir().find(hir_id) { 27 | | Some( 28 | | Node::Item(..) 29 | | | Node::ImplItem(..) ... | 36 | | _ => false, 37 | | } | |_____^ | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 26 | matches!(tcx.hir().find(hir_id), Some( 27 | Node::Item(..) 28 | | Node::ImplItem(..) 29 | | Node::ForeignItem(..) 30 | | Node::TraitItem(..) 31 | | Node::Variant(..) ... warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/borrow_check/type_check/liveness/trace.rs:239:13 | 239 | / if self.cx.initialized_at_terminator(location.block, mpi) { 240 | | if self.drop_live_at.insert(drop_point) { 241 | | self.drop_locations.push(location); 242 | | self.stack.push(drop_point); 243 | | } 244 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 239 | if self.cx.initialized_at_terminator(location.block, mpi) && self.drop_live_at.insert(drop_point) { 240 | self.drop_locations.push(location); 241 | self.stack.push(drop_point); 242 | } | warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/collect.rs:1391:13 | 1391 | / if !allow_defaults && default.is_some() { 1392 | | if !tcx.features().default_type_parameter_fallback { 1393 | | tcx.struct_span_lint_hir( 1394 | | lint::builtin::INVALID_TYPE_PARAM_DEFAULT, ... | 1405 | | } 1406 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1391 | if !allow_defaults && default.is_some() && !tcx.features().default_type_parameter_fallback { 1392 | tcx.struct_span_lint_hir( 1393 | lint::builtin::INVALID_TYPE_PARAM_DEFAULT, 1394 | param.hir_id, 1395 | param.span, 1396 | |lint| { ... warning: match expression looks like `matches!` macro --> compiler/rustc_passes/src/dead.rs:507:27 | 507 | let should_warn = match item.kind { | ___________________________^ 508 | | hir::ItemKind::Static(..) 509 | | | hir::ItemKind::Const(..) 510 | | | hir::ItemKind::Fn(..) ... | 515 | | _ => false, 516 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 507 | let should_warn = matches!(item.kind, hir::ItemKind::Static(..) 508 | | hir::ItemKind::Const(..) 509 | | hir::ItemKind::Fn(..) 510 | | hir::ItemKind::TyAlias(..) 511 | | hir::ItemKind::Enum(..) 512 | | hir::ItemKind::Struct(..) ... warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:119:31 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, 119 | || UnusedBraces: UnusedBraces, | ||_______________________________^ 120 | ||| UnusedImportBraces: UnusedImportBraces, 121 | ||| UnsafeCode: UnsafeCode, 122 | ||| AnonymousParameters: AnonymousParameters, ... ||| 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `UnusedBraces` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_passes/src/diagnostic_items.rs:97:1 | 97 | fn collect<'tcx>(tcx: TyCtxt<'tcx>) -> FxHashMap { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/collect.rs:2804:5 | 2804 | / if !codegen_fn_attrs.target_features.is_empty() { 2805 | | if codegen_fn_attrs.inline == InlineAttr::Always { 2806 | | if let Some(span) = inline_span { 2807 | | tcx.sess.span_err( ... | 2813 | | } 2814 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 2804 | if !codegen_fn_attrs.target_features.is_empty() && codegen_fn_attrs.inline == InlineAttr::Always { 2805 | if let Some(span) = inline_span { 2806 | tcx.sess.span_err( 2807 | span, 2808 | "cannot use `#[inline(always)]` with \ 2809 | `#[target_feature]`", ... warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_passes/src/diagnostic_items.rs:120:1 | 120 | fn collect_all<'tcx>(tcx: TyCtxt<'tcx>) -> FxHashMap { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this `else { if .. }` block can be collapsed --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:348:24 | 348 | } else { | ________________________^ 349 | | if let Err(terr) = self.cx.fully_perform_op( 350 | | location.to_locations(), 351 | | ConstraintCategory::Boring, ... | 365 | | } 366 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 348 | } else if let Err(terr) = self.cx.fully_perform_op( 349 | location.to_locations(), 350 | ConstraintCategory::Boring, 351 | self.cx.param_env.and(type_op::ascribe_user_type::AscribeUserType::new( 352 | constant.literal.ty, 353 | def.did, ... warning: you don't need to add `&` to all patterns --> compiler/rustc_passes/src/intrinsicck.rs:314:17 | 314 | / if let &InlineAsmTemplatePiece::Placeholder { operand_idx, modifier, span } = piece 315 | | { 316 | | if operand_idx == idx && modifier.is_none() { 317 | | spans.push(span); 318 | | } 319 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 314 | if let InlineAsmTemplatePiece::Placeholder { operand_idx, modifier, span } = *piece | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ warning: this `if` statement can be collapsed --> compiler/rustc_typeck/src/collect.rs:2816:5 | 2816 | / if !codegen_fn_attrs.no_sanitize.is_empty() { 2817 | | if codegen_fn_attrs.inline == InlineAttr::Always { 2818 | | if let (Some(no_sanitize_span), Some(inline_span)) = (no_sanitize_span, inline_span) { 2819 | | let hir_id = tcx.hir().local_def_id_to_hir_id(id.expect_local()); ... | 2831 | | } 2832 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 2816 | if !codegen_fn_attrs.no_sanitize.is_empty() && codegen_fn_attrs.inline == InlineAttr::Always { 2817 | if let (Some(no_sanitize_span), Some(inline_span)) = (no_sanitize_span, inline_span) { 2818 | let hir_id = tcx.hir().local_def_id_to_hir_id(id.expect_local()); 2819 | tcx.struct_span_lint_hir( 2820 | lint::builtin::INLINE_NO_SANITIZE, 2821 | hir_id, ... warning: usage of `Rc` when T is a buffer type --> compiler/rustc_passes/src/liveness.rs:193:32 | 193 | capture_info_map: HirIdMap>>, | ^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[CaptureInfo]>` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: redundant field names in struct initialization --> compiler/rustc_typeck/src/mem_categorization.rs:462:39 | 462 | projections.push(Projection { kind: kind, ty: ty }); | ^^^^^^^^^^ help: replace it with: `kind` | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: match expression looks like `matches!` macro --> compiler/rustc_passes/src/liveness.rs:364:28 | 364 | let is_shorthand = match param.pat.kind { | ____________________________^ 365 | | rustc_hir::PatKind::Struct(..) => true, 366 | | _ => false, 367 | | }; | |_________^ help: try this: `matches!(param.pat.kind, rustc_hir::PatKind::Struct(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: redundant field names in struct initialization --> compiler/rustc_typeck/src/mem_categorization.rs:462:51 | 462 | projections.push(Projection { kind: kind, ty: ty }); | ^^^^^^ help: replace it with: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:485:13 | 485 | / if place_ty.variant_index.is_none() { 486 | | if place_ty.ty.references_error() { 487 | | assert!(self.errors_reported); 488 | | return PlaceTy::from_ty(self.tcx().ty_error()); 489 | | } 490 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 485 | if place_ty.variant_index.is_none() && place_ty.ty.references_error() { 486 | assert!(self.errors_reported); 487 | return PlaceTy::from_ty(self.tcx().ty_error()); 488 | } | warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_passes/src/liveness.rs:1602:23 | 1602 | let mut vars: FxIndexMap)> = <_>::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_passes/src/reachable.rs:383:1 | 383 | fn reachable_set<'tcx>(tcx: TyCtxt<'tcx>, crate_num: CrateNum) -> FxHashSet { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_typeck/src/check/_match.rs:139:25 | 139 | / match o.predicate.skip_binders_unchecked() { 140 | | ty::PredicateAtom::Trait(t, constness) => { 141 | | let pred = ty::PredicateAtom::Trait( 142 | | ty::TraitPredicate { ... | 163 | | _ => {} 164 | | } | |_________________________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 139 | if let ty::PredicateAtom::Trait(t, constness) = o.predicate.skip_binders_unchecked() { 140 | let pred = ty::PredicateAtom::Trait( 141 | ty::TraitPredicate { 142 | trait_ref: ty::TraitRef { 143 | def_id: t.def_id(), 144 | substs: self.infcx.tcx.mk_substs_trait(arm_ty, &[]), ... warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_passes/src/stability.rs:179:19 | 179 | (&depr.as_ref().and_then(|(d, _)| d.since), &stab.level) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Use `and` instead: `depr.as_ref().and(d.since)` | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_passes/src/stability.rs:555:1 | 555 | fn new_index(tcx: TyCtxt<'tcx>) -> Index<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: 17 warnings emitted warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/borrow_check/mod.rs:1967:21 | 1967 | / if def.is_union() { 1968 | | if this.move_data.path_map[mpi].iter().any(|moi| { 1969 | | this.move_data.moves[*moi].source.is_predecessor_of(location, this.body) 1970 | | }) { 1971 | | return; 1972 | | } 1973 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1967 | if def.is_union() && this.move_data.path_map[mpi].iter().any(|moi| { 1968 | this.move_data.moves[*moi].source.is_predecessor_of(location, this.body) 1969 | }) { 1970 | return; 1971 | } | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:120:37 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, 119 | || UnusedBraces: UnusedBraces, 120 | || UnusedImportBraces: UnusedImportBraces, | ||_____________________________________^ 121 | ||| UnsafeCode: UnsafeCode, 122 | ||| AnonymousParameters: AnonymousParameters, 123 | ||| EllipsisInclusiveRangePatterns: EllipsisInclusiveRangePatterns::default(), ... ||| 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `UnusedImportBraces` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: you don't need to add `&` to all patterns --> compiler/rustc_typeck/src/check/callee.rs:293:17 | 293 | / if let &ty::Adt(adt_def, ..) = t { 294 | | if adt_def.is_enum() { 295 | | if let hir::ExprKind::Call(ref expr, _) = call_expr.kind { 296 | | unit_variant = ... | 299 | | } 300 | | } | |_________________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 293 | if let ty::Adt(adt_def, ..) = *t { | ^^^^^^^^^^^^^^^^^^^^ ^^ warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_mir_build/src/thir/pattern/_match.rs:519:9 | 519 | write!(f, "\n")?; | ^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_with_newline)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 519 | writeln!(f, )?; | ^^^^^^^ -- warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/interpret/operator.rs:199:17 | 199 | / if bin_op == Rem { 200 | | if r == -1 && l == (1 << (size.bits() - 1)) { 201 | | return Ok((Scalar::from_int(0, size), true, left_layout.ty)); 202 | | } 203 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 199 | if bin_op == Rem && r == -1 && l == (1 << (size.bits() - 1)) { 200 | return Ok((Scalar::from_int(0, size), true, left_layout.ty)); 201 | } | warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_mir_build/src/thir/pattern/_match.rs:533:9 | 533 | write!(f, "{}\n", br)?; | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 533 | writeln!(f, "{}", br)?; | ^^^^^^^ -- warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_typeck/src/check/callee.rs:449:13 | 449 | fn_sig.output().clone(), | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::clone_double_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 449 | &(*fn_sig.output()).clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 449 | <&rustc_middle::ty::TyS>::clone(fn_sig.output()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_mir_build/src/thir/pattern/_match.rs:541:13 | 541 | write!(f, "\n")?; | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 541 | writeln!(f, )?; | ^^^^^^^ -- warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/check.rs:384:1 | 384 | fn check_static_inhabited<'tcx>(tcx: TyCtxt<'tcx>, def_id: LocalDefId, span: Span) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: using `write!()` with a format string that ends in a single newline --> compiler/rustc_mir_build/src/thir/pattern/_match.rs:542:13 | 542 | write!(f, "{}\n", br)?; | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 542 | writeln!(f, "{}", br)?; | ^^^^^^^ -- warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/check.rs:434:1 | 434 | / pub(super) fn check_opaque_for_inheriting_lifetimes( 435 | | tcx: TyCtxt<'tcx>, 436 | | def_id: LocalDefId, 437 | | span: Span, 438 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/monomorphize/collector.rs:1014:17 | 1014 | / if generics.params.is_empty() { 1015 | | if self.mode == MonoItemCollectionMode::Eager { 1016 | | let def_id = self.tcx.hir().local_def_id(item.hir_id); 1017 | | debug!( ... | 1025 | | } 1026 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1014 | if generics.params.is_empty() && self.mode == MonoItemCollectionMode::Eager { 1015 | let def_id = self.tcx.hir().local_def_id(item.hir_id); 1016 | debug!( 1017 | "RootCollector: ADT drop-glue for {}", 1018 | self.tcx.def_path_str(def_id.to_def_id()) 1019 | ); ... warning: this function has too many arguments (9/7) --> compiler/rustc_mir_build/src/build/mod.rs:575:1 | 575 | / fn construct_fn<'a, 'tcx, A>( 576 | | hir: Cx<'a, 'tcx>, 577 | | fn_id: hir::HirId, 578 | | arguments: A, ... | 584 | | span_with_body: Span 585 | | ) -> Body<'tcx> | |_______________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: match expression looks like `matches!` macro --> compiler/rustc_typeck/src/check/check.rs:510:69 | 510 | ItemKind::OpaqueTy(hir::OpaqueTy { origin, .. }) => match origin { | _____________________________________________________________________^ 511 | | hir::OpaqueTyOrigin::AsyncFn => true, 512 | | _ => false, 513 | | }, | |_________________^ help: try this: `matches!(origin, hir::OpaqueTyOrigin::AsyncFn)` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (8/7) --> compiler/rustc_mir_build/src/build/mod.rs:716:5 | 716 | / fn new( 717 | | hir: Cx<'a, 'tcx>, 718 | | def_id: DefId, 719 | | span: Span, ... | 724 | | generator_kind: Option, 725 | | ) -> Builder<'a, 'tcx> { | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: match expression looks like `matches!` macro --> compiler/rustc_typeck/src/check/check.rs:1285:48 | 1285 | let is_unit = |var: &hir::Variant<'_>| match var.data { | ________________________________________________^ 1286 | | hir::VariantData::Unit(..) => true, 1287 | | _ => false, 1288 | | }; | |_________^ help: try this: `matches!(var.data, hir::VariantData::Unit(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:121:29 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 121 | || UnsafeCode: UnsafeCode, | ||_____________________________^ 122 | ||| AnonymousParameters: AnonymousParameters, 123 | ||| EllipsisInclusiveRangePatterns: EllipsisInclusiveRangePatterns::default(), 124 | ||| NonCamelCaseTypes: NonCamelCaseTypes, ... ||| 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `UnsafeCode` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/check.rs:1400:1 | 1400 | fn async_opaque_type_cycle_error(tcx: TyCtxt<'tcx>, span: Span) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this function has too many arguments (9/7) --> compiler/rustc_mir_build/src/build/expr/as_place.rs:281:5 | 281 | / fn lower_index_expression( 282 | | &mut self, 283 | | mut block: BasicBlock, 284 | | base: ExprRef<'tcx>, ... | 290 | | source_info: SourceInfo, 291 | | ) -> BlockAnd> { | |_____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/transform/check_consts/validation.rs:841:17 | 841 | / if callee_is_unstable_unmarked { 842 | | if self.ccx.is_const_stable_const_fn() { 843 | | self.check_op(ops::FnCallUnstable(callee, None)); 844 | | } 845 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 841 | if callee_is_unstable_unmarked && self.ccx.is_const_stable_const_fn() { 842 | self.check_op(ops::FnCallUnstable(callee, None)); 843 | } | warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name --> compiler/rustc_mir_build/src/build/expr/into.rs:20:9 | 20 | &mut self, | ^^^^^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/check.rs:1415:1 | 1415 | fn opaque_type_cycle_error(tcx: TyCtxt<'tcx>, def_id: LocalDefId, span: Span) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/coercion.rs:103:1 | 103 | fn simple(kind: Adjust<'tcx>) -> impl FnOnce(Ty<'tcx>) -> Vec> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_mir_build/src/build/matches/test.rs:54:49 | 54 | kind: TestKind::Eq { value, ty: match_pair.pattern.ty.clone() }, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::clone_double_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 54 | kind: TestKind::Eq { value, ty: &(*match_pair.pattern.ty).clone() }, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 54 | kind: TestKind::Eq { value, ty: <&rustc_middle::ty::TyS>::clone(match_pair.pattern.ty) }, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_typeck/src/check/coercion.rs:923:17 | 923 | / if let &ty::Closure(closure_def_id, _substs) = ty { 924 | | self.tcx.upvars_mentioned(closure_def_id.expect_local()).is_some() 925 | | } else { 926 | | false 927 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 923 | if let ty::Closure(closure_def_id, _substs) = *ty { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ warning: this function has too many arguments (8/7) --> compiler/rustc_mir_build/src/build/matches/test.rs:324:5 | 324 | / fn compare( 325 | | &mut self, 326 | | block: BasicBlock, 327 | | success_block: BasicBlock, ... | 332 | | right: Operand<'tcx>, 333 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/transform/check_packed_ref.rs:41:9 | 41 | / if context.is_borrow() { 42 | | if util::is_disaligned(self.tcx, self.body, self.param_env, *place) { 43 | | let source_info = self.source_info; 44 | | let lint_root = self.body.source_scopes[source_info.scope] ... | 63 | | } 64 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 41 | if context.is_borrow() && util::is_disaligned(self.tcx, self.body, self.param_env, *place) { 42 | let source_info = self.source_info; 43 | let lint_root = self.body.source_scopes[source_info.scope] 44 | .local_data 45 | .as_ref() 46 | .assert_crate_local() ... warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/coercion.rs:1422:5 | 1422 | / fn report_return_mismatched_types<'a>( 1423 | | &self, 1424 | | cause: &ObligationCause<'tcx>, 1425 | | expected: Ty<'tcx>, ... | 1430 | | expression: Option<(&'tcx hir::Expr<'tcx>, hir::HirId)>, 1431 | | ) -> DiagnosticBuilder<'a> { | |______________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir_build/src/build/matches/mod.rs:289:28 | 289 | fake_borrow_temps: &Vec<(Place<'tcx>, Local)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Place<'tcx>, Local)]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir_build/src/build/matches/mod.rs:1594:23 | 1594 | fake_borrows: &Vec<(Place<'tcx>, Local)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Place<'tcx>, Local)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/compare_method.rs:386:1 | 386 | / fn extract_spans_for_error_reporting<'a, 'tcx>( 387 | | infcx: &infer::InferCtxt<'a, 'tcx>, 388 | | param_env: ty::ParamEnv<'tcx>, 389 | | terr: &TypeError<'_>, ... | 394 | | trait_sig: ty::FnSig<'tcx>, 395 | | ) -> (Span, Option) { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (12/7) --> compiler/rustc_mir_build/src/build/matches/mod.rs:1944:5 | 1944 | / fn declare_binding( 1945 | | &mut self, 1946 | | source_info: SourceInfo, 1947 | | visibility_scope: SourceScope, ... | 1956 | | pat_span: Span, 1957 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/transform/check_unsafety.rs:184:9 | 184 | / if context.is_borrow() { 185 | | if util::is_disaligned(self.tcx, self.body, self.param_env, *place) { 186 | | self.require_unsafe( 187 | | UnsafetyViolationKind::BorrowPacked, ... | 190 | | } 191 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 184 | if context.is_borrow() && util::is_disaligned(self.tcx, self.body, self.param_env, *place) { 185 | self.require_unsafe( 186 | UnsafetyViolationKind::BorrowPacked, 187 | UnsafetyViolationDetails::BorrowOfPackedField, 188 | ); 189 | } | warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_typeck/src/check/expr.rs:712:69 | 712 | let return_expr_ty = self.check_expr_with_hint(return_expr, ret_ty.clone()); | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 712 | let return_expr_ty = self.check_expr_with_hint(return_expr, &(*ret_ty).clone()); | ^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 712 | let return_expr_ty = self.check_expr_with_hint(return_expr, <&rustc_middle::ty::TyS>::clone(ret_ty)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir_build/src/thir/pattern/_match.rs:321:1 | 321 | crate fn expand_pattern<'tcx>(pat: Pat<'tcx>) -> Pat<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:122:38 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 122 | || AnonymousParameters: AnonymousParameters, | ||______________________________________^ 123 | ||| EllipsisInclusiveRangePatterns: EllipsisInclusiveRangePatterns::default(), 124 | ||| NonCamelCaseTypes: NonCamelCaseTypes, 125 | ||| DeprecatedAttr: DeprecatedAttr::new(), ... ||| 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `AnonymousParameters` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir_build/src/thir/pattern/check_match.rs:291:63 | 291 | && edef.variants.iter().any(|variant| { | _______________________________________________________________^ 292 | | variant.ident == ident && variant.ctor_kind == CtorKind::Const 293 | | }) | |_________________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you don't need to add `&` to all patterns --> compiler/rustc_typeck/src/check/expr.rs:1142:9 | 1142 | / if let &Some(ref base_expr) = base_expr { 1143 | | // If check_expr_struct_fields hit an error, do not attempt to populate 1144 | | // the fields with the base_expr. This could cause us to hit errors later 1145 | | // when certain fields are assumed to exist that in fact do not. ... | 1173 | | } 1174 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1142 | if let Some(ref base_expr) = *base_expr { | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir_build/src/thir/pattern/const_to_pat.rs:152:9 | 152 | &mut self, | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: 16 warnings emitted warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/transform/check_unsafety.rs:195:13 | 195 | / if context.is_borrow() { 196 | | if util::is_disaligned(self.tcx, self.body, self.param_env, *place) { 197 | | self.require_unsafe( 198 | | UnsafetyViolationKind::BorrowPacked, ... | 201 | | } 202 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 195 | if context.is_borrow() && util::is_disaligned(self.tcx, self.body, self.param_env, *place) { 196 | self.require_unsafe( 197 | UnsafetyViolationKind::BorrowPacked, 198 | UnsafetyViolationDetails::BorrowOfPackedField, 199 | ); 200 | } | warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/expr.rs:1179:5 | 1179 | / fn check_expr_struct_fields( 1180 | | &self, 1181 | | adt_ty: Ty<'tcx>, 1182 | | expected: Expectation<'tcx>, ... | 1187 | | check_completeness: bool, 1188 | | ) -> bool { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this `else { if .. }` block can be collapsed --> compiler/rustc_mir/src/transform/const_prop.rs:1217:28 | 1217 | } else { | ____________________________^ 1218 | | if self.should_const_prop(value) { 1219 | | if let ScalarMaybeUninit::Scalar(scalar) = value_const { 1220 | | *cond = self.operand_from_scalar( ... | 1226 | | } 1227 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1217 | } else if self.should_const_prop(value) { 1218 | if let ScalarMaybeUninit::Scalar(scalar) = value_const { 1219 | *cond = self.operand_from_scalar( 1220 | scalar, 1221 | self.tcx.types.bool, 1222 | source_info.span, ... warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_typeck/src/check/expr.rs:1199:45 | 1199 | let (substs, adt_kind, kind_name) = match &adt_ty.kind() { | _____________________________________________^ 1200 | | &ty::Adt(adt, substs) => (substs, adt.adt_kind(), adt.variant_descr()), 1201 | | _ => span_bug!(span, "non-ADT passed to check_expr_struct_fields"), 1202 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 1199 | let (substs, adt_kind, kind_name) = match adt_ty.kind() { 1200 | ty::Adt(adt, substs) => (substs, adt.adt_kind(), adt.variant_descr()), | warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/transform/inline.rs:266:9 | 266 | / if callsite.callee.def_id().is_local() { 267 | | if callsite.callee.substs.non_erasable_generics().count() == 0 && !hinted { 268 | | debug!(" callee is an exported function - not inlining"); 269 | | return false; 270 | | } 271 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 266 | if callsite.callee.def_id().is_local() && callsite.callee.substs.non_erasable_generics().count() == 0 && !hinted { 267 | debug!(" callee is an exported function - not inlining"); 268 | return false; 269 | } | warning: use of `unwrap_or` followed by a call to `new` --> compiler/rustc_typeck/src/check/fn_ctxt/_impl.rs:121:9 | 121 | deferred_call_resolutions.remove(&closure_def_id).unwrap_or(vec![]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `deferred_call_resolutions.remove(&closure_def_id).unwrap_or_default()` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:124:36 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 124 | || NonCamelCaseTypes: NonCamelCaseTypes, | ||____________________________________^ 125 | ||| DeprecatedAttr: DeprecatedAttr::new(), 126 | ||| WhileTrue: WhileTrue, 127 | ||| NonAsciiIdents: NonAsciiIdents, ... ||| 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `NonCamelCaseTypes` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (9/7) --> compiler/rustc_typeck/src/check/fn_ctxt/checks.rs:93:5 | 93 | / pub(in super::super) fn check_argument_types( 94 | | &self, 95 | | sp: Span, 96 | | expr: &'tcx hir::Expr<'tcx>, ... | 102 | | def_id: Option, 103 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this `else { if .. }` block can be collapsed --> compiler/rustc_mir/src/transform/inline.rs:396:16 | 396 | } else { | ________________^ 397 | | if cost <= threshold { 398 | | debug!("INLINING {:?} [cost={} <= threshold={}]", callsite, cost, threshold); 399 | | true ... | 403 | | } 404 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 396 | } else if cost <= threshold { 397 | debug!("INLINING {:?} [cost={} <= threshold={}]", callsite, cost, threshold); 398 | true 399 | } else { 400 | debug!("NOT inlining {:?} [cost={} > threshold={}]", callsite, cost, threshold); 401 | false ... warning: match expression looks like `matches!` macro --> compiler/rustc_typeck/src/check/fn_ctxt/checks.rs:328:34 | 328 | let is_closure = match arg.kind { | __________________________________^ 329 | | ExprKind::Closure(..) => true, 330 | | _ => false, 331 | | }; | |_________________^ help: try this: `matches!(arg.kind, ExprKind::Closure(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/intrinsic.rs:21:1 | 21 | / fn equate_intrinsic_type<'tcx>( 22 | | tcx: TyCtxt<'tcx>, 23 | | it: &hir::ForeignItem<'_>, 24 | | def_id: DefId, ... | 29 | | output: Ty<'tcx>, 30 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this `if` statement can be collapsed --> compiler/rustc_mir/src/transform/instcombine.rs:249:9 | 249 | / if const_.literal.ty == self.tcx.types.bool 250 | | && const_.literal.val.try_to_bool() == Some(const_to_find) 251 | | { 252 | | if r.place().is_some() { 253 | | return Some(r); 254 | | } 255 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 249 | if const_.literal.ty == self.tcx.types.bool 250 | && const_.literal.val.try_to_bool() == Some(const_to_find) && r.place().is_some() { 251 | return Some(r); 252 | } | warning: usage of `Rc` when T is a buffer type --> compiler/rustc_typeck/src/check/method/probe.rs:65:12 | 65 | steps: Lrc>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[CandidateStep<'tcx>]>` | = note: `#[warn(clippy::rc_buffer)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: all variants have the same postfix: `Equal` --> compiler/rustc_mir/src/transform/simplify_try.rs:757:1 | 757 | / enum StatementEquality { 758 | | /// The two statements are trivially equal; same kind 759 | | TrivialEqual, 760 | | /// The two statements are considered equal, but may be of different kinds. The BasicBlock field is the basic block to jump to when p... ... | 764 | | NotEqual, 765 | | } | |_^ | = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: redundant field names in struct initialization --> compiler/rustc_mir/src/transform/validate.rs:151:78 | 151 | let mut relator: LifetimeIgnoreRelation<'tcx> = LifetimeIgnoreRelation { tcx: tcx, param_env }; | ^^^^^^^^ help: replace it with: `tcx` | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: use of `unwrap_or` followed by a call to `new` --> compiler/rustc_typeck/src/check/method/probe.rs:235:28 | 235 | let method_names = self | ____________________________^ 236 | | .probe_op( 237 | | span, 238 | | mode, ... | 246 | | ) 247 | | .unwrap_or(vec![]); | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 235 | let method_names = self 236 | .probe_op( 237 | span, 238 | mode, 239 | None, 240 | Some(return_type), ... warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/borrow_check/diagnostics/explain_borrow.rs:55:9 | 55 | / match self { 56 | | BorrowExplanation::Unexplained => false, 57 | | _ => true, 58 | | } | |_________^ help: try this: `!matches!(self, BorrowExplanation::Unexplained)` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/method/probe.rs:268:5 | 268 | / pub fn probe_for_name( 269 | | &self, 270 | | span: Span, 271 | | mode: Mode, ... | 276 | | scope: ProbeScope, 277 | | ) -> PickResult<'tcx> { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (10/7) --> compiler/rustc_typeck/src/check/method/probe.rs:295:5 | 295 | / fn probe_op( 296 | | &'a self, 297 | | span: Span, 298 | | mode: Mode, ... | 305 | | op: OP, 306 | | ) -> Result> | |_____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (9/7) --> compiler/rustc_mir/src/borrow_check/diagnostics/move_errors.rs:141:5 | 141 | / fn append_binding_error( 142 | | &self, 143 | | grouped_errors: &mut Vec>, 144 | | kind: IllegalMoveOriginKind<'tcx>, ... | 150 | | statement_span: Span, 151 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: usage of `Rc` when T is a buffer type --> compiler/rustc_typeck/src/check/method/probe.rs:519:16 | 519 | steps: Lrc>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc<[CandidateStep<'tcx>]>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:126:28 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 126 | || WhileTrue: WhileTrue, | ||____________________________^ 127 | ||| NonAsciiIdents: NonAsciiIdents, 128 | ||| IncompleteFeatures: IncompleteFeatures, 129 | ||| RedundantSemicolons: RedundantSemicolons, 130 | ||| UnusedDocComment: UnusedDocComment, 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `WhileTrue` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/method/probe.rs:512:5 | 512 | / fn new( 513 | | fcx: &'a FnCtxt<'a, 'tcx>, 514 | | span: Span, 515 | | mode: Mode, ... | 520 | | is_suggestion: IsSuggestion, 521 | | ) -> ProbeContext<'a, 'tcx> { | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/borrow_check/diagnostics/move_errors.rs:304:26 | 304 | let deref_base = match deref_target_place.projection.as_ref() { | __________________________^ 305 | | &[ref proj_base @ .., ProjectionElem::Deref] => { 306 | | PlaceRef { local: deref_target_place.local, projection: &proj_base } 307 | | } 308 | | _ => bug!("deref_target_place is not a deref projection"), 309 | | }; | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 304 | let deref_base = match *deref_target_place.projection.as_ref() { 305 | [ref proj_base @ .., ProjectionElem::Deref] => { | warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_typeck/src/check/method/probe.rs:1387:43 | 1387 | if self.probe(|_| { | ___________________________________________^ 1388 | | match self.select_trait_candidate(trait_ref) { 1389 | | Err(_) => return true, 1390 | | Ok(Some(impl_source)) ... | 1418 | | false 1419 | | }) { | |_________________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_mir/src/borrow_check/diagnostics/mod.rs:499:9 | 499 | / match ty.kind() { 500 | | ty::Ref( 501 | | ty::RegionKind::ReLateBound(_, br) 502 | | | ty::RegionKind::RePlaceholder(ty::PlaceholderRegion { name: br, .. }), ... | 506 | | _ => {} 507 | | } | |_________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 499 | if let ty::Ref( 500 | ty::RegionKind::ReLateBound(_, br) 501 | | ty::RegionKind::RePlaceholder(ty::PlaceholderRegion { name: br, .. }), 502 | _, 503 | _, 504 | ) = ty.kind() { printer.region_highlight_mode.highlighting_bound_region(*br, counter) } | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/borrow_check/diagnostics/mod.rs:959:17 | 959 | places: &Vec>, | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Operand<'tcx>]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_typeck/src/check/method/suggest.rs:335:33 | 335 | / ... if let &QPath::Resolved(_, ref path) = &qpath { 336 | | ... if let hir::def::Res::Local(hir_id) = path.res { 337 | | ... let span = tcx.hir().span(hir_id); 338 | | ... let snippet = tcx.sess.source_map().span_to_snippet(span); ... | 376 | | ... } 377 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 335 | if let QPath::Resolved(_, ref path) = qpath { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_mir/src/borrow_check/invalidation.rs:168:34 | 168 | let borrow_set = self.borrow_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::clone_double_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 168 | let borrow_set = &(*self.borrow_set).clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 168 | let borrow_set = <&borrow_check::borrow_set::BorrowSet>::clone(self.borrow_set); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: `if` chain can be rewritten with `match` --> compiler/rustc_typeck/src/check/method/suggest.rs:539:17 | 539 | / if static_sources.len() == 1 { 540 | | let ty_str = if let Some(CandidateSource::ImplSource(impl_did)) = 541 | | static_sources.get(0) 542 | | { ... | 570 | | report_candidates(span, &mut err, static_sources, sugg_span); 571 | | } | |_________________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_mir/src/borrow_check/invalidation.rs:180:34 | 180 | let borrow_set = self.borrow_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 180 | let borrow_set = &(*self.borrow_set).clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 180 | let borrow_set = <&borrow_check::borrow_set::BorrowSet>::clone(self.borrow_set); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/method/suggest.rs:958:5 | 958 | / fn suggest_traits_to_import<'b>( 959 | | &self, 960 | | err: &mut DiagnosticBuilder<'_>, 961 | | span: Span, ... | 966 | | unsatisfied_predicates: &[(ty::Predicate<'tcx>, Option>)], 967 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:127:33 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 127 | || NonAsciiIdents: NonAsciiIdents, | ||_________________________________^ 128 | ||| IncompleteFeatures: IncompleteFeatures, 129 | ||| RedundantSemicolons: RedundantSemicolons, 130 | ||| UnusedDocComment: UnusedDocComment, 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `NonAsciiIdents` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_mir/src/borrow_check/invalidation.rs:372:26 | 372 | let borrow_set = self.borrow_set.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 372 | let borrow_set = &(*self.borrow_set).clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 372 | let borrow_set = <&borrow_check::borrow_set::BorrowSet>::clone(self.borrow_set); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: this function has too many arguments (10/7) --> compiler/rustc_typeck/src/check/method/suggest.rs:1426:1 | 1426 | / fn print_disambiguation_help( 1427 | | item_name: Ident, 1428 | | args: Option<&'tcx [hir::Expr<'tcx>]>, 1429 | | err: &mut DiagnosticBuilder<'_>, ... | 1436 | | source_map: &source_map::SourceMap, 1437 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type --> compiler/rustc_mir/src/borrow_check/invalidation.rs:380:14 | 380 | &borrow_set.clone(), | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref help: try dereferencing it | 380 | &&(*borrow_set).clone(), | ^^^^^^^^^^^^^^^^^^^^^^ help: or try being explicit if you are sure, that you want to clone a reference | 380 | &<&borrow_check::borrow_set::BorrowSet>::clone(borrow_set), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: omit braces around single expression condition --> compiler/rustc_typeck/src/check/op.rs:403:24 | 403 | if { | ________________________^ 404 | | self.infcx.type_is_copy_modulo_regions(self.param_env, rty, lhs_expr.span) 405 | | && self 406 | | .lookup_op_method(rty, &[rhs_ty], Op::Binary(op, is_assign)) 407 | | .is_ok() 408 | | } { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions help: try | 403 | if self.infcx.type_is_copy_modulo_regions(self.param_env, rty, lhs_expr.span) 404 | && self 405 | .lookup_op_method(rty, &[rhs_ty], Op::Binary(op, is_assign)) 406 | .is_ok() { | warning: this function has too many arguments (10/7) --> compiler/rustc_mir/src/borrow_check/nll.rs:158:1 | 158 | / pub(in crate::borrow_check) fn compute_regions<'cx, 'tcx>( 159 | | infcx: &InferCtxt<'cx, 'tcx>, 160 | | universal_regions: UniversalRegions<'tcx>, 161 | | body: &Body<'tcx>, ... | 168 | | upvars: &[Upvar], 169 | | ) -> NllOutput<'tcx> { | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/op.rs:548:5 | 548 | / fn check_str_addition( 549 | | &self, 550 | | lhs_expr: &'tcx hir::Expr<'tcx>, 551 | | rhs_expr: &'tcx hir::Expr<'tcx>, ... | 556 | | op: hir::BinOp, 557 | | ) -> bool { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> compiler/rustc_mir/src/borrow_check/path_utils.rs:26:1 | 26 | / pub(super) fn each_borrow_involving_path<'tcx, F, I, S>( 27 | | s: &mut S, 28 | | tcx: TyCtxt<'tcx>, 29 | | body: &Body<'tcx>, ... | 34 | | mut op: F, 35 | | ) where | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/op.rs:873:1 | 873 | fn deref_ty_if_possible(ty: Ty<'tcx>) -> Ty<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/op.rs:943:1 | 943 | / fn suggest_constraining_param( 944 | | tcx: TyCtxt<'_>, 945 | | body_id: hir::HirId, 946 | | mut err: &mut DiagnosticBuilder<'_>, ... | 951 | | set_output: bool, 952 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this if-then-else expression returns a bool literal --> compiler/rustc_mir/src/borrow_check/path_utils.rs:120:5 | 120 | / if reserve_location.dominates(location, dominators) { 121 | | false 122 | | } else { 123 | | // Otherwise, this point is outside the diamond, so ... | 128 | | true 129 | | } | |_____^ help: you can reduce it to: `!reserve_location.dominates(location, dominators)` | = note: `#[warn(clippy::needless_bool)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/borrow_check/region_infer/mod.rs:85:9 | 85 | FxHashMap>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:528:5 | 528 | / fn check_pat_ident( 529 | | &self, 530 | | pat: &'tcx Pat<'tcx>, 531 | | ba: hir::BindingAnnotation, ... | 536 | | ti: TopInfo<'tcx>, 537 | | ) -> Ty<'tcx> { | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/borrow_check/region_infer/mod.rs:252:33 | 252 | closure_bounds_mapping: FxHashMap< | _________________________________^ 253 | | Location, 254 | | FxHashMap<(RegionVid, RegionVid), (ConstraintCategory, Span)>, 255 | | >, | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:668:5 | 668 | / fn check_pat_struct( 669 | | &self, 670 | | pat: &'tcx Pat<'tcx>, 671 | | qpath: &hir::QPath<'_>, ... | 676 | | ti: TopInfo<'tcx>, 677 | | ) -> Ty<'tcx> { | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:128:37 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 128 | || IncompleteFeatures: IncompleteFeatures, | ||_____________________________________^ 129 | ||| RedundantSemicolons: RedundantSemicolons, 130 | ||| UnusedDocComment: UnusedDocComment, 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `IncompleteFeatures` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (10/7) --> compiler/rustc_mir/src/borrow_check/region_infer/mod.rs:245:5 | 245 | / pub(in crate::borrow_check) fn new( 246 | | var_infos: VarInfos, 247 | | universal_regions: Rc>, 248 | | placeholder_indices: Rc, ... | 258 | | elements: &Rc, 259 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: use of `unwrap_or` followed by a call to `new` --> compiler/rustc_mir/src/borrow_check/region_infer/mod.rs:585:37 | 585 | let outlives_requirements = outlives_requirements.unwrap_or(vec![]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `outlives_requirements.unwrap_or_default()` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_typeck/src/check/pat.rs:750:9 | 750 | / match opt_def_id { 751 | | Some(def_id) => match self.tcx.hir().get_if_local(def_id) { 752 | | Some(hir::Node::Item(hir::Item { 753 | | kind: hir::ItemKind::Const(_, body_id), .. ... | 773 | | _ => (), 774 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 750 | if let Some(def_id) = opt_def_id { match self.tcx.hir().get_if_local(def_id) { 751 | Some(hir::Node::Item(hir::Item { 752 | kind: hir::ItemKind::Const(_, body_id), .. 753 | })) => match self.tcx.hir().get(body_id.hir_id) { 754 | hir::Node::Expr(expr) => { 755 | if hir::is_range_literal(expr) { ... warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/borrow_check/region_infer/mod.rs:2070:17 | 2070 | / match categorized_path[*i].0 { 2071 | | ConstraintCategory::OpaqueType 2072 | | | ConstraintCategory::Boring 2073 | | | ConstraintCategory::BoringNoLocation 2074 | | | ConstraintCategory::Internal => false, 2075 | | _ => true, 2076 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 2070 | !matches!(categorized_path[*i].0, ConstraintCategory::OpaqueType 2071 | | ConstraintCategory::Boring 2072 | | ConstraintCategory::BoringNoLocation 2073 | | ConstraintCategory::Internal) | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_typeck/src/check/pat.rs:751:29 | 751 | Some(def_id) => match self.tcx.hir().get_if_local(def_id) { | _____________________________^ 752 | | Some(hir::Node::Item(hir::Item { 753 | | kind: hir::ItemKind::Const(_, body_id), .. 754 | | })) => match self.tcx.hir().get(body_id.hir_id) { ... | 771 | | _ => (), 772 | | }, | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 751 | Some(def_id) => if let Some(hir::Node::Item(hir::Item { 752 | kind: hir::ItemKind::Const(_, body_id), .. 753 | })) = self.tcx.hir().get_if_local(def_id) { match self.tcx.hir().get(body_id.hir_id) { 754 | hir::Node::Expr(expr) => { 755 | if hir::is_range_literal(expr) { 756 | let span = self.tcx.hir().span(body_id.hir_id); ... warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/borrow_check/type_check/constraint_conversion.rs:36:29 | 36 | region_bound_pairs: &'a RegionBoundPairs<'tcx>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_mir/src/borrow_check/type_check/constraint_conversion.rs:33:5 | 33 | / crate fn new( 34 | | infcx: &'a InferCtxt<'a, 'tcx>, 35 | | universal_regions: &'a UniversalRegions<'tcx>, 36 | | region_bound_pairs: &'a RegionBoundPairs<'tcx>, ... | 41 | | constraints: &'a mut MirTypeckRegionConstraints<'tcx>, 42 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/borrow_check/type_check/constraint_conversion.rs:132:22 | 132 | fn to_region_vid(&mut self, r: ty::Region<'tcx>) -> ty::RegionVid { | ^^^^^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_typeck/src/check/pat.rs:754:24 | 754 | })) => match self.tcx.hir().get(body_id.hir_id) { | ________________________^ 755 | | hir::Node::Expr(expr) => { 756 | | if hir::is_range_literal(expr) { 757 | | let span = self.tcx.hir().span(body_id.hir_id); ... | 769 | | _ => (), 770 | | }, | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 754 | })) => if let hir::Node::Expr(expr) = self.tcx.hir().get(body_id.hir_id) { 755 | if hir::is_range_literal(expr) { 756 | let span = self.tcx.hir().span(body_id.hir_id); 757 | if let Ok(snip) = self.tcx.sess.source_map().span_to_snippet(span) { 758 | e.span_suggestion_verbose( 759 | ident.span, ... warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/borrow_check/type_check/liveness/local_use_map.rs:62:22 | 62 | live_locals: &Vec, | ^^^^^^^^^^^ help: change this to: `&[Local]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:778:5 | 778 | / fn emit_bad_pat_path( 779 | | &self, 780 | | mut e: DiagnosticBuilder<'_>, 781 | | pat_span: Span, ... | 786 | | parent_pat: Option<&Pat<'_>>, 787 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir/src/borrow_check/type_check/liveness/mod.rs:86:62 | 86 | if tcx.all_free_regions_meet(&local_decl.ty, |r| { | ______________________________________________________________^ 87 | | free_regions.contains(&r.to_region_vid()) 88 | | }) { | |_____________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:129:38 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 129 | || RedundantSemicolons: RedundantSemicolons, | ||______________________________________^ 130 | ||| UnusedDocComment: UnusedDocComment, 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `RedundantSemicolons` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:850:5 | 850 | / fn check_pat_tuple_struct( 851 | | &self, 852 | | pat: &'tcx Pat<'tcx>, 853 | | qpath: &hir::QPath<'_>, ... | 858 | | ti: TopInfo<'tcx>, 859 | | ) -> Ty<'tcx> { | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (12/7) --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:123:1 | 123 | / pub(crate) fn type_check<'mir, 'tcx>( 124 | | infcx: &InferCtxt<'_, 'tcx>, 125 | | param_env: ty::ParamEnv<'tcx>, 126 | | body: &Body<'tcx>, ... | 135 | | upvars: &[Upvar], 136 | | ) -> MirTypeckResults<'tcx> { | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:961:5 | 961 | / fn e0023( 962 | | &self, 963 | | pat_span: Span, 964 | | res: Res, ... | 969 | | had_err: bool, 970 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:195:25 | 195 | region_bound_pairs: &'a RegionBoundPairs<'tcx>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:1084:5 | 1084 | / fn check_struct_pat_fields( 1085 | | &self, 1086 | | adt_ty: Ty<'tcx>, 1087 | | pat: &'tcx Pat<'tcx>, ... | 1092 | | ti: TopInfo<'tcx>, 1093 | | ) -> bool { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (9/7) --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:190:1 | 190 | / fn type_check_internal<'a, 'tcx, R>( 191 | | infcx: &'a InferCtxt<'a, 'tcx>, 192 | | param_env: ty::ParamEnv<'tcx>, 193 | | body: &'a Body<'tcx>, ... | 199 | | extra: impl FnOnce(TypeChecker<'a, 'tcx>) -> R, 200 | | ) -> R { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/check/pat.rs:1605:5 | 1605 | / fn check_pat_slice( 1606 | | &self, 1607 | | span: Span, 1608 | | before: &'tcx [&'tcx Pat<'tcx>], ... | 1613 | | ti: TopInfo<'tcx>, 1614 | | ) -> Ty<'tcx> { | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:860:9 | 860 | FxHashMap>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: match expression looks like `matches!` macro --> compiler/rustc_typeck/src/check/regionck.rs:357:13 | 357 | / match fk { 358 | | intravisit::FnKind::Closure(..) => true, 359 | | _ => false, 360 | | }, | |_____________^ help: try this: `matches!(fk, intravisit::FnKind::Closure(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:955:29 | 955 | region_bound_pairs: &'a RegionBoundPairs<'tcx>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:1831:17 | 1831 | / if let &Some((_, target)) = destination { 1832 | | self.assert_iscleanup(body, block_data, target, is_cleanup); 1833 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1831 | if let Some((_, target)) = *destination { | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ warning: this `if` has identical blocks --> compiler/rustc_typeck/src/check/wfcheck.rs:831:89 | 831 | } else if predicates.predicates.iter().any(|&(p, _)| p == substituted_pred) { | _________________________________________________________________________________________^ 832 | | // Avoid duplication of predicates that contain no parameters, for example. 833 | | None 834 | | } else { | |_____________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_typeck/src/check/wfcheck.rs:829:13 | 829 | / { 830 | | None 831 | | } else if predicates.predicates.iter().any(|&(p, _)| p == substituted_pred) { | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_typeck/src/check/mod.rs:284:6 | 284 | ) -> Option<(hir::BodyId, Option<&hir::Ty<'_>>, Option<&hir::FnHeader>, Option<&hir::FnDecl<'_>>)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/borrow_check/type_check/mod.rs:1855:17 | 1855 | / if let &Some(target) = destination { 1856 | | self.assert_iscleanup(body, block_data, target, is_cleanup); 1857 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1855 | if let Some(target) = *destination { | ^^^^^^^^^^^^ ^^^^^^^^^^^^ warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/check/mod.rs:662:1 | 662 | / fn get_owner_return_paths( 663 | | tcx: TyCtxt<'tcx>, 664 | | def_id: LocalDefId, 665 | | ) -> Option<(hir::HirId, ReturnsVisitor<'tcx>)> { | |_______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/borrow_check/universal_regions.rs:141:9 | 141 | / match *self { 142 | | DefiningTy::FnDef(..) => true, 143 | | _ => false, 144 | | } | |_________^ help: try this: `matches!(*self, DefiningTy::FnDef(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:130:35 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 130 | || UnusedDocComment: UnusedDocComment, | ||___________________________________^ 131 | ||| ] 132 | ||| ); | |||__________- in this macro invocation (#2) 133 | | | }; 134 | | | } | | |_- in this expansion of `early_lint_passes!` (#1) 135 | | 136 | / macro_rules! declare_combined_early_pass { 137 | ([$name:ident], $passes:tt) => ( 138 | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | ) 140 | | } | |___- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | | -------------------------------------------------------------------------------- in this macro invocation (#1) ... | 259 | | late_lint_mod_passes!(register_passes, register_late_mod_pass); 260 | | } else { | |_______________________________^ help: replace it with: `UnusedDocComment` | ::: compiler/rustc_lint/src/passes.rs:156:1 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | ___________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |_____________- in this macro invocation (#4) 214 | | ) 215 | | } | |___- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 281 | | ) 282 | | } | |___- in this expansion of `declare_combined_early_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/borrow_check/universal_regions.rs:148:9 | 148 | / match *self { 149 | | DefiningTy::Const(..) => true, 150 | | _ => false, 151 | | } | |_________^ help: try this: `matches!(*self, DefiningTy::Const(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_typeck/src/check/mod.rs:768:5 | 768 | / match tcx.eval_static_initializer(id.to_def_id()) { 769 | | Ok(alloc) => { 770 | | if alloc.relocations().len() != 0 { 771 | | let msg = "statics with a custom `#[link_section]` must be a \ ... | 777 | | Err(_) => {} 778 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 768 | if let Ok(alloc) = tcx.eval_static_initializer(id.to_def_id()) { 769 | if alloc.relocations().len() != 0 { 770 | let msg = "statics with a custom `#[link_section]` must be a \ 771 | simple list of bytes on the wasm target with no \ 772 | extra levels of indirection such as references"; 773 | tcx.sess.span_err(span, msg); ... warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/borrow_check/mod.rs:271:29 | 271 | let movable_generator = match tcx.hir().get(id) { | _____________________________^ 272 | | Node::Expr(&hir::Expr { 273 | | kind: hir::ExprKind::Closure(.., Some(hir::Movability::Static)), 274 | | .. 275 | | }) => false, 276 | | _ => true, 277 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 271 | let movable_generator = !matches!(tcx.hir().get(id), Node::Expr(&hir::Expr { 272 | kind: hir::ExprKind::Closure(.., Some(hir::Movability::Static)), 273 | .. 274 | })); | warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir/src/borrow_check/mod.rs:1968:74 | 1968 | if this.move_data.path_map[mpi].iter().any(|moi| { | __________________________________________________________________________^ 1969 | | this.move_data.moves[*moi].source.is_predecessor_of(location, this.body) 1970 | | }) { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: unneeded `return` statement --> compiler/rustc_typeck/src/expr_use_visitor.rs:92:17 | 86 | / macro_rules! return_if_err { 87 | | ($inp: expr) => { 88 | | match $inp { 89 | | Ok(v) => v, ... | 92 | | return; | | ^^^^^^^ help: remove `return` ... | 95 | | }; 96 | | } | |_- in this expansion of `return_if_err!` ... 533 | / return_if_err!(mc.cat_pattern(discr_place.clone(), pat, |place, pat| { 534 | | if let PatKind::Binding(_, canonical_id, ..) = pat.kind { 535 | | debug!("walk_pat: binding place={:?} pat={:?}", place, pat,); 536 | | if let Some(bm) = ... | 568 | | } 569 | | })); | |____________- in this macro invocation | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: if let .. else expression looks like `matches!` macro --> compiler/rustc_mir/src/const_eval/fn_queries.rs:115:12 | 115 | } else if let hir::Node::Ctor(_) = node { | ____________^ 116 | | true 117 | | } else { 118 | | false 119 | | } | |_____^ help: try this: `matches!(node, hir::Node::Ctor(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (9/7) --> compiler/rustc_typeck/src/astconv/generics.rs:93:5 | 93 | / pub fn create_substs_for_generic_args<'b>( 94 | | tcx: TyCtxt<'tcx>, 95 | | def_id: DefId, 96 | | parent_substs: &[subst::GenericArg<'tcx>], ... | 106 | | ) -> subst::GenericArg<'tcx>, 107 | | ) -> SubstsRef<'tcx> { | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this boolean expression can be simplified --> /home/nick/development/rust/rust/library/core/src/macros/mod.rs:57:20 | 39 | / macro_rules! assert_eq { 40 | | ($left:expr, $right:expr $(,)?) => ({ 41 | | match (&$left, &$right) { 42 | | (left_val, right_val) => { ... | 57 | | if !(*left_val == *right_val) { | | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 68 | | }); 69 | | } | |_- in this expansion of `assert_eq!` | ::: compiler/rustc_mir/src/const_eval/fn_queries.rs:141:21 | 141 | / assert_eq!( 142 | | sig.unsafety(), 143 | | hir::Unsafety::Normal, 144 | | "don't mark const unsafe fns as promotable", 145 | | // https://github.com/rust-lang/rust/pull/53851#issuecomment-418760682 146 | | ); | |______________________- in this macro invocation | = note: `#[warn(clippy::nonminimal_bool)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool warning: match expression looks like `matches!` macro --> compiler/rustc_typeck/src/astconv/generics.rs:552:48 | 552 | generics.params.iter().any(|param| match param.kind { | ________________________________________________^ 553 | | ty::GenericParamDefKind::Type { 554 | | synthetic: 555 | | Some( ... | 561 | | _ => false, 562 | | }); | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 552 | generics.params.iter().any(|param| matches!(param.kind, ty::GenericParamDefKind::Type { 553 | synthetic: 554 | Some( 555 | hir::SyntheticTyParamKind::ImplTrait 556 | | hir::SyntheticTyParamKind::FromAttr, 557 | ), ... warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:152:36 | 131 | | ] | |______________________________^ help: replace it with: `UnusedBrokenConst` ... 145 | / macro_rules! late_lint_passes { 146 | ($macro:path, $args:tt) => { 147 | $macro!( | __________- 148 | | $args, 149 | | [ 150 | | // FIXME: Look into regression when this is used as a module lint 151 | | // May Depend on constants elsewhere 152 | UnusedBrokenConst: UnusedBrokenConst, | _____________________________________^ ... 169 | ] 170 | | ); | |___________- in this macro invocation (#2) 171 | | }; 172 | | } | |__- in this expansion of `late_lint_passes!` (#1) ... 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 215 | late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]); | --------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/const_eval/mod.rs:24:1 | 24 | / pub(crate) fn const_caller_location( 25 | | tcx: TyCtxt<'tcx>, 26 | | (file, line, col): (Symbol, u32, u32), 27 | | ) -> ConstValue<'tcx> { | |_____________________^ | = note: `#[warn(clippy::needless_lifetimes)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/dataflow/framework/engine.rs:85:28 | 85 | apply_trans_for_block: Option>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you don't need to add `&` to all patterns --> compiler/rustc_typeck/src/astconv/mod.rs:701:13 | 701 | / if let &hir::GenericBound::Trait(ref ptr, hir::TraitBoundModifier::Maybe) = ab { 702 | | if unbound.is_none() { 703 | | unbound = Some(&ptr.trait_ref); 704 | | } else { 705 | | tcx.sess.emit_err(MultipleRelaxedDefaultBounds { span }); 706 | | } 707 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 701 | if let hir::GenericBound::Trait(ref ptr, hir::TraitBoundModifier::Maybe) = *ab { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/dataflow/framework/engine.rs:140:32 | 140 | apply_trans_for_block: Option>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/astconv/mod.rs:829:5 | 829 | / fn add_predicates_for_ast_type_binding( 830 | | &self, 831 | | hir_ref_id: hir::HirId, 832 | | trait_ref: ty::PolyTraitRef<'tcx>, ... | 837 | | path_span: Span, 838 | | ) -> Result<(), ErrorReported> { | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/dataflow/framework/engine.rs:326:5 | 326 | fn parse(tcx: TyCtxt<'tcx>, def_id: DefId) -> Result { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/coherence/builtin.rs:113:1 | 113 | fn visit_implementation_of_coerce_unsized(tcx: TyCtxt<'tcx>, impl_did: LocalDefId) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/dataflow/move_paths/builder.rs:139:39 | 139 | ... is_index: match elem { | _________________________________^ 140 | | ... ProjectionElem::Index(..) => true, 141 | | ... _ => false, 142 | | ... }, | |_______________________^ help: try this: `matches!(elem, ProjectionElem::Index(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this `.filter_map` can be written more simply using `.filter` --> compiler/rustc_typeck/src/coherence/builtin.rs:182:38 | 182 | let coerced_fields = fields | ______________________________________^ 183 | | .iter() 184 | | .filter_map(|field| { 185 | | let ty_a = field.ty(tcx, substs_a); ... | 212 | | Some(field) 213 | | }) | |______________________^ | = note: `#[warn(clippy::unnecessary_filter_map)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/coherence/builtin.rs:291:1 | 291 | pub fn coerce_unsized_info(tcx: TyCtxt<'tcx>, impl_did: DefId) -> CoerceUnsizedInfo { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_mir/src/interpret/cast.rs:61:40 | 61 | let instance = ty::Instance::resolve_for_fn_ptr( | ________________________________________^ 62 | | *self.tcx, 63 | | self.param_env, 64 | | def_id, 65 | | substs, 66 | | ) 67 | | .ok_or_else(|| err_inval!(TooGeneric))?; | |______________________________________________________________^ | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `ok_or` instead | 61 | let instance = ty::Instance::resolve_for_fn_ptr( 62 | *self.tcx, 63 | self.param_env, 64 | def_id, 65 | substs, 66 | ).ok_or($crate::mir::interpret::InterpError::InvalidProgram( ... warning: match expression looks like `matches!` macro --> compiler/rustc_typeck/src/collect.rs:159:58 | 159 | } else if let Some(arg) = generics.iter().find(|arg| match arg.name { | __________________________________________________________^ 160 | | hir::ParamName::Plain(Ident { name: kw::Underscore, .. }) => true, 161 | | _ => false, 162 | | }) { | |_____^ help: try this: `matches!(arg.name, hir::ParamName::Plain(Ident { name: kw::Underscore, .. }))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_mir/src/interpret/eval_context.rs:647:28 | 647 | let size = elem.size.checked_mul(len, self).ok_or_else(|| { | ____________________________^ 648 | | err_ub!(InvalidMeta("slice is bigger than largest supported object")) 649 | | })?; | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `ok_or` instead | 647 | let size = elem.size.checked_mul(len, self).ok_or({ 648 | err_ub!(InvalidMeta("slice is bigger than largest supported object")) 649 | })?; | warning: this function has too many arguments (8/7) --> compiler/rustc_typeck/src/collect.rs:845:1 | 845 | / fn convert_variant( 846 | | tcx: TyCtxt<'_>, 847 | | variant_did: Option, 848 | | ctor_did: Option, ... | 853 | | parent_did: LocalDefId, 854 | | ) -> ty::VariantDef { | |___________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/interpret/intrinsics/type_name.rs:146:54 | 146 | let args = args.iter().cloned().filter(|arg| match arg.unpack() { | ______________________________________________________^ 147 | | GenericArgKind::Lifetime(_) => false, 148 | | _ => true, 149 | | }); | |_________^ help: try this: `!matches!(arg.unpack(), GenericArgKind::Lifetime(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:156:35 | 131 | | ] | |______________________________^ help: replace it with: `UnstableFeatures` ... 145 | / macro_rules! late_lint_passes { 146 | ($macro:path, $args:tt) => { 147 | $macro!( | __________- 148 | | $args, 149 | | [ 150 | | // FIXME: Look into regression when this is used as a module lint ... | 156 | UnstableFeatures: UnstableFeatures, | ____________________________________^ ... 169 | ] 170 | | ); | |___________- in this macro invocation (#2) 171 | | }; 172 | | } | |__- in this expansion of `late_lint_passes!` (#1) ... 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 215 | late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]); | --------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/interpret/machine.rs:219:10 | 219 | ) -> InterpResult<'tcx, Result<&'a mut LocalValue, MemPlace>> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you don't need to add `&` to all patterns --> compiler/rustc_typeck/src/collect.rs:1903:9 | 1903 | / match predicate { 1904 | | &hir::WherePredicate::BoundPredicate(ref bound_pred) => { 1905 | | let ty = icx.to_ty(&bound_pred.bounded_ty); 1906 | | ... | 1993 | | } 1994 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1903 | match *predicate { 1904 | hir::WherePredicate::BoundPredicate(ref bound_pred) => { 1905 | let ty = icx.to_ty(&bound_pred.bounded_ty); 1906 | 1907 | // Keep the type around in a dummy predicate, in case of no bounds. 1908 | // That way, `where Ty:` is not a complete noop (see #53696) and `Ty` ... warning: you don't need to add `&` to all patterns --> compiler/rustc_typeck/src/collect.rs:1931:21 | 1931 | / match bound { 1932 | | &hir::GenericBound::Trait(ref poly_trait_ref, modifier) => { 1933 | | let constness = match modifier { 1934 | | hir::TraitBoundModifier::MaybeConst => hir::Constness::NotConst, ... | 1971 | | } 1972 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 1931 | match *bound { 1932 | hir::GenericBound::Trait(ref poly_trait_ref, modifier) => { 1933 | let constness = match modifier { 1934 | hir::TraitBoundModifier::MaybeConst => hir::Constness::NotConst, 1935 | hir::TraitBoundModifier::None => constness, 1936 | hir::TraitBoundModifier::Maybe => bug!("this wasn't handled"), ... warning: this if-then-else expression returns a bool literal --> compiler/rustc_typeck/src/collect.rs:2143:17 | 2143 | / if projection.substs == trait_identity_substs 2144 | | && tcx.associated_item(projection.item_def_id).container.id() == def_id 2145 | | { 2146 | | true 2147 | | } else { 2148 | | false 2149 | | } | |_________________^ | = note: `#[warn(clippy::needless_bool)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool help: you can reduce it to | 2143 | projection.substs == trait_identity_substs 2144 | && tcx.associated_item(projection.item_def_id).container.id() == def_id | warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_typeck/src/collect.rs:2181:1 | 2181 | / fn projection_ty_from_predicates( 2182 | | tcx: TyCtxt<'tcx>, 2183 | | key: ( 2184 | | // ty_def_id ... | 2188 | | ), 2189 | | ) -> Option> { | |___________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged --> compiler/rustc_typeck/src/constrained_generic_params.rs:211:13 | 211 | i += 1; | ^ | = note: `#[warn(clippy::mut_range_bound)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs:249:20 | 249 | parent_substs: &Vec>, | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[GenericArg<'tcx>]` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:165:32 | 131 | | ] | |______________________________^ help: replace it with: `ArrayIntoIter` ... 145 | / macro_rules! late_lint_passes { 146 | ($macro:path, $args:tt) => { 147 | $macro!( | __________- 148 | | $args, 149 | | [ 150 | | // FIXME: Look into regression when this is used as a module lint ... | 165 | ArrayIntoIter: ArrayIntoIter, | _________________________________^ ... 169 | ] 170 | | ); | |___________- in this macro invocation (#2) 171 | | }; 172 | | } | |__- in this expansion of `late_lint_passes!` (#1) ... 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 215 | late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]); | --------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_typeck/src/impl_wf_check/min_specialization.rs:270:20 | 270 | parent_substs: &Vec>, | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[GenericArg<'tcx>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: 83 warnings emitted warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:167:39 | 131 | | ] | |______________________________^ help: replace it with: `DropTraitConstraints` ... 145 | / macro_rules! late_lint_passes { 146 | ($macro:path, $args:tt) => { 147 | $macro!( | __________- 148 | | $args, 149 | | [ 150 | | // FIXME: Look into regression when this is used as a module lint ... | 167 | DropTraitConstraints: DropTraitConstraints, | ________________________________________^ 168 | TemporaryCStringAsPtr: TemporaryCStringAsPtr, 169 | ] 170 | | ); | |___________- in this macro invocation (#2) 171 | | }; 172 | | } | |__- in this expansion of `late_lint_passes!` (#1) ... 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 215 | late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]); | --------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:168:40 | 131 | | ] | |______________________________^ help: replace it with: `TemporaryCStringAsPtr` ... 145 | / macro_rules! late_lint_passes { 146 | ($macro:path, $args:tt) => { 147 | $macro!( | __________- 148 | | $args, 149 | | [ 150 | | // FIXME: Look into regression when this is used as a module lint ... | 168 | TemporaryCStringAsPtr: TemporaryCStringAsPtr, | _________________________________________^ 169 | ] 170 | | ); | |___________- in this macro invocation (#2) 171 | | }; 172 | | } | |__- in this expansion of `late_lint_passes!` (#1) ... 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 215 | late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]); | --------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/interpret/machine.rs:292:10 | 292 | ) -> (Cow<'b, Allocation>, Self::PointerTag); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/interpret/memory.rs:80:24 | 80 | pub fn as_instance(self) -> InterpResult<'tcx, Instance<'tcx>> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/interpret/operand.rs:66:32 | 66 | pub fn to_scalar_or_uninit(self) -> ScalarMaybeUninit { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/interpret/operand.rs:74:22 | 74 | pub fn to_scalar(self) -> InterpResult<'tcx, Scalar> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/interpret/operand.rs:79:27 | 79 | pub fn to_scalar_pair(self) -> InterpResult<'tcx, (Scalar, Scalar)> { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/interpret/operand.rs:299:10 | 299 | ) -> InterpResult<'tcx, Result, MPlaceTy<'tcx, M::PointerTag>>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: order comparisons between booleans can be simplified --> compiler/rustc_mir/src/interpret/operator.rs:80:19 | 80 | Lt => l < r, | ^^^^^ help: try simplifying it as shown: `!l & r` | = note: `#[warn(clippy::bool_comparison)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison warning: order comparisons between booleans can be simplified --> compiler/rustc_mir/src/interpret/operator.rs:82:19 | 82 | Gt => l > r, | ^^^^^ help: try simplifying it as shown: `l & !r` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:179:33 | 131 | | ] | |______________________________^ help: replace it with: `HardwiredLints` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | HardwiredLints: HardwiredLints, | __________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/interpret/operator.rs:184:21 | 184 | let op: Option (i128, bool)> = match bin_op { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/interpret/place.rs:145:19 | 145 | pub fn to_ref(self) -> Immediate { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/interpret/terminator.rs:302:36 | 302 | let rust_abi = match caller_abi { | ____________________________________^ 303 | | Abi::Rust | Abi::RustCall => true, 304 | | _ => false, 305 | | }; | |_____________________^ help: try this: `matches!(caller_abi, Abi::Rust | Abi::RustCall)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_mir/src/interpret/traits.rs:83:21 | 83 | / ty::Instance::resolve_for_vtable(tcx, self.param_env, def_id, substs) 84 | | .ok_or_else(|| err_inval!(TooGeneric))?; | |______________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `ok_or` instead | 83 | ty::Instance::resolve_for_vtable(tcx, self.param_env, def_id, substs).ok_or($crate::mir::interpret::InterpError::InvalidProgram( 84 | $crate::mir::interpret::InvalidProgramInfo::$($tt)* 85 | ))?; | warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_mir/src/interpret/traits.rs:152:18 | 152 | let ty = args[0].builtin_deref(true).ok_or_else(|| err_ub!(InvalidDropFn(fn_sig)))?.ty; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: Use `ok_or` instead | 152 | let ty = args[0].builtin_deref(true).ok_or($crate::mir::interpret::InterpError::UndefinedBehavior( 153 | $crate::mir::interpret::UndefinedBehaviorInfo::$($tt)* 154 | ))?.ty; | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/interpret/validity.rs:155:39 | 155 | fn write_path(out: &mut String, path: &Vec) { | ^^^^^^^^^^^^^^ help: change this to: `&[PathElem]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:180:45 | 131 | | ] | |______________________________^ help: replace it with: `ImproperCTypesDeclarations` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, 180 | ImproperCTypesDeclarations: ImproperCTypesDeclarations, | ______________________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 321 | / try_validation!( 322 | | self.ecx.memory.check_ptr_access_align( 323 | | vtable, 324 | | 3 * self.ecx.tcx.data_layout.pointer_size, // drop, size, align ... | 336 | | { "too small vtable" }, 337 | | ); | |__________________- in this macro invocation | = note: `#[warn(clippy::try_err)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.memory.check_ptr_access_align( 95 | vtable, 96 | 3 * self.ecx.tcx.data_layout.pointer_size, // drop, size, align 97 | Some(self.ecx.tcx.data_layout.pointer_align.abi), 98 | CheckInAllocMsg::InboundsTest, ... warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 338 | / try_validation!( 339 | | self.ecx.read_drop_type_from_vtable(vtable), 340 | | self.path, 341 | | err_ub!(DanglingIntPointer(..)) | ... | 346 | | { "invalid drop function pointer in vtable (function has incompatible signature)" }, 347 | | ); | |__________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.read_drop_type_from_vtable(vtable), 95 | self.path, 96 | err_ub!(DanglingIntPointer(..)) | 97 | err_ub!(InvalidFunctionPointer(..)) | 98 | err_unsup!(ReadBytesAsPointer) => ... warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 348 | / try_validation!( 349 | | self.ecx.read_size_and_align_from_vtable(vtable), 350 | | self.path, 351 | | err_unsup!(ReadPointerAsBytes) => { "invalid size or align in vtable" }, 352 | | ); | |__________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.read_size_and_align_from_vtable(vtable), 95 | self.path, 96 | err_unsup!(ReadPointerAsBytes) => { "invalid size or align in vtable" }, 97 | );), | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:181:44 | 131 | | ] | |______________________________^ help: replace it with: `ImproperCTypesDefinitions` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, 180 | | ImproperCTypesDeclarations: ImproperCTypesDeclarations, 181 | ImproperCTypesDefinitions: ImproperCTypesDefinitions, | _____________________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 356 | let _len = try_validation!( | ____________________________- 357 | | meta.unwrap_meta().to_machine_usize(self.ecx), 358 | | self.path, 359 | | err_unsup!(ReadPointerAsBytes) => { "non-integer slice length in wide pointer" }, 360 | | ); | |_________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | meta.unwrap_meta().to_machine_usize(self.ecx), 95 | self.path, 96 | err_unsup!(ReadPointerAsBytes) => { "non-integer slice length in wide pointer" }, 97 | )), | warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 383 | let place = try_validation!( | _____________________- 384 | | self.ecx.ref_to_mplace(value), 385 | | self.path, 386 | | err_ub!(InvalidUninitBytes(None)) => { "uninitialized {}", kind }, 387 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.ref_to_mplace(value), 95 | self.path, 96 | err_ub!(InvalidUninitBytes(None)) => { "uninitialized {}", kind }, 97 | )), | warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 392 | let size_and_align = try_validation!( | ______________________________- 393 | | self.ecx.size_and_align_of(place.meta, place.layout), 394 | | self.path, 395 | | err_ub!(InvalidMeta(msg)) => { "invalid {} metadata: {}", kind, msg }, 396 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.size_and_align_of(place.meta, place.layout), 95 | self.path, 96 | err_ub!(InvalidMeta(msg)) => { "invalid {} metadata: {}", kind, msg }, 97 | )), | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:182:41 | 131 | | ] | |______________________________^ help: replace it with: `VariantSizeDifferences` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 182 | VariantSizeDifferences: VariantSizeDifferences, | __________________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_mir/src/interpret/validity.rs:397:29 | 397 | let (size, align) = size_and_align | _____________________________^ 398 | | // for the purpose of validity, consider foreign types to have 399 | | // alignment and size determined by the layout (size will be 0, 400 | | // alignment should take attributes into account). 401 | | .unwrap_or_else(|| (place.layout.size, place.layout.align.abi)); | |___________________________________________________________________________^ help: Use `unwrap_or` instead: `size_and_align.unwrap_or((place.layout.size, place.layout.align.abi))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 403 | let ptr: Option<_> = try_validation!( | ______________________________- 404 | | self.ecx.memory.check_ptr_access_align( 405 | | place.ptr, 406 | | size, ... | 429 | | { "a dangling {} (use-after-free)", kind }, 430 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.memory.check_ptr_access_align( 95 | place.ptr, 96 | size, 97 | Some(align), 98 | CheckInAllocMsg::InboundsTest, ... warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 495 | / try_validation!( 496 | | value.to_bool(), 497 | | self.path, 498 | | err_ub!(InvalidBool(..)) | err_ub!(InvalidUninitBytes(None)) => 499 | | { "{}", value } expected { "a boolean" }, 500 | | ); | |__________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | value.to_bool(), 95 | self.path, 96 | err_ub!(InvalidBool(..)) | err_ub!(InvalidUninitBytes(None)) => 97 | { "{}", value } expected { "a boolean" }, 98 | );), | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:183:30 | 131 | | ] | |______________________________^ help: replace it with: `BoxPointers` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 183 | BoxPointers: BoxPointers, | _______________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 505 | / try_validation!( 506 | | value.to_char(), 507 | | self.path, 508 | | err_ub!(InvalidChar(..)) | err_ub!(InvalidUninitBytes(None)) => 509 | | { "{}", value } expected { "a valid unicode scalar value (in `0..=0x10FFFF` but not in `0xD800..=0xDFFF`)" }, 510 | | ); | |__________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | value.to_char(), 95 | self.path, 96 | err_ub!(InvalidChar(..)) | err_ub!(InvalidUninitBytes(None)) => 97 | { "{}", value } expected { "a valid unicode scalar value (in `0..=0x10FFFF` but not in `0xD800..=0xDFFF`)" }, 98 | );), | warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 535 | let place = try_validation!( | _____________________________- 536 | | self.ecx.ref_to_mplace(self.ecx.read_immediate(value)?), 537 | | self.path, 538 | | err_ub!(InvalidUninitBytes(None)) => { "uninitialized raw pointer" }, 539 | | ); | |_________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.ref_to_mplace(self.ecx.read_immediate(value)?), 95 | self.path, 96 | err_ub!(InvalidUninitBytes(None)) => { "uninitialized raw pointer" }, 97 | )), | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:184:33 | 131 | | ] | |______________________________^ help: replace it with: `PathStatements` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 184 | PathStatements: PathStatements, | __________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 565 | let _fn = try_validation!( | ___________________________- 566 | | value.check_init().and_then(|ptr| self.ecx.memory.get_fn(ptr)), 567 | | self.path, 568 | | err_ub!(DanglingIntPointer(..)) | ... | 572 | | { "{}", value } expected { "a function pointer" }, 573 | | ); | |_________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | value.check_init().and_then(|ptr| self.ecx.memory.get_fn(ptr)), 95 | self.path, 96 | err_ub!(DanglingIntPointer(..)) | 97 | err_ub!(InvalidFunctionPointer(..)) | 98 | err_ub!(InvalidUninitBytes(None)) | ... warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 623 | let value = try_validation!( | _____________________- 624 | | value.check_init(), 625 | | self.path, 626 | | err_ub!(InvalidUninitBytes(None)) => { "{}", value } 627 | | expected { "something {}", wrapping_range_format(valid_range, max_hi) }, 628 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | value.check_init(), 95 | self.path, 96 | err_ub!(InvalidUninitBytes(None)) => { "{}", value } 97 | expected { "something {}", wrapping_range_format(valid_range, max_hi) }, 98 | )), | warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 684 | Ok(try_validation!( | ________________- 685 | | this.ecx.read_discriminant(op), 686 | | this.path, 687 | | err_ub!(InvalidTag(val)) => ... | 692 | | { "a pointer" } expected { "a valid enum tag" }, 693 | | ) | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | this.ecx.read_discriminant(op), 95 | this.path, 96 | err_ub!(InvalidTag(val)) => 97 | { "{}", val } expected { "a valid enum tag" }, 98 | err_ub!(InvalidUninitBytes(None)) => ... warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:186:32 | 131 | | ] | |______________________________^ help: replace it with: `UnusedResults` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 186 | UnusedResults: UnusedResults, | _________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: returning an `Err(_)` with the `?` operator --> compiler/rustc_mir/src/interpret/validity.rs:93:23 | 78 | / macro_rules! try_validation { 79 | | ($e:expr, $where:expr, 80 | | $( $( $p:pat )|+ => { $( $what_fmt:expr ),+ } $( expected { $( $expected_fmt:expr ),+ } )? ),+ $(,)? 81 | | ) => {{ ... | 93 | | Err(e) => Err::(e)?, | | ^^^^^^^^^^^^^^^ 94 | | } 95 | | }}; 96 | | } | |_- in this expansion of `try_validation!` ... 799 | / try_validation!( 800 | | self.ecx.memory.read_bytes(mplace.ptr, Size::from_bytes(len)), 801 | | self.path, 802 | | err_ub!(InvalidUninitBytes(..)) => { "uninitialized data in `str`" }, 803 | | ); | |__________________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#try_err help: try this | 93 | Err(e) => return Err(try_validation!( 94 | self.ecx.memory.read_bytes(mplace.ptr, Size::from_bytes(len)), 95 | self.path, 96 | err_ub!(InvalidUninitBytes(..)) => { "uninitialized data in `str`" }, 97 | );), | warning: use of `unwrap_or` followed by a function call --> compiler/rustc_mir/src/monomorphize/collector.rs:445:51 | 445 | before = &s[..positions().nth(before).unwrap_or(s.len())], | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir/src/monomorphize/partitioning/default.rs:245:48 | 245 | .filter_map(|accessor| { | ________________________________________________^ 246 | | // Some accessors might not have been 247 | | // instantiated. We can safely ignore those. 248 | | mono_item_placements.get(accessor) 249 | | }) | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/monomorphize/partitioning/mod.rs:304:1 | 304 | / fn collect_and_partition_mono_items<'tcx>( 305 | | tcx: TyCtxt<'tcx>, 306 | | cnum: CrateNum, 307 | | ) -> (&'tcx DefIdSet, &'tcx [CodegenUnit<'tcx>]) { | |________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: the operation is ineffective. Consider reducing it to `1` --> compiler/rustc_mir/src/shim.rs:170:49 | 170 | let dropee_ptr = Place::from(Local::new(1 + 0)); | ^^^^^ | = note: `#[warn(clippy::identity_op)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `1` --> compiler/rustc_mir/src/shim.rs:307:57 | 307 | let src = tcx.mk_place_deref(Place::from(Local::new(1 + 0))); | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `1` --> compiler/rustc_mir/src/shim.rs:393:67 | 393 | let rcvr = self.tcx.mk_place_deref(Place::from(Local::new(1 + 0))); | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `1` --> compiler/rustc_mir/src/shim.rs:724:32 | 724 | Place::from(Local::new(1 + 0)) | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/add_retag.rs:37:1 | 37 | fn may_be_reference(ty: Ty<'tcx>) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:187:38 | 131 | | ] | |______________________________^ help: replace it with: `NonUpperCaseGlobals` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 187 | NonUpperCaseGlobals: NonUpperCaseGlobals, | _______________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/check_consts/qualifs.rs:171:13 | 171 | / if let &[ref proj_base @ .., ProjectionElem::Deref] = place.projection.as_ref() { 172 | | let base_ty = Place::ty_from(place.local, proj_base, cx.body, cx.tcx).ty; 173 | | if let ty::Ref(..) = base_ty.kind() { 174 | | return in_place::( ... | 179 | | } 180 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 171 | if let [ref proj_base @ .., ProjectionElem::Deref] = *place.projection.as_ref() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/check_consts/qualifs.rs:207:5 | 207 | / while let &[ref proj_base @ .., proj_elem] = projection { 208 | | match proj_elem { 209 | | ProjectionElem::Index(index) if in_local(index) => return true, 210 | | ... | 225 | | projection = proj_base; 226 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 207 | while let [ref proj_base @ .., proj_elem] = *projection { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/check_consts/validation.rs:135:32 | 135 | .find(|(_, block)| match block.terminator().kind { | ________________________________^ 136 | | TerminatorKind::Return => true, 137 | | _ => false, 138 | | }) | |_____________^ help: try this: `matches!(block.terminator().kind, TerminatorKind::Return)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this `if` has identical blocks --> compiler/rustc_mir/src/transform/check_consts/validation.rs:416:33 | 416 | / ... { 417 | | ... // HACK: We shouldn't need the conditional above, but trait 418 | | ... // bounds on containing impl blocks are wrongly being marked as 419 | | ... // "not-const". 420 | | ... self.check_op_spanned(ops::ty::TraitBound(kind), span); 421 | | ... } | |_______________________^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> compiler/rustc_mir/src/transform/check_consts/validation.rs:412:71 | 412 | ... if constness == hir::Constness::Const { | _____________________________________________________________^ 413 | | ... self.check_op_spanned(ops::ty::TraitBound(kind), span); 414 | | ... } else if !tcx.features().const_fn | |_______________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/check_consts/mod.rs:76:1 | 76 | pub fn is_lang_panic_fn(tcx: TyCtxt<'tcx>, def_id: DefId) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/check_consts/mod.rs:82:1 | 82 | / pub fn rustc_allow_const_fn_unstable( 83 | | tcx: TyCtxt<'tcx>, 84 | | def_id: DefId, 85 | | feature_gate: Symbol, 86 | | ) -> bool { | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:188:44 | 131 | | ] | |______________________________^ help: replace it with: `NonShorthandFieldPatterns` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 188 | NonShorthandFieldPatterns: NonShorthandFieldPatterns, | _____________________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/check_consts/mod.rs:100:1 | 100 | pub fn is_const_stable_const_fn(tcx: TyCtxt<'tcx>, def_id: DefId) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_mir/src/transform/check_unsafety.rs:158:17 | 158 | / match (cast_in, cast_out) { 159 | | (CastTy::Ptr(_) | CastTy::FnPtr, CastTy::Int(_)) => { 160 | | self.require_unsafe( 161 | | UnsafetyViolationKind::General, ... | 165 | | _ => {} 166 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 158 | if let (CastTy::Ptr(_) | CastTy::FnPtr, CastTy::Int(_)) = (cast_in, cast_out) { 159 | self.require_unsafe( 160 | UnsafetyViolationKind::General, 161 | UnsafetyViolationDetails::CastOfPointerToInt, 162 | ); 163 | } | warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/check_unsafety.rs:390:9 | 390 | / while let &[ref proj_base @ .., elem] = cursor { 391 | | cursor = proj_base; 392 | | 393 | | match elem { ... | 423 | | } 424 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 390 | while let [ref proj_base @ .., elem] = *cursor { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/transform/const_prop.rs:252:10 | 252 | ) -> InterpResult<'tcx, Result<&'a mut LocalValue, MemPlace>> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir/src/transform/const_prop.rs:595:36 | 595 | if self.use_ecx(|this| { | ____________________________________^ 596 | | let (_res, overflow, _ty) = this.ecx.overflowing_binary_op(op, l, r)?; 597 | | Ok(overflow) 598 | | })? { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_mir/src/transform/coverage/query.rs:89:13 | 89 | / match coverage.kind { 90 | | CoverageKind::Expression { lhs, rhs, .. } => { 91 | | self.update_from_expression_operand(u32::from(lhs)); 92 | | self.update_from_expression_operand(u32::from(rhs)); 93 | | } 94 | | _ => {} 95 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 89 | if let CoverageKind::Expression { lhs, rhs, .. } = coverage.kind { 90 | self.update_from_expression_operand(u32::from(lhs)); 91 | self.update_from_expression_operand(u32::from(rhs)); 92 | } | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:189:35 | 131 | | ] | |______________________________^ help: replace it with: `UnusedAllocation` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 189 | UnusedAllocation: UnusedAllocation, | ____________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/coverage/query.rs:110:1 | 110 | fn coverageinfo_from_mir<'tcx>(tcx: TyCtxt<'tcx>, def_id: DefId) -> CoverageInfo { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/counters.rs:46:25 | 46 | coverage_spans: &Vec, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[CoverageSpan]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/counters.rs:144:25 | 144 | coverage_spans: &Vec, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[CoverageSpan]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/counters.rs:469:19 | 469 | branches: &Vec, | ^^^^^^^^^^^^^^^ help: change this to: `&[BcbBranch]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/counters.rs:513:19 | 513 | branches: &Vec, | ^^^^^^^^^^^^^^^ help: change this to: `&[BcbBranch]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir/src/transform/coverage/counters.rs:523:75 | 523 | if backedge_from_bcbs.iter().any(|&backedge_from_bcb| { | ___________________________________________________________________________^ 524 | | self.bcb_is_dominated_by(backedge_from_bcb, branch.target_bcb) 525 | | }) { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: redundant closure found --> compiler/rustc_mir/src/transform/coverage/debug.rs:133:32 | 133 | &DEBUG_OPTIONS.get_or_init(|| DebugOptions::from_env()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DebugOptions::from_env` | = note: `#[warn(clippy::redundant_closure)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: single-character string constant used as pattern --> compiler/rustc_mir/src/transform/coverage/debug.rs:150:91 | 150 | for setting_str in env_debug_options.replace(" ", "").replace("-", "_").split(",") { | ^^^ help: try using a `char` instead: `','` | = note: `#[warn(clippy::single_char_pattern)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern warning: single-character string constant used as pattern --> compiler/rustc_mir/src/transform/coverage/debug.rs:151:57 | 151 | let mut setting = setting_str.splitn(2, "="); | ^^^ help: try using a `char` instead: `'='` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:191:45 | 131 | | ] | |______________________________^ help: replace it with: `MissingCopyImplementations` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 191 | MissingCopyImplementations: MissingCopyImplementations, | ______________________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: single-character string constant used as pattern --> compiler/rustc_mir/src/transform/coverage/debug.rs:213:39 | 213 | let components = strval.splitn(3, "+"); | ^^^ help: try using a `char` instead: `'+'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern warning: useless conversion to the same type: `rustc_middle::mir::coverage::ExpressionOperandId` --> compiler/rustc_mir/src/transform/coverage/debug.rs:282:25 | 282 | .insert(id.into(), DebugCounter::new(counter_kind.clone(), some_block_label)) | ^^^^^^^^^ help: consider removing `.into()`: `id` | = note: `#[warn(clippy::useless_conversion)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: called `map_or(None, f)` on an `Option` value. This can be done more directly by calling `and_then(f)` instead --> compiler/rustc_mir/src/transform/coverage/debug.rs:290:9 | 290 | / self.some_counters.as_ref().map_or(None, |counters| { 291 | | counters 292 | | .get(&operand) 293 | | .map_or(None, |debug_counter| debug_counter.some_block_label.as_ref()) 294 | | }) | |__________^ | = note: `#[warn(clippy::option_map_or_none)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none help: try using `and_then` instead | 290 | self.some_counters.as_ref().and_then(|counters| { 291 | counters 292 | .get(&operand) 293 | .map_or(None, |debug_counter| debug_counter.some_block_label.as_ref()) 294 | }) | warning: called `map_or(None, f)` on an `Option` value. This can be done more directly by calling `and_then(f)` instead --> compiler/rustc_mir/src/transform/coverage/debug.rs:291:13 | 291 | / counters 292 | | .get(&operand) 293 | | .map_or(None, |debug_counter| debug_counter.some_block_label.as_ref()) | |______________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none help: try using `and_then` instead | 291 | counters 292 | .get(&operand).and_then(|debug_counter| debug_counter.some_block_label.as_ref()) | warning: useless conversion to the same type: `rustc_middle::mir::coverage::ExpressionOperandId` --> compiler/rustc_mir/src/transform/coverage/debug.rs:337:31 | 337 | counters.get(&id.into()) | ^^^^^^^^^ help: consider removing `.into()`: `id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: useless use of `format!` --> compiler/rustc_mir/src/transform/coverage/debug.rs:342:21 | 342 | format!("{}", block_label) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `block_label.to_string()` | = note: `#[warn(clippy::useless_format)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format warning: useless use of `format!` --> compiler/rustc_mir/src/transform/coverage/debug.rs:367:24 | 367 | return format!("{}", self.format_counter_kind(counter_kind)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.format_counter_kind(counter_kind).to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format warning: redundant closure found --> compiler/rustc_mir/src/transform/coverage/debug.rs:427:33 | 427 | .or_insert_with(|| Vec::new()) | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: redundant closure found --> compiler/rustc_mir/src/transform/coverage/debug.rs:453:33 | 453 | .or_insert_with(|| Vec::new()) | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:193:36 | 131 | | ] | |______________________________^ help: replace it with: `MutableTransmutes` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 193 | MutableTransmutes: MutableTransmutes, | _____________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: redundant closure found --> compiler/rustc_mir/src/transform/coverage/debug.rs:524:68 | 524 | used_expression_operands.entry(lhs).or_insert_with(|| Vec::new()).push(id); | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: redundant closure found --> compiler/rustc_mir/src/transform/coverage/debug.rs:525:68 | 525 | used_expression_operands.entry(rhs).or_insert_with(|| Vec::new()).push(id); | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/debug.rs:572:53 | 572 | bcb_counters_without_direct_coverage_spans: &Vec<( | _____________________________________________________^ 573 | | Option, 574 | | BasicCoverageBlock, 575 | | CoverageKind, 576 | | )>, | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 572 | bcb_counters_without_direct_coverage_spans: &[( 573 | Option, 574 | BasicCoverageBlock, 575 | CoverageKind, 576 | )], | warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/debug.rs:634:21 | 634 | coverage_spans: &Vec, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[CoverageSpan]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/debug.rs:654:21 | 654 | coverage_spans: &Vec, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[CoverageSpan]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/coverage/debug.rs:676:31 | 676 | intermediate_expressions: &Vec, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[CoverageKind]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (8/7) --> compiler/rustc_mir/src/transform/coverage/debug.rs:669:1 | 669 | / pub(crate) fn dump_coverage_graphviz( 670 | | tcx: TyCtxt<'tcx>, 671 | | mir_body: &mir::Body<'tcx>, 672 | | pass_name: &str, ... | 677 | | debug_used_expressions: &UsedExpressions, 678 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this creates an owned instance just for comparison --> compiler/rustc_mir/src/transform/coverage/debug.rs:698:36 | 698 | edge_labels.retain(|label| label.to_string() != "unreachable"); | ^^^^^^^^^^^^^^^^^ help: try: `*label` | = note: `#[warn(clippy::cmp_owned)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:194:34 | 131 | | ] | |______________________________^ help: replace it with: `TypeAliasBounds` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 194 | TypeAliasBounds: TypeAliasBounds, | ___________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: length comparison to zero --> compiler/rustc_mir/src/transform/coverage/debug.rs:718:8 | 718 | if unused_expressions.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unused_expressions.is_empty()` | = note: `#[warn(clippy::len_zero)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: length comparison to zero --> compiler/rustc_mir/src/transform/coverage/debug.rs:805:8 | 805 | if non_term_blocks.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!non_term_blocks.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: length comparison to zero --> compiler/rustc_mir/src/transform/coverage/graph.rs:316:17 | 316 | assert!(basic_blocks.len() > 0); | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!basic_blocks.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: redundant closure found --> compiler/rustc_mir/src/transform/coverage/graph.rs:388:33 | 388 | .get_or_insert_with(|| FxHashMap::default()) | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FxHashMap::default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: called `map_or(None, f)` on an `Option` value. This can be done more directly by calling `and_then(f)` instead --> compiler/rustc_mir/src/transform/coverage/graph.rs:414:9 | 414 | self.edge_from_bcbs.take().map_or(None, |m| Some(m.into_iter())) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using `and_then` instead: `self.edge_from_bcbs.take().and_then(|m| Some(m.into_iter()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none warning: called `map_or(None, f)` on an `Option` value. This can be done more directly by calling `and_then(f)` instead --> compiler/rustc_mir/src/transform/coverage/graph.rs:544:13 | 544 | self.context_stack.last_mut().map_or(None, |context| context.worklist.pop()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using `and_then` instead: `self.context_stack.last_mut().and_then(|context| context.worklist.pop())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none warning: length comparison to zero --> compiler/rustc_mir/src/transform/coverage/graph.rs:551:16 | 551 | if self.backedges[next_bcb].len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.backedges[next_bcb].is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/coverage/spans.rs:84:26 | 84 | let is_closure = match statement.kind { | __________________________^ 85 | | StatementKind::Assign(box ( 86 | | _, 87 | | Rvalue::Aggregate(box AggregateKind::Closure(_, _), _), 88 | | )) => true, 89 | | _ => false, 90 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 84 | let is_closure = matches!(statement.kind, StatementKind::Assign(box ( 85 | _, 86 | Rvalue::Aggregate(box AggregateKind::Closure(_, _), _), 87 | ))); | warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_mir/src/transform/coverage/spans.rs:311:25 | 311 | fn to_refined_spans(mut self) -> Vec { | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:195:37 | 131 | | ] | |______________________________^ help: replace it with: `TrivialConstraints` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 195 | TrivialConstraints: TrivialConstraints, | ______________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/coverage/spans.rs:648:1 | 648 | fn filtered_statement_span(statement: &'a Statement<'tcx>, body_span: Span) -> Option { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/coverage/spans.rs:689:1 | 689 | fn filtered_terminator_span(terminator: &'a Terminator<'tcx>, body_span: Span) -> Option { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/coverage/spans.rs:749:5 | 749 | / match term_kind { 750 | | TerminatorKind::Goto { .. } => true, 751 | | _ => false, 752 | | } | |_____^ help: try this: `matches!(term_kind, TerminatorKind::Goto { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: if let .. else expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/coverage/mod.rs:479:19 | 479 | debug_assert!(if let CoverageKind::Expression { .. } = expression { true } else { false }); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches!(expression, CoverageKind::Expression { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/coverage/mod.rs:521:1 | 521 | fn hir_body<'tcx>(tcx: TyCtxt<'tcx>, def_id: DefId) -> &'tcx rustc_hir::Body<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> compiler/rustc_mir/src/transform/dest_prop.rs:194:44 | 194 | if !tcx.consider_optimizing(|| { | ____________________________________________^ 195 | | format!("DestinationPropagation {:?} {:?}", def_id, candidate) 196 | | }) { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_mir/src/transform/dest_prop.rs:365:17 | 365 | / match rvalue { 366 | | Rvalue::Use(Operand::Copy(place) | Operand::Move(place)) => { 367 | | // These might've been turned into self-assignments by the replacement 368 | | // (this includes the original statement we wanted to eliminate). ... | 374 | | _ => {} 375 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 365 | if let Rvalue::Use(Operand::Copy(place) | Operand::Move(place)) = rvalue { 366 | // These might've been turned into self-assignments by the replacement 367 | // (this includes the original statement we wanted to eliminate). 368 | if dest == place { 369 | debug!("{:?} turned into self-assignment, deleting", location); 370 | statement.make_nop(); ... warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:197:31 | 131 | | ] | |______________________________^ help: replace it with: `NonSnakeCase` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 197 | NonSnakeCase: NonSnakeCase, | ________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/early_otherwise_branch.rs:162:5 | 162 | / match terminator.kind { 163 | | TerminatorKind::SwitchInt { .. } => true, 164 | | _ => false, 165 | | } | |_____^ help: try this: `matches!(terminator.kind, TerminatorKind::SwitchInt { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: using `clone` on a `Copy` type --> compiler/rustc_mir/src/transform/early_otherwise_branch.rs:216:59 | 216 | self.find_discriminant_switch_pairing(&discr, target.clone(), value.clone()) | ^^^^^^^^^^^^^^ help: try dereferencing it: `*target` | = note: `#[warn(clippy::clone_on_copy)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: using `clone` on a `Copy` type --> compiler/rustc_mir/src/transform/early_otherwise_branch.rs:216:75 | 216 | self.find_discriminant_switch_pairing(&discr, target.clone(), value.clone()) | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/function_item_references.rs:102:15 | 102 | args: &Vec>, | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Operand<'tcx>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/function_item_references.rs:165:34 | 165 | fn nth_arg_span(&self, args: &Vec>, n: usize) -> Span { | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Operand<'tcx>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. --> compiler/rustc_mir/src/transform/generator.rs:723:13 | 723 | upvars: &Vec>, | ^^^^^^^^^^^^^^ help: change this to: `&[Ty<'tcx>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_mir/src/transform/generator.rs:765:6 | 765 | ) -> ( | ______^ 766 | | FxHashMap, VariantIdx, usize)>, 767 | | GeneratorLayout<'tcx>, 768 | | IndexVec>>, 769 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/instcombine.rs:52:21 | 52 | / if let &[ref proj_l @ .., proj_r] = place.projection.as_ref() { 53 | | place.projection = self.tcx().intern_place_elems(&[proj_r]); 54 | | 55 | | Place { ... | 61 | | unreachable!(); 62 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 52 | if let [ref proj_l @ .., proj_r] = *place.projection.as_ref() { | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/nrvo.rs:135:9 | 135 | / match body.predecessors()[block].as_slice() { 136 | | &[pred] => block = pred, 137 | | _ => return None, 138 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 135 | match *body.predecessors()[block].as_slice() { 136 | [pred] => block = pred, | warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:198:39 | 131 | | ] | |______________________________^ help: replace it with: `InvalidNoMangleItems` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 198 | InvalidNoMangleItems: InvalidNoMangleItems, | ________________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/promote_consts.rs:341:29 | 341 | / ... while let &[ref proj_base @ .., elem] = place_projection { 342 | | ... // FIXME(eddyb) this is probably excessive, with 343 | | ... // the exception of `union` member accesses. 344 | | ... let ty = ... | 353 | | ... place_projection = proj_base; 354 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 341 | while let [ref proj_base @ .., elem] = *place_projection { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/transform/promote_consts.rs:703:21 | 703 | / while let &[ref proj_base @ .., elem] = place_projection { 704 | | // FIXME(eddyb) this is probably excessive, with 705 | | // the exception of `union` member accesses. 706 | | let ty = Place::ty_from(place.local, proj_base, self.body, self.tcx) ... | 714 | | place_projection = proj_base; 715 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 703 | while let [ref proj_base @ .., elem] = *place_projection { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ warning: struct update has no effect, all the fields in the struct have already been specified --> compiler/rustc_mir/src/transform/promote_consts.rs:960:27 | 960 | ..terminator | ^^^^^^^^^^ | = note: `#[warn(clippy::needless_update)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_mir/src/transform/remove_unneeded_drops.rs:39:9 | 39 | / match terminator.kind { 40 | | TerminatorKind::Drop { place, target, .. } => { 41 | | let ty = place.ty(self.body, self.tcx); 42 | | let needs_drop = ty.ty.needs_drop(self.tcx, self.param_env); ... | 47 | | _ => {} 48 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 39 | if let TerminatorKind::Drop { place, target, .. } = terminator.kind { 40 | let ty = place.ty(self.body, self.tcx); 41 | let needs_drop = ty.ty.needs_drop(self.tcx, self.param_env); 42 | if !needs_drop { 43 | self.optimizations.push((location, target)); 44 | } ... warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/simplify_try.rs:517:1 | 517 | fn match_variant_field_place<'tcx>(place: Place<'tcx>) -> Option<(Local, VarField<'tcx>)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: length comparison to zero --> compiler/rustc_mir/src/transform/simplify_try.rs:538:33 | 538 | let did_remove_blocks = opts.len() > 0; | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!opts.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:200:33 | 131 | | ] | |______________________________^ help: replace it with: `UnreachablePub` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 200 | UnreachablePub: UnreachablePub, | __________________________________^ ... 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/simplify_try.rs:618:56 | 618 | || bb.statements.iter().any(|stmt| match stmt.kind { | ________________________________________________________^ 619 | | StatementKind::LlvmInlineAsm(..) => true, 620 | | _ => false, 621 | | }) | |_____________________^ help: try this: `matches!(stmt.kind, StatementKind::LlvmInlineAsm(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> compiler/rustc_mir/src/transform/unreachable_prop.rs:30:70 | 30 | bb_data.statements.iter().any(|stmt: &Statement<'_>| match stmt.kind { | ______________________________________________________________________^ 31 | | StatementKind::LlvmInlineAsm(..) => true, 32 | | _ => false, 33 | | }) | |_________________^ help: try this: `matches!(stmt.kind, StatementKind::LlvmInlineAsm(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this `if` has identical blocks --> compiler/rustc_mir/src/transform/validate.rs:312:80 | 312 | } else if self.mir_phase > MirPhase::GeneratorLowering { | ________________________________________________________________________________^ 313 | | // No more aggregates after drop and generator lowering. 314 | | self.fail( 315 | | location, 316 | | format!("{:?} have been lowered to field assignments", rvalue), 317 | | ) 318 | | } | |_________________________^ | note: same as this --> compiler/rustc_mir/src/transform/validate.rs:305:25 | 305 | / { 306 | | // Generators persist until the state machine transformation, but all 307 | | // other aggregates must have been lowered. 308 | | self.fail( ... | 311 | | ) 312 | | } else if self.mir_phase > MirPhase::GeneratorLowering { | |_________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/mod.rs:455:1 | 455 | fn optimized_mir<'tcx>(tcx: TyCtxt<'tcx>, did: DefId) -> &'tcx Body<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/transform/mod.rs:464:1 | 464 | / fn optimized_mir_of_const_arg<'tcx>( 465 | | tcx: TyCtxt<'tcx>, 466 | | (did, param_did): (LocalDefId, DefId), 467 | | ) -> &'tcx Body<'tcx> { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: this function has too many arguments (9/7) --> compiler/rustc_mir/src/util/borrowck_errors.rs:124:5 | 124 | / crate fn cannot_uniquely_borrow_by_one_closure( 125 | | &self, 126 | | new_loan_span: Span, 127 | | container_name: &str, ... | 133 | | previous_end_span: Option, 134 | | ) -> DiagnosticBuilder<'cx> { | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:201:47 | 131 | | ] | |______________________________^ help: replace it with: `ExplicitOutlivesRequirements` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 201 | ExplicitOutlivesRequirements: ExplicitOutlivesRequirements, | ________________________________________________^ 202 | InvalidValue: InvalidValue, 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this function has too many arguments (10/7) --> compiler/rustc_mir/src/util/borrowck_errors.rs:155:5 | 155 | / crate fn cannot_reborrow_already_uniquely_borrowed( 156 | | &self, 157 | | new_loan_span: Span, 158 | | container_name: &str, ... | 165 | | second_borrow_desc: &str, 166 | | ) -> DiagnosticBuilder<'cx> { | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (10/7) --> compiler/rustc_mir/src/util/borrowck_errors.rs:191:5 | 191 | / crate fn cannot_reborrow_already_borrowed( 192 | | &self, 193 | | span: Span, 194 | | desc_new: &str, ... | 201 | | old_load_end_span: Option, 202 | | ) -> DiagnosticBuilder<'cx> { | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> compiler/rustc_mir/src/util/alignment.rs:42:5 | 42 | / while let &[ref proj_base @ .., elem] = cursor { 43 | | cursor = proj_base; 44 | | 45 | | match elem { ... | 56 | | } 57 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 42 | while let [ref proj_base @ .., elem] = *cursor { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ warning: single-character string constant used as pattern --> compiler/rustc_mir/src/util/generic_graphviz.rs:177:33 | 177 | let lines = label.split("\n").map(|s| dot::escape_html(s)).collect::>(); | ^^^^ help: try using a `char` instead: `'\n'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern warning: length comparison to zero --> compiler/rustc_mir/src/util/spanview.rs:183:11 | 183 | while ordered_viewables.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ordered_viewables.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: length comparison to zero --> compiler/rustc_mir/src/util/spanview.rs:389:11 | 389 | while remaining_viewables.len() > 0 && remaining_viewables[0].span.overlaps(viewable.span) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!remaining_viewables.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/util/spanview.rs:662:1 | 662 | fn fn_span<'tcx>(tcx: TyCtxt<'tcx>, def_id: DefId) -> Span { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) --> compiler/rustc_mir/src/util/spanview.rs:675:1 | 675 | fn hir_body<'tcx>(tcx: TyCtxt<'tcx>, def_id: DefId) -> &'tcx rustc_hir::Body<'tcx> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes warning: 188 warnings emitted warning: redundant field names in struct initialization --> compiler/rustc_lint/src/lib.rs:202:31 | 131 | | ] | |______________________________^ help: replace it with: `InvalidValue` ... 174 | / macro_rules! late_lint_mod_passes { 175 | ($macro:path, $args:tt) => { 176 | $macro!( | __________- 177 | | $args, 178 | | [ 179 | | HardwiredLints: HardwiredLints, ... | 202 | InvalidValue: InvalidValue, | ________________________________^ 203 | ] 204 | | ); | |___________- in this macro invocation (#2) 205 | | }; 206 | | } | |__- in this expansion of `late_lint_mod_passes!` (#1) 207 | 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 217 | late_lint_mod_passes!(declare_combined_late_pass, [BuiltinCombinedModuleLateLintPass]); | --------------------------------------------------------------------------------------- in this macro invocation (#1) | ::: compiler/rustc_lint/src/passes.rs:12:1 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: struct update has no effect, all the fields in the struct have already been specified --> /home/nick/development/rust/rust/compiler/rustc_lint_defs/src/lib.rs:396:19 | 375 | / macro_rules! declare_lint { 376 | | ($(#[$attr:meta])* $vis: vis $NAME: ident, $Level: ident, $desc: expr) => ( 377 | | $crate::declare_lint!( 378 | | $(#[$attr])* $vis $NAME, $Level, $desc, ... | 396 | | ..$crate::FutureIncompatibleInfo::default_fields_for_macro() | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 413 | | ); 414 | | } | |_- in this expansion of `declare_lint!` | ::: compiler/rustc_lint/src/array_into_iter.rs:9:1 | 9 | / declare_lint! { 10 | | /// The `array_into_iter` lint detects calling `into_iter` on arrays. 11 | | /// 12 | | /// ### Example ... | 44 | | }; 45 | | } | |_- in this macro invocation | = note: `#[warn(clippy::needless_update)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update warning: you should consider adding a `Default` implementation for `builtin::MissingDoc` --> compiler/rustc_lint/src/builtin.rs:450:5 | 450 | / pub fn new() -> MissingDoc { 451 | | MissingDoc { doc_hidden_stack: vec![false], private_traits: FxHashSet::default() } 452 | | } | |_____^ | = note: `#[warn(clippy::new_without_default)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 449 | impl Default for builtin::MissingDoc { 450 | fn default() -> Self { 451 | Self::new() 452 | } 453 | } | warning: you should consider adding a `Default` implementation for `builtin::DeprecatedAttr` --> compiler/rustc_lint/src/builtin.rs:912:5 | 912 | / pub fn new() -> DeprecatedAttr { 913 | | DeprecatedAttr { depr_attrs: deprecated_attributes() } 914 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 911 | impl Default for builtin::DeprecatedAttr { 912 | fn default() -> Self { 913 | Self::new() 914 | } 915 | } | warning: you don't need to add `&` to all patterns --> compiler/rustc_lint/src/builtin.rs:939:17 | 939 | / if let &AttributeGate::Gated( 940 | | Stability::Deprecated(link, suggestion), 941 | | ref name, 942 | | ref reason, ... | 948 | | lint_deprecated_attr(cx, attr, &msg, suggestion); 949 | | } | |_________________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 939 | if let AttributeGate::Gated( 940 | Stability::Deprecated(link, suggestion), 941 | ref name, 942 | ref reason, 943 | _, 944 | ) = *g | warning: you should consider adding a `Default` implementation for `builtin::UnnameableTestItems` --> compiler/rustc_lint/src/builtin.rs:1769:5 | 1769 | / pub fn new() -> Self { 1770 | | Self { boundary: None, items_nameable: true } 1771 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 1768 | impl Default for builtin::UnnameableTestItems { 1769 | fn default() -> Self { 1770 | Self::new() 1771 | } 1772 | } | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> compiler/rustc_lint/src/builtin.rs:2761:29 | 2761 | / ... match compare_layouts(a, b) { 2762 | | ... Ok(false) => return false, 2763 | | ... _ => (), // otherwise, continue onto the full, fields comparison 2764 | | ... } | |_______________________^ help: try this: `if let Ok(false) = compare_layouts(a, b) { return false }` | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match warning: unneeded `return` statement --> compiler/rustc_lint/src/context.rs:80:13 | 80 | return lint; | ^^^^^^^^^^^^ help: remove `return`: `lint` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: you don't need to add `&` to all patterns --> compiler/rustc_lint/src/context.rs:79:9 | 79 | / if let &[lint] = lints.as_slice() { 80 | | return lint; 81 | | } else { 82 | | panic!("Found mutliple lints with name `{}`: {:?}", lint_name, lints); 83 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 79 | if let [lint] = *lints.as_slice() { | ^^^^^^ ^^^^^^^^^^^^^^^^^ warning: you should consider adding a `Default` implementation for `context::LintStore` --> compiler/rustc_lint/src/context.rs:133:5 | 133 | / pub fn new() -> LintStore { 134 | | LintStore { 135 | | lints: vec![], 136 | | pre_expansion_passes: vec![], ... | 142 | | } 143 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 132 | impl Default for context::LintStore { 133 | fn default() -> Self { 134 | Self::new() 135 | } 136 | } | warning: sub-expression diverges --> compiler/rustc_lint/src/context.rs:829:50 | 829 | let mut path = print_prefix(self)?; | ^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: sub-expression diverges --> compiler/rustc_lint/src/context.rs:853:50 | 853 | let mut path = print_prefix(self)?; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: unneeded `return` statement --> compiler/rustc_lint/src/methods.rs:71:26 | 71 | _ => return, | ^^^^^^ help: replace `return` with an empty block: `{}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: unneeded `return` statement --> compiler/rustc_lint/src/methods.rs:74:18 | 74 | _ => return, | ^^^^^^ help: replace `return` with an empty block: `{}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_lint/src/nonstandard_style.rs:206:22 | 206 | fn to_snake_case(mut str: &str) -> String { | ^^^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_lint/src/nonstandard_style.rs:390:9 | 390 | / if let &PatKind::Binding(_, hid, ident, _) = &p.kind { 391 | | if let hir::Node::Pat(parent_pat) = cx.tcx.hir().get(cx.tcx.hir().get_parent_node(hid)) 392 | | { 393 | | if let PatKind::Struct(_, field_pats, _) = &parent_pat.kind { ... | 404 | | self.check_snake_case(cx, "variable", &ident); 405 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 390 | if let PatKind::Binding(_, hid, ident, _) = p.kind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_lint/src/unused.rs:863:9 | 863 | / if let &ast::TyKind::Paren(ref r) = &ty.kind { 864 | | match &r.kind { 865 | | &ast::TyKind::TraitObject(..) => {} 866 | | &ast::TyKind::ImplTrait(_, ref bounds) if bounds.len() > 1 => {} ... | 887 | | } 888 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 863 | if let ast::TyKind::Paren(ref r) = ty.kind { | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ warning: you don't need to add `&` to both the expression and the patterns --> compiler/rustc_lint/src/unused.rs:864:13 | 864 | / match &r.kind { 865 | | &ast::TyKind::TraitObject(..) => {} 866 | | &ast::TyKind::ImplTrait(_, ref bounds) if bounds.len() > 1 => {} 867 | | &ast::TyKind::Array(_, ref len) => { ... | 886 | | } 887 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 864 | match r.kind { 865 | ast::TyKind::TraitObject(..) => {} 866 | ast::TyKind::ImplTrait(_, ref bounds) if bounds.len() > 1 => {} 867 | ast::TyKind::Array(_, ref len) => { | warning: you should consider adding a `Default` implementation for `BuiltinCombinedPreExpansionLintPass` --> compiler/rustc_lint/src/passes.rs:258:13 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | _________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |___________- in this macro invocation (#4) 214 | | ) 215 | | } | |_- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 258 | / $v fn new() -> Self { 259 | Self { 260 | $($passes: $constructor,)* 261 | } 262 | | } | |_____________^ ... 281 | | ) 282 | | } | |_- in this expansion of `declare_combined_early_lint_pass!` (#4) | ::: compiler/rustc_lint/src/lib.rs:107:1 | 107 | / macro_rules! pre_expansion_lint_passes { 108 | | ($macro:path, $args:tt) => { 109 | | $macro!($args, [KeywordIdents: KeywordIdents,]); | | ------------------------------------------------ in this macro invocation (#2) 110 | | }; 111 | | } | |_- in this expansion of `pre_expansion_lint_passes!` (#1) ... 136 | / macro_rules! declare_combined_early_pass { 137 | | ([$name:ident], $passes:tt) => ( 138 | | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | | ) 140 | | } | |_- in this expansion of `declare_combined_early_pass!` (#2) 141 | 142 | pre_expansion_lint_passes!(declare_combined_early_pass, [BuiltinCombinedPreExpansionLintPass]); | ----------------------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 257 | impl Default for BuiltinCombinedPreExpansionLintPass { 258 | fn default() -> Self { 259 | Self::new() 260 | } 261 | } 262 | ... warning: you should consider adding a `Default` implementation for `BuiltinCombinedEarlyLintPass` --> compiler/rustc_lint/src/passes.rs:258:13 | 156 | / macro_rules! early_lint_methods { 157 | | ($macro:path, $args:tt) => ( 158 | $macro!($args, [ | __________- 159 | fn check_param(a: &ast::Param); 160 | fn check_ident(a: Ident); 161 | fn check_crate(a: &ast::Crate); ... 212 | fn exit_lint_attrs(a: &[ast::Attribute]); 213 | | ]); | |____________- in this macro invocation (#4) 214 | | ) 215 | | } | |__- in this expansion of `early_lint_methods!` (#3) ... 250 | / macro_rules! declare_combined_early_lint_pass { 251 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], $methods:tt) => ( 252 | | #[allow(non_snake_case)] 253 | | $v struct $name { ... | 258 | / $v fn new() -> Self { 259 | Self { 260 | $($passes: $constructor,)* 261 | } 262 | | } | |______________^ ... 281 | | ) 282 | | } | |__- in this expansion of `declare_combined_early_lint_pass!` (#4) | ::: compiler/rustc_lint/src/lib.rs:113:1 | 113 | / macro_rules! early_lint_passes { 114 | | ($macro:path, $args:tt) => { 115 | | $macro!( | |_________- 116 | || $args, 117 | || [ 118 | || UnusedParens: UnusedParens, ... || 131 | || ] 132 | || ); | ||__________- in this macro invocation (#2) 133 | | }; 134 | | } | |_- in this expansion of `early_lint_passes!` (#1) 135 | 136 | / macro_rules! declare_combined_early_pass { 137 | | ([$name:ident], $passes:tt) => ( 138 | | early_lint_methods!(declare_combined_early_lint_pass, [pub $name, $passes]); | | ---------------------------------------------------------------------------- in this macro invocation (#3) 139 | | ) 140 | | } | |__- in this expansion of `declare_combined_early_pass!` (#2) ... 143 | early_lint_passes!(declare_combined_early_pass, [BuiltinCombinedEarlyLintPass]); | -------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 257 | impl Default for BuiltinCombinedEarlyLintPass { 258 | fn default() -> Self { 259 | Self::new() 260 | } 261 | } 262 | ... warning: you should consider adding a `Default` implementation for `BuiltinCombinedLateLintPass` --> compiler/rustc_lint/src/passes.rs:129:13 | 12 | / macro_rules! late_lint_methods { 13 | | ($macro:path, $args:tt, [$hir:tt]) => ( 14 | | $macro!($args, [$hir], [ | |_________- 15 | || fn check_param(a: &$hir hir::Param<$hir>); 16 | || fn check_body(a: &$hir hir::Body<$hir>); 17 | || fn check_body_post(a: &$hir hir::Body<$hir>); ... || 72 | || fn exit_lint_attrs(a: &$hir [ast::Attribute]); 73 | || ]); | ||___________- in this macro invocation (#4) 74 | | ) 75 | | } | |_- in this expansion of `late_lint_methods!` (#3) ... 121 | / macro_rules! declare_combined_late_lint_pass { 122 | | ([$v:vis $name:ident, [$($passes:ident: $constructor:expr,)*]], [$hir:tt], $methods:tt) => ( 123 | | #[allow(non_snake_case)] 124 | | $v struct $name { ... | 129 | / $v fn new() -> Self { 130 | Self { 131 | $($passes: $constructor,)* 132 | } 133 | | } | |______________^ ... 152 | | ) 153 | | } | |__- in this expansion of `declare_combined_late_lint_pass!` (#4) | ::: compiler/rustc_lint/src/lib.rs:145:1 | 145 | / macro_rules! late_lint_passes { 146 | | ($macro:path, $args:tt) => { 147 | $macro!( | __________- 148 | $args, 149 | [ 150 | // FIXME: Look into regression when this is used as a module lint ... 169 | ] 170 | | ); | |___________- in this macro invocation (#2) 171 | | }; 172 | | } | |__- in this expansion of `late_lint_passes!` (#1) ... 208 | / macro_rules! declare_combined_late_pass { 209 | | ([$v:vis $name:ident], $passes:tt) => ( 210 | | late_lint_methods!(declare_combined_late_lint_pass, [$v $name, $passes], ['tcx]); | | --------------------------------------------------------------------------------- in this macro invocation (#3) 211 | | ) 212 | | } | |__- in this expansion of `declare_combined_late_pass!` (#2) ... 215 | late_lint_passes!(declare_combined_late_pass, [pub BuiltinCombinedLateLintPass]); | --------------------------------------------------------------------------------- in this macro invocation (#1) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try this | 128 | impl Default for BuiltinCombinedLateLintPass { 129 | fn default() -> Self { 130 | Self::new() 131 | } 132 | } 133 | ... warning: 57 warnings emitted warning: usage of `Rc>` --> compiler/rustc_interface/src/interface.rs:32:22 | 32 | codegen_backend: Lrc>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc` | = note: `#[warn(clippy::redundant_allocation)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: usage of `Rc>` --> compiler/rustc_interface/src/interface.rs:47:39 | 47 | pub fn codegen_backend(&self) -> &Lrc> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_interface/src/interface.rs:159:9 | 159 | Option Box + Send>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: transmute from a pointer to a pointer --> /home/nick/development/rust/rust/compiler/rustc_data_structures/src/box_region.rs:119:35 | 84 | / macro_rules! declare_box_region_type { 85 | | (impl $v:vis 86 | | $name: ident, 87 | | $yield_type:ty, ... | 119 | | self.0.access(::std::mem::transmute(mut_f)); | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 137 | / | declare_box_region_type!( 138 | | | impl $v $name, 139 | | | $crate::box_region::YieldType<$reti, for<$($lifetimes)*> fn(($($args,)*))>, 140 | | | for($($lifetimes)*), 141 | | | ($($args),*) -> ($reti, $retc) 142 | | | ); | |_|__________- in this macro invocation (#2) 143 | | }; 144 | | } | | - | | | | |_in this expansion of `declare_box_region_type!` (#1) | in this expansion of `declare_box_region_type!` (#2) | ::: compiler/rustc_interface/src/passes.rs:87:1 | 87 | / declare_box_region_type!( 88 | | pub BoxedResolver, 89 | | for(), 90 | | (&mut Resolver<'_>) -> (Result, ResolverOutputs) 91 | | ); | |____- in this macro invocation (#1) | = note: `#[warn(clippy::transmute_ptr_to_ptr)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: transmute from a pointer type (`*mut dyn std::ops::FnMut()`) to a reference type (`&mut dyn for<'r, 's> std::ops::FnMut(&'r mut rustc_resolve::Resolver<'s>)`) --> /home/nick/development/rust/rust/compiler/rustc_data_structures/src/box_region.rs:154:25 | 148 | / macro_rules! box_region_allow_access { 149 | | (for($($lifetimes:tt)*), ($($args:ty),*), ($($exprs:expr),*), $action:ident) => { 150 | | loop { 151 | | match $action { ... | 154 | | ::std::mem::transmute(accessor.get()) | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... | 168 | | } 169 | | } | |_- in this expansion of `box_region_allow_access!` | ::: compiler/rustc_interface/src/passes.rs:135:9 | 135 | box_region_allow_access!(for(), (&mut Resolver<'_>), (&mut resolver), action); | ------------------------------------------------------------------------------ in this macro invocation | = note: `#[warn(clippy::transmute_ptr_to_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> compiler/rustc_interface/src/passes.rs:142:32 | 142 | pub fn to_resolver_outputs(resolver: Rc>) -> ResolverOutputs { | ^^^^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: this function has too many arguments (9/7) --> compiler/rustc_interface/src/passes.rs:737:1 | 737 | / pub fn create_global_ctxt<'tcx>( 738 | | compiler: &'tcx Compiler, 739 | | lint_store: Lrc, 740 | | krate: &'tcx Crate<'tcx>, ... | 746 | | arena: &'tcx WorkerLocal>, 747 | | ) -> QueryContext<'tcx> { | |_______________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_interface/src/queries.rs:78:16 | 78 | expansion: Query<(ast::Crate, Steal>>, Lrc)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: usage of `Rc>` --> compiler/rustc_interface/src/queries.rs:109:35 | 109 | fn codegen_backend(&self) -> &Lrc> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: unnecessary closure used to substitute value for `Option::None` --> compiler/rustc_interface/src/queries.rs:141:17 | 141 | self.compiler.register_lints.as_deref().unwrap_or_else(|| empty), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Use `unwrap_or` instead: `self.compiler.register_lints.as_deref().unwrap_or(empty)` | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_interface/src/queries.rs:172:10 | 172 | ) -> Result<&Query<(ast::Crate, Steal>>, Lrc)>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: usage of `Rc>` --> compiler/rustc_interface/src/queries.rs:359:22 | 359 | codegen_backend: Lrc>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: usage of `Rc>` --> compiler/rustc_interface/src/util.rs:72:21 | 72 | ) -> (Lrc, Lrc>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_interface/src/util.rs:68:27 | 68 | make_codegen_backend: Option< | ___________________________^ 69 | | Box Box + Send>, 70 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: this function has too many arguments (8/7) --> compiler/rustc_interface/src/util.rs:61:1 | 61 | / pub fn create_session( 62 | | sopts: config::Options, 63 | | cfg: FxHashSet<(String, Option)>, 64 | | diagnostic_output: DiagnosticOutput, ... | 71 | | descriptions: Registry, 72 | | ) -> (Lrc, Lrc>) { | |_________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: 15 warnings emitted warning: literal with an empty format string --> compiler/rustc_driver/src/lib.rs:909:63 | 909 | println!(" {} {:7.7} {}", padded("name"), "default", "meaning"); | ^^^^^^^^^ | = note: `#[warn(clippy::print_literal)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal warning: literal with an empty format string --> compiler/rustc_driver/src/lib.rs:910:63 | 910 | println!(" {} {:7.7} {}", padded("----"), "-------", "-------"); | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal warning: literal with an empty format string --> compiler/rustc_driver/src/lib.rs:939:44 | 939 | println!(" {} {}", padded("name"), "sub-lints"); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal warning: literal with an empty format string --> compiler/rustc_driver/src/lib.rs:940:44 | 940 | println!(" {} {}", padded("----"), "---------"); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal warning: literal with an empty format string --> compiler/rustc_driver/src/lib.rs:941:48 | 941 | println!(" {} {}", padded("warnings"), "all lints that are set to issue warnings"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_driver/src/lib.rs:143:9 | 143 | Option Box + Send>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_driver/src/lib.rs:152:31 | 152 | make_codegen_backend: Option< | _______________________________^ 153 | | Box Box + Send>, 154 | | >, | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: very complex type used. Consider factoring parts into `type` definitions --> compiler/rustc_driver/src/lib.rs:187:27 | 187 | make_codegen_backend: Option< | ___________________________^ 188 | | Box Box + Send>, 189 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> compiler/rustc_driver/src/lib.rs:601:37 | 601 | fn show_content_with_pager(content: &String) { | ^^^^^^^ help: change this to: `&str` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: 9 warnings emitted Finished release [optimized] target(s) in 0.19s Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/highlight.rs:44:5 | 44 | write!(out, "
\n", class.unwrap_or_default())
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(clippy::write_with_newline)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
help: use `writeln!()` instead
   |
44 |     writeln!(out, "
", class.unwrap_or_default())
   |     ^^^^^^^                                                          --

warning: using `write!()` with a format string that ends in a single newline
  --> src/librustdoc/html/highlight.rs:59:5
   |
59 |     write!(out, "
{}
\n", playground_button.unwrap_or_default()).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 59 | writeln!(out, "
{}
", playground_button.unwrap_or_default()).unwrap() | ^^^^^^^ -- warning: literal with an empty format string --> src/librustdoc/html/render/mod.rs:1713:20 | 1713 | l, "goto source code" | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::write_literal)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:2557:13 | 2557 | write!(w, "{{\n"); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 2557 | writeln!(w, "{{"); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:2560:17 | 2560 | write!(w, ";\n"); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 2560 | writeln!(w, ";"); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:2567:17 | 2567 | write!(w, ";\n"); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 2567 | writeln!(w, ";"); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:2574:17 | 2574 | write!(w, ";\n"); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 2574 | writeln!(w, ";"); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:2590:25 | 2590 | write!(w, " {{ ... }}\n"); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 2590 | writeln!(w, " {{ ... }}"); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:3096:13 | 3096 | write!(w, " {{\n"); | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 3096 | writeln!(w, " {{"); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:3119:17 | 3119 | write!(w, ",\n"); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 3119 | writeln!(w, ","); | ^^^^^^^ -- warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/render/mod.rs:3123:17 | 3123 | write!(w, " // some variants omitted\n"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 3123 | writeln!(w, " // some variants omitted"); | ^^^^^^^ -- warning: literal with an empty format string --> src/librustdoc/html/render/mod.rs:3687:20 | 3687 | l, "goto source code" | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: literal with an empty format string --> src/librustdoc/html/render/mod.rs:3753:32 | 3753 | ... l, "goto source code" | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: literal with an empty format string --> src/librustdoc/html/render/mod.rs:3775:28 | 3775 | l, "goto source code" | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal warning: using `write!()` with a format string that ends in a single newline --> src/librustdoc/html/sources.rs:174:9 | 174 | write!(buf, "{0:1$}\n", i, cols); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!()` instead | 174 | writeln!(buf, "{0:1$}", i, cols); | ^^^^^^^ -- warning: redundant field names in struct initialization --> src/librustdoc/clean/types.rs:586:33 | 586 | ... parent_module: parent_module, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_module` | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names warning: this `else { if .. }` block can be collapsed --> src/librustdoc/clean/utils.rs:277:16 | 277 | } else { | ________________^ 278 | | if let Some(kind) = arg.type_.def_id().map(|did| cx.tcx.def_kind(did).clean(cx)) { 279 | | all_types.insert((arg.type_.clone(), kind)); 280 | | } 281 | | } | |_________^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 277 | } else if let Some(kind) = arg.type_.def_id().map(|did| cx.tcx.def_kind(did).clean(cx)) { 278 | all_types.insert((arg.type_.clone(), kind)); 279 | } | warning: this `if` statement can be collapsed --> src/librustdoc/clean/mod.rs:171:25 | 171 | / if attr.has_name(sym::keyword) { 172 | | if v.is_doc_keyword() { 173 | | keyword = Some(v.to_string()); 174 | | break; 175 | | } 176 | | // FIXME: should warn on unknown keywords? 177 | | } | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 171 | if attr.has_name(sym::keyword) && v.is_doc_keyword() { 172 | keyword = Some(v.to_string()); 173 | break; 174 | } | warning: this `else { if .. }` block can be collapsed --> src/librustdoc/html/format.rs:235:16 | 235 | } else { | ________________^ 236 | | if end_newline { 237 | | clause.push_str(" where"); 238 | | } else { 239 | | clause.push_str(" where"); 240 | | } 241 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 235 | } else if end_newline { 236 | clause.push_str(" where"); 237 | } else { 238 | clause.push_str(" where"); 239 | } | warning: 5 bindings with single-character names in scope --> src/librustdoc/html/format.rs:639:13 | 639 | fn fmt_type(t: &clean::Type, f: &mut fmt::Formatter<'_>, use_absolute: bool) -> fmt::Result { | ^ ^ ... 736 | clean::BorrowedRef { lifetime: ref l, mutability, type_: ref ty } => { | ^ ... 741 | let m = mutability.print_with_space(); | ^ ... 777 | clean::ResolvedPath { param_names: Some(ref v), .. } if !v.is_empty() => { | ^ | = note: `#[warn(clippy::many_single_char_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: 5 bindings with single-character names in scope --> src/librustdoc/html/format.rs:639:13 | 639 | fn fmt_type(t: &clean::Type, f: &mut fmt::Formatter<'_>, use_absolute: bool) -> fmt::Result { | ^ ^ ... 736 | clean::BorrowedRef { lifetime: ref l, mutability, type_: ref ty } => { | ^ ... 741 | let m = mutability.print_with_space(); | ^ ... 777 | clean::ResolvedPath { param_names: Some(ref v), .. } if !v.is_empty() => { | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: this `else { if .. }` block can be collapsed --> src/librustdoc/html/format.rs:812:20 | 812 | } else { | ____________________^ 813 | | if should_show_cast { 814 | | write!(f, "<{} as {}>::", self_type.print(), trait_.print())? 815 | | } else { 816 | | write!(f, "{}::", self_type.print())? 817 | | } 818 | | }; | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 812 | } else if should_show_cast { 813 | write!(f, "<{} as {}>::", self_type.print(), trait_.print())? 814 | } else { 815 | write!(f, "{}::", self_type.print())? 816 | }; | warning: 5 bindings with single-character names in scope --> src/librustdoc/html/render/mod.rs:1999:23 | 1999 | fn take_parts<'a>(s: &mut &'a str) -> (&'a str, &'a str) { | ^ 2000 | let i = s.find(|c: char| c.is_ascii_digit()); | ^ 2001 | let (a, b) = s.split_at(i.unwrap_or(s.len())); | ^ ^ 2002 | let i = b.find(|c: char| !c.is_ascii_digit()); 2003 | let (b, c) = b.split_at(i.unwrap_or(b.len())); | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names warning: this `else { if .. }` block can be collapsed --> src/librustdoc/html/render/mod.rs:3531:12 | 3531 | } else { | ____________^ 3532 | | if let Some(prim) = target.primitive_type() { 3533 | | if let Some(&did) = cache.primitive_locations.get(&prim) { 3534 | | render_assoc_items(w, cx, container_item, did, what, cache); 3535 | | } 3536 | | } 3537 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 3531 | } else if let Some(prim) = target.primitive_type() { 3532 | if let Some(&did) = cache.primitive_locations.get(&prim) { 3533 | render_assoc_items(w, cx, container_item, did, what, cache); 3534 | } 3535 | } | warning: this `if` statement can be collapsed --> src/librustdoc/passes/stripper.rs:44:17 | 44 | / if i.def_id.is_local() { 45 | | if !self.access_levels.is_exported(i.def_id) { 46 | | debug!("Stripper: stripping {:?} {:?}", i.type_(), i.name); 47 | | return None; 48 | | } 49 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 44 | if i.def_id.is_local() && !self.access_levels.is_exported(i.def_id) { 45 | debug!("Stripper: stripping {:?} {:?}", i.type_(), i.name); 46 | return None; 47 | } | warning: this `else { if .. }` block can be collapsed --> src/librustdoc/passes/strip_hidden.rs:56:16 | 56 | } else { | ________________^ 57 | | if self.update_retained { 58 | | self.retained.insert(i.def_id); 59 | | } 60 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 56 | } else if self.update_retained { 57 | self.retained.insert(i.def_id); 58 | } | warning: this `else { if .. }` block can be collapsed --> src/librustdoc/passes/collect_intra_doc_links.rs:2089:16 | 2089 | } else { | ________________^ 2090 | | if param_depth == 0 { 2091 | | stripped_segment.push(c); 2092 | | } else { 2093 | | latest_generics_chunk.push(c); 2094 | | } 2095 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 2089 | } else if param_depth == 0 { 2090 | stripped_segment.push(c); 2091 | } else { 2092 | latest_generics_chunk.push(c); 2093 | } | warning: this function has too many arguments (9/7) --> src/librustdoc/externalfiles.rs:22:5 | 22 | / pub fn load( 23 | | in_header: &[String], 24 | | before_content: &[String], 25 | | after_content: &[String], ... | 31 | | playground: &Option, 32 | | ) -> Option { | |_____________________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: you don't need to add `&` to all patterns --> src/librustdoc/clean/auto_trait.rs:160:9 | 160 | / match region { 161 | | &ty::ReEarlyBound(r) => Some(r.name.to_string()), 162 | | _ => None, 163 | | } | |_________^ | = note: `#[warn(clippy::match_ref_pats)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 160 | match *region { 161 | ty::ReEarlyBound(r) => Some(r.name.to_string()), | warning: you don't need to add `&` to all patterns --> src/librustdoc/clean/auto_trait.rs:194:13 | 194 | / match constraint { 195 | | &Constraint::VarSubVar(r1, r2) => { 196 | | { 197 | | let deps1 = vid_map.entry(RegionTarget::RegionVid(r1)).or_default(); ... | 221 | | } 222 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 194 | match *constraint { 195 | Constraint::VarSubVar(r1, r2) => { 196 | { 197 | let deps1 = vid_map.entry(RegionTarget::RegionVid(r1)).or_default(); 198 | deps1.larger.insert(RegionTarget::RegionVid(r2)); 199 | } ... warning: you don't need to add `&` to both the expression and the patterns --> src/librustdoc/clean/auto_trait.rs:357:34 | 357 | let new_ty = match &poly_trait.trait_ { | __________________________________^ 358 | | &Type::ResolvedPath { 359 | | ref path, 360 | | ref param_names, ... | 405 | | _ => panic!("Unexpected data: {:?}, {:?}", ty, data), 406 | | }; | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 357 | let new_ty = match poly_trait.trait_ { 358 | Type::ResolvedPath { 359 | ref path, 360 | ref param_names, 361 | ref did, 362 | ref is_generic, ... warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> src/librustdoc/clean/auto_trait.rs:527:39 | 527 | .and_then(|t| { | _______________________________________^ 528 | | ty_to_traits 529 | | .get(&ty) 530 | | .map(|bounds| bounds.contains(&strip_type(t.clone()))) 531 | | }) | |_________________________^ | = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: you don't need to add `&` to all patterns --> src/librustdoc/clean/auto_trait.rs:541:37 | 541 | let is_fn = match &mut b { | _____________________________________^ 542 | | &mut GenericBound::TraitBound(ref mut p, _) => { 543 | | // Insert regions into the for_generics hash map first, to ensure 544 | | // that we don't end up with duplicate bounds (e.g., for<'b, 'b>) ... | 549 | | _ => false, 550 | | }; | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 541 | let is_fn = match *(&mut b) { 542 | GenericBound::TraitBound(ref mut p, _) => { | warning: you don't need to add `&` to both the expression and the patterns --> src/librustdoc/clean/auto_trait.rs:744:9 | 744 | / match &ty { 745 | | &&Type::ResolvedPath { ref did, .. } => { 746 | | *did == tcx.require_lang_item(LangItem::Fn, None) 747 | | || *did == tcx.require_lang_item(LangItem::FnMut, None) ... | 750 | | _ => false, 751 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: try | 744 | match ty { 745 | &Type::ResolvedPath { ref did, .. } => { | warning: you don't need to add `&` to all patterns --> src/librustdoc/clean/auto_trait.rs:767:9 | 767 | / (match r { 768 | | &ty::ReVar(vid) => self.vid_to_region.get(&vid).cloned(), 769 | | _ => None, 770 | | }) | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 767 | (match *r { 768 | ty::ReVar(vid) => self.vid_to_region.get(&vid).cloned(), | warning: match expression looks like `matches!` macro --> src/librustdoc/clean/cfg.rs:180:34 | 180 | Cfg::Cfg(name, _) => match name { | __________________________________^ 181 | | sym::debug_assertions | sym::target_endian => true, 182 | | _ => false, 183 | | }, | |_____________^ help: try this: `matches!(name, sym::debug_assertions | sym::target_endian)` | = note: `#[warn(clippy::match_like_matches_macro)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> src/librustdoc/clean/cfg.rs:191:36 | 191 | Cfg::Not(ref child) => match **child { | ____________________________________^ 192 | | Cfg::Cfg(..) => true, 193 | | _ => false, 194 | | }, | |_____________^ help: try this: `matches!(**child, Cfg::Cfg(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> src/librustdoc/clean/cfg.rs:199:9 | 199 | / match *self { 200 | | Cfg::Cfg(name, _) if name == sym::target_feature => true, 201 | | _ => false, 202 | | } | |_________^ help: try this: `matches!(*self, Cfg::Cfg(name, _) if name == sym::target_feature)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> src/librustdoc/clean/types.rs:127:9 | 127 | / match self.inner { 128 | | StrippedItem(box ModuleItem(Module { is_crate: true, .. })) 129 | | | ModuleItem(Module { is_crate: true, .. }) => true, 130 | | _ => false, 131 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 127 | matches!(self.inner, StrippedItem(box ModuleItem(Module { is_crate: true, .. })) 128 | | ModuleItem(Module { is_crate: true, .. })) | warning: match expression looks like `matches!` macro --> src/librustdoc/clean/types.rs:291:9 | 291 | / match *self { 292 | | ItemEnum::TypedefItem(_, _) | ItemEnum::AssocTypeItem(_, _) => true, 293 | | _ => false, 294 | | } | |_________^ help: try this: `matches!(*self, ItemEnum::TypedefItem(_, _) | ItemEnum::AssocTypeItem(_, _))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: calling `push_str()` using a single-character string literal --> src/librustdoc/clean/types.rs:662:33 | 662 | ... href.push_str("#"); | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `href.push('#')` | = note: `#[warn(clippy::single_char_push_str)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: match expression looks like `matches!` macro --> src/librustdoc/clean/types.rs:857:9 | 857 | / match *self { 858 | | GenericParamDefKind::Type { .. } => true, 859 | | _ => false, 860 | | } | |_________^ help: try this: `matches!(*self, GenericParamDefKind::Type { .. })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: match expression looks like `matches!` macro --> src/librustdoc/clean/types.rs:1222:9 | 1222 | / match *self { 1223 | | Type::Generic(_) => true, 1224 | | _ => false, 1225 | | } | |_________^ help: try this: `matches!(*self, Type::Generic(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: you don't need to add `&` to all patterns --> src/librustdoc/clean/utils.rs:199:77 | 199 | if let Some(where_pred) = generics.where_predicates.iter().find(|g| match g { | _____________________________________________________________________________^ 200 | | &WherePredicate::BoundPredicate { ref ty, .. } => ty.def_id() == arg.def_id(), 201 | | _ => false, 202 | | }) { | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 199 | if let Some(where_pred) = generics.where_predicates.iter().find(|g| match *g { 200 | WherePredicate::BoundPredicate { ref ty, .. } => ty.def_id() == arg.def_id(), | warning: very complex type used. Consider factoring parts into `type` definitions --> src/librustdoc/clean/utils.rs:268:6 | 268 | ) -> (Vec<(Type, TypeKind)>, Vec<(Type, TypeKind)>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> src/librustdoc/clean/mod.rs:397:9 | 397 | / match def { 398 | | Some( 399 | | rl::Region::EarlyBound(_, node_id, _) 400 | | | rl::Region::LateBound(_, node_id, _) ... | 407 | | _ => {} 408 | | } | |_________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 397 | if let Some( 398 | rl::Region::EarlyBound(_, node_id, _) 399 | | rl::Region::LateBound(_, node_id, _) 400 | | rl::Region::Free(_, node_id), 401 | ) = def { 402 | if let Some(lt) = cx.lt_substs.borrow().get(&node_id).cloned() { ... warning: if let .. else expression looks like `matches!` macro --> src/librustdoc/clean/mod.rs:822:36 | 822 | bounds.sort_by_key(|b| if let GenericBound::TraitBound(..) = b { false } else { true }); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `!matches!(b, GenericBound::TraitBound(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this boolean expression can be simplified --> src/librustdoc/clean/mod.rs:904:16 | 904 | && !is_unstable_const_fn(cx.tcx, did.to_def_id()).is_some() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_unstable_const_fn(cx.tcx, did.to_def_id()).is_none()` | = note: `#[warn(clippy::nonminimal_bool)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool warning: use of `unwrap_or` followed by a call to `new` --> src/librustdoc/clean/mod.rs:939:25 | 939 | self.1.get(i).map(|ident| ident.to_string()).unwrap_or(String::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.1.get(i).map(|ident| ident.to_string()).unwrap_or_default()` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: match expression looks like `matches!` macro --> src/librustdoc/config.rs:40:9 | 40 | / match self { 41 | | OutputFormat::Json => true, 42 | | _ => false, 43 | | } | |_________^ help: try this: `matches!(self, OutputFormat::Json)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: unnecessary closure used to substitute value for `Option::None` --> src/librustdoc/doctest.rs:70:24 | 70 | lint_cap: Some(options.lint_cap.clone().unwrap_or_else(|| lint::Forbid)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Use `unwrap_or` instead: `options.lint_cap.clone().unwrap_or(lint::Forbid)` | = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations warning: this function has too many arguments (16/7) --> src/librustdoc/doctest.rs:234:1 | 234 | / fn run_test( 235 | | test: &str, 236 | | cratename: &str, 237 | | line: usize, ... | 250 | | path: PathBuf, 251 | | ) -> Result<(), TestFailure> { | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: calling `push_str()` using a single-character string literal --> src/librustdoc/doctest.rs:589:17 | 589 | before.push_str("\n"); | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `before.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/librustdoc/doctest.rs:593:17 | 593 | crates.push_str("\n"); | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `crates.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/librustdoc/doctest.rs:597:17 | 597 | after.push_str("\n"); | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `after.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: struct update has no effect, all the fields in the struct have already been specified --> src/librustdoc/fold.rs:64:79 | 64 | VariantItem(Variant { kind: VariantKind::Struct(j), ..i2 }) | ^^ | = note: `#[warn(clippy::needless_update)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name --> src/librustdoc/html/format.rs:99:35 | 99 | crate fn to_display(mut self, t: T) -> String { | ^^^^^^^^ | = note: `#[warn(clippy::wrong_self_convention)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention warning: you don't need to add `&` to all patterns --> src/librustdoc/html/format.rs:249:13 | 249 | / match pred { 250 | | &clean::WherePredicate::BoundPredicate { ref ty, ref bounds } => { 251 | | let bounds = bounds; 252 | | if f.alternate() { ... | 283 | | } 284 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 249 | match *pred { 250 | clean::WherePredicate::BoundPredicate { ref ty, ref bounds } => { 251 | let bounds = bounds; 252 | if f.alternate() { 253 | clause.push_str(&format!( 254 | "{:#}: {:#}", ... warning: calling `push_str()` using a single-character string literal --> src/librustdoc/html/format.rs:507:9 | 507 | url.push_str("/"); | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('/')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/librustdoc/html/format.rs:516:13 | 516 | url.push_str("."); | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('.')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. --> src/librustdoc/html/format.rs:847:21 | 847 | drop(param_names); | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::drop_ref)]` on by default note: argument has type `&std::option::Option>` --> src/librustdoc/html/format.rs:847:26 | 847 | drop(param_names); | ^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref warning: calling `push_str()` using a single-character string literal --> src/librustdoc/html/format.rs:1027:25 | 1027 | args_plain.push_str(" "); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `args_plain.push(' ')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: stripping a prefix manually --> src/librustdoc/html/markdown.rs:140:22 | 140 | Line::Hidden(&trimmed[2..]) | ^^^^^^^^^^^^^ | = note: `#[warn(clippy::manual_strip)]` on by default note: the prefix was tested here --> src/librustdoc/html/markdown.rs:138:12 | 138 | } else if trimmed.starts_with("# ") { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip help: try using the `strip_prefix` method | 138 | } else if let Some() = trimmed.strip_prefix("# ") { 139 | // # text 140 | Line::Hidden() | warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. --> src/librustdoc/html/markdown.rs:389:38 | 389 | if self.links.iter().find(|&link| *link.href == **dest).is_some() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|link| *link.href == **dest)` | = note: `#[warn(clippy::search_is_some)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some warning: match expression looks like `matches!` macro --> src/librustdoc/html/markdown.rs:519:5 | 519 | / match *t { 520 | | Tag::Paragraph 521 | | | Tag::Item 522 | | | Tag::Emphasis ... | 526 | | _ => false, 527 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 519 | matches!(*t, Tag::Paragraph 520 | | Tag::Item 521 | | Tag::Emphasis 522 | | Tag::Strong 523 | | Tag::Link(..) 524 | | Tag::BlockQuote) | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> src/librustdoc/html/markdown.rs:866:21 | 866 | / match if s == "compile-fail" || s == "compile_fail" || s == "compilefail" { 867 | | Some(( 868 | | "compile_fail", 869 | | "the code block will either not be tested if not marked as a rust one \ ... | 907 | | None => {} 908 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 866 | if let Some((flag, help)) = if s == "compile-fail" || s == "compile_fail" || s == "compilefail" { 867 | Some(( 868 | "compile_fail", 869 | "the code block will either not be tested if not marked as a rust one \ 870 | or won't fail if it compiles successfully", 871 | )) ... warning: usage of `contains_key` followed by `insert` on a `HashMap` --> src/librustdoc/html/render/cache.rs:102:13 | 102 | / if defid_to_pathid.contains_key(&defid) { 103 | | defid_to_pathid.get(&defid).copied() 104 | | } else { 105 | | let pathid = lastpathid; ... | 114 | | } 115 | | } | |_____________^ consider using `defid_to_pathid.entry(defid)` | = note: `#[warn(clippy::map_entry)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry warning: use of `unwrap_or` followed by a call to `new` --> src/librustdoc/html/render/cache.rs:127:21 | 127 | let crate_doc = krate | _____________________^ 128 | | .module 129 | | .as_ref() 130 | | .map(|module| shorten(plain_text_summary(module.doc_value()))) 131 | | .unwrap_or(String::new()); | |_________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 127 | let crate_doc = krate 128 | .module 129 | .as_ref() 130 | .map(|module| shorten(plain_text_summary(module.doc_value()))).unwrap_or_default(); | warning: this call to `map()` won't have an effect on the call to `count()` --> src/librustdoc/html/render/mod.rs:515:25 | 515 | let nb_errors = self.errors.iter().map(|err| diag.struct_err(&err).emit()).count(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::suspicious_map)]` on by default = help: make sure you did not confuse `map` with `filter` or `for_each` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_map warning: needlessly taken reference of left operand --> src/librustdoc/html/render/mod.rs:1405:28 | 1405 | if &opt.0 == default_value { "selected" } else { "" }, | ------^^^^^^^^^^^^^^^^^ | | | help: use the left value directly: `opt.0` | = note: `#[warn(clippy::op_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref warning: calling `push_str()` using a single-character string literal --> src/librustdoc/html/render/mod.rs:1572:21 | 1572 | url.push_str("/"); | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `url.push('/')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: use of `unwrap_or` followed by a function call --> src/librustdoc/html/render/mod.rs:2001:35 | 2001 | let (a, b) = s.split_at(i.unwrap_or(s.len())); | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> src/librustdoc/html/render/mod.rs:2003:35 | 2003 | let (b, c) = b.split_at(i.unwrap_or(b.len())); | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| b.len())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: writing `&String` instead of `&str` involves a new object where a slice will do. --> src/librustdoc/html/render/mod.rs:3380:26 | 3380 | fn anchor(&self, id: &'a String) -> Self { | ^^^^^^^^^^ help: change this to: `&str` | = note: `#[warn(clippy::ptr_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg warning: this function has too many arguments (13/7) --> src/librustdoc/html/render/mod.rs:3622:1 | 3622 | / fn render_impl( 3623 | | w: &mut Buffer, 3624 | | cx: &Context, 3625 | | i: &Impl, ... | 3637 | | cache: &Cache, 3638 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (11/7) --> src/librustdoc/html/render/mod.rs:3709:5 | 3709 | / fn doc_impl_item( 3710 | | w: &mut Buffer, 3711 | | cx: &Context, 3712 | | item: &clean::Item, ... | 3720 | | cache: &Cache, 3721 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: this function has too many arguments (9/7) --> src/librustdoc/html/render/mod.rs:3842:5 | 3842 | / fn render_default_items( 3843 | | w: &mut Buffer, 3844 | | cx: &Context, 3845 | | t: &clean::Trait, ... | 3851 | | cache: &Cache, 3852 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: use of `or` followed by a function call --> src/librustdoc/html/render/mod.rs:4197:26 | 4197 | .or(target | __________________________^ 4198 | | .primitive_type() 4199 | | .and_then(|prim| c.primitive_locations.get(&prim).cloned())) | |________________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 4197 | .or_else(|| target 4198 | .primitive_type() 4199 | .and_then(|prim| c.primitive_locations.get(&prim).cloned())) | warning: if let .. else expression looks like `matches!` macro --> src/librustdoc/html/render/mod.rs:4473:21 | 4473 | .filter(|f| if let clean::StructFieldItem(..) = f.inner { true } else { false }) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches!(f.inner, clean::StructFieldItem(..))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> src/librustdoc/html/render/mod.rs:4564:30 | 4564 | if items.iter().any(|it| { | ______________________________^ 4565 | | it.type_() == ItemType::ExternCrate || (it.type_() == ItemType::Import && !it.is_stripped()) 4566 | | }) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions warning: calling `push_str()` using a single-character string literal --> src/librustdoc/html/toc.rs:135:21 | 135 | sec_number.push_str("."); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `sec_number.push('.')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/non_autolinks.rs:80:22 | 80 | .unwrap_or(item.source.span()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: this loop could be written as a `for` loop --> src/librustdoc/passes/non_autolinks.rs:125:25 | 125 | while let Some((event, _)) = p.next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (event, _) in p` | = note: `#[warn(clippy::while_let_on_iterator)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> src/librustdoc/passes/non_autolinks.rs:126:29 | 126 | / ... match event { 127 | | ... Event::End(Tag::CodeBlock(_)) => break, 128 | | ... _ => {} 129 | | ... } | |_______________________^ help: try this: `if let Event::End(Tag::CodeBlock(_)) = event { break }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match warning: returning the result of a `let` binding from a block --> src/librustdoc/passes/strip_hidden.rs:31:5 | 29 | let krate = stripper.fold_crate(krate); | --------------------------------------- unnecessary `let` binding 30 | 31 | krate | ^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 29 | 30 | 31 | stripper.fold_crate(krate) | warning: if let .. else expression looks like `matches!` macro --> src/librustdoc/passes/collect_intra_doc_links.rs:726:5 | 726 | / if let PerNS { 727 | | type_ns: Ok((Res::Def(DefKind::Trait, _), _)), 728 | | macro_ns: Ok((Res::Def(DefKind::Macro(MacroKind::Derive), _), _)), 729 | | .. ... | 734 | | false 735 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro help: try this | 726 | matches!(*ns, PerNS { 727 | type_ns: Ok((Res::Def(DefKind::Trait, _), _)), 728 | macro_ns: Ok((Res::Def(DefKind::Macro(MacroKind::Derive), _), _)), 729 | .. 730 | }) | warning: use of `or` followed by a function call --> src/librustdoc/passes/collect_intra_doc_links.rs:779:39 | 779 | match parent_node.or(self.mod_ids.last().copied()) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.mod_ids.last().copied())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: this function has too many arguments (9/7) --> src/librustdoc/passes/collect_intra_doc_links.rs:908:5 | 908 | / fn resolve_link( 909 | | &self, 910 | | item: &Item, 911 | | dox: &str, ... | 917 | | link_range: Option>, 918 | | ) -> Option { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: `if` chain can be rewritten with `match` --> src/librustdoc/passes/collect_intra_doc_links.rs:934:38 | 934 | let (link, extra_fragment) = if parts.len() > 2 { | ______________________________________^ 935 | | anchor_failure(cx, &item, &link, dox, link_range, AnchorFailure::MultipleAnchors); 936 | | return None; 937 | | } else if parts.len() == 2 { ... | 944 | | (parts[0], None) 945 | | }; | |_________^ | = note: `#[warn(clippy::comparison_chain)]` on by default = help: Consider rewriting the `if` chain to use `cmp` and `match`. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain warning: useless conversion to the same type: `passes::collect_intra_doc_links::ResolutionFailure` --> src/librustdoc/passes/collect_intra_doc_links.rs:992:32 | 992 | let err_kind = ResolutionFailure::NoParentItem.into(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ResolutionFailure::NoParentItem` | = note: `#[warn(clippy::useless_conversion)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: this function has too many arguments (10/7) --> src/librustdoc/passes/collect_intra_doc_links.rs:1176:5 | 1176 | / fn resolve_with_disambiguator( 1177 | | &self, 1178 | | disambiguator: Option, 1179 | | item: &Item, ... | 1186 | | link_range: Option>, 1187 | | ) -> Option<(Res, Option)> { | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: unneeded `return` statement --> src/librustdoc/passes/collect_intra_doc_links.rs:1223:25 | 1223 | return None; | ^^^^^^^^^^^^ help: remove `return`: `None` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: unneeded `return` statement --> src/librustdoc/passes/collect_intra_doc_links.rs:1227:25 | 1227 | return None; | ^^^^^^^^^^^^ help: remove `return`: `None` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: unneeded `return` statement --> src/librustdoc/passes/collect_intra_doc_links.rs:1319:21 | 1319 | return None; | ^^^^^^^^^^^^ help: remove `return`: `None` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: unneeded `return` statement --> src/librustdoc/passes/collect_intra_doc_links.rs:1348:25 | 1348 | return None; | ^^^^^^^^^^^^ help: remove `return`: `None` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/collect_intra_doc_links.rs:1547:35 | 1547 | let sp = span_of_attrs(attrs).unwrap_or(item.source.span()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/doc_test_lints.rs:100:49 | 100 | let sp = span_of_attrs(&item.attrs).unwrap_or(item.source.span()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/doc_test_lints.rs:113:40 | 113 | span_of_attrs(&item.attrs).unwrap_or(item.source.span()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/check_code_block_syntax.rs:77:55 | 77 | super::span_of_attrs(&item.attrs).unwrap_or(item.source.span()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/check_code_block_syntax.rs:101:49 | 101 | let sp = span_of_attrs(&item.attrs).unwrap_or(item.source.span()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: taken reference of right operand --> src/librustdoc/passes/html_tags.rs:63:50 | 63 | if ALLOWED_UNCLOSED.iter().any(|&at| at == &last_tag_name_low) { | ^^^^^^------------------ | | | help: use the right value directly: `last_tag_name_low` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref warning: use of `unwrap_or` followed by a function call --> src/librustdoc/passes/html_tags.rs:191:56 | 191 | None => span_of_attrs(&item.attrs).unwrap_or(item.source.span()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.source.span())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: match expression looks like `matches!` macro --> src/librustdoc/theme.rs:73:9 | 73 | / match *self { 74 | | Events::StartLineComment(_) | Events::StartComment(_) | Events::EndComment(_) => true, 75 | | _ => false, 76 | | } | |_________^ help: try this: `matches!(*self, Events::StartLineComment(_) | Events::StartComment(_) | Events::EndComment(_))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: if let .. else expression looks like `matches!` macro --> src/librustdoc/theme.rs:81:5 | 81 | if let Some(&Events::StartLineComment(_)) = events.last() { true } else { false } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches!(events.last(), Some(&Events::StartLineComment(_)))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro warning: this function has too many arguments (8/7) --> src/librustdoc/visit_ast.rs:156:5 | 156 | / fn visit_fn( 157 | | &mut self, 158 | | om: &mut Module<'tcx>, 159 | | item: &'tcx hir::Item<'_>, ... | 164 | | body: hir::BodyId, 165 | | ) { | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: 105 warnings emitted Finished release [optimized] target(s) in 0.12s warning: this `if` statement can be collapsed --> src/driver/aot.rs:127:5 | 127 | / if tcx 128 | | .sess 129 | | .crate_types() 130 | | .contains(&rustc_session::config::CrateType::ProcMacro) ... | 144 | | } 145 | | } | |_____^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 127 | if tcx 128 | .sess 129 | .crate_types() 130 | .contains(&rustc_session::config::CrateType::ProcMacro) && mono_items.iter().any(|(mono_item, _)| match mono_item { 131 | rustc_middle::mir::mono::MonoItem::Static(def_id) => tcx 132 | .symbol_name(Instance::mono(tcx, *def_id)) ... warning: all variants have the same postfix: `Before` --> src/optimize/stack2reg.rs:486:1 | 486 | / enum TemporalOrder { 487 | | /// `src` will never be executed before `dest`. 488 | | NeverBefore, 489 | | ... | 495 | | DefinitivelyBefore, 496 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: all variants have the same prefix: `By` --> src/value_and_place.rs:73:1 | 73 | / enum CValueInner { 74 | | ByRef(Pointer, Option), 75 | | ByVal(Value), 76 | | ByValPair(Value, Value), 77 | | } | |_^ | = help: remove the prefixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names warning: returning the result of a `let` binding from a block --> src/abi/mod.rs:262:9 | 254 | / let func_ref = self 255 | | .cx 256 | | .module 257 | | .declare_func_in_func(func_id, &mut self.bcx.func); | |_______________________________________________________________- unnecessary `let` binding ... 262 | func_ref | ^^^^^^^^ | = note: `#[warn(clippy::let_and_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 254 | 255 | 256 | #[cfg(debug_assertions)] 257 | self.add_comment(func_ref, format!("{:?}", inst)); 258 | 259 | self ... warning: returning the result of a `let` binding from a block --> src/abi/mod.rs:350:5 | 337 | / let place = if is_ssa { 338 | | if let rustc_target::abi::Abi::ScalarPair(_, _) = layout.abi { 339 | | CPlace::new_var_pair(fx, local, layout) 340 | | } else { ... | 344 | | CPlace::new_stack_slot(fx, layout) 345 | | }; | |______- unnecessary `let` binding ... 350 | place | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 337 | 338 | 339 | #[cfg(debug_assertions)] 340 | self::comments::add_local_place_comments(fx, place, local); 341 | 342 | if is_ssa { ... warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> src/analyze.rs:31:13 | 31 | / match &stmt.kind { 32 | | Assign(place_and_rval) => match &place_and_rval.1 { 33 | | Rvalue::Ref(_, _, place) | Rvalue::AddressOf(_, place) => { 34 | | not_ssa(&mut flag_map, place.local) ... | 38 | | _ => {} 39 | | } | |_____________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 31 | if let Assign(place_and_rval) = &stmt.kind { match &place_and_rval.1 { 32 | Rvalue::Ref(_, _, place) | Rvalue::AddressOf(_, place) => { 33 | not_ssa(&mut flag_map, place.local) 34 | } 35 | _ => {} 36 | } } | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> src/analyze.rs:42:9 | 42 | / match &bb.terminator().kind { 43 | | TerminatorKind::Call { destination, .. } => { 44 | | if let Some((dest_place, _dest_bb)) = destination { 45 | | let dest_layout = fx ... | 52 | | _ => {} 53 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 42 | if let TerminatorKind::Call { destination, .. } = &bb.terminator().kind { 43 | if let Some((dest_place, _dest_bb)) = destination { 44 | let dest_layout = fx 45 | .layout_of(fx.monomorphize(&dest_place.ty(&fx.mir.local_decls, fx.tcx).ty)); 46 | if !crate::abi::can_return_to_ssa_var(fx.tcx, dest_layout) { 47 | not_ssa(&mut flag_map, dest_place.local) ... warning: unneeded `return` statement --> src/debuginfo/line_info.rs:42:9 | 42 | return path.as_bytes(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `path.as_bytes()` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: this function has too many arguments (8/7) --> src/debuginfo/mod.rs:268:5 | 268 | / pub(crate) fn define_function( 269 | | &mut self, 270 | | instance: Instance<'tcx>, 271 | | func_id: FuncId, ... | 276 | | local_map: IndexVec>, 277 | | ) { | |______^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: sub-expression diverges --> src/driver/mod.rs:33:20 | 33 | let _: ! = jit::run_jit(tcx); | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::diverging_sub_expression)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression warning: unneeded `return` statement --> src/num.rs:424:17 | 424 | return codegen_compare_bin_op(fx, bin_op, false, lhs, rhs); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `codegen_compare_bin_op(fx, bin_op, false, lhs, rhs)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: 11 warnings emitted warning: use of `unwrap_or` followed by a function call --> src/bin/cg_clif.rs:30:47 | 30 | config.opts.maybe_sysroot.clone().unwrap_or( | _______________________________________________^ 31 | | std::env::current_exe() 32 | | .unwrap() 33 | | .parent() 34 | | .unwrap() 35 | | .join("sysroot"), 36 | | ), | |_____________^ | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 30 | config.opts.maybe_sysroot.clone().unwrap_or_else(|| std::env::current_exe() 31 | .unwrap() 32 | .parent() 33 | .unwrap() 34 | .join("sysroot")), | warning: 1 warning emitted Finished release [optimized] target(s) in 0.04s Checking clippy artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) Finished release [optimized] target(s) in 0.11s Checking bootstrap artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) warning: this `if` statement can be collapsed --> src/bootstrap/compile.rs:140:5 | 140 | / if target == "x86_64-fortanix-unknown-sgx" { 141 | | if env::var_os("X86_FORTANIX_SGX_LIBS").is_some() { 142 | | builder.info("Warning: X86_FORTANIX_SGX_LIBS environment variable is ignored, libunwind is now compiled as part of rustbuild"); 143 | | } 144 | | } | |_____^ | = note: `#[warn(clippy::collapsible_if)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 140 | if target == "x86_64-fortanix-unknown-sgx" && env::var_os("X86_FORTANIX_SGX_LIBS").is_some() { 141 | builder.info("Warning: X86_FORTANIX_SGX_LIBS environment variable is ignored, libunwind is now compiled as part of rustbuild"); 142 | } | warning: this `if` statement can be collapsed --> src/bootstrap/native.rs:221:9 | 221 | / if builder.config.llvm_tools_enabled { 222 | | if !target.contains("msvc") { 223 | | if target.contains("apple") { 224 | | cfg.define("CMAKE_EXE_LINKER_FLAGS", "-static-libstdc++"); ... | 228 | | } 229 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 221 | if builder.config.llvm_tools_enabled && !target.contains("msvc") { 222 | if target.contains("apple") { 223 | cfg.define("CMAKE_EXE_LINKER_FLAGS", "-static-libstdc++"); 224 | } else { 225 | cfg.define("CMAKE_EXE_LINKER_FLAGS", "-Wl,-Bsymbolic -static-libstdc++"); 226 | } ... warning: this `if` statement can be collapsed --> src/bootstrap/sanity.rs:168:9 | 168 | / if target.contains("-none-") || target.contains("nvptx") { 169 | | if build.no_std(*target) == Some(false) { 170 | | panic!("All the *-none-* and nvptx* targets are no-std targets") 171 | | } 172 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 168 | if (target.contains("-none-") || target.contains("nvptx")) && build.no_std(*target) == Some(false) { 169 | panic!("All the *-none-* and nvptx* targets are no-std targets") 170 | } | warning: this `if` statement can be collapsed --> src/bootstrap/test.rs:1067:9 | 1067 | / if !is_rustdoc { 1068 | | if builder.config.rust_optimize_tests { 1069 | | flags.push("-O".to_string()); 1070 | | } 1071 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1067 | if !is_rustdoc && builder.config.rust_optimize_tests { 1068 | flags.push("-O".to_string()); 1069 | } | warning: this `if` statement can be collapsed --> src/bootstrap/tool.rs:235:5 | 235 | / if builder.build.config.cargo_native_static { 236 | | if path.ends_with("cargo") 237 | | || path.ends_with("rls") 238 | | || path.ends_with("clippy") ... | 244 | | } 245 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 235 | if builder.build.config.cargo_native_static && (path.ends_with("cargo") 236 | || path.ends_with("rls") 237 | || path.ends_with("clippy") 238 | || path.ends_with("miri") 239 | || path.ends_with("rustfmt")) { 240 | cargo.env("LIBZ_SYS_STATIC", "1"); ... warning: this `if` statement can be collapsed --> src/bootstrap/lib.rs:1367:9 | 1367 | / if !self.config.ninja_in_file && self.config.build.contains("msvc") { 1368 | | if cmd_finder.maybe_have("ninja").is_some() { 1369 | | return true; 1370 | | } 1371 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1367 | if !self.config.ninja_in_file && self.config.build.contains("msvc") && cmd_finder.maybe_have("ninja").is_some() { 1368 | return true; 1369 | } | warning: calling `push_str()` using a single-character string literal --> src/bootstrap/builder.rs:1503:13 | 1503 | self.0.push_str(" "); | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.0.push(' ')` | = note: `#[warn(clippy::single_char_push_str)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: transmute from a reference to a reference --> src/bootstrap/cache.rs:110:18 | 110 | unsafe { mem::transmute::<&str, &'static str>(l.get(*self)) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(l.get(*self) as *const std::string::String as *const str)` | = note: `#[warn(clippy::transmute_ptr_to_ptr)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: transmute from a reference to a reference --> src/bootstrap/cache.rs:118:18 | 118 | unsafe { mem::transmute::<&Path, &'static Path>(l.get(*self)) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(l.get(*self) as *const std::path::PathBuf as *const std::path::Path)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: transmute from a reference to a reference --> src/bootstrap/cache.rs:125:18 | 125 | unsafe { mem::transmute::<&Path, &'static Path>(l.get(*self)) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(l.get(*self) as *const std::path::PathBuf as *const std::path::Path)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr warning: this `if` has identical blocks --> src/bootstrap/cc_detect.rs:47:42 | 47 | } else if target.contains("openbsd") { | __________________________________________^ 48 | | Some(PathBuf::from("ar")) 49 | | } else if target.contains("vxworks") { | |_____^ | = note: `#[warn(clippy::if_same_then_else)]` on by default note: same as this --> src/bootstrap/cc_detect.rs:45:39 | 45 | } else if target.contains("musl") { | _______________________________________^ 46 | | Some(PathBuf::from("ar")) 47 | | } else if target.contains("openbsd") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: this `if` has identical blocks --> src/bootstrap/cc_detect.rs:47:42 | 47 | } else if target.contains("openbsd") { | __________________________________________^ 48 | | Some(PathBuf::from("ar")) 49 | | } else if target.contains("vxworks") { | |_____^ | note: same as this --> src/bootstrap/cc_detect.rs:45:39 | 45 | } else if target.contains("musl") { | _______________________________________^ 46 | | Some(PathBuf::from("ar")) 47 | | } else if target.contains("openbsd") { | |_____^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else warning: calling `push_str()` using a single-character string literal --> src/bootstrap/channel.rs:77:13 | 77 | version.push_str(" "); | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `version.push(' ')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/bootstrap/channel.rs:79:13 | 79 | version.push_str(")"); | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `version.push(')')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: redundant closure found --> src/bootstrap/clean.rs:53:44 | 53 | do_op(path, "remove file", |p| fs::remove_file(p)); | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `fs::remove_file` | = note: `#[warn(clippy::redundant_closure)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: redundant closure found --> src/bootstrap/clean.rs:60:39 | 60 | do_op(path, "remove dir", |p| fs::remove_dir(p)); | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `fs::remove_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure warning: calling `push_str()` using a single-character string literal --> src/bootstrap/dist.rs:1851:9 | 1851 | license.push_str("\n"); | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `license.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/bootstrap/dist.rs:1852:9 | 1852 | license.push_str("\n"); | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `license.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/bootstrap/dist.rs:1856:9 | 1856 | rtf.push_str("\n"); | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `rtf.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: calling `push_str()` using a single-character string literal --> src/bootstrap/dist.rs:1861:9 | 1861 | rtf.push_str("}"); | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `rtf.push('}')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_push_str warning: used sort instead of sort_unstable to sort primitive type `str` --> src/bootstrap/native.rs:265:13 | 265 | enabled_llvm_projects.sort(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `enabled_llvm_projects.sort_unstable()` | = note: `#[warn(clippy::stable_sort_primitive)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#stable_sort_primitive warning: use of `or_insert` followed by a function call --> src/bootstrap/sanity.rs:166:14 | 166 | .or_insert(Target::from_triple(&target.triple)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Target::from_triple(&target.triple))` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: using `clone` on a `Copy` type --> src/bootstrap/sanity.rs:165:20 | 165 | .entry(target.clone()) | ^^^^^^^^^^^^^^ help: try dereferencing it: `*target` | = note: `#[warn(clippy::clone_on_copy)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: using `clone` on a `Copy` type --> src/bootstrap/sanity.rs:179:63 | 179 | let target = build.config.target_config.entry(target.clone()).or_default(); | ^^^^^^^^^^^^^^ help: try dereferencing it: `*target` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: use of `unwrap_or` followed by a function call --> src/bootstrap/setup.rs:92:25 | 92 | let path = cfg_file.unwrap_or("config.toml".into()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "config.toml".into())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call warning: passing a unit value to a function --> src/bootstrap/setup.rs:198:5 | 198 | / Ok(if should_install { 199 | | let src = src_path.join("src").join("etc").join("pre-commit.sh"); 200 | | let git = t!(Command::new("git").args(&["rev-parse", "--git-common-dir"]).output().map( 201 | | |output| { ... | 216 | | println!("Ok, skipping installation!"); 217 | | }) | |______^ | = note: `#[warn(clippy::unit_arg)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg help: move the expression in front of the call and replace it with the unit literal `()` | 198 | if should_install { 199 | let src = src_path.join("src").join("etc").join("pre-commit.sh"); 200 | let git = t!(Command::new("git").args(&["rev-parse", "--git-common-dir"]).output().map( 201 | |output| { 202 | assert!(output.status.success(), "failed to run `git`"); 203 | PathBuf::from(t!(String::from_utf8(output.stdout)).trim()) ... warning: this function has too many arguments (8/7) --> src/bootstrap/tool.rs:220:1 | 220 | / pub fn prepare_tool_cargo( 221 | | builder: &Builder<'_>, 222 | | compiler: Compiler, 223 | | mode: Mode, ... | 228 | | extra_features: &[String], 229 | | ) -> CargoCommand { | |_________________^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments warning: very complex type used. Consider factoring parts into `type` definitions --> src/bootstrap/lib.rs:270:9 | 270 | RefCell)>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::type_complexity)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity warning: wildcard pattern covers any other pattern as it will match anyway. --> src/bootstrap/lib.rs:1107:13 | 1107 | "nightly" | _ => true, | ^^^^^^^^^^^^^ | = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default = help: Consider handling `_` separately. = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns warning: 29 warnings emitted Finished release [optimized] target(s) in 0.11s Build completed successfully in 0:00:01