Skip to content

Commit fe86dcf

Browse files
committed
Delete pretty printer tracing
1 parent 9ad5d82 commit fe86dcf

File tree

3 files changed

+0
-54
lines changed

3 files changed

+0
-54
lines changed

Diff for: Cargo.lock

-1
Original file line numberDiff line numberDiff line change
@@ -3433,7 +3433,6 @@ version = "0.0.0"
34333433
dependencies = [
34343434
"rustc_ast",
34353435
"rustc_span",
3436-
"tracing",
34373436
]
34383437

34393438
[[package]]

Diff for: compiler/rustc_ast_pretty/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@ edition = "2021"
77
doctest = false
88

99
[dependencies]
10-
tracing = "0.1"
1110
rustc_span = { path = "../rustc_span" }
1211
rustc_ast = { path = "../rustc_ast" }

Diff for: compiler/rustc_ast_pretty/src/pp.rs

-52
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ use ring::RingBuffer;
138138
use std::borrow::Cow;
139139
use std::collections::VecDeque;
140140
use std::fmt;
141-
use tracing::debug;
142141

143142
/// How to break. Described in more detail in the module docs.
144143
#[derive(Clone, Copy, PartialEq)]
@@ -193,22 +192,6 @@ impl fmt::Display for Token {
193192
}
194193
}
195194

196-
fn buf_str(buf: &RingBuffer<BufEntry>, left: usize, right: usize, lim: usize) -> String {
197-
let mut i = left;
198-
let mut l = lim;
199-
let mut s = String::from("[");
200-
while i != right && l != 0 {
201-
l -= 1;
202-
if i != left {
203-
s.push_str(", ");
204-
}
205-
s.push_str(&format!("{}={}", buf[i].size, &buf[i].token));
206-
i += 1;
207-
}
208-
s.push(']');
209-
s
210-
}
211-
212195
#[derive(Copy, Clone)]
213196
enum PrintStackBreak {
214197
Fits,
@@ -267,7 +250,6 @@ impl Default for BufEntry {
267250
impl Printer {
268251
pub fn new() -> Self {
269252
let linewidth = 78;
270-
debug!("Printer::new {}", linewidth);
271253
let mut buf = RingBuffer::new();
272254
buf.advance_right();
273255
Printer {
@@ -310,16 +292,13 @@ impl Printer {
310292
} else {
311293
self.advance_right();
312294
}
313-
debug!("pp Begin({})/buffer Vec<{},{}>", b.offset, self.left, self.right);
314295
self.scan_push(BufEntry { token: Token::Begin(b), size: -self.right_total });
315296
}
316297

317298
fn scan_end(&mut self) {
318299
if self.scan_stack.is_empty() {
319-
debug!("pp End/print Vec<{},{}>", self.left, self.right);
320300
self.print_end();
321301
} else {
322-
debug!("pp End/buffer Vec<{},{}>", self.left, self.right);
323302
self.advance_right();
324303
self.scan_push(BufEntry { token: Token::End, size: -1 });
325304
}
@@ -334,18 +313,15 @@ impl Printer {
334313
} else {
335314
self.advance_right();
336315
}
337-
debug!("pp Break({})/buffer Vec<{},{}>", b.offset, self.left, self.right);
338316
self.check_stack(0);
339317
self.scan_push(BufEntry { token: Token::Break(b), size: -self.right_total });
340318
self.right_total += b.blank_space;
341319
}
342320

343321
fn scan_string(&mut self, s: Cow<'static, str>) {
344322
if self.scan_stack.is_empty() {
345-
debug!("pp String('{}')/print Vec<{},{}>", s, self.left, self.right);
346323
self.print_string(s);
347324
} else {
348-
debug!("pp String('{}')/buffer Vec<{},{}>", s, self.left, self.right);
349325
self.advance_right();
350326
let len = s.len() as isize;
351327
self.buf[self.right] = BufEntry { token: Token::String(s), size: len };
@@ -355,18 +331,8 @@ impl Printer {
355331
}
356332

357333
fn check_stream(&mut self) {
358-
debug!(
359-
"check_stream Vec<{}, {}> with left_total={}, right_total={}",
360-
self.left, self.right, self.left_total, self.right_total
361-
);
362334
if self.right_total - self.left_total > self.space {
363-
debug!(
364-
"scan window is {}, longer than space on line ({})",
365-
self.right_total - self.left_total,
366-
self.space
367-
);
368335
if Some(&self.left) == self.scan_stack.back() {
369-
debug!("setting {} to infinity and popping", self.left);
370336
let scanned = self.scan_pop_bottom();
371337
self.buf[scanned].size = SIZE_INFINITY;
372338
}
@@ -378,7 +344,6 @@ impl Printer {
378344
}
379345

380346
fn scan_push(&mut self, entry: BufEntry) {
381-
debug!("scan_push {}", self.right);
382347
self.buf[self.right] = entry;
383348
self.scan_stack.push_front(self.right);
384349
}
@@ -401,11 +366,6 @@ impl Printer {
401366
}
402367

403368
fn advance_left(&mut self) {
404-
debug!(
405-
"advance_left Vec<{},{}>, sizeof({})={}",
406-
self.left, self.right, self.left, self.buf[self.left].size
407-
);
408-
409369
let mut left_size = self.buf[self.left].size;
410370

411371
while left_size >= 0 {
@@ -465,14 +425,12 @@ impl Printer {
465425
}
466426

467427
fn print_newline(&mut self, amount: isize) {
468-
debug!("NEWLINE {}", amount);
469428
self.out.push('\n');
470429
self.pending_indentation = 0;
471430
self.indent(amount);
472431
}
473432

474433
fn indent(&mut self, amount: isize) {
475-
debug!("INDENT {}", amount);
476434
self.pending_indentation += amount;
477435
}
478436

@@ -485,40 +443,33 @@ impl Printer {
485443
fn print_begin(&mut self, b: BeginToken, l: isize) {
486444
if l > self.space {
487445
let col = self.margin - self.space + b.offset;
488-
debug!("print Begin -> push broken block at col {}", col);
489446
self.print_stack
490447
.push(PrintStackElem { offset: col, pbreak: PrintStackBreak::Broken(b.breaks) });
491448
} else {
492-
debug!("print Begin -> push fitting block");
493449
self.print_stack.push(PrintStackElem { offset: 0, pbreak: PrintStackBreak::Fits });
494450
}
495451
}
496452

497453
fn print_end(&mut self) {
498-
debug!("print End -> pop End");
499454
self.print_stack.pop().unwrap();
500455
}
501456

502457
fn print_break(&mut self, b: BreakToken, l: isize) {
503458
let top = self.get_top();
504459
match top.pbreak {
505460
PrintStackBreak::Fits => {
506-
debug!("print Break({}) in fitting block", b.blank_space);
507461
self.space -= b.blank_space;
508462
self.indent(b.blank_space);
509463
}
510464
PrintStackBreak::Broken(Breaks::Consistent) => {
511-
debug!("print Break({}+{}) in consistent block", top.offset, b.offset);
512465
self.print_newline(top.offset + b.offset);
513466
self.space = self.margin - (top.offset + b.offset);
514467
}
515468
PrintStackBreak::Broken(Breaks::Inconsistent) => {
516469
if l > self.space {
517-
debug!("print Break({}+{}) w/ newline in inconsistent", top.offset, b.offset);
518470
self.print_newline(top.offset + b.offset);
519471
self.space = self.margin - (top.offset + b.offset);
520472
} else {
521-
debug!("print Break({}) w/o newline in inconsistent", b.blank_space);
522473
self.indent(b.blank_space);
523474
self.space -= b.blank_space;
524475
}
@@ -528,7 +479,6 @@ impl Printer {
528479

529480
fn print_string(&mut self, s: Cow<'static, str>) {
530481
let len = s.len() as isize;
531-
debug!("print String({})", s);
532482
// assert!(len <= space);
533483
self.space -= len;
534484

@@ -545,8 +495,6 @@ impl Printer {
545495
}
546496

547497
fn print(&mut self, token: Token, l: isize) {
548-
debug!("print {} {} (remaining line space={})", token, l, self.space);
549-
debug!("{}", buf_str(&self.buf, self.left, self.right, 6));
550498
match token {
551499
Token::Begin(b) => self.print_begin(b, l),
552500
Token::End => self.print_end(),

0 commit comments

Comments
 (0)