Skip to content

Commit fab6814

Browse files
jshaGuillaumeGomez
authored andcommitted
Remove data-level selectors from CSS.
1 parent 98a9b02 commit fab6814

File tree

3 files changed

+20
-82
lines changed

3 files changed

+20
-82
lines changed

src/librustdoc/html/render/mod.rs

+6-10
Original file line numberDiff line numberDiff line change
@@ -1371,7 +1371,7 @@ fn render_impl(
13711371
.map(|item| format!("{}.{}", item.type_(), name));
13721372
write!(
13731373
w,
1374-
"<div id=\"{}\" class=\"{}{}\" data-level=\"2\">",
1374+
"<div id=\"{}\" class=\"{}{} has-srclink\">",
13751375
id, item_type, in_trait_class,
13761376
);
13771377
w.write_str("<code>");
@@ -1400,7 +1400,7 @@ fn render_impl(
14001400
let id = cx.derive_id(source_id.clone());
14011401
write!(
14021402
w,
1403-
"<div id=\"{}\" class=\"{}{}\" data-level=\"2\"><code>",
1403+
"<div id=\"{}\" class=\"{}{} has-srclink\"><code>",
14041404
id, item_type, in_trait_class
14051405
);
14061406
assoc_type(
@@ -1421,7 +1421,7 @@ fn render_impl(
14211421
let id = cx.derive_id(source_id.clone());
14221422
write!(
14231423
w,
1424-
"<div id=\"{}\" class=\"{}{}\" data-level=\"2\"><code>",
1424+
"<div id=\"{}\" class=\"{}{} has-srclink\"><code>",
14251425
id, item_type, in_trait_class
14261426
);
14271427
assoc_const(
@@ -1448,11 +1448,7 @@ fn render_impl(
14481448
clean::AssocTypeItem(ref bounds, ref default) => {
14491449
let source_id = format!("{}.{}", item_type, name);
14501450
let id = cx.derive_id(source_id.clone());
1451-
write!(
1452-
w,
1453-
"<div id=\"{}\" class=\"{}{}\" data-level=\"2\"><code>",
1454-
id, item_type, in_trait_class,
1455-
);
1451+
write!(w, "<div id=\"{}\" class=\"{}{}\"><code>", id, item_type, in_trait_class,);
14561452
assoc_type(
14571453
w,
14581454
item,
@@ -1593,7 +1589,7 @@ fn render_impl(
15931589
if let Some(use_absolute) = use_absolute {
15941590
write!(
15951591
w,
1596-
"{}<div id=\"{}\" class=\"impl\"{} data-level=\"1\">\
1592+
"{}<div id=\"{}\" class=\"impl has-srclink\"{}>\
15971593
<code class=\"in-band\">",
15981594
open_details(&mut close_tags, is_implementing_trait),
15991595
id,
@@ -1621,7 +1617,7 @@ fn render_impl(
16211617
} else {
16221618
write!(
16231619
w,
1624-
"{}<div id=\"{}\" class=\"impl\"{} data-level=\"1\">\
1620+
"{}<div id=\"{}\" class=\"impl has-srclink\"{}>\
16251621
<code class=\"in-band\">{}</code>",
16261622
open_details(&mut close_tags, is_implementing_trait),
16271623
id,

src/librustdoc/html/render/print_item.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ fn item_trait(w: &mut Buffer, cx: &Context<'_>, it: &clean::Item, t: &clean::Tra
585585
if toggled {
586586
write!(w, "<details class=\"rustdoc-toggle\" open><summary>");
587587
}
588-
write!(w, "<div id=\"{}\" class=\"method\" data-level=\"1\"><code>", id);
588+
write!(w, "<div id=\"{}\" class=\"method has-srclink\"><code>", id);
589589
render_assoc_item(w, m, AssocItemLink::Anchor(Some(&id)), ItemType::Impl, cx);
590590
w.write_str("</code>");
591591
render_stability_since(w, m, t, cx.tcx());

src/librustdoc/html/static/rustdoc.css

+13-71
Original file line numberDiff line numberDiff line change
@@ -137,19 +137,19 @@ h1.fqn > .in-band > a:hover {
137137
h2, h3, h4 {
138138
border-bottom: 1px solid;
139139
}
140-
div[data-level="1"].impl, div[data-level="1"].method, div[data-level="2"].method,
141-
div[data-level="1"].type, div[data-level="2"].type, div[data-level="2"].associatedconstant,
142-
div[data-level="2"].associatedtype {
140+
.impl, .method,
141+
.type, .associatedconstant,
142+
.associatedtype {
143143
flex-basis: 100%;
144144
font-weight: 600;
145145
margin-top: 16px;
146146
margin-bottom: 10px;
147147
position: relative;
148148
}
149-
div[data-level="1"].impl, div[data-level="1"].method, div[data-level="2"].method.trait-impl,
150-
div[data-level="1"].type, div[data-level="2"].type.trait-impl,
151-
div[data-level="2"].associatedconstant.trait-impl,
152-
div[data-level="2"].associatedtype.trait-impl {
149+
.impl, .method.trait-impl,
150+
.type.trait-impl,
151+
.associatedconstant.trait-impl,
152+
.associatedtype.trait-impl {
153153
padding-left: 15px;
154154
}
155155

@@ -160,7 +160,7 @@ div.impl-items > div {
160160
h1, h2, h3, h4,
161161
.sidebar, a.source, .search-input, .search-results .result-name,
162162
.content table td:first-child > a,
163-
.collapse-toggle, div.item-list .out-of-band, span.since,
163+
div.item-list .out-of-band, span.since,
164164
#source-sidebar, #sidebar-toggle,
165165
details.rustdoc-toggle > summary::before,
166166
details.undocumented > summary::before,
@@ -467,15 +467,7 @@ nav.sub {
467467
font-weight: normal;
468468
}
469469

470-
div[data-level="1"].impl > .out-of-band {
471-
font-size: 21px;
472-
}
473-
474-
div[data-level="2"].method > .out-of-band {
475-
font-size: 19px;
476-
}
477-
478-
div[data-level="1"] > code, div[data-level="2"] > code, .invisible > code {
470+
.method > code, .trait-impl > code, .invisible > code {
479471
max-width: calc(100% - 41px);
480472
display: block;
481473
}
@@ -548,7 +540,7 @@ div[data-level="1"] > code, div[data-level="2"] > code, .invisible > code {
548540
}
549541
.content .multi-column li { width: 100%; display: inline-block; }
550542

551-
.content > div.methods > div.method {
543+
.content > .methods > .method {
552544
font-size: 1em;
553545
position: relative;
554546
}
@@ -569,9 +561,6 @@ div[data-level="1"] > code, div[data-level="2"] > code, .invisible > code {
569561
margin-left: 20px;
570562
margin-top: -34px;
571563
}
572-
.content .docblock > .impl-items > div[data-level="2"] {
573-
border-bottom: 0;
574-
}
575564
.content .docblock >.impl-items .table-display {
576565
margin: 0;
577566
}
@@ -694,7 +683,7 @@ a {
694683
}
695684

696685
.invisible > .srclink,
697-
div[data-level="1"] > code + .srclink, div[data-level="2"] > code + .srclink {
686+
.method > code + .srclink {
698687
position: absolute;
699688
top: 0;
700689
right: 0;
@@ -929,8 +918,7 @@ body.blur > :not(#help) {
929918
flex-grow: 1;
930919
}
931920

932-
.impl-items div[data-level="2"], div[data-level="2"].impl, div[data-level="1"].impl,
933-
.methods div[data-level="1"] {
921+
.has-srclink {
934922
display: flex;
935923
flex-basis: 100%;
936924
font-size: 16px;
@@ -992,45 +980,6 @@ a.test-arrow:hover{
992980
font-weight: 300;
993981
}
994982

995-
.collapse-toggle {
996-
font-weight: 300;
997-
position: absolute;
998-
left: -23px;
999-
top: 0;
1000-
}
1001-
1002-
div[data-level="1"] > .collapse-toggle, div[data-level="2"] > .collapse-toggle {
1003-
font-size: 0.8em;
1004-
top: 5px;
1005-
}
1006-
1007-
.toggle-wrapper > .collapse-toggle {
1008-
left: -24px;
1009-
margin-top: 0px;
1010-
}
1011-
1012-
.toggle-wrapper {
1013-
position: relative;
1014-
margin-top: 0;
1015-
}
1016-
1017-
.toggle-wrapper.collapsed {
1018-
height: 25px;
1019-
transition: height .2s;
1020-
margin-bottom: .6em;
1021-
}
1022-
1023-
.collapse-toggle > .inner {
1024-
display: inline-block;
1025-
width: 1.2ch;
1026-
text-align: center;
1027-
}
1028-
1029-
.collapse-toggle.hidden-default {
1030-
position: relative;
1031-
margin-left: 20px;
1032-
}
1033-
1034983
.since + .srclink {
1035984
display: table-cell;
1036985
padding-left: 10px;
@@ -1241,9 +1190,6 @@ pre.rust {
12411190
cursor: pointer;
12421191
z-index: 2;
12431192
margin-left: 5px;
1244-
}
1245-
1246-
div[data-level="2"] > .notable-traits {
12471193
position: absolute;
12481194
left: -44px;
12491195
top: 2px;
@@ -1661,10 +1607,6 @@ details.undocumented[open] > summary::before {
16611607
padding: 0;
16621608
}
16631609

1664-
.content div[data-level="2"] > .out-of-band {
1665-
position: inherit;
1666-
}
1667-
16681610
#search {
16691611
margin-left: 0;
16701612
}
@@ -1684,7 +1626,7 @@ details.undocumented[open] > summary::before {
16841626
z-index: 1;
16851627
}
16861628

1687-
div[data-level="2"] > .notable-traits {
1629+
.notable-traits {
16881630
position: absolute;
16891631
left: -22px;
16901632
top: 24px;

0 commit comments

Comments
 (0)