Skip to content

Commit f87afe5

Browse files
author
hyd-dev
committed
Extend the comment of check_toolstate() to clarify that the tool won't be shipped on all targets
1 parent f82315a commit f87afe5

File tree

1 file changed

+4
-1
lines changed
  • src/tools/build-manifest/src

1 file changed

+4
-1
lines changed

Diff for: src/tools/build-manifest/src/main.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,10 @@ impl Builder {
254254
t!(self.checksums.store_cache());
255255
}
256256

257-
/// If a tool does not pass its tests, don't ship it.
257+
/// If a tool does not pass its tests on *any* of Linux and Windows, don't ship
258+
/// it on *all* targets, because tools like Miri can "cross-run" programs for
259+
/// different targets, for example, run a program for `x86_64-pc-windows-msvc`
260+
/// on `x86_64-unknown-linux-gnu`.
258261
/// Right now, we do this only for Miri.
259262
fn check_toolstate(&mut self) {
260263
for file in &["toolstates-linux.json", "toolstates-windows.json"] {

0 commit comments

Comments
 (0)