Skip to content

Commit f82fefd

Browse files
authored
Rollup merge of #117982 - cuviper:quiet-pgo, r=onur-ozkan
bootstrap: only show PGO warnings when verbose Building rustc with `--rust-profile-use` is currently dumping a lot of warnings of "no profile data available for function" from `rustc_smir` and `stable_mir`. These simply aren't exercised by the current profile- gathering steps, but that's to be expected for new or experimental functionality. I think for most people, these warnings will be just noise, so it makes sense to only have them in verbose builds.
2 parents 7437151 + 776146e commit f82fefd

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/bootstrap/src/core/build_steps/compile.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,9 @@ impl Step for Rustc {
887887
} else if let Some(path) = &builder.config.rust_profile_use {
888888
if compiler.stage == 1 {
889889
cargo.rustflag(&format!("-Cprofile-use={path}"));
890-
cargo.rustflag("-Cllvm-args=-pgo-warn-missing-function");
890+
if builder.is_verbose() {
891+
cargo.rustflag("-Cllvm-args=-pgo-warn-missing-function");
892+
}
891893
true
892894
} else {
893895
false

0 commit comments

Comments
 (0)