Nicer error message when using raw-dylib

bjorn3 · bjorn3 · commit f5c3195e92d4 · 2024-07-13T13:53:14.000Z
cc rust-lang/rustc_codegen_cranelift#1510
diff --git a/src/archive.rs b/src/archive.rs
@@ -14,12 +14,12 @@ impl ArchiveBuilderBuilder for ArArchiveBuilderBuilder {
 
     fn create_dll_import_lib(
         &self,
-        _sess: &Session,
+        sess: &Session,
         _lib_name: &str,
         _dll_imports: &[rustc_session::cstore::DllImport],
         _tmpdir: &Path,
         _is_direct_dependency: bool,
     ) -> PathBuf {
-        unimplemented!("creating dll imports is not yet supported");
+        sess.dcx().fatal("raw-dylib is not yet supported by rustc_codegen_cranelift");
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,12 @@ impl ArchiveBuilderBuilder for ArArchiveBuilderBuilder {`
`14`	`14`
`15`	`15`	`fn create_dll_import_lib(`
`16`	`16`	`&self,`
`17`		`- _sess: &Session,`
	`17`	`+ sess: &Session,`
`18`	`18`	`_lib_name: &str,`
`19`	`19`	`_dll_imports: &[rustc_session::cstore::DllImport],`
`20`	`20`	`_tmpdir: &Path,`
`21`	`21`	`_is_direct_dependency: bool,`
`22`	`22`	`) -> PathBuf {`
`23`		`- unimplemented!("creating dll imports is not yet supported");`
	`23`	`+ sess.dcx().fatal("raw-dylib is not yet supported by rustc_codegen_cranelift");`
`24`	`24`	`}`
`25`	`25`	`}`