Fix compiler panic with a large number of threads

practicalrs · practicalrs · commit ef30dab782a9 · 2024-10-30T16:45:57.000+01:00
diff --git a/compiler/rustc_session/src/options.rs b/compiler/rustc_session/src/options.rs
@@ -663,7 +663,9 @@ mod parse {
                 true
             }
             Some(i) => {
-                *slot = i;
+                // We want to cap the number of threads here to avoid large numbers like 999999 and compiler panics.
+                // This solution was suggested here https://github.com/rust-lang/rust/issues/117638#issuecomment-1800925067
+                *slot = i.min(256);
                 true
             }
             None => false,

Original file line number	Diff line number	Diff line change
`@@ -663,7 +663,9 @@ mod parse {`
`663`	`663`	`true`
`664`	`664`	`}`
`665`	`665`	`Some(i) => {`
`666`		`- *slot = i;`
	`666`	`+ // We want to cap the number of threads here to avoid large numbers like 999999 and compiler panics.`
	`667`	`+ // This solution was suggested here https://github.com/rust-lang/rust/issues/117638#issuecomment-1800925067`
	`668`	`+ *slot = i.min(256);`
`667`	`669`	`true`
`668`	`670`	`}`
`669`	`671`	`None => false,`